[Bug 30737] New: Dde_OnRequest should return groups_data instead of NULL

http://bugs.winehq.org/show_bug.cgi?id=30737

Bug #: 30737
           Summary: Dde_OnRequest should return groups_data instead of
                    NULL
           Product: Wine
           Version: 1.5.4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 40241
  --> http://bugs.winehq.org/attachment.cgi?id=40241
patch v1

The setup32.exe of EG (Evangelisches Gesangbuch) fail before end of setup. The
reason is on unxpected result on DdeClientTransaction. The second reason is
probably programming error of this app.
The app works as fallow:
- DdeCreateStringHandleA with "Progman"
- then DdeClientTransaction with hszItem == Pragman and hszTopic == Pragman.
- after this it parses the data returned by previous command.
at this stage it will try to parse NULL pointer and fail. At this point i would
say, it is an app problem. But it works on windows and looks like it returns
NULL in really rare cases.

Currently i did some hacky patch wich return empty group data. It fixes crash
issue on the end of setup.

[Bug 30737] Dde_OnRequest should return groups_data instead of NULL

http://bugs.winehq.org/show_bug.cgi?id=30737

--- Comment #1 from Alexey Fisher  2012-05-20 15:50:29 CDT ---
If you wont to know what this app get on windows instead of empty list or NULL.
Here are some debug results:

this list it get on first request:
EAX=00151634, (ASCII "Accessories
Google Chrome Startup Accessories Administrative Tools Eg Games Logitech
Microsoft Silverlight Startup")

This on second:
EAX=0014E354, (ASCII
""Accessories",C:\DOCUME~1\iii\STARTM~1\Programs\ACCESS~1,6,1,0
"Windows
Explorer","C:\WINDOWS\explorer.exe",%HOMEDRIVE%%HOMEPATH%,%SystemRoot%\explorer.exe,352,32,1,0,0
"Tour Windows XP","C:\WINDOWS\system32\TOURST~1.EXE",%HOMEDRI)

and on third:
EAX=0014E354, (ASCII ""Google
Chrome",C:\DOCUME~1\iii\STARTM~1\Programs\GOOGLE~1,2,1,0
"Google
Chrome","C:\DOCUME~1\iii\LOCALS~1\APPLIC~1\Google\Chrome\APPLIC~1\chrome.exe",C:\DOCUME~1\iii\LOCALS~1\APPLIC~1\Google\Chrome\APPLIC~1,C:\DOCUME~1\iii\LOCALS~)

it makes no sense to post more results. With this patch i avoid to make second
request. Because first list is empty.

[Bug 30737] Dde_OnRequest should return groups_data instead of NULL

http://bugs.winehq.org/show_bug.cgi?id=30737

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Jerome Leclanche  2013-08-26 06:19:47 CDT ---
Is this still an issue in current wine? if it is, are you willing to work on a
proper patch to send?

[Bug 30737] Dde_OnRequest should return groups_data instead of NULL

http://bugs.winehq.org/show_bug.cgi?id=30737

--- Comment #3 from Oleksij Rempel  2013-08-27 03:55:58 CDT ---
It is still present.

Right now i need to work on linux kernel drivers, so no really lots of time for
deep diving in to wine :)
What do you mean by proper patch? Git ready, or real fix? Suddenly i do not
know how it actually should be solved.

[Bug 30737] Dde_OnRequest should return groups_data instead of NULL

https://bugs.winehq.org/show_bug.cgi?id=30737

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |83196d0cb3dedd00254d13e3be9
                   |                            |a8be7f2f8eb1d
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Bruno Jesus  ---
The original problem in this bug was fixed long ago with the patch from comment
0 being commited.
http://source.winehq.org/git/wine.git/commit/83196d0c

[Bug 30737] Dde_OnRequest should return groups_data instead of NULL

https://bugs.winehq.org/show_bug.cgi?id=30737

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.31.