[Bug 28578] New: Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Bug #: 28578
           Summary: Editing a wiki page strips out carriage returns from
                    all preformatted text on that page
           Product: WineHQ.org
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: www-unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

This most recently happened with the Regression Testing page (bug 28575), but
I've seen it before on other pages: carriage returns are removed from
preformatted text, even if that part is not edited directly, and the
preformatted text turns into an unreadable mess. It used to be possible to
avoid this by staying in GUI mode and not previewing, but that seems to no
longer work.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #1 from Rosanne DiMesio  2012-01-07 09:28:56 CST ---
Still an issue. This makes editing wiki pages that contain a lot of
preformatted sections (e.g., the FAQ and RegressionTesting) very difficult:
every time you edit those pages you have to go into text mode and manually put
back every single carriage return in every preformatted section on the page.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Frédéric Delanoy  2012-04-10 09:19:16 CDT ---
(In reply to comment #1)
> Still an issue. This makes editing wiki pages that contain a lot of
> preformatted sections (e.g., the FAQ and RegressionTesting) very difficult:
> every time you edit those pages you have to go into text mode and manually put
> back every single carriage return in every preformatted section on the page.

Actually it would be more than time to perform an upgrade from the antediluvian
moinmoin wiki platform version currently used.

Maybe even another platform since, for instance, moinmoin doesn't allow
previewing of the current changes only (as opposed to full page preview), which
can be really annoying for long pages (e.g. the FAQ). Something like
wikipedia's "view my changes" would be quite helpful.

Of course, that's easier said than done and there may be some glitches in the
transition...

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dan Kegel  2012-07-30 12:18:18 CDT ---
I can't reproduce this.  I went and edited the page in bug 28575,
and it didn't strip any formatting.

I'm using Chrome on Linux; when's the last time this happened, and
what browsers does it happen with?

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #4 from Rosanne DiMesio  2012-07-30 13:14:38 CDT ---
I've always used Firefox, and I just reproduced it on the FAQ page in Firefox
14 on Linux. All I did was open the page in Edit mode, then click "Save
changes"--I didn't even MAKE any changes, but the preformatted sections that
have more than one line are now a mess. I've left it that way for you to see;
it will need to be reverted shortly.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #5 from Rosanne DiMesio  2013-07-26 08:30:22 CDT ---
I am still encountering this in Firefox 21 & 22, and I tested in a clean
profile (no extensions) on both openSUSE 12.3 and Linux Mint 15.

This can be tested on the Wiki Sand Box page. There's a preformatted section
under Formatting that reads

preformatted some more
and some more lines too

The line break is stripped out when I save the page, even if I have made no
edits. Not only that, but everything on that page below IRC Log Test is also
gone.

As for other browsers, Opera, Chrome, Chromium, and Konqueror all show raw text
in the edit window when I try to edit any page, and trying to preview or save
(even if I made no actual changes) from any of these browsers results in the
same error message:

ExpatError: mismatched tag: line 389, column 1341 (see dump in
/var/www/wine/wiki/data/expaterror.log)

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #6 from Rosanne DiMesio  2013-07-26 08:35:00 CDT ---
Created attachment 45404
  --> http://bugs.winehq.org/attachment.cgi?id=45404
Python error log from Opera

Attaching the full error log from hitting Preview in Opera. The same error
happens with Chrome, Chromium, and Konqueror.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #7 from Dan Kegel  2013-08-02 09:34:41 CDT ---
I can't reproduce this with chrome 28.0.1500.71 on linux.

Have you tried exorcism?

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #8 from Rosanne DiMesio  2013-08-02 15:58:24 CDT ---
Created attachment 45491
  --> http://bugs.winehq.org/attachment.cgi?id=45491
Chrome edit wiki screenshot

Here's what I see when I try to edit the wiki sandbox page in Chrome
28.0.1500.71 on openSUSE 12.3. If I click any of the buttons at the top except
Cancel I get the same python error as in Opera.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #9 from Frédéric Delanoy  2013-08-04 03:16:20 CDT ---
(In reply to comment #8)
> Created attachment 45491 [details]
> Chrome edit wiki screenshot
>
> Here's what I see when I try to edit the wiki sandbox page in Chrome
> 28.0.1500.71 on openSUSE 12.3. If I click any of the buttons at the top except
> Cancel I get the same python error as in Opera.

Can't reproduce in Chromium 28.0.1500.71, Opera 12.16, Firefox 23
(did also try with elinks but can't edit the text ;) )

Do you have the same issue with all of your browsers?

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #10 from Rosanne DiMesio  2013-08-04 07:16:10 CDT ---
Chrome, Chromium, Opera, and Konqueror all give me the same non-GUI display in
the GUI editor as in the screenshot, and the buttons don't work (except for
cancel).

The GUI editor mostly works in Firefox and SeaMonkey, except for the problem of
stripping out carriage returns in preformatted text when I save, and as I've
now discovered, dropping tables. The tables at the bottom of the wiki sandbox
page don't display in the GUI editor--I'll post a screenshot of that.

I tested this on two distros (openSUSE and Linux Mint), installed on different
machines.

Since the two of you can't reproduce this: is there something (library,
extension) you can think of that a developer would normally have installed on
their system (and take for granted) that a non-developer might not?

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #11 from Rosanne DiMesio  2013-08-04 07:21:44 CDT ---
Created attachment 45501
  --> http://bugs.winehq.org/attachment.cgi?id=45501
Screenshot of GUI editor in Firefox

This is a screenshot of the bottom of the wiki sand box page in the GUI editor
in Firefox 21 (but it's been the same for every previous version). You can see
the bottom of the first table, which does display correctly, but the two that
follow just show the yellow highlighted wiki markup. All the tables disappear
if I save the page in Firefox.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Kyle Auble  2013-08-04 22:55:12 CDT ---
I can confirm this (using Firefox 22 on Ubuntu 12.04). After fiddling with the
editor a little on the WikiSandBox, it's specifically a problem in the GUI
editor so as long as you stick to the text editor you'll be OK.

It looks like in the version of MoinMoin (1.5) we're using, the GUI editor
reads in carriage returns to display everything correctly, but then only keeps
HTML/macro line breaks. Definitely not a great moment in usability:
http://moinmo.in/MoinMoinBugs/GuiEditorLineBreak. I think the reason the
preview cuts off at the IRC section is because IRC logs have their own parser
that especially freaks out when it can't find newlines. That's when the preview
function throws in the towel.

For a moment I worried it was something to do with our CSS white-space settings
in "pre" blocks, but we definitely have it set to keep line breaks. So long
story short, it looks like as long as we're on MoinMoin v1.5, we're stuck with
either the text editor or having to redo every line break in the GUI. I don't
know if Dimi Paun's subscribed to this report with a current email address, but
he's the one to contact about upgrading MoinMoin.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #13 from Dan Kegel  2013-08-04 23:00:10 CDT ---
There's a GUI editor?  Seriously, I never use those in wikis, they break far
too often.

[Bug 28578] Editing a wiki page strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #14 from Frédéric Delanoy  2013-08-05 03:36:04 CDT ---
Rosanne, did you use GUI mode?

I always use text mode and have never seen the issue, but the GUI mode triggers
the issue indeed.

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |UPSTREAM
            Summary|Editing a wiki page strips  |Wiki GUI editor strips out
                   |out carriage returns from   |carriage returns from all
                   |all preformatted text on    |preformatted text on that
                   |that page                   |page

--- Comment #15 from Rosanne DiMesio  2013-08-05 08:17:47 CDT ---
Um, yeah, I did mention "staying in GUI mode" in the bug description, comment 1
mentions having "to go into text mode" (i.e., I must have been in GUI mode),
and the two screenshots I posted were of the GUI editor.

(Hitting self in head.)

My account was set to default to GUI mode, so the bug was triggered as soon as
I opened the editor. It didn't occur to me until Dan denied knowledge of the
existence of a GUI editor that I could change that. I did, and that does enable
me to avoid the carriage return bug at the expense of not being able to see
what the page will look like until it's saved. (Still a bug, but easier to live
with). It also turns out to be the reason editing was completely broken for me
in Chrome, Opera, etc. The text editor does work in those browsers if you start
in text mode, but the GUI editor is so broken you can't switch to text mode
once you're in it.

I'm editing the summary and setting this to UPSTREAM based on comment 12.

Thanks for pointing out the obvious. :-)

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #16 from Dan Kegel  2013-08-05 08:55:14 CDT ---
Not obvious to me!  Maybe the right action is to disable the gui editor.

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #17 from Frédéric Delanoy  2013-08-05 11:37:46 CDT ---
(In reply to comment #15)
> My account was set to default to GUI mode, so the bug was triggered as soon as
> I opened the editor. It didn't occur to me until Dan denied knowledge of the
> existence of a GUI editor that I could change that. I did, and that does enable
> me to avoid the carriage return bug at the expense of not being able to see
> what the page will look like until it's saved.

Doesn't the "Preview" button work for you?

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

http://bugs.winehq.org/show_bug.cgi?id=28578

--- Comment #18 from Rosanne DiMesio  2013-08-05 17:56:32 CDT ---
(In reply to comment #17)
> Doesn't the "Preview" button work for you?

It does now, with my account set to open in text mode (should have actually
tested more thoroughly before I posted). I remember in the past thinking it
triggered the carriage return bug,  but in retrospect, it was probably opening
in the GUI editor that was doing it.

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

https://bugs.winehq.org/show_bug.cgi?id=28578

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

https://bugs.winehq.org/show_bug.cgi?id=28578

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Rosanne DiMesio  ---
We've moved to MediaWiki and this no longer matters, so closing.

[Bug 28578] Wiki GUI editor strips out carriage returns from all preformatted text on that page

https://bugs.winehq.org/show_bug.cgi?id=28578

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |