[Bug 16126] New: Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Summary: Keyboard keys displaced one position to left
           Product: Wine
           Version: 1.1.5
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: directx-dinput
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello,

I am using wine 1.1.5 on my Debian Sid (amd64) and a X1650 ATI Card (fglrx:
8-10, xserver 1.4.2).

I am just playing Max Payne 1 and CS 1.6 (with Steam).
In the game menues (steam, configuration etc) everything is fine, but ingame in
those games the whole keys on the lower keyboard are displaced by one position
to left.

So on x becomes y, n becomes b, ',' becomes m, etc.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

--- Comment #1 from Austin English   2008-11-19 16:19:58 ---
Not critical.

What is your keyboard layout?

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Patrick Matthäi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Patrick Matthäi   2008-11-19 16:31:34 ---
Here in X11 it is the following:

Identifier  "Generic Keyboard"
        Driver      "kbd"             
        Option      "XkbRules" "xorg" 
        Option      "XkbModel" "pc105"
        Option      "XkbLayout" "de"  
        Option      "XkbVariant" "nodeadkeys"

So on german layout.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #3 from Austin English   2008-11-19 18:14:01 ---
Does this happen in all applications? How about notepad?

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
          Component|directx-dinput              |winex11.drv

--- Comment #4 from Vitaliy Margolen   2008-11-19 19:39:20 ---
Can you try US keyboard layout?. I doubt it's dinput, most likely new code that
queries X for the key name/code/scan code.

So this might mean wrong layout table in either your X or Wine's X11.drv

Besides CS (as all other Valve games) don't use dinput at all.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #5 from Patrick Matthäi   2008-11-20 08:03:25 ---
Yeah that it is!

I switched XkbLayout to us and it worked in CS, anyway this is surely no
solution for me :p

But no, notepad works as it should.
The only games I have are Max Payne 1 and CS 1.6 and those are affected.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Vitaliy Margolen   2008-11-30 14:25:33 ---
*** Bug 16167 has been marked as a duplicate of this bug. ***

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Vitaliy Margolen   2008-11-30 14:25:54 ---
Confirming.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #8 from egasimus   2008-11-30 15:22:36 ---
Confirming, too (I posted 16167).
However, they don't seem to be one position to the left. B -> A, but "," -> H,
I -> R, O -> L.

You can use this game:
http://forums.tigsource.com/index.php?topic=3692.0
to get a complete mapping.

I have no keyboard settings in xorg.conf. I alternate between USA and Bulgarian
keyboards using Gnome's layout switcher, and this happens with either.

Change importance to "major"??

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #9 from Vitaliy Margolen   2008-11-30 16:10:26 ---
(In reply to comment #8)
Pleas set US layout and verify that things work properly for you.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Rosanne DiMesio   2008-12-01 20:29:49 ---
(In reply to comment #8)
> I have no keyboard settings in xorg.conf. I alternate between USA and Bulgarian
> keyboards using Gnome's layout switcher, and this happens with either.

Do you mean gxneur?

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #11 from egasimus   2008-12-02 08:25:43 ---
(In reply to comment #10)
> (In reply to comment #8)
> > I have no keyboard settings in xorg.conf. I alternate between USA and Bulgarian
> > keyboards using Gnome's layout switcher, and this happens with either.
>
> Do you mean gxneur?

Nope, just whatever Ubuntu comes with. Not sure what it's called, really.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #12 from el   2009-01-08 17:22:30 ---
This might be somehow related to bug 11122 although that claims to be fixed. I
still have the problem using de(nodeadkeys), for example in Half-Life.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #13 from el   2009-01-08 22:08:53 ---
A little follow-up: I compiled two different versions of wine; one right before
and one right after the patch that led to the closing of bug 11122:
http://source.winehq.org/git/wine.git/?a=commit;h=f151180330bf8a25931d08eda6...

wine 7ea27385171700f3dd7b3fbf84874d47edf64e58 (before the patch):
I am affected by the bug. The bottom row of the keyboard is shifted by one key
in games like Half-Life. The bug can be worked around by changing apostrophe to
acute in the nodeadkeys layout as described in my post at the other bugreport.

wine f151180330bf8a25931d08eda63e385359cec1ce (after the patch):
I am still affected by the bug but it can no longer be avoided by modifying the
keyboard layout.

Which means that the patch that was supposed to fix 11122 only made the
situation worse for me.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #14 from el   2009-01-09 23:44:04 ---
Created an attachment (id=18606)
 --> (http://bugs.winehq.org/attachment.cgi?id=18606)
patch to modify main_key_DE_nodead_105 layout

OK, I tested all the german layouts one by one and found out which one breaks
it for me; it was main_key_DE_nodead_105.

In keyboard.c there is a comment saying "Remember that your 102nd key (to the
right of l-shift) should be on a separate line, see existing tables". The
aforementioned layout is the only german one that did not have the "<>" key on
an extra line.

I moved this key to it's own line and now it's working.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |

--- Comment #15 from Dmitry Timoshkov   2009-01-12 06:08:15 ---
Please send the patch to wine-patches.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #16 from el   2009-01-12 19:55:32 ---
I can't. The patch doesn't really solve the problem. While it fixes the game
controls for me it also breaks other things. For example in Half-Life the key
input in the configurations menu is now shifted by one position. Detailed
effects for Half-Life:

before my patch:
chat        - shifted
config menu - correct
controls    - shifted
console     - correct

after my patch:
chat        - correct
config menu - shifted
controls    - correct
console     - correct

Sidenote:
The console always uses the same keyboard layout that my X uses, but the ingame
chat does not. No matter whether my X layout is set to de or us the ingame chat
will always use an us mapping (i.e. even with my patch pressing y on my german
(qwertz) keyboard creates z in the chat and the other way round). This might be
a Half-Life bug and not a wine bug though.

My xorg.conf:
Section "InputDevice"
    Identifier     "Generic Keyboard"
    Driver         "kbd"
    Option         "CoreKeyboard"
    Option         "XkbRules"     "xorg"
    Option         "XkbModel"     "pc105"
    Option         "XkbLayout"    "de"
    Option         "XkbVariant"   "nodeadkeys"
EndSection

Sidenote2:
Running "setxkbmap -rules xorg -model pc105 -layout de -variant nodeadkeys"
(which, considering my xorg.conf settings, might seem like a no-op) before
running Half-Life actually solves the issue without the need for any patch (but
it only works for the rest of the X session). Same thing happens if I just run
"setxkbmap" (without any arguments).

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #17 from Dmitry Timoshkov   2009-01-12 23:57:58 ---
You also need to patch main_key_vkey_qwertz_105, or rather remove the 105
variant completely since after your patch it matches the main_key_vkey_qwertz
one.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

el  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18606|0                           |1
        is obsolete|                            |

--- Comment #18 from el   2009-01-13 09:42:40 ---
Created an attachment (id=18680)
 --> (http://bugs.winehq.org/attachment.cgi?id=18680)
Remove "German keyboard layout without dead keys 105"

You are correct. Removing the whole layout does indeed solve my problem. Do you
think that removing this layout completely is the right fix for this bug? It
has been there since 2002 and only very few people have reported this problem
with it. Might this change break stuff on other people's keyboard
configurations or other applications?

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

--- Comment #19 from Dmitry Timoshkov   2009-01-13 09:50:02 ---
(In reply to comment #18)
> Created an attachment (id=18680)

--> (http://bugs.winehq.org/attachment.cgi?id=18680) [details]
> Remove "German keyboard layout without dead keys 105"
> You are correct. Removing the whole layout does indeed solve my problem. Do you
> think that removing this layout completely is the right fix for this bug? It
> has been there since 2002 and only very few people have reported this problem
> with it. Might this change break stuff on other people's keyboard
> configurations or other applications?

Yes, I think removing a 105 key version is the right thing to do.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Dmitry Timoshkov   2009-01-21 04:33:57 ---
The patch has been committed.

[Bug 16126] Keyboard keys displaced one position to left

http://bugs.winehq.org/show_bug.cgi?id=16126

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard   2009-01-30 11:04:29 ---
Closing bugs fixed in 1.1.14.