[Bug 51284] New: shell32:shellpath fails on Windows 8.1 when there is more than on CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

Bug ID: 51284
           Summary: shell32:shellpath fails on Windows 8.1 when there is
                    more than on CD drive
           Product: Wine
           Version: 6.10
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]

shell32:shellpath fails on Windows when there is more than on CD drive:

https://test.winehq.org/data/patterns.html#shell32:shellpath

shellpath.c:380: Test failed: Full path
L"C:\Users\winetest\AppData\Local\Microsoft\Windows\Burn\Burn1" does
not end with relative path L"Microsoft\Windows\Burn\Burn"

For now these failures happen on the Windows 8.1 cw-rx460 and cw-gtx560
machines. That's because these machines have both Burn\Burn and Burn\Burn1
folders.

Paradoxically these don't have a CD drive at all. However they are connected to
a KVM which can serve ISOs in the form of a USB CD drive. I suspect that with
ISO changes, connection/disconnections Windows 8.1 ended up thinking there were
two USB CD drives and thus created one folder for each drive.

I have confirmed that adding two drives to a recent Windows 10 VM gives the
same result so this is not something specific to Windows 8.1 or the cw-*
machines.

Incidentally the failing test was introduced by the commit below:

commit 73c08fb638938ac6f903ad91d5ef2c93ae18a971
Author:     Andrew Eikum 
AuthorDate: Thu May 27 13:38:16 2021 -0500

shell32/tests: Add tests to show relative known folder paths match
SHGetKnownFolderPath.

Signed-off-by: Andrew Eikum 
    Signed-off-by: Alexandre Julliard

[Bug 51284] shell32:shellpath fails on Windows 8.1 when there is more than on CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase
    Regression SHA1|                            |73c08fb638938ac6f903ad91d5e
                   |                            |f2c93ae18a971

[Bug 51284] shell32:shellpath fails on Windows when there is more than on CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|shell32:shellpath fails on  |shell32:shellpath fails on
                   |Windows 8.1 when there is   |Windows when there is more
                   |more than on CD drive       |than on CD drive

[Bug 51284] shell32:shellpath fails on Windows when there is more than on CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 51284] shell32:shellpath fails on Windows when there is more than one CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|shell32:shellpath fails on  |shell32:shellpath fails on
                   |Windows when there is more  |Windows when there is more
                   |than on CD drive            |than one CD drive

[Bug 51284] shell32:shellpath fails on Windows when there is more than one CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8aaf9e64607f72806391843cfeb
                   |                            |38adeb5b8aaa7
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This is fixed:

commit 8aaf9e64607f72806391843cfeb38adeb5b8aaa7
Author:     Francois Gouget 
AuthorDate: Tue Jun 29 17:59:51 2021 +0200

shell32/tests: Fix the known folder relative path check for multiple CD
drives.

When there is more than one CD drive the extra drives typically get a
    folder called "Burn1", etc.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 51284] shell32:shellpath fails on Windows when there is more than one CD drive

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51284

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 6.14.