http://bugs.winehq.org/show_bug.cgi?id=18510
Summary: Microsoft .Net 20 SP1 Installer's text is unreadable Product: Wine Version: 1.1.21 Platform: PC-x86-64 URL: http://www.microsoft.com/downloads/details.aspx?family id=79BC3B77-E02C-4AD3-AACF-A7633F706BA5 OS/Version: Linux Status: NEW Keywords: download, Installer Severity: minor Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Created an attachment (id=21157) --> (http://bugs.winehq.org/attachment.cgi?id=21157) +richedit
Dan asked me to slipstream .net sp1 into winetricks. I took a look, and when attempting to install, noticed the license is unreadable. It's fixed by 'winetricks riched30' (+richedit attached).
It (appears to) install fine, but fails, see bug 16956.
http://bugs.winehq.org/show_bug.cgi?id=18510
--- Comment #1 from Austin English austinenglish@gmail.com 2009-05-17 19:17:50 --- Created an attachment (id=21158) --> (http://bugs.winehq.org/attachment.cgi?id=21158) screenshot
http://bugs.winehq.org/show_bug.cgi?id=18510
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #2 from Anastasius Focht focht@gmx.net 2009-06-16 16:43:02 --- Hello,
Wine's RichEdit WM_SETTEXT message handler needs to properly detect the case when Ansi RTF is passed and not blindly rely on Unicode flag.
The string was read from Ansi input file "EULA.1033.RTF" :
--- snip EULA.1033.RTF --- {\rtf1\ansi\ansicpg1252\deff0\deflang1033\deflangfe1033{\fonttbl{\f0\fswiss\fprq2\fcharset0 Tahoma;}} {*\generator Msftedit 5.41.21.2507;}\viewkind4\uc1\pard\b\f0\fs20 MICROSOFT SOFTWARE SUPPLEMENTAL LICENSE TERMS\par MICROSOFT .NET FRAMEWORK 2.0 \b0\par ... --- snip EULA.1033.RTF ---
The Ansi string gets incorrectly interpreted as Unicode (ME_ToUnicode pass-thru), leading to garbage display:
--- snip --- ... 0013:warn:file:wine_nt_to_unix_file_name L"\??\C:\4da3d33c08badc1346a1f48a8150\eula.1033.rtf" -> "/home/focht/.wine/dosdevices/c:/4da3d33c08badc1346a1f48a8150/EULA.1033.RTF" required a case-insensitive search 0013:trace:file:wine_nt_to_unix_file_name L"\??\C:\4da3d33c08badc1346a1f48a8150\eula.1033.rtf" -> "/home/focht/.wine/dosdevices/c:/4da3d33c08badc1346a1f48a8150/EULA.1033.RTF" 0013:trace:file:CreateFileW returning 0x110 0013:trace:file:ReadFile 0x110 0xff8818 3784 0x154d21c (nil) 0013:trace:richedit:RichEditWndProc_common enter hwnd 0x20118 msg 000c () 0 ff8818, unicode 1 0013:trace:richedit:ME_HandleMessage WM_SETTEXT lParam==ff8818 0013:trace:richedit:ME_HandleMessage WM_SETTEXT - L"\5c7b\7472\3166\615c\736e\5c69\6e61\6973\7063\3167\3532\5c32\6564\6666\5c30\6564\6c66\6e61\3167\3330\5c33\6564\6c66\6e61\6667\3165\3330\7b33\665c\6e6f\7474\6c62\5c7b\3066\665c\7773\7369\5c73\7066\7172\5c32\6366\6168\7372\7465\2030\6154\6f68\616d\7d3b\0d7d\7b0a\2a5c\675c\6e65\7265\7461\726f\4d20\6673\6574" ... --- snip ---
You might want to check for RTF sequence at the start of the string (similar to EM_SETTEXTEX) and use this info for further processing (ME_StreamInRTFString vs. ME_InsertTextFromCursor). With that properly fixed, the EULA will be correctly displayed.
You also might want to fix "{\urtf}" to "{\urtf" in EM_SETTEXTEX (minor one because compare length is 6 anyway) ;-)
Regards
http://bugs.winehq.org/show_bug.cgi?id=18510
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith@gmail.com
--- Comment #3 from Dylan Smith dylan.ah.smith@gmail.com 2009-07-10 22:59:50 --- I send in a patch fixing this bug by removing the check to see if a unicode message was sent.
richedit: Support ascii RTF in WM_SETTEXT even for unicode http://www.winehq.org/pipermail/wine-patches/2009-July/075755.html
Thanks for tracking down the problem for me.
http://bugs.winehq.org/show_bug.cgi?id=18510
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #4 from Dylan Smith dylan.ah.smith@gmail.com 2009-07-16 17:50:06 --- (In reply to comment #3)
richedit: Support ascii RTF in WM_SETTEXT even for unicode http://www.winehq.org/pipermail/wine-patches/2009-July/075755.html
In git as commit 88c2b90aa63b3a893f6edc0ffb4f652889a02c39
http://bugs.winehq.org/show_bug.cgi?id=18510
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #5 from Austin English austinenglish@gmail.com 2009-07-18 19:33:03 --- (In reply to comment #4)
(In reply to comment #3)
richedit: Support ascii RTF in WM_SETTEXT even for unicode http://www.winehq.org/pipermail/wine-patches/2009-July/075755.html
In git as commit 88c2b90aa63b3a893f6edc0ffb4f652889a02c39
Works great, thanks!
http://bugs.winehq.org/show_bug.cgi?id=18510
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2009-08-07 12:45:08 --- Closing bugs fixed in 1.1.27.
http://bugs.winehq.org/show_bug.cgi?id=18510
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dotnet Fixed by SHA1| |88c2b90aa63b3a893f6edc0ffb4 | |f652889a02c39
-
wine-bugs＠winehq.org