[Bug 34965] New: New Testbot doesn't correctly sets the time for the VMs so e.g. winhttp is failing

http://bugs.winehq.org/show_bug.cgi?id=34965

Bug #: 34965
           Summary: New Testbot doesn't correctly sets the time for the
                    VMs so e.g. winhttp is failing
           Product: Wine-Testbot
           Version: unspecified
          Platform: x86
               URL: https://newtestbot.winehq.org/JobDetails.pl?Key=3484
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified

winhttp tests a secure connection to google.com, but fails because the VM time
out of the certificates time range:

winhttp:winhttp start - -
winhttp.c:806: WINHTTP_CALLBACK_STATUS_FLAG_CERT_DATE_INVALID
winhttp.c:859: Test failed: failed to send request 12175
winhttp.c:870: ftStart Wednesday, November 06, 2013 2:00:40 PM
winhttp.c:874: ftExpiry Thursday, March 06, 2014 12:00:00 AM
winhttp.c:878: local Friday, October 25, 2013 9:23:32 AM

after hacking this into the tests before the skip:

size = sizeof(info);
ret = WinHttpQueryOption(req, WINHTTP_OPTION_SECURITY_CERTIFICATE_STRUCT,
&info, &size );
ok(ret, "failed to retrieve certificate info %u\n", GetLastError());
{
SYSTEMTIME st;
char exdate[255], extime[255];

FileTimeToSystemTime( &info.ftStart, &st );
GetDateFormatA( LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, NULL, exdate, 255 );
GetTimeFormatA( LOCALE_USER_DEFAULT, 0, &st, NULL, extime, 255 );
trace( "ftStart %s %s\n", exdate, extime );
FileTimeToSystemTime( &info.ftExpiry, &st );
GetDateFormatA( LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, NULL, exdate, 255 );
GetTimeFormatA( LOCALE_USER_DEFAULT, 0, &st, NULL, extime, 255 );
trace( "ftExpiry %s %s\n", exdate, extime );
GetLocalTime(&st);
GetDateFormatA( LOCALE_USER_DEFAULT, DATE_LONGDATE, &st, NULL, exdate, 255 );
GetTimeFormatA( LOCALE_USER_DEFAULT, 0, &st, NULL, extime, 255 );
trace( "local %s %s\n", exdate, extime );
}

[Bug 34965] New Testbot doesn't correctly sets the time for the VMs so e.g. winhttp is failing

http://bugs.winehq.org/show_bug.cgi?id=34965

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from François Gouget  ---
The commits below should fix this.

Note that they assume testagentd is being run with high enough privileges which
is the case for the current set of WineTestBot VMs. So later on we may run into
this kind of problem again.

commit b7f27a6b914689b7e05073e56ac40750ce2b04b4
Author: Francois Gouget 
Date:   Wed Mar 12 14:22:59 2014 +0100

testbot: Don't show the TestAgent server version when failing to set the
time.

The connection may have failed in which case we don't have this
information.

commit 28e77b884077e52aba213a079a320672e404881a
Author: Francois Gouget 
Date:   Thu Mar 6 15:26:34 2014 +0100

testbot/WineRunTask: Set the system time on the Windows VM before running
the tests.

commit df9f82b2f5e8040085f97e116f93f60187825ec7
Author: Francois Gouget 
Date:   Thu Mar 6 15:24:05 2014 +0100

testbot/testagentd: Add an RPC to set the remote host's system time.

[Bug 34965] New Testbot doesn't correctly sets the time for the VMs so e.g. winhttp is failing

https://bugs.winehq.org/show_bug.cgi?id=34965

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Bruno Jesus  ---
Closing other products fixed bugs.