[Bug 39279] New: valgrind shows uninitialized memory in winmm/tests/mcicda.c

https://bugs.winehq.org/show_bug.cgi?id=39279

Bug ID: 39279
           Summary: valgrind shows uninitialized memory in
                    winmm/tests/mcicda.c
           Product: Wine
           Version: 1.7.51
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: winmm&mci
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

../../../tools/runtest -q -P wine -T ../../.. -M winmm.dll -p winmm_test.exe.so
mcicda && touch mcicda.ok
preloader: Warning: failed to reserve range 00110000-68000000
preloader: Warning: failed to reserve range 7f000000-82000000
mcicda.c:174: Tests skipped: No CD-ROM in drive.
==21071== Syscall param ioctl(arg) contains uninitialised byte(s)
==21071==    at 0x455603C9: ioctl (in /usr/lib/libc-2.21.so)
==21071==    by 0x7BC36D16: CDROM_StopAudio (cdrom.c:1362)
==21071==    by 0x7BC38E8C: CDROM_DeviceIoControl (cdrom.c:3024)
==21071==    by 0x7BC469AD: NtDeviceIoControlFile (file.c:1614)
==21071==    by 0x7B841301: DeviceIoControl (file.c:2658)
==21071==    by 0x5B7C3E8: MCICDA_Stop (mcicda.c:1087)
==21071==    by 0x5B79D76: MCICDA_Close (mcicda.c:505)
==21071==    by 0x5B7CF3B: MCICDA_DriverProc (mcicda.c:1310)
==21071==    by 0x48D58FF: DRIVER_SendMessage (driver.c:136)
==21071==    by 0x48D5A04: SendDriverMessage (driver.c:156)
==21071==    by 0x48DBDD0: MCI_SendCommandFrom32 (mci.c:894)
==21071==    by 0x48DE8BA: MCI_Close (mci.c:1875)
==21071==    by 0x48DF591: MCI_SendCommand (mci.c:2099)
==21071==    by 0x48DFD6E: mciSendCommandW (mci.c:2295)
==21071==    by 0x48DFED4: mciSendCommandA (mci.c:2318)
==21071==    by 0x476663F: test_openclose (mcicda.c:577)
==21071==    by 0x47667B6: func_mcicda (mcicda.c:604)
==21071==    by 0x477E3B5: run_test (test.h:584)
==21071==    by 0x477E7FD: main (test.h:666)
==21071==  Uninitialised value was created by a stack allocation
==21071==    at 0x7BC36D08: CDROM_StopAudio (cdrom.c:1362)
==21071==

Note this also exposes a valgrind bug:
==21071== Warning: noted but unhandled ioctl 0x5307 with no size/direction
hints.
==21071==    This could cause spurious value errors to appear.
==21071==    See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a
proper wrapper.

That's https://bugs.kde.org/show_bug.cgi?id=352767

[Bug 39279] valgrind shows uninitialized memory in winmm/tests/mcicda.c

https://bugs.winehq.org/show_bug.cgi?id=39279

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
> Note this also exposes a valgrind bug:
>
> That's https://bugs.kde.org/show_bug.cgi?id=352767

That is fixed, but I got lost how to test the other part of this bug.

[Bug 39279] valgrind shows uninitialized memory in winmm/tests/mcicda.c

https://bugs.winehq.org/show_bug.cgi?id=39279

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Austin English  ---
Not seeing this in 4.0-rc2.

[Bug 39279] valgrind shows uninitialized memory in winmm/tests/mcicda.c

https://bugs.winehq.org/show_bug.cgi?id=39279

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 4.0-rc3.