[Bug 53309] New: Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

Bug ID: 53309
           Summary: Wizard101 launcher window takes over a minute to
                    appear
           Product: Wine
           Version: 7.12
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: secur32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 0a10bfc8b17234db6aff130ce0448a62c3fb6a1e
      Distribution: SUSE

Normally it pops up immediately.

0a10bfc8b17234db6aff130ce0448a62c3fb6a1e is the first bad commit
commit 0a10bfc8b17234db6aff130ce0448a62c3fb6a1e
Author: Hans Leidekker 
Date:   Wed Jun 29 13:54:57 2022 +0200

secur32: Return a SECBUFFER_MISSING buffer from the handshake if the input
message is incomplete.

dlls/secur32/schannel.c       | 25 +++++++++++++++++++++++--
 dlls/secur32/tests/schannel.c | 21 ++++++++++++++++++++-
 2 files changed, 43 insertions(+), 3 deletions(-)

Reverting the patch fixes it.

[Bug 53309] Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

--- Comment #1 from Hans Leidekker  ---
The launcher is confused by the SECBUFFER_MISSING buffer. It resets the buffer
type to SECBUFFER_EMPTY but doesn't reset the buffer size, which is an invalid
input according to my tests. If I fix Wine to reject this like Windows the
launcher windows appears immediately, even though the connection fails.

[Bug 53309] Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

--- Comment #2 from Hans Leidekker  ---
Created attachment 72690
  --> https://bugs.winehq.org/attachment.cgi?id=72690
patch

Does the launcher behave as expected with this patch?

[Bug 53309] Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

--- Comment #3 from Rosanne DiMesio  ---
(In reply to Hans Leidekker from comment #2)
> Created attachment 72690 [details]
> patch
>
> Does the launcher behave as expected with this patch?

Yes, that fixes it.

[Bug 53309] Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |738a5b53a4b3140ef5025d070af
                   |                            |bd267efc8edbc
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Hans Leidekker  ---
Fixed by 738a5b53a4b3140ef5025d070afbd267efc8edbc.

[Bug 53309] Wizard101 launcher window takes over a minute to appear

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53309

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 7.13.