[Bug 45169] New: Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

Bug ID: 45169
           Summary: Commit "shell32: Handle writing an iconresource entry
                    in  SHGetSetFolderCustomSettings" changes return value
                    to E_FAIL
           Product: Wine
           Version: 3.7
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello,

we have a regression with new crashes of a proprietary application. A bisect
shows as _one_ problematic patch:
> From 730264609f468d7aa0973edc9a435bd20373c1cd Mon Sep 17 00:00:00 2001

From: Louis Lenders 
Date: Mon, 30 Apr 2018 09:22:42 +0200
Subject: [PATCH] shell32: Handle writing an iconresource entry in
 SHGetSetFolderCustomSettings.

Signed-off-by: Louis Lenders 
Signed-off-by: Alexandre Julliard 
---
 dlls/shell32/shlfolder.c       | 38 ++++++++++++++++++++++++++++++++++----
 dlls/shell32/tests/shlfolder.c |  4 ++--
 2 files changed, 36 insertions(+), 6 deletions(-)

Prior to this patch the function returned always E_NOTIMPL.

This patch changes the return value from E_NOTIMPL to E_FAIL even when flags is
not FCS_FORCEWRITE and when fcs->dwMask is not FCSM_ICONFILE.

At least the first case is also with the patch not implemented and should
return E_NOTIMPL.

Changing this return values changes the behavior of our application (which
shows the next crash :-).

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |730264609f468d7aa0973edc9a4
                   |                            |35bd20373c1cd
                 CC|                            |[e-mail]

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

--- Comment #1 from Louis Lenders  ---
Hi Ulrich, thanks for bugreport.

As far as I tested this, the function actually never returned E_NOTIMPL;  It
might be better to just implement this what you need (and thus return S_OK). I
guess your application is satisfied with S_OK as well (?)
> From what you wrote I understand your application calls it with FCS_READ (am I

right about that?). Could you tell me what fcs->dwMask you call it with? Then
I`ll add test and try to implement it, shouldn`t be to difficult I think

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

--- Comment #2 from Louis Lenders  ---
Created attachment 61422
  --> https://bugs.winehq.org/attachment.cgi?id=61422
better trace patch

Hi Ulrich, have you already had any time to have a look at my quesions?

If you don`t know the answer, could you apply the attached patch (that adds a
trace for fcs->dwmask) and run the app and post the consolelog here? ATM I
don`t have enough info to fix this.

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

Ulrich Gemkow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Ulrich Gemkow  ---
Hi Louis,

thank you very much for looking into this and please forgive the long delay in
answering!

I tried very hard to reproduce the observed behavior and I must admit that I
was not able to do so - the applicatio no longer crashes (after the toolbar
fixes). I did not notice the exact git release which I used as a base and maybe
I made an mistake while bisecting.

So I closed this bug as invalid. Thanks again and sorry the waste of your time
- I really regret this!

Best regards

Ulrich

[Bug 45169] Commit "shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings" changes return value to E_FAIL

https://bugs.winehq.org/show_bug.cgi?id=45169

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|RESOLVED                    |CLOSED

--- Comment #4 from André H.  ---
closing invalid