winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
January 2006
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
617 discussions
Start a n
N
ew thread
appdb/. testResults.php appsubmit.php
by WineHQ
17 Jan '06
17 Jan '06
ChangeSet ID: 22336 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/01/16 20:33:14 Modified files: . : testResults.php appsubmit.php Log message: Tony Lambregts <tony.lambregts(a)gmail.com> Only create new distributions if the user didn't pick one from the dropdown menu. Previous behavior would create a new distribution if any text was present in the 'distribution' textbox, even if a distribution is picked from the dropdown menu. Patch:
http://cvs.winehq.org/patch.py?id=22336
Old revision New revision Changes Path 1.1 1.2 +17 -14 appdb/testResults.php 1.35 1.36 +9 -7 appdb/appsubmit.php Index: appdb/testResults.php diff -u -p appdb/testResults.php:1.1 appdb/testResults.php:1.2 --- appdb/testResults.php:1.1 17 Jan 2006 2:33:14 -0000 +++ appdb/testResults.php 17 Jan 2006 2:33:14 -0000 @@ -27,22 +27,25 @@ if ($_REQUEST['sub']) $oTest->GetOutputEditorValues(); // retrieve the values from the current $_REQUEST if(empty($errors)) { - $sDistribution = trim($_REQUEST['sDistribution']); - if(!empty($sDistribution)) + if(!$_REQUEST['iDistributionId']) { - $oDistribution = new distribution(); - $oDistribution->sName = $sDistribution; - $oDistribution->create(); - $oTest->iDistributionId = $oDistribution->iDistributionId; + $sDistribution = trim($_REQUEST['sDistribution']); + if(!empty($sDistribution)) + { + $oDistribution = new distribution(); + $oDistribution->sName = $sDistribution; + $oDistribution->create(); + $oTest->iDistributionId = $oDistribution->iDistributionId; + } + } + if($_REQUEST['sub'] == 'Submit') + { + $oTest->create(); + } else if($_REQUEST['sub'] == 'Resubmit') + { + $oTest->update(true); + $oTest->ReQueue(); } - if($_REQUEST['sub'] == 'Submit') - { - $oTest->create(); - } else if($_REQUEST['sub'] == 'Resubmit') - { - $oTest->update(true); - $oTest->ReQueue(); - } redirect($_SERVER['PHP_SELF']); } else { Index: appdb/appsubmit.php diff -u -p appdb/appsubmit.php:1.35 appdb/appsubmit.php:1.36 --- appdb/appsubmit.php:1.35 17 Jan 2006 2:33:14 -0000 +++ appdb/appsubmit.php 17 Jan 2006 2:33:14 -0000 @@ -181,14 +181,16 @@ if ($_REQUEST['sub']) { $oVersion->create(); } - - $sDistribution = trim($_REQUEST['sDistribution']); - if(!empty($sDistribution)) + if(!$_REQUEST['iDistributionId']) { - $oDistribution = new distribution(); - $oDistribution->sName = $sDistribution; - $oDistribution->create(); - $oTest->iDistributionId = $oDistribution->iDistributionId; + $sDistribution = trim($_REQUEST['sDistribution']); + if(!empty($sDistribution)) + { + $oDistribution = new distribution(); + $oDistribution->sName = $sDistribution; + $oDistribution->create(); + $oTest->iDistributionId = $oDistribution->iDistributionId; + } } $oTest->iVersionId = $oVersion->iVersionId; if(is_numeric($oTest->iTestingId))
1
0
0
0
Michael Stefaniuc : oleaut32: Tests for the VarCmp reimplementation.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: 2f9c9b31ae1d734266726271342da0778414eda2 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=2f9c9b31ae1d73426672627…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Jan 16 21:34:59 2006 +0100 oleaut32: Tests for the VarCmp reimplementation. --- dlls/oleaut32/tests/vartest.c | 240 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 240 insertions(+), 0 deletions(-)
1
0
0
0
Michael Stefaniuc : oleaut32: Reimplement VarCmp().
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: f73b68b0169bc8b53993329364798f884f2c2b4e URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=f73b68b0169bc8b53993329…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Jan 16 21:34:50 2006 +0100 oleaut32: Reimplement VarCmp(). - Supports now all WinXP allowed combinations of input variants. - VT_RESERVED on input variants is handled now. - Removed complicated VT_DATE comparision; that's not how Windows does it. - Improved documentation. --- dlls/oleaut32/variant.c | 368 ++++++++++++++++++++++++++--------------------- 1 files changed, 200 insertions(+), 168 deletions(-)
1
0
0
0
Michael Stefaniuc : oleaut32: Define missing but useful VTBIT_* macros.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: e47b813fc6d517ed341ed7b6f75925d1cec5add0 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=e47b813fc6d517ed341ed7b…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Jan 16 21:32:24 2006 +0100 oleaut32: Define missing but useful VTBIT_* macros. --- dlls/oleaut32/varformat.c | 2 +- dlls/oleaut32/variant.c | 6 +++--- dlls/oleaut32/variant.h | 14 ++++++++++++++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c index 13458a2..29bf3a7 100644 --- a/dlls/oleaut32/varformat.c +++ b/dlls/oleaut32/varformat.c @@ -1983,7 +1983,7 @@ VARIANT_FormatString_Exit: #define NUMBER_VTBITS (VTBIT_I1|VTBIT_UI1|VTBIT_I2|VTBIT_UI2| \ VTBIT_I4|VTBIT_UI4|VTBIT_I8|VTBIT_UI8| \ VTBIT_R4|VTBIT_R8|VTBIT_CY|VTBIT_DECIMAL| \ - (1<<VT_BOOL)|(1<<VT_INT)|(1<<VT_UINT)) + VTBIT_BOOL|VTBIT_INT|VTBIT_UINT) /********************************************************************** * VarFormatFromTokens [OLEAUT32.139] diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c index 953595b..55b61fa 100644 --- a/dlls/oleaut32/variant.c +++ b/dlls/oleaut32/variant.c @@ -3184,7 +3184,7 @@ HRESULT WINAPI VarDiv(LPVARIANT left, LP found = TRUE; resvt = VT_DECIMAL; } - if (!found && (((1<<lvt) | (1<<rvt)) & (VTBIT_I1|VTBIT_I2|VTBIT_UI1|VTBIT_UI2|VTBIT_I4|VTBIT_UI4|(1<<VT_INT)|(1<<VT_UINT)))) { + if (!found && (((1<<lvt) | (1<<rvt)) & (VTBIT_I1|VTBIT_I2|VTBIT_UI1|VTBIT_UI2|VTBIT_I4|VTBIT_UI4|VTBIT_INT|VTBIT_UINT))) { found = TRUE; resvt = VT_I4; } @@ -3253,7 +3253,7 @@ HRESULT WINAPI VarSub(LPVARIANT left, LP lvt = V_VT(left)&VT_TYPEMASK; rvt = V_VT(right)&VT_TYPEMASK; found = FALSE;resvt = VT_VOID; - if (((1<<lvt) | (1<<rvt)) & ((1<<VT_DATE)|(1<<VT_R4)|(1<<VT_R8))) { + if (((1<<lvt) | (1<<rvt)) & (VTBIT_DATE|VTBIT_R4|VTBIT_R8)) { found = TRUE; resvt = VT_R8; } @@ -3261,7 +3261,7 @@ HRESULT WINAPI VarSub(LPVARIANT left, LP found = TRUE; resvt = VT_DECIMAL; } - if (!found && (((1<<lvt) | (1<<rvt)) & (VTBIT_I1|VTBIT_I2|VTBIT_UI1|VTBIT_UI2|VTBIT_I4|VTBIT_UI4|(1<<VT_INT)|(1<<VT_UINT)))) { + if (!found && (((1<<lvt) | (1<<rvt)) & (VTBIT_I1|VTBIT_I2|VTBIT_UI1|VTBIT_UI2|VTBIT_I4|VTBIT_UI4|VTBIT_INT|VTBIT_UINT))) { found = TRUE; resvt = VT_I4; } diff --git a/dlls/oleaut32/variant.h b/dlls/oleaut32/variant.h index 0c2acde..42c5e76 100644 --- a/dlls/oleaut32/variant.h +++ b/dlls/oleaut32/variant.h @@ -34,6 +34,20 @@ /* Get the extra flags from a variant pointer */ #define V_EXTRA_TYPE(v) (V_VT((v)) & VT_EXTRA_TYPE) +/* Missing in Windows but usefull VTBIT_* defines */ +#define VTBIT_BOOL (1 << VT_BSTR) +#define VTBIT_BSTR (1 << VT_BSTR) +#define VTBIT_DATE (1 << VT_DATE) +#define VTBIT_DISPATCH (1 << VT_DISPATCH) +#define VTBIT_EMPTY (1 << VT_EMPTY) +#define VTBIT_ERROR (1 << VT_ERROR) +#define VTBIT_INT (1 << VT_INT) +#define VTBIT_NULL (1 << VT_NULL) +#define VTBIT_UINT (1 << VT_UINT) +#define VTBIT_UNKNOWN (1 << VT_UNKNOWN) +#define VTBIT_VARIANT (1 << VT_VARIANT) +#define VTBIT_15 (1 << 15) /* no variant type with this number */ + extern const char* wine_vtypes[]; #define debugstr_vt(v) (((v)&VT_TYPEMASK) <= VT_CLSID ? wine_vtypes[((v)&VT_TYPEMASK)] : \ ((v)&VT_TYPEMASK) == VT_BSTR_BLOB ? "VT_BSTR_BLOB": "Invalid")
1
0
0
0
Robert Shearman : shell: GetDetailsOf fix.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: d9d9d7e897245083fad749c395a21ea4343aa86e URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=d9d9d7e897245083fad749c…
Author: Robert Shearman <rob(a)codeweavers.com> Date: Mon Jan 16 21:32:06 2006 +0100 shell: GetDetailsOf fix. Initialise hr and psd->str.uType before the call to IShellFolder_GetDisplayNameOf so that whatever it returns is preserved. --- dlls/shell32/shfldr_fs.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/shfldr_fs.c b/dlls/shell32/shfldr_fs.c index 394c254..506236f 100644 --- a/dlls/shell32/shfldr_fs.c +++ b/dlls/shell32/shfldr_fs.c @@ -965,6 +965,8 @@ IShellFolder_fnGetDetailsOf (IShellFolde psd->str.u.cStr, MAX_PATH); return S_OK; } else { + hr = S_OK; + psd->str.uType = STRRET_CSTR; /* the data from the pidl */ switch (iColumn) { case 0: /* name */ @@ -984,8 +986,6 @@ IShellFolder_fnGetDetailsOf (IShellFolde _ILGetFileAttributes (pidl, psd->str.u.cStr, MAX_PATH); break; } - hr = S_OK; - psd->str.uType = STRRET_CSTR; } return hr;
1
0
0
0
Robert Shearman : shell: Convert the filesystem shell folder to Unicode.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: f8782733f3b8b19f39fb90e24140e08e5cfd0098 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=f8782733f3b8b19f39fb90e…
Author: Robert Shearman <rob(a)codeweavers.com> Date: Mon Jan 16 21:31:48 2006 +0100 shell: Convert the filesystem shell folder to Unicode. --- dlls/shell32/shfldr.h | 2 - dlls/shell32/shfldr_desktop.c | 18 ++++-- dlls/shell32/shfldr_fs.c | 115 +++++++++++++++++++++++------------------ 3 files changed, 75 insertions(+), 60 deletions(-)
1
0
0
0
Robert Shearman : shell: Convert SHELL32_GetDisplayNameOfChild to unicode.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: 50c1e46d18089118c522fe13da34fc85559b1ad5 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=50c1e46d18089118c522fe1…
Author: Robert Shearman <rob(a)codeweavers.com> Date: Mon Jan 16 21:31:10 2006 +0100 shell: Convert SHELL32_GetDisplayNameOfChild to unicode. --- dlls/shell32/cpanelfolder.c | 13 ++++++++----- dlls/shell32/shfldr.h | 2 +- dlls/shell32/shfldr_desktop.c | 18 ++++++++++++++++-- dlls/shell32/shfldr_fs.c | 8 +++++++- dlls/shell32/shfldr_mycomp.c | 18 ++++++++++++++++-- dlls/shell32/shlfolder.c | 6 +++--- 6 files changed, 51 insertions(+), 14 deletions(-) diff --git a/dlls/shell32/cpanelfolder.c b/dlls/shell32/cpanelfolder.c index cbac65a..878e6d8 100644 --- a/dlls/shell32/cpanelfolder.c +++ b/dlls/shell32/cpanelfolder.c @@ -652,7 +652,8 @@ static HRESULT WINAPI ISF_ControlPanel_f { ICPanelImpl *This = (ICPanelImpl *)iface; - CHAR szPath[MAX_PATH*2]; + CHAR szPath[MAX_PATH]; + WCHAR wszPath[MAX_PATH+1]; /* +1 for potential backslash */ PIDLCPanelStruct* pcpanel; *szPath = '\0'; @@ -676,7 +677,7 @@ static HRESULT WINAPI ISF_ControlPanel_f BOOL bSimplePidl = _ILIsPidlSimple(pidl); if (bSimplePidl) { - _ILSimpleGetText(pidl, szPath, MAX_PATH); /* append my own path */ + _ILSimpleGetTextW(pidl, wszPath, MAX_PATH); /* append my own path */ } else { FIXME("special pidl\n"); } @@ -684,12 +685,14 @@ static HRESULT WINAPI ISF_ControlPanel_f if ((dwFlags & SHGDN_FORPARSING) && !bSimplePidl) { /* go deeper if needed */ int len = 0; - PathAddBackslashA(szPath); /*FIXME*/ - len = lstrlenA(szPath); + PathAddBackslashW(wszPath); + len = lstrlenW(wszPath); if (!SUCCEEDED - (SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags | SHGDN_INFOLDER, szPath + len, MAX_PATH - len))) + (SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags | SHGDN_INFOLDER, wszPath + len, MAX_PATH + 1 - len))) return E_OUTOFMEMORY; + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, szPath, MAX_PATH, NULL, NULL)) + wszPath[0] = '\0'; } } diff --git a/dlls/shell32/shfldr.h b/dlls/shell32/shfldr.h index e626255..ed474b2 100644 --- a/dlls/shell32/shfldr.h +++ b/dlls/shell32/shfldr.h @@ -39,7 +39,7 @@ LPCWSTR GetNextElementW (LPCWSTR pszNext HRESULT SHELL32_ParseNextElement (IShellFolder2 * psf, HWND hwndOwner, LPBC pbc, LPITEMIDLIST * pidlInOut, LPOLESTR szNext, DWORD * pEaten, DWORD * pdwAttributes); HRESULT SHELL32_GetItemAttributes (IShellFolder * psf, LPCITEMIDLIST pidl, LPDWORD pdwAttributes); -HRESULT SHELL32_GetDisplayNameOfChild (IShellFolder2 * psf, LPCITEMIDLIST pidl, DWORD dwFlags, LPSTR szOut, +HRESULT SHELL32_GetDisplayNameOfChild (IShellFolder2 * psf, LPCITEMIDLIST pidl, DWORD dwFlags, LPWSTR szOut, DWORD dwOutLen); HRESULT SHELL32_BindToChild (LPCITEMIDLIST pidlRoot, diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c index 09d6270..3dd637d 100644 --- a/dlls/shell32/shfldr_desktop.c +++ b/dlls/shell32/shfldr_desktop.c @@ -562,6 +562,7 @@ static HRESULT WINAPI ISF_Desktop_fnGetD { IGenericSFImpl *This = (IGenericSFImpl *)iface; HRESULT hr = S_OK; + WCHAR wszPath[MAX_PATH]; TRACE ("(%p)->(pidl=%p,0x%08lx,%p)\n", This, pidl, dwFlags, strRet); pdump (pidl); @@ -645,13 +646,20 @@ static HRESULT WINAPI ISF_Desktop_fnGetD if ((GET_SHGDN_RELATION (dwFlags) == SHGDN_NORMAL) && bWantsForParsing) { + WCHAR wszPath[MAX_PATH]; /* * we need the filesystem path to the destination folder. * Only the folder itself can know it */ hr = SHELL32_GetDisplayNameOfChild (iface, pidl, dwFlags, - strRet->u.cStr, + wszPath, MAX_PATH); + if (SUCCEEDED(hr)) + { + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, strRet->u.cStr, MAX_PATH, + NULL, NULL)) + wszPath[0] = '\0'; + } } else { @@ -690,7 +698,13 @@ static HRESULT WINAPI ISF_Desktop_fnGetD { /* a complex pidl, let the subfolder do the work */ hr = SHELL32_GetDisplayNameOfChild (iface, pidl, dwFlags, - strRet->u.cStr, MAX_PATH); + wszPath, MAX_PATH); + if (SUCCEEDED(hr)) + { + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, strRet->u.cStr, MAX_PATH, + NULL, NULL)) + wszPath[0] = '\0'; + } } TRACE ("-- (%p)->(%s,0x%08lx)\n", This, diff --git a/dlls/shell32/shfldr_fs.c b/dlls/shell32/shfldr_fs.c index 53d8231..fb89688 100644 --- a/dlls/shell32/shfldr_fs.c +++ b/dlls/shell32/shfldr_fs.c @@ -816,7 +816,13 @@ IShellFolder_fnGetDisplayNameOf (IShellF _ILSimpleGetText(pidl, strRet->u.cStr + len, MAX_PATH - len); if (!_ILIsFolder(pidl)) SHELL_FS_ProcessDisplayFilename(strRet->u.cStr, dwFlags); } else { - hr = SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags, strRet->u.cStr, MAX_PATH); + WCHAR wszPath[MAX_PATH]; + hr = SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags, wszPath, MAX_PATH); + if (SUCCEEDED(hr)) { + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, strRet->u.cStr, MAX_PATH, + NULL, NULL)) + wszPath[0] = '\0'; + } } TRACE ("-- (%p)->(%s)\n", This, strRet->u.cStr); diff --git a/dlls/shell32/shfldr_mycomp.c b/dlls/shell32/shfldr_mycomp.c index b9b51b7..176b8ae 100644 --- a/dlls/shell32/shfldr_mycomp.c +++ b/dlls/shell32/shfldr_mycomp.c @@ -617,12 +617,19 @@ static HRESULT WINAPI ISF_MyComputer_fnG if ((GET_SHGDN_RELATION (dwFlags) == SHGDN_NORMAL) && bWantsForParsing) { + WCHAR wszPath[MAX_PATH]; /* * We need the filesystem path to the destination folder * Only the folder itself can know it */ hr = SHELL32_GetDisplayNameOfChild (iface, pidl, - dwFlags, szPath, MAX_PATH); + dwFlags, wszPath, MAX_PATH); + if (SUCCEEDED(hr)) + { + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, szPath, MAX_PATH, + NULL, NULL)) + wszPath[0] = '\0'; + } } else { @@ -677,9 +684,16 @@ static HRESULT WINAPI ISF_MyComputer_fnG } else { + WCHAR wszPath[MAX_PATH]; /* Complex pidl. Let the child folder do the work */ strRet->uType = STRRET_CSTR; - hr = SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags, szPath, MAX_PATH); + hr = SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags, wszPath, MAX_PATH); + if (SUCCEEDED(hr)) + { + if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, szPath, MAX_PATH, + NULL, NULL)) + wszPath[0] = '\0'; + } } if (SUCCEEDED (hr)) diff --git a/dlls/shell32/shlfolder.c b/dlls/shell32/shlfolder.c index d033b2a..09e46f1 100644 --- a/dlls/shell32/shlfolder.c +++ b/dlls/shell32/shlfolder.c @@ -331,7 +331,7 @@ HRESULT SHELL32_BindToChild (LPCITEMIDLI * virtual folders with the registry key WantsFORPARSING set. */ HRESULT SHELL32_GetDisplayNameOfChild (IShellFolder2 * psf, - LPCITEMIDLIST pidl, DWORD dwFlags, LPSTR szOut, DWORD dwOutLen) + LPCITEMIDLIST pidl, DWORD dwFlags, LPWSTR szOut, DWORD dwOutLen) { LPITEMIDLIST pidlFirst; HRESULT hr = E_INVALIDARG; @@ -350,7 +350,7 @@ HRESULT SHELL32_GetDisplayNameOfChild (I hr = IShellFolder_GetDisplayNameOf (psfChild, pidlNext, dwFlags, &strTemp); if (SUCCEEDED (hr)) { - hr = StrRetToStrNA (szOut, dwOutLen, &strTemp, pidlNext); + hr = StrRetToStrNW (szOut, dwOutLen, &strTemp, pidlNext); } IShellFolder_Release (psfChild); } @@ -358,7 +358,7 @@ HRESULT SHELL32_GetDisplayNameOfChild (I } else hr = E_OUTOFMEMORY; - TRACE ("-- ret=0x%08lx %s\n", hr, szOut); + TRACE ("-- ret=0x%08lx %s\n", hr, debugstr_w(szOut)); return hr; }
1
0
0
0
Alex Villacís Lasso : msacm: Fix incorrect linked list traversing leading to memory/driver
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: 8cfa507f31923a717a00bbe8f7c882d6f63c756a URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=8cfa507f31923a717a00bbe…
Author: Alex Villacís Lasso <a_villacis(a)palosanto.com> Date: Mon Jan 16 21:30:52 2006 +0100 msacm: Fix incorrect linked list traversing leading to memory/driver instance leak. --- dlls/msacm/driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msacm/driver.c b/dlls/msacm/driver.c index bfcc533..eef7875 100644 --- a/dlls/msacm/driver.c +++ b/dlls/msacm/driver.c @@ -123,7 +123,7 @@ MMRESULT WINAPI acmDriverClose(HACMDRIVE padid = pad->obj.pACMDriverID; /* remove driver from list */ - for (tpad = &(padid->pACMDriverList); *tpad; *tpad = (*tpad)->pNextACMDriver) { + for (tpad = &(padid->pACMDriverList); *tpad; tpad = &((*tpad)->pNextACMDriver)) { if (*tpad == pad) { *tpad = (*tpad)->pNextACMDriver; break;
1
0
0
0
Uwe Bonnes : regsvr32 understands '-' and '/' for arguments.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: 6906cbc1bffb52ca3f04059e0a102a3d01a36210 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=6906cbc1bffb52ca3f04059…
Author: Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> Date: Mon Jan 16 21:30:38 2006 +0100 regsvr32 understands '-' and '/' for arguments. --- programs/regsvr32/regsvr32.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/programs/regsvr32/regsvr32.c b/programs/regsvr32/regsvr32.c index 7fd9c93..184e00a 100644 --- a/programs/regsvr32/regsvr32.c +++ b/programs/regsvr32/regsvr32.c @@ -190,11 +190,11 @@ int main(int argc, char* argv[]) */ for(i = 1; i < argc; i++) { - if (!strcasecmp(argv[i], "/u")) + if ((!strcasecmp(argv[i], "/u")) ||(!strcasecmp(argv[i], "-u"))) Unregister = TRUE; - else if (!strcasecmp(argv[i], "/s")) + else if ((!strcasecmp(argv[i], "/s"))||(!strcasecmp(argv[i], "-s"))) Silent = 1; - else if (!strncasecmp(argv[i], "/i", strlen("/i"))) + else if ((!strncasecmp(argv[i], "/i", strlen("/i")))||(!strncasecmp(argv[i], "-i", strlen("-i")))) { CHAR* command_line = argv[i] + strlen("/i"); @@ -236,7 +236,7 @@ int main(int argc, char* argv[]) wsCommandLine = EmptyLine; } } - else if(!strcasecmp(argv[i], "/n")) + else if((!strcasecmp(argv[i], "/n"))||(!strcasecmp(argv[i], "-n"))) CallRegister = FALSE; else if (argv[i][0] == '/' && (!argv[i][2] || argv[i][2] == ':')) printf("Unrecognized switch %s\n", argv[i]);
1
0
0
0
Mike McCormack : kernel32: Move FileCDR16 in with the other 16bit file functions.
by Alexandre Julliard
16 Jan '06
16 Jan '06
Module: wine Branch: refs/heads/master Commit: 13ea51556d3bf11201c635f258ba8c1dc470ea0c URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=13ea51556d3bf11201c635f…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Mon Jan 16 20:51:28 2006 +0100 kernel32: Move FileCDR16 in with the other 16bit file functions. --- dlls/kernel/change.c | 10 ---------- dlls/kernel/file16.c | 9 +++++++++ 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dlls/kernel/change.c b/dlls/kernel/change.c index 601c18f..177c616 100644 --- a/dlls/kernel/change.c +++ b/dlls/kernel/change.c @@ -31,7 +31,6 @@ #include "winerror.h" #include "winternl.h" #include "kernel_private.h" -#include "wine/windef16.h" #include "wine/server.h" #include "wine/debug.h" @@ -126,15 +125,6 @@ BOOL WINAPI FindCloseChangeNotification( return CloseHandle( handle ); } -/*********************************************************************** -* FileCDR (KERNEL.130) -*/ -FARPROC16 WINAPI FileCDR16(FARPROC16 x) -{ - FIXME("(%p): stub\n", x); - return (FARPROC16)TRUE; -} - BOOL WINAPI ReadDirectoryChangesW( HANDLE handle, LPVOID buffer, DWORD len, BOOL subtree, DWORD filter, LPDWORD returned, LPOVERLAPPED overlapped, LPOVERLAPPED_COMPLETION_ROUTINE completion ) diff --git a/dlls/kernel/file16.c b/dlls/kernel/file16.c index 0ac6fad..503c614 100644 --- a/dlls/kernel/file16.c +++ b/dlls/kernel/file16.c @@ -733,3 +733,12 @@ BOOL16 WINAPI GetDiskFreeSpace16( LPCSTR return GetDiskFreeSpaceA( root, cluster_sectors, sector_bytes, free_clusters, total_clusters ); } + +/*********************************************************************** + * FileCDR (KERNEL.130) + */ +FARPROC16 WINAPI FileCDR16(FARPROC16 x) +{ + FIXME("(%p): stub\n", x); + return (FARPROC16)TRUE; +}
1
0
0
0
← Newer
1
...
29
30
31
32
33
34
35
...
62
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
Results per page:
10
25
50
100
200