ChangeSet ID: 30028
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2006/11/26 20:32:22
Modified files:
include : testData.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Add basic rating logic checking to testData::CheckOutputEditorInput() to prevent people from saying a running application is
garbage and an application that won't install is platinum.
Patch: http://cvs.winehq.org/patch.py?id=30028
Old revision New revision Changes Path
1.10 1.11 +9 -1 appdb/include/testData.php
Index: appdb/include/testData.php
diff -u -p appdb/include/testData.php:1.10 appdb/include/testData.php:1.11
--- appdb/include/testData.php:1.10 27 Nov 2006 2:32:22 -0000
+++ appdb/include/testData.php 27 Nov 2006 2:32:22 -0000
@@ -582,7 +582,15 @@ class testData{
if (empty($aValues['sTestedRating']))
$errors .= "<li>Please enter a rating based on how well this application runs.</li>\n";
-
+
+ // Basic checking of rating logic to ensure that the users test results
+ // are consistent
+ if (($aValues['sRuns'] != "Yes") && ($aValues['sTestedRating'] != GARBAGE_RATING))
+ $errors .= "<li>Applications that do not run should be rated ‘Garbage’.</li>\n";
+
+ if (($aValues['sInstalls'] == "No") && ($aValues['sTestedRating'] == PLATINUM_RATING))
+ $errors .= "<li>An application can only get a Platinum rating if it installs and runs ‘out of the box’.</li>\n";
+
return $errors;
}
ChangeSet ID: 30027
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2006/11/26 12:17:29
Modified files:
help : appdb_faq.help
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Add a FAQ entry about the term 'vendor'.
Patch: http://cvs.winehq.org/patch.py?id=30027
Old revision New revision Changes Path
1.9 1.10 +5 -0 appdb/help/appdb_faq.help
Index: appdb/help/appdb_faq.help
diff -u -p appdb/help/appdb_faq.help:1.9 appdb/help/appdb_faq.help:1.10
--- appdb/help/appdb_faq.help:1.9 26 Nov 2006 18:17:29 -0000
+++ appdb/help/appdb_faq.help 26 Nov 2006 18:17:29 -0000
@@ -81,6 +81,11 @@ Simply click on the button you will find
<blockquote>
<p><b>A:</b> A super maintainer maintains an application and all it's versions. A maintainer maintains only one specific version of an application.</p>
</blockquote>
+
+<p><b>Q: What is meant by the term ‘vendor’?</b></p>
+<blockquote>
+<p><b>A:</b> The vendor is the developer of an application.</p>
+</blockquote>
</ul>
If you have more questions you would like to add to our FAQ, please contact us
ChangeSet ID: 30026
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2006/11/26 12:16:20
Modified files:
. : index.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Fix a typo on the main page.
Patch: http://cvs.winehq.org/patch.py?id=30026
Old revision New revision Changes Path
1.39 1.40 +1 -1 appdb/index.php
Index: appdb/index.php
diff -u -p appdb/index.php:1.39 appdb/index.php:1.40
--- appdb/index.php:1.39 26 Nov 2006 18:16:20 -0000
+++ appdb/index.php 26 Nov 2006 18:16:20 -0000
@@ -47,7 +47,7 @@ if(!$_SESSION['current']->isLoggedIn())
$str_benefits
- <p>We'd like to thank your for being a member and being logged in the system. Your help in
+ <p>We'd like to thank you for being a member and being logged in to the system. Your help in
stomping out Wine issues will be greatly appreciated.</p>";
}
ChangeSet ID: 30025
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2006/11/26 11:15:38
Modified files:
admin : moveAppVersion.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Fix moving versions by having the move version form update the internal version variable and then call the
Version::update() method to perform the update.
Patch: http://cvs.winehq.org/patch.py?id=30025
Old revision New revision Changes Path
1.9 1.10 +2 -1 appdb/admin/moveAppVersion.php
Index: appdb/admin/moveAppVersion.php
diff -u -p appdb/admin/moveAppVersion.php:1.9 appdb/admin/moveAppVersion.php:1.10
--- appdb/admin/moveAppVersion.php:1.9 26 Nov 2006 17:15:38 -0000
+++ appdb/admin/moveAppVersion.php 26 Nov 2006 17:15:38 -0000
@@ -22,7 +22,8 @@ if(!empty($aClean['sAction']))
{
/* move this version to the given application */
$oVersion = new Version($aClean['iVersionId']);
- $oVersion->update(null, null, null, null, $aClean['iAppId']);
+ $oVersion->iAppId = $aClean['iAppId'];
+ $oVersion->update();
/* redirect to the application we just moved this version to */
util_redirect_and_exit(apidb_fullurl("appview.php?iAppId=".$aClean['iAppId']));