winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2006
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
792 discussions
Start a n
N
ew thread
Andrey Turkin : atl: Implement AtlPixelToHiMetric and AtlHiMetricToPixel.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: abc3769ad2a4b717b404b006d7fc9728d10a635a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=abc3769ad2a4b717b404b006d…
Author: Andrey Turkin <pancha(a)mail.nnov.ru> Date: Mon Oct 30 18:57:48 2006 +0300 atl: Implement AtlPixelToHiMetric and AtlHiMetricToPixel. --- dlls/atl/Makefile.in | 2 +- dlls/atl/atl.spec | 4 ++-- dlls/atl/atl_main.c | 17 +++++++++++++++++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/dlls/atl/Makefile.in b/dlls/atl/Makefile.in index e54cf64..fc20950 100644 --- a/dlls/atl/Makefile.in +++ b/dlls/atl/Makefile.in @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = atl.dll IMPORTLIB = libatl.$(IMPLIBEXT) -IMPORTS = ole32 shlwapi user32 advapi32 kernel32 +IMPORTS = ole32 shlwapi user32 gdi32 advapi32 kernel32 EXTRALIBS = -luuid C_SRCS = \ diff --git a/dlls/atl/atl.spec b/dlls/atl/atl.spec index f7f46fe..c8f0199 100644 --- a/dlls/atl/atl.spec +++ b/dlls/atl/atl.spec @@ -19,8 +19,8 @@ 24 stub AtlWaitWithMessageLoop 25 stub AtlSetErrorInfo 26 stub AtlCreateTargetDC -27 stub AtlHiMetricToPixel -28 stub AtlPixelToHiMetric +27 stdcall AtlHiMetricToPixel(ptr ptr) +28 stdcall AtlPixelToHiMetric(ptr ptr) 29 stub AtlDevModeW2A 30 stdcall AtlComPtrAssign(ptr ptr) 31 stub AtlComQIPtrAssign diff --git a/dlls/atl/atl_main.c b/dlls/atl/atl_main.c index 2fdf901..f7a6fc4 100644 --- a/dlls/atl/atl_main.c +++ b/dlls/atl/atl_main.c @@ -26,6 +26,7 @@ #define COBJMACROS #include "windef.h" #include "winbase.h" #include "winerror.h" +#include "wingdi.h" #include "winuser.h" #include "wine/debug.h" #include "objbase.h" @@ -421,3 +422,19 @@ ATOM WINAPI AtlModuleRegisterWndClassInf TRACE("returning 0x%04x\n", atom); return atom; } + +void WINAPI AtlHiMetricToPixel(const SIZEL* lpHiMetric, SIZEL* lpPix) +{ + HDC dc = GetDC(NULL); + lpPix->cx = lpHiMetric->cx * GetDeviceCaps( dc, LOGPIXELSX ) / 100; + lpPix->cy = lpHiMetric->cy * GetDeviceCaps( dc, LOGPIXELSY ) / 100; + ReleaseDC( NULL, dc ); +} + +void WINAPI AtlPixelToHiMetric(const SIZEL* lpPix, SIZEL* lpHiMetric) +{ + HDC dc = GetDC(NULL); + lpHiMetric->cx = 100 * lpPix->cx / GetDeviceCaps( dc, LOGPIXELSX ); + lpHiMetric->cy = 100 * lpPix->cy / GetDeviceCaps( dc, LOGPIXELSY ); + ReleaseDC( NULL, dc ); +}
1
0
0
0
Jacek Caban : mshtml: Added implementation of QueryStatus(IDM_UNDERLINE).
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: 64fe2774289e1df5e74b083e3eb198e7372ec1d5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=64fe2774289e1df5e74b083e3…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:57 2006 +0100 mshtml: Added implementation of QueryStatus(IDM_UNDERLINE). --- dlls/mshtml/olecmd.c | 7 ++++--- dlls/mshtml/tests/htmldoc.c | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index a373269..68762a9 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -41,6 +41,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); #define NSCMD_BOLD "cmd_bold" #define NSCMD_ITALIC "cmd_italic" +#define NSCMD_UNDERLINE "cmd_underline" /********************************************************** * IOleCommandTarget implementation @@ -408,7 +409,7 @@ static HRESULT exec_underline(HTMLDocume TRACE("(%p)\n", This); if(This->nscontainer) - do_ns_command(This->nscontainer, "cmd_underline", NULL); + do_ns_command(This->nscontainer, NSCMD_UNDERLINE, NULL); return S_OK; } @@ -674,8 +675,8 @@ static HRESULT WINAPI OleCommandTarget_Q prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; break; case IDM_UNDERLINE: - FIXME("CGID_MSHTML: IDM_UNDERLINE\n"); - prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; + TRACE("CGID_MSHTML: IDM_UNDERLINE\n"); + prgCmds[i].cmdf = query_edit_status(This, NSCMD_UNDERLINE); break; case IDM_HORIZONTALLINE: FIXME("CGID_MSHTML: IDM_HORIZONTALLINE\n"); diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index bf05400..6b28b13 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -2041,6 +2041,7 @@ static void test_MSHTML_QueryStatus(IUnk test_QueryStatus(unk, &CGID_MSHTML, IDM_BOLD, cmdf); test_QueryStatus(unk, &CGID_MSHTML, IDM_ITALIC, cmdf); + test_QueryStatus(unk, &CGID_MSHTML, IDM_UNDERLINE, cmdf); } static void test_OleCommandTarget(IUnknown *unk)
1
0
0
0
Jacek Caban : mshtml: Added implementation of QueryStatus(IDM_ITALIC).
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: 5e0d749c2fb154b1e72db5bbe062b3f8cafe8e55 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5e0d749c2fb154b1e72db5bbe…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:44 2006 +0100 mshtml: Added implementation of QueryStatus(IDM_ITALIC). --- dlls/mshtml/olecmd.c | 7 ++++--- dlls/mshtml/tests/htmldoc.c | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index 6c619c7..a373269 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -40,6 +40,7 @@ #include "mshtml_private.h" WINE_DEFAULT_DEBUG_CHANNEL(mshtml); #define NSCMD_BOLD "cmd_bold" +#define NSCMD_ITALIC "cmd_italic" /********************************************************** * IOleCommandTarget implementation @@ -397,7 +398,7 @@ static HRESULT exec_italic(HTMLDocument TRACE("(%p)\n", This); if(This->nscontainer) - do_ns_command(This->nscontainer, "cmd_italic", NULL); + do_ns_command(This->nscontainer, NSCMD_ITALIC, NULL); return S_OK; } @@ -657,8 +658,8 @@ static HRESULT WINAPI OleCommandTarget_Q prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; break; case IDM_ITALIC: - FIXME("CGID_MSHTML: IDM_ITALIC\n"); - prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; + TRACE("CGID_MSHTML: IDM_ITALIC\n"); + prgCmds[i].cmdf = query_edit_status(This, NSCMD_ITALIC); break; case IDM_JUSTIFYCENTER: FIXME("CGID_MSHTML: IDM_JUSTIFYCENTER\n"); diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index db56d24..bf05400 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -2040,6 +2040,7 @@ static void test_MSHTML_QueryStatus(IUnk else unk = _unk; test_QueryStatus(unk, &CGID_MSHTML, IDM_BOLD, cmdf); + test_QueryStatus(unk, &CGID_MSHTML, IDM_ITALIC, cmdf); } static void test_OleCommandTarget(IUnknown *unk)
1
0
0
0
Jacek Caban : mshtml: Added more QueryStatus tests.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: da3f18745e4d1b764137c2704acb845d7c1068b5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=da3f18745e4d1b764137c2704…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:33 2006 +0100 mshtml: Added more QueryStatus tests. --- dlls/mshtml/tests/htmldoc.c | 45 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index d2d9d92..db56d24 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -115,6 +115,7 @@ static BOOL expect_LockContainer_fLock; static BOOL expect_SetActiveObject_active; static BOOL set_clientsite = FALSE, container_locked = FALSE; static BOOL readystate_set_loading = FALSE; +static BOOL editmode = FALSE; static enum load_state_t { LD_DOLOAD, LD_LOADING, @@ -127,6 +128,7 @@ static LPCOLESTR expect_status_text = NU static HRESULT QueryInterface(REFIID riid, void **ppv); static void test_readyState(IUnknown*); +static void test_MSHTML_QueryStatus(IUnknown*,DWORD); static HRESULT WINAPI HlinkFrame_QueryInterface(IHlinkFrame *iface, REFIID riid, void **ppv) { @@ -249,6 +251,10 @@ static HRESULT WINAPI PropertyNotifySink switch(dispID) { case DISPID_READYSTATE: CHECK_EXPECT2(OnChanged_READYSTATE); + test_MSHTML_QueryStatus(NULL, OLECMDF_SUPPORTED + | (editmode && (load_state == LD_INTERACTIVE || load_state == LD_COMPLETE) + ? OLECMDF_ENABLED : 0)); + if(readystate_set_loading) { readystate_set_loading = FALSE; load_state = LD_LOADING; @@ -2006,6 +2012,36 @@ static const OLECMDF expect_cmds[OLECMDI OLECMDF_SUPPORTED /* OLECMDID_GETPRINTTEMPLATE */ }; +static void test_QueryStatus(IUnknown *unk, REFIID cgid, ULONG cmdid, DWORD cmdf) +{ + IOleCommandTarget *cmdtrg; + OLECMD olecmd = {cmdid, 0}; + HRESULT hres; + + hres = IUnknown_QueryInterface(unk, &IID_IOleCommandTarget, (void**)&cmdtrg); + ok(hres == S_OK, "QueryInterface(IID_IOleCommandTarget failed: %08x\n", hres); + if(FAILED(hres)) + return; + + hres = IOleCommandTarget_QueryStatus(cmdtrg, cgid, 1, &olecmd, NULL); + ok(hres == S_OK, "QueryStatus failed: %08x\n", hres); + + IOleCommandTarget_Release(cmdtrg); + + ok(olecmd.cmdID == cmdid, "cmdID changed\n"); + ok(olecmd.cmdf == cmdf, "cmdf=%08x, expected %08x\n", olecmd.cmdf, cmdf); +} + +static void test_MSHTML_QueryStatus(IUnknown *unk, DWORD cmdf) +{ + static IUnknown *_unk; + + if(unk) _unk = unk; + else unk = _unk; + + test_QueryStatus(unk, &CGID_MSHTML, IDM_BOLD, cmdf); +} + static void test_OleCommandTarget(IUnknown *unk) { IOleCommandTarget *cmdtrg; @@ -2147,6 +2183,8 @@ static void test_exec_editmode(IUnknown CHECK_CALLED(OnChanged_READYSTATE); IOleCommandTarget_Release(cmdtrg); + + editmode = TRUE; } static HWND create_container_window(void) @@ -2577,6 +2615,7 @@ static void init_test(enum load_state_t set_clientsite = FALSE; call_UIActivate = FALSE; load_state = ls; + editmode = FALSE; } static void test_HTMLDocument(enum load_state_t ls) @@ -2594,6 +2633,7 @@ static void test_HTMLDocument(enum load_ return; test_QueryInterface(unk); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED); test_ConnectionPointContainer(unk); test_Persist(unk); if(load_state == LD_NO) @@ -2608,6 +2648,7 @@ static void test_HTMLDocument(enum load_ if(load_state == LD_LOADING) test_download(FALSE); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED); test_OleCommandTarget_fail(unk); test_OleCommandTarget(unk); test_OnAmbientPropertyChange(unk); @@ -2677,6 +2718,7 @@ static void test_HTMLDocument_hlink(void test_download(FALSE); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED); test_exec_onunload(unk); test_Window(unk, TRUE); test_InPlaceDeactivate(unk, TRUE); @@ -2712,11 +2754,14 @@ static void test_editing_mode(void) test_ConnectionPointContainer(unk); test_ClientSite(oleobj, CLIENTSITE_EXPECTPATH); test_DoVerb(oleobj); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED); IOleObject_Release(oleobj); test_exec_editmode(unk); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED); test_download(TRUE); + test_MSHTML_QueryStatus(unk, OLECMDF_SUPPORTED|OLECMDF_ENABLED); test_UIDeactivate(); test_InPlaceDeactivate(unk, TRUE);
1
0
0
0
Jacek Caban : mshtml: Added implementation of QueryStatus(IDM_BOLD).
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: 227be057c222756de196d879790d05e92f29b47d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=227be057c222756de196d8797…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:17 2006 +0100 mshtml: Added implementation of QueryStatus(IDM_BOLD). --- dlls/mshtml/olecmd.c | 31 +++++++++++++++++++++++++++---- 1 files changed, 27 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index 908ed90..6c619c7 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -39,6 +39,8 @@ #include "mshtml_private.h" WINE_DEFAULT_DEBUG_CHANNEL(mshtml); +#define NSCMD_BOLD "cmd_bold" + /********************************************************** * IOleCommandTarget implementation */ @@ -245,7 +247,7 @@ static void do_ns_command(NSContainer *T nsIInterfaceRequestor *iface_req; nsresult nsres; - FIXME("(%p)\n", This); + TRACE("(%p)\n", This); nsres = nsIWebBrowser_QueryInterface(This->webbrowser, &IID_nsIInterfaceRequestor, (void**)&iface_req); @@ -298,6 +300,27 @@ static nsresult get_ns_command_state(NSC return nsres; } +static DWORD query_edit_status(HTMLDocument *This, const char *nscmd) +{ + nsICommandParams *nsparam; + PRBool b = FALSE; + + if(!This->nscontainer) { + FIXME("dummy not implemented\n"); + return OLECMDF_SUPPORTED; + } + + if(This->usermode != EDITMODE || This->readystate < READYSTATE_INTERACTIVE) + return OLECMDF_SUPPORTED; + + nsparam = create_nscommand_params(); + get_ns_command_state(This->nscontainer, nscmd, nsparam); + + nsICommandParams_GetBooleanValue(nsparam, "state_enabled", &b); + + return OLECMDF_SUPPORTED | OLECMDF_ENABLED | (b ? OLECMDF_LATCHED : 0); +} + static HRESULT exec_fontname(HTMLDocument *This, VARIANT *in, VARIANT *out) { TRACE("(%p)->(%p %p)\n", This, in, out); @@ -364,7 +387,7 @@ static HRESULT exec_bold(HTMLDocument *T TRACE("(%p)\n", This); if(This->nscontainer) - do_ns_command(This->nscontainer, "cmd_bold", NULL); + do_ns_command(This->nscontainer, NSCMD_BOLD, NULL); return S_OK; } @@ -626,8 +649,8 @@ static HRESULT WINAPI OleCommandTarget_Q prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; break; case IDM_BOLD: - FIXME("CGID_MSHTML: IDM_BOLD\n"); - prgCmds[i].cmdf = OLECMDF_SUPPORTED|OLECMDF_ENABLED; + TRACE("CGID_MSHTML: IDM_BOLD\n"); + prgCmds[i].cmdf = query_edit_status(This, NSCMD_BOLD); break; case IDM_FORECOLOR: FIXME("CGID_MSHTML: IDM_FORECOLOR\n");
1
0
0
0
Jacek Caban : mshtml: Added more edit mode tests.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: f003d3c56921412085e323b244e2a26b96ebef3c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f003d3c56921412085e323b24…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:12 2006 +0100 mshtml: Added more edit mode tests. --- dlls/mshtml/tests/htmldoc.c | 100 +++++++++++++++++++++++++++--------------- 1 files changed, 64 insertions(+), 36 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index cd3162d..d2d9d92 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -1804,24 +1804,33 @@ static void test_Load(IPersistMoniker *p (IUnknown*)&ClientSite); SET_EXPECT(GetDisplayName); - SET_EXPECT(GetHostInfo); - SET_EXPECT(Invoke_AMBIENT_USERMODE); - SET_EXPECT(Invoke_AMBIENT_SILENT); - SET_EXPECT(Invoke_AMBIENT_DLCONTROL); - SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); - SET_EXPECT(Invoke_AMBIENT_USERAGENT); - SET_EXPECT(Invoke_AMBIENT_PALETTE); - SET_EXPECT(GetOptionKeyPath); - SET_EXPECT(GetOverrideKeyPath); - SET_EXPECT(GetWindow); - SET_EXPECT(QueryStatus_SETPROGRESSTEXT); - SET_EXPECT(Exec_SETPROGRESSMAX); - SET_EXPECT(Exec_SETPROGRESSPOS); - SET_EXPECT(Exec_ShellDocView_37); + if(!set_clientsite) { + SET_EXPECT(Invoke_AMBIENT_USERMODE); + SET_EXPECT(GetHostInfo); + SET_EXPECT(Invoke_AMBIENT_DLCONTROL); + SET_EXPECT(Invoke_AMBIENT_SILENT); + SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + SET_EXPECT(Invoke_AMBIENT_USERAGENT); + SET_EXPECT(Invoke_AMBIENT_PALETTE); + SET_EXPECT(GetOptionKeyPath); + SET_EXPECT(GetOverrideKeyPath); + SET_EXPECT(GetWindow); + SET_EXPECT(QueryStatus_SETPROGRESSTEXT); + SET_EXPECT(Exec_SETPROGRESSMAX); + SET_EXPECT(Exec_SETPROGRESSPOS); + SET_EXPECT(Exec_ShellDocView_37); + } + if(!container_locked) { + SET_EXPECT(GetContainer); + SET_EXPECT(LockContainer); + } SET_EXPECT(OnChanged_READYSTATE); SET_EXPECT(BindToStorage); - SET_EXPECT(GetContainer); - SET_EXPECT(LockContainer); + if(set_clientsite) { + SET_EXPECT(Invoke_AMBIENT_SILENT); + SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + SET_EXPECT(Exec_ShellDocView_37); + } expect_LockContainer_fLock = TRUE; readystate_set_loading = TRUE; @@ -1829,24 +1838,34 @@ static void test_Load(IPersistMoniker *p ok(hres == S_OK, "Load failed: %08x\n", hres); CHECK_CALLED(GetDisplayName); - CHECK_CALLED(GetHostInfo); - CHECK_CALLED(Invoke_AMBIENT_USERMODE); - CHECK_CALLED(Invoke_AMBIENT_SILENT); - CHECK_CALLED(Invoke_AMBIENT_DLCONTROL); - CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); - CHECK_CALLED(Invoke_AMBIENT_USERAGENT); - CHECK_CALLED(Invoke_AMBIENT_PALETTE); - CHECK_CALLED(GetOptionKeyPath); - CHECK_CALLED(GetOverrideKeyPath); - CHECK_CALLED(GetWindow); - CHECK_CALLED(QueryStatus_SETPROGRESSTEXT); - CHECK_CALLED(Exec_SETPROGRESSMAX); - CHECK_CALLED(Exec_SETPROGRESSPOS); - CHECK_CALLED(Exec_ShellDocView_37); + if(!set_clientsite) { + CHECK_CALLED(Invoke_AMBIENT_USERMODE); + CHECK_CALLED(GetHostInfo); + CHECK_CALLED(Invoke_AMBIENT_DLCONTROL); + CHECK_CALLED(Invoke_AMBIENT_SILENT); + CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_CALLED(Invoke_AMBIENT_USERAGENT); + CHECK_CALLED(Invoke_AMBIENT_PALETTE); + CHECK_CALLED(GetOptionKeyPath); + CHECK_CALLED(GetOverrideKeyPath); + CHECK_CALLED(GetWindow); + CHECK_CALLED(QueryStatus_SETPROGRESSTEXT); + CHECK_CALLED(Exec_SETPROGRESSMAX); + CHECK_CALLED(Exec_SETPROGRESSPOS); + CHECK_CALLED(Exec_ShellDocView_37); + } + if(!container_locked) { + CHECK_CALLED(GetContainer); + CHECK_CALLED(LockContainer); + container_locked = TRUE; + } CHECK_CALLED(OnChanged_READYSTATE); CHECK_CALLED(BindToStorage); - CHECK_CALLED(GetContainer); - CHECK_CALLED(LockContainer); + if(set_clientsite) { + CHECK_CALLED(Invoke_AMBIENT_SILENT); + CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_CALLED(Exec_ShellDocView_37); + } set_clientsite = container_locked = TRUE; @@ -1855,7 +1874,7 @@ static void test_Load(IPersistMoniker *p test_readyState((IUnknown*)persist); } -static void test_download(void) +static void test_download(BOOL verb_done) { HWND hwnd; MSG msg; @@ -1865,6 +1884,10 @@ static void test_download(void) test_readyState(NULL); + if(verb_done) { + SET_EXPECT(Exec_SETPROGRESSMAX); + SET_EXPECT(GetHostInfo); + } SET_EXPECT(SetStatusText); SET_EXPECT(Exec_SETDOWNLOADSTATE_1); SET_EXPECT(GetDropTarget); @@ -1882,6 +1905,10 @@ static void test_download(void) DispatchMessage(&msg); } + if(verb_done) { + CHECK_CALLED(Exec_SETPROGRESSMAX); + CHECK_CALLED(GetHostInfo); + } CHECK_CALLED(SetStatusText); CHECK_CALLED(Exec_SETDOWNLOADSTATE_1); CHECK_CALLED(GetDropTarget); @@ -1987,7 +2014,7 @@ static void test_OleCommandTarget(IUnkno HRESULT hres; hres = IUnknown_QueryInterface(unk, &IID_IOleCommandTarget, (void**)&cmdtrg); - ok(hres == S_OK, "QueryInterface(IIDIOleM=CommandTarget failed: %08x\n", hres); + ok(hres == S_OK, "QueryInterface(IID_IOleCommandTarget failed: %08x\n", hres); if(FAILED(hres)) return; @@ -2579,7 +2606,7 @@ static void test_HTMLDocument(enum load_ } if(load_state == LD_LOADING) - test_download(); + test_download(FALSE); test_OleCommandTarget_fail(unk); test_OleCommandTarget(unk); @@ -2648,7 +2675,7 @@ static void test_HTMLDocument_hlink(void test_Persist(unk); test_Navigate(unk); - test_download(); + test_download(FALSE); test_exec_onunload(unk); test_Window(unk, TRUE); @@ -2689,6 +2716,7 @@ static void test_editing_mode(void) IOleObject_Release(oleobj); test_exec_editmode(unk); + test_download(TRUE); test_UIDeactivate(); test_InPlaceDeactivate(unk, TRUE);
1
0
0
0
Jacek Caban : mshtml: Load about:blank in exec_editmode.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: cf075bdf00830dd0eda259bda5ea4a8ca746382d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cf075bdf00830dd0eda259bda…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:06 2006 +0100 mshtml: Load about:blank in exec_editmode. --- dlls/mshtml/olecmd.c | 50 +++++++++----------------------------------------- 1 files changed, 9 insertions(+), 41 deletions(-) diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index 7e6e0cf..908ed90 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -448,8 +448,11 @@ static void setup_ns_editing(NSContainer static HRESULT exec_editmode(HTMLDocument *This) { + IMoniker *mon; HRESULT hres; + static const WCHAR wszAboutBlank[] = {'a','b','o','u','t',':','b','l','a','n','k',0}; + TRACE("(%p)\n", This); This->usermode = EDITMODE; @@ -457,20 +460,6 @@ static HRESULT exec_editmode(HTMLDocumen if(This->frame) IOleInPlaceFrame_SetStatusText(This->frame, NULL); - if(This->client) { - IOleCommandTarget *cmdtrg = NULL; - - hres = IOleClientSite_QueryInterface(This->client, &IID_IOleCommandTarget, - (void**)&cmdtrg); - if(SUCCEEDED(hres)) { - VARIANT var; - - V_VT(&var) = VT_I4; - V_I4(&var) = 0; - IOleCommandTarget_Exec(cmdtrg, &CGID_ShellDocView, 37, 0, &var, NULL); - } - } - if(This->hostui) { DOCHOSTUIINFO hostinfo; @@ -484,37 +473,16 @@ static HRESULT exec_editmode(HTMLDocumen debugstr_w(hostinfo.pchHostCss), debugstr_w(hostinfo.pchHostNS)); } - if(This->client) { - VARIANT silent, offline; - - hres = get_client_disp_property(This->client, DISPID_AMBIENT_SILENT, &silent); - if(SUCCEEDED(hres)) { - if(V_VT(&silent) != VT_BOOL) - WARN("V_VT(silent) = %d\n", V_VT(&silent)); - else if(V_BOOL(&silent)) - FIXME("silent == true\n"); - } - - hres = get_client_disp_property(This->client, - DISPID_AMBIENT_OFFLINEIFNOTCONNECTED, &offline); - if(SUCCEEDED(hres)) { - if(V_VT(&silent) != VT_BOOL) - WARN("V_VT(offline) = %d\n", V_VT(&silent)); - else if(V_BOOL(&silent)) - FIXME("offline == true\n"); - } - } - if(This->nscontainer) setup_ns_editing(This->nscontainer); - /* - * FIXME: We should load about:protocol here. - */ - This->readystate = READYSTATE_LOADING; - call_property_onchanged(This->cp_propnotif, DISPID_READYSTATE); + hres = CreateURLMoniker(NULL, wszAboutBlank, &mon); + if(FAILED(hres)) { + FIXME("CreateURLMoniker failed: %08x\n", hres); + return hres; + } - return S_OK; + return IPersistMoniker_Load(PERSISTMON(This), TRUE, mon, NULL, 0); } static HRESULT exec_baselinefont3(HTMLDocument *This)
1
0
0
0
Jacek Caban : mshtml: Added beginning of set_progress task implementation.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: d6108c6c247121781c8950047039db544dfc683d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d6108c6c247121781c8950047…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:34:01 2006 +0100 mshtml: Added beginning of set_progress task implementation. --- dlls/mshtml/mshtml_private.h | 3 ++- dlls/mshtml/persist.c | 10 ++++++++++ dlls/mshtml/task.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 52 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index b3ad479..b352c5f 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -353,7 +353,8 @@ typedef struct task_t { enum { TASK_SETDOWNLOADSTATE, - TASK_PARSECOMPLETE + TASK_PARSECOMPLETE, + TASK_SETPROGRESS } task_id; struct task_t *next; diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 7b35e96..39c3a7e 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -243,6 +243,16 @@ static HRESULT WINAPI PersistMoniker_Loa bscallback = create_bscallback(pimkName); + if(This->frame) { + task = mshtml_alloc(sizeof(task_t)); + + task->doc = This; + task->task_id = TASK_SETPROGRESS; + task->next = NULL; + + push_task(task); + } + task = mshtml_alloc(sizeof(task_t)); task->doc = This; diff --git a/dlls/mshtml/task.c b/dlls/mshtml/task.c index 6b5d093..84108d1 100644 --- a/dlls/mshtml/task.c +++ b/dlls/mshtml/task.c @@ -179,6 +179,44 @@ static void set_parsecomplete(HTMLDocume } } +static void set_progress(HTMLDocument *doc) +{ + IOleCommandTarget *olecmd = NULL; + HRESULT hres; + + TRACE("(%p)\n", doc); + + if(doc->client) + IOleClientSite_QueryInterface(doc->client, &IID_IOleCommandTarget, (void**)&olecmd); + + if(olecmd) { + VARIANT progress_max, progress; + + V_VT(&progress_max) = VT_I4; + V_I4(&progress_max) = 0; /* FIXME */ + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSMAX, OLECMDEXECOPT_DONTPROMPTUSER, + &progress_max, NULL); + + V_VT(&progress) = VT_I4; + V_I4(&progress) = 0; /* FIXME */ + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, OLECMDEXECOPT_DONTPROMPTUSER, + &progress, NULL); + } + + if(doc->usermode == EDITMODE && doc->hostui) { + DOCHOSTUIINFO hostinfo; + + memset(&hostinfo, 0, sizeof(DOCHOSTUIINFO)); + hostinfo.cbSize = sizeof(DOCHOSTUIINFO); + hres = IDocHostUIHandler_GetHostInfo(doc->hostui, &hostinfo); + if(SUCCEEDED(hres)) + /* FIXME: use hostinfo */ + TRACE("hostinfo = {%u %08x %08x %s %s}\n", + hostinfo.cbSize, hostinfo.dwFlags, hostinfo.dwDoubleClick, + debugstr_w(hostinfo.pchHostCss), debugstr_w(hostinfo.pchHostNS)); + } +} + static void process_task(task_t *task) { switch(task->task_id) { @@ -186,6 +224,8 @@ static void process_task(task_t *task) return set_downloading(task->doc); case TASK_PARSECOMPLETE: return set_parsecomplete(task->doc); + case TASK_SETPROGRESS: + return set_progress(task->doc); default: ERR("Wrong task_id %d\n", task->task_id); }
1
0
0
0
Jacek Caban : mshtml: Call SetStatusText in set_parsecomplete.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: 0cd636c3555bca9c28580d96e4ad25db0ac9d2b7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0cd636c3555bca9c28580d96e…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:33:55 2006 +0100 mshtml: Call SetStatusText in set_parsecomplete. --- dlls/mshtml/task.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/task.c b/dlls/mshtml/task.c index 25b9501..6b5d093 100644 --- a/dlls/mshtml/task.c +++ b/dlls/mshtml/task.c @@ -97,7 +97,7 @@ static void set_downloading(HTMLDocument TRACE("(%p)\n", doc); - if(doc->frame) + if(doc->frame) IOleInPlaceFrame_SetStatusText(doc->frame, NULL /* FIXME */); if(!doc->client) @@ -160,6 +160,11 @@ static void set_parsecomplete(HTMLDocume doc->readystate = READYSTATE_COMPLETE; call_property_onchanged(doc->cp_propnotif, DISPID_READYSTATE); + if(doc->frame) { + static const WCHAR wszDone[] = {'D','o','n','e',0}; + IOleInPlaceFrame_SetStatusText(doc->frame, wszDone); + } + if(olecmd) { VARIANT title; WCHAR empty[] = {0};
1
0
0
0
Jacek Caban : mshtml: Get DISPID_AMBIENT_SILENT and DISPID_AMBIENT_OFFLINECONNECTED property in IPersistMoniker ::Load.
by Alexandre Julliard
02 Nov '06
02 Nov '06
Module: wine Branch: master Commit: f09890eade58d93b62212a0f1c1047452e0746a6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f09890eade58d93b62212a0f1…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 2 17:30:27 2006 +0100 mshtml: Get DISPID_AMBIENT_SILENT and DISPID_AMBIENT_OFFLINECONNECTED property in IPersistMoniker::Load. --- dlls/mshtml/persist.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index a52f015..7b35e96 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -30,6 +30,7 @@ #include "winbase.h" #include "winuser.h" #include "ole2.h" #include "shlguid.h" +#include "idispids.h" #include "wine/debug.h" #include "wine/unicode.h" @@ -219,6 +220,27 @@ static HRESULT WINAPI PersistMoniker_Loa } } + if(This->client) { + VARIANT silent, offline; + + hres = get_client_disp_property(This->client, DISPID_AMBIENT_SILENT, &silent); + if(SUCCEEDED(hres)) { + if(V_VT(&silent) != VT_BOOL) + WARN("V_VT(silent) = %d\n", V_VT(&silent)); + else if(V_BOOL(&silent)) + FIXME("silent == true\n"); + } + + hres = get_client_disp_property(This->client, + DISPID_AMBIENT_OFFLINEIFNOTCONNECTED, &offline); + if(SUCCEEDED(hres)) { + if(V_VT(&silent) != VT_BOOL) + WARN("V_VT(offline) = %d\n", V_VT(&silent)); + else if(V_BOOL(&silent)) + FIXME("offline == true\n"); + } + } + bscallback = create_bscallback(pimkName); task = mshtml_alloc(sizeof(task_t));
1
0
0
0
← Newer
1
...
72
73
74
75
76
77
78
79
80
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
Results per page:
10
25
50
100
200