winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2006
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
5 participants
746 discussions
Start a n
N
ew thread
Roderick Colenbrander : wined3d: Better GPU detection.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: de97fa7a3be906e06f99c730c52390f451b8a974 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=de97fa7a3be906e06f99c73…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sat Aug 19 11:58:23 2006 +0200 wined3d: Better GPU detection. --- dlls/wined3d/directx.c | 205 +++++++++++++++++++++++++++++----------- dlls/wined3d/wined3d_private.h | 6 + include/wine/wined3d_gl.h | 30 ++++-- 3 files changed, 177 insertions(+), 64 deletions(-) Diff:
http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=de97fa7a3be906e06f9…
1
0
0
0
H. Verbeet : wined3d: Improve float constant loading a bit.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: 09eb0c40a63a09150c1c70308864017c27f72fbc URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=09eb0c40a63a09150c1c703…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Sat Aug 19 17:24:02 2006 +0200 wined3d: Improve float constant loading a bit. - Use a list to keep track of what constants are set. - Move TRACEs and checkGLcall calls out of the main constant loading loop. --- dlls/wined3d/arb_program_shader.c | 78 +++++++++++++++++++-------------- dlls/wined3d/device.c | 14 +++++- dlls/wined3d/glsl_shader.c | 87 +++++++++++++++++++++++++------------ dlls/wined3d/stateblock.c | 13 ++++++ dlls/wined3d/wined3d_private.h | 7 +++ 5 files changed, 135 insertions(+), 64 deletions(-) Diff:
http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=09eb0c40a63a09150c1…
1
0
0
0
H. Verbeet : wined3d: Lookup GLSL float uniform locations only once per program.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: 49f4c68e29a9eed401b8e0f3f33a03fbe0d47667 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=49f4c68e29a9eed401b8e0f…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Sat Aug 19 17:23:20 2006 +0200 wined3d: Lookup GLSL float uniform locations only once per program. --- dlls/wined3d/device.c | 29 ++++++++++++++++++++---- dlls/wined3d/drawprim.c | 11 +++++---- dlls/wined3d/glsl_shader.c | 49 +++++++++++++++++----------------------- dlls/wined3d/stateblock.c | 6 ++--- dlls/wined3d/wined3d_private.h | 4 ++- 5 files changed, 57 insertions(+), 42 deletions(-) Diff:
http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=49f4c68e29a9eed401b…
1
0
0
0
H. Verbeet : wined3d: Free the float constant map arrays for all stateblocks.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: efa5f785981bf90354bdea9ea3e4e1e6d81b876d URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=efa5f785981bf90354bdea9…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Sat Aug 19 17:23:02 2006 +0200 wined3d: Free the float constant map arrays for all stateblocks. --- dlls/wined3d/stateblock.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/stateblock.c b/dlls/wined3d/stateblock.c index 6242697..ea77ecd 100644 --- a/dlls/wined3d/stateblock.c +++ b/dlls/wined3d/stateblock.c @@ -254,14 +254,7 @@ static ULONG WINAPI IWineD3DStateBlockI if (NULL != This->vertexDecl) { IWineD3DVertexDeclaration_Release(This->vertexDecl); } - - HeapFree(GetProcessHeap(), 0, This->vertexShaderConstantF); - HeapFree(GetProcessHeap(), 0, This->set.vertexShaderConstantsF); - HeapFree(GetProcessHeap(), 0, This->changed.vertexShaderConstantsF); - HeapFree(GetProcessHeap(), 0, This->pixelShaderConstantF); - HeapFree(GetProcessHeap(), 0, This->set.pixelShaderConstantsF); - HeapFree(GetProcessHeap(), 0, This->changed.pixelShaderConstantsF); - + /* NOTE: according to MSDN: The application is responsible for making sure the texture references are cleared down */ for (counter = 0; counter < GL_LIMITS(sampler_stages); counter++) { if (This->textures[counter]) { @@ -273,6 +266,14 @@ static ULONG WINAPI IWineD3DStateBlockI } } + + HeapFree(GetProcessHeap(), 0, This->vertexShaderConstantF); + HeapFree(GetProcessHeap(), 0, This->set.vertexShaderConstantsF); + HeapFree(GetProcessHeap(), 0, This->changed.vertexShaderConstantsF); + HeapFree(GetProcessHeap(), 0, This->pixelShaderConstantF); + HeapFree(GetProcessHeap(), 0, This->set.pixelShaderConstantsF); + HeapFree(GetProcessHeap(), 0, This->changed.pixelShaderConstantsF); + HeapFree(GetProcessHeap(), 0, This); } return refCount;
1
0
0
0
H. Verbeet : wined3d: Fix indices for the float constant map.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: 2358fbbb031e3ced2bc8d4f6e06aac17288fca47 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=2358fbbb031e3ced2bc8d4f…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Sat Aug 19 17:22:46 2006 +0200 wined3d: Fix indices for the float constant map. Indices for the float constant map should be multiplied by 4 because we're loading 4 component float vectors, not because the size of a float is 4. --- dlls/wined3d/arb_program_shader.c | 6 +++--- dlls/wined3d/glsl_shader.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 6700de3..7aa6691 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -60,10 +60,10 @@ void shader_arb_load_constantsF( for (i=0; i<max_constants; ++i) { if (NULL == constants_set || constants_set[i]) { TRACE("Loading constants %i: %f, %f, %f, %f\n", i, - constants[i * sizeof(float) + 0], constants[i * sizeof(float) + 1], - constants[i * sizeof(float) + 2], constants[i * sizeof(float) + 3]); + constants[i * 4 + 0], constants[i * 4 + 1], + constants[i * 4 + 2], constants[i * 4 + 3]); - GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, i, &constants[i * sizeof(float)])); + GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, i, &constants[i * 4])); checkGLcall("glProgramEnvParameter4fvARB"); } } diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 0829e88..d222610 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -96,8 +96,8 @@ void shader_glsl_load_constantsF( if (NULL == constants_set || constants_set[i]) { TRACE("Loading constants %i: %f, %f, %f, %f\n", i, - constants[i * sizeof(float) + 0], constants[i * sizeof(float) + 1], - constants[i * sizeof(float) + 2], constants[i * sizeof(float) + 3]); + constants[i * 4 + 0], constants[i * 4 + 1], + constants[i * 4 + 2], constants[i * 4 + 3]); /* TODO: Benchmark and see if it would be beneficial to store the * locations of the constants to avoid looking up each time */ @@ -105,7 +105,7 @@ void shader_glsl_load_constantsF( tmp_loc = GL_EXTCALL(glGetUniformLocationARB(programId, tmp_name)); if (tmp_loc != -1) { /* We found this uniform name in the program - go ahead and send the data */ - GL_EXTCALL(glUniform4fvARB(tmp_loc, 1, &constants[i * sizeof(float)])); + GL_EXTCALL(glUniform4fvARB(tmp_loc, 1, &constants[i * 4])); checkGLcall("glUniform4fvARB"); } }
1
0
0
0
Jacek Caban : mshtml: Added IDM_BOLD implementation.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: 4e418499cafcb0d991bbf209a3f707e8f7541aac URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=4e418499cafcb0d991bbf20…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 18 23:14:44 2006 +0200 mshtml: Added IDM_BOLD implementation. --- dlls/mshtml/nsiface.idl | 17 +++++++++++++++++ dlls/mshtml/olecmd.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index 46e0a23..5de6916 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -109,6 +109,7 @@ typedef nsISupports nsIDOMHTMLOptionsCol typedef nsISupports nsIDOMHTMLCollection; typedef nsISupports nsIDOMRange; typedef nsISupports nsIEditor; +typedef nsISupports nsICommandParams; [ object, @@ -1174,6 +1175,22 @@ interface nsIEditingSession : nsISupport nsresult SetEditorOnControllers(nsIDOMWindow *aWindow, nsIEditor *aEditor); } +[ + object, + uuid(080d2001-f91e-11d4-a73c-f9242928207c) +] +interface nsICommandManager : nsISupports +{ + nsresult AddCommandObserver(nsIObserver *aCommandObserver, const char *aCommandToObserve); + nsresult RemoveCommandObserver(nsIObserver *aCommandObserver, const char *aCommandObserved); + nsresult IsCommandSupported(const char *aCommandName, nsIDOMWindow *aTargetWindow, PRBool *_retval); + nsresult IsCommandEnabled(const char *aCommandName, nsIDOMWindow *aTargetWindow, PRBool *_retval); + nsresult GetCommandState(const char *aCommandName, nsIDOMWindow *aTargetWindow, + nsICommandParams *aCommandParams); + nsresult DoCommand(const char *aCommandName, nsICommandParams *aCommandParams, + nsIDOMWindow *aTargetWindow); +} + /* * NOTE: * This is a private Wine interface that is implemented by our implementation diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index a95f5b1..ef0de64 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -238,6 +238,46 @@ static HRESULT exec_get_print_template(H return E_NOTIMPL; } +static void do_ns_command(NSContainer *This, const char *cmd) +{ + nsICommandManager *cmdmgr; + nsIInterfaceRequestor *iface_req; + nsresult nsres; + + FIXME("(%p)\n", This); + + nsres = nsIWebBrowser_QueryInterface(This->webbrowser, + &IID_nsIInterfaceRequestor, (void**)&iface_req); + if(NS_FAILED(nsres)) { + ERR("Could not get nsIInterfaceRequestor: %08lx\n", nsres); + return; + } + + nsres = nsIInterfaceRequestor_GetInterface(iface_req, &IID_nsICommandManager, + (void**)&cmdmgr); + nsIInterfaceRequestor_Release(iface_req); + if(NS_FAILED(nsres)) { + ERR("Could not get nsICommandManager: %08lx\n", nsres); + return; + } + + nsres = nsICommandManager_DoCommand(cmdmgr, cmd, NULL, NULL); + if(NS_FAILED(nsres)) + ERR("DoCommand(%s) failed: %08lx\n", debugstr_a(cmd), nsres); + + nsICommandManager_Release(cmdmgr); +} + +static HRESULT exec_bold(HTMLDocument *This) +{ + TRACE("(%p)\n", This); + + if(This->nscontainer) + do_ns_command(This->nscontainer, "cmd_bold"); + + return S_OK; +} + static HRESULT exec_browsemode(HTMLDocument *This) { WARN("(%p)\n", This); @@ -504,7 +544,13 @@ static HRESULT WINAPI OleCommandTarget_E return OLECMDERR_E_NOTSUPPORTED; }else if(IsEqualGUID(&CGID_MSHTML, pguidCmdGroup)) { switch(nCmdID) { + case IDM_BOLD: + if(pvaIn || pvaOut) + FIXME("unsupported arguments\n"); + return exec_bold(This); case IDM_BROWSEMODE: + if(pvaIn || pvaOut) + FIXME("unsupported arguments\n"); return exec_browsemode(This); case IDM_EDITMODE: if(pvaIn || pvaOut)
1
0
0
0
Paul Vriens : wintrust: Added stubbed CryptCATAdminEnumCatalogFromHash.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: b20dad068a67693ae708ca0b579802733a904fa7 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=b20dad068a67693ae708ca0…
Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Sun Aug 20 14:17:34 2006 +0200 wintrust: Added stubbed CryptCATAdminEnumCatalogFromHash. --- dlls/wintrust/wintrust.spec | 2 +- dlls/wintrust/wintrust_main.c | 14 ++++++++++++++ include/mscat.h | 3 ++- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/dlls/wintrust/wintrust.spec b/dlls/wintrust/wintrust.spec index a41c77d..58f5267 100644 --- a/dlls/wintrust/wintrust.spec +++ b/dlls/wintrust/wintrust.spec @@ -3,7 +3,7 @@ @ stdcall CryptCATAdminAcquireContext(long ptr long) @ stub CryptCATAdminAddCatalog @ stdcall CryptCATAdminCalcHashFromFileHandle(long ptr ptr long) -@ stub CryptCATAdminEnumCatalogFromHash +@ stdcall CryptCATAdminEnumCatalogFromHash(long ptr long long ptr) @ stub CryptCATAdminPauseServiceForBackup @ stub CryptCATAdminReleaseCatalogContext @ stdcall CryptCATAdminReleaseContext(long long) diff --git a/dlls/wintrust/wintrust_main.c b/dlls/wintrust/wintrust_main.c index e7d0f42..4928116 100644 --- a/dlls/wintrust/wintrust_main.c +++ b/dlls/wintrust/wintrust_main.c @@ -73,6 +73,20 @@ BOOL WINAPI CryptCATAdminCalcHashFromFil } /*********************************************************************** + * CryptCATAdminEnumCatalogFromHash (WINTRUST.@) + */ +HCATINFO WINAPI CryptCATAdminEnumCatalogFromHash(HCATADMIN hCatAdmin, + BYTE* pbHash, + DWORD cbHash, + DWORD dwFlags, + HCATINFO* phPrevCatInfo ) +{ + FIXME("%p %p %ld %ld %p\n", hCatAdmin, pbHash, cbHash, dwFlags, phPrevCatInfo); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return NULL; +} + +/*********************************************************************** * CryptCATAdminReleaseContext (WINTRUST.@) */ BOOL WINAPI CryptCATAdminReleaseContext(HCATADMIN hCatAdmin, DWORD dwFlags ) diff --git a/include/mscat.h b/include/mscat.h index c98a35a..ad3eca0 100644 --- a/include/mscat.h +++ b/include/mscat.h @@ -20,7 +20,7 @@ #ifndef __WINE_MSCAT_H #define __WINE_MSCAT_H typedef HANDLE HCATADMIN; - +typedef HANDLE HCATINFO; #ifdef __cplusplus extern "C" { @@ -28,6 +28,7 @@ #endif BOOL WINAPI CryptCATAdminAcquireContext(HCATADMIN*,const GUID*,DWORD); BOOL WINAPI CryptCATAdminCalcHashFromFileHandle(HANDLE,DWORD*,BYTE*,DWORD); +HCATINFO WINAPI CryptCATAdminEnumCatalogFromHash(HCATADMIN,BYTE*,DWORD,DWORD,HCATINFO*); BOOL WINAPI CryptCATAdminReleaseContext(HCATADMIN,DWORD); #ifdef __cplusplus
1
0
0
0
Dan Kegel : mpr: Fix bug in ProviderOrder comma processing in wnetInit().
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: 50ed26c358e74a0380c9514792e0de6fb844ce27 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=50ed26c358e74a0380c9514…
Author: Dan Kegel <dank(a)kegel.com> Date: Sat Aug 19 21:45:10 2006 -0700 mpr: Fix bug in ProviderOrder comma processing in wnetInit(). --- dlls/mpr/wnet.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/mpr/wnet.c b/dlls/mpr/wnet.c index 804b457..c099c68 100644 --- a/dlls/mpr/wnet.c +++ b/dlls/mpr/wnet.c @@ -260,8 +260,10 @@ void wnetInit(HINSTANCE hInstDll) for (ptr = providers, numToAllocate = 1; ptr; ) { ptr = strchrW(ptr, ','); - if (ptr) + if (ptr) { numToAllocate++; + ptr++; + } } providerTable = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, @@ -287,7 +289,7 @@ void wnetInit(HINSTANCE hInstDll) ptrPrev = ptr; ptr = strchrW(ptr, ','); if (ptr) - *ptr = '\0'; + *ptr++ = '\0'; _tryLoadProvider(ptrPrev); } }
1
0
0
0
Matt Finnicum : riched20: Swap two lines that were in wrong order / caused notification not to be sent.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: cba723836410bbd52b7b6af58db5d80331135b42 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=cba723836410bbd52b7b6af…
Author: Matt Finnicum <mattfinn(a)gmail.com> Date: Sat Aug 19 16:04:49 2006 -0500 riched20: Swap two lines that were in wrong order / caused notification not to be sent. --- dlls/riched20/editor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 048c892..95d11dc 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -2303,8 +2303,8 @@ LRESULT WINAPI RichEditANSIWndProc(HWND case WM_MOUSEMOVE: if (GetCapture() == hWnd) ME_MouseMove(editor, (short)LOWORD(lParam), (short)HIWORD(lParam)); - break; ME_LinkNotify(editor,msg,wParam,lParam); + break; case WM_LBUTTONUP: if (GetCapture() == hWnd) ReleaseCapture();
1
0
0
0
Kai Blin : secur32: Initial working implementation of EncryptMessage and DecryptMessage.
by Alexandre Julliard
21 Aug '06
21 Aug '06
Module: wine Branch: master Commit: bfa596736665e71681ef46d7e0b6bd0afa840279 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=bfa596736665e71681ef46d…
Author: Kai Blin <kai.blin(a)gmail.com> Date: Sat Aug 19 20:02:16 2006 +0200 secur32: Initial working implementation of EncryptMessage and DecryptMessage. --- dlls/secur32/ntlm.c | 87 +++++++++++++++++++++++++++++++++++++++++++-- dlls/secur32/tests/ntlm.c | 2 + 2 files changed, 84 insertions(+), 5 deletions(-) diff --git a/dlls/secur32/ntlm.c b/dlls/secur32/ntlm.c index a1011da..ce8da6f 100644 --- a/dlls/secur32/ntlm.c +++ b/dlls/secur32/ntlm.c @@ -1360,12 +1360,66 @@ static SECURITY_STATUS SEC_ENTRY ntlm_Fr static SECURITY_STATUS SEC_ENTRY ntlm_EncryptMessage(PCtxtHandle phContext, ULONG fQOP, PSecBufferDesc pMessage, ULONG MessageSeqNo) { - TRACE("%p %ld %p %ld stub\n", phContext, fQOP, pMessage, MessageSeqNo); + PNegoHelper helper; + TRACE("(%p %ld %p %ld)\n", phContext, fQOP, pMessage, MessageSeqNo); if(!phContext) return SEC_E_INVALID_HANDLE; - return SEC_E_UNSUPPORTED_FUNCTION; + if(fQOP) + FIXME("Ignoring fQOP\n"); + + if(MessageSeqNo) + FIXME("Ignoring MessageSeqNo\n"); + + if(!pMessage || !pMessage->pBuffers || pMessage->cBuffers < 2 || + pMessage->pBuffers[0].BufferType != SECBUFFER_TOKEN || + !pMessage->pBuffers[0].pvBuffer) + return SEC_E_INVALID_TOKEN; + + if(pMessage->pBuffers[0].cbBuffer < 16) + return SEC_E_BUFFER_TOO_SMALL; + + helper = (PNegoHelper) phContext->dwLower; + + if(helper->neg_flags & NTLMSSP_NEGOTIATE_NTLM2) + { + FIXME("Can't handle NTLMv2 encryption yet, aborting\n"); + return SEC_E_UNSUPPORTED_FUNCTION; + } + else + { + PBYTE sig = pMessage->pBuffers[0].pvBuffer; + ULONG crc = ComputeCrc32(pMessage->pBuffers[1].pvBuffer, + pMessage->pBuffers[1].cbBuffer); + ULONG sign_version = 1l; + + sig[ 0] = (sign_version >> 0) & 0xff; + sig[ 1] = (sign_version >> 8) & 0xff; + sig[ 2] = (sign_version >> 16) & 0xff; + sig[ 3] = (sign_version >> 24) & 0xff; + memset(sig+4, 0, 4); + sig[ 8] = (crc >> 0) & 0xff; + sig[ 9] = (crc >> 8) & 0xff; + sig[10] = (crc >> 16) & 0xff; + sig[11] = (crc >> 24) & 0xff; + sig[12] = (helper->crypt.ntlm.seq_num >> 0) & 0xff; + sig[13] = (helper->crypt.ntlm.seq_num >> 8) & 0xff; + sig[14] = (helper->crypt.ntlm.seq_num >> 16) & 0xff; + sig[15] = (helper->crypt.ntlm.seq_num >> 24) & 0xff; + + SECUR32_arc4Process(helper->crypt.ntlm.a4i, pMessage->pBuffers[1].pvBuffer, + pMessage->pBuffers[1].cbBuffer); + SECUR32_arc4Process(helper->crypt.ntlm.a4i, sig+4, 12); + + if(helper->neg_flags & NTLMSSP_NEGOTIATE_ALWAYS_SIGN || helper->neg_flags == 0) + memset(sig+4, 0, 4); + + ++(helper->crypt.ntlm.seq_num); + + } + + return SEC_E_OK; } /*********************************************************************** @@ -1374,12 +1428,37 @@ static SECURITY_STATUS SEC_ENTRY ntlm_En static SECURITY_STATUS SEC_ENTRY ntlm_DecryptMessage(PCtxtHandle phContext, PSecBufferDesc pMessage, ULONG MessageSeqNo, PULONG pfQOP) { - TRACE("%p %p %ld %p stub\n", phContext, pMessage, MessageSeqNo, pfQOP); + PNegoHelper helper; + TRACE("(%p %p %ld %p)\n", phContext, pMessage, MessageSeqNo, pfQOP); if(!phContext) return SEC_E_INVALID_HANDLE; - return SEC_E_UNSUPPORTED_FUNCTION; + if(MessageSeqNo) + FIXME("Ignoring MessageSeqNo\n"); + + if(!pMessage || !pMessage->pBuffers || pMessage->cBuffers < 2 || + pMessage->pBuffers[0].BufferType != SECBUFFER_TOKEN || + !pMessage->pBuffers[0].pvBuffer) + return SEC_E_INVALID_TOKEN; + + if(pMessage->pBuffers[0].cbBuffer < 16) + return SEC_E_BUFFER_TOO_SMALL; + + helper = (PNegoHelper) phContext->dwLower; + + if(helper->neg_flags & NTLMSSP_NEGOTIATE_NTLM2) + { + FIXME("Can't handle NTLMv2 encryption yet, aborting\n"); + return SEC_E_UNSUPPORTED_FUNCTION; + } + else + { + SECUR32_arc4Process(helper->crypt.ntlm.a4i, + pMessage->pBuffers[1].pvBuffer, pMessage->pBuffers[1].cbBuffer); + } + + return ntlm_VerifySignature(phContext, pMessage, MessageSeqNo, pfQOP); } static SecurityFunctionTableA ntlmTableA = { diff --git a/dlls/secur32/tests/ntlm.c b/dlls/secur32/tests/ntlm.c index 240a01d..9128620 100644 --- a/dlls/secur32/tests/ntlm.c +++ b/dlls/secur32/tests/ntlm.c @@ -805,9 +805,9 @@ static void testSignSeal() getSecError(sec_status)); sec_status = pEncryptMessage(client.ctxt, 0, crypt, 0); - todo_wine{ ok(sec_status == SEC_E_OK, "EncryptMessage returned %s, not SEC_E_OK.\n", getSecError(sec_status)); + todo_wine{ ok(!memcmp(crypt->pBuffers[0].pvBuffer, crypt_trailer_client, crypt->pBuffers[0].cbBuffer), "Crypt trailer not as expected.\n"); ok(!memcmp(crypt->pBuffers[1].pvBuffer, crypt_message_client,
1
0
0
0
← Newer
1
...
20
21
22
23
24
25
26
...
75
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
Results per page:
10
25
50
100
200