winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2006
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
5 participants
746 discussions
Start a n
N
ew thread
Aric Stewart : user: Implement MNS_NOTIFYBYPOS.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 26985e6bec8016a44dcbf8dfb9ac621013edb602 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=26985e6bec8016a44dcbf8d…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Thu Aug 10 10:25:49 2006 -0500 user: Implement MNS_NOTIFYBYPOS. --- dlls/user/menu.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/user/menu.c b/dlls/user/menu.c index eb8632a..a28eff7 100644 --- a/dlls/user/menu.c +++ b/dlls/user/menu.c @@ -37,7 +37,6 @@ * - MNS_AUTODISMISS * - MNS_DRAGDROP * - MNS_MODELESS - * - MNS_NOTIFYBYPOS */ #include "config.h" @@ -2450,7 +2449,13 @@ static INT MENU_ExecFocusedItem( MTRACKE PostMessageW( pmt->hOwnerWnd, WM_SYSCOMMAND, item->wID, MAKELPARAM((INT16)pmt->pt.x, (INT16)pmt->pt.y) ); else - PostMessageW( pmt->hOwnerWnd, WM_COMMAND, item->wID, 0 ); + { + if (menu->dwStyle & MNS_NOTIFYBYPOS) + PostMessageW( pmt->hOwnerWnd, WM_MENUCOMMAND, menu->FocusedItem, + (LPARAM)hMenu); + else + PostMessageW( pmt->hOwnerWnd, WM_COMMAND, item->wID, 0 ); + } } return item->wID; } @@ -4901,7 +4906,7 @@ BOOL WINAPI SetMenuInfo (HMENU hMenu, LP if (menu->dwStyle & MNS_AUTODISMISS) FIXME("MNS_AUTODISMISS unimplemented\n"); if (menu->dwStyle & MNS_DRAGDROP) FIXME("MNS_DRAGDROP unimplemented\n"); if (menu->dwStyle & MNS_MODELESS) FIXME("MNS_MODELESS unimplemented\n"); - if (menu->dwStyle & MNS_NOTIFYBYPOS) FIXME("MNS_NOTIFYBYPOS unimplemented\n"); + if (menu->dwStyle & MNS_NOTIFYBYPOS) FIXME("MNS_NOTIFYBYPOS partially implemented\n"); } return TRUE;
1
0
0
0
Alexandre Julliard : ntdll: Remove some macros and clean up the code now that all platforms use siginfo .
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: c627cbd765512726f0e0700af14eb717a18c976e URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=c627cbd765512726f0e0700…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Aug 11 14:45:11 2006 +0200 ntdll: Remove some macros and clean up the code now that all platforms use siginfo. --- dlls/ntdll/signal_i386.c | 221 ++++++++++------------------------------------ 1 files changed, 47 insertions(+), 174 deletions(-) Diff:
http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=c627cbd765512726f0e…
1
0
0
0
Alexandre Julliard : ntdll: Switch linux to siginfo-style signal handling.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 38cf3a43058a6ba5a1f34fe5fd46efe3e270e536 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=38cf3a43058a6ba5a1f34fe…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Aug 11 14:14:38 2006 +0200 ntdll: Switch linux to siginfo-style signal handling. --- dlls/ntdll/signal_i386.c | 85 ++++++++++++++-------------------------------- 1 files changed, 26 insertions(+), 59 deletions(-) diff --git a/dlls/ntdll/signal_i386.c b/dlls/ntdll/signal_i386.c index 2055d93..b115ff6 100644 --- a/dlls/ntdll/signal_i386.c +++ b/dlls/ntdll/signal_i386.c @@ -65,60 +65,36 @@ #endif */ #ifdef linux -typedef struct -{ - unsigned short sc_gs, __gsh; - unsigned short sc_fs, __fsh; - unsigned short sc_es, __esh; - unsigned short sc_ds, __dsh; - unsigned long sc_edi; - unsigned long sc_esi; - unsigned long sc_ebp; - unsigned long sc_esp; - unsigned long sc_ebx; - unsigned long sc_edx; - unsigned long sc_ecx; - unsigned long sc_eax; - unsigned long sc_trapno; - unsigned long sc_err; - unsigned long sc_eip; - unsigned short sc_cs, __csh; - unsigned long sc_eflags; - unsigned long esp_at_signal; - unsigned short sc_ss, __ssh; - unsigned long i387; - unsigned long oldmask; - unsigned long cr2; -} volatile SIGCONTEXT; - -#define HANDLER_DEF(name) void name( int __signal, SIGCONTEXT __context ) -#define HANDLER_CONTEXT (&__context) -#define EAX_sig(context) ((context)->sc_eax) -#define EBX_sig(context) ((context)->sc_ebx) -#define ECX_sig(context) ((context)->sc_ecx) -#define EDX_sig(context) ((context)->sc_edx) -#define ESI_sig(context) ((context)->sc_esi) -#define EDI_sig(context) ((context)->sc_edi) -#define EBP_sig(context) ((context)->sc_ebp) - -#define CS_sig(context) ((context)->sc_cs) -#define DS_sig(context) ((context)->sc_ds) -#define ES_sig(context) ((context)->sc_es) -#define FS_sig(context) ((context)->sc_fs) -#define GS_sig(context) ((context)->sc_gs) -#define SS_sig(context) ((context)->sc_ss) - -#define TRAP_sig(context) ((context)->sc_trapno) -#define ERROR_sig(context) ((context)->sc_err) -#define EFL_sig(context) ((context)->sc_eflags) +typedef ucontext_t SIGCONTEXT; -#define EIP_sig(context) ((context)->sc_eip) -#define ESP_sig(context) ((context)->sc_esp) +#define HANDLER_DEF(name) void name( int __signal, siginfo_t *__siginfo, SIGCONTEXT *__context ) +#define HANDLER_CONTEXT __context -#define FPU_sig(context) ((FLOATING_SAVE_AREA*)((context)->i387)) +#define EAX_sig(context) ((context)->uc_mcontext.gregs[REG_EAX]) +#define EBX_sig(context) ((context)->uc_mcontext.gregs[REG_EBX]) +#define ECX_sig(context) ((context)->uc_mcontext.gregs[REG_ECX]) +#define EDX_sig(context) ((context)->uc_mcontext.gregs[REG_EDX]) +#define ESI_sig(context) ((context)->uc_mcontext.gregs[REG_ESI]) +#define EDI_sig(context) ((context)->uc_mcontext.gregs[REG_EDI]) +#define EBP_sig(context) ((context)->uc_mcontext.gregs[REG_EBP]) +#define ESP_sig(context) ((context)->uc_mcontext.gregs[REG_ESP]) + +#define CS_sig(context) ((context)->uc_mcontext.gregs[REG_CS]) +#define DS_sig(context) ((context)->uc_mcontext.gregs[REG_DS]) +#define ES_sig(context) ((context)->uc_mcontext.gregs[REG_ES]) +#define SS_sig(context) ((context)->uc_mcontext.gregs[REG_SS]) +#define FS_sig(context) ((context)->uc_mcontext.gregs[REG_FS]) +#define GS_sig(context) ((context)->uc_mcontext.gregs[REG_GS]) + +#define EFL_sig(context) ((context)->uc_mcontext.gregs[REG_EFL]) +#define EIP_sig(context) ((context)->uc_mcontext.gregs[REG_EIP]) +#define TRAP_sig(context) ((context)->uc_mcontext.gregs[REG_TRAPNO]) +#define ERROR_sig(context) ((context)->uc_mcontext.gregs[REG_ERR]) + +#define FPU_sig(context) ((FLOATING_SAVE_AREA*)((context)->uc_mcontext.fpregs)) -#define FAULT_ADDRESS ((void *)HANDLER_CONTEXT->cr2) +#define FAULT_ADDRESS (__siginfo->si_addr) #define VM86_EAX 0 /* the %eax value while vm86_enter is executing */ @@ -1466,16 +1442,7 @@ #endif /* HAVE_SIGALTSTACK */ sigaddset( &sig_act.sa_mask, SIGINT ); sigaddset( &sig_act.sa_mask, SIGUSR1 ); sigaddset( &sig_act.sa_mask, SIGUSR2 ); - -#if defined(linux) - sig_act.sa_flags = SA_RESTART; -#elif defined (__svr4__) || defined(_SCO_DS) || defined(__APPLE__) || \ - defined(__NetBSD__) || defined(__OpenBSD__) || \ - defined(__FreeBSD__) || defined(__FreeBSD_kernel__) sig_act.sa_flags = SA_SIGINFO | SA_RESTART; -#else - sig_act.sa_flags = 0; -#endif #ifdef SA_ONSTACK sig_act.sa_flags |= SA_ONSTACK;
1
0
0
0
Mike McCormack : pstorec: Add a stub implementation.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: acb7f8abe27c42191cb9774bf16505cb9b8a92ec URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=acb7f8abe27c42191cb9774…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Fri Aug 11 15:11:47 2006 +0900 pstorec: Add a stub implementation. --- configure | 3 configure.ac | 1 dlls/Makefile.in | 1 dlls/pstorec/Makefile.in | 14 ++ dlls/pstorec/pstorec.c | 392 +++++++++++++++++++++++++++++++++++++++++++++ dlls/pstorec/pstorec.spec | 7 + 6 files changed, 417 insertions(+), 1 deletions(-) create mode 100644 dlls/pstorec/Makefile.in create mode 100644 dlls/pstorec/pstorec.c create mode 100644 dlls/pstorec/pstorec.spec Diff:
http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=acb7f8abe27c42191cb…
1
0
0
0
Benjamin Arai : oleaut32: Removes stub message from olefont: OLEFontImpl_FindConnectionPoint.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 3dade1e7def970bffd0aeac5d34b831e1ea37ed1 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=3dade1e7def970bffd0aeac…
Author: Benjamin Arai <me(a)benjaminarai.com> Date: Thu Aug 10 18:48:37 2006 -0700 oleaut32: Removes stub message from olefont:OLEFontImpl_FindConnectionPoint. --- dlls/oleaut32/olefont.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/oleaut32/olefont.c b/dlls/oleaut32/olefont.c index ee52a05..ac0bc8f 100644 --- a/dlls/oleaut32/olefont.c +++ b/dlls/oleaut32/olefont.c @@ -2018,7 +2018,7 @@ static HRESULT WINAPI OLEFontImpl_FindCo IConnectionPoint **ppCp) { OLEFontImpl *this = impl_from_IConnectionPointContainer(iface); - TRACE("(%p)->(%s, %p): stub\n", this, debugstr_guid(riid), ppCp); + TRACE("(%p)->(%s, %p)\n", this, debugstr_guid(riid), ppCp); if(IsEqualIID(riid, &IID_IPropertyNotifySink)) { return IConnectionPoint_QueryInterface(this->pPropertyNotifyCP,
1
0
0
0
Molle Bestefich : bug_report.pl: Use correct 'wine --version' syntax.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 9503f6efefffa50d1d9239c7eee43aa8fb7937f0 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=9503f6efefffa50d1d9239c…
Author: Molle Bestefich <molle.bestefich(a)gmail.com> Date: Thu Aug 10 22:38:48 2006 +0200 bug_report.pl: Use correct 'wine --version' syntax. --- tools/bug_report.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/bug_report.pl b/tools/bug_report.pl index 18f180c..f445c57 100755 --- a/tools/bug_report.pl +++ b/tools/bug_report.pl @@ -425,11 +425,11 @@ if ($debuglevel > 1) { $winever .= " CVS"; } else { - $winever = `$wineloc -v 2>&1`; + $winever = `$wineloc --version 2>&1`; chomp $winever; } } elsif ($debuglevel =~ 1) { - $winever=`$wineloc -v 2>&1`; + $winever=`$wineloc --version 2>&1`; chomp $winever; } my $gccver=`gcc -v 2>&1`;
1
0
0
0
Dan Hipschman : widl: Fix incorrect version number in generated code.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: a20f7f46dcc032478e966c2301d05002440b8423 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=a20f7f46dcc032478e966c2…
Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Thu Aug 10 16:51:28 2006 -0700 widl: Fix incorrect version number in generated code. --- tools/widl/client.c | 2 +- tools/widl/proxy.c | 2 +- tools/widl/server.c | 2 +- tools/widl/widl.h | 2 -- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/widl/client.c b/tools/widl/client.c index 6f8773e..c52fe98 100644 --- a/tools/widl/client.c +++ b/tools/widl/client.c @@ -451,7 +451,7 @@ static void init_client(void) if (!(client = fopen(client_name, "w"))) error("Could not open %s for output\n", client_name); - print_client("/*** Autogenerated by WIDL %s from %s - Do not edit ***/\n", WIDL_FULLVERSION, input_name); + print_client("/*** Autogenerated by WIDL %s from %s - Do not edit ***/\n", PACKAGE_VERSION, input_name); print_client("#include <string.h>\n"); print_client("#ifdef _ALPHA_\n"); print_client("#include <stdarg.h>\n"); diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c index 1710cdc..c308ab8 100644 --- a/tools/widl/proxy.c +++ b/tools/widl/proxy.c @@ -147,7 +147,7 @@ static void init_proxy(void) if (proxy) return; if(!(proxy = fopen(proxy_name, "w"))) error("Could not open %s for output\n", proxy_name); - print_proxy( "/*** Autogenerated by WIDL %s - Do not edit ***/\n", WIDL_FULLVERSION); + print_proxy( "/*** Autogenerated by WIDL %s from %s - Do not edit ***/\n", PACKAGE_VERSION, input_name); print_proxy( "\n"); print_proxy( "#ifndef __REDQ_RPCPROXY_H_VERSION__\n"); print_proxy( "#define __REQUIRED_RPCPROXY_H_VERSION__ 440\n"); diff --git a/tools/widl/server.c b/tools/widl/server.c index 72d5ae7..19a4a2b 100644 --- a/tools/widl/server.c +++ b/tools/widl/server.c @@ -587,7 +587,7 @@ static void init_server(void) if (!(server = fopen(server_name, "w"))) error("Could not open %s for output\n", server_name); - print_server("/*** Autogenerated by WIDL %s from %s - Do not edit ***/\n", WIDL_FULLVERSION, input_name); + print_server("/*** Autogenerated by WIDL %s from %s - Do not edit ***/\n", PACKAGE_VERSION, input_name); print_server("#include <string.h>\n"); fprintf(server, "\n"); print_server("#include \"%s\"\n", header_name); diff --git a/tools/widl/widl.h b/tools/widl/widl.h index 9357450..e84a5ad 100644 --- a/tools/widl/widl.h +++ b/tools/widl/widl.h @@ -25,8 +25,6 @@ #include "widltypes.h" #include <time.h> -#define WIDL_FULLVERSION "0.1" - extern int debuglevel; #define DEBUGLEVEL_NONE 0x0000 #define DEBUGLEVEL_CHAT 0x0001
1
0
0
0
Hwang YunSong(=?UTF-8?Q?=ED=99=A9=EC=9C=A4=EC=84=B1?=) : shell32: Updated Korean resource.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: a17d253c5db45d7a791eb6d52b36f43998419691 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=a17d253c5db45d7a791eb6d…
Author: Hwang YunSong(황윤성) <hys545(a)dreamwiz.com> Date: Fri Aug 11 08:39:29 2006 +0900 shell32: Updated Korean resource. --- dlls/shell32/shell32_Ko.rc | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/shell32/shell32_Ko.rc b/dlls/shell32/shell32_Ko.rc index 9d69748..158cf56 100644 --- a/dlls/shell32/shell32_Ko.rc +++ b/dlls/shell32/shell32_Ko.rc @@ -146,10 +146,13 @@ IDS_SHV_COLUMN8 "�̸�" IDS_SHV_COLUMN9 "�ּ�" IDS_SHV_COLUMN10 "������" IDS_SHV_COLUMN11 "��" +IDS_SHV_COLUMN_DELFROM "���� ��ġ" +IDS_SHV_COLUMN_DELDATE "������ ��¥" /* special folders */ IDS_DESKTOP "����ũž" IDS_MYCOMPUTER "�� ��ǻ��" +IDS_RECYCLEBIN_FOLDER_NAME "������" /* context menus */ IDS_VIEW_LARGE "ū ������(&G)"
1
0
0
0
Roderick Colenbrander : wined3d: Fix opengl extension call.
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 1a3359884c73692b30ffa28f88361c27381a1c9f URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=1a3359884c73692b30ffa28…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Fri Aug 11 01:04:24 2006 +0200 wined3d: Fix opengl extension call. --- dlls/wined3d/drawprim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index 434fab9..360efdd 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -859,7 +859,7 @@ static void unloadVertexData(IWineD3DDev glDisableClientState(GL_SECONDARY_COLOR_ARRAY_EXT); } for (texture_idx = 0; texture_idx < GL_LIMITS(textures); ++texture_idx) { - glClientActiveTextureARB(GL_TEXTURE0_ARB + texture_idx); + GL_EXTCALL(glClientActiveTextureARB(GL_TEXTURE0_ARB + texture_idx)); glDisableClientState(GL_TEXTURE_COORD_ARRAY); } }
1
0
0
0
James Hawkins : msi: Only remove a file if the version to be installed is strictly newer than the old file .
by Alexandre Julliard
11 Aug '06
11 Aug '06
Module: wine Branch: master Commit: 5d37be9e56e9b875142a93a7af0671f2d9bc2947 URL:
http://source.winehq.org/git/?p=wine.git;a=commit;h=5d37be9e56e9b875142a93a…
Author: James Hawkins <truiken(a)gmail.com> Date: Thu Aug 10 13:53:08 2006 -0700 msi: Only remove a file if the version to be installed is strictly newer than the old file. --- dlls/msi/files.c | 24 ++++++++++++++++++++++++ dlls/msi/tests/package.c | 11 ++++------- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/dlls/msi/files.c b/dlls/msi/files.c index 443e6c3..7f1c4db 100644 --- a/dlls/msi/files.c +++ b/dlls/msi/files.c @@ -823,6 +823,24 @@ UINT ACTION_DuplicateFiles(MSIPACKAGE *p return rc; } +/* compares the version of a file read from the filesystem and + * the version specified in the File table + */ +static int msi_compare_file_version( MSIFILE *file ) +{ + WCHAR version[MAX_PATH]; + DWORD size; + UINT r; + + size = MAX_PATH; + version[0] = '\0'; + r = MsiGetFileVersionW( file->TargetPath, version, &size, NULL, NULL ); + if ( r != ERROR_SUCCESS ) + return 0; + + return lstrcmpW( version, file->Version ); +} + UINT ACTION_RemoveFiles( MSIPACKAGE *package ) { MSIFILE *file; @@ -843,6 +861,12 @@ UINT ACTION_RemoveFiles( MSIPACKAGE *pac if ( file->state != msifs_present ) continue; + /* only remove a file if the version to be installed + * is strictly newer than the old file + */ + if ( msi_compare_file_version( file ) >= 0 ) + continue; + TRACE("removing %s\n", debugstr_w(file->File) ); if ( !DeleteFileW( file->TargetPath ) ) ERR("failed to delete %s\n", debugstr_w(file->TargetPath) ); diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 3ff7b0f..55b2e1c 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -1938,13 +1938,10 @@ static void test_removefiles(void) r = MsiDoAction( hpkg, "RemoveFiles"); ok( r == ERROR_SUCCESS, "remove files failed\n"); - todo_wine - { - ok(DeleteFileA("hydrogen.txt"), "Expected hydrogen.txt to exist\n"); - ok(DeleteFileA("lithium.txt"), "Expected lithium.txt to exist\n"); - ok(DeleteFileA("beryllium.txt"), "Expected beryllium.txt to exist\n"); - ok(DeleteFileA("carbon.txt"), "Expected carbon.txt to exist\n"); - } + ok(DeleteFileA("hydrogen.txt"), "Expected hydrogen.txt to exist\n"); + ok(DeleteFileA("lithium.txt"), "Expected lithium.txt to exist\n"); + ok(DeleteFileA("beryllium.txt"), "Expected beryllium.txt to exist\n"); + ok(DeleteFileA("carbon.txt"), "Expected carbon.txt to exist\n"); ok(DeleteFileA("helium.txt"), "Expected helium.txt to exist\n"); ok(DeleteFileA("boron.txt"), "Expected boron.txt to exist\n");
1
0
0
0
← Newer
1
...
41
42
43
44
45
46
47
...
75
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
Results per page:
10
25
50
100
200