wine-commits October 2007

wine-commits@winehq.org

4 participants
996 discussions

Alexandre Julliard : Fix redundant uses of MAKEINTRESOURCE.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 41cf63148af21722e8b85c216b60ec4998cb2c1c URL: http://source.winehq.org/git/wine.git/?a=commit;h=41cf63148af21722e8b85c216… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 18 14:12:05 2007 +0200 Fix redundant uses of MAKEINTRESOURCE. --- dlls/ole32/tests/ole2.c | 2 +- dlls/shell32/tests/systray.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c index 6732c13..4eb6be6 100644 --- a/dlls/ole32/tests/ole2.c +++ b/dlls/ole32/tests/ole2.c @@ -1175,7 +1175,7 @@ static void test_data_cache(void) fmtetc.cfFormat = CF_METAFILEPICT; stgmedium.tymed = TYMED_MFPICT; U(stgmedium).hMetaFilePict = OleMetafilePictFromIconAndLabel( - LoadIcon(NULL, MAKEINTRESOURCE(IDI_APPLICATION)), wszPath, wszPath, 0); + LoadIcon(NULL, IDI_APPLICATION), wszPath, wszPath, 0); stgmedium.pUnkForRelease = NULL; fmtetc.dwAspect = DVASPECT_CONTENT; diff --git a/dlls/shell32/tests/systray.c b/dlls/shell32/tests/systray.c index b80b109..9c97a4e 100644 --- a/dlls/shell32/tests/systray.c +++ b/dlls/shell32/tests/systray.c @@ -83,7 +83,7 @@ START_TEST(systray) wc.cbWndExtra = 0; wc.hInstance = GetModuleHandleA(NULL); wc.hIcon = NULL; - wc.hCursor = LoadCursorA(NULL, MAKEINTRESOURCEA(IDC_IBEAM)); + wc.hCursor = LoadCursorA(NULL, IDC_IBEAM); wc.hbrBackground = GetSysColorBrush(COLOR_WINDOW); wc.lpszMenuName = NULL; wc.lpszClassName = "MyTestWnd";

1 0

Alexandre Julliard : shell32: Use wine_get_dos_file_name instead of duplicating knowledge about the drive symlinks .
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 7f092818f057ce02d0f8c4628cbf7e93c1d69040 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f092818f057ce02d0f8c4628… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 18 14:11:43 2007 +0200 shell32: Use wine_get_dos_file_name instead of duplicating knowledge about the drive symlinks. --- dlls/shell32/shfldr_unixfs.c | 59 ++++++++++-------------------------------- 1 files changed, 14 insertions(+), 45 deletions(-) diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c index a4f4ade..f780037 100644 --- a/dlls/shell32/shfldr_unixfs.c +++ b/dlls/shell32/shfldr_unixfs.c @@ -369,36 +369,6 @@ static inline BOOL UNIXFS_is_pidl_of_type(LPITEMIDLIST pIDL, SHCONTF fFilter) { } /****************************************************************************** - * UNIXFS_is_dos_device [Internal] - * - * Determines if a unix directory corresponds to any dos device. - * - * PARAMS - * statPath [I] The stat struct of the directory, as returned by stat(2). - * - * RETURNS - * TRUE, if statPath corresponds to any dos drive letter - * FALSE, otherwise - */ -static BOOL UNIXFS_is_dos_device(const struct stat *statPath) { - struct stat statDrive; - char *pszDrivePath; - DWORD dwDriveMap; - WCHAR wszDosDevice[4] = { 'A', ':', '\\', 0 }; - - for (dwDriveMap = GetLogicalDrives(); dwDriveMap; dwDriveMap >>= 1, wszDosDevice[0]++) { - if (!(dwDriveMap & 0x1)) continue; - pszDrivePath = wine_get_unix_file_name(wszDosDevice); - if (pszDrivePath && !stat(pszDrivePath, &statDrive)) { - HeapFree(GetProcessHeap(), 0, pszDrivePath); - if ((statPath->st_dev == statDrive.st_dev) && (statPath->st_ino == statDrive.st_ino)) - return TRUE; - } - } - return FALSE; -} - -/****************************************************************************** * UNIXFS_get_unix_path [Internal] * * Convert an absolute dos path to an absolute unix path. @@ -733,9 +703,9 @@ static HRESULT UNIXFS_initialize_target_folder(UnixFolder *This, const char *szB { LPCITEMIDLIST current = pidlSubFolder; DWORD dwPathLen = strlen(szBasePath)+1; - struct stat statPrefix; char *pNextDir; - + WCHAR *dos_name; + /* Determine the path's length bytes */ while (current && current->mkid.cb) { dwPathLen += UNIXFS_filename_from_shitemid(current, NULL) + 1; /* For the '/' */ @@ -755,23 +725,20 @@ static HRESULT UNIXFS_initialize_target_folder(UnixFolder *This, const char *szB pNextDir += strlen(szBasePath); if (This->m_dwPathMode == PATHMODE_UNIX || IsEqualCLSID(&CLSID_MyDocuments, This->m_pCLSID)) This->m_dwAttributes |= SFGAO_FILESYSTEM; - if (!(This->m_dwAttributes & SFGAO_FILESYSTEM)) { - *pNextDir = '\0'; - if (!stat(This->m_pszPath, &statPrefix) && UNIXFS_is_dos_device(&statPrefix)) - This->m_dwAttributes |= SFGAO_FILESYSTEM; - } while (current && current->mkid.cb) { pNextDir += UNIXFS_filename_from_shitemid(current, pNextDir); - if (!(This->m_dwAttributes & SFGAO_FILESYSTEM)) { - *pNextDir = '\0'; - if (!stat(This->m_pszPath, &statPrefix) && UNIXFS_is_dos_device(&statPrefix)) - This->m_dwAttributes |= SFGAO_FILESYSTEM; - } *pNextDir++ = '/'; current = ILGetNext(current); } *pNextDir='\0'; - + + if (!(This->m_dwAttributes & SFGAO_FILESYSTEM) && + ((dos_name = wine_get_dos_file_name(This->m_pszPath)))) + { + This->m_dwAttributes |= SFGAO_FILESYSTEM; + HeapFree( GetProcessHeap(), 0, dos_name ); + } + return S_OK; } @@ -1050,11 +1017,13 @@ static HRESULT WINAPI UnixFolder_IShellFolder2_GetAttributesOf(IShellFolder2* if pszRelativePath = szAbsolutePath + lstrlenA(szAbsolutePath); for (i=0; i<cidl; i++) { if (!(This->m_dwAttributes & SFGAO_FILESYSTEM)) { - struct stat fileStat; + WCHAR *dos_name; if (!UNIXFS_filename_from_shitemid(apidl[i], pszRelativePath)) return E_INVALIDARG; - if (stat(szAbsolutePath, &fileStat) || !UNIXFS_is_dos_device(&fileStat)) + if (!(dos_name = wine_get_dos_file_name( szAbsolutePath ))) *rgfInOut &= ~SFGAO_FILESYSTEM; + else + HeapFree( GetProcessHeap(), 0, dos_name ); } if (_ILIsFolder(apidl[i])) *rgfInOut |= SFGAO_FOLDER|SFGAO_HASSUBFOLDER|SFGAO_FILESYSANCESTOR;

1 0

Alex Villacís Lasso : user32: Tests for fix EM_SETLIMITTEXT with zeroed args.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: c67d0122db53999d4b58a33209ee1e43de6327a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c67d0122db53999d4b58a3320… Author: Alex Villacís Lasso <a_villacis(a)palosanto.com> Date: Sun Oct 14 20:25:54 2007 -0500 user32: Tests for fix EM_SETLIMITTEXT with zeroed args. --- dlls/user32/tests/edit.c | 33 ++++++++++++++++++++++++++++++++- 1 files changed, 32 insertions(+), 1 deletions(-) diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c index c74f6d7..cd498cc 100644 --- a/dlls/user32/tests/edit.c +++ b/dlls/user32/tests/edit.c @@ -706,6 +706,36 @@ static void test_edit_control_5(void) DestroyWindow(hWnd); } +static void test_edit_control_limittext(void) +{ + HWND hwEdit; + DWORD r; + + /* Test default limit for single-line control */ + trace("EDIT: buffer limit for single-line\n"); + hwEdit = create_editcontrol(ES_AUTOHSCROLL | ES_AUTOVSCROLL, 0); + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); + ok(r == 30000, "Incorrect default text limit, expected 30000 got %u\n", r); + SendMessage(hwEdit, EM_SETLIMITTEXT, 0, 0); + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); + /* Win9x+ME: 32766; WinNT: 2147483646UL */ + ok( (r == 32766) || (r == 2147483646UL), + "got limit %u (expected 32766 or 2147483646)\n", r); + DestroyWindow(hwEdit); + + /* Test default limit for multi-line control */ + trace("EDIT: buffer limit for multi-line\n"); + hwEdit = create_editcontrol(ES_MULTILINE | WS_VSCROLL | ES_AUTOHSCROLL | ES_AUTOVSCROLL, 0); + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); + ok(r == 30000, "Incorrect default text limit, expected 30000 got %u\n", r); + SendMessage(hwEdit, EM_SETLIMITTEXT, 0, 0); + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); + /* Win9x+ME: 65535; WinNT: 4294967295UL */ + ok( (r == 65535) || (r == 4294967295UL), + "got limit %u (expected 65535 or 4294967295)\n", r); + DestroyWindow(hwEdit); +} + static void test_margins(void) { HWND hwEdit; @@ -1139,7 +1169,7 @@ static BOOL RegisterWindowClasses (void) text_position.cbWndExtra = 0; text_position.hInstance = hinst; text_position.hIcon = NULL; - text_position.hCursor = LoadCursorA(NULL, MAKEINTRESOURCEA(IDC_ARROW)); + text_position.hCursor = LoadCursorA(NULL, IDC_ARROW); text_position.hbrBackground = (HBRUSH)(COLOR_BTNFACE + 1); text_position.lpszMenuName = NULL; text_position.lpszClassName = szEditTextPositionClass; @@ -1166,6 +1196,7 @@ START_TEST(edit) test_edit_control_3(); test_edit_control_4(); test_edit_control_5(); + test_edit_control_limittext(); test_margins(); test_margins_font_change(); test_text_position();

1 0

Alex Villacís Lasso : user32: Fix EM_SETLIMITTEXT with zeroed args.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 48fd106ea17bc37aed9f7d2166d329824ed2dfb3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=48fd106ea17bc37aed9f7d216… Author: Alex Villacís Lasso <a_villacis(a)palosanto.com> Date: Tue Oct 16 15:25:51 2007 -0500 user32: Fix EM_SETLIMITTEXT with zeroed args. --- dlls/user32/edit.c | 37 +++++++++++-------------------------- 1 files changed, 11 insertions(+), 26 deletions(-) diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c index b11bf10..6ea843e 100644 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -65,9 +65,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(edit); WINE_DECLARE_DEBUG_CHANNEL(combo); WINE_DECLARE_DEBUG_CHANNEL(relay); -#define BUFLIMIT_MULTI 65534 /* maximum buffer size (not including '\0') - FIXME: BTW, new specs say 65535 (do you dare ???) */ -#define BUFLIMIT_SINGLE 32766 /* maximum buffer size (not including '\0') */ +#define BUFLIMIT_INITIAL 30000 /* initial buffer size */ #define GROWLENGTH 32 /* buffers granularity in bytes: must be power of 2 */ #define ROUND_TO_GROW(size) (((size) + (GROWLENGTH - 1)) & ~(GROWLENGTH - 1)) #define HSCROLL_FRACTION 3 /* scroll window by 1/3 width */ @@ -247,7 +245,7 @@ static LRESULT EDIT_EM_Scroll(EDITSTATE *es, INT action); static void EDIT_EM_ScrollCaret(EDITSTATE *es); static void EDIT_EM_SetHandle(EDITSTATE *es, HLOCAL hloc); static void EDIT_EM_SetHandle16(EDITSTATE *es, HLOCAL16 hloc); -static void EDIT_EM_SetLimitText(EDITSTATE *es, INT limit); +static void EDIT_EM_SetLimitText(EDITSTATE *es, UINT limit); static void EDIT_EM_SetMargins(EDITSTATE *es, INT action, WORD left, WORD right, BOOL repaint); static void EDIT_EM_SetPasswordChar(EDITSTATE *es, WCHAR c); static void EDIT_EM_SetSel(EDITSTATE *es, UINT start, UINT end, BOOL after_wrap); @@ -650,7 +648,7 @@ static LRESULT WINAPI EditWndProc_common( HWND hwnd, UINT msg, case EM_LIMITTEXT16: case EM_SETLIMITTEXT: - EDIT_EM_SetLimitText(es, (INT)wParam); + EDIT_EM_SetLimitText(es, wParam); break; case EM_CANUNDO16: @@ -3203,7 +3201,7 @@ static void EDIT_EM_ReplaceSel(EDITSTATE *es, BOOL can_undo, LPCWSTR lpsz_replac /* Issue the EN_MAXTEXT notification and continue with replacing text * such that buffer limit is honored. */ - if ((honor_limit) && (es->buffer_limit > 0) && (size > es->buffer_limit)) { + if ((honor_limit) && (size > es->buffer_limit)) { EDIT_NOTIFY_PARENT(es, EN_MAXTEXT); strl = es->buffer_limit - (tl - (e-s)); } @@ -3649,27 +3647,14 @@ static void EDIT_EM_SetHandle16(EDITSTATE *es, HLOCAL16 hloc) * * EM_SETLIMITTEXT * - * FIXME: in WinNT maxsize is 0x7FFFFFFF / 0xFFFFFFFF - * However, the windows version is not complied to yet in all of edit.c + * NOTE: this version currently implements WinNT limits * - * Additionally as the wrapper for RichEdit controls we need larger buffers - * at present -1 will represent nolimit */ -static void EDIT_EM_SetLimitText(EDITSTATE *es, INT limit) +static void EDIT_EM_SetLimitText(EDITSTATE *es, UINT limit) { - if (limit == 0xFFFFFFFF) - es->buffer_limit = -1; - else if (es->style & ES_MULTILINE) { - if (limit) - es->buffer_limit = min(limit, BUFLIMIT_MULTI); - else - es->buffer_limit = BUFLIMIT_MULTI; - } else { - if (limit) - es->buffer_limit = min(limit, BUFLIMIT_SINGLE); - else - es->buffer_limit = BUFLIMIT_SINGLE; - } + if (!limit) limit = ~0u; + if (!(es->style & ES_MULTILINE)) limit = min(limit, 0x7ffffffe); + es->buffer_limit = limit; } @@ -4792,7 +4777,7 @@ static LRESULT EDIT_WM_NCCreate(HWND hwnd, LPCREATESTRUCTW lpcs, BOOL unicode) es->style &= ~ES_UPPERCASE; } if (es->style & ES_MULTILINE) { - es->buffer_limit = BUFLIMIT_MULTI; + es->buffer_limit = BUFLIMIT_INITIAL; if (es->style & WS_VSCROLL) es->style |= ES_AUTOVSCROLL; if (es->style & WS_HSCROLL) @@ -4806,7 +4791,7 @@ static LRESULT EDIT_WM_NCCreate(HWND hwnd, LPCREATESTRUCTW lpcs, BOOL unicode) es->style &= ~ES_AUTOHSCROLL; } } else { - es->buffer_limit = BUFLIMIT_SINGLE; + es->buffer_limit = BUFLIMIT_INITIAL; if ((es->style & ES_RIGHT) && (es->style & ES_CENTER)) es->style &= ~ES_CENTER; es->style &= ~WS_HSCROLL;

1 0

Dmitry Timoshkov : user32: Add more listbox message tests, make them pass under Wine.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 566ce8f5edd314d31a2f76f10da51d8674a66112 URL: http://source.winehq.org/git/wine.git/?a=commit;h=566ce8f5edd314d31a2f76f10… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Tue Oct 16 22:23:34 2007 +0900 user32: Add more listbox message tests, make them pass under Wine. --- dlls/user32/listbox.c | 81 +++++++++++++++++++++++++++++++----------- dlls/user32/tests/msg.c | 91 ++++++++++++++++++++++++++++++++++++++++------- 2 files changed, 138 insertions(+), 34 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=566ce8f5edd314d31a2f7…

1 0

Evan Teran : shell32: Fix typo in GlobalAlloc parameters.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 6b3c0ecf2e968621ff6b21b4fa8d11d55187cbb5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b3c0ecf2e968621ff6b21b4f… Author: Evan Teran <evan.teran(a)gmail.com> Date: Thu Oct 18 02:12:34 2007 -0400 shell32: Fix typo in GlobalAlloc parameters. --- dlls/shell32/shell32_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c index b974f8d..63f81f3 100644 --- a/dlls/shell32/shell32_main.c +++ b/dlls/shell32/shell32_main.c @@ -97,7 +97,7 @@ LPWSTR* WINAPI CommandLineToArgvW(LPCWSTR lpCmdline, int* numargs) /* Return the path to the executable */ DWORD len, size=16; - hargv=GlobalAlloc(size, 0); + hargv=GlobalAlloc(0, size); argv=GlobalLock(hargv); for (;;) {

1 0

Mikolaj Zalewski : msi: Make the WriteEnvironmentStrings handling of [~] a bit better.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: d5b620ea0bde2c60696c72e2d6d33a8b4aacd1f3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d5b620ea0bde2c60696c72e2d… Author: Mikolaj Zalewski <mikolajz(a)google.com> Date: Wed Oct 17 18:22:16 2007 -0700 msi: Make the WriteEnvironmentStrings handling of [~] a bit better. --- dlls/msi/action.c | 32 ++++++++++++++++++-------------- 1 files changed, 18 insertions(+), 14 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 0b3374d..80caaac 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -4757,12 +4757,13 @@ static UINT ACTION_InstallODBC( MSIPACKAGE *package ) #define check_flag_combo(x, y) ((x) & ~(y)) == (y) -static LONG env_set_flags( LPCWSTR *name, LPWSTR *value, DWORD *flags ) +static LONG env_set_flags( LPCWSTR *name, LPCWSTR *value, DWORD *flags ) { LPCWSTR cptr = *name; - LPWSTR ptr = *value; + LPCWSTR ptr = *value; static const WCHAR prefix[] = {'[','~',']',0}; + static const int prefix_len = 3; *flags = 0; while (*cptr) @@ -4790,18 +4791,18 @@ static LONG env_set_flags( LPCWSTR *name, LPWSTR *value, DWORD *flags ) return ERROR_FUNCTION_FAILED; } - if (!strncmpW(ptr, prefix, lstrlenW(prefix))) + if (!strncmpW(ptr, prefix, prefix_len)) { - *flags |= ENV_MOD_PREFIX; + *flags |= ENV_MOD_APPEND; *value += lstrlenW(prefix); } - else + else if (lstrlenW(*value) >= prefix_len) { - ptr += lstrlenW(ptr) - lstrlenW(prefix) - 1; + ptr += lstrlenW(ptr) - prefix_len; if (!lstrcmpW(ptr, prefix)) { - *flags |= ENV_MOD_APPEND; - *ptr = '\0'; + *flags |= ENV_MOD_PREFIX; + /* the "[~]" will be removed by deformat_string */; } } @@ -4823,7 +4824,7 @@ static UINT ITERATE_WriteEnvironmentString( MSIRECORD *rec, LPVOID param ) MSIPACKAGE *package = param; LPCWSTR name, value, comp; LPWSTR data = NULL, newval = NULL; - LPWSTR deformatted, ptr; + LPWSTR deformatted = NULL, ptr; DWORD flags, type, size; LONG res; HKEY env = NULL, root = HKEY_CURRENT_USER; @@ -4840,14 +4841,17 @@ static UINT ITERATE_WriteEnvironmentString( MSIRECORD *rec, LPVOID param ) value = MSI_RecordGetString(rec, 3); comp = MSI_RecordGetString(rec, 4); - deformat_string(package, value, &deformatted); - if (!deformatted) - return ERROR_OUTOFMEMORY; - - res = env_set_flags(&name, &deformatted, &flags); + res = env_set_flags(&name, &value, &flags); if (res != ERROR_SUCCESS) goto done; + deformat_string(package, value, &deformatted); + if (!deformatted) + { + res = ERROR_OUTOFMEMORY; + goto done; + } + value = deformatted; if (flags & ENV_MOD_MACHINE)

1 0

Nigel Liang : wininet: Release object in HttpEndRequestW after use.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: 7d2ac2039b3212b1a2b6dccdda3fc0640787a696 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d2ac2039b3212b1a2b6dccdd… Author: Nigel Liang <ncliang(a)gmail.com> Date: Wed Oct 17 17:07:41 2007 -0700 wininet: Release object in HttpEndRequestW after use. --- dlls/wininet/http.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 454d332..70239f7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -830,6 +830,8 @@ BOOL WINAPI HttpEndRequestW(HINTERNET hRequest, if (NULL == lpwhr || lpwhr->hdr.htype != WH_HHTTPREQ) { INTERNET_SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); + if (lpwhr) + WININET_Release( &lpwhr->hdr ); return FALSE; } @@ -881,6 +883,7 @@ BOOL WINAPI HttpEndRequestW(HINTERNET hRequest, } } + WININET_Release( &lpwhr->hdr ); TRACE("%i <--\n",rc); return rc; }

1 0

Detlef Riekenberg : spoolss: Return a magic number as HANDLE in RevertToPrinterSelf.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: c2b52a11f4cf2c38a68e7771a6b1f30fc4a27f92 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c2b52a11f4cf2c38a68e7771a… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Wed Oct 17 22:55:56 2007 +0200 spoolss: Return a magic number as HANDLE in RevertToPrinterSelf. --- dlls/spoolss/spoolss_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/spoolss/spoolss_main.c b/dlls/spoolss/spoolss_main.c index 15a86c8..2fee59e 100644 --- a/dlls/spoolss/spoolss_main.c +++ b/dlls/spoolss/spoolss_main.c @@ -175,7 +175,7 @@ BOOL WINAPI ImpersonatePrinterClient(HANDLE hToken) HANDLE WINAPI RevertToPrinterSelf(void) { FIXME("() stub\n"); - return NULL; + return (HANDLE) 0xdead0947; } /******************************************************************

1 0

Detlef Riekenberg : spoolss: Add a stub for BuildOtherNamesFromMachineName.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Module: wine Branch: master Commit: cdb5f358a153ec53fd8c94b00dee74bdfa348eed URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdb5f358a153ec53fd8c94b00… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Wed Oct 17 22:46:07 2007 +0200 spoolss: Add a stub for BuildOtherNamesFromMachineName. --- dlls/spoolss/spoolss.spec | 2 +- dlls/spoolss/spoolss_main.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dlls/spoolss/spoolss.spec b/dlls/spoolss/spoolss.spec index 2f893d5..d873d75 100644 --- a/dlls/spoolss/spoolss.spec +++ b/dlls/spoolss/spoolss.spec @@ -14,7 +14,7 @@ @ stub AddPrinterW @ stdcall AllocSplStr(wstr) @ stub AppendPrinterNotifyInfoData -@ stub BuildOtherNamesFromMachineName +@ stdcall BuildOtherNamesFromMachineName(ptr ptr) @ stub CallDrvDevModeConversion @ stub CallRouterFindFirstPrinterChangeNotification @ stub ClosePrinter diff --git a/dlls/spoolss/spoolss_main.c b/dlls/spoolss/spoolss_main.c index 9a9ec48..15a86c8 100644 --- a/dlls/spoolss/spoolss_main.c +++ b/dlls/spoolss/spoolss_main.c @@ -80,6 +80,18 @@ LPWSTR WINAPI AllocSplStr(LPCWSTR pwstr) } /****************************************************************** + * BuildOtherNamesFromMachineName [SPOOLSS.@] + */ +BOOL WINAPI BuildOtherNamesFromMachineName(LPVOID * ptr1, LPVOID * ptr2) +{ + FIXME("(%p, %p) stub\n", ptr1, ptr2); + + *ptr1 = NULL; + *ptr2 = NULL; + return FALSE; +} + +/****************************************************************** * DllAllocSplMem [SPOOLSS.@] * * Allocate cleared memory from the spooler heap

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2007