wine-commits October 2007

wine-commits@winehq.org

4 participants
996 discussions

Stefan Dösinger : wined3d: Take care against overwriting a source register in cmp.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 6dc11616d56323b7ea39fd85debeef589d52ac01 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6dc11616d56323b7ea39fd85d… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Sep 9 16:54:51 2007 +0200 wined3d: Take care against overwriting a source register in cmp. --- dlls/wined3d/glsl_shader.c | 41 +++++++++++++++++++++++++++++++++++++---- 1 files changed, 37 insertions(+), 4 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 47859fe..d82d24c 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1513,6 +1513,17 @@ void shader_glsl_cmp(SHADER_OPCODE_ARG* arg) { glsl_src_param_t src2_param; DWORD write_mask, cmp_channel = 0; unsigned int i, j; + char mask_char[6]; + BOOL temp_destination = FALSE; + + DWORD src0reg = arg->src[0] & WINED3DSP_REGNUM_MASK; + DWORD src1reg = arg->src[1] & WINED3DSP_REGNUM_MASK; + DWORD src2reg = arg->src[2] & WINED3DSP_REGNUM_MASK; + DWORD src0regtype = shader_get_regtype(arg->src[0]); + DWORD src1regtype = shader_get_regtype(arg->src[1]); + DWORD src2regtype = shader_get_regtype(arg->src[2]); + DWORD dstreg = arg->dst & WINED3DSP_REGNUM_MASK; + DWORD dstregtype = shader_get_regtype(arg->dst); /* Cycle through all source0 channels */ for (i=0; i<4; i++) { @@ -1524,16 +1535,38 @@ void shader_glsl_cmp(SHADER_OPCODE_ARG* arg) { cmp_channel = WINED3DSP_WRITEMASK_0 << j; } } - write_mask = shader_glsl_append_dst_ext(arg->buffer, arg, arg->dst & (~WINED3DSP_SWIZZLE_MASK | write_mask)); - if (!write_mask) continue; + + /* Splitting the cmp instruction up in multiple lines imposes a problem: + * The first lines may overwrite source parameters of the following lines. + * Deal with that by using a temporary destination register if needed + */ + if((src0reg == dstreg && src0regtype == dstregtype) || + (src1reg == dstreg && src1regtype == dstregtype) || + (src2reg == dstreg && src2regtype == dstregtype)) { + + write_mask = shader_glsl_get_write_mask(arg->dst & (~WINED3DSP_SWIZZLE_MASK | write_mask), mask_char); + if (!write_mask) continue; + shader_addline(arg->buffer, "tmp0%s = (", mask_char); + temp_destination = TRUE; + } else { + write_mask = shader_glsl_append_dst_ext(arg->buffer, arg, arg->dst & (~WINED3DSP_SWIZZLE_MASK | write_mask)); + if (!write_mask) continue; + } shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], cmp_channel, &src0_param); shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], write_mask, &src1_param); shader_glsl_add_src_param(arg, arg->src[2], arg->src_addr[2], write_mask, &src2_param); - shader_addline(arg->buffer, "%s >= 0.0 ? %s : %s);\n", - src0_param.param_str, src1_param.param_str, src2_param.param_str); + shader_addline(arg->buffer, "%s >= 0.0 ? %s : %s);\n", + src0_param.param_str, src1_param.param_str, src2_param.param_str); } + + if(temp_destination) { + shader_glsl_get_write_mask(arg->dst, mask_char); + shader_glsl_append_dst_ext(arg->buffer, arg, arg->dst); + shader_addline(arg->buffer, "tmp0%s);\n", mask_char); + } + } /** Process the CND opcode in GLSL (dst = (src0 > 0.5) ? src1 : src2) */

1 0

Stefan Dösinger : wined3d: Reverse the position fixup if the pshader is reading vpos.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 9c6cdda1472b45deb4ed1d90ddb802e4f56f6fc2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9c6cdda1472b45deb4ed1d90d… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Sep 14 13:11:00 2007 +0200 wined3d: Reverse the position fixup if the pshader is reading vpos. --- dlls/wined3d/baseshader.c | 3 +++ dlls/wined3d/glsl_shader.c | 36 +++++++++++++++++++++++++++++++++++- dlls/wined3d/pixelshader.c | 7 +++++++ dlls/wined3d/wined3d_private.h | 5 ++++- 4 files changed, 49 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/baseshader.c b/dlls/wined3d/baseshader.c index 6533810..67888b2 100644 --- a/dlls/wined3d/baseshader.c +++ b/dlls/wined3d/baseshader.c @@ -418,6 +418,9 @@ HRESULT shader_get_registers_used( else if (WINED3DSPR_RASTOUT == regtype && reg == 1) reg_maps->fog = 1; + + else if (WINED3DSPR_MISCTYPE == regtype && reg == 0 && pshader) + reg_maps->vpos = 1; } } } diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index b0ca134..47859fe 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -469,6 +469,20 @@ void shader_glsl_load_constants( checkGLcall("glGetUniformLocationARB"); GL_EXTCALL(glUniform4fvARB(pos, 1, mul_low)); } + if(((IWineD3DPixelShaderImpl *) pshader)->vpos_uniform) { + float correction_params[4]; + pos = GL_EXTCALL(glGetUniformLocationARB(programId, "ycorrection")); + checkGLcall("glGetUniformLocationARB"); + if(deviceImpl->render_offscreen) { + correction_params[0] = 0.0; + correction_params[1] = 1.0; + } else { + /* position is window relative, not viewport relative */ + correction_params[0] = ((IWineD3DSurfaceImpl *) deviceImpl->render_targets[0])->currentDesc.Height; + correction_params[1] = -1.0; + } + GL_EXTCALL(glUniform4fvARB(pos, 1, correction_params)); + } } } @@ -528,6 +542,7 @@ void shader_generate_glsl_declarations( shader_addline(buffer, "uniform vec4 srgb_mul_low;\n"); shader_addline(buffer, "uniform vec4 srgb_comparison;\n"); ps_impl->srgb_mode_hardcoded = 0; + extra_constants_needed++; } else { ps_impl->srgb_mode_hardcoded = 1; shader_addline(buffer, "const vec4 srgb_mul_low = {%f, %f, %f, %f};\n", @@ -544,6 +559,22 @@ void shader_generate_glsl_declarations( ps_impl->srgb_enabled = 0; ps_impl->srgb_mode_hardcoded = 1; } + if(reg_maps->vpos) { + if(This->baseShader.limits.constant_float + extra_constants_needed + 1 < GL_LIMITS(pshader_constantsF)) { + shader_addline(buffer, "uniform vec4 ycorrection;\n"); + ((IWineD3DPixelShaderImpl *) This)->vpos_uniform = 1; + extra_constants_needed++; + } else { + /* This happens because we do not have proper tracking of the constant registers that are + * actually used, only the max limit of the shader version + */ + FIXME("Cannot find a free uniform for vpos correction params\n"); + shader_addline(buffer, "const vec4 ycorrection = {%f, %f, 0.0, 0.0};\n", + device->render_offscreen ? 0.0 : ((IWineD3DSurfaceImpl *) device->render_targets[0])->currentDesc.Height, + device->render_offscreen ? 1.0 : -1.0); + } + shader_addline(buffer, "vec4 vpos;\n"); + } } /* Declare texture samplers */ @@ -621,6 +652,9 @@ void shader_generate_glsl_declarations( /* Start the main program */ shader_addline(buffer, "void main() {\n"); + if(pshader && reg_maps->vpos) { + shader_addline(buffer, "vpos = vec4(0, ycorrection[0], 0, 0) + gl_FragCoord * vec4(1, ycorrection[1], 1, 1) - 0.5;\n"); + } } /***************************************************************************** @@ -836,7 +870,7 @@ static void shader_glsl_get_register_name( case WINED3DSPR_MISCTYPE: if (reg == 0) { /* vPos */ - sprintf(tmpStr, "gl_FragCoord"); + sprintf(tmpStr, "vpos"); } else { /* gl_FrontFacing could be used for vFace, but note that * gl_FrontFacing is a bool, while vFace is a float for diff --git a/dlls/wined3d/pixelshader.c b/dlls/wined3d/pixelshader.c index 7b9a2c4..245c6b0 100644 --- a/dlls/wined3d/pixelshader.c +++ b/dlls/wined3d/pixelshader.c @@ -592,6 +592,13 @@ static HRESULT WINAPI IWineD3DPixelShaderImpl_CompileShader(IWineD3DPixelShader WARN("Recompiling shader because srgb correction is different and hardcoded\n"); goto recompile; } + if(This->baseShader.reg_maps.vpos && !This->vpos_uniform) { + if(This->render_offscreen != deviceImpl->render_offscreen || + This->height != ((IWineD3DSurfaceImpl *) deviceImpl->render_targets[0])->currentDesc.Height) { + WARN("Recompiling shader because vpos is used, hard compiled and changed\n"); + goto recompile; + } + } return WINED3D_OK; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 9457615..1cfd622 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1652,7 +1652,7 @@ typedef struct shader_reg_maps { * Use 0 as default (bit 31 is always 1 on a valid token) */ DWORD samplers[max(MAX_FRAGMENT_SAMPLERS, MAX_VERTEX_SAMPLERS)]; char bumpmat, luminanceparams; - char usesnrm; + char usesnrm, vpos; /* Whether or not a loop is used in this shader */ char loop; @@ -2083,6 +2083,9 @@ typedef struct IWineD3DPixelShaderImpl { char srgb_mode_hardcoded; UINT srgb_low_const; UINT srgb_cmp_const; + char vpos_uniform; + BOOL render_offscreen; + UINT height; #if 0 /* needs reworking */ PSHADERINPUTDATA input;

1 0

Rémi Assailly : user32: Renamed and moved SetDeskPattern.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 06b3967978b1ae703079498f6da622964fca3735 URL: http://source.winehq.org/git/wine.git/?a=commit;h=06b3967978b1ae703079498f6… Author: Rémi Assailly <remi.assailly(a)free.fr> Date: Tue Oct 2 20:19:29 2007 +0200 user32: Renamed and moved SetDeskPattern. --- dlls/user32/desktop.c | 9 --------- dlls/user32/user.exe.spec | 2 +- dlls/user32/user16.c | 9 +++++++++ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/user32/desktop.c b/dlls/user32/desktop.c index 40bf184..37774b8 100644 --- a/dlls/user32/desktop.c +++ b/dlls/user32/desktop.c @@ -179,15 +179,6 @@ BOOL WINAPI PaintDesktop(HDC hdc) } /*********************************************************************** - * OldSetDeskPattern (USER.279) - */ -BOOL16 WINAPI SetDeskPattern(void) -{ - return SystemParametersInfoA( SPI_SETDESKPATTERN, -1, NULL, FALSE ); -} - - -/*********************************************************************** * SetDeskWallPaper (USER32.@) * * FIXME: is there a unicode version? diff --git a/dlls/user32/user.exe.spec b/dlls/user32/user.exe.spec index b1dbe92..9a22d87 100644 --- a/dlls/user32/user.exe.spec +++ b/dlls/user32/user.exe.spec @@ -276,7 +276,7 @@ 276 stub LockMyTask 277 pascal -ret16 GetDlgCtrlID(word) GetDlgCtrlID16 278 pascal -ret16 GetDesktopHwnd() GetDesktopHwnd16 -279 pascal -ret16 OldSetDeskPattern() SetDeskPattern +279 pascal -ret16 OldSetDeskPattern() SetDeskPattern16 280 pascal -ret16 SetSystemMenu(word word) SetSystemMenu16 281 pascal -ret16 GetSysColorBrush(word) GetSysColorBrush16 282 pascal -ret16 SelectPalette(word word word) SelectPalette16 diff --git a/dlls/user32/user16.c b/dlls/user32/user16.c index f056fbb..b8951f2 100644 --- a/dlls/user32/user16.c +++ b/dlls/user32/user16.c @@ -927,6 +927,15 @@ void WINAPI ControlPanelInfo16( INT16 nInfoType, WORD wData, LPSTR lpBuffer ) /*********************************************************************** + * OldSetDeskPattern (USER.279) + */ +BOOL16 WINAPI SetDeskPattern16(void) +{ + return SystemParametersInfoA( SPI_SETDESKPATTERN, -1, NULL, FALSE ); +} + + +/*********************************************************************** * GetSysColorBrush (USER.281) */ HBRUSH16 WINAPI GetSysColorBrush16( INT16 index )

1 0

Rémi Assailly : user32: Moved some 16-bit functions.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 6e9fea22f82fe60624e1081d74ad990a5c428eed URL: http://source.winehq.org/git/wine.git/?a=commit;h=6e9fea22f82fe60624e1081d7… Author: Rémi Assailly <remi.assailly(a)free.fr> Date: Tue Oct 2 20:13:09 2007 +0200 user32: Moved some 16-bit functions. --- dlls/user32/clipboard.c | 51 ----------------------------------------------- dlls/user32/desktop.c | 9 -------- dlls/user32/user16.c | 27 ++++++++++++++++++++++++ 3 files changed, 27 insertions(+), 60 deletions(-) diff --git a/dlls/user32/clipboard.c b/dlls/user32/clipboard.c index 137ace9..59d93ab 100644 --- a/dlls/user32/clipboard.c +++ b/dlls/user32/clipboard.c @@ -486,35 +486,6 @@ BOOL WINAPI ChangeClipboardChain(HWND hWnd, HWND hWndNext) /************************************************************************** - * SetClipboardData (USER.141) - */ -HANDLE16 WINAPI SetClipboardData16(UINT16 wFormat, HANDLE16 hData) -{ - CLIPBOARDINFO cbinfo; - HANDLE16 hResult = 0; - - TRACE("(%04X, %04x) !\n", wFormat, hData); - - /* If it's not owned, data can only be set if the format doesn't exists - and its rendering is not delayed */ - if (!CLIPBOARD_GetClipboardInfo(&cbinfo) || - (!(cbinfo.flags & CB_OWNER) && !hData)) - { - WARN("Clipboard not owned by calling task. Operation failed.\n"); - return 0; - } - - if (USER_Driver->pSetClipboardData(wFormat, hData, 0, cbinfo.flags & CB_OWNER)) - { - hResult = hData; - bCBHasChanged = TRUE; - } - - return hResult; -} - - -/************************************************************************** * SetClipboardData (USER32.@) */ HANDLE WINAPI SetClipboardData(UINT wFormat, HANDLE hData) @@ -586,28 +557,6 @@ BOOL WINAPI IsClipboardFormatAvailable(UINT wFormat) /************************************************************************** - * GetClipboardData (USER.142) - */ -HANDLE16 WINAPI GetClipboardData16(UINT16 wFormat) -{ - HANDLE16 hData = 0; - CLIPBOARDINFO cbinfo; - - if (!CLIPBOARD_GetClipboardInfo(&cbinfo) || - (~cbinfo.flags & CB_OPEN)) - { - WARN("Clipboard not opened by calling task.\n"); - SetLastError(ERROR_CLIPBOARD_NOT_OPEN); - return 0; - } - - if (!USER_Driver->pGetClipboardData(wFormat, &hData, NULL)) hData = 0; - - return hData; -} - - -/************************************************************************** * GetClipboardData (USER32.@) */ HANDLE WINAPI GetClipboardData(UINT wFormat) diff --git a/dlls/user32/desktop.c b/dlls/user32/desktop.c index 4fbb2d9..40bf184 100644 --- a/dlls/user32/desktop.c +++ b/dlls/user32/desktop.c @@ -188,15 +188,6 @@ BOOL16 WINAPI SetDeskPattern(void) /*********************************************************************** - * SetDeskWallPaper (USER.285) - */ -BOOL16 WINAPI SetDeskWallPaper16( LPCSTR filename ) -{ - return SetDeskWallPaper( filename ); -} - - -/*********************************************************************** * SetDeskWallPaper (USER32.@) * * FIXME: is there a unicode version? diff --git a/dlls/user32/user16.c b/dlls/user32/user16.c index 1566f2c..f056fbb 100644 --- a/dlls/user32/user16.c +++ b/dlls/user32/user16.c @@ -447,6 +447,24 @@ BOOL16 WINAPI EmptyClipboard16(void) /************************************************************************** + * SetClipboardData (USER.141) + */ +HANDLE16 WINAPI SetClipboardData16(UINT16 wFormat, HANDLE16 hData) +{ + return HANDLE_16(SetClipboardData(wFormat, HANDLE_32(hData))); +} + + +/************************************************************************** + * GetClipboardData (USER.142) + */ +HANDLE16 WINAPI GetClipboardData16(UINT16 wFormat) +{ + return HANDLE_16(GetClipboardData(wFormat)); +} + + +/************************************************************************** * CountClipboardFormats (USER.143) */ INT16 WINAPI CountClipboardFormats16(void) @@ -983,6 +1001,15 @@ WORD WINAPI GetFreeSystemResources16( WORD resType ) /*********************************************************************** + * SetDeskWallPaper (USER.285) + */ +BOOL16 WINAPI SetDeskWallPaper16( LPCSTR filename ) +{ + return SetDeskWallPaper( filename ); +} + + +/*********************************************************************** * GetClipCursor (USER.309) */ void WINAPI GetClipCursor16( RECT16 *rect )

1 0

Marcus Meissner : setupapi: Use correct parameter in pointer init.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 263cb44d7640dead60b9c989cded7b134f2f38d5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=263cb44d7640dead60b9c989c… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Tue Oct 2 19:26:15 2007 +0200 setupapi: Use correct parameter in pointer init. --- dlls/setupapi/devinst.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c index 2459ccd..0ec77b9 100644 --- a/dlls/setupapi/devinst.c +++ b/dlls/setupapi/devinst.c @@ -1986,7 +1986,7 @@ static void SETUPDI_EnumerateInterfaces(HDEVINFO DeviceInfoSet, static void SETUPDI_EnumerateMatchingDevices(HDEVINFO DeviceInfoSet, LPCWSTR parent, HKEY key, const GUID *class, DWORD flags) { - struct DeviceInfoSet *set = (struct DeviceInfoSet *)set; + struct DeviceInfoSet *set = (struct DeviceInfoSet *)DeviceInfoSet; DWORD i, len; WCHAR subKeyName[MAX_PATH]; LONG l = ERROR_SUCCESS;

1 0

Marcus Meissner : d3d9/tests: Initialize shader to NULL.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 4a31362d537222109c672be3f18b7ed1732b4bf3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4a31362d537222109c672be3f… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Tue Oct 2 19:23:20 2007 +0200 d3d9/tests: Initialize shader to NULL. --- dlls/d3d9/tests/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 328813c..2402a97 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -1375,7 +1375,7 @@ static void test_null_stream(void) IDirect3D9 *d3d9; HWND hwnd; HRESULT hr; - IDirect3DVertexShader9 *shader; + IDirect3DVertexShader9 *shader = NULL; IDirect3DVertexDeclaration9 *decl; DWORD shader_code[] = { 0xfffe0101, /* vs_1_1 */

1 0

Roy Shea : net.exe: Added missing service name.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: c8c43acc2b5dba5cf1b30777daad522f34ffbf31 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c8c43acc2b5dba5cf1b30777d… Author: Roy Shea <roy(a)cs.hmc.edu> Date: Tue Oct 2 10:00:45 2007 -0700 net.exe: Added missing service name. --- programs/net/net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/net/net.c b/programs/net/net.c index 73e1763..4bc3652 100644 --- a/programs/net/net.c +++ b/programs/net/net.c @@ -99,8 +99,8 @@ static BOOL net_service(int operation, char *service_name) output_string(STRING_START_SVC, service_display_name); result = StartService(serviceHandle, 0, NULL); - if(result) output_string(STRING_START_SVC_SUCCESS); - else output_string(STRING_START_SVC_FAIL); + if(result) output_string(STRING_START_SVC_SUCCESS, service_display_name); + else output_string(STRING_START_SVC_FAIL, service_display_name); break; case NET_STOP: output_string(STRING_STOP_SVC, service_display_name);

1 0

Huw Davies : gdi32: Let the WINE_GGO_GRAY16_BITMAP case load a bitmap.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 05bb6f6ce4619921407e1f1e82a0e8d9cf9fb5c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=05bb6f6ce4619921407e1f1e8… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Oct 2 14:24:34 2007 +0100 gdi32: Let the WINE_GGO_GRAY16_BITMAP case load a bitmap. --- dlls/gdi32/freetype.c | 81 +++++++++++++++++++++++++++++++------------------ 1 files changed, 51 insertions(+), 30 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index b45c6c4..62563e8 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -3533,7 +3533,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, if (!font->gm[glyph_index / GM_BLOCK_SIZE]) font->gm[glyph_index / GM_BLOCK_SIZE] = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY, sizeof(GM) * GM_BLOCK_SIZE); - if(font->orientation || (format != GGO_METRICS && format != GGO_BITMAP) || font->aveWidth || lpmat) + if(font->orientation || (format != GGO_METRICS && format != GGO_BITMAP && format != WINE_GGO_GRAY16_BITMAP) || font->aveWidth || lpmat) load_flags |= FT_LOAD_NO_BITMAP; err = pFT_Load_Glyph(ft_face, glyph_index, load_flags); @@ -3650,7 +3650,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, lpgm->gmptGlyphOrigin.x = left >> 6; lpgm->gmptGlyphOrigin.y = top >> 6; - if(format == GGO_METRICS || format == GGO_BITMAP) + if(format == GGO_METRICS || format == GGO_BITMAP || format == WINE_GGO_GRAY16_BITMAP) { FONT_GM(font,glyph_index)->gm = *lpgm; FONT_GM(font,glyph_index)->adv = adv; @@ -3662,7 +3662,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, if(format == GGO_METRICS) return 1; /* FIXME */ - if(ft_face->glyph->format != ft_glyph_format_outline && format != GGO_BITMAP) { + if(ft_face->glyph->format != ft_glyph_format_outline && format != GGO_BITMAP && format != WINE_GGO_GRAY16_BITMAP) { TRACE("loaded a bitmap\n"); return GDI_ERROR; } @@ -3728,34 +3728,55 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, needed = pitch * height; if(!buf || !buflen) break; - ft_bitmap.width = width; - ft_bitmap.rows = height; - ft_bitmap.pitch = pitch; - ft_bitmap.pixel_mode = ft_pixel_mode_grays; - ft_bitmap.buffer = buf; - - if(needsTransform) { - pFT_Outline_Transform(&ft_face->glyph->outline, &transMat); - } - - pFT_Outline_Translate(&ft_face->glyph->outline, -left, -bottom ); - - memset(ft_bitmap.buffer, 0, buflen); - - pFT_Outline_Get_Bitmap(library, &ft_face->glyph->outline, &ft_bitmap); - if(format == GGO_GRAY2_BITMAP) - mult = 4; - else if(format == GGO_GRAY4_BITMAP) - mult = 16; - else if(format == GGO_GRAY8_BITMAP) - mult = 64; - else if(format == WINE_GGO_GRAY16_BITMAP) - break; - else { - assert(0); - break; - } + switch(ft_face->glyph->format) { + case ft_glyph_format_bitmap: + { + BYTE *src = ft_face->glyph->bitmap.buffer, *dst = buf; + INT h = ft_face->glyph->bitmap.rows; + INT x; + while(h--) { + for(x = 0; x < pitch; x++) + dst[x] = (src[x / 8] & (1 << ( (7 - (x % 8))))) ? 0xff : 0; + src += ft_face->glyph->bitmap.pitch; + dst += pitch; + } + return needed; + } + case ft_glyph_format_outline: + { + ft_bitmap.width = width; + ft_bitmap.rows = height; + ft_bitmap.pitch = pitch; + ft_bitmap.pixel_mode = ft_pixel_mode_grays; + ft_bitmap.buffer = buf; + + if(needsTransform) + pFT_Outline_Transform(&ft_face->glyph->outline, &transMat); + + pFT_Outline_Translate(&ft_face->glyph->outline, -left, -bottom ); + + memset(ft_bitmap.buffer, 0, buflen); + + pFT_Outline_Get_Bitmap(library, &ft_face->glyph->outline, &ft_bitmap); + + if(format == GGO_GRAY2_BITMAP) + mult = 4; + else if(format == GGO_GRAY4_BITMAP) + mult = 16; + else if(format == GGO_GRAY8_BITMAP) + mult = 64; + else if(format == WINE_GGO_GRAY16_BITMAP) + return needed; + else { + assert(0); + break; + } + } + default: + FIXME("loaded glyph format %x\n", ft_face->glyph->format); + return GDI_ERROR; + } start = buf; for(row = 0; row < height; row++) {

1 0

Huw Davies : gdi32: Only cache the glyph metrics when rendering to a monochrome bitmap or when just retrieving the metrics .
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 70c212937aa06815e72b6e232375dc0844914064 URL: http://source.winehq.org/git/wine.git/?a=commit;h=70c212937aa06815e72b6e232… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Oct 2 11:56:54 2007 +0100 gdi32: Only cache the glyph metrics when rendering to a monochrome bitmap or when just retrieving the metrics. --- dlls/gdi32/freetype.c | 20 +++++++++++++------- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 1db51ca..b45c6c4 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -3500,7 +3500,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, DWORD width, height, pitch, needed = 0; FT_Bitmap ft_bitmap; FT_Error err; - INT left, right, top = 0, bottom = 0; + INT left, right, top = 0, bottom = 0, adv, lsb, bbx; FT_Angle angle = 0; FT_Int load_flags = FT_LOAD_DEFAULT | FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH; float widthRatio = 1.0; @@ -3551,9 +3551,9 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, left = (INT)(ft_face->glyph->metrics.horiBearingX * widthRatio) & -64; right = (INT)((ft_face->glyph->metrics.horiBearingX + ft_face->glyph->metrics.width) * widthRatio + 63) & -64; - FONT_GM(font,glyph_index)->adv = (INT)((ft_face->glyph->metrics.horiAdvance * widthRatio) + 63) >> 6; - FONT_GM(font,glyph_index)->lsb = left >> 6; - FONT_GM(font,glyph_index)->bbx = (right - left) >> 6; + adv = (INT)((ft_face->glyph->metrics.horiAdvance * widthRatio) + 63) >> 6; + lsb = left >> 6; + bbx = (right - left) >> 6; /* Scaling transform */ if(font->aveWidth) { @@ -3609,7 +3609,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, top = (ft_face->glyph->metrics.horiBearingY + 63) & -64; bottom = (ft_face->glyph->metrics.horiBearingY - ft_face->glyph->metrics.height) & -64; - lpgm->gmCellIncX = FONT_GM(font,glyph_index)->adv; + lpgm->gmCellIncX = adv; lpgm->gmCellIncY = 0; } else { INT xc, yc; @@ -3650,8 +3650,14 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, lpgm->gmptGlyphOrigin.x = left >> 6; lpgm->gmptGlyphOrigin.y = top >> 6; - FONT_GM(font,glyph_index)->gm = *lpgm; - FONT_GM(font,glyph_index)->init = TRUE; + if(format == GGO_METRICS || format == GGO_BITMAP) + { + FONT_GM(font,glyph_index)->gm = *lpgm; + FONT_GM(font,glyph_index)->adv = adv; + FONT_GM(font,glyph_index)->lsb = lsb; + FONT_GM(font,glyph_index)->bbx = bbx; + FONT_GM(font,glyph_index)->init = TRUE; + } if(format == GGO_METRICS) return 1; /* FIXME */

1 0

Huw Davies : gdi32: TrueType fonts from the data directory should be added to the registry.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Module: wine Branch: master Commit: 5af70f49c6a673f7122d267db005824a460744ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=5af70f49c6a673f7122d267db… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Oct 2 14:30:04 2007 +0100 gdi32: TrueType fonts from the data directory should be added to the registry. --- dlls/gdi32/freetype.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index f3c76da..1db51ca 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2112,7 +2112,7 @@ BOOL WineEngInit(void) if (data_dir && (unixname = HeapAlloc(GetProcessHeap(), 0, strlen(data_dir) + sizeof("/fonts/")))) { strcpy(unixname, data_dir); strcat(unixname, "/fonts/"); - ReadFontDir(unixname, FALSE); + ReadFontDir(unixname, TRUE); HeapFree(GetProcessHeap(), 0, unixname); }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2007