winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
757 discussions
Start a n
N
ew thread
Hans Leidekker : wininet: Correct several ftp server response to error code mappings.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: 5270b429fae84afe45316df6d70c03ce07e2a7e2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5270b429fae84afe45316df6d…
Author: Hans Leidekker <hans(a)it.vu.nl> Date: Wed Oct 31 22:53:51 2007 +0100 wininet: Correct several ftp server response to error code mappings. --- dlls/wininet/ftp.c | 69 ++++++++++++++++++++-------------------------- dlls/wininet/tests/ftp.c | 16 ++-------- 2 files changed, 34 insertions(+), 51 deletions(-) diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c index d763043..c045217 100644 --- a/dlls/wininet/ftp.c +++ b/dlls/wininet/ftp.c @@ -3437,45 +3437,36 @@ static DWORD FTP_SetResponseError(DWORD dwResponse) switch(dwResponse) { - case 421: /* Service not available - Server may be shutting down. */ - dwCode = ERROR_INTERNET_EXTENDED_ERROR; - break; - - case 425: /* Cannot open data connection. */ - dwCode = ERROR_INTERNET_CANNOT_CONNECT; - break; - - case 426: /* Connection closed, transer aborted. */ - dwCode = ERROR_INTERNET_CONNECTION_ABORTED; - break; - - case 500: /* Syntax error. Command unrecognized. */ - case 501: /* Syntax error. Error in parameters or arguments. */ - dwCode = ERROR_INTERNET_INCORRECT_FORMAT; - break; - - case 530: /* Not logged in. Login incorrect. */ - dwCode = ERROR_INTERNET_LOGIN_FAILURE; - break; - - case 550: /* File action not taken. File not found or no access. */ - dwCode = ERROR_INTERNET_ITEM_NOT_FOUND; - break; - - case 450: /* File action not taken. File may be busy. */ - case 451: /* Action aborted. Server error. */ - case 452: /* Action not taken. Insufficient storage space on server. */ - case 502: /* Command not implemented. */ - case 503: /* Bad sequence of commands. */ - case 504: /* Command not implemented for that parameter. */ - case 532: /* Need account for storing files */ - case 551: /* Requested action aborted. Page type unknown */ - case 552: /* Action aborted. Exceeded storage allocation */ - case 553: /* Action not taken. File name not allowed. */ - - default: - dwCode = ERROR_INTERNET_EXTENDED_ERROR; - break; + case 425: /* Cannot open data connection. */ + dwCode = ERROR_INTERNET_CANNOT_CONNECT; + break; + + case 426: /* Connection closed, transer aborted. */ + dwCode = ERROR_INTERNET_CONNECTION_ABORTED; + break; + + case 530: /* Not logged in. Login incorrect. */ + dwCode = ERROR_INTERNET_LOGIN_FAILURE; + break; + + case 421: /* Service not available - Server may be shutting down. */ + case 450: /* File action not taken. File may be busy. */ + case 451: /* Action aborted. Server error. */ + case 452: /* Action not taken. Insufficient storage space on server. */ + case 500: /* Syntax error. Command unrecognized. */ + case 501: /* Syntax error. Error in parameters or arguments. */ + case 502: /* Command not implemented. */ + case 503: /* Bad sequence of commands. */ + case 504: /* Command not implemented for that parameter. */ + case 532: /* Need account for storing files */ + case 550: /* File action not taken. File not found or no access. */ + case 551: /* Requested action aborted. Page type unknown */ + case 552: /* Action aborted. Exceeded storage allocation */ + case 553: /* Action not taken. File name not allowed. */ + + default: + dwCode = ERROR_INTERNET_EXTENDED_ERROR; + break; } INTERNET_SetLastError(dwCode); diff --git a/dlls/wininet/tests/ftp.c b/dlls/wininet/tests/ftp.c index 7bbaf02..fa13fdc 100644 --- a/dlls/wininet/tests/ftp.c +++ b/dlls/wininet/tests/ftp.c @@ -125,7 +125,6 @@ static void test_createdir(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpCreateDirectoryA(hFtp, "new_directory_deadbeef"); ok ( bRet == FALSE, "Expected FtpCreateDirectoryA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); @@ -165,7 +164,6 @@ static void test_deletefile(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpDeleteFileA(hFtp, "non_existent_file_deadbeef"); ok ( bRet == FALSE, "Expected FtpDeleteFileA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); @@ -256,14 +254,13 @@ static void test_getfile(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpGetFileA(hFtp, "should_be_non_existing_deadbeef", "should_also_be_non_existing_deadbeef", FALSE, FILE_ATTRIBUTE_NORMAL, FTP_TRANSFER_TYPE_UNKNOWN, 0); ok ( bRet == FALSE, "Expected FtpGetFileA to fail\n"); - todo_wine - { ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); /* Currently Wine always creates the local file (even on failure) which is not correct, hence the test */ + todo_wine ok (GetFileAttributesA("should_also_be_non_existing_deadbeef") == INVALID_FILE_ATTRIBUTES, "Local file should not have been created\n"); - } + DeleteFileA("should_also_be_non_existing_deadbeef"); /* Same call as the previous but now the local file does exists. Windows just removes the file if the call fails @@ -278,14 +275,13 @@ static void test_getfile(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpGetFileA(hFtp, "should_be_non_existing_deadbeef", "should_also_be_non_existing_deadbeef", FALSE, FILE_ATTRIBUTE_NORMAL, FTP_TRANSFER_TYPE_UNKNOWN, 0); ok ( bRet == FALSE, "Expected FtpGetFileA to fail\n"); - todo_wine - { ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); /* Currently Wine always creates the local file (even on failure) which is not correct, hence the test */ + todo_wine ok (GetFileAttributesA("should_also_be_non_existing_deadbeef") == INVALID_FILE_ATTRIBUTES, "Local file should not have been created\n"); - } + DeleteFileA("should_also_be_non_existing_deadbeef"); /* This one should succeed */ @@ -537,7 +533,6 @@ static void test_putfile(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpPutFileA(hFtp, "now_existing_local", "non_existing_remote", FTP_TRANSFER_TYPE_UNKNOWN, 0); ok ( bRet == FALSE, "Expected FtpPutFileA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); @@ -587,7 +582,6 @@ static void test_removedir(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpRemoveDirectoryA(hFtp, "should_be_non_existing_deadbeef_dir"); ok ( bRet == FALSE, "Expected FtpRemoveDirectoryA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); @@ -595,7 +589,6 @@ static void test_removedir(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpRemoveDirectoryA(hFtp, "pub"); ok ( bRet == FALSE, "Expected FtpRemoveDirectoryA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError()); @@ -642,7 +635,6 @@ static void test_renamefile(HINTERNET hFtp, HINTERNET hConnect) SetLastError(0xdeadbeef); bRet = FtpRenameFileA(hFtp , "should_be_non_existing_deadbeef", "new"); ok ( bRet == FALSE, "Expected FtpRenameFileA to fail\n"); - todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR, "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError());
1
0
0
0
Alexandre Julliard : winex11.drv: Set the WM_STATE_ABOVE hint on topmost windows.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: 83fd17f2163071415471bb1433b004dce1ddba00 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83fd17f2163071415471bb143…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 18:13:20 2007 +0100 winex11.drv: Set the WM_STATE_ABOVE hint on topmost windows. --- dlls/winex11.drv/winpos.c | 3 +++ dlls/winex11.drv/x11drv.h | 2 ++ dlls/winex11.drv/x11drv_main.c | 1 + 3 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/winex11.drv/winpos.c b/dlls/winex11.drv/winpos.c index 9de341b..e4ce6f5 100644 --- a/dlls/winex11.drv/winpos.c +++ b/dlls/winex11.drv/winpos.c @@ -181,6 +181,7 @@ static void update_wm_states( Display *display, struct x11drv_win_data *data, BO static const unsigned int state_atoms[NB_WM_STATES] = { XATOM__NET_WM_STATE_FULLSCREEN, + XATOM__NET_WM_STATE_ABOVE, XATOM__NET_WM_STATE_SKIP_PAGER, XATOM__NET_WM_STATE_SKIP_TASKBAR }; @@ -195,6 +196,8 @@ static void update_wm_states( Display *display, struct x11drv_win_data *data, BO new_state |= (1 << WM_STATE_FULLSCREEN); ex_style = GetWindowLongW( data->hwnd, GWL_EXSTYLE ); + if (ex_style & WS_EX_TOPMOST) + new_state |= (1 << WM_STATE_ABOVE); if (ex_style & WS_EX_TOOLWINDOW) new_state |= (1 << WM_STATE_SKIP_TASKBAR) | (1 << WM_STATE_SKIP_PAGER); diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h index 49d6e8b..445badc 100644 --- a/dlls/winex11.drv/x11drv.h +++ b/dlls/winex11.drv/x11drv.h @@ -578,6 +578,7 @@ enum x11drv_atoms XATOM__NET_WM_PID, XATOM__NET_WM_PING, XATOM__NET_WM_STATE, + XATOM__NET_WM_STATE_ABOVE, XATOM__NET_WM_STATE_FULLSCREEN, XATOM__NET_WM_STATE_SKIP_PAGER, XATOM__NET_WM_STATE_SKIP_TASKBAR, @@ -649,6 +650,7 @@ enum x11drv_window_messages enum x11drv_wm_state { WM_STATE_FULLSCREEN, + WM_STATE_ABOVE, WM_STATE_SKIP_PAGER, WM_STATE_SKIP_TASKBAR, NB_WM_STATES diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c index 1cfc0b0..d26fa8b 100644 --- a/dlls/winex11.drv/x11drv_main.c +++ b/dlls/winex11.drv/x11drv_main.c @@ -135,6 +135,7 @@ static const char * const atom_names[NB_XATOMS - FIRST_XATOM] = "_NET_WM_PID", "_NET_WM_PING", "_NET_WM_STATE", + "_NET_WM_STATE_ABOVE", "_NET_WM_STATE_FULLSCREEN", "_NET_WM_STATE_SKIP_PAGER", "_NET_WM_STATE_SKIP_TASKBAR",
1
0
0
0
Alexandre Julliard : server: Added support for HWND_TOPMOST and HWND_NOTOPMOST.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: c183a9e6e7809ef39874d1c01778af31173d0e82 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c183a9e6e7809ef39874d1c01…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 18:12:56 2007 +0100 server: Added support for HWND_TOPMOST and HWND_NOTOPMOST. --- dlls/user32/winpos.c | 22 +++++-- server/window.c | 162 ++++++++++++++++++++++++++++++++++---------------- 2 files changed, 126 insertions(+), 58 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=c183a9e6e7809ef39874d…
1
0
0
0
Alexandre Julliard : server: Fix get_next/ prev_window behavior for unlinked windows.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: b8435343579bcb414cbe9edfd0fb774a889b4157 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b8435343579bcb414cbe9edfd…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 18:08:19 2007 +0100 server: Fix get_next/prev_window behavior for unlinked windows. --- server/window.c | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/server/window.c b/server/window.c index 1e81cbf..75f01a7 100644 --- a/server/window.c +++ b/server/window.c @@ -77,7 +77,8 @@ struct window unsigned int ex_style; /* window extended style */ unsigned int id; /* window id */ void* instance; /* creator instance */ - int is_unicode; /* ANSI or unicode */ + unsigned int is_unicode : 1; /* ANSI or unicode */ + unsigned int is_linked : 1; /* is it linked into the parent z-order list? */ unsigned long user_data; /* user-specific data */ WCHAR *text; /* window caption text */ unsigned int paint_flags; /* various painting flags */ @@ -142,6 +143,7 @@ static int set_parent_window( struct window *win, struct window *parent ) { win->parent = parent; list_add_head( &parent->children, &win->entry ); + win->is_linked = 1; /* if parent belongs to a different thread and the window isn't */ /* top-level, attach the two threads */ @@ -151,6 +153,7 @@ static int set_parent_window( struct window *win, struct window *parent ) else /* move it to parent unlinked list */ { list_add_head( &win->parent->unlinked, &win->entry ); + win->is_linked = 0; } return 1; } @@ -159,7 +162,6 @@ static int set_parent_window( struct window *win, struct window *parent ) static inline struct window *get_next_window( struct window *win ) { struct list *ptr = list_next( &win->parent->children, &win->entry ); - if (ptr == &win->parent->unlinked) ptr = NULL; return ptr ? LIST_ENTRY( ptr, struct window, entry ) : NULL; } @@ -167,7 +169,6 @@ static inline struct window *get_next_window( struct window *win ) static inline struct window *get_prev_window( struct window *win ) { struct list *ptr = list_prev( &win->parent->children, &win->entry ); - if (ptr == &win->parent->unlinked) ptr = NULL; return ptr ? LIST_ENTRY( ptr, struct window, entry ) : NULL; } @@ -402,6 +403,7 @@ static struct window *create_window( struct window *parent, struct window *owner win->id = 0; win->instance = NULL; win->is_unicode = 1; + win->is_linked = 0; win->user_data = 0; win->text = NULL; win->paint_flags = 0; @@ -1378,6 +1380,7 @@ static void set_window_pos( struct window *win, struct window *previous, list_remove( &win->entry ); /* unlink it from the previous location */ if (previous) list_add_after( &previous->entry, &win->entry ); else list_add_head( &win->parent->children, &win->entry ); + win->is_linked = 1; } if (swp_flags & SWP_SHOWWINDOW) win->style |= WS_VISIBLE; else if (swp_flags & SWP_HIDEWINDOW) win->style &= ~WS_VISIBLE; @@ -1765,8 +1768,11 @@ DECL_HANDLER(get_window_tree) struct window *parent = win->parent; reply->parent = parent->handle; reply->owner = win->owner; - if ((ptr = get_next_window( win ))) reply->next_sibling = ptr->handle; - if ((ptr = get_prev_window( win ))) reply->prev_sibling = ptr->handle; + if (win->is_linked) + { + if ((ptr = get_next_window( win ))) reply->next_sibling = ptr->handle; + if ((ptr = get_prev_window( win ))) reply->prev_sibling = ptr->handle; + } if ((ptr = get_first_child( parent ))) reply->first_sibling = ptr->handle; if ((ptr = get_last_child( parent ))) reply->last_sibling = ptr->handle; }
1
0
0
0
Alexandre Julliard : user32: SetParent should not make the window topmost.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: 86c8860d62ee7731526d1d488b0228c3f0193074 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=86c8860d62ee7731526d1d488…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 18:00:53 2007 +0100 user32: SetParent should not make the window topmost. --- dlls/user32/win.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/user32/win.c b/dlls/user32/win.c index c70b0ca..f6f0512 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -2599,7 +2599,7 @@ HWND WINAPI SetParent( HWND hwnd, HWND parent ) in the x-order and send the expected WM_WINDOWPOSCHANGING and WM_WINDOWPOSCHANGED notification messages. */ - SetWindowPos( hwnd, HWND_TOPMOST, 0, 0, 0, 0, + SetWindowPos( hwnd, HWND_TOP, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOSIZE | (was_visible ? SWP_SHOWWINDOW : 0) ); /* FIXME: a WM_MOVE is also generated (in the DefWindowProc handler * for WM_WINDOWPOSCHANGED) in Windows, should probably remove SWP_NOMOVE */
1
0
0
0
Alexandre Julliard : user32: Don' t allow changing the WS_EX_TOPMOST style with SetWindowLong.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: ebc686495362525784ab26be67ae412379556439 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ebc686495362525784ab26be6…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 17:53:58 2007 +0100 user32: Don't allow changing the WS_EX_TOPMOST style with SetWindowLong. --- dlls/user32/tests/win.c | 9 +++------ dlls/user32/win.c | 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 548f13c..49fe766 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -993,12 +993,9 @@ static void test_shell_window(void) /* passes on Win XP, but not on Win98 ok(!ret, "third call to SetShellWindow(hwnd1)\n"); */ - todo_wine - { - SetWindowLong(hwnd1, GWL_EXSTYLE, GetWindowLong(hwnd1,GWL_EXSTYLE)|WS_EX_TOPMOST); - ret = GetWindowLong(hwnd1,GWL_EXSTYLE)&WS_EX_TOPMOST? TRUE: FALSE; - ok(!ret, "SetWindowExStyle(hwnd1, WS_EX_TOPMOST)\n"); - } + SetWindowLong(hwnd1, GWL_EXSTYLE, GetWindowLong(hwnd1,GWL_EXSTYLE)|WS_EX_TOPMOST); + ret = GetWindowLong(hwnd1,GWL_EXSTYLE)&WS_EX_TOPMOST? TRUE: FALSE; + ok(!ret, "SetWindowExStyle(hwnd1, WS_EX_TOPMOST)\n"); ret = DestroyWindow(hwnd1); ok(ret, "DestroyWindow(hwnd1)\n"); diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 3c077c9..c70b0ca 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -1945,6 +1945,8 @@ LONG_PTR WIN_SetWindowLong( HWND hwnd, INT offset, UINT size, LONG_PTR newval, B break; case GWL_EXSTYLE: req->flags = SET_WIN_EXSTYLE; + /* WS_EX_TOPMOST can only be changed through SetWindowPos */ + newval = (newval & ~WS_EX_TOPMOST) | (wndPtr->dwExStyle & WS_EX_TOPMOST); req->ex_style = newval; break; case GWLP_ID:
1
0
0
0
Alexandre Julliard : server: Also return the new extended style in the set_window_pos request.
by Alexandre Julliard
01 Nov '07
01 Nov '07
Module: wine Branch: master Commit: 917f288f1bb8b51f5a0f2722494fb8f2f2e75983 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=917f288f1bb8b51f5a0f27224…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 31 17:51:05 2007 +0100 server: Also return the new extended style in the set_window_pos request. --- dlls/winex11.drv/winpos.c | 5 ++++- include/wine/server_protocol.h | 3 ++- server/protocol.def | 1 + server/trace.c | 3 ++- server/window.c | 1 + 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/winpos.c b/dlls/winex11.drv/winpos.c index da08bd4..9de341b 100644 --- a/dlls/winex11.drv/winpos.c +++ b/dlls/winex11.drv/winpos.c @@ -240,7 +240,7 @@ BOOL X11DRV_SetWindowPos( HWND hwnd, HWND insert_after, const RECT *rectWindow, struct x11drv_win_data *data; RECT new_whole_rect, old_client_rect; WND *win; - DWORD old_style, new_style; + DWORD old_style, new_style, new_ex_style; BOOL ret, make_managed = FALSE; if (!(data = X11DRV_get_win_data( hwnd ))) return FALSE; @@ -293,6 +293,7 @@ BOOL X11DRV_SetWindowPos( HWND hwnd, HWND insert_after, const RECT *rectWindow, } ret = !wine_server_call( req ); new_style = reply->new_style; + new_ex_style = reply->new_ex_style; } SERVER_END_REQ; @@ -304,6 +305,7 @@ BOOL X11DRV_SetWindowPos( HWND hwnd, HWND insert_after, const RECT *rectWindow, win->rectWindow = *rectWindow; win->rectClient = *rectClient; win->dwStyle = new_style; + win->dwExStyle = new_ex_style; WIN_ReleasePtr( win ); } return ret; @@ -325,6 +327,7 @@ BOOL X11DRV_SetWindowPos( HWND hwnd, HWND insert_after, const RECT *rectWindow, win->rectClient = *rectClient; old_style = win->dwStyle; win->dwStyle = new_style; + win->dwExStyle = new_ex_style; data->window_rect = *rectWindow; TRACE( "win %p window %s client %s style %08x\n", diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index e669953..606e814 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -2946,6 +2946,7 @@ struct set_window_pos_reply { struct reply_header __header; unsigned int new_style; + unsigned int new_ex_style; }; @@ -4879,6 +4880,6 @@ union generic_reply struct set_completion_info_reply set_completion_info_reply; }; -#define SERVER_PROTOCOL_VERSION 323 +#define SERVER_PROTOCOL_VERSION 324 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/server/protocol.def b/server/protocol.def index 5d8acde..c91e8db 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2171,6 +2171,7 @@ enum message_type VARARG(valid,rectangles); /* valid rectangles from WM_NCCALCSIZE */ @REPLY unsigned int new_style; /* new window style */ + unsigned int new_ex_style; /* new window extended style */ @END diff --git a/server/trace.c b/server/trace.c index 72f9ddb..e63cad9 100644 --- a/server/trace.c +++ b/server/trace.c @@ -2691,7 +2691,8 @@ static void dump_set_window_pos_request( const struct set_window_pos_request *re static void dump_set_window_pos_reply( const struct set_window_pos_reply *req ) { - fprintf( stderr, " new_style=%08x", req->new_style ); + fprintf( stderr, " new_style=%08x,", req->new_style ); + fprintf( stderr, " new_ex_style=%08x", req->new_ex_style ); } static void dump_get_window_rectangles_request( const struct get_window_rectangles_request *req ) diff --git a/server/window.c b/server/window.c index ce5297c..1e81cbf 100644 --- a/server/window.c +++ b/server/window.c @@ -1822,6 +1822,7 @@ DECL_HANDLER(set_window_pos) if (!visible_rect) visible_rect = &req->window; set_window_pos( win, previous, flags, &req->window, &req->client, visible_rect, valid_rects ); reply->new_style = win->style; + reply->new_ex_style = win->ex_style; }
1
0
0
0
← Newer
1
...
73
74
75
76
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
Results per page:
10
25
50
100
200