winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
February 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
839 discussions
Start a n
N
ew thread
Francois Gouget : Add missing '\n's in traces.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 0271a09d4c6ff4896eed65ab0b74d06752eac43f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0271a09d4c6ff4896eed65ab0…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Feb 6 10:16:53 2007 +0100 Add missing '\n's in traces. --- dlls/kernel32/tests/sync.c | 2 +- dlls/winealsa.drv/dsoutput.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/sync.c b/dlls/kernel32/tests/sync.c index 19c9067..6031fc5 100644 --- a/dlls/kernel32/tests/sync.c +++ b/dlls/kernel32/tests/sync.c @@ -191,7 +191,7 @@ static void test_slist(void) memset(&slist_header, 0xFF, sizeof(slist_header)); pInitializeSListHead(&slist_header); ok(memcmp(&test_header, &slist_header, sizeof(SLIST_HEADER)) == 0, - "InitializeSListHead didn't zero-fill list header"); + "InitializeSListHead didn't zero-fill list header\n"); size = pQueryDepthSList(&slist_header); ok(size == 0, "initially created slist has size %d, expected 0\n", size); diff --git a/dlls/winealsa.drv/dsoutput.c b/dlls/winealsa.drv/dsoutput.c index f104ff9..1b7e9b1 100644 --- a/dlls/winealsa.drv/dsoutput.c +++ b/dlls/winealsa.drv/dsoutput.c @@ -231,7 +231,7 @@ static DWORD CALLBACK DBSB_MMAPLoop(LPVO SetEvent(hEvent); goto out; default: - ERR("Unhandled event %s", ALSA_getCmdString(msg)); + ERR("Unhandled event %s\n", ALSA_getCmdString(msg)); break; } if (hEvent != INVALID_HANDLE_VALUE)
1
0
0
0
Mike McCormack : widl: Implement dispinterfaces derived from an interface.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 609cd3027749067a70bcdfa5054be71669f19fcc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=609cd3027749067a70bcdfa50…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:09:17 2007 +0900 widl: Implement dispinterfaces derived from an interface. --- tools/widl/parser.y | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 1741b83..9cd1b12 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -726,13 +726,13 @@ dispinterfacedef: dispinterfacehdr '{' if (!parse_only && do_header) write_dispinterface($$); if (!parse_only && do_idfile) write_diid($$); } -/* FIXME: not sure how to handle this yet - | dispinterfacehdr '{' interface '}' { $$ = $1; - compute_method_indexes($$); - if (!parse_only && do_header) write_interface($$); - if (!parse_only && do_idfile) write_iid($$); + | dispinterfacehdr + '{' interface ';' '}' { $$ = $1; + $$->fields = $3->fields; + $$->funcs = $3->funcs; + if (!parse_only && do_header) write_dispinterface($$); + if (!parse_only && do_idfile) write_diid($$); } -*/ ; inherit: { $$ = NULL; }
1
0
0
0
Mike McCormack : ole32: Add a few more tests for transacted storage.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 4c46194cf5daf75a7a8d80c81d32e42fa3868358 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4c46194cf5daf75a7a8d80c81…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:39:58 2007 +0900 ole32: Add a few more tests for transacted storage. --- dlls/ole32/tests/storage32.c | 33 ++++++++++++++++++++++++++++++++- 1 files changed, 32 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/tests/storage32.c b/dlls/ole32/tests/storage32.c index 663bc30..9a90ad3 100644 --- a/dlls/ole32/tests/storage32.c +++ b/dlls/ole32/tests/storage32.c @@ -862,10 +862,11 @@ static void test_transact(void) static const WCHAR szPrefix[] = { 's','t','g',0 }; static const WCHAR szDot[] = { '.',0 }; WCHAR filename[MAX_PATH]; - IStorage *stg = NULL; + IStorage *stg = NULL, *stg2 = NULL; HRESULT r; IStream *stm = NULL; static const WCHAR stmname[] = { 'C','O','N','T','E','N','T','S',0 }; + static const WCHAR stmname2[] = { 'F','O','O',0 }; if(!GetTempFileNameW(szDot, szPrefix, 0, filename)) return; @@ -878,9 +879,28 @@ static void test_transact(void) ok(r==S_OK, "StgCreateDocfile failed\n"); /* now create a stream, but don't commit it */ + r = IStorage_CreateStream(stg, stmname2, STGM_SHARE_EXCLUSIVE | STGM_READWRITE, 0, 0, &stm ); + ok(r==S_OK, "IStorage->CreateStream failed\n"); + + r = IStream_Write(stm, "this is stream 1\n", 16, NULL); + ok(r==S_OK, "IStream->Write failed\n"); + + r = IStream_Release(stm); + + r = IStorage_Commit(stg, 0); + ok(r==S_OK, "IStorage->Commit failed\n"); + + /* now create a stream, but don't commit it */ + stm = NULL; r = IStorage_CreateStream(stg, stmname, STGM_SHARE_EXCLUSIVE | STGM_READWRITE, 0, 0, &stm ); ok(r==S_OK, "IStorage->CreateStream failed\n"); + r = IStream_Write(stm, "this is stream 2\n", 16, NULL); + ok(r==S_OK, "IStream->Write failed\n"); + + r = IStream_Commit(stm, STGC_ONLYIFCURRENT | STGC_DANGEROUSLYCOMMITMERELYTODISKCACHE); + ok(r==S_OK, "IStream->Commit failed\n"); + r = IStream_Release(stm); IStorage_Release(stg); @@ -902,13 +922,24 @@ static void test_transact(void) r = IStorage_OpenStream(stg, stmname, NULL, STGM_TRANSACTED|STGM_SHARE_EXCLUSIVE|STGM_READWRITE, 0, &stm ); ok(r==STG_E_INVALIDFUNCTION, "IStorage->OpenStream failed %08x\n", r); + r = IStorage_OpenStorage(stg, stmname, NULL, STGM_TRANSACTED|STGM_SHARE_EXCLUSIVE|STGM_READWRITE, NULL, 0, &stg2 ); + ok(r==STG_E_FILENOTFOUND, "IStorage->OpenStream failed %08x\n", r); + todo_wine { r = IStorage_OpenStream(stg, stmname, NULL, STGM_SHARE_EXCLUSIVE|STGM_READWRITE, 0, &stm ); ok(r==STG_E_FILENOTFOUND, "IStorage->OpenStream should fail %08x\n", r); } + if (stm) + r = IStream_Release(stm); + r = IStorage_OpenStorage(stg, stmname2, NULL, STGM_TRANSACTED|STGM_SHARE_EXCLUSIVE|STGM_READWRITE, NULL, 0, &stg2 ); + ok(r==STG_E_FILENOTFOUND, "IStorage->OpenStream failed %08x\n", r); + + r = IStorage_OpenStream(stg, stmname2, NULL, STGM_SHARE_EXCLUSIVE|STGM_READWRITE, 0, &stm ); + ok(r==S_OK, "IStorage->OpenStream should fail %08x\n", r); if (stm) r = IStream_Release(stm); + IStorage_Release(stg); r = DeleteFileW(filename);
1
0
0
0
Mike McCormack : msi: Test the dispid for CreateRecord.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 224ead82531b85ac9366227d3d7975452f810d1b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=224ead82531b85ac9366227d3…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:41:12 2007 +0900 msi: Test the dispid for CreateRecord. --- dlls/msi/tests/iface.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/iface.c b/dlls/msi/tests/iface.c index d7dc640..9a0742b 100644 --- a/dlls/msi/tests/iface.c +++ b/dlls/msi/tests/iface.c @@ -64,6 +64,7 @@ static void test_msi_dispid(void) } todo_wine { + ok( get_dispid( disp, "CreateRecord" ) == 1, "dispid wrong\n"); ok( get_dispid( disp, "OpenPackage" ) == 2, "dispid wrong\n"); ok( get_dispid( disp, "OpenProduct" ) == 3, "dispid wrong\n"); ok( get_dispid( disp, "OpenDatabase" ) == 4, "dispid wrong\n");
1
0
0
0
Mike McCormack : msi: Add the generated typelib to the resources.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 59736773d731e55cfd0faa60d246857f3486beee URL:
http://source.winehq.org/git/wine.git/?a=commit;h=59736773d731e55cfd0faa60d…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:40:59 2007 +0900 msi: Add the generated typelib to the resources. --- dlls/msi/msi.rc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msi/msi.rc b/dlls/msi/msi.rc index ed818ad..cbe18fe 100644 --- a/dlls/msi/msi.rc +++ b/dlls/msi/msi.rc @@ -46,6 +46,8 @@ LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL +1 TYPELIB LOADONCALL DISCARDABLE msiserver.tlb + /* BINRES instadvert.bmp */ 0x1001 BITMAP instadvert.bmp /* {
1
0
0
0
Mike McCormack : msi: Factor out code to calculate column offsets.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: a16e5151da9432f7deab7b89d4babb421b40e569 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a16e5151da9432f7deab7b89d…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:08:20 2007 +0900 msi: Factor out code to calculate column offsets. --- dlls/msi/table.c | 35 +++++++++++++++++++++-------------- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index dd611d2..420519b 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -873,6 +873,24 @@ static const MSICOLUMNINFO _Tables_cols[ { szTables, 1, szName, MSITYPE_VALID | MSITYPE_STRING | 64, 0 }, }; +static void table_calc_column_offsets( MSICOLUMNINFO *colinfo, DWORD count ) +{ + DWORD i; + + for( i=0; colinfo && (i<count); i++ ) + { + assert( (i+1) == colinfo[ i ].number ); + if (i) + colinfo[i].offset = colinfo[ i - 1 ].offset + + bytes_per_column( &colinfo[ i - 1 ] ); + else + colinfo[i].offset = 0; + TRACE("column %d is [%s] with type %08x ofs %d\n", + colinfo[i].number, debugstr_w(colinfo[i].colname), + colinfo[i].type, colinfo[i].offset); + } +} + static UINT get_defaulttablecolumns( LPCWSTR name, MSICOLUMNINFO *colinfo, UINT *sz) { const MSICOLUMNINFO *p; @@ -905,6 +923,7 @@ static UINT get_defaulttablecolumns( LPC if( colinfo && (i >= *sz) ) break; } + table_calc_column_offsets( colinfo, n ); *sz = n; return ERROR_SUCCESS; } @@ -994,26 +1013,14 @@ static UINT get_tablecolumns( MSIDATABAS TRACE("%s has %d columns\n", debugstr_w(szTableName), n); - if (maxcount && n != maxcount) + if (colinfo && n != maxcount) { ERR("missing column in table %s\n", debugstr_w(szTableName)); msi_free_colinfo(colinfo, maxcount ); return ERROR_FUNCTION_FAILED; } - /* calculate the offsets */ - for( i=0; maxcount && (i<maxcount); i++ ) - { - assert( (i+1) == colinfo[ i ].number ); - if (i) - colinfo[i].offset = colinfo[ i - 1 ].offset - + bytes_per_column( &colinfo[ i - 1 ] ); - else - colinfo[i].offset = 0; - TRACE("column %d is [%s] with type %08x ofs %d\n", - colinfo[i].number, debugstr_w(colinfo[i].colname), - colinfo[i].type, colinfo[i].offset); - } + table_calc_column_offsets( colinfo, n ); *sz = n; return ERROR_SUCCESS;
1
0
0
0
Mike McCormack : msi: Add a test showing MsiGetProperty returns correct values.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 824b89987a27837daf8ab005da0055ad71c526d9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=824b89987a27837daf8ab005d…
Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Feb 6 18:07:52 2007 +0900 msi: Add a test showing MsiGetProperty returns correct values. --- dlls/msi/tests/package.c | 31 +++++++++++++++++++++++++++++-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index a0a72f0..233b472 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -1347,12 +1347,26 @@ static BOOL check_prop_empty( MSIHANDLE static void test_props(void) { - MSIHANDLE hpkg; + MSIHANDLE hpkg, hdb; UINT r; DWORD sz; char buffer[0x100]; - hpkg = package_from_db(create_package_db()); + hdb = create_package_db(); + r = run_query( hdb, + "CREATE TABLE `Property` ( " + "`Property` CHAR(255) NOT NULL, " + "`Value` CHAR(255) " + "PRIMARY KEY `Property`)" ); + ok( r == ERROR_SUCCESS , "Failed\n" ); + + r = run_query(hdb, + "INSERT INTO `Property` " + "(`Property`, `Value`) " + "VALUES( 'MetadataCompName', 'Photoshop.dll' )"); + ok( r == ERROR_SUCCESS , "Failed\n" ); + + hpkg = package_from_db( hdb ); ok( hpkg, "failed to create package\n"); /* test invalid values */ @@ -1473,6 +1487,19 @@ static void test_props(void) ok( !strcmp(buffer,"foo"), "buffer wrong\n"); ok( sz == 3, "wrong size returned\n"); + r = MsiSetProperty(hpkg, "MetadataCompName", "Photoshop.dll"); + ok( r == ERROR_SUCCESS, "wrong return val\n"); + + sz = 0; + r = MsiGetProperty(hpkg, "MetadataCompName", NULL, &sz ); + ok( r == ERROR_SUCCESS, "return wrong\n"); + ok( sz == 13, "size wrong (%d)\n", sz); + + sz = 13; + r = MsiGetProperty(hpkg, "MetadataCompName", buffer, &sz ); + ok( r == ERROR_MORE_DATA, "return wrong\n"); + ok( !strcmp(buffer,"Photoshop.dl"), "buffer wrong\n"); + MsiCloseHandle( hpkg ); DeleteFile(msifile); }
1
0
0
0
Jan Zerebecki : urlmon: Remove redundant const.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: ea6ee42c714e2408e09539aa19fb99adf2778c52 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea6ee42c714e2408e09539aa1…
Author: Jan Zerebecki <jan.wine(a)zerebecki.de> Date: Tue Feb 6 08:42:22 2007 +0100 urlmon: Remove redundant const. --- dlls/urlmon/urlmon_main.c | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/dlls/urlmon/urlmon_main.c b/dlls/urlmon/urlmon_main.c index 5dc9b54..7cee585 100644 --- a/dlls/urlmon/urlmon_main.c +++ b/dlls/urlmon/urlmon_main.c @@ -400,7 +400,7 @@ void WINAPI ReleaseBindInfo(BINDINFO* pb * * Determines the Multipurpose Internet Mail Extensions (MIME) type from the data provided. */ -static BOOL text_html_filter(const BYTE const *b, DWORD size) +static BOOL text_html_filter(const BYTE *b, DWORD size) { int i; @@ -419,7 +419,7 @@ static BOOL text_html_filter(const BYTE return FALSE; } -static BOOL image_gif_filter(const BYTE const *b, DWORD size) +static BOOL image_gif_filter(const BYTE *b, DWORD size) { return size >= 6 && (b[0] == 'G' || b[0] == 'g') @@ -430,69 +430,69 @@ static BOOL image_gif_filter(const BYTE && (b[5] == 'A' || b[5] == 'a'); } -static BOOL image_pjpeg_filter(const BYTE const *b, DWORD size) +static BOOL image_pjpeg_filter(const BYTE *b, DWORD size) { return size > 2 && b[0] == 0xff && b[1] == 0xd8; } -static BOOL image_tiff_filter(const BYTE const *b, DWORD size) +static BOOL image_tiff_filter(const BYTE *b, DWORD size) { return size > 2 && b[0] == 0x4d && b[1] == 0x4d; } -static BOOL image_xpng_filter(const BYTE const *b, DWORD size) +static BOOL image_xpng_filter(const BYTE *b, DWORD size) { static const BYTE xpng_header[] = {0x89,'P','N','G',0x0d,0x0a,0x1a,0x0a}; return size > sizeof(xpng_header) && !memcmp(b, xpng_header, sizeof(xpng_header)); } -static BOOL image_bmp_filter(const BYTE const *b, DWORD size) +static BOOL image_bmp_filter(const BYTE *b, DWORD size) { return size >= 14 && b[0] == 0x42 && b[1] == 0x4d && *(const DWORD *)(b+6) == 0; } -static BOOL video_avi_filter(const BYTE const *b, DWORD size) +static BOOL video_avi_filter(const BYTE *b, DWORD size) { return size > 12 && b[0] == 'R' && b[1] == 'I' && b[2] == 'F' && b[3] == 'F' && b[8] == 'A' && b[9] == 'V' && b[10] == 'I' && b[11] == 0x20; } -static BOOL video_mpeg_filter(const BYTE const *b, DWORD size) +static BOOL video_mpeg_filter(const BYTE *b, DWORD size) { return size > 4 && !b[0] && !b[1] && b[2] == 0x01 && (b[3] == 0xb3 || b[3] == 0xba); } -static BOOL application_pdf_filter(const BYTE const *b, DWORD size) +static BOOL application_pdf_filter(const BYTE *b, DWORD size) { return size > 4 && b[0] == 0x25 && b[1] == 0x50 && b[2] == 0x44 && b[3] == 0x46; } -static BOOL application_xzip_filter(const BYTE const *b, DWORD size) +static BOOL application_xzip_filter(const BYTE *b, DWORD size) { return size > 2 && b[0] == 0x50 && b[1] == 0x4b; } -static BOOL application_xgzip_filter(const BYTE const *b, DWORD size) +static BOOL application_xgzip_filter(const BYTE *b, DWORD size) { return size > 2 && b[0] == 0x1f && b[1] == 0x8b; } -static BOOL application_java_filter(const BYTE const *b, DWORD size) +static BOOL application_java_filter(const BYTE *b, DWORD size) { return size > 4 && b[0] == 0xca && b[1] == 0xfe && b[2] == 0xba && b[3] == 0xbe; } -static BOOL application_xmsdownload(const BYTE const *b, DWORD size) +static BOOL application_xmsdownload(const BYTE *b, DWORD size) { return size > 2 && b[0] == 'M' && b[1] == 'Z'; } -static BOOL text_plain_filter(const BYTE const *b, DWORD size) +static BOOL text_plain_filter(const BYTE *b, DWORD size) { const BYTE *ptr; @@ -504,7 +504,7 @@ static BOOL text_plain_filter(const BYTE return TRUE; } -static BOOL application_octet_stream_filter(const BYTE const *b, DWORD size) +static BOOL application_octet_stream_filter(const BYTE *b, DWORD size) { return TRUE; } @@ -539,7 +539,7 @@ HRESULT WINAPI FindMimeFromData(LPBC pBC } if(pBuffer) { - const BYTE const *buf = pBuffer; + const BYTE *buf = pBuffer; DWORD len; LPCWSTR ret = NULL; int i; @@ -568,7 +568,7 @@ HRESULT WINAPI FindMimeFromData(LPBC pBC static const struct { LPCWSTR mime; - BOOL (*filter)(const BYTE const*,DWORD); + BOOL (*filter)(const BYTE *,DWORD); } mime_filters[] = { {wszTextHtml, text_html_filter}, {wszImageGif, image_gif_filter},
1
0
0
0
Misha Koshelev : msi: InstallPackage check for UI level must not disregard flags.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: ecd20e28ac8de743483ae9c313ab6d56be502aa6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ecd20e28ac8de743483ae9c31…
Author: Misha Koshelev <mk144210(a)bcm.tmc.edu> Date: Mon Feb 5 23:25:15 2007 -0600 msi: InstallPackage check for UI level must not disregard flags. --- dlls/msi/action.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 0c8ac79..6c2fdf4 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -642,7 +642,7 @@ UINT MSI_InstallPackage( MSIPACKAGE *pac msi_apply_transforms( package ); msi_apply_patches( package ); - if ( msi_get_property_int(package, szUILevel, 0) >= INSTALLUILEVEL_REDUCED ) + if ( (msi_get_property_int(package, szUILevel, 0) & 0xf) >= INSTALLUILEVEL_REDUCED ) { package->script->InWhatSequence |= SEQUENCE_UI; rc = ACTION_ProcessUISequence(package);
1
0
0
0
Andrew Talbot : wineps.drv: Declare some functions static.
by Alexandre Julliard
06 Feb '07
06 Feb '07
Module: wine Branch: master Commit: 550ea86ffd37f57dba71167425c789334cafe965 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=550ea86ffd37f57dba7116742…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Feb 5 21:24:35 2007 +0000 wineps.drv: Declare some functions static. --- dlls/wineps.drv/driver.c | 4 ++-- dlls/wineps.drv/escape.c | 2 +- dlls/wineps.drv/ppd.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index e096bf6..fececd7 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -195,8 +195,8 @@ WORD WINAPI PSDRV_AdvancedSetupDialog16( * * Dialog proc for 'Paper' propsheet */ -INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM - lParam) +static INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, + WPARAM wParam, LPARAM lParam) { PSDRV_DLGINFO *di; int i, Cursel = 0; diff --git a/dlls/wineps.drv/escape.c b/dlls/wineps.drv/escape.c index dcc972e..3e5de7f 100644 --- a/dlls/wineps.drv/escape.c +++ b/dlls/wineps.drv/escape.c @@ -381,7 +381,7 @@ INT PSDRV_EndPage( PSDRV_PDEVICE *physDe /************************************************************************ * PSDRV_StartDocA */ -INT PSDRV_StartDocA( PSDRV_PDEVICE *physDev, const DOCINFOA *doc ) +static INT PSDRV_StartDocA( PSDRV_PDEVICE *physDev, const DOCINFOA *doc ) { LPCSTR output = "LPT1:"; BYTE buf[300]; diff --git a/dlls/wineps.drv/ppd.c b/dlls/wineps.drv/ppd.c index 0b17bce..9b7169b 100644 --- a/dlls/wineps.drv/ppd.c +++ b/dlls/wineps.drv/ppd.c @@ -467,7 +467,7 @@ static BOOL PSDRV_PPDGetNextTuple(FILE * * entry which is appended to the list if name is not found. * */ -PAGESIZE *PSDRV_PPDGetPageSizeInfo(PPD *ppd, char *name) +static PAGESIZE *PSDRV_PPDGetPageSizeInfo(PPD *ppd, char *name) { PAGESIZE *page = ppd->PageSizes, *lastpage;
1
0
0
0
← Newer
1
...
71
72
73
74
75
76
77
...
84
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Results per page:
10
25
50
100
200