winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
February 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
839 discussions
Start a n
N
ew thread
Andrew Talbot : wtsapi32: Declare a variable static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 7e13c16cbcc2b0b96da8f9216bb7c809ee7358d7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7e13c16cbcc2b0b96da8f9216…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Sat Feb 3 14:25:13 2007 +0000 wtsapi32: Declare a variable static. --- dlls/wtsapi32/wtsapi32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wtsapi32/wtsapi32.c b/dlls/wtsapi32/wtsapi32.c index 91b1aa4..cec23ee 100644 --- a/dlls/wtsapi32/wtsapi32.c +++ b/dlls/wtsapi32/wtsapi32.c @@ -25,7 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wtsapi); -HMODULE WTSAPI32_hModule = 0; +static HMODULE WTSAPI32_hModule; BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) {
1
0
0
0
Andrew Talbot : winmm: Declare a function static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 77250f3ce89ee3c030279632942ceb976dc8774c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=77250f3ce89ee3c0302796329…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Sat Feb 3 11:27:52 2007 +0000 winmm: Declare a function static. --- dlls/winmm/message16.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/winmm/message16.c b/dlls/winmm/message16.c index 6ecf34b..54e9939 100644 --- a/dlls/winmm/message16.c +++ b/dlls/winmm/message16.c @@ -1793,9 +1793,9 @@ theEnd: * MMDRV_LoadMMDrvFunc16 * */ -unsigned MMDRV_LoadMMDrvFunc16(LPCSTR drvName, LPWINE_DRIVER d, - LPWINE_MM_DRIVER lpDrv) -{ +static unsigned MMDRV_LoadMMDrvFunc16(LPCSTR drvName, LPWINE_DRIVER d, + LPWINE_MM_DRIVER lpDrv) +{ WINEMM_msgFunc16 func; unsigned count = 0; char buffer[128];
1
0
0
0
Andrew Talbot : winemp3.acm: Declare some items static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 6d7e1e73271a05c940dd1f4cc757caed0604d634 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6d7e1e73271a05c940dd1f4cc…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Fri Feb 2 17:25:09 2007 +0000 winemp3.acm: Declare some items static. --- dlls/winemp3.acm/layer1.c | 6 +++--- dlls/winemp3.acm/layer2.c | 5 +++-- dlls/winemp3.acm/layer3.c | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/dlls/winemp3.acm/layer1.c b/dlls/winemp3.acm/layer1.c index 001811b..45caf30 100644 --- a/dlls/winemp3.acm/layer1.c +++ b/dlls/winemp3.acm/layer1.c @@ -24,7 +24,7 @@ #include "mpg123.h" -void I_step_one(unsigned int balloc[], unsigned int scale_index[2][SBLIMIT],struct frame *fr) +static void I_step_one(unsigned int balloc[], unsigned int scale_index[2][SBLIMIT],struct frame *fr) { unsigned int *ba=balloc; unsigned int *sca = (unsigned int *) scale_index; @@ -64,8 +64,8 @@ void I_step_one(unsigned int balloc[], u } } -void I_step_two(real fraction[2][SBLIMIT],unsigned int balloc[2*SBLIMIT], - unsigned int scale_index[2][SBLIMIT],struct frame *fr) +static void I_step_two(real fraction[2][SBLIMIT],unsigned int balloc[2*SBLIMIT], + unsigned int scale_index[2][SBLIMIT],struct frame *fr) { int i,n; int smpb[2*SBLIMIT]; /* values: 0-65535 */ diff --git a/dlls/winemp3.acm/layer2.c b/dlls/winemp3.acm/layer2.c index be765f0..5e3fbdf 100644 --- a/dlls/winemp3.acm/layer2.c +++ b/dlls/winemp3.acm/layer2.c @@ -71,7 +71,7 @@ void init_layer2(void) } -void II_step_one(unsigned int *bit_alloc,int *scale,struct frame *fr) +static void II_step_one(unsigned int *bit_alloc,int *scale,struct frame *fr) { int stereo = fr->stereo-1; int sblimit = fr->II_sblimit; @@ -144,7 +144,8 @@ void II_step_one(unsigned int *bit_alloc } -void II_step_two(unsigned int *bit_alloc,real fraction[2][4][SBLIMIT],int *scale,struct frame *fr,int x1) +static void II_step_two(unsigned int *bit_alloc, real fraction[2][4][SBLIMIT], + int *scale, struct frame *fr, int x1) { int i,j,k,ba; int stereo = fr->stereo; diff --git a/dlls/winemp3.acm/layer3.c b/dlls/winemp3.acm/layer3.c index 35ad213..398a0a0 100644 --- a/dlls/winemp3.acm/layer3.c +++ b/dlls/winemp3.acm/layer3.c @@ -48,8 +48,8 @@ struct bandInfoStruct { short shortDiff[13]; }; -int longLimit[9][23]; -int shortLimit[9][14]; +static int longLimit[9][23]; +static int shortLimit[9][14]; static const struct bandInfoStruct bandInfo[9] = {
1
0
0
0
Andrew Talbot : quartz: Fix a typo.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 6ef74bc9c885b0ef053b7c060bf79b4f539a3b3b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6ef74bc9c885b0ef053b7c060…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Fri Feb 2 17:47:54 2007 +0000 quartz: Fix a typo. Should fix Coverity CID-348 (dereference before NULL check). --- dlls/quartz/pin.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c index 9336022..5bc84bf 100644 --- a/dlls/quartz/pin.c +++ b/dlls/quartz/pin.c @@ -338,7 +338,7 @@ HRESULT WINAPI IPinImpl_QueryId(IPin * i TRACE("(%p/%p)->(%p)\n", This, iface, Id); *Id = CoTaskMemAlloc((strlenW(This->pinInfo.achName) + 1) * sizeof(WCHAR)); - if (!Id) + if (!*Id) return E_OUTOFMEMORY; strcpyW(*Id, This->pinInfo.achName);
1
0
0
0
Andrew Talbot : uxtheme: Declare some items static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 2bb44198b6958e6d981dd96c794ebdd46aa76513 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2bb44198b6958e6d981dd96c7…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Thu Feb 1 21:52:58 2007 +0000 uxtheme: Declare some items static. --- dlls/uxtheme/draw.c | 4 ++-- dlls/uxtheme/msstyles.c | 14 +++++++------- dlls/uxtheme/msstyles.h | 1 - dlls/uxtheme/system.c | 6 +++--- 4 files changed, 12 insertions(+), 13 deletions(-) diff --git a/dlls/uxtheme/draw.c b/dlls/uxtheme/draw.c index a2fee03..bad4471 100644 --- a/dlls/uxtheme/draw.c +++ b/dlls/uxtheme/draw.c @@ -1719,8 +1719,8 @@ HRESULT WINAPI GetThemeBackgroundRegion( } /* compute part size for "borderfill" backgrounds */ -HRESULT get_border_background_size (HTHEME hTheme, int iPartId, - int iStateId, THEMESIZE eSize, POINT* psz) +static HRESULT get_border_background_size (HTHEME hTheme, int iPartId, + int iStateId, THEMESIZE eSize, POINT* psz) { HRESULT hr = S_OK; int bordersize = 1; diff --git a/dlls/uxtheme/msstyles.c b/dlls/uxtheme/msstyles.c index 919a871..e555eb2 100644 --- a/dlls/uxtheme/msstyles.c +++ b/dlls/uxtheme/msstyles.c @@ -47,7 +47,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(uxtheme); BOOL MSSTYLES_GetNextInteger(LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LPCWSTR *lpValEnd, int *value); BOOL MSSTYLES_GetNextToken(LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LPCWSTR *lpValEnd, LPWSTR lpBuff, DWORD buffSize); void MSSTYLES_ParseThemeIni(PTHEME_FILE tf, BOOL setMetrics); -HRESULT MSSTYLES_GetFont (LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LPCWSTR *lpValEnd, LOGFONTW* logfont); +static HRESULT MSSTYLES_GetFont (LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LPCWSTR *lpValEnd, LOGFONTW* logfont); extern HINSTANCE hDllInst; extern int alphaBlendMode; @@ -58,7 +58,7 @@ static const WCHAR szThemesIniResource[] 't','h','e','m','e','s','_','i','n','i','\0' }; -PTHEME_FILE tfActiveTheme = NULL; +static PTHEME_FILE tfActiveTheme; /***********************************************************************/ @@ -403,7 +403,7 @@ static BOOL MSSTYLES_ParseIniSectionName * RETURNS * The class found, or NULL */ -PTHEME_CLASS MSSTYLES_FindClass(PTHEME_FILE tf, LPCWSTR pszAppName, LPCWSTR pszClassName) +static PTHEME_CLASS MSSTYLES_FindClass(PTHEME_FILE tf, LPCWSTR pszAppName, LPCWSTR pszClassName) { PTHEME_CLASS cur = tf->classes; while(cur) { @@ -675,7 +675,7 @@ struct PARSECOLORSTATE int captionColors; }; -inline void parse_init_color (struct PARSECOLORSTATE* state) +static inline void parse_init_color (struct PARSECOLORSTATE* state) { memset (state, 0, sizeof (*state)); } @@ -729,7 +729,7 @@ struct PARSENONCLIENTSTATE LOGFONTW iconTitleFont; }; -inline void parse_init_nonclient (struct PARSENONCLIENTSTATE* state) +static inline void parse_init_nonclient (struct PARSENONCLIENTSTATE* state) { memset (state, 0, sizeof (*state)); state->metrics.cbSize = sizeof (NONCLIENTMETRICSW); @@ -1226,8 +1226,8 @@ HRESULT MSSTYLES_GetPropertyColor(PTHEME * * Retrieve a color value for a property */ -HRESULT MSSTYLES_GetFont (LPCWSTR lpCur, LPCWSTR lpEnd, - LPCWSTR *lpValEnd, LOGFONTW* pFont) +static HRESULT MSSTYLES_GetFont (LPCWSTR lpCur, LPCWSTR lpEnd, + LPCWSTR *lpValEnd, LOGFONTW* pFont) { static const WCHAR szBold[] = {'b','o','l','d','\0'}; static const WCHAR szItalic[] = {'i','t','a','l','i','c','\0'}; diff --git a/dlls/uxtheme/msstyles.h b/dlls/uxtheme/msstyles.h index c333a2a..0eef06c 100644 --- a/dlls/uxtheme/msstyles.h +++ b/dlls/uxtheme/msstyles.h @@ -94,7 +94,6 @@ BOOL MSSTYLES_LookupEnum(LPCWSTR pszValu BOOL MSSTYLES_LookupPartState(LPCWSTR pszClass, LPCWSTR pszPart, LPCWSTR pszState, int *iPartId, int *iStateId); PUXINI_FILE MSSTYLES_GetThemeIni(PTHEME_FILE tf); PTHEME_PARTSTATE MSSTYLES_FindPartState(PTHEME_CLASS tc, int iPartId, int iStateId, PTHEME_CLASS *tcNext); -PTHEME_CLASS MSSTYLES_FindClass(PTHEME_FILE tf, LPCWSTR pszAppName, LPCWSTR pszClassName); PTHEME_PROPERTY MSSTYLES_FindProperty(PTHEME_CLASS tc, int iPartId, int iStateId, int iPropertyPrimitive, int iPropertyId); PTHEME_PROPERTY MSSTYLES_FindMetric(int iPropertyPrimitive, int iPropertyId); HBITMAP MSSTYLES_LoadBitmap(PTHEME_CLASS tc, LPCWSTR lpFilename, BOOL* hasAlpha); diff --git a/dlls/uxtheme/system.c b/dlls/uxtheme/system.c index b0545b1..9e69cb8 100644 --- a/dlls/uxtheme/system.c +++ b/dlls/uxtheme/system.c @@ -471,7 +471,7 @@ static void UXTHEME_SaveSystemMetrics(vo * * Change the current active theme */ -HRESULT UXTHEME_SetActiveTheme(PTHEME_FILE tf) +static HRESULT UXTHEME_SetActiveTheme(PTHEME_FILE tf) { HKEY hKey; WCHAR tmp[2]; @@ -605,7 +605,7 @@ HRESULT WINAPI EnableTheming(BOOL fEnabl * I'm using atoms as there may be large numbers of duplicated strings * and they do the work of keeping memory down as a cause of that quite nicely */ -HRESULT UXTHEME_SetWindowProperty(HWND hwnd, ATOM aProp, LPCWSTR pszValue) +static HRESULT UXTHEME_SetWindowProperty(HWND hwnd, ATOM aProp, LPCWSTR pszValue) { ATOM oldValue = (ATOM)(size_t)RemovePropW(hwnd, (LPCWSTR)MAKEINTATOM(aProp)); if(oldValue) @@ -622,7 +622,7 @@ HRESULT UXTHEME_SetWindowProperty(HWND h return S_OK; } -LPWSTR UXTHEME_GetWindowProperty(HWND hwnd, ATOM aProp, LPWSTR pszBuffer, int dwLen) +static LPWSTR UXTHEME_GetWindowProperty(HWND hwnd, ATOM aProp, LPWSTR pszBuffer, int dwLen) { ATOM atValue = (ATOM)(size_t)GetPropW(hwnd, (LPCWSTR)MAKEINTATOM(aProp)); if(atValue) {
1
0
0
0
Andrew Talbot : user32: Declare some functions static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 29c66df45b9c20703469e8a1ac517823ffd94ede URL:
http://source.winehq.org/git/wine.git/?a=commit;h=29c66df45b9c20703469e8a1a…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Wed Jan 31 20:22:01 2007 +0000 user32: Declare some functions static. --- dlls/user32/comm16.c | 2 +- dlls/user32/menu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/user32/comm16.c b/dlls/user32/comm16.c index ebeb97c..4f6a076 100644 --- a/dlls/user32/comm16.c +++ b/dlls/user32/comm16.c @@ -361,7 +361,7 @@ static void comm_waitwrite(struct DosDev /***************************************************************************** * COMM16_DCBtoDCB16 (Internal) */ -INT16 COMM16_DCBtoDCB16(LPDCB lpdcb, LPDCB16 lpdcb16) +static INT16 COMM16_DCBtoDCB16(LPDCB lpdcb, LPDCB16 lpdcb16) { if(lpdcb->BaudRate<0x10000) lpdcb16->BaudRate = lpdcb->BaudRate; diff --git a/dlls/user32/menu.c b/dlls/user32/menu.c index 0e87fde..4ac2e93 100644 --- a/dlls/user32/menu.c +++ b/dlls/user32/menu.c @@ -440,7 +440,7 @@ static HMENU MENU_CopySysPopup(void) * However, the real system menu handle is sometimes seen in the * WM_MENUSELECT parameters (and Word 6 likes it this way). */ -HMENU MENU_GetSysMenu( HWND hWnd, HMENU hPopupMenu ) +static HMENU MENU_GetSysMenu( HWND hWnd, HMENU hPopupMenu ) { HMENU hMenu;
1
0
0
0
Andrew Talbot : shdocvw: Declare some functions static.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: f06c01e230df3451757bc07523bdfb8f8f97c85d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f06c01e230df3451757bc0752…
Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Jan 29 18:12:56 2007 +0000 shdocvw: Declare some functions static. --- dlls/shdocvw/navigate.c | 4 ++-- dlls/shdocvw/shdocvw_main.c | 2 +- dlls/shdocvw/shlinstobj.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index dcbbb24..3d3ff61 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -548,8 +548,8 @@ HRESULT navigate_url(DocHost *This, BSTR return hres; } -HRESULT navigate_hlink(DocHost *This, IMoniker *mon, IBindCtx *bindctx, - IBindStatusCallback *callback) +static HRESULT navigate_hlink(DocHost *This, IMoniker *mon, IBindCtx *bindctx, + IBindStatusCallback *callback) { IHttpNegotiate *http_negotiate; LPWSTR url = NULL; diff --git a/dlls/shdocvw/shdocvw_main.c b/dlls/shdocvw/shdocvw_main.c index 89956ac..551fb3e 100644 --- a/dlls/shdocvw/shdocvw_main.c +++ b/dlls/shdocvw/shdocvw_main.c @@ -126,7 +126,7 @@ HRESULT WINAPI DllInstall(BOOL bInstall, * * makes sure the handle to shell32 is valid */ - BOOL SHDOCVW_LoadShell32(void) +static BOOL SHDOCVW_LoadShell32(void) { if (SHDOCVW_hshell32) return TRUE; diff --git a/dlls/shdocvw/shlinstobj.c b/dlls/shdocvw/shlinstobj.c index 6a39fe9..a697918 100644 --- a/dlls/shdocvw/shlinstobj.c +++ b/dlls/shdocvw/shlinstobj.c @@ -169,7 +169,7 @@ static const IPropertyBagVtbl RegistryPr RegistryPropertyBag_IPropertyBag_Write }; -HRESULT RegistryPropertyBag_Constructor(HKEY hInitPropertyBagKey, REFIID riid, LPVOID *ppvObject) { +static HRESULT RegistryPropertyBag_Constructor(HKEY hInitPropertyBagKey, REFIID riid, LPVOID *ppvObject) { HRESULT hr = E_FAIL; RegistryPropertyBag *pRegistryPropertyBag; @@ -313,8 +313,8 @@ static const IClassFactoryVtbl InstanceO InstanceObjectFactory_IClassFactory_LockServer }; -HRESULT InstanceObjectFactory_Constructor(REFCLSID rclsid, IPropertyBag *pPropertyBag, REFIID riid, - LPVOID *ppvObject) +static HRESULT InstanceObjectFactory_Constructor(REFCLSID rclsid, IPropertyBag *pPropertyBag, + REFIID riid, LPVOID *ppvObject) { InstanceObjectFactory *pInstanceObjectFactory; HRESULT hr = E_FAIL;
1
0
0
0
Dmitry Timoshkov : dbghelp: Turn a FIXME to a WARN in order to avoid mangling the output.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 736743dd57c0445b5cc7802bf9f16924295e157d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=736743dd57c0445b5cc7802bf…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Mon Feb 5 14:20:23 2007 +0800 dbghelp: Turn a FIXME to a WARN in order to avoid mangling the output. --- dlls/dbghelp/dwarf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index e8f9d3e..6ff33f2 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1319,7 +1319,7 @@ static void dwarf2_parse_variable(dwarf2 else if (dwarf2_find_attribute(subpgm->ctx, di, DW_AT_const_value, &value)) { VARIANT v; - if (subpgm->func) FIXME("Unsupported constant %s in function\n", name.u.string); + if (subpgm->func) WARN("Unsupported constant %s in function\n", name.u.string); if (is_pmt) FIXME("Unsupported constant (parameter) %s in function\n", name.u.string); switch (value.form) {
1
0
0
0
Dmitry Timoshkov : winedump: Add a sanity check before dumping long format library export.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: 6d62ef657de15216c7ee23d722fa3b1f02ec7dcb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6d62ef657de15216c7ee23d72…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Mon Feb 5 14:19:44 2007 +0800 winedump: Add a sanity check before dumping long format library export. --- tools/winedump/lib.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/winedump/lib.c b/tools/winedump/lib.c index a7f8367..155a6fa 100644 --- a/tools/winedump/lib.c +++ b/tools/winedump/lib.c @@ -183,6 +183,9 @@ void lib_dump(void) cur_file_pos += sizeof(IMAGE_ARCHIVE_MEMBER_HEADER); + size = strtoul((const char *)iamh->Size, NULL, 10); + size = (size + 1) & ~1; /* align to an even address */ + /* FIXME: only import library contents with the short format are * recognized. */ @@ -193,6 +196,7 @@ void lib_dump(void) } else if (strncmp((const char *)iamh->Name, IMAGE_ARCHIVE_LINKER_MEMBER, sizeof(iamh->Name))) { + long expected_size; const IMAGE_FILE_HEADER *fh = (const IMAGE_FILE_HEADER *)ioh; if (globals.do_dumpheader) @@ -204,12 +208,12 @@ void lib_dump(void) dump_optional_header(oh, fh->SizeOfOptionalHeader); } } - dump_long_import(fh, (const IMAGE_SECTION_HEADER *)((const char *)fh + sizeof(*fh) + fh->SizeOfOptionalHeader), fh->NumberOfSections); + /* Sanity check */ + expected_size = sizeof(*fh) + fh->SizeOfOptionalHeader + fh->NumberOfSections * sizeof(IMAGE_SECTION_HEADER); + if (size > expected_size) + dump_long_import(fh, (const IMAGE_SECTION_HEADER *)((const char *)fh + sizeof(*fh) + fh->SizeOfOptionalHeader), fh->NumberOfSections); } - size = strtoul((const char *)iamh->Size, NULL, 10); - size = (size + 1) & ~1; /* align to an even address */ - cur_file_pos += size; } }
1
0
0
0
Dmitry Timoshkov : kernel32: Add a trace to MultiByteToWideChar.
by Alexandre Julliard
05 Feb '07
05 Feb '07
Module: wine Branch: master Commit: d32d5a4706ebe123a277c53a3667a5e29a3fb48b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d32d5a4706ebe123a277c53a3…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Jan 31 18:40:05 2007 +0800 kernel32: Add a trace to MultiByteToWideChar. --- dlls/kernel32/locale.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c index 25196da..1c6e537 100644 --- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c @@ -1823,6 +1823,8 @@ INT WINAPI MultiByteToWideChar( UINT pag } ret = 0; } + TRACE("cp %d %s -> %s, ret = %d\n", + page, debugstr_an(src, srclen), debugstr_wn(dst, ret), ret); return ret; }
1
0
0
0
← Newer
1
...
77
78
79
80
81
82
83
84
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Results per page:
10
25
50
100
200