wine-commits March 2007

wine-commits@winehq.org

3 participants
844 discussions

Andrew Talbot : secur32: Replace const pointer parameters with correct pointers to const.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: e7730a16680741f6bbce80b284fe2349df1d8030 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e7730a16680741f6bbce80b28… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Mar 26 21:29:02 2007 +0100 secur32: Replace const pointer parameters with correct pointers to const. --- dlls/secur32/secur32.c | 2 +- dlls/secur32/secur32_priv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/secur32/secur32.c b/dlls/secur32/secur32.c index ee0b080..421b115 100644 --- a/dlls/secur32/secur32.c +++ b/dlls/secur32/secur32.c @@ -389,7 +389,7 @@ static void _copyPackageInfo(PSecPkgInfoW info, const SecPkgInfoA *inInfoA, } SecureProvider *SECUR32_addProvider(const SecurityFunctionTableA *fnTableA, - const SecurityFunctionTableW *fnTableW, const PWSTR moduleName) + const SecurityFunctionTableW *fnTableW, PCWSTR moduleName) { SecureProvider *ret; diff --git a/dlls/secur32/secur32_priv.h b/dlls/secur32/secur32_priv.h index 29c48e7..8e80dea 100644 --- a/dlls/secur32/secur32_priv.h +++ b/dlls/secur32/secur32_priv.h @@ -103,7 +103,7 @@ typedef enum _sign_direction { * Returns a pointer to the stored provider entry, for use adding packages. */ SecureProvider *SECUR32_addProvider(const SecurityFunctionTableA *fnTableA, - const SecurityFunctionTableW *fnTableW, const PWSTR moduleName); + const SecurityFunctionTableW *fnTableW, PCWSTR moduleName); /* Allocates space for and adds toAdd packages with the given provider. * provider must not be NULL, and either infoA or infoW may be NULL, but not

1 0

Andrew Talbot : loader: Replace inline static with static inline.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: cb5dcc68f82ba75cd054122dc8bf85553bf41e1a URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb5dcc68f82ba75cd054122dc… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Mar 26 20:27:22 2007 +0100 loader: Replace inline static with static inline. --- loader/kthread.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/loader/kthread.c b/loader/kthread.c index 1c43be5..2b64e27 100644 --- a/loader/kthread.c +++ b/loader/kthread.c @@ -167,7 +167,7 @@ static int next_temp_stack; /* next temp stack to use */ * * Get a temporary stack address to run the thread exit code on. */ -inline static char *get_temp_stack(void) +static inline char *get_temp_stack(void) { unsigned int next = interlocked_xchg_add( &next_temp_stack, 1 ); return temp_stacks[next % NB_TEMP_STACKS] + TEMP_STACK_SIZE;

1 0

Andrew Talbot : winelib: Replace inline static with static inline.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: 4125821a99262565afc68b2269a9955693caf71f URL: http://source.winehq.org/git/wine.git/?a=commit;h=4125821a99262565afc68b226… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Mar 26 20:26:29 2007 +0100 winelib: Replace inline static with static inline. --- include/wine/debug.h | 10 +++++----- include/wine/library.h | 18 +++++++++--------- include/wine/list.h | 28 ++++++++++++++-------------- include/wine/server.h | 8 ++++---- libs/wine/config.c | 2 +- libs/wine/loader.c | 6 +++--- libs/wine/utf8.c | 2 +- 7 files changed, 37 insertions(+), 37 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4125821a99262565afc68…

1 0

Andrew Talbot : comctl32: Constify some variables.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: 79205875f79ff434f7518f2a04896f9cacedb91a URL: http://source.winehq.org/git/wine.git/?a=commit;h=79205875f79ff434f7518f2a0… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Mon Mar 26 18:57:43 2007 +0100 comctl32: Constify some variables. --- dlls/comctl32/datetime.c | 26 +++++++++++++------------- dlls/comctl32/header.c | 16 ++++++++-------- dlls/comctl32/hotkey.c | 14 +++++++------- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c index 4f35b4f..faa1f72 100644 --- a/dlls/comctl32/datetime.c +++ b/dlls/comctl32/datetime.c @@ -129,8 +129,8 @@ extern int MONTHCAL_MonthLength(int month, int year); #define DTHT_MCPOPUP 0x300 /* & DTHT_DATEFIELD 0 when DATETIME_KeyDown */ #define DTHT_GOTFOCUS 0x400 /* tests for date-fields */ -static BOOL DATETIME_SendSimpleNotify (DATETIME_INFO *infoPtr, UINT code); -static BOOL DATETIME_SendDateTimeChangeNotify (DATETIME_INFO *infoPtr); +static BOOL DATETIME_SendSimpleNotify (const DATETIME_INFO *infoPtr, UINT code); +static BOOL DATETIME_SendDateTimeChangeNotify (const DATETIME_INFO *infoPtr); extern void MONTHCAL_CopyTime(const SYSTEMTIME *from, SYSTEMTIME *to); static const WCHAR allowedformatchars[] = {'d', 'h', 'H', 'm', 'M', 's', 't', 'y', 'X', '\'', 0}; static const int maxrepetition [] = {4,2,2,2,4,2,2,4,-1,-1}; @@ -152,7 +152,7 @@ DATETIME_GetSystemTime (DATETIME_INFO *infoPtr, SYSTEMTIME *lprgSysTimeArray) static BOOL -DATETIME_SetSystemTime (DATETIME_INFO *infoPtr, DWORD flag, SYSTEMTIME *lprgSysTimeArray) +DATETIME_SetSystemTime (DATETIME_INFO *infoPtr, DWORD flag, const SYSTEMTIME *lprgSysTimeArray) { if (!lprgSysTimeArray) return 0; @@ -304,7 +304,7 @@ DATETIME_SetFormatA (DATETIME_INFO *infoPtr, LPCSTR lpszFormat) static void -DATETIME_ReturnTxt (DATETIME_INFO *infoPtr, int count, LPWSTR result, int resultSize) +DATETIME_ReturnTxt (const DATETIME_INFO *infoPtr, int count, LPWSTR result, int resultSize) { static const WCHAR fmt_dW[] = { '%', 'd', 0 }; static const WCHAR fmt__2dW[] = { '%', '.', '2', 'd', 0 }; @@ -525,7 +525,7 @@ DATETIME_IncreaseField (DATETIME_INFO *infoPtr, int number, int delta) static void -DATETIME_ReturnFieldWidth (DATETIME_INFO *infoPtr, HDC hdc, int count, SHORT *fieldWidthPtr) +DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHORT *fieldWidthPtr) { /* fields are a fixed width, determined by the largest possible string */ /* presumably, these widths should be language dependent */ @@ -677,7 +677,7 @@ DATETIME_Refresh (DATETIME_INFO *infoPtr, HDC hdc) static INT -DATETIME_HitTest (DATETIME_INFO *infoPtr, POINT pt) +DATETIME_HitTest (const DATETIME_INFO *infoPtr, POINT pt) { int i; @@ -735,7 +735,7 @@ DATETIME_LButtonDown (DATETIME_INFO *infoPtr, WORD wKey, INT x, INT y) if(IsWindowVisible(infoPtr->hMonthCal)) { ShowWindow(infoPtr->hMonthCal, SW_HIDE); } else { - SYSTEMTIME *lprgSysTimeArray = &infoPtr->date; + const SYSTEMTIME *lprgSysTimeArray = &infoPtr->date; TRACE("update calendar %04d/%02d/%02d\n", lprgSysTimeArray->wYear, lprgSysTimeArray->wMonth, lprgSysTimeArray->wDay); SendMessageW(infoPtr->hMonthCal, MCM_SETCURSEL, 0, (LPARAM)(&infoPtr->date)); @@ -816,7 +816,7 @@ DATETIME_Enable (DATETIME_INFO *infoPtr, BOOL bEnable) static LRESULT -DATETIME_EraseBackground (DATETIME_INFO *infoPtr, HDC hdc) +DATETIME_EraseBackground (const DATETIME_INFO *infoPtr, HDC hdc) { HBRUSH hBrush, hSolidBrush = NULL; RECT rc; @@ -1044,7 +1044,7 @@ DATETIME_KillFocus (DATETIME_INFO *infoPtr, HWND lostFocus) static LRESULT -DATETIME_NCCreate (HWND hwnd, LPCREATESTRUCTW lpcs) +DATETIME_NCCreate (HWND hwnd, const CREATESTRUCTW *lpcs) { DWORD dwExStyle = GetWindowLongW(hwnd, GWL_EXSTYLE); /* force control to have client edge */ @@ -1072,7 +1072,7 @@ DATETIME_SetFocus (DATETIME_INFO *infoPtr, HWND lostFocus) static BOOL -DATETIME_SendDateTimeChangeNotify (DATETIME_INFO *infoPtr) +DATETIME_SendDateTimeChangeNotify (const DATETIME_INFO *infoPtr) { NMDATETIMECHANGE dtdtc; @@ -1089,7 +1089,7 @@ DATETIME_SendDateTimeChangeNotify (DATETIME_INFO *infoPtr) static BOOL -DATETIME_SendSimpleNotify (DATETIME_INFO *infoPtr, UINT code) +DATETIME_SendSimpleNotify (const DATETIME_INFO *infoPtr, UINT code) { NMHDR nmhdr; @@ -1142,7 +1142,7 @@ DATETIME_Size (DATETIME_INFO *infoPtr, WORD flags, INT width, INT height) static LRESULT -DATETIME_StyleChanged(DATETIME_INFO *infoPtr, WPARAM wStyleType, LPSTYLESTRUCT lpss) +DATETIME_StyleChanged(DATETIME_INFO *infoPtr, WPARAM wStyleType, const STYLESTRUCT *lpss) { static const WCHAR buttonW[] = { 'b', 'u', 't', 't', 'o', 'n', 0 }; @@ -1187,7 +1187,7 @@ DATETIME_SetFont (DATETIME_INFO *infoPtr, HFONT font, BOOL repaint) static LRESULT -DATETIME_Create (HWND hwnd, LPCREATESTRUCTW lpcs) +DATETIME_Create (HWND hwnd, const CREATESTRUCTW *lpcs) { static const WCHAR SysMonthCal32W[] = { 'S', 'y', 's', 'M', 'o', 'n', 't', 'h', 'C', 'a', 'l', '3', '2', 0 }; DATETIME_INFO *infoPtr = (DATETIME_INFO *)Alloc (sizeof(DATETIME_INFO)); diff --git a/dlls/comctl32/header.c b/dlls/comctl32/header.c index 93b2cb5..b9ea615 100644 --- a/dlls/comctl32/header.c +++ b/dlls/comctl32/header.c @@ -108,12 +108,12 @@ typedef struct static BOOL HEADER_PrepareCallbackItems(HWND hwnd, INT iItem, INT reqMask); static void HEADER_FreeCallbackItems(HEADER_ITEM *lpItem); static LRESULT HEADER_SendNotify(HWND hwnd, UINT code, NMHDR *hdr); -static LRESULT HEADER_SendCtrlCustomDraw(HWND hwnd, DWORD dwDrawStage, HDC hdc, RECT *rect); +static LRESULT HEADER_SendCtrlCustomDraw(HWND hwnd, DWORD dwDrawStage, HDC hdc, const RECT *rect); static const WCHAR themeClass[] = {'H','e','a','d','e','r',0}; static WCHAR emptyString[] = {0}; -static void HEADER_StoreHDItemInHeader(HEADER_ITEM *lpItem, UINT mask, HDITEMW *phdi, BOOL fUnicode) +static void HEADER_StoreHDItemInHeader(HEADER_ITEM *lpItem, UINT mask, const HDITEMW *phdi, BOOL fUnicode) { if (mask & HDI_UNSUPPORTED_FIELDS) FIXME("unsupported header fields %x\n", (mask & HDI_UNSUPPORTED_FIELDS)); @@ -182,7 +182,7 @@ HEADER_OrderToIndex(HWND hwnd, WPARAM wParam) } static void -HEADER_ChangeItemOrder(HEADER_INFO *infoPtr, INT iItem, INT iNewOrder) +HEADER_ChangeItemOrder(const HEADER_INFO *infoPtr, INT iItem, INT iNewOrder) { HEADER_ITEM *lpItem = &infoPtr->items[iItem]; INT i, nMin, nMax; @@ -257,7 +257,7 @@ HEADER_Size (HWND hwnd, WPARAM wParam) return 0; } -static void HEADER_GetHotDividerRect(HWND hwnd, HEADER_INFO *infoPtr, RECT *r) +static void HEADER_GetHotDividerRect(HWND hwnd, const HEADER_INFO *infoPtr, RECT *r) { INT iDivider = infoPtr->iHotDivider; if (infoPtr->uNumItem > 0) @@ -588,7 +588,7 @@ HEADER_RefreshItem (HWND hwnd, HDC hdc, INT iItem) static void -HEADER_InternalHitTest (HWND hwnd, LPPOINT lpPt, UINT *pFlags, INT *pItem) +HEADER_InternalHitTest (HWND hwnd, const POINT *lpPt, UINT *pFlags, INT *pItem) { HEADER_INFO *infoPtr = HEADER_GetInfoPtr (hwnd); RECT rect, rcTest; @@ -794,7 +794,7 @@ HEADER_SendSimpleNotify (HWND hwnd, UINT code) } static LRESULT -HEADER_SendCtrlCustomDraw(HWND hwnd, DWORD dwDrawStage, HDC hdc, RECT *rect) +HEADER_SendCtrlCustomDraw(HWND hwnd, DWORD dwDrawStage, HDC hdc, const RECT *rect) { NMCUSTOMDRAW nm; nm.dwDrawStage = dwDrawStage; @@ -1262,7 +1262,7 @@ HEADER_HitTest (HWND hwnd, WPARAM wParam, LPARAM lParam) static LRESULT -HEADER_InsertItemT (HWND hwnd, INT nItem, LPHDITEMW phdi, BOOL bUnicode) +HEADER_InsertItemT (HWND hwnd, INT nItem, const HDITEMW *phdi, BOOL bUnicode) { HEADER_INFO *infoPtr = HEADER_GetInfoPtr (hwnd); HEADER_ITEM *lpItem; @@ -1532,7 +1532,7 @@ HEADER_GetFont (HWND hwnd) static BOOL -HEADER_IsDragDistance(HEADER_INFO *infoPtr, POINT *pt) +HEADER_IsDragDistance(const HEADER_INFO *infoPtr, const POINT *pt) { /* Windows allows for a mouse movement before starting the drag. We use the * SM_CXDOUBLECLICK/SM_CYDOUBLECLICK as that distance. diff --git a/dlls/comctl32/hotkey.c b/dlls/comctl32/hotkey.c index b963ed7..a24a678 100644 --- a/dlls/comctl32/hotkey.c +++ b/dlls/comctl32/hotkey.c @@ -63,7 +63,7 @@ static LRESULT HOTKEY_SetFont (HOTKEY_INFO *infoPtr, HFONT hFont, BOOL redraw); #define IsOnlySet(flags) (infoPtr->CurrMod == (flags)) static BOOL -HOTKEY_IsCombInv(HOTKEY_INFO *infoPtr) +HOTKEY_IsCombInv(const HOTKEY_INFO *infoPtr) { TRACE("(infoPtr=%p)\n", infoPtr); if((infoPtr->InvComb & HKCOMB_NONE) && !infoPtr->CurrMod) @@ -197,7 +197,7 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) } static LRESULT -HOTKEY_GetHotKey(HOTKEY_INFO *infoPtr) +HOTKEY_GetHotKey(const HOTKEY_INFO *infoPtr) { TRACE("(infoPtr=%p) Modifiers: 0x%x, Virtual Key: %d\n", infoPtr, HIBYTE(infoPtr->HotKey), LOBYTE(infoPtr->HotKey)); @@ -226,7 +226,7 @@ HOTKEY_SetRules(HOTKEY_INFO *infoPtr, WORD invComb, WORD invMod) static LRESULT -HOTKEY_Create (HOTKEY_INFO *infoPtr, LPCREATESTRUCTW lpcs) +HOTKEY_Create (HOTKEY_INFO *infoPtr, const CREATESTRUCTW *lpcs) { infoPtr->hwndNotify = lpcs->hwndParent; @@ -248,7 +248,7 @@ HOTKEY_Destroy (HOTKEY_INFO *infoPtr) static LRESULT -HOTKEY_EraseBackground (HOTKEY_INFO *infoPtr, HDC hdc) +HOTKEY_EraseBackground (const HOTKEY_INFO *infoPtr, HDC hdc) { HBRUSH hBrush, hSolidBrush = NULL; RECT rc; @@ -275,7 +275,7 @@ HOTKEY_EraseBackground (HOTKEY_INFO *infoPtr, HDC hdc) static inline LRESULT -HOTKEY_GetFont (HOTKEY_INFO *infoPtr) +HOTKEY_GetFont (const HOTKEY_INFO *infoPtr) { return (LRESULT)infoPtr->hFont; } @@ -393,7 +393,7 @@ HOTKEY_KillFocus (HOTKEY_INFO *infoPtr, HWND receiveFocus) static LRESULT -HOTKEY_LButtonDown (HOTKEY_INFO *infoPtr) +HOTKEY_LButtonDown (const HOTKEY_INFO *infoPtr) { if (!(GetWindowLongW(infoPtr->hwndSelf, GWL_STYLE) & WS_DISABLED)) SetFocus (infoPtr->hwndSelf); @@ -403,7 +403,7 @@ HOTKEY_LButtonDown (HOTKEY_INFO *infoPtr) static inline LRESULT -HOTKEY_NCCreate (HWND hwnd, LPCREATESTRUCTW lpcs) +HOTKEY_NCCreate (HWND hwnd, const CREATESTRUCTW *lpcs) { HOTKEY_INFO *infoPtr; DWORD dwExStyle = GetWindowLongW (hwnd, GWL_EXSTYLE);

1 0

Chris Robinson : quartz: Return proper CLSID for parser filters.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: a110e6e433e5e927b610514e9c6d0a419e9f7da8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a110e6e433e5e927b610514e9… Author: Chris Robinson <chris.kcat(a)gmail.com> Date: Mon Mar 26 01:18:17 2007 -0700 quartz: Return proper CLSID for parser filters. --- dlls/quartz/parser.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c index 15e01e8..e1f2c62 100644 --- a/dlls/quartz/parser.c +++ b/dlls/quartz/parser.c @@ -223,9 +223,11 @@ static ULONG WINAPI Parser_Release(IBaseFilter * iface) static HRESULT WINAPI Parser_GetClassID(IBaseFilter * iface, CLSID * pClsid) { + ParserImpl *This = (ParserImpl *)iface; + TRACE("(%p)\n", pClsid); - *pClsid = CLSID_AviSplitter; + *pClsid = This->clsid; return S_OK; }

1 0

Piotr Caban : comctl32: Set label width after editting.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: 2b1f1093f0a1885dd1d199e241a88aace9ef05ff URL: http://source.winehq.org/git/wine.git/?a=commit;h=2b1f1093f0a1885dd1d199e24… Author: Piotr Caban <piotr.caban(a)gmail.com> Date: Mon Mar 26 16:34:48 2007 +0200 comctl32: Set label width after editting. --- dlls/comctl32/treeview.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c index 85e6f68..dce755b 100644 --- a/dlls/comctl32/treeview.c +++ b/dlls/comctl32/treeview.c @@ -3806,6 +3806,7 @@ TREEVIEW_EndEditLabelNow(TREEVIEW_INFO *infoPtr, BOOL bCancel) editedItem->pszText = ptr; editedItem->cchTextMax = iLength + 1; strcpyW(editedItem->pszText, newText); + TREEVIEW_ComputeTextWidth(infoPtr, editedItem, 0); } } if(newText != tmpText) Free(newText);

1 0

Mikołaj Zalewski : wrc: Change the format of the output of "wrc --verify-translation".
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: c74f6d9d7a3806f1b63e60113f5dc5eed8767c4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=c74f6d9d7a3806f1b63e60113… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Mon Mar 26 12:53:28 2007 +0200 wrc: Change the format of the output of "wrc --verify-translation". --- tools/wrc/translation.c | 497 ++++++++++++++++++++++------------------------ 1 files changed, 238 insertions(+), 259 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c74f6d9d7a3806f1b63e6…

1 0

Mikołaj Zalewski : wrc: Add HTML resources support to wrc --verify-translation.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: fbd25173a8c5edd1612a5277b59cbc43d0639399 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fbd25173a8c5edd1612a5277b… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Mon Mar 26 11:42:33 2007 +0200 wrc: Add HTML resources support to wrc --verify-translation. --- tools/wrc/translation.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/tools/wrc/translation.c b/tools/wrc/translation.c index be1cb7f..e332e2d 100644 --- a/tools/wrc/translation.c +++ b/tools/wrc/translation.c @@ -79,6 +79,9 @@ static int get_language_id(resource_t *resource) { case res_anicur: case res_aniico: return resource->res.ani->data->lvc.language->id; + case res_html: + return resource->res.html->data->lvc.language->id; + default: /* Not supposed to reach here */ fprintf(stderr, "Not supposed to reach here (get_language_id())\n"); @@ -614,6 +617,16 @@ static int compare_rcdata(rcdata_t *rcdata1, rcdata_t *rcdata2) { return different; } +static int compare_html(html_t *rcdata1, html_t *rcdata2) { + int different = 0; + if(!different && + ((rcdata1->memopt != rcdata2->memopt) || + (rcdata1->data->lvc.version != rcdata2->data->lvc.version) || + (rcdata1->data->lvc.characts != rcdata2->data->lvc.characts))) + different = 1; + return different; +} + static int compare_stringtable(stringtable_t *stringtable1, stringtable_t *stringtable2) { int different = 0; int i; @@ -917,6 +930,8 @@ static int compare(resource_t *resource1, resource_t *resource2) { return compare_stringtable(resource1->res.stt, resource2->res.stt); case res_usr: return compare_user(resource1->res.usr, resource2->res.usr); + case res_html: + return compare_html(resource1->res.html, resource2->res.html); case res_msg: return compare_messagetable(resource1->res.msg, resource2->res.msg); case res_ver: @@ -978,6 +993,7 @@ void verify_translations(resource_t *top) { case res_toolbar: case res_anicur: case res_aniico: + case res_html: add_resource(next); break; default: @@ -1027,6 +1043,8 @@ void verify_translations(resource_t *top) { res_names[res_anicur] = strdup("ani_cursor"); present_resources[res_aniico] = 1; res_names[res_aniico] = strdup("ani_icon"); + present_resources[res_html] = 1; + res_names[res_html] = strdup("html"); for(res_type = res_0; res_type <= res_usr; res_type++) { if(!present_resources[res_type]) {

1 0

Mikołaj Zalewski : user32: combobox: The text area height should be font_height+4.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: 4043b007fe761b8f0b77be9f0e81a5a1eb7add30 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4043b007fe761b8f0b77be9f0… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Mon Mar 26 11:25:21 2007 +0200 user32: combobox: The text area height should be font_height+4. The tests shows that CBGetTextAreaHeight was using a bad formula. --- dlls/user32/combo.c | 12 +--- dlls/user32/tests/Makefile.in | 1 + dlls/user32/tests/combo.c | 141 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 145 insertions(+), 9 deletions(-) diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c index 7e54ea8..4be67cc 100644 --- a/dlls/user32/combo.c +++ b/dlls/user32/combo.c @@ -205,8 +205,9 @@ static LRESULT COMBO_NCDestroy( LPHEADCOMBO lphc ) * The height of the text area is set in two ways. * It can be set explicitly through a combobox message or through a * WM_MEASUREITEM callback. - * If this is not the case, the height is set to 13 dialog units. + * If this is not the case, the height is set to font height + 4px * This height was determined through experimentation. + * CBCalcPlacement will add 2*COMBO_YBORDERSIZE pixels for the border */ static INT CBGetTextAreaHeight( HWND hwnd, @@ -237,14 +238,7 @@ static INT CBGetTextAreaHeight( ReleaseDC(hwnd, hDC); - iTextItemHeight = ((13 * baseUnitY) / 8); - - /* - * This "formula" calculates the height of the complete control. - * To calculate the height of the text area, we have to remove the - * borders. - */ - iTextItemHeight -= 2*COMBO_YBORDERSIZE(); + iTextItemHeight = baseUnitY + 4; } /* diff --git a/dlls/user32/tests/Makefile.in b/dlls/user32/tests/Makefile.in index a50a8ee..505d62d 100644 --- a/dlls/user32/tests/Makefile.in +++ b/dlls/user32/tests/Makefile.in @@ -8,6 +8,7 @@ IMPORTS = user32 gdi32 advapi32 kernel32 CTESTS = \ class.c \ clipboard.c \ + combo.c \ cursoricon.c \ dce.c \ dde.c \ diff --git a/dlls/user32/tests/combo.c b/dlls/user32/tests/combo.c new file mode 100644 index 0000000..bf777c7 --- /dev/null +++ b/dlls/user32/tests/combo.c @@ -0,0 +1,141 @@ +/* Unit test suite for combo boxes. + * + * Copyright 2007 Mikolaj Zalewski + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <assert.h> +#include <stdarg.h> +#include <stdio.h> + +#define WIN32_LEAN_AND_MEAN +#include <windows.h> + +#include "wine/test.h" + +HWND hMainWnd; + +#define expect_eq(expr, value, type, fmt); { type val = expr; ok(val == (value), #expr " expected " #fmt " got " #fmt "\n", (value), val); } +#define expect_rect(r, _left, _top, _right, _bottom) ok(r.left == _left && r.top == _top && \ + r.bottom == _bottom && r.right == _right, "Invalid rect (%d,%d) (%d,%d) vs (%d,%d) (%d,%d)\n", \ + r.left, r.top, r.right, r.bottom, _left, _top, _right, _bottom); + +static HWND build_combo(DWORD style) +{ + return CreateWindow("ComboBox", "Combo", WS_VISIBLE|WS_CHILD|style, 5, 5, 100, 100, hMainWnd, NULL, NULL, 0); +} + +static int font_height(HFONT hFont) +{ + TEXTMETRIC tm; + HFONT hFontOld; + HDC hDC; + + hDC = CreateCompatibleDC(NULL); + hFontOld = SelectObject(hDC, hFont); + GetTextMetrics(hDC, &tm); + SelectObject(hDC, hFontOld); + DeleteDC(hDC); + + return tm.tmHeight; +} + +static INT CALLBACK is_font_installed_proc(const LOGFONT *elf, const TEXTMETRIC *tm, DWORD type, LPARAM lParam) +{ + return 0; +} + +static int is_font_installed(const char *name) +{ + HDC hdc = GetDC(NULL); + BOOL ret = !EnumFontFamilies(hdc, name, is_font_installed_proc, 0); + ReleaseDC(NULL, hdc); + return ret; +} + +static void test_setfont(DWORD style) +{ + HWND hCombo = build_combo(style); + HFONT hFont1 = CreateFont(10, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett"); + HFONT hFont2 = CreateFont(8, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett"); + RECT r; + int i; + + trace("Style %x\n", style); + GetClientRect(hCombo, &r); + expect_rect(r, 0, 0, 100, 24); + SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r); + MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2); + todo_wine expect_rect(r, 5, 5, 105, 105); + + if (!is_font_installed("Marlett")) + { + skip("Marlett font not available\n"); + return; + } + + if (font_height(hFont1) == 10 && font_height(hFont2) == 8) + { + SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont1, FALSE); + GetClientRect(hCombo, &r); + expect_rect(r, 0, 0, 100, 18); + SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r); + MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2); + todo_wine expect_rect(r, 5, 5, 105, 99); + + SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont2, FALSE); + GetClientRect(hCombo, &r); + expect_rect(r, 0, 0, 100, 16); + SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r); + MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2); + todo_wine expect_rect(r, 5, 5, 105, 97); + + SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont1, FALSE); + GetClientRect(hCombo, &r); + expect_rect(r, 0, 0, 100, 18); + SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r); + MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2); + todo_wine expect_rect(r, 5, 5, 105, 99); + } + else + skip("Invalid Marlett font heights\n"); + + for (i = 1; i < 30; i++) + { + HFONT hFont = CreateFont(i, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett"); + int height = font_height(hFont); + + SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont, FALSE); + GetClientRect(hCombo, &r); + expect_eq(r.bottom - r.top, height + 8, int, "%d"); + SendMessage(hCombo, WM_SETFONT, 0, FALSE); + DeleteObject(hFont); + } + + DestroyWindow(hCombo); + DeleteObject(hFont1); + DeleteObject(hFont2); +} + +START_TEST(combo) +{ + hMainWnd = CreateWindow("static", "Test", WS_OVERLAPPEDWINDOW, 10, 10, 300, 300, NULL, NULL, NULL, 0); + ShowWindow(hMainWnd, SW_SHOW); + + test_setfont(CBS_DROPDOWN); + test_setfont(CBS_DROPDOWNLIST); + DestroyWindow(hMainWnd); +}

1 0

Mikołaj Zalewski : shell32: autocomplete: Don' t use sel uninitialized.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Module: wine Branch: master Commit: 3924e6b730850a5f42c5d907ea7c85565e013212 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3924e6b730850a5f42c5d907e… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Tue Mar 20 23:04:36 2007 +0100 shell32: autocomplete: Don't use sel uninitialized. --- dlls/shell32/autocomplete.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c index 2ffe0d6..ed32f44 100644 --- a/dlls/shell32/autocomplete.c +++ b/dlls/shell32/autocomplete.c @@ -624,7 +624,7 @@ static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, { IAutoCompleteImpl *This = (IAutoCompleteImpl *)GetWindowLongPtrW(hwnd, GWLP_USERDATA); WCHAR *msg; - int sel = -1, len; + int sel, len; switch (uMsg) { case WM_MOUSEMOVE: @@ -632,9 +632,11 @@ static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, SendMessageW(hwnd, LB_SETCURSEL, (WPARAM)sel, (LPARAM)0); break; case WM_LBUTTONDOWN: - len = SendMessageW(This->hwndListBox, LB_GETTEXTLEN, sel, (LPARAM)NULL); + sel = SendMessageW(hwnd, LB_GETCURSEL, 0, 0); + if (sel < 0) + break; + len = SendMessageW(This->hwndListBox, LB_GETTEXTLEN, sel, 0); msg = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len+1)*sizeof(WCHAR)); - sel = (INT)SendMessageW(hwnd, LB_GETCURSEL, 0, 0); SendMessageW(hwnd, LB_GETTEXT, sel, (LPARAM)msg); SendMessageW(This->hwndEdit, WM_SETTEXT, 0, (LPARAM)msg); SendMessageW(This->hwndEdit, EM_SETSEL, 0, lstrlenW(msg));

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2007