ChangeSet ID: 31196
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/13 20:17:07
Modified files:
cron : cleanup.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Add missing 'global $sEmailSubject;' declaration to functions using the global $sEmailSubject
value.
Patch: http://cvs.winehq.org/patch.py?id=31196
Old revision New revision Changes Path
1.37 1.38 +12 -0 appdb/cron/cleanup.php
Index: appdb/cron/cleanup.php
diff -u -p appdb/cron/cleanup.php:1.37 appdb/cron/cleanup.php:1.38
--- appdb/cron/cleanup.php:1.37 14 Jun 2007 1:17: 7 -0000
+++ appdb/cron/cleanup.php 14 Jun 2007 1:17: 7 -0000
@@ -130,6 +130,8 @@ function warnUserDeleted($sEmail)
function notifyAdminsOfCleanupStart()
{
+ global $sEmailSubject;
+
$sSubject = $sEmailSubject."Cleanup script starting\r\n";
$sMsg = "Appdb cleanup cron script started.\r\n";
$sEmail = User::get_notify_email_address_list(null, null); /* get list admins */
@@ -142,6 +144,8 @@ function notifyAdminsOfCleanupStart()
/* events of the appdb */
function notifyAdminsOfCleanupExecution($usersWarned, $usersUnwarnedWithData, $usersDeleted, $usersWithData)
{
+ global $sEmailSubject;
+
$warnedUsers = User::get_inactive_users_pending_deletion();
$sSubject = $sEmailSubject."Inactive users\r\n";
@@ -162,6 +166,8 @@ function notifyAdminsOfCleanupExecution(
/* we don't report anything if no orphans are found */
function orphanVersionCheck()
{
+ global $sEmailSubject;
+
$sQuery = "select versionId, versionName from appVersion where appId = 0";
$hResult = query_appdb($sQuery);
$found_orphans = false;
@@ -192,6 +198,8 @@ function orphanVersionCheck()
/* so we'll want to purge them here after reporting how many we have */
function orphanSessionMessagesCheck()
{
+ global $sEmailSubject;
+
$iSessionMessageDayLimit = 1; /* the number of days a session message must be stuck before being purges */
/* get a count of the messages older than $iSessionMessageDayLimit */
@@ -220,6 +228,8 @@ function orphanSessionMessagesCheck()
/* by one row each time a user logs */
function orphanSessionListCheck()
{
+ global $sEmailSubject;
+
/* get a count of the messages older than $iSessionListDayLimit */
$sQuery = "SELECT count(*) as cnt from session_list where TO_DAYS(NOW()) - TO_DAYS(stamp) > ?";
$hResult = query_parameters($sQuery, SESSION_DAYS_TO_EXPIRE + 2);
@@ -281,6 +291,8 @@ function getMissingScreenshotArray()
function removeScreenshotsWithMissingFiles()
{
+ global $sEmailSubject;
+
$aMissingScreenshotIds = getMissingScreenshotArray();
// build the email to admins about what we are doing
ChangeSet ID: 31195
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/13 19:52:57
Modified files:
include : application.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Fix admin response in submitter notifications. Some code was in the wrong place inside of a
switch statement
Patch: http://cvs.winehq.org/patch.py?id=31195
Old revision New revision Changes Path
1.114 1.115 +3 -2 appdb/include/application.php
Index: appdb/include/application.php
diff -u -p appdb/include/application.php:1.114 appdb/include/application.php:1.115
--- appdb/include/application.php:1.114 14 Jun 2007 0:52:57 -0000
+++ appdb/include/application.php 14 Jun 2007 0:52:57 -0000
@@ -372,7 +372,7 @@ class Application {
{
case "add":
$sSubject = "Submitted application accepted";
- $sMsg = "The application you submitted (".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname.".";
+ $sMsg = "The application you submitted (".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname.".\n";
$sMsg .= "Administrator's Response:\n";
break;
case "reject":
@@ -390,10 +390,11 @@ class Application {
$sMsg = "The application you submitted (".$this->sName.") has been deleted by ".$_SESSION['current']->sRealname.".";
$sMsg .= "Reason given:\n";
break;
+ }
$sMsg .= $aClean['sReplyText']."\n";
$sMsg .= "We appreciate your help in making the Application Database better for all users.";
- }
+
mail_appdb($oSubmitter->sEmail, $sSubject ,$sMsg);
}
}
ChangeSet ID: 31193
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/13 19:50:35
Modified files:
include : appData.php application.php
application_queue.php distribution.php
downloadurl.php maintainer.php
objectManager.php screenshot.php testData.php
testData_queue.php vendor.php version.php
version_queue.php
unit_test : test_om_objects.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
Patch: http://cvs.winehq.org/patch.py?id=31193
Old revision New revision Changes Path
1.26 1.27 +7 -7 appdb/include/appData.php
1.113 1.114 +7 -9 appdb/include/application.php
1.7 1.8 +7 -2 appdb/include/application_queue.php
1.34 1.35 +5 -20 appdb/include/distribution.php
1.18 1.19 +7 -3 appdb/include/downloadurl.php
1.43 1.44 +2 -8 appdb/include/maintainer.php
1.26 1.27 +54 -4 appdb/include/objectManager.php
1.70 1.71 +7 -3 appdb/include/screenshot.php
1.61 1.62 +7 -14 appdb/include/testData.php
1.10 1.11 +11 -12 appdb/include/testData_queue.php
1.31 1.32 +4 -15 appdb/include/vendor.php
1.130 1.131 +7 -8 appdb/include/version.php
1.13 1.14 +7 -2 appdb/include/version_queue.php
1.14 1.15 +2 -1 appdb/unit_test/test_om_objects.php