winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
7 participants
787 discussions
Start a n
N
ew thread
Mikolaj Zalewski : include: Fix the definition of VALID_INHERIT_FLAGS.
by Alexandre Julliard
26 Sep '07
26 Sep '07
Module: wine Branch: master Commit: f606055740fc560c73c04f3271bfec263292e4ea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f606055740fc560c73c04f327…
Author: Mikolaj Zalewski <mikolajz(a)google.com> Date: Tue Sep 25 11:38:23 2007 -0700 include: Fix the definition of VALID_INHERIT_FLAGS. --- include/winnt.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/winnt.h b/include/winnt.h index 63b1936..aecc2af 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -3917,7 +3917,7 @@ typedef struct _ACE_HEADER { #define NO_PROPAGATE_INHERIT_ACE 0x04 #define INHERIT_ONLY_ACE 0x08 #define INHERITED_ACE 0x10 -#define VALID_INHERIT_FLAGS 0x0F +#define VALID_INHERIT_FLAGS 0x1F /* AceFlags mask for what events we (should) audit */ #define SUCCESSFUL_ACCESS_ACE_FLAG 0x40
1
0
0
0
Mikolaj Zalewski : wine.inf: add four keys found on Windows XP to Active Setup\Installed Components.
by Alexandre Julliard
26 Sep '07
26 Sep '07
Module: wine Branch: master Commit: 74bc7c091f91d95c4087e3df0b7c601bd510cc0b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=74bc7c091f91d95c4087e3df0…
Author: Mikolaj Zalewski <mikolajz(a)google.com> Date: Tue Sep 25 14:22:07 2007 -0700 wine.inf: add four keys found on Windows XP to Active Setup\Installed Components. --- tools/wine.inf | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/tools/wine.inf b/tools/wine.inf index b051aa0..cfad301 100644 --- a/tools/wine.inf +++ b/tools/wine.inf @@ -335,6 +335,28 @@ HKLM,System\CurrentControlSet\Control\VMM32Files,,,"" HKCU,Software\Wine\MSHTML,"GeckoUrl",,"
http://source.winehq.org/winegecko.php
" HKLM,HARDWARE\DEVICEMAP\PARALLEL PORTS,,,"" HKLM,HARDWARE\DEVICEMAP\SERIALCOMM,,,"" +; Some apps requires at least four subkeys of Active Setup\Installed Components +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{44BBA855-CC51-11CF-AAFA-00AA00B6015F},,2,"DirectDrawEx" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{44BBA855-CC51-11CF-AAFA-00AA00B6015F},"ComponentID",2,"DirectDrawEx" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{44BBA855-CC51-11CF-AAFA-00AA00B6015F},"IsInstalled",2,1 +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{44BBA855-CC51-11CF-AAFA-00AA00B6015F},"Locale",2,"*" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{44BBA855-CC51-11CF-AAFA-00AA00B6015F},"Version",2,"4,71,1113,0" + +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{7131646D-CD3C-40F4-97B9-CD9E4E6262EF},,2,".NET Framework" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{7131646D-CD3C-40F4-97B9-CD9E4E6262EF},"ComponentID",2,".NETFramework" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{7131646D-CD3C-40F4-97B9-CD9E4E6262EF},"Locale",2,"" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{7131646D-CD3C-40F4-97B9-CD9E4E6262EF},"Version",2,"2,0,50727,0" + +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{CB2F7EDD-9D1F-43C1-90FC-4F52EAE172A1},,2,".NET Framework" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{CB2F7EDD-9D1F-43C1-90FC-4F52EAE172A1},"ComponentID",2,".NETFramework" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{CB2F7EDD-9D1F-43C1-90FC-4F52EAE172A1},"Locale",2,"" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{CB2F7EDD-9D1F-43C1-90FC-4F52EAE172A1},"Version",2,"1,0,4322,1" + +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},,2,"HTML Help" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"ComponentID",2,"HTMLHelp" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"IsInstalled",2,1 +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Locale",2,"*" +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Version",2,"4,74,9273,0" [Nls] HKLM,System\CurrentControlSet\Control\Nls\Codepage,"37",,""
1
0
0
0
Detlef Riekenberg : ntdll: Avoid segfault with snoop for exefiles with a broken export table.
by Alexandre Julliard
26 Sep '07
26 Sep '07
Module: wine Branch: master Commit: 3e83b750383e061fb1919bb79e57e20064a874f6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3e83b750383e061fb1919bb79…
Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Tue Sep 25 23:15:00 2007 +0200 ntdll: Avoid segfault with snoop for exefiles with a broken export table. --- dlls/ntdll/loader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 04172f9..6c1d7bc 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -1444,7 +1444,7 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, LPCWSTR name, HANDLE file, } SERVER_END_REQ; - if (TRACE_ON(snoop)) SNOOP_SetupDLL( module ); + if ((wm->ldr.Flags & LDR_IMAGE_IS_DLL) && TRACE_ON(snoop)) SNOOP_SetupDLL( module ); TRACE_(loaddll)( " Loaded module %s : native\n", debugstr_w(wm->ldr.FullDllName.Buffer) );
1
0
0
0
Stefan Leichter : comcat: Remove 'recursive registry key delete' function.
by Alexandre Julliard
26 Sep '07
26 Sep '07
Module: wine Branch: master Commit: 6be7eba918cacd60192fe612d9082ad18f6e88a4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6be7eba918cacd60192fe612d…
Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Tue Sep 25 17:21:51 2007 +0200 comcat: Remove 'recursive registry key delete' function. --- dlls/comcat/regsvr.c | 63 +++---------------------------------------------- 1 files changed, 4 insertions(+), 59 deletions(-) diff --git a/dlls/comcat/regsvr.c b/dlls/comcat/regsvr.c index 1a2bb68..21a7597 100644 --- a/dlls/comcat/regsvr.c +++ b/dlls/comcat/regsvr.c @@ -101,8 +101,6 @@ static LONG register_key_defvalueW(HKEY base, WCHAR const *name, WCHAR const *value); static LONG register_key_defvalueA(HKEY base, WCHAR const *name, char const *value); -static LONG recursive_delete_key(HKEY key); - /*********************************************************************** * register_interfaces @@ -189,22 +187,12 @@ static HRESULT unregister_interfaces(struct regsvr_interface const *list) for (; res == ERROR_SUCCESS && list->iid; ++list) { WCHAR buf[39]; - HKEY iid_key; StringFromGUID2(list->iid, buf, 39); - res = RegOpenKeyExW(interface_key, buf, 0, - KEY_READ | KEY_WRITE, &iid_key); - if (res == ERROR_FILE_NOT_FOUND) { - res = ERROR_SUCCESS; - continue; - } - if (res != ERROR_SUCCESS) goto error_close_interface_key; - res = recursive_delete_key(iid_key); - RegCloseKey(iid_key); - if (res != ERROR_SUCCESS) goto error_close_interface_key; + res = RegDeleteTreeW(interface_key, buf); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; } -error_close_interface_key: RegCloseKey(interface_key); error_return: return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; @@ -287,23 +275,12 @@ static HRESULT unregister_coclasses(struct regsvr_coclass const *list) for (; res == ERROR_SUCCESS && list->clsid; ++list) { WCHAR buf[39]; - HKEY clsid_key; StringFromGUID2(list->clsid, buf, 39); - res = RegOpenKeyExW(coclass_key, buf, 0, - KEY_READ | KEY_WRITE, &clsid_key); - if (res == ERROR_FILE_NOT_FOUND) { - res = ERROR_SUCCESS; - continue; - } - if (res != ERROR_SUCCESS) goto error_close_coclass_key; - res = recursive_delete_key(clsid_key); - RegCloseKey(clsid_key); - if (res != ERROR_SUCCESS) goto error_close_coclass_key; + res = RegDeleteTreeW(coclass_key, buf); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; } -error_close_coclass_key: - RegCloseKey(coclass_key); error_return: return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; } @@ -360,38 +337,6 @@ static LONG register_key_defvalueA( } /*********************************************************************** - * recursive_delete_key - */ -static LONG recursive_delete_key(HKEY key) -{ - LONG res; - WCHAR subkey_name[MAX_PATH]; - DWORD cName; - HKEY subkey; - - for (;;) { - cName = sizeof(subkey_name) / sizeof(WCHAR); - res = RegEnumKeyExW(key, 0, subkey_name, &cName, - NULL, NULL, NULL, NULL); - if (res != ERROR_SUCCESS && res != ERROR_MORE_DATA) { - res = ERROR_SUCCESS; /* presumably we're done enumerating */ - break; - } - res = RegOpenKeyExW(key, subkey_name, 0, - KEY_READ | KEY_WRITE, &subkey); - if (res == ERROR_FILE_NOT_FOUND) continue; - if (res != ERROR_SUCCESS) break; - - res = recursive_delete_key(subkey); - RegCloseKey(subkey); - if (res != ERROR_SUCCESS) break; - } - - if (res == ERROR_SUCCESS) res = RegDeleteKeyW(key, 0); - return res; -} - -/*********************************************************************** * coclass list */ static struct regsvr_coclass const coclass_list[] = {
1
0
0
0
Stefan Leichter : d3dxof: Remove 'recursive registry key delete' function.
by Alexandre Julliard
26 Sep '07
26 Sep '07
Module: wine Branch: master Commit: 4677e50a06426d80302b0149a5dae3be65d2fc84 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4677e50a06426d80302b0149a…
Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Tue Sep 25 17:03:24 2007 +0200 d3dxof: Remove 'recursive registry key delete' function. --- dlls/d3dxof/regsvr.c | 79 +++++-------------------------------------------- 1 files changed, 8 insertions(+), 71 deletions(-) diff --git a/dlls/d3dxof/regsvr.c b/dlls/d3dxof/regsvr.c index 7c90bd6..34c5827 100644 --- a/dlls/d3dxof/regsvr.c +++ b/dlls/d3dxof/regsvr.c @@ -118,9 +118,6 @@ static LONG register_key_defvalueA(HKEY base, WCHAR const *name, static LONG register_progid(WCHAR const *clsid, char const *progid, char const *curver_progid, char const *name, char const *extra); -static LONG recursive_delete_key(HKEY key); -static LONG recursive_delete_keyA(HKEY base, char const *name); -static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); /*********************************************************************** * register_interfaces @@ -209,7 +206,8 @@ static HRESULT unregister_interfaces(struct regsvr_interface const *list) WCHAR buf[39]; StringFromGUID2(list->iid, buf, 39); - res = recursive_delete_keyW(interface_key, buf); + res = RegDeleteTreeW(interface_key, buf); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; } RegCloseKey(interface_key); @@ -316,16 +314,19 @@ static HRESULT unregister_coclasses(struct regsvr_coclass const *list) WCHAR buf[39]; StringFromGUID2(list->clsid, buf, 39); - res = recursive_delete_keyW(coclass_key, buf); + res = RegDeleteTreeW(coclass_key, buf); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; if (res != ERROR_SUCCESS) goto error_close_coclass_key; if (list->progid) { - res = recursive_delete_keyA(HKEY_CLASSES_ROOT, list->progid); + res = RegDeleteTreeA(HKEY_CLASSES_ROOT, list->progid); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; if (res != ERROR_SUCCESS) goto error_close_coclass_key; } if (list->viprogid) { - res = recursive_delete_keyA(HKEY_CLASSES_ROOT, list->viprogid); + res = RegDeleteTreeA(HKEY_CLASSES_ROOT, list->viprogid); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; if (res != ERROR_SUCCESS) goto error_close_coclass_key; } } @@ -438,70 +439,6 @@ error_close_progid_key: } /*********************************************************************** - * recursive_delete_key - */ -static LONG recursive_delete_key(HKEY key) -{ - LONG res; - WCHAR subkey_name[MAX_PATH]; - DWORD cName; - HKEY subkey; - - for (;;) { - cName = sizeof(subkey_name) / sizeof(WCHAR); - res = RegEnumKeyExW(key, 0, subkey_name, &cName, - NULL, NULL, NULL, NULL); - if (res != ERROR_SUCCESS && res != ERROR_MORE_DATA) { - res = ERROR_SUCCESS; /* presumably we're done enumerating */ - break; - } - res = RegOpenKeyExW(key, subkey_name, 0, - KEY_READ | KEY_WRITE, &subkey); - if (res == ERROR_FILE_NOT_FOUND) continue; - if (res != ERROR_SUCCESS) break; - - res = recursive_delete_key(subkey); - RegCloseKey(subkey); - if (res != ERROR_SUCCESS) break; - } - - if (res == ERROR_SUCCESS) res = RegDeleteKeyW(key, 0); - return res; -} - -/*********************************************************************** - * recursive_delete_keyA - */ -static LONG recursive_delete_keyA(HKEY base, char const *name) -{ - LONG res; - HKEY key; - - res = RegOpenKeyExA(base, name, 0, KEY_READ | KEY_WRITE, &key); - if (res == ERROR_FILE_NOT_FOUND) return ERROR_SUCCESS; - if (res != ERROR_SUCCESS) return res; - res = recursive_delete_key(key); - RegCloseKey(key); - return res; -} - -/*********************************************************************** - * recursive_delete_keyW - */ -static LONG recursive_delete_keyW(HKEY base, WCHAR const *name) -{ - LONG res; - HKEY key; - - res = RegOpenKeyExW(base, name, 0, KEY_READ | KEY_WRITE, &key); - if (res == ERROR_FILE_NOT_FOUND) return ERROR_SUCCESS; - if (res != ERROR_SUCCESS) return res; - res = recursive_delete_key(key); - RegCloseKey(key); - return res; -} - -/*********************************************************************** * coclass list */ static struct regsvr_coclass const coclass_list[] = {
1
0
0
0
Dmitry Timoshkov : user32: Make message test pass cleanly under XP SP2.
by Alexandre Julliard
25 Sep '07
25 Sep '07
Module: wine Branch: master Commit: d4193a94e4cd53c488fc920dc99f59462254ff06 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d4193a94e4cd53c488fc920dc…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Tue Sep 25 19:26:57 2007 +0900 user32: Make message test pass cleanly under XP SP2. --- dlls/user32/tests/msg.c | 123 +++++++++++++++++++++++++++++++--------------- 1 files changed, 83 insertions(+), 40 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=d4193a94e4cd53c488fc9…
1
0
0
0
Misha Koshelev : wininet: When sending INTERNET_STATUS_HANDLE_CLOSING make sure the freed handle is not yet available .
by Alexandre Julliard
25 Sep '07
25 Sep '07
Module: wine Branch: master Commit: 705b01c05479cb931e0e2a3bc5984425ff602721 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=705b01c05479cb931e0e2a3bc…
Author: Misha Koshelev <mk144210(a)bcm.edu> Date: Fri Sep 21 21:27:48 2007 -0500 wininet: When sending INTERNET_STATUS_HANDLE_CLOSING make sure the freed handle is not yet available. --- dlls/wininet/internet.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 5e95a12..0edca74 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -208,13 +208,14 @@ BOOL WININET_FreeHandle( HINTERNET hinternet ) TRACE( "destroying handle %d for object %p\n", handle+1, info); WININET_Handles[handle] = NULL; ret = TRUE; - if( WININET_dwNextHandle > handle ) - WININET_dwNextHandle = handle; } } LeaveCriticalSection( &WININET_cs ); + /* As on native when the equivalent of WININET_Release is called, the handle + * is already invalid, but if a new handle is created at this time it does + * not yet get assigned the freed handle number */ if( info ) { /* Free all children as native does */ @@ -227,6 +228,13 @@ BOOL WININET_FreeHandle( HINTERNET hinternet ) WININET_Release( info ); } + EnterCriticalSection( &WININET_cs ); + + if( WININET_dwNextHandle > handle && !WININET_Handles[handle] ) + WININET_dwNextHandle = handle; + + LeaveCriticalSection( &WININET_cs ); + return ret; } @@ -1006,8 +1014,8 @@ BOOL WINAPI InternetCloseHandle(HINTERNET hInternet) return FALSE; } - WININET_FreeHandle( hInternet ); WININET_Release( lpwh ); + WININET_FreeHandle( hInternet ); return TRUE; }
1
0
0
0
Chris Robinson : wgl: Override glFinish and glFlush.
by Alexandre Julliard
25 Sep '07
25 Sep '07
Module: wine Branch: master Commit: 665a8add929d45c5a7d5de4023ea197f04acff9c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=665a8add929d45c5a7d5de402…
Author: Chris Robinson <chris.kcat(a)gmail.com> Date: Sat Sep 22 20:45:27 2007 -0700 wgl: Override glFinish and glFlush. --- dlls/opengl32/make_opengl | 2 ++ dlls/opengl32/opengl_norm.c | 20 -------------------- dlls/opengl32/wgl.c | 22 ++++++++++++++++++++++ dlls/winex11.drv/opengl.c | 22 +++++++++++++++++++++- 4 files changed, 45 insertions(+), 21 deletions(-) diff --git a/dlls/opengl32/make_opengl b/dlls/opengl32/make_opengl index 381b1a9..b14b5cf 100755 --- a/dlls/opengl32/make_opengl +++ b/dlls/opengl32/make_opengl @@ -220,6 +220,8 @@ sub GenerateThunk($$$$$) return "" if $func_ref->[0] eq "glDisable"; return "" if $func_ref->[0] eq "glScissor"; return "" if $func_ref->[0] eq "glViewport"; + return "" if $func_ref->[0] eq "glFinish"; + return "" if $func_ref->[0] eq "glFlush"; # If for opengl_norm.c, generate a nice heading otherwise Patrik won't be happy :-) # Patrik says: Well I would be even happier if a (OPENGL32.@) was added as well. Done. :-) diff --git a/dlls/opengl32/opengl_norm.c b/dlls/opengl32/opengl_norm.c index 6534301..69acc85 100644 --- a/dlls/opengl32/opengl_norm.c +++ b/dlls/opengl32/opengl_norm.c @@ -1060,26 +1060,6 @@ void WINAPI wine_glFeedbackBuffer( GLsizei size, GLenum type, GLfloat* buffer ) } /*********************************************************************** - * glFinish (OPENGL32.@) - */ -void WINAPI wine_glFinish( void ) { - TRACE("()\n"); - ENTER_GL(); - glFinish( ); - LEAVE_GL(); -} - -/*********************************************************************** - * glFlush (OPENGL32.@) - */ -void WINAPI wine_glFlush( void ) { - TRACE("()\n"); - ENTER_GL(); - glFlush( ); - LEAVE_GL(); -} - -/*********************************************************************** * glFogf (OPENGL32.@) */ void WINAPI wine_glFogf( GLenum pname, GLfloat param ) { diff --git a/dlls/opengl32/wgl.c b/dlls/opengl32/wgl.c index 029f361..deac8db 100644 --- a/dlls/opengl32/wgl.c +++ b/dlls/opengl32/wgl.c @@ -54,6 +54,8 @@ typedef struct wine_wgl_s { GLboolean WINAPI (*p_wglIsEnabled)(GLenum cap); void WINAPI (*p_wglScissor)(GLint x, GLint y, GLsizei width, GLsizei height); void WINAPI (*p_wglViewport)(GLint x, GLint y, GLsizei width, GLsizei height); + void WINAPI (*p_wglFinish)(void); + void WINAPI (*p_wglFlush)(void); } wine_wgl_t; /** global wgl object */ @@ -614,6 +616,24 @@ void WINAPI wine_glViewport( GLint x, GLint y, GLsizei width, GLsizei height ) } /*********************************************************************** + * glFinish (OPENGL32.@) + */ +void WINAPI wine_glFinish( void ) +{ + TRACE("()\n"); + wine_wgl.p_wglFinish(); +} + +/*********************************************************************** + * glFlush (OPENGL32.@) + */ +void WINAPI wine_glFlush( void ) +{ + TRACE("()\n"); + wine_wgl.p_wglFlush(); +} + +/*********************************************************************** * glGetString (OPENGL32.@) */ const GLubyte * WINAPI wine_glGetString( GLenum name ) @@ -705,6 +725,8 @@ static BOOL process_attach(void) wine_wgl.p_wglIsEnabled = (void *)wine_wgl.p_wglGetProcAddress("wglIsEnabled"); wine_wgl.p_wglScissor = (void *)wine_wgl.p_wglGetProcAddress("wglScissor"); wine_wgl.p_wglViewport = (void *)wine_wgl.p_wglGetProcAddress("wglViewport"); + wine_wgl.p_wglFinish = (void *)wine_wgl.p_wglGetProcAddress("wglFinish"); + wine_wgl.p_wglFlush = (void *)wine_wgl.p_wglGetProcAddress("wglFlush"); internal_gl_disabled_extensions[0] = 0; if (!RegOpenKeyA( HKEY_CURRENT_USER, "Software\\Wine\\OpenGL", &hkey)) { diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index 091aee5..b867abd 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -72,7 +72,7 @@ typedef struct wine_glextension { struct { const char *funcName; void *funcAddress; - } extEntryPoints[8]; + } extEntryPoints[9]; } WineGLExtension; struct WineGLInfo { @@ -277,6 +277,8 @@ MAKE_FUNCPTR(glReadPixels) MAKE_FUNCPTR(glScissor) MAKE_FUNCPTR(glTexImage2D) MAKE_FUNCPTR(glViewport) +MAKE_FUNCPTR(glFinish) +MAKE_FUNCPTR(glFlush) #undef MAKE_FUNCPTR static BOOL X11DRV_WineGL_InitOpenglInfo(void) @@ -428,6 +430,8 @@ LOAD_FUNCPTR(glReadPixels) LOAD_FUNCPTR(glScissor) LOAD_FUNCPTR(glTexImage2D) LOAD_FUNCPTR(glViewport) +LOAD_FUNCPTR(glFinish) +LOAD_FUNCPTR(glFlush) #undef LOAD_FUNCPTR /* It doesn't matter if these fail. They'll only be used if the driver reports @@ -2054,6 +2058,20 @@ static void WINAPI X11DRV_wglViewport(GLint x, GLint y, GLsizei width, GLsizei h } } +static void WINAPI X11DRV_wglFinish(void) +{ + wine_tsx11_lock(); + pglFinish(); + wine_tsx11_unlock(); +} + +static void WINAPI X11DRV_wglFlush(void) +{ + wine_tsx11_lock(); + pglFlush(); + wine_tsx11_unlock(); +} + /** * X11DRV_wglGetExtensionsStringARB * @@ -3093,6 +3111,8 @@ static const WineGLExtension WGL_internal_functions = { "wglIsEnabled", X11DRV_wglIsEnabled }, { "wglScissor", X11DRV_wglScissor }, { "wglViewport", X11DRV_wglViewport }, + { "wglFinish", X11DRV_wglFinish }, + { "wglFlush", X11DRV_wglFlush }, } };
1
0
0
0
L. Rahyen : user32: Implement initial stubs for all raw input functions.
by Alexandre Julliard
25 Sep '07
25 Sep '07
Module: wine Branch: master Commit: 43601c282b51bd844daa181c8f2f76b0aaef8181 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=43601c282b51bd844daa181c8…
Author: L. Rahyen <mail(a)science.su> Date: Mon Sep 24 22:22:19 2007 +0000 user32: Implement initial stubs for all raw input functions. --- dlls/user32/input.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/user32/user32.spec | 16 ++++---- include/winuser.h | 69 +++++++++++++++++++++++++++++++++-- 3 files changed, 165 insertions(+), 12 deletions(-) diff --git a/dlls/user32/input.c b/dlls/user32/input.c index 8048412..3e16dc3 100644 --- a/dlls/user32/input.c +++ b/dlls/user32/input.c @@ -340,6 +340,98 @@ BOOL WINAPI GetLastInputInfo(PLASTINPUTINFO plii) } +/****************************************************************** +* GetRawInputDeviceList (USER32.@) +*/ +UINT WINAPI GetRawInputDeviceList(PRAWINPUTDEVICELIST pRawInputDeviceList, PUINT puiNumDevices, UINT cbSize) +{ + FIXME("(pRawInputDeviceList=%p, puiNumDevices=%p, cbSize=%d) stub!\n", pRawInputDeviceList, puiNumDevices, cbSize); + + if(pRawInputDeviceList) + memset(pRawInputDeviceList, 0, sizeof *pRawInputDeviceList); + *puiNumDevices = 0; + return 0; +} + + +/****************************************************************** +* RegisterRawInputDevices (USER32.@) +*/ +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize) +{ + FIXME("(pRawInputDevices=%p, uiNumDevices=%d, cbSize=%d) stub!\n", pRawInputDevices, uiNumDevices, cbSize); + + return TRUE; +} + + +/****************************************************************** +* GetRawInputData (USER32.@) +*/ +INT WINAPI GetRawInputData(HRAWINPUT hRawInput, UINT uiCommand, LPVOID pData, PUINT pcbSize, UINT cbSizeHeader) +{ + FIXME("(hRawInput=%p, uiCommand=%d, pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", + hRawInput, uiCommand, pData, pcbSize, cbSizeHeader); + + return 0; +} + + +/****************************************************************** +* GetRawInputBuffer (USER32.@) +*/ +UINT WINAPI GetRawInputBuffer(PRAWINPUT pData, PUINT pcbSize, UINT cbSizeHeader) +{ + FIXME("(pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", pData, pcbSize, cbSizeHeader); + + return 0; +} + + +/****************************************************************** +* GetRawInputDeviceInfoA (USER32.@) +*/ +UINT WINAPI GetRawInputDeviceInfoA(HANDLE hDevice, UINT uiCommand, LPVOID pData, PUINT pcbSize) +{ + FIXME("(hDevice=%p, uiCommand=%d, pData=%p, pcbSize=%p) stub!\n", hDevice, uiCommand, pData, pcbSize); + + return 0; +} + + +/****************************************************************** +* GetRawInputDeviceInfoW (USER32.@) +*/ +UINT WINAPI GetRawInputDeviceInfoW(HANDLE hDevice, UINT uiCommand, LPVOID pData, PUINT pcbSize) +{ + FIXME("(hDevice=%p, uiCommand=%d, pData=%p, pcbSize=%p) stub!\n", hDevice, uiCommand, pData, pcbSize); + + return 0; +} + + +/****************************************************************** +* GetRegisteredRawInputDevices (USER32.@) +*/ +UINT WINAPI GetRegisteredRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, PUINT puiNumDevices, UINT cbSize) +{ + FIXME("(pRawInputDevices=%p, puiNumDevices=%p, cbSize=%d) stub!\n", pRawInputDevices, puiNumDevices, cbSize); + + return 0; +} + + +/****************************************************************** +* DefRawInputProc (USER32.@) +*/ +LRESULT WINAPI DefRawInputProc(PRAWINPUT *paRawInput, INT nInput, UINT cbSizeHeader) +{ + FIXME("(paRawInput=%p, nInput=%d, cbSizeHeader=%d) stub!\n", *paRawInput, nInput, cbSizeHeader); + + return 0; +} + + /********************************************************************** * AttachThreadInput (USER32.@) * diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index d626053..417b93e 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -143,7 +143,7 @@ @ stdcall DefFrameProcW(long long long long long) @ stdcall DefMDIChildProcA(long long long long) @ stdcall DefMDIChildProcW(long long long long) -# @ stub DefRawInputProc +@ stdcall DefRawInputProc(ptr long long) @ stdcall DefWindowProcA(long long long long) @ stdcall DefWindowProcW(long long long long) @ stdcall DeferWindowPos(long long long long long long long long) @@ -341,13 +341,13 @@ @ stdcall GetPropA(long str) @ stdcall GetPropW(long wstr) @ stdcall GetQueueStatus(long) -# @ stub GetRawInputBuffer -# @ stub GetRawInputData -# @ stub GetRawInputDeviceInfoA -# @ stub GetRawInputDeviceInfoW -# @ stub GetRawInputDeviceList +@ stdcall GetRawInputBuffer(ptr ptr long) +@ stdcall GetRawInputData(ptr long ptr ptr long) +@ stdcall GetRawInputDeviceInfoA(ptr long ptr ptr) +@ stdcall GetRawInputDeviceInfoW(ptr long ptr ptr) +@ stdcall GetRawInputDeviceList(ptr ptr long) # @ stub GetReasonTitleFromReasonCode -# @ stub GetRegisteredRawInputDevices +@ stdcall GetRegisteredRawInputDevices(ptr ptr long) @ stdcall GetScrollBarInfo(long long ptr) @ stdcall GetScrollInfo(long long ptr) @ stdcall GetScrollPos(long long) @@ -562,7 +562,7 @@ @ stdcall RegisterLogonProcess(long long) # @ stub RegisterMessagePumpHook @ stub RegisterNetworkCapabilities -# @ stub RegisterRawInputDevices +@ stdcall RegisterRawInputDevices(ptr long long) @ stub RegisterServicesProcess @ stdcall RegisterShellHookWindow (long) @ stdcall RegisterSystemThread(long long) diff --git a/include/winuser.h b/include/winuser.h index b667aa5..ef17994 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -443,6 +443,59 @@ typedef struct tagINPUT } DUMMYUNIONNAME; } INPUT, *PINPUT, *LPINPUT; +typedef HANDLE HRAWINPUT; + +typedef struct tagRAWINPUTDEVICELIST +{ + HANDLE hDevice; + DWORD dwType; +} RAWINPUTDEVICELIST, *PRAWINPUTDEVICELIST; + +typedef struct tagRAWHID { + DWORD dwSizeHid; + DWORD dwCount; + BYTE bRawData; +} RAWHID, *LPRAWHID; + +typedef struct tagRAWKEYBOARD { + USHORT MakeCode; + USHORT Flags; + USHORT Reserved; + USHORT VKey; + UINT Message; + ULONG ExtraInformation; +} RAWKEYBOARD, *PRAWKEYBOARD, *LPRAWKEYBOARD; + +typedef struct tagRAWMOUSE { + USHORT usFlags; + union { + ULONG ulButtons; + struct { + USHORT usButtonFlags; + USHORT usButtonData; + } DUMMYSTRUCTNAME; + } DUMMYUNIONNAME; + ULONG ulRawButtons; + LONG lLastX; + LONG lLastY; + ULONG ulExtraInformation; +} RAWMOUSE, *PRAWMOUSE, *LPRAWMOUSE; + +typedef struct tagRAWINPUTHEADER { + DWORD dwType; + DWORD dwSize; + HANDLE hDevice; + WPARAM wParam; +} RAWINPUTHEADER, *PRAWINPUTHEADER; + +typedef struct tagRAWINPUT { + RAWINPUTHEADER header; + union { + RAWMOUSE mouse; + RAWKEYBOARD keyboard; + RAWHID hid; + } data; +} RAWINPUT, *PRAWINPUT, *LPRAWINPUT; typedef struct tagRAWINPUTDEVICE { USHORT usUsagePage; @@ -4457,6 +4510,7 @@ LRESULT WINAPI DefFrameProcW(HWND,HWND,UINT,WPARAM,LPARAM); LRESULT WINAPI DefMDIChildProcA(HWND,UINT,WPARAM,LPARAM); LRESULT WINAPI DefMDIChildProcW(HWND,UINT,WPARAM,LPARAM); #define DefMDIChildProc WINELIB_NAME_AW(DefMDIChildProc) +LRESULT WINAPI DefRawInputProc(PRAWINPUT*,INT,UINT); LRESULT WINAPI DefWindowProcA(HWND,UINT,WPARAM,LPARAM); LRESULT WINAPI DefWindowProcW(HWND,UINT,WPARAM,LPARAM); #define DefWindowProc WINELIB_NAME_AW(DefWindowProc) @@ -4613,8 +4667,14 @@ BOOL WINAPI GetKeyboardLayoutNameA(LPSTR); BOOL WINAPI GetKeyboardLayoutNameW(LPWSTR); #define GetKeyboardLayoutName WINELIB_NAME_AW(GetKeyboardLayoutName) SHORT WINAPI GetKeyState(INT); -HWND WINAPI GetLastActivePopup(HWND); -BOOL WINAPI GetLastInputInfo(PLASTINPUTINFO); +HWND WINAPI GetLastActivePopup(HWND); +BOOL WINAPI GetLastInputInfo(PLASTINPUTINFO); +UINT WINAPI GetRawInputBuffer(PRAWINPUT,PUINT,UINT); +INT WINAPI GetRawInputData(HRAWINPUT,UINT,LPVOID,PUINT,UINT); +UINT WINAPI GetRawInputDeviceInfoA(HANDLE,UINT,LPVOID,PUINT); +UINT WINAPI GetRawInputDeviceInfoW(HANDLE,UINT,LPVOID,PUINT); +#define GetRawInputDeviceInfo WINELIB_NAME_AW(GetRawInputDeviceInfo) +UINT WINAPI GetRawInputDeviceList(PRAWINPUTDEVICELIST,PUINT,UINT); BOOL WINAPI GetLayeredWindowAttributes(HWND,COLORREF*,BYTE*,DWORD*); HMENU WINAPI GetMenu(HWND); INT WINAPI GetMenuItemCount(HMENU); @@ -4831,9 +4891,10 @@ ATOM WINAPI RegisterClassW(const WNDCLASSW *); ATOM WINAPI RegisterClassExA(const WNDCLASSEXA *); ATOM WINAPI RegisterClassExW(const WNDCLASSEXW *); #define RegisterClassEx WINELIB_NAME_AW(RegisterClassEx) -UINT WINAPI RegisterClipboardFormatA(LPCSTR); -UINT WINAPI RegisterClipboardFormatW(LPCWSTR); +UINT WINAPI RegisterClipboardFormatA(LPCSTR); +UINT WINAPI RegisterClipboardFormatW(LPCWSTR); #define RegisterClipboardFormat WINELIB_NAME_AW(RegisterClipboardFormat) +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE,UINT,UINT); UINT WINAPI RegisterWindowMessageA(LPCSTR); UINT WINAPI RegisterWindowMessageW(LPCWSTR); #define RegisterWindowMessage WINELIB_NAME_AW(RegisterWindowMessage)
1
0
0
0
Christian Gmeiner : advapi32: fix some compiler warnings when using -Wsign-compare.
by Alexandre Julliard
25 Sep '07
25 Sep '07
Module: wine Branch: master Commit: bb3a968d30b84995fbd347cbf825b61e2a865696 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bb3a968d30b84995fbd347cbf…
Author: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri Sep 21 20:17:23 2007 +0000 advapi32: fix some compiler warnings when using -Wsign-compare. --- dlls/advapi32/crypt.c | 2 +- dlls/advapi32/crypt_lmhash.c | 4 ++-- dlls/advapi32/security.c | 12 ++++++------ dlls/advapi32/service.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c index 63f89f6..c6ea940 100644 --- a/dlls/advapi32/crypt.c +++ b/dlls/advapi32/crypt.c @@ -146,7 +146,7 @@ static inline BOOL CRYPT_UnicodeToANSI(LPCWSTR wstr, LPSTR* str, int strsize) */ static inline BOOL CRYPT_ANSIToUnicode(LPCSTR str, LPWSTR* wstr, int wstrsize) { - int wcount; + unsigned int wcount; if (!str) { diff --git a/dlls/advapi32/crypt_lmhash.c b/dlls/advapi32/crypt_lmhash.c index 2f57842..345c89d 100644 --- a/dlls/advapi32/crypt_lmhash.c +++ b/dlls/advapi32/crypt_lmhash.c @@ -194,7 +194,7 @@ NTSTATUS WINAPI SystemFunction004(const struct ustring *in, unsigned int ui[2]; } data; unsigned char deskey[7]; - int crypt_len, ofs; + unsigned int crypt_len, ofs; if (key->Length<=0) return STATUS_INVALID_PARAMETER_2; @@ -253,7 +253,7 @@ NTSTATUS WINAPI SystemFunction005(const struct ustring *in, unsigned int ui[2]; } data; unsigned char deskey[7]; - int ofs, crypt_len; + unsigned int ofs, crypt_len; if (key->Length<=0) return STATUS_INVALID_PARAMETER_2; diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index 89e3d90..bfe7edf 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -772,7 +772,7 @@ CreateWellKnownSid( WELL_KNOWN_SID_TYPE WellKnownSidType, PSID pSid, DWORD* cbSid) { - int i; + unsigned int i; TRACE("(%d, %s, %p, %p)\n", WellKnownSidType, debugstr_sid(DomainSid), pSid, cbSid); if (DomainSid != NULL) { @@ -811,7 +811,7 @@ CreateWellKnownSid( WELL_KNOWN_SID_TYPE WellKnownSidType, BOOL WINAPI IsWellKnownSid( PSID pSid, WELL_KNOWN_SID_TYPE WellKnownSidType ) { - int i; + unsigned int i; TRACE("(%s, %d)\n", debugstr_sid(pSid), WellKnownSidType); for (i = 0; i < sizeof(WellKnownSids)/sizeof(WellKnownSids[0]); i++) @@ -1627,7 +1627,7 @@ LookupPrivilegeNameA( LPCSTR lpSystemName, PLUID lpLuid, LPSTR lpName, if (ret) { /* Windows crashes if cchName is NULL, so will I */ - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, *cchName, NULL, NULL); if (len == 0) @@ -1870,7 +1870,7 @@ LookupAccountSidW( IN OUT LPDWORD domainSize, OUT PSID_NAME_USE name_use ) { - int i, j; + unsigned int i, j; const WCHAR * ac = NULL; const WCHAR * dm = NULL; SID_NAME_USE use = 0; @@ -3821,7 +3821,7 @@ static DWORD ComputeStringSidSize(LPCWSTR StringSid) } else /* String constant format - Only available in winxp and above */ { - int i; + unsigned int i; for (i = 0; i < sizeof(WellKnownSids)/sizeof(WellKnownSids[0]); i++) if (!strncmpW(WellKnownSids[i].wstr, StringSid, 2)) @@ -3915,7 +3915,7 @@ static BOOL ParseStringSidToSid(LPCWSTR StringSid, PSID pSid, LPDWORD cBytes) } else /* String constant format - Only available in winxp and above */ { - int i; + unsigned int i; pisid->Revision = SDDL_REVISION; for (i = 0; i < sizeof(WellKnownSids)/sizeof(WellKnownSids[0]); i++) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index ce031ab..82bd7ed 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -2319,7 +2319,7 @@ BOOL WINAPI GetServiceDisplayNameW( SC_HANDLE hSCManager, LPCWSTR lpServiceName, if (!RegOpenKeyW(hscm->hkey, lpServiceName, &hkey)) { - INT len = lstrlenW(lpServiceName); + UINT len = lstrlenW(lpServiceName); BOOL r = FALSE; if ((*lpcchBuffer <= len) || (!lpDisplayName && *lpcchBuffer))
1
0
0
0
← Newer
1
...
9
10
11
12
13
14
15
...
79
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
Results per page:
10
25
50
100
200