winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2007
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
7 participants
787 discussions
Start a n
N
ew thread
Francois Gouget : regstr. h only defines constants and structures and thus does not need an extern "C " statement.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: 2b891021275a8ce3f3ce92303c4efe8d287a9e7c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2b891021275a8ce3f3ce92303…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Sep 20 21:35:31 2007 +0200 regstr.h only defines constants and structures and thus does not need an extern "C" statement. --- include/regstr.h | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/include/regstr.h b/include/regstr.h index ef6cf99..99df694 100644 --- a/include/regstr.h +++ b/include/regstr.h @@ -21,9 +21,6 @@ #ifndef _INC_REGSTR #define _INC_REGSTR -#ifdef __cplusplus -extern "C" { -#endif /* defined(__cplusplus) */ #define REGSTR_PATH_UNINSTALL TEXT("Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall") @@ -32,8 +29,5 @@ extern "C" { /* UninstallString <= 63 chars in Windows (otherwise problems) */ #define REGSTR_VAL_UNINSTALLER_COMMANDLINE TEXT("UninstallString") -#ifdef __cplusplus -} /* extern "C" */ -#endif /* defined(__cplusplus) */ #endif /* _INC_REGSTR_H */
1
0
0
0
Peter Oberndorfer : user32/tests: Fix dialog proc prototypes.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: 1fce55410efafd758a98798ae8d8e55515fd12c3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1fce55410efafd758a98798ae…
Author: Peter Oberndorfer <kumbayo84(a)arcor.de> Date: Thu Sep 20 19:31:56 2007 +0200 user32/tests: Fix dialog proc prototypes. --- dlls/user32/tests/dialog.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index fe8a0fd..afde292 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -676,7 +676,7 @@ static void IsDialogMessageWTest (void) } -static LRESULT CALLBACK delayFocusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, +static INT_PTR CALLBACK delayFocusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, LPARAM lParam) { switch (uiMsg) @@ -716,7 +716,7 @@ static LRESULT CALLBACK delayFocusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wPar return FALSE; } -static LRESULT CALLBACK focusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, +static INT_PTR CALLBACK focusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, LPARAM lParam) { switch (uiMsg) @@ -781,7 +781,7 @@ static void InitialFocusTest (void) g_styleInitialFocusT1 = -1; g_styleInitialFocusT2 = -1; - DialogBoxA(g_hinst, "RADIO_TEST_DIALOG", NULL, (DLGPROC)delayFocusDlgWinProc); + DialogBoxA(g_hinst, "RADIO_TEST_DIALOG", NULL, delayFocusDlgWinProc); ok (((g_styleInitialFocusT1 & WS_TABSTOP) == 0), "Error in wrc - Detected WS_TABSTOP as default style for GROUPBOX\n"); @@ -812,7 +812,7 @@ static void InitialFocusTest (void) g_styleInitialFocusT1 = -1; g_styleInitialFocusT2 = -1; - DialogBoxA(g_hinst, "RADIO_TEST_DIALOG", NULL, (DLGPROC)delayFocusDlgWinProc); + DialogBoxA(g_hinst, "RADIO_TEST_DIALOG", NULL, delayFocusDlgWinProc); ok ((g_hwndInitialFocusT1 == g_hwndButton2), "Error in initial focus when WM_INITDIALOG returned TRUE: " @@ -839,7 +839,7 @@ static void InitialFocusTest (void) pTemplate = (LPDLGTEMPLATEA)LockResource(hTemplate); g_hwndInitialFocusT1 = 0; - hDlg = CreateDialogIndirectParamW(g_hinst, pTemplate, NULL, (DLGPROC)focusDlgWinProc,0); + hDlg = CreateDialogIndirectParamW(g_hinst, pTemplate, NULL, focusDlgWinProc, 0); ok (hDlg != 0, "Failed to create test dialog.\n"); ok ((g_hwndInitialFocusT1 == 0),
1
0
0
0
Peter Oberndorfer : include: Add new processor feature constants.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: 70238568c6e48062d17c9906e9a173c7ea8f767a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=70238568c6e48062d17c9906e…
Author: Peter Oberndorfer <kumbayo84(a)arcor.de> Date: Thu Sep 20 19:16:37 2007 +0200 include: Add new processor feature constants. --- include/winnt.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/winnt.h b/include/winnt.h index 71dbf6d..63b1936 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -692,7 +692,12 @@ typedef enum _HEAP_INFORMATION_CLASS { #define PF_RDTSC_INSTRUCTION_AVAILABLE 8 #define PF_PAE_ENABLED 9 #define PF_XMMI64_INSTRUCTIONS_AVAILABLE 10 +#define PF_SSE_DAZ_MODE_AVAILABLE 11 #define PF_NX_ENABLED 12 +#define PF_SSE3_INSTRUCTIONS_AVAILABLE 13 +#define PF_COMPARE_EXCHANGE128 14 +#define PF_COMPARE64_EXCHANGE128 15 +#define PF_CHANNELS_ENABLED 16 /* Execution state flags */
1
0
0
0
Alexandre Julliard : winex11.drv: Don' t call GDI functions while holding the xrender lock.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: d08fbfc3b0151368f01ccc7feacd605622500425 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d08fbfc3b0151368f01ccc7fe…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 21 10:47:45 2007 +0200 winex11.drv: Don't call GDI functions while holding the xrender lock. --- dlls/winex11.drv/xrender.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index b659e21..cbf83bc 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1130,7 +1130,6 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag { RGNDATA *data; XGCValues xgcval; - int render_op = PictOpOver; gsCacheEntry *entry; gsCacheEntryFormat *formatEntry; BOOL retv = FALSE; @@ -1215,8 +1214,6 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag DeleteObject( clip_region ); } - EnterCriticalSection(&xrender_cs); - if(X11DRV_XRender_Installed) { if(!physDev->xrender->pict) { XRenderPictureAttributes pa; @@ -1245,15 +1242,10 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag wine_tsx11_unlock(); HeapFree( GetProcessHeap(), 0, data ); } - - tile_pict = get_tile_pict(depth_type, physDev->textPixel); - - /* FIXME the mapping of Text/BkColor onto 1 or 0 needs investigation. - */ - if((depth_type == mono_drawable) && (textPixel == 0)) - render_op = PictOpOutReverse; /* This gives us 'black' text */ } + EnterCriticalSection(&xrender_cs); + entry = glyphsetCache + physDev->xrender->cache_index; if( disable_antialias == FALSE ) aa_type = entry->aa_default; @@ -1285,6 +1277,7 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag XGlyphElt16 *elts = HeapAlloc(GetProcessHeap(), 0, sizeof(XGlyphElt16) * count); INT offset = 0; POINT desired, current; + int render_op = PictOpOver; /* There's a bug in XRenderCompositeText that ignores the xDst and yDst parameters. So we pass zeros to the function and move to our starting position using the first @@ -1294,6 +1287,13 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag desired.y = physDev->dc_rect.top + y; current.x = current.y = 0; + tile_pict = get_tile_pict(depth_type, physDev->textPixel); + + /* FIXME the mapping of Text/BkColor onto 1 or 0 needs investigation. + */ + if((depth_type == mono_drawable) && (textPixel == 0)) + render_op = PictOpOutReverse; /* This gives us 'black' text */ + for(idx = 0; idx < count; idx++) { elts[idx].glyphset = formatEntry->glyphset;
1
0
0
0
Alexandre Julliard : loader: Set the address space limit before starting the preloader.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: 1b8d9e03a9efe9744456e64d6381a2762a22103c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1b8d9e03a9efe9744456e64d6…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 21 10:43:45 2007 +0200 loader: Set the address space limit before starting the preloader. --- loader/glibc.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/loader/glibc.c b/loader/glibc.c index f4d2f9c..28a8d19 100644 --- a/loader/glibc.c +++ b/loader/glibc.c @@ -27,6 +27,9 @@ #ifdef HAVE_SYS_MMAN_H # include <sys/mman.h> #endif +#ifdef HAVE_SYS_RESOURCE_H +# include <sys/resource.h> +#endif #ifdef HAVE_UNISTD_H # include <unistd.h> #endif @@ -97,6 +100,18 @@ static void check_vmsplit( void *stack ) } } +static void set_max_limit( int limit ) +{ + struct rlimit rlimit; + + if (!getrlimit( limit, &rlimit )) + { + rlimit.rlim_cur = rlimit.rlim_max; + setrlimit( limit, &rlimit ); + } +} + + /********************************************************************** * main */ @@ -108,6 +123,9 @@ int main( int argc, char *argv[] ) wine_init_argv0_path( new_argv0 ); + /* set the address space limit before starting the preloader */ + set_max_limit( RLIMIT_AS ); + if (loader) { /* update WINELOADER with the new name */
1
0
0
0
Alexandre Julliard : server: Clip the visible region of a window to the desktop window.
by Alexandre Julliard
21 Sep '07
21 Sep '07
Module: wine Branch: master Commit: 5874b854ee83455211c07af5f1c651c10335ca49 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5874b854ee83455211c07af5f…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 20 19:38:50 2007 +0200 server: Clip the visible region of a window to the desktop window. --- server/window.c | 23 +++++++++++------------ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/server/window.c b/server/window.c index 14d6468..7c246dc 100644 --- a/server/window.c +++ b/server/window.c @@ -840,7 +840,7 @@ static inline struct window *get_top_clipping_window( struct window *win ) /* compute the visible region of a window, in window coordinates */ -static struct region *get_visible_region( struct window *win, struct window *top, unsigned int flags ) +static struct region *get_visible_region( struct window *win, unsigned int flags ) { struct region *tmp = NULL, *region; int offset_x, offset_y; @@ -853,7 +853,7 @@ static struct region *get_visible_region( struct window *win, struct window *top /* create a region relative to the window itself */ - if ((flags & DCX_PARENTCLIP) && win != top && win->parent) + if ((flags & DCX_PARENTCLIP) && win->parent && !is_desktop_window(win->parent)) { set_region_client_rect( region, win->parent ); offset_region( region, -win->parent->client_rect.left, -win->parent->client_rect.top ); @@ -891,11 +891,12 @@ static struct region *get_visible_region( struct window *win, struct window *top offset_y = win->window_rect.top; } - if (top && top != win && (tmp = create_empty_region()) != NULL) + if ((tmp = create_empty_region()) != NULL) { - while (win != top && win->parent) + while (win->parent) { - if (win->style & WS_CLIPSIBLINGS) + /* we don't clip out top-level siblings as that's up to the native windowing system */ + if ((win->style & WS_CLIPSIBLINGS) && !is_desktop_window( win->parent )) { if (!clip_children( win->parent, win, region, 0, 0 )) goto error; if (is_region_empty( region )) break; @@ -1332,12 +1333,11 @@ static void set_window_pos( struct window *win, struct window *previous, const rectangle_t old_window_rect = win->window_rect; const rectangle_t old_visible_rect = win->visible_rect; const rectangle_t old_client_rect = win->client_rect; - struct window *top = get_top_clipping_window( win ); int visible = (win->style & WS_VISIBLE) || (swp_flags & SWP_SHOWWINDOW); if (win->parent && !is_visible( win->parent )) visible = 0; - if (visible && !(old_vis_rgn = get_visible_region( win, top, DCX_WINDOW ))) return; + if (visible && !(old_vis_rgn = get_visible_region( win, DCX_WINDOW ))) return; /* set the new window info before invalidating anything */ @@ -1356,7 +1356,7 @@ static void set_window_pos( struct window *win, struct window *previous, /* if the window is not visible, everything is easy */ if (!visible) return; - if (!(new_vis_rgn = get_visible_region( win, top, DCX_WINDOW ))) + if (!(new_vis_rgn = get_visible_region( win, DCX_WINDOW ))) { free_region( old_vis_rgn ); clear_error(); /* ignore error since the window info has been modified already */ @@ -1441,17 +1441,16 @@ done: static void set_window_region( struct window *win, struct region *region, int redraw ) { struct region *old_vis_rgn = NULL, *new_vis_rgn; - struct window *top = get_top_clipping_window( win ); /* no need to redraw if window is not visible */ if (redraw && !is_visible( win )) redraw = 0; - if (redraw) old_vis_rgn = get_visible_region( win, top, DCX_WINDOW ); + if (redraw) old_vis_rgn = get_visible_region( win, DCX_WINDOW ); if (win->win_region) free_region( win->win_region ); win->win_region = region; - if (old_vis_rgn && (new_vis_rgn = get_visible_region( win, top, DCX_WINDOW ))) + if (old_vis_rgn && (new_vis_rgn = get_visible_region( win, DCX_WINDOW ))) { /* expose anything revealed by the change */ if (xor_region( new_vis_rgn, old_vis_rgn, new_vis_rgn )) @@ -1867,7 +1866,7 @@ DECL_HANDLER(get_visible_region) if (!win) return; top = get_top_clipping_window( win ); - if ((region = get_visible_region( win, top, req->flags ))) + if ((region = get_visible_region( win, req->flags ))) { rectangle_t *data; map_win_region_to_screen( win, region );
1
0
0
0
Alexander Nicolaysen Sørnes : version: Improve the submit test button for not-logged-in users
by Chris Morgan
21 Sep '07
21 Sep '07
Module: appdb Branch: master Commit: 4b453e1e5a932fcdf2c2a069129787f9eaeb703d URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=4b453e1e5a932fcdf2c2a069…
Author: Alexander Nicolaysen Sørnes <alexander(a)kurt.alexstyrt> Date: Thu Sep 20 20:03:35 2007 +0200 version: Improve the submit test button for not-logged-in users --- include/version.php | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/version.php b/include/version.php index 7b9c436..163a9a0 100644 --- a/include/version.php +++ b/include/version.php @@ -1009,9 +1009,9 @@ class version { echo '</form>'."\n"; } else { - echo '<form method="post" name="sMessage" action="account.php">'."\n"; + echo '<form method="post" name="sMessage" action="'.login_url().'">'."\n"; echo "\t".'<input type="hidden" name="sCmd" value="login">'."\n"; - echo "\t".'<input type=submit value="Log in add Test Data" class="button">'."\n"; + echo "\t".'<input type=submit value="Log in to add test data" class="button">'."\n"; echo '</form>'."\n"; }
1
0
0
0
Alexander Nicolaysen Sørnes : Use objectManager to submit super maintainer requests
by Chris Morgan
21 Sep '07
21 Sep '07
Module: appdb Branch: master Commit: e5d1bc1bf07b3cb5a526440fa2b84d4fee326713 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=e5d1bc1bf07b3cb5a526440f…
Author: Alexander Nicolaysen Sørnes <alexander(a)kurt.alexstyrt> Date: Thu Sep 20 21:25:07 2007 +0200 Use objectManager to submit super maintainer requests --- include/application.php | 2 +- include/maintainer.php | 18 ++++- include/objectManager.php | 9 ++- maintainersubmit.php | 173 --------------------------------------------- 4 files changed, 24 insertions(+), 178 deletions(-) Diff:
http://source.winehq.org/git/appdb.git/?a=commitdiff;h=e5d1bc1bf07b3cb5a526…
1
0
0
0
Alexander Nicolaysen Sørnes : Use objectManager to submit maintainer requests
by Chris Morgan
21 Sep '07
21 Sep '07
Module: appdb Branch: master Commit: 3ab41b6fca5277f0b428f529effdf63ff0a7e688 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=3ab41b6fca5277f0b428f529…
Author: Alexander Nicolaysen Sørnes <alexander(a)kurt.alexstyrt> Date: Thu Sep 20 21:03:09 2007 +0200 Use objectManager to submit maintainer requests --- include/maintainer.php | 235 +++++++++++++++++++++++++++++---------------- include/objectManager.php | 3 - include/version.php | 2 +- 3 files changed, 153 insertions(+), 87 deletions(-) Diff:
http://source.winehq.org/git/appdb.git/?a=commitdiff;h=3ab41b6fca5277f0b428…
1
0
0
0
Alexander Nicolaysen Sørnes : Fix objectGetCustomVars
by Chris Morgan
21 Sep '07
21 Sep '07
Module: appdb Branch: master Commit: fdfe3eb2d3c24a319a7a809807c8410b72294a91 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=fdfe3eb2d3c24a319a7a8098…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Sep 20 08:33:00 2007 +0200 Fix objectGetCustomVars --- include/objectManager.php | 11 ++++++----- include/version.php | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/objectManager.php b/include/objectManager.php index c52d36a..b75c879 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -736,14 +736,15 @@ class ObjectManager return null; /* No vars */ $aVars = array(); + $aVarNames = $oObject->objectGetCustomVars($sAction); - foreach($oObject->objectGetCustomVars($aClean, $sAction) as $sVar) + if(!$aVarNames) /* No vars */ + return null; + + foreach($aVarNames as $sVar) $aVars[$sVar] = $aClean[$sVar]; - if(!sizeof($aVars)) - return null; /* No vars */ - else - return $aVars; + return $aVars; } /* View an entry */ diff --git a/include/version.php b/include/version.php index 6d74736..7ba53d4 100644 --- a/include/version.php +++ b/include/version.php @@ -731,7 +731,7 @@ class version { } } - function objectGetCustomVars($aClean, $sAction) + function objectGetCustomVars($sAction) { switch($sAction) {
1
0
0
0
← Newer
1
...
23
24
25
26
27
28
29
...
79
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
Results per page:
10
25
50
100
200