winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2008
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1225 discussions
Start a n
N
ew thread
Gerald Pfeifer : wpp: Add missing #include <ctype.h>.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: 3ba99863253af1e326b796a86d02fce4ee1001ce URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3ba99863253af1e326b796a86…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 27 09:14:20 2008 +0100 wpp: Add missing #include <ctype.h>. --- libs/wpp/preproc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libs/wpp/preproc.c b/libs/wpp/preproc.c index c1fa3fc..63455ce 100644 --- a/libs/wpp/preproc.c +++ b/libs/wpp/preproc.c @@ -20,6 +20,7 @@ #include "wine/port.h" #include <assert.h> +#include <ctype.h> #include <fcntl.h> #include <stdio.h> #include <stdlib.h>
1
0
0
0
Gerald Pfeifer : comctl32: Simplify NATIVEFONT_Create.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: 6eb33b932e4cd832ac34be42b777ec78984f210a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6eb33b932e4cd832ac34be42b…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 27 08:57:44 2008 +0100 comctl32: Simplify NATIVEFONT_Create. --- dlls/comctl32/nativefont.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/nativefont.c b/dlls/comctl32/nativefont.c index 26347a3..2e11a9e 100644 --- a/dlls/comctl32/nativefont.c +++ b/dlls/comctl32/nativefont.c @@ -47,7 +47,7 @@ typedef struct #define NATIVEFONT_GetInfoPtr(hwnd) ((NATIVEFONT_INFO *)GetWindowLongPtrW (hwnd, 0)) static LRESULT -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam) +NATIVEFONT_Create (HWND hwnd) { NATIVEFONT_INFO *infoPtr; @@ -85,7 +85,7 @@ NATIVEFONT_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) switch (uMsg) { case WM_CREATE: - return NATIVEFONT_Create (hwnd, wParam, lParam); + return NATIVEFONT_Create (hwnd); case WM_DESTROY: return NATIVEFONT_Destroy (infoPtr);
1
0
0
0
Gerald Pfeifer : comctl32: Simplify COMBOEX_Command.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: 568a4bdd2a033a653a3781f371578b5e567b506f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=568a4bdd2a033a653a3781f37…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 27 08:55:50 2008 +0100 comctl32: Simplify COMBOEX_Command. --- dlls/comctl32/comboex.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/comboex.c b/dlls/comctl32/comboex.c index f576eee..0f55f4e 100644 --- a/dlls/comctl32/comboex.c +++ b/dlls/comctl32/comboex.c @@ -1118,7 +1118,7 @@ static LRESULT COMBOEX_Create (HWND hwnd, CREATESTRUCTA const *cs) } -static LRESULT COMBOEX_Command (COMBOEX_INFO *infoPtr, WPARAM wParam, LPARAM lParam) +static LRESULT COMBOEX_Command (COMBOEX_INFO *infoPtr, WPARAM wParam) { LRESULT lret; INT command = HIWORD(wParam); @@ -2273,7 +2273,7 @@ COMBOEX_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) /* Window messages passed to parent */ case WM_COMMAND: - return COMBOEX_Command (infoPtr, wParam, lParam); + return COMBOEX_Command (infoPtr, wParam); case WM_NOTIFY: if (infoPtr->NtfUnicode)
1
0
0
0
Gerald Pfeifer : comctl32: Simplify DATETIME_Char.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: d7876a2cd48a4370d57160c2168ed40bd9ffda8f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d7876a2cd48a4370d57160c21…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 27 08:51:39 2008 +0100 comctl32: Simplify DATETIME_Char. --- dlls/comctl32/datetime.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c index 34c750a..ae538a5 100644 --- a/dlls/comctl32/datetime.c +++ b/dlls/comctl32/datetime.c @@ -949,7 +949,7 @@ DATETIME_KeyDown (DATETIME_INFO *infoPtr, DWORD vkCode) static LRESULT -DATETIME_Char (DATETIME_INFO *infoPtr, WPARAM vkCode, LPARAM keyData) +DATETIME_Char (DATETIME_INFO *infoPtr, WPARAM vkCode) { int fieldNum = infoPtr->select & DTHT_DATEFIELD; @@ -1353,7 +1353,7 @@ DATETIME_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) return DATETIME_KeyDown (infoPtr, wParam); case WM_CHAR: - return DATETIME_Char (infoPtr, wParam, lParam); + return DATETIME_Char (infoPtr, wParam); case WM_KILLFOCUS: return DATETIME_KillFocus (infoPtr, (HWND)wParam);
1
0
0
0
Gerald Pfeifer : comctl32: Shed off some unused parameters.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: d7d6ceb4da5cfdebe006d8c9ef41180290ca8192 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d7d6ceb4da5cfdebe006d8c9e…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Dec 27 08:42:50 2008 +0100 comctl32: Shed off some unused parameters. --- dlls/comctl32/hotkey.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/comctl32/hotkey.c b/dlls/comctl32/hotkey.c index 33f3920..165d95d 100644 --- a/dlls/comctl32/hotkey.c +++ b/dlls/comctl32/hotkey.c @@ -342,7 +342,7 @@ HOTKEY_KeyDown (HOTKEY_INFO *infoPtr, DWORD key, DWORD flags) static LRESULT -HOTKEY_KeyUp (HOTKEY_INFO *infoPtr, DWORD key, DWORD flags) +HOTKEY_KeyUp (HOTKEY_INFO *infoPtr, DWORD key) { BYTE bOldMod; @@ -383,7 +383,7 @@ HOTKEY_KeyUp (HOTKEY_INFO *infoPtr, DWORD key, DWORD flags) static LRESULT -HOTKEY_KillFocus (HOTKEY_INFO *infoPtr, HWND receiveFocus) +HOTKEY_KillFocus (HOTKEY_INFO *infoPtr) { infoPtr->bFocus = FALSE; DestroyCaret (); @@ -424,7 +424,7 @@ HOTKEY_NCCreate (HWND hwnd, const CREATESTRUCTW *lpcs) } static LRESULT -HOTKEY_SetFocus (HOTKEY_INFO *infoPtr, HWND lostFocus) +HOTKEY_SetFocus (HOTKEY_INFO *infoPtr) { infoPtr->bFocus = TRUE; @@ -505,10 +505,10 @@ HOTKEY_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) case WM_KEYUP: case WM_SYSKEYUP: - return HOTKEY_KeyUp (infoPtr, wParam, lParam); + return HOTKEY_KeyUp (infoPtr, wParam); case WM_KILLFOCUS: - return HOTKEY_KillFocus (infoPtr, (HWND)wParam); + return HOTKEY_KillFocus (infoPtr); case WM_LBUTTONDOWN: return HOTKEY_LButtonDown (infoPtr); @@ -522,7 +522,7 @@ HOTKEY_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) return 0; case WM_SETFOCUS: - return HOTKEY_SetFocus (infoPtr, (HWND)wParam); + return HOTKEY_SetFocus (infoPtr); case WM_SETFONT: return HOTKEY_SetFont (infoPtr, (HFONT)wParam, LOWORD(lParam));
1
0
0
0
Nikolay Sivov : gdiplus: Stub for GdipRotateLineTransform.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: be7d21255ca7382bd821f4e17ebe6a632fc080c2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=be7d21255ca7382bd821f4e17…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat Dec 27 21:39:57 2008 +0300 gdiplus: Stub for GdipRotateLineTransform. --- dlls/gdiplus/brush.c | 14 ++++++++++++++ dlls/gdiplus/gdiplus.spec | 2 +- 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c index a24f54e..9a513e1 100644 --- a/dlls/gdiplus/brush.c +++ b/dlls/gdiplus/brush.c @@ -1331,3 +1331,17 @@ GpStatus WINGDIPAPI GdipGetLineRectI(GpLineGradient *brush, GpRect *rect) return ret; } + +GpStatus WINGDIPAPI GdipRotateLineTransform(GpLineGradient* brush, + REAL angle, GpMatrixOrder order) +{ + static int calls; + + if(!brush) + return InvalidParameter; + + if(!(calls++)) + FIXME("(%p, %.2f, %d) stub\n", brush, angle, order); + + return NotImplemented; +} diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index c995144..12a2316 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -485,7 +485,7 @@ @ stdcall GdipResetWorldTransform(ptr) @ stdcall GdipRestoreGraphics(ptr long) @ stdcall GdipReversePath(ptr) -@ stub GdipRotateLineTransform +@ stdcall GdipRotateLineTransform(ptr long long) @ stdcall GdipRotateMatrix(ptr long long) @ stub GdipRotatePathGradientTransform @ stub GdipRotatePenTransform
1
0
0
0
Nikolay Sivov : gdiplus: Stub for GdipScalePenTransform.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: f4c017eac149d8ab7c1148a64bb1af63886fafe9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f4c017eac149d8ab7c1148a64…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat Dec 27 21:35:40 2008 +0300 gdiplus: Stub for GdipScalePenTransform. --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/pen.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index ad6b191..c995144 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -499,7 +499,7 @@ @ stub GdipScaleLineTransform @ stdcall GdipScaleMatrix(ptr long long long) @ stub GdipScalePathGradientTransform -@ stub GdipScalePenTransform +@ stdcall GdipScalePenTransform(ptr long long long) @ stdcall GdipScaleTextureTransform(ptr long long long) @ stdcall GdipScaleWorldTransform(ptr long long long) @ stdcall GdipSetAdjustableArrowCapFillState(ptr long) diff --git a/dlls/gdiplus/pen.c b/dlls/gdiplus/pen.c index da8a06a..4a68a27 100644 --- a/dlls/gdiplus/pen.c +++ b/dlls/gdiplus/pen.c @@ -398,6 +398,19 @@ GpStatus WINGDIPAPI GdipResetPenTransform(GpPen *pen) return NotImplemented; } +GpStatus WINGDIPAPI GdipScalePenTransform(GpPen *pen, REAL sx, REAL sy, GpMatrixOrder order) +{ + static int calls; + + if(!pen) + return InvalidParameter; + + if(!(calls++)) + FIXME("(%p, %.2f, %.2f, %d) stub\n", pen, sx, sy, order); + + return NotImplemented; +} + GpStatus WINGDIPAPI GdipSetPenBrushFill(GpPen *pen, GpBrush *brush) { TRACE("(%p, %p)\n", pen, brush);
1
0
0
0
Nikolay Sivov : gdiplus: Stub for GdipResetPenTransform.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: 62512971fed983e3363e2bdfb352e5155219f985 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=62512971fed983e3363e2bdfb…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat Dec 27 21:33:21 2008 +0300 gdiplus: Stub for GdipResetPenTransform. --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/pen.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index d380d74..ad6b191 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -480,7 +480,7 @@ @ stub GdipResetPageTransform @ stdcall GdipResetPath(ptr) @ stub GdipResetPathGradientTransform -@ stub GdipResetPenTransform +@ stdcall GdipResetPenTransform(ptr) @ stdcall GdipResetTextureTransform(ptr) @ stdcall GdipResetWorldTransform(ptr) @ stdcall GdipRestoreGraphics(ptr long) diff --git a/dlls/gdiplus/pen.c b/dlls/gdiplus/pen.c index b2d6dab..da8a06a 100644 --- a/dlls/gdiplus/pen.c +++ b/dlls/gdiplus/pen.c @@ -385,6 +385,19 @@ GpStatus WINGDIPAPI GdipGetPenWidth(GpPen *pen, REAL *width) return Ok; } +GpStatus WINGDIPAPI GdipResetPenTransform(GpPen *pen) +{ + static int calls; + + if(!pen) + return InvalidParameter; + + if(!(calls++)) + FIXME("(%p) stub\n", pen); + + return NotImplemented; +} + GpStatus WINGDIPAPI GdipSetPenBrushFill(GpPen *pen, GpBrush *brush) { TRACE("(%p, %p)\n", pen, brush);
1
0
0
0
Vitaliy Margolen : dinput: Replace perror with more appropriate ERR and WARN.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: 7915569511d32c87e16b2d3c9637632749bcbe41 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7915569511d32c87e16b2d3c9…
Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sat Dec 27 11:23:15 2008 -0700 dinput: Replace perror with more appropriate ERR and WARN. --- dlls/dinput/joystick_linuxinput.c | 67 +++++++++++++++++++++---------------- 1 files changed, 38 insertions(+), 29 deletions(-) diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c index c6f07ac..a08a5b7 100644 --- a/dlls/dinput/joystick_linuxinput.c +++ b/dlls/dinput/joystick_linuxinput.c @@ -243,21 +243,25 @@ static void find_joydevs(void) continue; } - if ((-1==ioctl(fd,EVIOCGBIT(0,sizeof(joydev.evbits)),joydev.evbits))) { - perror("EVIOCGBIT 0"); - close(fd); - continue; - } - if (-1==ioctl(fd,EVIOCGBIT(EV_ABS,sizeof(joydev.absbits)),joydev.absbits)) { - perror("EVIOCGBIT EV_ABS"); - close(fd); - continue; - } - if (-1==ioctl(fd,EVIOCGBIT(EV_KEY,sizeof(joydev.keybits)),joydev.keybits)) { - perror("EVIOCGBIT EV_KEY"); - close(fd); - continue; - } + if (ioctl(fd, EVIOCGBIT(0, sizeof(joydev.evbits)), joydev.evbits) == -1) + { + WARN("ioct(EVIOCGBIT, 0) failed: %d %s\n", errno, strerror(errno)); + close(fd); + continue; + } + if (ioctl(fd, EVIOCGBIT(EV_ABS, sizeof(joydev.absbits)), joydev.absbits) == -1) + { + WARN("ioct(EVIOCGBIT, EV_ABS) failed: %d %s\n", errno, strerror(errno)); + close(fd); + continue; + } + if (ioctl(fd, EVIOCGBIT(EV_KEY, sizeof(joydev.keybits)), joydev.keybits) == -1) + { + WARN("ioct(EVIOCGBIT, EV_KEY) failed: %d %s\n", errno, strerror(errno)); + close(fd); + continue; + } + /* A true joystick has at least axis X and Y, and at least 1 * button. copied from linux/drivers/input/joydev.c */ if (test_bit(joydev.absbits,ABS_X) && test_bit(joydev.absbits,ABS_Y) && @@ -628,24 +632,29 @@ static HRESULT WINAPI JoystickAImpl_Acquire(LPDIRECTINPUTDEVICE8A iface) TRACE("(this=%p)\n",This); - res = IDirectInputDevice2AImpl_Acquire(iface); - if (res==DI_OK) { - if (-1==(This->joyfd=open(This->joydev->device,O_RDWR))) { - if (-1==(This->joyfd=open(This->joydev->device,O_RDONLY))) { - /* Couldn't open the device at all */ - perror(This->joydev->device); - IDirectInputDevice2AImpl_Unacquire(iface); - return DIERR_NOTFOUND; - } else { - /* Couldn't open in r/w but opened in read-only. */ - WARN("Could not open %s in read-write mode. Force feedback will be disabled.\n", This->joydev->device); + if ((res = IDirectInputDevice2AImpl_Acquire(iface)) != DI_OK) + { + WARN("Failed to acquire: %x\n", res); + return res; + } + + if ((This->joyfd = open(This->joydev->device, O_RDWR)) == -1) + { + if ((This->joyfd = open(This->joydev->device, O_RDONLY)) == -1) + { + /* Couldn't open the device at all */ + ERR("Failed to open device %s: %d %s\n", This->joydev->device, errno, strerror(errno)); + IDirectInputDevice2AImpl_Unacquire(iface); + return DIERR_NOTFOUND; } - } } else - WARN("Failed to acquire: %x\n", res); + { + /* Couldn't open in r/w but opened in read-only. */ + WARN("Could not open %s in read-write mode. Force feedback will be disabled.\n", This->joydev->device); + } - return res; + return DI_OK; } /******************************************************************************
1
0
0
0
Vitaliy Margolen : dinput: Warn if failed to open device.
by Alexandre Julliard
27 Dec '08
27 Dec '08
Module: wine Branch: master Commit: a179f491fd06ff59cdab6348fdeeea3666f5eb8e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a179f491fd06ff59cdab6348f…
Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sat Dec 27 11:23:13 2008 -0700 dinput: Warn if failed to open device. --- dlls/dinput/joystick_linuxinput.c | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c index 95666e8..c6f07ac 100644 --- a/dlls/dinput/joystick_linuxinput.c +++ b/dlls/dinput/joystick_linuxinput.c @@ -231,12 +231,17 @@ static void find_joydevs(void) snprintf(buf, sizeof(buf), EVDEVPREFIX"%d", i); - if ((fd=open(buf, O_RDWR))==-1) { - fd = open(buf, O_RDONLY); - no_ff_check = 1; - } + if ((fd = open(buf, O_RDWR)) == -1) + { + fd = open(buf, O_RDONLY); + no_ff_check = 1; + } - if (fd!=-1) { + if (fd == -1) + { + WARN("Failed to open \"%s\": %d %s\n", buf, errno, strerror(errno)); + continue; + } if ((-1==ioctl(fd,EVIOCGBIT(0,sizeof(joydev.evbits)),joydev.evbits))) { perror("EVIOCGBIT 0"); @@ -319,9 +324,8 @@ static void find_joydevs(void) have_joydevs++; } - close(fd); + close(fd); } - } } static void fill_joystick_dideviceinstanceA(LPDIDEVICEINSTANCEA lpddi, DWORD version, int id)
1
0
0
0
← Newer
1
...
10
11
12
13
14
15
16
...
123
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
Results per page:
10
25
50
100
200