wine-commits March 2008

wine-commits@winehq.org

4 participants
1001 discussions

Dan Hipschman : qmgr: Add critical sections for jobs and files.
by Alexandre Julliard 13 Mar '08

13 Mar '08

Module: wine Branch: master Commit: fd499df4d5dca5aff2cd179b2149bafbcd3b81d1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd499df4d5dca5aff2cd179b2… Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Wed Mar 12 11:56:13 2008 -0700 qmgr: Add critical sections for jobs and files. --- dlls/qmgr/enum_files.c | 3 +++ dlls/qmgr/file.c | 10 ++++++++-- dlls/qmgr/job.c | 33 ++++++++++++++++++++++----------- dlls/qmgr/qmgr.c | 2 +- dlls/qmgr/qmgr.h | 10 ++++++++-- 5 files changed, 42 insertions(+), 16 deletions(-) diff --git a/dlls/qmgr/enum_files.c b/dlls/qmgr/enum_files.c index 082b541..36afc33 100644 --- a/dlls/qmgr/enum_files.c +++ b/dlls/qmgr/enum_files.c @@ -186,6 +186,7 @@ HRESULT EnumBackgroundCopyFilesConstructor(LPVOID *ppObj, IBackgroundCopyJob* iC /* Create array of files */ This->indexFiles = 0; + EnterCriticalSection(&job->cs); This->numFiles = list_count(&job->files); This->files = NULL; if (This->numFiles > 0) @@ -194,6 +195,7 @@ HRESULT EnumBackgroundCopyFilesConstructor(LPVOID *ppObj, IBackgroundCopyJob* iC This->numFiles * sizeof This->files[0]); if (!This->files) { + LeaveCriticalSection(&job->cs); HeapFree(GetProcessHeap(), 0, This); return E_OUTOFMEMORY; } @@ -206,6 +208,7 @@ HRESULT EnumBackgroundCopyFilesConstructor(LPVOID *ppObj, IBackgroundCopyJob* iC This->files[i] = (IBackgroundCopyFile *) file; ++i; } + LeaveCriticalSection(&job->cs); *ppObj = &This->lpVtbl; return S_OK; diff --git a/dlls/qmgr/file.c b/dlls/qmgr/file.c index 93ffba4..f1ae06a 100644 --- a/dlls/qmgr/file.c +++ b/dlls/qmgr/file.c @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(qmgr); static void BackgroundCopyFileDestructor(BackgroundCopyFileImpl *This) { + IBackgroundCopyJob_Release((IBackgroundCopyJob *) This->owner); HeapFree(GetProcessHeap(), 0, This->info.LocalName); HeapFree(GetProcessHeap(), 0, This->info.RemoteName); HeapFree(GetProcessHeap(), 0, This); @@ -105,9 +106,11 @@ static HRESULT WINAPI BITS_IBackgroundCopyFile_GetProgress( { BackgroundCopyFileImpl *This = (BackgroundCopyFileImpl *) iface; + EnterCriticalSection(&This->owner->cs); pVal->BytesTotal = This->fileProgress.BytesTotal; pVal->BytesTransferred = This->fileProgress.BytesTransferred; pVal->Completed = This->fileProgress.Completed; + LeaveCriticalSection(&This->owner->cs); return S_OK; } @@ -122,8 +125,9 @@ static const IBackgroundCopyFileVtbl BITS_IBackgroundCopyFile_Vtbl = BITS_IBackgroundCopyFile_GetProgress }; -HRESULT BackgroundCopyFileConstructor(LPCWSTR remoteName, - LPCWSTR localName, LPVOID *ppObj) +HRESULT BackgroundCopyFileConstructor(BackgroundCopyJobImpl *owner, + LPCWSTR remoteName, LPCWSTR localName, + LPVOID *ppObj) { BackgroundCopyFileImpl *This; int n; @@ -160,6 +164,8 @@ HRESULT BackgroundCopyFileConstructor(LPCWSTR remoteName, This->fileProgress.BytesTotal = BG_SIZE_UNKNOWN; This->fileProgress.BytesTransferred = 0; This->fileProgress.Completed = FALSE; + This->owner = owner; + IBackgroundCopyJob_AddRef((IBackgroundCopyJob *) owner); *ppObj = &This->lpVtbl; return S_OK; diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c index 8768027..6bc63f4 100644 --- a/dlls/qmgr/job.c +++ b/dlls/qmgr/job.c @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(qmgr); static void BackgroundCopyJobDestructor(BackgroundCopyJobImpl *This) { + DeleteCriticalSection(&This->cs); HeapFree(GetProcessHeap(), 0, This->displayName); HeapFree(GetProcessHeap(), 0, This); } @@ -88,15 +89,17 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_AddFile( /* We should return E_INVALIDARG in these cases. */ FIXME("Check for valid filenames and supported protocols\n"); - res = BackgroundCopyFileConstructor(RemoteUrl, LocalName, (LPVOID *) &pFile); + res = BackgroundCopyFileConstructor(This, RemoteUrl, LocalName, (LPVOID *) &pFile); if (res != S_OK) return res; /* Add a reference to the file to file list */ IBackgroundCopyFile_AddRef(pFile); file = (BackgroundCopyFileImpl *) pFile; + EnterCriticalSection(&This->cs); list_add_head(&This->files, &file->entryFromJob); ++This->jobProgress.FilesTotal; + LeaveCriticalSection(&This->cs); return S_OK; } @@ -120,24 +123,26 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_Resume( IBackgroundCopyJob* iface) { BackgroundCopyJobImpl *This = (BackgroundCopyJobImpl *) iface; + HRESULT rv = S_OK; + EnterCriticalSection(&globalMgr.cs); if (This->state == BG_JOB_STATE_CANCELLED || This->state == BG_JOB_STATE_ACKNOWLEDGED) { - return BG_E_INVALID_STATE; + rv = BG_E_INVALID_STATE; } - - if (This->jobProgress.FilesTransferred == This->jobProgress.FilesTotal) - return BG_E_EMPTY; - - if (This->state == BG_JOB_STATE_CONNECTING - || This->state == BG_JOB_STATE_TRANSFERRING) + else if (This->jobProgress.FilesTransferred == This->jobProgress.FilesTotal) { - return S_OK; + rv = BG_E_EMPTY; } + else if (This->state != BG_JOB_STATE_CONNECTING + && This->state != BG_JOB_STATE_TRANSFERRING) + { + This->state = BG_JOB_STATE_QUEUED; + } + LeaveCriticalSection(&globalMgr.cs); - This->state = BG_JOB_STATE_QUEUED; - return S_OK; + return rv; } static HRESULT WINAPI BITS_IBackgroundCopyJob_Cancel( @@ -185,10 +190,12 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_GetProgress( if (!pVal) return E_INVALIDARG; + EnterCriticalSection(&This->cs); pVal->BytesTotal = This->jobProgress.BytesTotal; pVal->BytesTransferred = This->jobProgress.BytesTransferred; pVal->FilesTotal = This->jobProgress.FilesTotal; pVal->FilesTransferred = This->jobProgress.FilesTransferred; + LeaveCriticalSection(&This->cs); return S_OK; } @@ -210,6 +217,7 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_GetState( if (!pVal) return E_INVALIDARG; + /* Don't think we need a critical section for this */ *pVal = This->state; return S_OK; } @@ -441,6 +449,7 @@ HRESULT BackgroundCopyJobConstructor(LPCWSTR displayName, BG_JOB_TYPE type, return E_OUTOFMEMORY; This->lpVtbl = &BITS_IBackgroundCopyJob_Vtbl; + InitializeCriticalSection(&This->cs); This->ref = 1; This->type = type; @@ -448,6 +457,7 @@ HRESULT BackgroundCopyJobConstructor(LPCWSTR displayName, BG_JOB_TYPE type, This->displayName = HeapAlloc(GetProcessHeap(), 0, n); if (!This->displayName) { + DeleteCriticalSection(&This->cs); HeapFree(GetProcessHeap(), 0, This); return E_OUTOFMEMORY; } @@ -456,6 +466,7 @@ HRESULT BackgroundCopyJobConstructor(LPCWSTR displayName, BG_JOB_TYPE type, hr = CoCreateGuid(&This->jobId); if (FAILED(hr)) { + DeleteCriticalSection(&This->cs); HeapFree(GetProcessHeap(), 0, This->displayName); HeapFree(GetProcessHeap(), 0, This); return hr; diff --git a/dlls/qmgr/qmgr.c b/dlls/qmgr/qmgr.c index c6fbc42..b0a6013 100644 --- a/dlls/qmgr/qmgr.c +++ b/dlls/qmgr/qmgr.c @@ -127,7 +127,7 @@ static const IBackgroundCopyManagerVtbl BITS_IBackgroundCopyManager_Vtbl = BITS_IBackgroundCopyManager_GetErrorDescription }; -static BackgroundCopyManagerImpl globalMgr = { +BackgroundCopyManagerImpl globalMgr = { &BITS_IBackgroundCopyManager_Vtbl, { NULL, -1, 0, 0, 0, 0 }, LIST_INIT(globalMgr.jobs) diff --git a/dlls/qmgr/qmgr.h b/dlls/qmgr/qmgr.h index 166ee40..a584694 100644 --- a/dlls/qmgr/qmgr.h +++ b/dlls/qmgr/qmgr.h @@ -41,6 +41,8 @@ typedef struct struct list files; BG_JOB_PROGRESS jobProgress; BG_JOB_STATE state; + /* Protects file list, and progress */ + CRITICAL_SECTION cs; struct list entryFromQmgr; } BackgroundCopyJobImpl; @@ -72,12 +74,14 @@ typedef struct BG_FILE_INFO info; BG_FILE_PROGRESS fileProgress; struct list entryFromJob; + BackgroundCopyJobImpl *owner; } BackgroundCopyFileImpl; /* Background copy manager vtbl and related data */ typedef struct { const IBackgroundCopyManagerVtbl *lpVtbl; + /* Protects job list and job states */ CRITICAL_SECTION cs; struct list jobs; } BackgroundCopyManagerImpl; @@ -88,14 +92,16 @@ typedef struct } ClassFactoryImpl; extern ClassFactoryImpl BITS_ClassFactory; +extern BackgroundCopyManagerImpl globalMgr; HRESULT BackgroundCopyManagerConstructor(IUnknown *pUnkOuter, LPVOID *ppObj); HRESULT BackgroundCopyJobConstructor(LPCWSTR displayName, BG_JOB_TYPE type, GUID *pJobId, LPVOID *ppObj); HRESULT EnumBackgroundCopyJobsConstructor(LPVOID *ppObj, IBackgroundCopyManager* copyManager); -HRESULT BackgroundCopyFileConstructor(LPCWSTR remoteName, - LPCWSTR localName, LPVOID *ppObj); +HRESULT BackgroundCopyFileConstructor(BackgroundCopyJobImpl *owner, + LPCWSTR remoteName, LPCWSTR localName, + LPVOID *ppObj); HRESULT EnumBackgroundCopyFilesConstructor(LPVOID *ppObj, IBackgroundCopyJob* copyJob);

1 0

Rob Shearman : wininet: Fix local variable shadowing in URLCacheContainer_OpenIndex.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: bcfb47e85bed0a37046914a4128a06dcec8002eb URL: http://source.winehq.org/git/wine.git/?a=commit;h=bcfb47e85bed0a37046914a41… Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed Mar 12 17:40:39 2008 +0000 wininet: Fix local variable shadowing in URLCacheContainer_OpenIndex. --- dlls/wininet/urlcache.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index ab63ac7..d42192a 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -375,8 +375,6 @@ static BOOL URLCacheContainer_OpenIndex(URLCACHECONTAINER * pContainer) if (CreateDirectoryW(wszDirPath, 0)) { - int k; - /* The following is OK because we generated an * 8 character directory name made from characters * [A-Z0-9], which are equivalent for all code

1 0

Rob Shearman : msi: Passing NULL for szBuffer and NULL for pcchValueBuf into MsiGetProductInfo{A , W} shouldn't crash.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: 58130dde08396f2b93481e9166f6ecae4a4446e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=58130dde08396f2b93481e916… Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed Mar 12 17:40:51 2008 +0000 msi: Passing NULL for szBuffer and NULL for pcchValueBuf into MsiGetProductInfo{A, W} shouldn't crash. Add a test for this. --- dlls/msi/msi.c | 27 ++++++++++++++++----------- dlls/msi/tests/msi.c | 4 ++++ 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 85446e8..32a4173 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -722,20 +722,25 @@ static UINT WINAPI MSI_GetProductInfo(LPCWSTR szProduct, LPCWSTR szAttribute, goto done; } - save = *pcchValueBuf; + if (pcchValueBuf) + { + save = *pcchValueBuf; - if (lstrlenW(val) < *pcchValueBuf) - r = msi_strcpy_to_awstring(val, szValue, pcchValueBuf); - else if (szValue->str.a || szValue->str.w) - r = ERROR_MORE_DATA; + if (lstrlenW(val) < *pcchValueBuf) + r = msi_strcpy_to_awstring(val, szValue, pcchValueBuf); + else if (szValue->str.a || szValue->str.w) + r = ERROR_MORE_DATA; - if (!badconfig) - *pcchValueBuf = lstrlenW(val); - else if (r == ERROR_SUCCESS) - { - *pcchValueBuf = save; - r = ERROR_BAD_CONFIGURATION; + if (!badconfig) + *pcchValueBuf = lstrlenW(val); + else if (r == ERROR_SUCCESS) + { + *pcchValueBuf = save; + r = ERROR_BAD_CONFIGURATION; + } } + else if (badconfig) + r = ERROR_BAD_CONFIGURATION; if (val != empty) msi_free(val); diff --git a/dlls/msi/tests/msi.c b/dlls/msi/tests/msi.c index f82a9a9..5da8673 100644 --- a/dlls/msi/tests/msi.c +++ b/dlls/msi/tests/msi.c @@ -2233,6 +2233,10 @@ static void test_MsiGetProductInfo(void) ok(!lstrcmpA(buf, "link"), "Expected \"link\", got \"%s\"\n", buf); ok(sz == 4, "Expected 4, got %d\n", sz); + /* pcchBuf is NULL */ + r = MsiGetProductInfoA(prodcode, INSTALLPROPERTY_HELPLINK, NULL, NULL); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + /* lpValueBuf is NULL */ sz = MAX_PATH; r = MsiGetProductInfoA(prodcode, INSTALLPROPERTY_HELPLINK, NULL, &sz);

1 0

Rob Shearman : msi: Fix typos which caused joins of three or more tables to not work properly.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: dd31a1eac4dbbac2e7a14099a26189fc54cb5029 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd31a1eac4dbbac2e7a14099a… Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed Mar 12 15:12:01 2008 +0000 msi: Fix typos which caused joins of three or more tables to not work properly. In JOIN_fetch_int and JOIN_fetch_stream, prev_rows should be multiplied by the rows encountered in the current table so that prev_rows contains all of counts of the rows encountered multiplied together, rather than just the count of the rows in the last table encountered. --- dlls/msi/join.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/join.c b/dlls/msi/join.c index 7d25217..e24eace 100644 --- a/dlls/msi/join.c +++ b/dlls/msi/join.c @@ -77,7 +77,7 @@ static UINT JOIN_fetch_int( struct tagMSIVIEW *view, UINT row, UINT col, UINT *v break; } - prev_rows = table->rows; + prev_rows *= table->rows; cols += table->columns; } @@ -108,7 +108,7 @@ static UINT JOIN_fetch_stream( struct tagMSIVIEW *view, UINT row, UINT col, IStr break; } - prev_rows = table->rows; + prev_rows *= table->rows; cols += table->columns; }

1 0

Rob Shearman : oleaut32: Split the methods for opening different sources of typelibs out of TLB_ReadTypeLib .
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: 0ec1e2842ae3e4de3db843d3e06d972d91a58fc3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ec1e2842ae3e4de3db843d3e… Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed Mar 12 13:29:58 2008 +0000 oleaut32: Split the methods for opening different sources of typelibs out of TLB_ReadTypeLib. --- dlls/oleaut32/typelib.c | 256 +++++++++++++++++++++++++++++++++++++---------- 1 files changed, 202 insertions(+), 54 deletions(-) diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c index f251d70..70f8a0d 100644 --- a/dlls/oleaut32/typelib.c +++ b/dlls/oleaut32/typelib.c @@ -2217,6 +2217,188 @@ static CRITICAL_SECTION_DEBUG cache_section_debug = static CRITICAL_SECTION cache_section = { &cache_section_debug, -1, 0, 0, 0, 0 }; +typedef struct TLB_PEFile +{ + const IUnknownVtbl *lpvtbl; + LONG refs; + HMODULE dll; + HRSRC typelib_resource; + HGLOBAL typelib_global; + LPVOID typelib_base; +} TLB_PEFile; + +static HRESULT WINAPI TLB_PEFile_QueryInterface(IUnknown *iface, REFIID riid, void **ppv) +{ + if (IsEqualIID(riid, &IID_IUnknown)) + { + *ppv = iface; + IUnknown_AddRef(iface); + return S_OK; + } + *ppv = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI TLB_PEFile_AddRef(IUnknown *iface) +{ + TLB_PEFile *This = (TLB_PEFile *)iface; + return InterlockedIncrement(&This->refs); +} + +static ULONG WINAPI TLB_PEFile_Release(IUnknown *iface) +{ + TLB_PEFile *This = (TLB_PEFile *)iface; + ULONG refs = InterlockedDecrement(&This->refs); + if (!refs) + { + if (This->typelib_global) + FreeResource(This->typelib_global); + if (This->dll) + FreeLibrary(This->dll); + HeapFree(GetProcessHeap(), 0, This); + } + return refs; +} + +static const IUnknownVtbl TLB_PEFile_Vtable = +{ + TLB_PEFile_QueryInterface, + TLB_PEFile_AddRef, + TLB_PEFile_Release +}; + +static HRESULT TLB_PEFile_Open(LPCWSTR path, INT index, LPVOID *ppBase, DWORD *pdwTLBLength, IUnknown **ppFile) +{ + TLB_PEFile *This; + + This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); + if (!This) + return E_OUTOFMEMORY; + + This->lpvtbl = &TLB_PEFile_Vtable; + This->refs = 1; + This->dll = NULL; + This->typelib_resource = NULL; + This->typelib_global = NULL; + This->typelib_base = NULL; + + This->dll = LoadLibraryExW(path, 0, DONT_RESOLVE_DLL_REFERENCES | + LOAD_LIBRARY_AS_DATAFILE | LOAD_WITH_ALTERED_SEARCH_PATH); + + if (This->dll) + { + static const WCHAR TYPELIBW[] = {'T','Y','P','E','L','I','B',0}; + This->typelib_resource = FindResourceW(This->dll, MAKEINTRESOURCEW(index), TYPELIBW); + if (This->typelib_resource) + { + This->typelib_global = LoadResource(This->dll, This->typelib_resource); + if (This->typelib_global) + { + This->typelib_base = LockResource(This->typelib_global); + + if (This->typelib_base) + { + *pdwTLBLength = SizeofResource(This->dll, This->typelib_resource); + *ppBase = This->typelib_base; + *ppFile = (IUnknown *)&This->lpvtbl; + return S_OK; + } + } + } + } + + TLB_PEFile_Release((IUnknown *)&This->lpvtbl); + return TYPE_E_CANTLOADLIBRARY; +} + + +typedef struct TLB_Mapping +{ + const IUnknownVtbl *lpvtbl; + LONG refs; + HANDLE file; + HANDLE mapping; + LPVOID typelib_base; +} TLB_Mapping; + +static HRESULT WINAPI TLB_Mapping_QueryInterface(IUnknown *iface, REFIID riid, void **ppv) +{ + if (IsEqualIID(riid, &IID_IUnknown)) + { + *ppv = iface; + IUnknown_AddRef(iface); + return S_OK; + } + *ppv = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI TLB_Mapping_AddRef(IUnknown *iface) +{ + TLB_Mapping *This = (TLB_Mapping *)iface; + return InterlockedIncrement(&This->refs); +} + +static ULONG WINAPI TLB_Mapping_Release(IUnknown *iface) +{ + TLB_Mapping *This = (TLB_Mapping *)iface; + ULONG refs = InterlockedDecrement(&This->refs); + if (!refs) + { + if (This->typelib_base) + UnmapViewOfFile(This->typelib_base); + if (This->mapping) + CloseHandle(This->mapping); + if (This->file != INVALID_HANDLE_VALUE) + CloseHandle(This->file); + HeapFree(GetProcessHeap(), 0, This); + } + return refs; +} + +static const IUnknownVtbl TLB_Mapping_Vtable = +{ + TLB_Mapping_QueryInterface, + TLB_Mapping_AddRef, + TLB_Mapping_Release +}; + +static HRESULT TLB_Mapping_Open(LPCWSTR path, LPVOID *ppBase, DWORD *pdwTLBLength, IUnknown **ppFile) +{ + TLB_Mapping *This; + + This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); + if (!This) + return E_OUTOFMEMORY; + + This->lpvtbl = &TLB_Mapping_Vtable; + This->refs = 1; + This->file = INVALID_HANDLE_VALUE; + This->mapping = NULL; + This->typelib_base = NULL; + + This->file = CreateFileW(path, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); + if (INVALID_HANDLE_VALUE != This->file) + { + This->mapping = CreateFileMappingW(This->file, NULL, PAGE_READONLY | SEC_COMMIT, 0, 0, NULL); + if (This->mapping) + { + This->typelib_base = MapViewOfFile(This->mapping, FILE_MAP_READ, 0, 0, 0); + if(This->typelib_base) + { + /* retrieve file size */ + *pdwTLBLength = GetFileSize(This->file, NULL); + *ppBase = This->typelib_base; + *ppFile = (IUnknown *)&This->lpvtbl; + return S_OK; + } + } + } + + IUnknown_Release((IUnknown *)&This->lpvtbl); + return TYPE_E_CANTLOADLIBRARY; +} + /**************************************************************************** * TLB_ReadTypeLib * @@ -2228,10 +2410,12 @@ static CRITICAL_SECTION cache_section = { &cache_section_debug, -1, 0, 0, 0, 0 } static int TLB_ReadTypeLib(LPCWSTR pszFileName, LPWSTR pszPath, UINT cchPath, ITypeLib2 **ppTypeLib) { ITypeLibImpl *entry; - int ret = TYPE_E_CANTLOADLIBRARY; + HRESULT ret; INT index = 1; - HINSTANCE hinstDLL; LPWSTR index_str, file = (LPWSTR)pszFileName; + LPVOID pBase = NULL; + DWORD dwTLBLength = 0; + IUnknown *pFile = NULL; *ppTypeLib = NULL; @@ -2285,63 +2469,27 @@ static int TLB_ReadTypeLib(LPCWSTR pszFileName, LPWSTR pszPath, UINT cchPath, IT /* now actually load and parse the typelib */ - hinstDLL = LoadLibraryExW(pszPath, 0, DONT_RESOLVE_DLL_REFERENCES | - LOAD_LIBRARY_AS_DATAFILE | LOAD_WITH_ALTERED_SEARCH_PATH); - - if (hinstDLL) + ret = TLB_PEFile_Open(pszPath, index, &pBase, &dwTLBLength, &pFile); + if (ret == TYPE_E_CANTLOADLIBRARY) + ret = TLB_Mapping_Open(pszPath, &pBase, &dwTLBLength, &pFile); + if (SUCCEEDED(ret)) { - static const WCHAR TYPELIBW[] = {'T','Y','P','E','L','I','B',0}; - HRSRC hrsrc = FindResourceW(hinstDLL, MAKEINTRESOURCEW(index), TYPELIBW); - if (hrsrc) + if (dwTLBLength >= 4) { - HGLOBAL hGlobal = LoadResource(hinstDLL, hrsrc); - if (hGlobal) - { - LPVOID pBase = LockResource(hGlobal); - DWORD dwTLBLength = SizeofResource(hinstDLL, hrsrc); - - if (pBase) - { - /* try to load as incore resource */ - DWORD dwSignature = FromLEDWord(*((DWORD*) pBase)); - if (dwSignature == MSFT_SIGNATURE) - *ppTypeLib = ITypeLib2_Constructor_MSFT(pBase, dwTLBLength); - else if (dwSignature == SLTG_SIGNATURE) - *ppTypeLib = ITypeLib2_Constructor_SLTG(pBase, dwTLBLength); - else - FIXME("Header type magic 0x%08x not supported.\n",dwSignature); - } - FreeResource( hGlobal ); - } - } - FreeLibrary(hinstDLL); - } - else - { - HANDLE hFile = CreateFileW(pszPath, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0 ); - if (INVALID_HANDLE_VALUE != hFile) - { - HANDLE hMapping = CreateFileMappingW( hFile, NULL, PAGE_READONLY | SEC_COMMIT, 0, 0, NULL ); - if (hMapping) + DWORD dwSignature = FromLEDWord(*((DWORD*) pBase)); + if (dwSignature == MSFT_SIGNATURE) + *ppTypeLib = ITypeLib2_Constructor_MSFT(pBase, dwTLBLength); + else if (dwSignature == SLTG_SIGNATURE) + *ppTypeLib = ITypeLib2_Constructor_SLTG(pBase, dwTLBLength); + else { - LPVOID pBase = MapViewOfFile(hMapping, FILE_MAP_READ, 0, 0, 0); - if(pBase) - { - /* retrieve file size */ - DWORD dwTLBLength = GetFileSize(hFile, NULL); - DWORD dwSignature = FromLEDWord(*((DWORD*) pBase)); - - if (dwSignature == MSFT_SIGNATURE) - *ppTypeLib = ITypeLib2_Constructor_MSFT(pBase, dwTLBLength); - else if (dwSignature == SLTG_SIGNATURE) - *ppTypeLib = ITypeLib2_Constructor_SLTG(pBase, dwTLBLength); - - UnmapViewOfFile(pBase); - } - CloseHandle(hMapping); + FIXME("Header type magic 0x%08x not supported.\n",dwSignature); + ret = TYPE_E_CANTLOADLIBRARY; } - CloseHandle(hFile); } + else + ret = TYPE_E_CANTLOADLIBRARY; + IUnknown_Release(pFile); } if(*ppTypeLib) {

1 0

Jacek Caban : jscript: Added Dll[Un]RegisterServer implementation.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: 66c728dec1a37f10c6e039f0a63558c05590ab9d URL: http://source.winehq.org/git/wine.git/?a=commit;h=66c728dec1a37f10c6e039f0a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 12 18:41:11 2008 +0100 jscript: Added Dll[Un]RegisterServer implementation. --- dlls/jscript/Makefile.in | 2 + dlls/jscript/jscript.inf | 97 +++++++++++++++++++++++++++++++++++++++++++ dlls/jscript/jscript_main.c | 86 ++++++++++++++++++++++++++++++++++++-- dlls/jscript/rsrc.rc | 20 +++++++++ 4 files changed, 200 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/Makefile.in b/dlls/jscript/Makefile.in index c1ce428..f314abb 100644 --- a/dlls/jscript/Makefile.in +++ b/dlls/jscript/Makefile.in @@ -6,6 +6,8 @@ MODULE = jscript.dll IMPORTS = kernel32 EXTRALIBS = -luuid +RC_SRCS = rsrc.rc + C_SRCS = \ jscript_main.c diff --git a/dlls/jscript/jscript.inf b/dlls/jscript/jscript.inf new file mode 100644 index 0000000..bdec721 --- /dev/null +++ b/dlls/jscript/jscript.inf @@ -0,0 +1,97 @@ +[version] +Signature="$CHICAGO$" + + +[RegisterDll] +AddReg=Classes.Reg + + +[UnregisterDll] +DelReg=Classes.Reg + + +[Classes.Reg] +HKCR,"CLSID\%CLSID_JScript%",,,"JScript Language" +HKCR,"CLSID\%CLSID_JScript%\Implemented Categories\%CATID_ActiveScript%",,, +HKCR,"CLSID\%CLSID_JScript%\Implemented Categories\%CATID_ActiveScriptParse%",,, +HKCR,"CLSID\%CLSID_JScript%\InprocServer32",,,"%MODULE%" +HKCR,"CLSID\%CLSID_JScript%\InprocServer32","ThreadingModel",,"Both" +HKCR,"CLSID\%CLSID_JScript%\OLEScript",,, +HKCR,"CLSID\%CLSID_JScript%\ProgID",,,"JScript" + +HKCR,"CLSID\%CLSID_JScriptAuthor%",,,"JScript Language Authoring" +HKCR,"CLSID\%CLSID_JScriptAuthor%\Implemented Categories\%CATID_ActiveScriptAuthor%",,, +HKCR,"CLSID\%CLSID_JScriptAuthor%\InprocServer32",,,"%MODULE%" +HKCR,"CLSID\%CLSID_JScriptAuthor%\InprocServer32","ThreadingModel",,"Both" +HKCR,"CLSID\%CLSID_JScriptAuthor%\OLEScript",,, +HKCR,"CLSID\%CLSID_JScriptAuthor%\ProgID",,,"JScript Author" + +HKCR,"CLSID\%CLSID_JScriptEncode%",,,"JScript Language Encoding" +HKCR,"CLSID\%CLSID_JScriptEncode%\Implemented Categories\%CATID_ActiveScript%",,, +HKCR,"CLSID\%CLSID_JScriptEncode%\Implemented Categories\%CATID_ActiveScriptParse%",,, +HKCR,"CLSID\%CLSID_JScriptEncode%\Implemented Categories\%CATID_ActiveScriptEncode%",,, +HKCR,"CLSID\%CLSID_JScriptEncode%\InprocServer32",,,"%MODULE%" +HKCR,"CLSID\%CLSID_JScriptEncode%\InprocServer32","ThreadingModel",,"Both" +HKCR,"CLSID\%CLSID_JScriptEncode%\OLEScript",,, +HKCR,"CLSID\%CLSID_JScriptEncode%\ProgID",,,"JScript.Encode" + +HKCR,"Component Categories\%CATID_ActiveScriptAuthor%","409",,"Active Scripting Engine with Authoring" +HKCR,"Component Categories\%CATID_ActiveScript%","409",,"Active Scripting Engine" +HKCR,"Component Categories\%CATID_ActiveScriptParse%","409",,"Active Scripting Engine with Parsing" +HKCR,"Component Categories\%CATID_ActiveScriptEncode%","409",,"Active Scripting Engine with Encoding" + +HKCR,"ECMAScript",,,"JScript Language" +HKCR,"ECMAScript\CLSID",,,"%CLSID_JScript%" +HKCR,"ECMAScript\OLEScript",,, + +HKCR,"JavaScript",,,"JScript Language" +HKCR,"JavaScript\CLSID",,,"%CLSID_JScript%" +HKCR,"JavaScript\OLEScript",,, + +HKCR,"JavaScript Author",,,"JScript Language Authoring" +HKCR,"JavaScript Author\CLSID",,,"%CLSID_JScriptAuthor%" +HKCR,"JavaScript Author\OLEScript",,, + +HKCR,"JavaScript1.1",,,"JScript Language" +HKCR,"JavaScript1.1\CLSID",,,"%CLSID_JScript%" +HKCR,"JavaScript1.1\OLEScript",,, + +HKCR,"JavaScript1.1 Author",,,"JScript Language Authoring" +HKCR,"JavaScript1.1 Author\CLSID",,,"%CLSID_JScriptAuthor%" +HKCR,"JavaScript1.1 Author\OLEScript",,, + +HKCR,"JavaScript1.2",,,"JScript Language" +HKCR,"JavaScript1.2\CLSID",,,"%CLSID_JScript%" +HKCR,"JavaScript1.2\OLEScript",,, + +HKCR,"JavaScript1.2 Author",,,"JScript Language Authoring" +HKCR,"JavaScript1.2 Author\CLSID",,,"%CLSID_JScriptAuthor%" +HKCR,"JavaScript1.2 Author\OLEScript",,, + +HKCR,"JavaScript1.3",,,"JScript Language" +HKCR,"JavaScript1.3\CLSID",,,"%CLSID_JScript%" +HKCR,"JavaScript1.3\OLEScript",,, + +HKCR,"JScript",,,"JScript Language" +HKCR,"JScript\CLSID",,,"%CLSID_JScript%" +HKCR,"JScript\OLEScript",,, + +HKCR,"JScript Author",,,"JScript Language Authoring" +HKCR,"JScript Author\CLSID",,,"%CLSID_JScriptAuthor%" +HKCR,"JScript Author\OLEScript",,, + +HKCR,"JScript.Encode",,,"JScript Language Encoding" +HKCR,"JScript.Encode\CLSID",,,"%CLSID_JScriptEncode%" +HKCR,"JScript.Encode\OLEScript",,, + +HKCR,"LiveScript",,,"JScript Language" +HKCR,"LiveScript\CLSID",,,"%CLSID_JScript%" +HKCR,"LiveScript\OLEScript",,, + +HKCR,"LiveScript Author",,,"JScript Language Authoring" +HKCR,"LiveScript Author\CLSID",,,"%CLSID_JScriptAuthor%" +HKCR,"LiveScript Author\OLEScript",,, + + +[Strings] +MODULE="jscript.dll" diff --git a/dlls/jscript/jscript_main.c b/dlls/jscript/jscript_main.c index 807a821..dea26ca 100644 --- a/dlls/jscript/jscript_main.c +++ b/dlls/jscript/jscript_main.c @@ -19,16 +19,34 @@ #include "config.h" #include <stdarg.h> +#include <stdio.h> #define COBJMACROS #include "windef.h" #include "winbase.h" +#include "winuser.h" +#include "winreg.h" +#include "ole2.h" +#include "advpub.h" + +#include "initguid.h" +#include "activscp.h" +#include "activaut.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(jscript); +static const CLSID CLSID_JScript = + {0xf414c260,0x6ac0,0x11cf,{0xb6,0xd1,0x00,0xaa,0x00,0xbb,0xbb,0x58}}; +static const CLSID CLSID_JScriptAuthor = + {0xf414c261,0x6ac0,0x11cf,{0xb6,0xd1,0x00,0xaa,0x00,0xbb,0xbb,0x58}}; +static const CLSID CLSID_JScriptEncode = + {0xf414c262,0x6ac0,0x11cf,{0xb6,0xd1,0x00,0xaa,0x00,0xbb,0xbb,0x58}}; + +static HINSTANCE jscript_hinstance; + /****************************************************************** * DllMain (jscript.@) */ @@ -41,7 +59,8 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) case DLL_WINE_PREATTACH: return FALSE; /* prefer native version */ case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls(hInstDLL); + DisableThreadLibraryCalls(hInstDLL); + jscript_hinstance = hInstDLL; break; } @@ -67,12 +86,69 @@ HRESULT WINAPI DllCanUnloadNow(void) } /*********************************************************************** + * register_inf + */ + +#define INF_SET_ID(id) \ + do \ + { \ + static CHAR name[] = #id; \ + \ + pse[i].pszName = name; \ + clsids[i++] = &id; \ + } while (0) + +static HRESULT register_inf(BOOL doregister) +{ + HRESULT hres; + HMODULE hAdvpack; + HRESULT (WINAPI *pRegInstall)(HMODULE hm, LPCSTR pszSection, const STRTABLEA* pstTable); + STRTABLEA strtable; + STRENTRYA pse[7]; + static CLSID const *clsids[7]; + int i = 0; + + static const WCHAR advpackW[] = {'a','d','v','p','a','c','k','.','d','l','l',0}; + + INF_SET_ID(CLSID_JScript); + INF_SET_ID(CLSID_JScriptAuthor); + INF_SET_ID(CLSID_JScriptEncode); + INF_SET_ID(CATID_ActiveScript); + INF_SET_ID(CATID_ActiveScriptParse); + INF_SET_ID(CATID_ActiveScriptEncode); + INF_SET_ID(CATID_ActiveScriptAuthor); + + for(i = 0; i < sizeof(pse)/sizeof(pse[0]); i++) { + pse[i].pszValue = HeapAlloc(GetProcessHeap(), 0, 39); + sprintf(pse[i].pszValue, "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", + clsids[i]->Data1, clsids[i]->Data2, clsids[i]->Data3, clsids[i]->Data4[0], + clsids[i]->Data4[1], clsids[i]->Data4[2], clsids[i]->Data4[3], clsids[i]->Data4[4], + clsids[i]->Data4[5], clsids[i]->Data4[6], clsids[i]->Data4[7]); + } + + strtable.cEntries = sizeof(pse)/sizeof(pse[0]); + strtable.pse = pse; + + hAdvpack = LoadLibraryW(advpackW); + pRegInstall = (void *)GetProcAddress(hAdvpack, "RegInstall"); + + hres = pRegInstall(jscript_hinstance, doregister ? "RegisterDll" : "UnregisterDll", &strtable); + + for(i=0; i < sizeof(pse)/sizeof(pse[0]); i++) + HeapFree(GetProcessHeap(), 0, pse[i].pszValue); + + return hres; +} + +#undef INF_SET_CLSID + +/*********************************************************************** * DllRegisterServer (jscript.@) */ HRESULT WINAPI DllRegisterServer(void) { - FIXME("()\n"); - return S_OK; + TRACE("()\n"); + return register_inf(TRUE); } /*********************************************************************** @@ -80,6 +156,6 @@ HRESULT WINAPI DllRegisterServer(void) */ HRESULT WINAPI DllUnregisterServer(void) { - FIXME("()\n"); - return S_OK; + TRACE("()\n"); + return register_inf(FALSE); } diff --git a/dlls/jscript/rsrc.rc b/dlls/jscript/rsrc.rc new file mode 100644 index 0000000..7a08b79 --- /dev/null +++ b/dlls/jscript/rsrc.rc @@ -0,0 +1,20 @@ +/* + * Copyright 2008 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +/* @makedep: jscript.inf */ +REGINST REGINST jscript.inf

1 0

Jacek Caban : secur32: Improve SECPKG_ATTR_CIPHER_STRENGTHS stub.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: 87368bb623849b500e6238903ac7e6dffb018e5b URL: http://source.winehq.org/git/wine.git/?a=commit;h=87368bb623849b500e6238903… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 12 18:35:10 2008 +0100 secur32: Improve SECPKG_ATTR_CIPHER_STRENGTHS stub. --- dlls/secur32/schannel.c | 12 ++++++++---- dlls/secur32/tests/schannel.c | 15 +++++++++++++++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c index b74e54c..742cdb3 100644 --- a/dlls/secur32/schannel.c +++ b/dlls/secur32/schannel.c @@ -39,7 +39,7 @@ static SECURITY_STATUS schan_QueryCredentialsAttributes( if (pBuffer) { /* FIXME: get from CryptoAPI */ - FIXME("%d: stub\n", ulAttribute); + FIXME("SECPKG_ATTR_SUPPORTED_ALGS: stub\n"); ret = SEC_E_UNSUPPORTED_FUNCTION; } else @@ -48,9 +48,13 @@ static SECURITY_STATUS schan_QueryCredentialsAttributes( case SECPKG_ATTR_CIPHER_STRENGTHS: if (pBuffer) { + SecPkgCred_CipherStrengths *r = (SecPkgCred_CipherStrengths*)pBuffer; + /* FIXME: get from CryptoAPI */ - FIXME("%d: stub\n", ulAttribute); - ret = SEC_E_UNSUPPORTED_FUNCTION; + FIXME("SECPKG_ATTR_CIPHER_STRENGTHS: semi-stub\n"); + r->dwMinimumCipherStrength = 40; + r->dwMaximumCipherStrength = 168; + ret = SEC_E_OK; } else ret = SEC_E_INTERNAL_ERROR; @@ -59,7 +63,7 @@ static SECURITY_STATUS schan_QueryCredentialsAttributes( if (pBuffer) { /* FIXME: get from OpenSSL? */ - FIXME("%d: stub\n", ulAttribute); + FIXME("SECPKG_ATTR_SUPPORTED_PROTOCOLS: stub\n"); ret = SEC_E_UNSUPPORTED_FUNCTION; } else diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c index b19590a..2fc793b 100644 --- a/dlls/secur32/tests/schannel.c +++ b/dlls/secur32/tests/schannel.c @@ -31,6 +31,7 @@ static HMODULE secdll, crypt32dll; static ACQUIRE_CREDENTIALS_HANDLE_FN_A pAcquireCredentialsHandleA; static FREE_CREDENTIALS_HANDLE_FN pFreeCredentialsHandle; +static QUERY_CREDENTIALS_ATTRIBUTES_FN_A pQueryCredentialsAttributesA; static PCCERT_CONTEXT (WINAPI *pCertCreateCertificateContext)(DWORD,const BYTE*,DWORD); static BOOL (WINAPI *pCertFreeCertificateContext)(PCCERT_CONTEXT); @@ -120,6 +121,7 @@ static void InitFunctionPtrs(void) { GET_PROC(secdll, AcquireCredentialsHandleA); GET_PROC(secdll, FreeCredentialsHandle); + GET_PROC(secdll, QueryCredentialsAttributesA); } GET_PROC(advapi32dll, CryptAcquireContextW); @@ -134,6 +136,18 @@ static void InitFunctionPtrs(void) #undef GET_PROC } +static void test_strength(PCredHandle handle) +{ + SecPkgCred_CipherStrengths strength = {-1,-1}; + SECURITY_STATUS st; + + st = pQueryCredentialsAttributesA(handle, SECPKG_ATTR_CIPHER_STRENGTHS, &strength); + ok(st == SEC_E_OK, "QueryCredentialsAttributesA failed: %u\n", GetLastError()); + ok(strength.dwMinimumCipherStrength, "dwMinimumCipherStrength not changed\n"); + ok(strength.dwMaximumCipherStrength, "dwMaximumCipherStrength not changed\n"); + trace("strength %d - %d\n", strength.dwMinimumCipherStrength, strength.dwMaximumCipherStrength); +} + static void testAcquireSecurityContext(void) { SECURITY_STATUS st; @@ -347,6 +361,7 @@ static void testAcquireSecurityContext(void) st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_INBOUND, NULL, &schanCred, NULL, NULL, &cred, NULL); ok(st == SEC_E_OK, "AcquireCredentialsHandleA failed: %08x\n", st); + test_strength(&cred); pFreeCredentialsHandle(&cred); /* How about more than one cert? */

1 0

Jacek Caban : secur32: Fixed dynamic loading in schannel test.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: d11e30e484785dad780d2254a7af80affc6a0d18 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d11e30e484785dad780d2254a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 12 18:34:55 2008 +0100 secur32: Fixed dynamic loading in schannel test. --- dlls/secur32/tests/schannel.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c index dec9368..b19590a 100644 --- a/dlls/secur32/tests/schannel.c +++ b/dlls/secur32/tests/schannel.c @@ -28,14 +28,15 @@ #include "wine/test.h" static HMODULE secdll, crypt32dll; -static SECURITY_STATUS (SEC_ENTRY * pAcquireCredentialsHandleA)(SEC_CHAR*, SEC_CHAR*, - ULONG, PLUID, PVOID, SEC_GET_KEY_FN, PVOID, PCredHandle, PTimeStamp); + +static ACQUIRE_CREDENTIALS_HANDLE_FN_A pAcquireCredentialsHandleA; +static FREE_CREDENTIALS_HANDLE_FN pFreeCredentialsHandle; + static PCCERT_CONTEXT (WINAPI *pCertCreateCertificateContext)(DWORD,const BYTE*,DWORD); static BOOL (WINAPI *pCertFreeCertificateContext)(PCCERT_CONTEXT); static BOOL (WINAPI *pCertSetCertificateContextProperty)(PCCERT_CONTEXT,DWORD,DWORD,const void*); -static SECURITY_STATUS (SEC_ENTRY * pFreeCredentialsHandle)(PCredHandle); -static BOOL (WINAPI * pCryptAcquireContextW)(HCRYPTPROV*, LPCWSTR, LPCWSTR, DWORD, DWORD); +static BOOL (WINAPI *pCryptAcquireContextW)(HCRYPTPROV*, LPCWSTR, LPCWSTR, DWORD, DWORD); static BOOL (WINAPI *pCryptDestroyKey)(HCRYPTKEY); static BOOL (WINAPI *pCryptImportKey)(HCRYPTPROV,CONST BYTE*,DWORD,HCRYPTKEY,DWORD,HCRYPTKEY*); static BOOL (WINAPI *pCryptReleaseContext)(HCRYPTPROV,ULONG_PTR); @@ -105,12 +106,13 @@ static const BYTE selfSignedCert[] = { static void InitFunctionPtrs(void) { - HMODULE advapi32dll = GetModuleHandleA("advapi32.dll"); + HMODULE advapi32dll; crypt32dll = LoadLibraryA("crypt32.dll"); secdll = LoadLibraryA("secur32.dll"); if(!secdll) secdll = LoadLibraryA("security.dll"); + advapi32dll = GetModuleHandleA("advapi32.dll"); #define GET_PROC(h, func) p ## func = (void*)GetProcAddress(h, #func) @@ -127,6 +129,7 @@ static void InitFunctionPtrs(void) GET_PROC(crypt32dll, CertFreeCertificateContext); GET_PROC(crypt32dll, CertSetCertificateContextProperty); + GET_PROC(crypt32dll, CertCreateCertificateContext); #undef GET_PROC }

1 0

Huw Davies : gdi32: Factor out FreeType initialization into a separate function.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: e0693a18134be876625425ae1d18bfafe1466d6a URL: http://source.winehq.org/git/wine.git/?a=commit;h=e0693a18134be876625425ae1… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Mar 12 13:45:13 2008 +0000 gdi32: Factor out FreeType initialization into a separate function. --- dlls/gdi32/freetype.c | 76 +++++++++++++++++++++++++++---------------------- 1 files changed, 42 insertions(+), 34 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 765ac82..aef9024 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2163,28 +2163,9 @@ static void update_font_info(void) FIXME("there is no font defaults for codepages %u,%u\n", ansi_cp, oem_cp); } -/************************************************************* - * WineEngInit - * - * Initialize FreeType library and create a list of available faces - */ -BOOL WineEngInit(void) -{ - static const WCHAR dot_fonW[] = {'.','f','o','n','\0'}; - static const WCHAR pathW[] = {'P','a','t','h',0}; - HKEY hkey; - DWORD valuelen, datalen, i = 0, type, dlen, vlen; - LPVOID data; - WCHAR windowsdir[MAX_PATH]; - char *unixname; - HANDLE font_mutex; - const char *data_dir; - - TRACE("\n"); - - /* update locale dependent font info in registry */ - update_font_info(); +static BOOL init_freetype(void) +{ ft_handle = wine_dlopen(SONAME_LIBFREETYPE, RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( @@ -2219,7 +2200,7 @@ BOOL WineEngInit(void) LOAD_FUNCPTR(FT_Vector_Transform) #undef LOAD_FUNCPTR - /* Don't warn if this one is missing */ + /* Don't warn if these ones are missing */ pFT_Library_Version = wine_dlsym(ft_handle, "FT_Library_Version", NULL, 0); pFT_Load_Sfnt_Table = wine_dlsym(ft_handle, "FT_Load_Sfnt_Table", NULL, 0); pFT_Get_First_Char = wine_dlsym(ft_handle, "FT_Get_First_Char", NULL, 0); @@ -2241,11 +2222,10 @@ BOOL WineEngInit(void) ft_handle = NULL; return FALSE; } - FT_Version.major=FT_Version.minor=FT_Version.patch=-1; + FT_Version.major = FT_Version.minor = FT_Version.patch = -1; if (pFT_Library_Version) - { pFT_Library_Version(library,&FT_Version.major,&FT_Version.minor,&FT_Version.patch); - } + if (FT_Version.major<=0) { FT_Version.major=2; @@ -2257,6 +2237,43 @@ BOOL WineEngInit(void) ((FT_Version.minor << 8) & 0x00ff00) | ((FT_Version.patch ) & 0x0000ff); + return TRUE; + +sym_not_found: + WINE_MESSAGE( + "Wine cannot find certain functions that it needs inside the FreeType\n" + "font library. To enable Wine to use TrueType fonts please upgrade\n" + "FreeType to at least version 2.0.5.\n" + "http://www.freetype.org\n"); + wine_dlclose(ft_handle, NULL, 0); + ft_handle = NULL; + return FALSE; +} + +/************************************************************* + * WineEngInit + * + * Initialize FreeType library and create a list of available faces + */ +BOOL WineEngInit(void) +{ + static const WCHAR dot_fonW[] = {'.','f','o','n','\0'}; + static const WCHAR pathW[] = {'P','a','t','h',0}; + HKEY hkey; + DWORD valuelen, datalen, i = 0, type, dlen, vlen; + LPVOID data; + WCHAR windowsdir[MAX_PATH]; + char *unixname; + HANDLE font_mutex; + const char *data_dir; + + TRACE("\n"); + + /* update locale dependent font info in registry */ + update_font_info(); + + if(!init_freetype()) return FALSE; + if((font_mutex = CreateMutexW(NULL, FALSE, font_mutex_nameW)) == NULL) { ERR("Failed to create font mutex\n"); return FALSE; @@ -2385,15 +2402,6 @@ BOOL WineEngInit(void) ReleaseMutex(font_mutex); return TRUE; -sym_not_found: - WINE_MESSAGE( - "Wine cannot find certain functions that it needs inside the FreeType\n" - "font library. To enable Wine to use TrueType fonts please upgrade\n" - "FreeType to at least version 2.0.5.\n" - "http://www.freetype.org\n"); - wine_dlclose(ft_handle, NULL, 0); - ft_handle = NULL; - return FALSE; }

1 0

Alexandre Julliard : comctl32/tests: Avoid size_t printf format warnings.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Module: wine Branch: master Commit: 9dd61548bb383d1de123316c690e27f4071f960a URL: http://source.winehq.org/git/wine.git/?a=commit;h=9dd61548bb383d1de123316c6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 12 18:14:22 2008 +0100 comctl32/tests: Avoid size_t printf format warnings. --- dlls/comctl32/tests/toolbar.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c index dbe9c58..2693025 100644 --- a/dlls/comctl32/tests/toolbar.c +++ b/dlls/comctl32/tests/toolbar.c @@ -1109,14 +1109,14 @@ static void test_getstring(void) r = SendMessage(hToolbar, TB_ADDSTRING, 0, (LPARAM)answer); expect(0, r); r = SendMessage(hToolbar, TB_GETSTRING, MAKEWPARAM(0, 0), (LPARAM)NULL); - expect(strlen(answer), r); + expect(lstrlenA(answer), r); r = SendMessage(hToolbar, TB_GETSTRINGW, MAKEWPARAM(0, 0), (LPARAM)NULL); - expect(strlen(answer), r); + expect(lstrlenA(answer), r); r = SendMessage(hToolbar, TB_GETSTRING, MAKEWPARAM(sizeof(str), 0), (LPARAM)str); - expect(strlen(answer), r); + expect(lstrlenA(answer), r); expect(0, lstrcmp(answer, str)); r = SendMessage(hToolbar, TB_GETSTRINGW, MAKEWPARAM(sizeof(strW), 0), (LPARAM)strW); - expect(strlen(answer), r); + expect(lstrlenA(answer), r); expect(0, lstrcmpW(answerW, strW)); DestroyWindow(hToolbar);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2008