wine-commits March 2008

wine-commits@winehq.org

4 participants
1001 discussions

Paul Vriens : winecfg: Fix setting version to Vista.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 863240b77b4886c5868ccf566dc537b33ca2394e URL: http://source.winehq.org/git/wine.git/?a=commit;h=863240b77b4886c5868ccf566… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue Mar 11 14:25:05 2008 +0100 winecfg: Fix setting version to Vista. --- programs/winecfg/appdefaults.c | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c index 3fdd8f3..53e912a 100644 --- a/programs/winecfg/appdefaults.c +++ b/programs/winecfg/appdefaults.c @@ -70,11 +70,18 @@ static const char szKeyNT[] = "Software\\Microsoft\\Windows NT\\CurrentVersion"; static int get_registry_version(void) { - int i, best = -1, platform, major, minor = 0; + int i, best = -1, platform, major, minor, build = 0; char *p, *ver; if ((ver = get_reg_key( HKEY_LOCAL_MACHINE, szKeyNT, "CurrentVersion", NULL ))) + { + char *build_str; + platform = VER_PLATFORM_WIN32_NT; + + build_str = get_reg_key( HKEY_LOCAL_MACHINE, szKeyNT, "CurrentBuildNumber", NULL ); + build = atoi(build_str); + } else if ((ver = get_reg_key( HKEY_LOCAL_MACHINE, szKey9x, "VersionNumber", NULL ))) platform = VER_PLATFORM_WIN32_WINDOWS; else @@ -82,10 +89,15 @@ static int get_registry_version(void) if ((p = strchr( ver, '.' ))) { - char *str = p; - *str++ = 0; - if ((p = strchr( str, '.' ))) *p = 0; - minor = atoi(str); + char *minor_str = p; + *minor_str++ = 0; + if ((p = strchr( minor_str, '.' ))) + { + char *build_str = p; + *build_str++ = 0; + build = atoi(build_str); + } + minor = atoi(minor_str); } major = atoi(ver); @@ -94,7 +106,9 @@ static int get_registry_version(void) if (win_versions[i].dwPlatformId != platform) continue; if (win_versions[i].dwMajorVersion != major) continue; best = i; - if (win_versions[i].dwMinorVersion == minor) return i; + if ((win_versions[i].dwMinorVersion == minor) && + (win_versions[i].dwBuildNumber == build)) + return i; } return best; }

1 0

Alexandre Julliard : uuid: Avoid some guids that shouldn' t be defined in libuuid.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: acc1dd11cb7cb6a95f1801d8f591addab8ea9eae URL: http://source.winehq.org/git/wine.git/?a=commit;h=acc1dd11cb7cb6a95f1801d8f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 11 15:38:21 2008 +0100 uuid: Avoid some guids that shouldn't be defined in libuuid. --- dlls/uuid/uuid.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c index c53238f..32f953b 100644 --- a/dlls/uuid/uuid.c +++ b/dlls/uuid/uuid.c @@ -50,7 +50,9 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); #include "shldisp.h" #include "comcat.h" #include "urlmon.h" +#define _NO_AUTHOR_GUIDS #include "activaut.h" +#define _NO_SCRIPT_GUIDS #include "activscp.h" #include "dispex.h" #include "mlang.h"

1 0

Jacek Caban : include: Added activaut.idl.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: fe5ea9f006ada0a79ba2fad2cb82d476ea3393d1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fe5ea9f006ada0a79ba2fad2c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 11 13:01:00 2008 +0100 include: Added activaut.idl. --- .gitignore | 1 + dlls/uuid/uuid.c | 1 + include/Makefile.in | 1 + include/activaut.idl | 29 +++++++++++++++++++++++++++++ 4 files changed, 32 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 483b391..1abc9e7 100644 --- a/.gitignore +++ b/.gitignore @@ -590,6 +590,7 @@ dlls/ws2_32/version.res dlls/wsock32/libwsock32.def dlls/wsock32/version.res dlls/wtsapi32/libwtsapi32.def +include/activaut.h include/activscp.h include/amstream.h include/amvideo.h diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c index 3fc97ee..c53238f 100644 --- a/dlls/uuid/uuid.c +++ b/dlls/uuid/uuid.c @@ -50,6 +50,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); #include "shldisp.h" #include "comcat.h" #include "urlmon.h" +#include "activaut.h" #include "activscp.h" #include "dispex.h" #include "mlang.h" diff --git a/include/Makefile.in b/include/Makefile.in index 287cfa9..f81b4c4 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -5,6 +5,7 @@ VPATH = @srcdir@ MODULE = none IDL_H_SRCS = \ + activaut.idl \ activscp.idl \ amstream.idl \ amvideo.idl \ diff --git a/include/activaut.idl b/include/activaut.idl new file mode 100644 index 0000000..890e785 --- /dev/null +++ b/include/activaut.idl @@ -0,0 +1,29 @@ +/* + * Copyright 2008 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef DO_NO_IMPORTS +import "ocidl.idl"; +import "oleidl.idl"; +import "oaidl.idl"; +#endif + +cpp_quote("#ifndef _NO_AUTHOR_GUIDS") + +cpp_quote("DEFINE_GUID(CATID_ActiveScriptAuthor, 0xaee2a92,0xbcbb,0x11d0,0x8c,0x72,0x0,0xc0,0x4f,0xc2,0xb0,0x85);") + +cpp_quote("#endif")

1 0

Jacek Caban : activscp.idl: Added CATID_* declarations.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 7ba25f0b22698d5ebc48d1c02400c1c2268540c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ba25f0b22698d5ebc48d1c02… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 11 13:00:46 2008 +0100 activscp.idl: Added CATID_* declarations. --- include/activscp.idl | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/activscp.idl b/include/activscp.idl index 248203e..ea201f5 100644 --- a/include/activscp.idl +++ b/include/activscp.idl @@ -21,6 +21,14 @@ import "ocidl.idl"; import "oleidl.idl"; import "oaidl.idl"; #endif + +cpp_quote("#ifndef _NO_SCRIPT_GUIDS") + +cpp_quote("DEFINE_GUID(CATID_ActiveScript, 0xf0b7a1a1,0x9847,0x11cf,0x8f,0x20,0x00,0x80,0x5f,0x2c,0xd0,0x64);") +cpp_quote("DEFINE_GUID(CATID_ActiveScriptParse, 0xf0b7a1a2,0x9847,0x11cf,0x8f,0x20,0x00,0x80,0x5f,0x2c,0xd0,0x64);") +cpp_quote("DEFINE_GUID(CATID_ActiveScriptEncode, 0xf0b7a1a3,0x9847,0x11cf,0x8f,0x20,0x00,0x80,0x5f,0x2c,0xd0,0x64);") + +cpp_quote("#endif") typedef enum tagSCRIPTSTATE { SCRIPTSTATE_UNINITIALIZED = 0,

1 0

Aric Stewart : gdi32: Skip leading @ from FontFace when looking for font to load.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 5c1229982a932c72d2bf444b61a2f24da6e3d155 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c1229982a932c72d2bf444b6… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Mar 11 19:34:48 2008 +0900 gdi32: Skip leading @ from FontFace when looking for font to load. --- dlls/gdi32/freetype.c | 19 ++++++++++++++----- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 46a53c8..765ac82 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -3068,13 +3068,22 @@ GdiFont *WineEngCreateFontInstance(DC *dc, HFONT hfont) FontSubst *psub; SYSTEM_LINKS *font_link; CHILD_FONT *font_link_entry; + LPWSTR FaceName = lf.lfFaceName; - psub = get_font_subst(&font_subst_list, lf.lfFaceName, lf.lfCharSet); + /* + * Check for a leading '@' this signals that the font is being + * requested in tategaki mode (vertical writing subtitution) but + * does not affect the fontface that is to be selected. + */ + if (lf.lfFaceName[0]=='@') + FaceName = &lf.lfFaceName[1]; + + psub = get_font_subst(&font_subst_list, FaceName, lf.lfCharSet); if(psub) { - TRACE("substituting %s -> %s\n", debugstr_w(lf.lfFaceName), + TRACE("substituting %s -> %s\n", debugstr_w(FaceName), debugstr_w(psub->to.name)); - strcpyW(lf.lfFaceName, psub->to.name); + strcpyW(FaceName, psub->to.name); } /* We want a match on name and charset or just name if @@ -3085,7 +3094,7 @@ GdiFont *WineEngCreateFontInstance(DC *dc, HFONT hfont) */ LIST_FOR_EACH(family_elem_ptr, &font_list) { family = LIST_ENTRY(family_elem_ptr, Family, entry); - if(!strcmpiW(family->FamilyName, lf.lfFaceName)) { + if(!strcmpiW(family->FamilyName, FaceName)) { LIST_FOR_EACH(face_elem_ptr, &family->faces) { face = LIST_ENTRY(face_elem_ptr, Face, entry); if((csi.fs.fsCsb[0] & (face->fs.fsCsb[0] | face->fs_links.fsCsb[0])) || !csi.fs.fsCsb[0]) @@ -3101,7 +3110,7 @@ GdiFont *WineEngCreateFontInstance(DC *dc, HFONT hfont) */ LIST_FOR_EACH_ENTRY(font_link, &system_links, SYSTEM_LINKS, entry) { - if(!strcmpiW(font_link->font_name, lf.lfFaceName)) + if(!strcmpiW(font_link->font_name, FaceName)) { TRACE("found entry in system list\n"); LIST_FOR_EACH_ENTRY(font_link_entry, &font_link->links, CHILD_FONT, entry)

1 0

Denver Gingerich : ddraw: Implement ForceRefreshRate registry entry for overriding DirectX refresh rate .
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 248ae8f112720d65cebe76f60f062c5589268a05 URL: http://source.winehq.org/git/wine.git/?a=commit;h=248ae8f112720d65cebe76f60… Author: Denver Gingerich <denver(a)ossguy.com> Date: Mon Mar 10 12:44:38 2008 -0400 ddraw: Implement ForceRefreshRate registry entry for overriding DirectX refresh rate. --- dlls/ddraw/ddraw.c | 91 +++++++++++++++++++++++++++++-------------- dlls/ddraw/ddraw_private.h | 2 + dlls/ddraw/main.c | 36 +++++++++++++++++ 3 files changed, 99 insertions(+), 30 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 4cac55d..60ffdcd 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -3,6 +3,7 @@ * Copyright 1998-2000 Lionel Ulmer * Copyright 2000-2001 TransGaming Technologies Inc. * Copyright 2006 Stefan D�singer + * Copyright 2008 Denver Gingerich * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -534,34 +535,24 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, } /***************************************************************************** - * IDirectDraw7::SetDisplayMode * - * Sets the display screen resolution, color depth and refresh frequency - * when in fullscreen mode (in theory). - * Possible return values listed in the SDK suggest that this method fails - * when not in fullscreen mode, but this is wrong. Windows 2000 happily sets - * the display mode in DDSCL_NORMAL mode without an hwnd specified. - * It seems to be valid to pass 0 for With and Height, this has to be tested - * It could mean that the current video mode should be left as-is. (But why - * call it then?) - * - * Params: - * Height, Width: Screen dimension - * BPP: Color depth in Bits per pixel - * Refreshrate: Screen refresh rate - * Flags: Other stuff + * Helper function for SetDisplayMode and RestoreDisplayMode * - * Returns - * DD_OK on success + * Implements DirectDraw's SetDisplayMode, but ignores the value of + * ForceRefreshRate, since it is already handled by + * IDirectDrawImpl_SetDisplayMode. RestoreDisplayMode can use this function + * without worrying that ForceRefreshRate will override the refresh rate. For + * argument and return value documentation, see + * IDirectDrawImpl_SetDisplayMode. * *****************************************************************************/ -static HRESULT WINAPI -IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, - DWORD Width, - DWORD Height, - DWORD BPP, - DWORD RefreshRate, - DWORD Flags) +static HRESULT +IDirectDrawImpl_SetDisplayModeNoOverride(IDirectDraw7 *iface, + DWORD Width, + DWORD Height, + DWORD BPP, + DWORD RefreshRate, + DWORD Flags) { ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw7, iface); WINED3DDISPLAYMODE Mode; @@ -616,6 +607,46 @@ IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, } /***************************************************************************** + * IDirectDraw7::SetDisplayMode + * + * Sets the display screen resolution, color depth and refresh frequency + * when in fullscreen mode (in theory). + * Possible return values listed in the SDK suggest that this method fails + * when not in fullscreen mode, but this is wrong. Windows 2000 happily sets + * the display mode in DDSCL_NORMAL mode without an hwnd specified. + * It seems to be valid to pass 0 for With and Height, this has to be tested + * It could mean that the current video mode should be left as-is. (But why + * call it then?) + * + * Params: + * Height, Width: Screen dimension + * BPP: Color depth in Bits per pixel + * Refreshrate: Screen refresh rate + * Flags: Other stuff + * + * Returns + * DD_OK on success + * + *****************************************************************************/ +static HRESULT WINAPI +IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, + DWORD Width, + DWORD Height, + DWORD BPP, + DWORD RefreshRate, + DWORD Flags) +{ + if (force_refresh_rate != 0) + { + TRACE("ForceRefreshRate overriding passed-in refresh rate (%d Hz) to %d Hz\n", RefreshRate, force_refresh_rate); + RefreshRate = force_refresh_rate; + } + + return IDirectDrawImpl_SetDisplayModeNoOverride(iface, Width, Height, BPP, + RefreshRate, Flags); +} + +/***************************************************************************** * IDirectDraw7::RestoreDisplayMode * * Restores the display mode to what it was at creation time. Basically. @@ -642,12 +673,12 @@ IDirectDrawImpl_RestoreDisplayMode(IDirectDraw7 *iface) ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw7, iface); TRACE("(%p)\n", This); - return IDirectDraw7_SetDisplayMode(ICOM_INTERFACE(This, IDirectDraw7), - This->orig_width, - This->orig_height, - This->orig_bpp, - 0, - 0); + return IDirectDrawImpl_SetDisplayModeNoOverride(ICOM_INTERFACE(This, IDirectDraw7), + This->orig_width, + This->orig_height, + This->orig_bpp, + 0, + 0); } /***************************************************************************** diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index 9b78edf..c10f981 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -83,6 +83,8 @@ extern ULONG WINAPI D3D7CB_DestroyDepthStencilSurface(IWineD3DSurface *pSurface) /* Global critical section */ extern CRITICAL_SECTION ddraw_cs; +extern DWORD force_refresh_rate; + /***************************************************************************** * IDirectDraw implementation structure *****************************************************************************/ diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c index 4e77d4f..a33cb34 100644 --- a/dlls/ddraw/main.c +++ b/dlls/ddraw/main.c @@ -4,6 +4,7 @@ * Copyright 1998 Lionel Ulmer * Copyright 2000-2001 TransGaming Technologies Inc. * Copyright 2006 Stefan D�singer + * Copyright 2008 Denver Gingerich * * This file contains the (internal) driver registration functions, * driver enumeration APIs and DirectDraw creation functions. @@ -68,6 +69,9 @@ static CRITICAL_SECTION_DEBUG ddraw_cs_debug = }; CRITICAL_SECTION ddraw_cs = { &ddraw_cs_debug, -1, 0, 0, 0, 0 }; +/* value of ForceRefreshRate */ +DWORD force_refresh_rate = 0; + /*********************************************************************** * * Helper function for DirectDrawCreate and friends @@ -886,6 +890,38 @@ DllMain(HINSTANCE hInstDLL, } } + /* On Windows one can force the refresh rate that DirectDraw uses by + * setting an override value in dxdiag. This is documented in KB315614 + * (main article), KB230002, and KB217348. By comparing registry dumps + * before and after setting the override, we see that the override value + * is stored in HKLM\Software\Microsoft\DirectDraw\ForceRefreshRate as a + * DWORD that represents the refresh rate to force. We use this + * registry entry to modify the behavior of SetDisplayMode so that Wine + * users can override the refresh rate in a Windows-compatible way. + * + * dxdiag will not accept a refresh rate lower than 40 or higher than + * 120 so this value should be within that range. It is, of course, + * possible for a user to set the registry entry value directly so that + * assumption might not hold. + * + * There is no current mechanism for setting this value through the Wine + * GUI. It would be most appropriate to set this value through a dxdiag + * clone, but it may be sufficient to use winecfg. + * + * TODO: Create a mechanism for setting this value through the Wine GUI. + */ + if ( !RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Microsoft\\DirectDraw", &hkey ) ) + { + DWORD type, data; + size = sizeof(data); + if (!RegQueryValueExA( hkey, "ForceRefreshRate", NULL, &type, (LPBYTE)&data, &size ) && type == REG_DWORD) + { + TRACE("ForceRefreshRate set; overriding refresh rate to %d Hz\n", data); + force_refresh_rate = data; + } + RegCloseKey( hkey ); + } + DisableThreadLibraryCalls(hInstDLL); } else if (Reason == DLL_PROCESS_DETACH)

1 0

Christopher Berner : user32: Make LoadStringW pass tests.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 9978cc9c56f7ec09be2d2a22c2e7fb5d5d1f07be URL: http://source.winehq.org/git/wine.git/?a=commit;h=9978cc9c56f7ec09be2d2a22c… Author: Christopher Berner <raccoonone(a)procyongames.com> Date: Wed Mar 5 12:28:54 2008 -0800 user32: Make LoadStringW pass tests. --- dlls/crypt32/oid.c | 10 +++++----- dlls/hhctrl.ocx/help.c | 9 +++++---- dlls/mpr/wnet.c | 10 ++++++---- dlls/user32/resource.c | 12 +++++++++++- dlls/user32/tests/resource.c | 29 +++++++++++------------------ 5 files changed, 38 insertions(+), 32 deletions(-) diff --git a/dlls/crypt32/oid.c b/dlls/crypt32/oid.c index 5d17997..980c750 100644 --- a/dlls/crypt32/oid.c +++ b/dlls/crypt32/oid.c @@ -1402,8 +1402,9 @@ static void init_oid_info(HINSTANCE hinst) } else { + LPCWSTR stringresource; int len = LoadStringW(hinst, (UINT_PTR)oidInfoConstructors[i].pwszName, - NULL, 0); + (LPWSTR)&stringresource, 0); if (len) { @@ -1415,12 +1416,11 @@ static void init_oid_info(HINSTANCE hinst) memset(info, 0, sizeof(*info)); info->info.cbSize = sizeof(CRYPT_OID_INFO); info->info.pszOID = oidInfoConstructors[i].pszOID; - info->info.pwszName = - (LPWSTR)((LPBYTE)info + sizeof(struct OIDInfo)); + info->info.pwszName = (LPWSTR)(info + 1); info->info.dwGroupId = oidInfoConstructors[i].dwGroupId; info->info.u.Algid = oidInfoConstructors[i].Algid; - LoadStringW(hinst, (UINT_PTR)oidInfoConstructors[i].pwszName, - (LPWSTR)info->info.pwszName, len + 1); + memcpy(info + 1, stringresource, len*sizeof(WCHAR)); + ((LPWSTR)(info + 1))[len] = 0; if (oidInfoConstructors[i].blob) { info->info.ExtraInfo.cbData = diff --git a/dlls/hhctrl.ocx/help.c b/dlls/hhctrl.ocx/help.c index 3f6a080..3ee522e 100644 --- a/dlls/hhctrl.ocx/help.c +++ b/dlls/hhctrl.ocx/help.c @@ -51,13 +51,14 @@ static const WCHAR szEmpty[] = {0}; static LPWSTR HH_LoadString(DWORD dwID) { LPWSTR string = NULL; + LPCWSTR stringresource; int iSize; - iSize = LoadStringW(hhctrl_hinstance, dwID, NULL, 0); - iSize += 2; /* some strings (tab text) needs double-null termination */ + iSize = LoadStringW(hhctrl_hinstance, dwID, (LPWSTR)&stringresource, 0); - string = heap_alloc(iSize * sizeof(WCHAR)); - LoadStringW(hhctrl_hinstance, dwID, string, iSize); + string = heap_alloc((iSize + 2) * sizeof(WCHAR)); /* some strings (tab text) needs double-null termination */ + memcpy(string, stringresource, iSize*sizeof(WCHAR)); + string[iSize] = 0; return string; } diff --git a/dlls/mpr/wnet.c b/dlls/mpr/wnet.c index 17e8195..32bc255 100644 --- a/dlls/mpr/wnet.c +++ b/dlls/mpr/wnet.c @@ -279,16 +279,18 @@ void wnetInit(HINSTANCE hInstDll) { PWSTR ptrPrev; int entireNetworkLen; + LPCWSTR stringresource; entireNetworkLen = LoadStringW(hInstDll, - IDS_ENTIRENETWORK, NULL, 0); + IDS_ENTIRENETWORK, (LPWSTR)&stringresource, 0); providerTable->entireNetwork = HeapAlloc( GetProcessHeap(), 0, (entireNetworkLen + 1) * sizeof(WCHAR)); if (providerTable->entireNetwork) - LoadStringW(hInstDll, IDS_ENTIRENETWORK, - providerTable->entireNetwork, - entireNetworkLen + 1); + { + memcpy(providerTable->entireNetwork, stringresource, entireNetworkLen*sizeof(WCHAR)); + providerTable->entireNetwork[entireNetworkLen] = 0; + } providerTable->numAllocated = numToAllocate; for (ptr = providers; ptr; ) { diff --git a/dlls/user32/resource.c b/dlls/user32/resource.c index 9eed0e8..cbdb4ea 100644 --- a/dlls/user32/resource.c +++ b/dlls/user32/resource.c @@ -368,6 +368,9 @@ INT WINAPI LoadStringW( HINSTANCE instance, UINT resource_id, TRACE("instance = %p, id = %04x, buffer = %p, length = %d\n", instance, resource_id, buffer, buflen); + if(buffer == NULL) + return 0; + /* Use loword (incremented by 1) as resourceid */ hrsrc = FindResourceW( instance, MAKEINTRESOURCEW((LOWORD(resource_id) >> 4) + 1), (LPWSTR)RT_STRING ); @@ -382,7 +385,14 @@ INT WINAPI LoadStringW( HINSTANCE instance, UINT resource_id, TRACE("strlen = %d\n", (int)*p ); - if (buffer == NULL) return *p; + /*if buflen == 0, then return a read-only pointer to the resource itself in buffer + it is assumed that buffer is actually a (LPWSTR *) */ + if(buflen == 0) + { + *((LPWSTR *)buffer) = p + 1; + return *p; + } + i = min(buflen - 1, *p); if (i > 0) { memcpy(buffer, p + 1, i * sizeof (WCHAR)); diff --git a/dlls/user32/tests/resource.c b/dlls/user32/tests/resource.c index 7be82ad..99fc24f 100644 --- a/dlls/user32/tests/resource.c +++ b/dlls/user32/tests/resource.c @@ -43,13 +43,10 @@ static void test_LoadStringW(void) length1 = LoadStringW(hInst, 2, (WCHAR *) &resourcepointer, 0); /* get pointer to resource. */ length2 = LoadStringW(hInst, 2, returnedstringw, sizeof(returnedstringw) /sizeof(WCHAR)); /* get resource string */ ok(length2 > 0, "LoadStringW failed to load resource 2, ret %d, err %d\n", length2, GetLastError()); - todo_wine - { - ok(length1 == length2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d\n", - length1, length2); - ok(length1 > 0 && resourcepointer != NULL, "LoadStringW failed to get pointer to resource 2, ret %d, err %d\n", - length1, GetLastError()); - } + ok(length1 == length2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d\n", + length1, length2); + ok(length1 > 0 && resourcepointer != NULL, "LoadStringW failed to get pointer to resource 2, ret %d, err %d\n", + length1, GetLastError()); /* Copy the resource since it is not '\0' terminated, and add '\0' to the end */ if(resourcepointer != NULL) /* Check that the resource pointer was loaded to avoid access violation */ @@ -62,17 +59,13 @@ static void test_LoadStringW(void) ok(!memcmp(copiedstringw, returnedstringw, (length2 + 1)*sizeof(WCHAR)), "strings don't match: returnedstring = %s, copiedstring = %s\n", returnedstring, copiedstring); } - todo_wine - { - /* check that calling LoadStringW with buffer = NULL returns zero */ - retvalue = LoadStringW(hInst, 2, NULL, 0); - ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", - retvalue); - /* check again, with a different buflen value, that calling LoadStringW with buffer = NULL returns zero */ - retvalue = LoadStringW(hInst, 2, NULL, 128); - ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", - retvalue); - } + + /* check that calling LoadStringW with buffer = NULL returns zero */ + retvalue = LoadStringW(hInst, 2, NULL, 0); + ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", retvalue); + /* check again, with a different buflen value, that calling LoadStringW with buffer = NULL returns zero */ + retvalue = LoadStringW(hInst, 2, NULL, 128); + ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", retvalue); } static void test_LoadStringA (void)

1 0

Alistair Leslie-Hughes : msxml3: Corrected double free in test.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 17bf0d916439d310471b22ad0ca1e8b5e1afce4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=17bf0d916439d310471b22ad0… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Mar 11 19:33:06 2008 +1100 msxml3: Corrected double free in test. --- dlls/msxml3/tests/domdoc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 5d7fc0c..c4c5b9c 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -2,7 +2,7 @@ * XML test * * Copyright 2005 Mike McCormack for CodeWeavers - * Copyright 2007 Alistair Leslie-Hughes + * Copyright 2007-2008 Alistair Leslie-Hughes * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -528,6 +528,7 @@ static void test_domdoc( void ) ok( r == E_INVALIDARG, "returns %08x\n", r ); r = IXMLDOMDocument_createTextNode(doc, str, &nodetext); ok( r == S_OK, "returns %08x\n", r ); + SysFreeString( str ); if(nodetext) { IXMLDOMNamedNodeMap *pAttribs; @@ -696,7 +697,6 @@ static void test_domdoc( void ) IXMLDOMText_Release( nodetext ); } - SysFreeString( str ); /* test Create Comment */ r = IXMLDOMDocument_createComment(doc, NULL, NULL);

1 0

James Hawkins : msi: Ignore the custom action type 51 if the source field is empty.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 2d0ff9740605cb8b663cce44775b08856b570ac5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d0ff9740605cb8b663cce447… Author: James Hawkins <jhawkins(a)codeweavers.com> Date: Tue Mar 11 00:30:24 2008 -0500 msi: Ignore the custom action type 51 if the source field is empty. --- dlls/msi/custom.c | 3 ++ dlls/msi/tests/install.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 0 deletions(-) diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c index 53cdf68..316fe5a 100644 --- a/dlls/msi/custom.c +++ b/dlls/msi/custom.c @@ -331,6 +331,9 @@ UINT ACTION_CustomAction(MSIPACKAGE *package, LPCWSTR action, UINT script, BOOL msi_free(deformated); break; case 51: /* Property set with formatted text. */ + if (!source) + break; + deformat_string(package,target,&deformated); rc = MSI_SetPropertyW(package,source,deformated); msi_free(deformated); diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 03458dc..00cd705 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -603,6 +603,36 @@ static const CHAR wrv_registry_dat[] = "Registry\tRoot\tKey\tName\tValue\tCompon "Registry\tRegistry\n" "regdata\t2\tSOFTWARE\\Wine\\msitest\tValue\t[~]one[~]two[~]three\taugustus"; +static const CHAR ca51_component_dat[] = "Component\tComponentId\tDirectory_\tAttributes\tCondition\tKeyPath\n" + "s72\tS38\ts72\ti2\tS255\tS72\n" + "Component\tComponent\n" + "augustus\t\tMSITESTDIR\t0\tMYPROP=42\taugustus\n"; + +static const CHAR ca51_install_exec_seq_dat[] = "Action\tCondition\tSequence\n" + "s72\tS255\tI2\n" + "InstallExecuteSequence\tAction\n" + "ValidateProductID\t\t700\n" + "GoodSetProperty\t\t725\n" + "BadSetProperty\t\t750\n" + "CostInitialize\t\t800\n" + "FileCost\t\t900\n" + "CostFinalize\t\t1000\n" + "InstallValidate\t\t1400\n" + "InstallInitialize\t\t1500\n" + "ProcessComponents\t\t1600\n" + "UnpublishFeatures\t\t1800\n" + "InstallFiles\t\t4000\n" + "RegisterProduct\t\t6100\n" + "PublishFeatures\t\t6300\n" + "PublishProduct\t\t6400\n" + "InstallFinalize\t\t6600"; + +static const CHAR ca51_custom_action_dat[] = "Action\tType\tSource\tTarget\n" + "s72\ti2\tS64\tS0\n" + "CustomAction\tAction\n" + "GoodSetProperty\t51\tMYPROP\t42\n" + "BadSetProperty\t51\t\tMYPROP\n"; + typedef struct _msi_table { const CHAR *filename; @@ -928,6 +958,19 @@ static const msi_table sf_tables[] = ADD_TABLE(property), }; +static const msi_table ca51_tables[] = +{ + ADD_TABLE(ca51_component), + ADD_TABLE(directory), + ADD_TABLE(rof_feature), + ADD_TABLE(ci2_feature_comp), + ADD_TABLE(ci2_file), + ADD_TABLE(ca51_install_exec_seq), + ADD_TABLE(rof_media), + ADD_TABLE(property), + ADD_TABLE(ca51_custom_action), +}; + /* cabinet definitions */ /* make the max size large so there is only one cab file */ @@ -4250,6 +4293,27 @@ static void test_sourcefolder(void) DeleteFile("augustus"); } +static void test_customaction51(void) +{ + UINT r; + + CreateDirectoryA("msitest", NULL); + create_file("msitest\\augustus", 500); + + create_database(msifile, ca51_tables, sizeof(ca51_tables) / sizeof(msi_table)); + + MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); + + r = MsiInstallProductA(msifile, NULL); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); + ok(delete_pf("msitest\\augustus", TRUE), "File installed\n"); + ok(delete_pf("msitest", FALSE), "File installed\n"); + + DeleteFile(msifile); + DeleteFile("msitest\\augustus"); + RemoveDirectory("msitest"); +} + START_TEST(install) { DWORD len; @@ -4299,6 +4363,7 @@ START_TEST(install) test_duplicatefiles(); test_writeregistryvalues(); test_sourcefolder(); + test_customaction51(); SetCurrentDirectoryA(prev_path); }

1 0

James Hawkins : msi: Fix an off-by-one error when applying embedded transforms.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 776a7d7065bbc8de1a0431b1a1a6a1e5779373b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=776a7d7065bbc8de1a0431b1a… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Mar 10 23:03:50 2008 -0500 msi: Fix an off-by-one error when applying embedded transforms. --- dlls/msi/action.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 04ccef5..cfef958 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -565,7 +565,7 @@ static UINT msi_apply_transforms( MSIPACKAGE *package ) for( i=0; xforms && xforms[i] && r == ERROR_SUCCESS; i++ ) { if (xforms[i][0] == ':') - r = msi_apply_substorage_transform( package, package->db, &xforms[i][1] ); + r = msi_apply_substorage_transform( package, package->db, xforms[i] ); else r = MSI_DatabaseApplyTransformW( package->db, xforms[i], 0 ); }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2008