winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2008
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
722 discussions
Start a n
N
ew thread
Nikolay Sivov : gdiplus: Let GdipDrawArcI use float args version.
by Alexandre Julliard
08 May '08
08 May '08
Module: wine Branch: master Commit: a77dc34b41482c31989e9b664dc35bb7570c8692 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a77dc34b41482c31989e9b664…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu May 8 00:39:05 2008 +0400 gdiplus: Let GdipDrawArcI use float args version. --- dlls/gdiplus/graphics.c | 17 +---------------- 1 files changed, 1 insertions(+), 16 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 416741c..a86a015 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -932,22 +932,7 @@ GpStatus WINGDIPAPI GdipDrawArc(GpGraphics *graphics, GpPen *pen, REAL x, GpStatus WINGDIPAPI GdipDrawArcI(GpGraphics *graphics, GpPen *pen, INT x, INT y, INT width, INT height, REAL startAngle, REAL sweepAngle) { - INT save_state, num_pts; - GpPointF points[MAX_ARC_PTS]; - GpStatus retval; - - if(!graphics || !pen || width <= 0 || height <= 0) - return InvalidParameter; - - num_pts = arc2polybezier(points, x, y, width, height, startAngle, sweepAngle); - - save_state = prepare_dc(graphics, pen); - - retval = draw_polybezier(graphics, pen, points, num_pts, TRUE); - - restore_dc(graphics, save_state); - - return retval; + return GdipDrawArc(graphics,pen,(REAL)x,(REAL)y,(REAL)width,(REAL)height,startAngle,sweepAngle); } GpStatus WINGDIPAPI GdipDrawBezier(GpGraphics *graphics, GpPen *pen, REAL x1,
1
0
0
0
Vitaly Lipatov : wineboot: Add missed short option -u.
by Alexandre Julliard
08 May '08
08 May '08
Module: wine Branch: master Commit: 6bca330d4d41b86a9703a124489196fd90eed9a6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6bca330d4d41b86a9703a1244…
Author: Vitaly Lipatov <lav(a)etersoft.ru> Date: Wed May 7 23:02:56 2008 +0400 wineboot: Add missed short option -u. --- programs/wineboot/wineboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index a682e65..717a175 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -798,7 +798,7 @@ static void usage(void) WINE_MESSAGE( " -u,--update Update the wineprefix directory\n" ); } -static const char short_options[] = "efhikrs"; +static const char short_options[] = "efhikrsu"; static const struct option long_options[] = {
1
0
0
0
Alexandre Julliard : ntdll: Ignore failures to retrieve serial status for events we are not interested in .
by Alexandre Julliard
08 May '08
08 May '08
Module: wine Branch: master Commit: 03fbe0163294d1af2418ade46210f6ed6dc37e39 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=03fbe0163294d1af2418ade46…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 7 21:10:39 2008 +0200 ntdll: Ignore failures to retrieve serial status for events we are not interested in. Based on a patch by Valentine Sinitsyn. --- dlls/ntdll/serial.c | 41 +++++++++++++++++++++++------------------ 1 files changed, 23 insertions(+), 18 deletions(-) diff --git a/dlls/ntdll/serial.c b/dlls/ntdll/serial.c index 3e1c071..bdb47e4 100644 --- a/dlls/ntdll/serial.c +++ b/dlls/ntdll/serial.c @@ -287,18 +287,13 @@ static NTSTATUS get_line_control(int fd, SERIAL_LINE_CONTROL* slc) static NTSTATUS get_modem_status(int fd, DWORD* lpModemStat) { - NTSTATUS status = STATUS_SUCCESS; + NTSTATUS status = STATUS_NOT_SUPPORTED; int mstat; + *lpModemStat = 0; #ifdef TIOCMGET - if (ioctl(fd, TIOCMGET, &mstat) == -1) - { - WARN("ioctl failed\n"); - status = FILE_GetNtStatus(); - } - else + if (!ioctl(fd, TIOCMGET, &mstat)) { - *lpModemStat = 0; #ifdef TIOCM_CTS if (mstat & TIOCM_CTS) *lpModemStat |= MS_CTS_ON; #endif @@ -317,9 +312,10 @@ static NTSTATUS get_modem_status(int fd, DWORD* lpModemStat) (*lpModemStat & MS_RING_ON) ? "MS_RING_ON " : "", (*lpModemStat & MS_DSR_ON) ? "MS_DSR_ON " : "", (*lpModemStat & MS_CTS_ON) ? "MS_CTS_ON " : ""); + return STATUS_SUCCESS; } -#else - status = STATUS_NOT_SUPPORTED; + WARN("ioctl failed\n"); + status = FILE_GetNtStatus(); #endif return status; } @@ -873,6 +869,7 @@ typedef struct async_commio */ static NTSTATUS get_irq_info(int fd, serial_irq_info *irq_info) { + NTSTATUS status = STATUS_NOT_IMPLEMENTED; #ifdef TIOCGICOUNT struct serial_icounter_struct einfo; if (!ioctl(fd, TIOCGICOUNT, &einfo)) @@ -887,11 +884,10 @@ static NTSTATUS get_irq_info(int fd, serial_irq_info *irq_info) return STATUS_SUCCESS; } TRACE("TIOCGICOUNT err %s\n", strerror(errno)); - return FILE_GetNtStatus(); -#else - memset(irq_info,0, sizeof(serial_irq_info)); - return STATUS_NOT_IMPLEMENTED; + status = FILE_GetNtStatus(); #endif + memset(irq_info,0, sizeof(serial_irq_info)); + return status; } @@ -1050,15 +1046,24 @@ static NTSTATUS wait_on(HANDLE hDevice, int fd, HANDLE hEvent, DWORD* events) #endif if (commio->evtmask & EV_RXFLAG) FIXME("EV_RXFLAG not handled\n"); - if ((status = get_irq_info(fd, &commio->irq_info)) || - (status = get_modem_status(fd, &commio->mstat))) - goto out_now; + + if ((status = get_irq_info(fd, &commio->irq_info)) && + (commio->evtmask & (EV_BREAK | EV_ERR))) + goto out_now; + + if ((status = get_modem_status(fd, &commio->mstat)) && + (commio->evtmask & (EV_CTS | EV_DSR| EV_RING| EV_RLSD))) + goto out_now; /* We might have received something or the TX buffer is delivered */ *events = check_events(fd, commio->evtmask, &commio->irq_info, &commio->irq_info, commio->mstat, commio->mstat); - if (*events) goto out_now; + if (*events) + { + status = STATUS_SUCCESS; + goto out_now; + } /* create the worker for the task */ status = RtlQueueWorkItem(wait_for_event, commio, 0 /* FIXME */);
1
0
0
0
Maarten Lankhorst : ntdll: Fix file test to not free memory allocated on the stack.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: b574c11582eac45499e7a78fcbe654ad897dd94b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b574c11582eac45499e7a78fc…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Wed May 7 11:05:13 2008 -0700 ntdll: Fix file test to not free memory allocated on the stack. --- dlls/ntdll/tests/file.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 8d2ffc3..7b88b01 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -39,7 +39,6 @@ #endif static VOID (WINAPI *pRtlInitUnicodeString)( PUNICODE_STRING, LPCWSTR ); -static VOID (WINAPI *pRtlFreeUnicodeString)(PUNICODE_STRING); static NTSTATUS (WINAPI *pNtCreateMailslotFile)( PHANDLE, ULONG, POBJECT_ATTRIBUTES, PIO_STATUS_BLOCK, ULONG, ULONG, ULONG, PLARGE_INTEGER ); static NTSTATUS (WINAPI *pNtReadFile)(HANDLE hFile, HANDLE hEvent, @@ -467,8 +466,6 @@ static void nt_mailslot_test(void) rc = pNtClose(hslot); ok( rc == STATUS_SUCCESS, "NtClose failed\n"); - - pRtlFreeUnicodeString(&str); } static void test_iocp_setcompletion(HANDLE h) @@ -611,7 +608,6 @@ START_TEST(file) return; } - pRtlFreeUnicodeString = (void *)GetProcAddress(hntdll, "RtlFreeUnicodeString"); pRtlInitUnicodeString = (void *)GetProcAddress(hntdll, "RtlInitUnicodeString"); pNtCreateMailslotFile = (void *)GetProcAddress(hntdll, "NtCreateMailslotFile"); pNtReadFile = (void *)GetProcAddress(hntdll, "NtReadFile");
1
0
0
0
Maarten Lankhorst : ntdll: Fix some exception tests to pass on Windows.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: 9c509234bc7d3d615da60b80e5c7c528d5858c0c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9c509234bc7d3d615da60b80e…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Wed May 7 10:41:52 2008 -0700 ntdll: Fix some exception tests to pass on Windows. --- dlls/ntdll/tests/exception.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index d6168ee..80a8fbd 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -105,7 +105,7 @@ static const struct exception /* test loading an invalid selector */ { { 0xb8, 0xef, 0xbe, 0x00, 0x00, 0x8e, 0xe8, 0xc3 }, /* mov $beef,%ax; mov %ax,%gs; ret */ - 5, 2, STATUS_ACCESS_VIOLATION, 2, { 0, 0xbee8 } }, + 5, 2, STATUS_ACCESS_VIOLATION, 2, { 0, 0xbee8 } }, /* 0xbee8 or 0xffffffff */ /* test accessing a zero selector */ { { 0x06, 0x31, 0xc0, 0x8e, 0xc0, 0x26, 0xa1, 0, 0, 0, 0, 0x07, 0xc3 }, @@ -358,6 +358,14 @@ static DWORD handler( EXCEPTION_RECORD *rec, EXCEPTION_REGISTRATION_RECORD *fram goto skip_params; } + /* Seems that both 0xbee8 and 0xfffffffff can be returned in windows */ + if (except->nb_params == 2 && rec->NumberParameters == 2 + && except->params[1] == 0xbee8 && rec->ExceptionInformation[1] == 0xffffffff + && except->params[0] == rec->ExceptionInformation[0]) + { + goto skip_params; + } + for (i = 0; i < rec->NumberParameters; i++) ok( rec->ExceptionInformation[i] == except->params[i], "%u: Wrong parameter %d: %lx/%x\n", @@ -485,7 +493,8 @@ static DWORD direction_flag_handler( EXCEPTION_RECORD *rec, EXCEPTION_REGISTRATI #ifdef __GNUC__ unsigned int flags; __asm__("pushfl; popl %0" : "=r" (flags) ); - ok( !(flags & 0x400), "eflags has DF bit set\n" ); + /* older windows versions don't clear DF properly so don't test */ + if (flags & 0x400) trace( "eflags has DF bit set\n" ); #endif ok( context->EFlags & 0x400, "context eflags has DF bit cleared\n" ); got_exception++;
1
0
0
0
Maarten Lankhorst : rpcrt4: Fix ndr_marshall test failures.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: fd7b277d8ac23706b1c819d2ed1fd0ee9833fd06 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fd7b277d8ac23706b1c819d2e…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Tue May 6 15:06:17 2008 -0700 rpcrt4: Fix ndr_marshall test failures. Created with help from Robert Shearman. --- dlls/rpcrt4/tests/ndr_marshall.c | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c index 72fd1be..1ff5e3b 100644 --- a/dlls/rpcrt4/tests/ndr_marshall.c +++ b/dlls/rpcrt4/tests/ndr_marshall.c @@ -514,7 +514,9 @@ static void test_nontrivial_pointer_types(void) NdrPointerBufferSize( &StubMsg, (unsigned char *)p1, &fmtstr_ref_unique_out[4] ); - ok(StubMsg.BufferLength == 5, "length %d\n", StubMsg.BufferLength); + + /* Windows overestimates the buffer size */ + ok(StubMsg.BufferLength >= 5, "length %d\n", StubMsg.BufferLength); /*NdrGetBuffer(&_StubMsg, _StubMsg.BufferLength, NULL);*/ StubMsg.RpcMsg->Buffer = StubMsg.BufferStart = StubMsg.Buffer = HeapAlloc(GetProcessHeap(), 0, StubMsg.BufferLength); @@ -1706,7 +1708,7 @@ static void test_nonconformant_string(void) static void test_ndr_buffer(void) { static unsigned char ncalrpc[] = "ncalrpc"; - static unsigned char endpoint[] = "winetest:" __FILE__; + static unsigned char endpoint[] = "winetest:test_ndr_buffer"; RPC_MESSAGE RpcMessage; MIDL_STUB_MESSAGE StubMsg; MIDL_STUB_DESC StubDesc = Object_StubDesc; @@ -1717,9 +1719,17 @@ static void test_ndr_buffer(void) StubDesc.RpcInterfaceInformation = (void *)&IFoo___RpcServerInterface; - ok(RPC_S_OK == RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL), "RpcServerUseProtseqEp\n"); - ok(RPC_S_OK == RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL), "RpcServerRegisterIf\n"); - ok(RPC_S_OK == RpcServerListen(1, 20, TRUE), "RpcServerListen\n"); + status = RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL); + ok(RPC_S_OK == status, "RpcServerUseProtseqEp failed with status %lu\n", status); + status = RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL); + ok(RPC_S_OK == status, "RpcServerRegisterIf failed with status %lu\n", status); + status = RpcServerListen(1, 20, TRUE); + ok(RPC_S_OK == status, "RpcServerListen failed with status %lu\n", status); + if (status != RPC_S_OK) + { + /* Failed to create a server, running client tests is useless */ + return; + } status = RpcStringBindingCompose(NULL, ncalrpc, NULL, endpoint, NULL, &binding); ok(status == RPC_S_OK, "RpcStringBindingCompose failed (%lu)\n", status);
1
0
0
0
Rob Shearman : crypt32: Add stub for CertVerifyCTLUsage.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: 9e717aa2e8b03fd1b4a389022571251c99c10933 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9e717aa2e8b03fd1b4a389022…
Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed May 7 17:03:25 2008 +0100 crypt32: Add stub for CertVerifyCTLUsage. --- dlls/crypt32/cert.c | 12 ++++++++++++ dlls/crypt32/crypt32.spec | 2 +- 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/cert.c b/dlls/crypt32/cert.c index 84780cb..41d3998 100644 --- a/dlls/crypt32/cert.c +++ b/dlls/crypt32/cert.c @@ -2574,3 +2574,15 @@ PCCERT_CONTEXT WINAPI CertCreateSelfSignCertificate(HCRYPTPROV_OR_NCRYPT_KEY_HAN CryptReleaseContext(hProv, 0); return context; } + +BOOL WINAPI CertVerifyCTLUsage(DWORD dwEncodingType, DWORD dwSubjectType, + void *pvSubject, PCTL_USAGE pSubjectUsage, DWORD dwFlags, + PCTL_VERIFY_USAGE_PARA pVerifyUsagePara, + PCTL_VERIFY_USAGE_STATUS pVerifyUsageStatus) +{ + FIXME("(0x%x, %d, %p, %p, 0x%x, %p, %p): stub\n", dwEncodingType, + dwSubjectType, pvSubject, pSubjectUsage, dwFlags, pVerifyUsagePara, + pVerifyUsageStatus); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; +} diff --git a/dlls/crypt32/crypt32.spec b/dlls/crypt32/crypt32.spec index 870ee48..b7f45d0 100644 --- a/dlls/crypt32/crypt32.spec +++ b/dlls/crypt32/crypt32.spec @@ -89,7 +89,7 @@ @ stdcall CertVerifyCertificateChainPolicy(str ptr ptr ptr) @ stdcall CertVerifyCRLRevocation(long ptr long ptr) @ stdcall CertVerifyCRLTimeValidity(ptr ptr) -@ stub CertVerifyCTLUsage +@ stdcall CertVerifyCTLUsage(long long ptr ptr long ptr ptr) @ stdcall CertVerifyRevocation(long long long ptr long ptr ptr) @ stdcall CertVerifySubjectCertificateContext(ptr ptr ptr) @ stdcall CertVerifyTimeValidity(ptr ptr)
1
0
0
0
Alexandre Julliard : ntdll: Don' t consider a 0-byte read from a serial port as a broken pipe.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: 152d65c6f34c9973e6d6acece883443746e9b78a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=152d65c6f34c9973e6d6acece…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 7 20:18:09 2008 +0200 ntdll: Don't consider a 0-byte read from a serial port as a broken pipe. --- dlls/ntdll/file.c | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index fd72a61..972d600 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -599,10 +599,22 @@ NTSTATUS WINAPI NtReadFile(HANDLE hFile, HANDLE hEvent, if (!result || total == length) { if (total) + { status = STATUS_SUCCESS; - else - status = (type == FD_TYPE_FILE || type == FD_TYPE_CHAR) ? STATUS_END_OF_FILE : STATUS_PIPE_BROKEN; - goto done; + goto done; + } + switch (type) + { + case FD_TYPE_FILE: + case FD_TYPE_CHAR: + status = STATUS_END_OF_FILE; + goto done; + case FD_TYPE_SERIAL: + break; + default: + status = STATUS_PIPE_BROKEN; + goto done; + } } } else
1
0
0
0
Alexandre Julliard : ntdll: Always set VTIME to 0 to avoid blocking, don' t try to set it from the comm timeouts.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: b1ace4490e8ee820977af528df02117f3583dcfd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b1ace4490e8ee820977af528d…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 7 20:17:32 2008 +0200 ntdll: Always set VTIME to 0 to avoid blocking, don't try to set it from the comm timeouts. --- dlls/ntdll/serial.c | 42 +++++++++--------------------------------- 1 files changed, 9 insertions(+), 33 deletions(-) diff --git a/dlls/ntdll/serial.c b/dlls/ntdll/serial.c index 8155d67..3e1c071 100644 --- a/dlls/ntdll/serial.c +++ b/dlls/ntdll/serial.c @@ -664,6 +664,10 @@ static NTSTATUS set_line_control(int fd, const SERIAL_LINE_CONTROL* slc) port.c_cflag &= ~(PARENB | PARODD); #endif + /* make sure that reads don't block */ + port.c_cc[VMIN] = 0; + port.c_cc[VTIME] = 0; + switch (slc->Parity) { case NOPARITY: port.c_iflag &= ~INPCK; break; @@ -751,9 +755,6 @@ static NTSTATUS set_special_chars(int fd, const SERIAL_CHARS* sc) return FILE_GetNtStatus(); } - port.c_cc[VMIN ] = 0; - port.c_cc[VTIME ] = 1; - port.c_cc[VEOF ] = sc->EofChar; /* FIXME: sc->ErrorChar is not supported */ /* FIXME: sc->BreakChar is not supported */ @@ -769,11 +770,9 @@ static NTSTATUS set_special_chars(int fd, const SERIAL_CHARS* sc) return STATUS_SUCCESS; } -static NTSTATUS set_timeouts(HANDLE handle, int fd, const SERIAL_TIMEOUTS* st) +static NTSTATUS set_timeouts(HANDLE handle, const SERIAL_TIMEOUTS* st) { NTSTATUS status; - struct termios port; - unsigned int ux_timeout; SERVER_START_REQ( set_serial_info ) { @@ -787,31 +786,7 @@ static NTSTATUS set_timeouts(HANDLE handle, int fd, const SERIAL_TIMEOUTS* st) status = wine_server_call( req ); } SERVER_END_REQ; - if (status) return status; - - if (tcgetattr(fd, &port) == -1) - { - FIXME("tcgetattr on fd %d failed (%s)!\n", fd, strerror(errno)); - return FILE_GetNtStatus(); - } - - /* VTIME is in 1/10 seconds */ - if (st->ReadIntervalTimeout == 0) /* 0 means no timeout */ - ux_timeout = 0; - else - { - ux_timeout = (st->ReadIntervalTimeout + 99) / 100; - if (ux_timeout == 0) - ux_timeout = 1; /* must be at least some timeout */ - } - port.c_cc[VTIME] = ux_timeout; - - if (tcsetattr(fd, 0, &port) == -1) - { - FIXME("tcsetattr on fd %d failed (%s)!\n", fd, strerror(errno)); - return FILE_GetNtStatus(); - } - return STATUS_SUCCESS; + return status; } static NTSTATUS set_wait_mask(HANDLE hDevice, DWORD mask) @@ -1132,7 +1107,8 @@ static inline NTSTATUS io_control(HANDLE hDevice, piosb->Information = 0; - if (dwIoControlCode != IOCTL_SERIAL_GET_TIMEOUTS) + if (dwIoControlCode != IOCTL_SERIAL_GET_TIMEOUTS && + dwIoControlCode != IOCTL_SERIAL_SET_TIMEOUTS) if ((status = server_get_unix_fd( hDevice, access, &fd, &needs_close, NULL, NULL ))) goto error; @@ -1307,7 +1283,7 @@ static inline NTSTATUS io_control(HANDLE hDevice, break; case IOCTL_SERIAL_SET_TIMEOUTS: if (lpInBuffer && nInBufferSize == sizeof(SERIAL_TIMEOUTS)) - status = set_timeouts(hDevice, fd, (const SERIAL_TIMEOUTS*)lpInBuffer); + status = set_timeouts(hDevice, (const SERIAL_TIMEOUTS*)lpInBuffer); else status = STATUS_INVALID_PARAMETER; break;
1
0
0
0
Dmitry Timoshkov : gdi32: Implement EMFDRV_SelectPalette.
by Alexandre Julliard
07 May '08
07 May '08
Module: wine Branch: master Commit: 2820682202886cb1fc438ab55b3c39f13baef9bf URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2820682202886cb1fc438ab55…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed May 7 20:35:04 2008 +0900 gdi32: Implement EMFDRV_SelectPalette. --- dlls/gdi32/enhmfdrv/enhmetafiledrv.h | 1 + dlls/gdi32/enhmfdrv/init.c | 2 +- dlls/gdi32/enhmfdrv/objects.c | 55 ++++++++++++++++++++++++++++++++++ 3 files changed, 57 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/enhmfdrv/enhmetafiledrv.h b/dlls/gdi32/enhmfdrv/enhmetafiledrv.h index f1c81a2..c00c653 100644 --- a/dlls/gdi32/enhmfdrv/enhmetafiledrv.h +++ b/dlls/gdi32/enhmfdrv/enhmetafiledrv.h @@ -122,6 +122,7 @@ extern HBRUSH EMFDRV_SelectBrush( PHYSDEV dev, HBRUSH handle ) DECLSPEC_HIDDEN extern BOOL EMFDRV_SelectClipPath( PHYSDEV dev, INT iMode ) DECLSPEC_HIDDEN; extern HFONT EMFDRV_SelectFont( PHYSDEV dev, HFONT handle, HANDLE gdiFont ) DECLSPEC_HIDDEN; extern HPEN EMFDRV_SelectPen( PHYSDEV dev, HPEN handle ) DECLSPEC_HIDDEN; +extern HPALETTE EMFDRV_SelectPalette( PHYSDEV dev, HPALETTE hPal, BOOL force ) DECLSPEC_HIDDEN; extern INT EMFDRV_SetArcDirection( PHYSDEV dev, INT arcDirection ) DECLSPEC_HIDDEN; extern COLORREF EMFDRV_SetBkColor( PHYSDEV dev, COLORREF color ) DECLSPEC_HIDDEN; extern INT EMFDRV_SetBkMode( PHYSDEV dev, INT mode ) DECLSPEC_HIDDEN; diff --git a/dlls/gdi32/enhmfdrv/init.c b/dlls/gdi32/enhmfdrv/init.c index dafac60..de135d2 100644 --- a/dlls/gdi32/enhmfdrv/init.c +++ b/dlls/gdi32/enhmfdrv/init.c @@ -114,7 +114,7 @@ static const DC_FUNCTIONS EMFDRV_Funcs = EMFDRV_SelectBrush, /* pSelectBrush */ EMFDRV_SelectClipPath, /* pSelectClipPath */ EMFDRV_SelectFont, /* pSelectFont */ - NULL, /* pSelectPalette */ + EMFDRV_SelectPalette, /* pSelectPalette */ EMFDRV_SelectPen, /* pSelectPen */ EMFDRV_SetArcDirection, /* pSetArcDirection */ NULL, /* pSetBitmapBits */ diff --git a/dlls/gdi32/enhmfdrv/objects.c b/dlls/gdi32/enhmfdrv/objects.c index c7ecd54..54c34bf 100644 --- a/dlls/gdi32/enhmfdrv/objects.c +++ b/dlls/gdi32/enhmfdrv/objects.c @@ -465,6 +465,61 @@ HPEN EMFDRV_SelectPen(PHYSDEV dev, HPEN hPen ) /****************************************************************** + * EMFDRV_CreatePalette + */ +static DWORD EMFDRV_CreatePalette(PHYSDEV dev, HPALETTE hPal) +{ + WORD i; + struct { + EMRCREATEPALETTE hdr; + PALETTEENTRY entry[255]; + } pal; + + memset( &pal, 0, sizeof(pal) ); + + if (!GetObjectW( hPal, sizeof(pal.hdr.lgpl) + sizeof(pal.entry), &pal.hdr.lgpl )) + return 0; + + for (i = 0; i < pal.hdr.lgpl.palNumEntries; i++) + pal.hdr.lgpl.palPalEntry[i].peFlags = 0; + + pal.hdr.emr.iType = EMR_CREATEPALETTE; + pal.hdr.emr.nSize = sizeof(pal.hdr) + pal.hdr.lgpl.palNumEntries * sizeof(PALETTEENTRY); + pal.hdr.ihPal = EMFDRV_AddHandle( dev, hPal ); + + if (!EMFDRV_WriteRecord( dev, &pal.hdr.emr )) + pal.hdr.ihPal = 0; + return pal.hdr.ihPal; +} + +/****************************************************************** + * EMFDRV_SelectPalette + */ +HPALETTE EMFDRV_SelectPalette( PHYSDEV dev, HPALETTE hPal, BOOL force ) +{ + EMFDRV_PDEVICE *physDev = (EMFDRV_PDEVICE*)dev; + EMRSELECTPALETTE emr; + DWORD index; + + if (hPal == GetStockObject( DEFAULT_PALETTE )) + index = DEFAULT_PALETTE | 0x80000000; + goto found; + + if ((index = EMFDRV_FindObject( dev, hPal )) != 0) + goto found; + + if (!(index = EMFDRV_CreatePalette( dev, hPal ))) return 0; + GDI_hdc_using_object( hPal, physDev->hdc ); + +found: + emr.emr.iType = EMR_SELECTPALETTE; + emr.emr.nSize = sizeof(emr); + emr.ihPal = index; + return EMFDRV_WriteRecord( dev, &emr.emr ) ? hPal : 0; +} + + +/****************************************************************** * EMFDRV_GdiComment */ BOOL EMFDRV_GdiComment(PHYSDEV dev, UINT bytes, CONST BYTE *buffer)
1
0
0
0
← Newer
1
...
44
45
46
47
48
49
50
...
73
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
Results per page:
10
25
50
100
200