winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2008
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1114 discussions
Start a n
N
ew thread
Andrew Talbot : crypt32: Remove unneeded address-of operator from array name.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 2b8bf17a0831dff9ff962cf4240a24bd35251111 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2b8bf17a0831dff9ff962cf42…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Wed Jul 9 20:36:45 2008 +0100 crypt32: Remove unneeded address-of operator from array name. --- dlls/crypt32/decode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c index 47b0ba6..3ac3ebb 100644 --- a/dlls/crypt32/decode.c +++ b/dlls/crypt32/decode.c @@ -3147,7 +3147,7 @@ static BOOL CRYPT_AsnDecodeIntInternal(const BYTE *pbEncoded, DWORD cbEncoded, DWORD size = sizeof(buf); blob->pbData = buf + sizeof(CRYPT_INTEGER_BLOB); - ret = CRYPT_AsnDecodeIntegerInternal(pbEncoded, cbEncoded, 0, &buf, + ret = CRYPT_AsnDecodeIntegerInternal(pbEncoded, cbEncoded, 0, buf, &size, pcbDecoded); if (ret) {
1
0
0
0
Andrew Talbot : comdlg32: Remove unneeded address-of operator from array name.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 468f709cbe19df6919c22d7d480572008cdc15c1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=468f709cbe19df6919c22d7d4…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Wed Jul 9 20:36:41 2008 +0100 comdlg32: Remove unneeded address-of operator from array name. --- dlls/comdlg32/filedlg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index 618fc22..dd47528 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -1164,7 +1164,7 @@ static LRESULT FILEDLG95_InitControls(HWND hwnd) SendMessageW(fodInfos->DlgInfos.hwndTB, TB_ADDBITMAP, 12, (LPARAM) &tba[0]); SendMessageW(fodInfos->DlgInfos.hwndTB, TB_ADDBITMAP, 1, (LPARAM) &tba[1]); - SendMessageW(fodInfos->DlgInfos.hwndTB, TB_ADDBUTTONSW, 9, (LPARAM) &tbb); + SendMessageW(fodInfos->DlgInfos.hwndTB, TB_ADDBUTTONSW, 9, (LPARAM) tbb); SendMessageW(fodInfos->DlgInfos.hwndTB, TB_AUTOSIZE, 0, 0); /* Set the window text with the text specified in the OPENFILENAME structure */
1
0
0
0
Francois Gouget : wined3d: Move float_32_to_16() to surface_base. c which is the only place where it's used, and because it needs port. h for isinf().
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 8320d214d470876efb4a7377fa88e5ba91776ff5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8320d214d470876efb4a7377f…
Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Jul 10 00:23:07 2008 +0200 wined3d: Move float_32_to_16() to surface_base.c which is the only place where it's used, and because it needs port.h for isinf(). --- dlls/wined3d/surface_base.c | 51 ++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h | 51 +-------------------------------------- 2 files changed, 53 insertions(+), 49 deletions(-) diff --git a/dlls/wined3d/surface_base.c b/dlls/wined3d/surface_base.c index 7536706..183cd2b 100644 --- a/dlls/wined3d/surface_base.c +++ b/dlls/wined3d/surface_base.c @@ -34,6 +34,57 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d_surface); +/* See also float_16_to_32() in wined3d_private.h */ +static inline unsigned short float_32_to_16(const float *in) +{ + int exp = 0; + float tmp = fabs(*in); + unsigned int mantissa; + unsigned short ret; + + /* Deal with special numbers */ + if(*in == 0.0) return 0x0000; + if(isnan(*in)) return 0x7C01; + if(isinf(*in)) return (*in < 0.0 ? 0xFC00 : 0x7c00); + + if(tmp < pow(2, 10)) { + do + { + tmp = tmp * 2.0; + exp--; + }while(tmp < pow(2, 10)); + } else if(tmp >= pow(2, 11)) { + do + { + tmp /= 2.0; + exp++; + }while(tmp >= pow(2, 11)); + } + + mantissa = (unsigned int) tmp; + if(tmp - mantissa >= 0.5) mantissa++; /* round to nearest, away from zero */ + + exp += 10; /* Normalize the mantissa */ + exp += 15; /* Exponent is encoded with excess 15 */ + + if(exp > 30) { /* too big */ + ret = 0x7c00; /* INF */ + } else if(exp <= 0) { + /* exp == 0: Non-normalized mantissa. Returns 0x0000 (=0.0) for too small numbers */ + while(exp <= 0) { + mantissa = mantissa >> 1; + exp++; + } + ret = mantissa & 0x3ff; + } else { + ret = (exp << 10) | (mantissa & 0x3ff); + } + + ret |= ((*in < 0.0 ? 1 : 0) << 15); /* Add the sign */ + return ret; +} + + /* Do NOT define GLINFO_LOCATION in this file. THIS CODE MUST NOT USE IT */ /* ******************************************* diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 808d9bf..b11a3f5 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -126,7 +126,8 @@ void init_type_lookup(WineD3D_GL_Info *gl_info); #define WINED3D_ATR_NORMALIZED(type) GLINFO_LOCATION.glTypeLookup[type].normalized #define WINED3D_ATR_TYPESIZE(type) GLINFO_LOCATION.glTypeLookup[type].typesize -/* The following functions convert 16 bit floats in the FLOAT16 data type +/* float_16_to_32() and float_32_to_16() (see implementation in + * surface_base.c) convert 16 bit floats in the FLOAT16 data type * to standard C floats and vice versa. They do not depend on the encoding * of the C float, so they are platform independent, but slow. On x86 and * other IEEE 754 compliant platforms the conversion can be accelerated by @@ -152,54 +153,6 @@ static inline float float_16_to_32(const unsigned short *in) { } } -static inline unsigned short float_32_to_16(const float *in) { - int exp = 0; - float tmp = fabs(*in); - unsigned int mantissa; - unsigned short ret; - - /* Deal with special numbers */ - if(*in == 0.0) return 0x0000; - if(isnan(*in)) return 0x7C01; - if(isinf(*in)) return (*in < 0.0 ? 0xFC00 : 0x7c00); - - if(tmp < pow(2, 10)) { - do - { - tmp = tmp * 2.0; - exp--; - }while(tmp < pow(2, 10)); - } else if(tmp >= pow(2, 11)) { - do - { - tmp /= 2.0; - exp++; - }while(tmp >= pow(2, 11)); - } - - mantissa = (unsigned int) tmp; - if(tmp - mantissa >= 0.5) mantissa++; /* round to nearest, away from zero */ - - exp += 10; /* Normalize the mantissa */ - exp += 15; /* Exponent is encoded with excess 15 */ - - if(exp > 30) { /* too big */ - ret = 0x7c00; /* INF */ - } else if(exp <= 0) { - /* exp == 0: Non-normalized mantissa. Returns 0x0000 (=0.0) for too small numbers */ - while(exp <= 0) { - mantissa = mantissa >> 1; - exp++; - } - ret = mantissa & 0x3ff; - } else { - ret = (exp << 10) | (mantissa & 0x3ff); - } - - ret |= ((*in < 0.0 ? 1 : 0) << 15); /* Add the sign */ - return ret; -} - /** * Settings */
1
0
0
0
Francois Gouget : rpcss: Add a trailing '\n' to a Wine trace.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 888cf5a4af96814d69056f63e41329466af6d2a6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=888cf5a4af96814d69056f63e…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jul 10 00:26:43 2008 +0200 rpcss: Add a trailing '\n' to a Wine trace. --- programs/rpcss/epmp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/rpcss/epmp.c b/programs/rpcss/epmp.c index cf14be8..e731e06 100644 --- a/programs/rpcss/epmp.c +++ b/programs/rpcss/epmp.c @@ -86,7 +86,7 @@ static struct registered_ept_entry *find_ept_entry( void __RPC_USER ept_lookup_handle_t_rundown(ept_lookup_handle_t entry_handle) { - WINE_FIXME("%p", entry_handle); + WINE_FIXME("%p\n", entry_handle); } void ept_insert(handle_t h,
1
0
0
0
Francois Gouget : gdiplus/tests: Spelling fix.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 4b1f6310d96c6da4e6a13d117fa4ed247f63c6ec URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4b1f6310d96c6da4e6a13d117…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jul 10 00:24:46 2008 +0200 gdiplus/tests: Spelling fix. --- dlls/gdiplus/tests/font.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 8bf1289..96ed64c 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -25,7 +25,7 @@ #define expect(expected, got) ok(got == expected, "Expected %.8x, got %.8x\n", expected, got) static const WCHAR arial[] = {'A','r','i','a','l','\0'}; -static const WCHAR nonexistant[] = {'T','h','i','s','F','o','n','t','s','h','o','u','l','d','N','o','t','E','x','i','s','t','\0'}; +static const WCHAR nonexistent[] = {'T','h','i','s','F','o','n','t','s','h','o','u','l','d','N','o','t','E','x','i','s','t','\0'}; static const WCHAR MSSansSerif[] = {'M','S',' ','S','a','n','s',' ','S','e','r','i','f','\0'}; static const WCHAR MicrosoftSansSerif[] = {'M','i','c','r','o','s','o','f','t',' ','S','a','n','s',' ','S','e','r','i','f','\0'}; static const WCHAR TimesNewRoman[] = {'T','i','m','e','s',' ','N','e','w',' ','R','o','m','a','n','\0'}; @@ -48,7 +48,7 @@ static void test_createfont(void) UINT i; REAL size; - stat = GdipCreateFontFamilyFromName(nonexistant, NULL, &fontfamily); + stat = GdipCreateFontFamilyFromName(nonexistent, NULL, &fontfamily); expect (FontFamilyNotFound, stat); stat = GdipDeleteFont(font); expect (InvalidParameter, stat); @@ -161,10 +161,10 @@ static void test_fontfamily (void) /* FontFamily must be able to actually find the family. * If it can't, any subsequent calls should fail. */ - stat = GdipCreateFontFamilyFromName (nonexistant, NULL, &family); + stat = GdipCreateFontFamilyFromName (nonexistent, NULL, &family); expect (FontFamilyNotFound, stat); - ok ((lstrcmpiW(itsName, nonexistant) != 0), - "Expected a non-zero value for nonexistant font!\n"); + ok ((lstrcmpiW(itsName, nonexistent) != 0), + "Expected a non-zero value for nonexistent font!\n"); /* Bitmap fonts are not found */ todo_wine
1
0
0
0
Francois Gouget : msxml3/tests: Add a trailing '\n' to ok() calls.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: c3a952eb485597541736ba0e75880f9449b7e43a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c3a952eb485597541736ba0e7…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jul 10 00:23:43 2008 +0200 msxml3/tests: Add a trailing '\n' to ok() calls. --- dlls/msxml3/tests/domdoc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index f914e09..3745fca 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -1170,17 +1170,17 @@ todo_wine ok( r == E_INVALIDARG, "ret %08x\n", r ); r = IXMLDOMNodeList_get_item(list, 0, NULL); - ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x", r); + ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x\n", r); r = IXMLDOMNodeList_get_length(list, NULL); - ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x", r); + ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x\n", r); r = IXMLDOMNodeList_get_length( list, &count ); ok( r == S_OK, "get_length returns %08x\n", r ); ok( count == 4, "get_length got %ld\n", count ); r = IXMLDOMNodeList_nextNode(list, NULL); - ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x", r); + ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x\n", r); r = IXMLDOMNodeList_nextNode( list, &node ); ok( r == S_OK, "nextNode returned wrong code\n");
1
0
0
0
Francois Gouget : winhlp32: Remove spaces before '...'.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: bfc133f19b7c7d38bbdcc02803e2f3d832a87f63 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bfc133f19b7c7d38bbdcc0280…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jul 10 00:20:50 2008 +0200 winhlp32: Remove spaces before '...'. --- programs/winhlp32/No.rc | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/programs/winhlp32/No.rc b/programs/winhlp32/No.rc index 2301c7c..b31df01 100644 --- a/programs/winhlp32/No.rc +++ b/programs/winhlp32/No.rc @@ -26,17 +26,17 @@ MAIN_MENU MENU LANGUAGE LANG_NORWEGIAN, SUBLANG_NORWEGIAN_BOKMAL MENUITEM "&�pne", MNID_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Skriv &ut", MNID_FILE_PRINT - MENUITEM "Opp&sett av skriveren ...", MNID_FILE_SETUP + MENUITEM "Opp&sett av skriveren...", MNID_FILE_SETUP MENUITEM SEPARATOR MENUITEM "&Avslutt", MNID_FILE_EXIT } POPUP "R&ediger" { - MENUITEM "&Kopier ...", MNID_EDIT_COPYDLG + MENUITEM "&Kopier...", MNID_EDIT_COPYDLG MENUITEM SEPARATOR - MENUITEM "K&ommenter ...", MNID_EDIT_ANNOTATE + MENUITEM "K&ommenter...", MNID_EDIT_ANNOTATE } POPUP "&Bokmerke" { - MENUITEM "&Definer ...", MNID_BKMK_DEFINE + MENUITEM "&Definer...", MNID_BKMK_DEFINE } POPUP "&Innstillinger" { POPUP "Synlighet" @@ -58,7 +58,7 @@ MAIN_MENU MENU LANGUAGE LANG_NORWEGIAN, SUBLANG_NORWEGIAN_BOKMAL MENUITEM "&Hjelp til Hjelp", MNID_HELP_HELPON MENUITEM "All&tid �verst", MNID_HELP_HELPTOP MENUITEM SEPARATOR - MENUITEM "&Informasjon ...", MNID_HELP_ABOUT + MENUITEM "&Informasjon...", MNID_HELP_ABOUT #ifdef WINELIB MENUITEM "&Om Wine", MNID_HELP_WINE #endif @@ -98,9 +98,9 @@ CONTEXT_MENU MENU LANGUAGE LANG_NORWEGIAN, SUBLANG_NORWEGIAN_BOKMAL BEGIN POPUP "" BEGIN - MENUITEM "Kommentar ...", MNID_CTXT_ANNOTATE + MENUITEM "Kommentar...", MNID_CTXT_ANNOTATE MENUITEM "Kopier", MNID_CTXT_COPY - MENUITEM "Skriv ut ...", MNID_CTXT_PRINT + MENUITEM "Skriv ut...", MNID_CTXT_PRINT POPUP "Skriftst�rrelse" BEGIN MENUITEM "Liten", MNID_CTXT_FONTS_SMALL
1
0
0
0
Maarten Lankhorst : quartz: Fix deadlocks in dsound renderer.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: adcf93aeaf446d657685cee8976365980499fb69 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=adcf93aeaf446d657685cee89…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Wed Jul 9 10:21:30 2008 -0700 quartz: Fix deadlocks in dsound renderer. --- dlls/quartz/dsoundrender.c | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index 618f073..7a6ec3d 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -265,6 +265,7 @@ static HRESULT DSoundRender_Sample(LPVOID iface, IMediaSample * pSample) if (FAILED(hr)) { ERR("Cannot get pointer to sample data (%x)\n", hr); + LeaveCriticalSection(&This->csFilter); return hr; } @@ -281,6 +282,7 @@ static HRESULT DSoundRender_Sample(LPVOID iface, IMediaSample * pSample) if (IMediaSample_IsPreroll(pSample) == S_OK) { TRACE("Preroll!\n"); + LeaveCriticalSection(&This->csFilter); return S_OK; } @@ -298,6 +300,7 @@ static HRESULT DSoundRender_Sample(LPVOID iface, IMediaSample * pSample) if (This->state == State_Paused) { /* Assuming we return because of flushing */ + TRACE("Flushing\n"); LeaveCriticalSection(&This->csFilter); return S_OK; } @@ -887,7 +890,12 @@ static HRESULT WINAPI DSoundRender_InputPin_EndOfStream(IPin * iface) EnterCriticalSection(This->pin.pCritSec); TRACE("(%p/%p)->()\n", This, iface); - InputPin_EndOfStream(iface); + hr = InputPin_EndOfStream(iface); + if (hr != S_OK) + { + ERR("%08x\n", hr); + return hr; + } hr = IFilterGraph_QueryInterface(me->filterInfo.pGraph, &IID_IMediaEventSink, (LPVOID*)&pEventSink); if (SUCCEEDED(hr))
1
0
0
0
Michael Stefaniuc : quartz: Compare a file handle to INVALID_HANDLE_VALUE and not NULL.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: 310b58994cae46289b0b685b276814d68fecec98 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=310b58994cae46289b0b685b2…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jul 9 23:54:28 2008 +0200 quartz: Compare a file handle to INVALID_HANDLE_VALUE and not NULL. --- dlls/quartz/tests/avisplitter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/quartz/tests/avisplitter.c b/dlls/quartz/tests/avisplitter.c index 3dd1615..d3cdaac 100644 --- a/dlls/quartz/tests/avisplitter.c +++ b/dlls/quartz/tests/avisplitter.c @@ -203,7 +203,7 @@ static void test_threads() file = CreateFileW(wfile, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL); - if (!file) + if (file == INVALID_HANDLE_VALUE) { skip("Could not read test file \"%s\", skipping test\n", afile); return;
1
0
0
0
Jacek Caban : shlwapi: Fixed handling mk protocol URLs in UrlCombineW.
by Alexandre Julliard
10 Jul '08
10 Jul '08
Module: wine Branch: master Commit: c086429465cbe9387349ef6835dfa4ac1b33e654 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c086429465cbe9387349ef683…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jul 9 20:02:23 2008 +0200 shlwapi: Fixed handling mk protocol URLs in UrlCombineW. --- dlls/shlwapi/tests/url.c | 2 ++ dlls/shlwapi/url.c | 42 +++++++++++++++++++++--------------------- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index 4eb581f..ede4d7c 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -234,6 +234,8 @@ static const TEST_URL_COMBINE TEST_COMBINE[] = { {"foo:today", "bar:calendar", 0, S_OK, "bar:calendar"}, {"foo:/today", "foo:calendar", 0, S_OK, "foo:/calendar"}, {"foo:/today/", "foo:calendar", 0, S_OK, "foo:/today/calendar"}, + {"mk:@MSITStore:dir/test.chm::dir/index.html", "image.jpg", 0, S_OK, "mk:@MSITStore:dir/test.chm::dir/image.jpg"}, + {"mk:@MSITStore:dir/test.chm::dir/dir2/index.html", "../image.jpg", 0, S_OK, "mk:@MSITStore:dir/test.chm::dir/image.jpg"} }; /* ################ */ diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c index 00d319d..03941a9 100644 --- a/dlls/shlwapi/url.c +++ b/dlls/shlwapi/url.c @@ -659,29 +659,29 @@ HRESULT WINAPI UrlCombineW(LPCWSTR pszBase, LPCWSTR pszRelative, base.pszSuffix += delta; base.cchSuffix -= delta; } - } - - /* get size of location field (if it exists) */ - work = (LPWSTR)base.pszSuffix; - sizeloc = 0; - if (*work++ == '/') { + }else { + /* get size of location field (if it exists) */ + work = (LPWSTR)base.pszSuffix; + sizeloc = 0; if (*work++ == '/') { - /* At this point have start of location and - * it ends at next '/' or end of string. - */ - while(*work && (*work != '/')) work++; - sizeloc = (DWORD)(work - base.pszSuffix); - } - } + if (*work++ == '/') { + /* At this point have start of location and + * it ends at next '/' or end of string. + */ + while(*work && (*work != '/')) work++; + sizeloc = (DWORD)(work - base.pszSuffix); + } + } + } - /* Change .sizep2 to not have the last leaf in it, - * Note: we need to start after the location (if it exists) - */ + /* Change .sizep2 to not have the last leaf in it, + * Note: we need to start after the location (if it exists) + */ work = strrchrW((base.pszSuffix+sizeloc), '/'); - if (work) { - len = (DWORD)(work - base.pszSuffix + 1); - base.cchSuffix = len; - } + if (work) { + len = (DWORD)(work - base.pszSuffix + 1); + base.cchSuffix = len; + } /* * At this point: @@ -723,7 +723,7 @@ HRESULT WINAPI UrlCombineW(LPCWSTR pszBase, LPCWSTR pszRelative, process_case = 4; break; } - process_case = (*base.pszSuffix == '/') ? 5 : 3; + process_case = (*base.pszSuffix == '/' || base.nScheme == URL_SCHEME_MK) ? 5 : 3; break; }
1
0
0
0
← Newer
1
...
68
69
70
71
72
73
74
...
112
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
Results per page:
10
25
50
100
200