winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2008
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1114 discussions
Start a n
N
ew thread
Nikolay Sivov : gdiplus: GdipPathIterNextMarker implementation with tests.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 0a9937c534823df161f0b911dd410a508ea4a148 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0a9937c534823df161f0b911d…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat Jul 5 13:02:36 2008 +0400 gdiplus: GdipPathIterNextMarker implementation with tests. --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/pathiterator.c | 25 ++++++++++++++++ dlls/gdiplus/tests/pathiterator.c | 57 +++++++++++++++++++++++++++++++++++++ include/gdiplusflat.h | 1 + 4 files changed, 84 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index 9492065..df28863 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -456,7 +456,7 @@ @ stub GdipPathIterGetSubpathCount @ stdcall GdipPathIterHasCurve(ptr ptr) @ stub GdipPathIterIsValid -@ stub GdipPathIterNextMarker +@ stdcall GdipPathIterNextMarker(ptr ptr ptr ptr) @ stub GdipPathIterNextMarkerPath @ stub GdipPathIterNextPathType @ stdcall GdipPathIterNextSubpath(ptr ptr ptr ptr ptr) diff --git a/dlls/gdiplus/pathiterator.c b/dlls/gdiplus/pathiterator.c index abb5dbb..e9ba03e 100644 --- a/dlls/gdiplus/pathiterator.c +++ b/dlls/gdiplus/pathiterator.c @@ -105,6 +105,31 @@ GpStatus WINGDIPAPI GdipPathIterHasCurve(GpPathIterator* iterator, BOOL* hasCurv return Ok; } +GpStatus WINGDIPAPI GdipPathIterNextMarker(GpPathIterator* iterator, INT *resultCount, + INT* startIndex, INT* endIndex) +{ + INT i; + + if(!iterator || !startIndex || !endIndex) + return InvalidParameter; + + *resultCount = 0; + + /* first call could start with second point as all subsequent, cause + path couldn't contain only one */ + for(i = iterator->marker_pos + 1; i < iterator->pathdata.Count; i++){ + if(iterator->pathdata.Types[i] & PathPointTypePathMarker){ + *startIndex = iterator->marker_pos; + if(iterator->marker_pos > 0) (*startIndex)++; + *endIndex = iterator->marker_pos = i; + *resultCount= *endIndex - *startIndex + 1; + break; + } + } + + return Ok; +} + GpStatus WINGDIPAPI GdipPathIterNextSubpath(GpPathIterator* iterator, INT *resultCount, INT* startIndex, INT* endIndex, BOOL* isClosed) { diff --git a/dlls/gdiplus/tests/pathiterator.c b/dlls/gdiplus/tests/pathiterator.c index baeb22b..3406ce6 100644 --- a/dlls/gdiplus/tests/pathiterator.c +++ b/dlls/gdiplus/tests/pathiterator.c @@ -90,6 +90,62 @@ static void test_hascurve(void) GdipDeletePath(path); } +static void test_nextmarker(void) +{ + GpPath *path; + GpPathIterator *iter; + GpStatus stat; + INT start, end, result; + + /* NULL args + BOOL out argument is local in wrapper class method, + so it always has not-NULL address */ + stat = GdipPathIterNextMarker(NULL, &result, NULL, NULL); + expect(InvalidParameter, stat); + stat = GdipPathIterNextMarker(NULL, &result, &start, NULL); + expect(InvalidParameter, stat); + stat = GdipPathIterNextMarker(NULL, &result, NULL, &end); + expect(InvalidParameter, stat); + + GdipCreatePath(FillModeAlternate, &path); + GdipAddPathRectangle(path, 5.0, 5.0, 100.0, 50.0); + + /* no markers */ + GdipCreatePathIter(&iter, path); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(0, result); + GdipDeletePathIter(iter); + + /* one marker */ + GdipSetPathMarker(path); + GdipCreatePathIter(&iter, path); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(TRUE, (start == 0) && (end == 3) && (result == 4)); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(0, result); + GdipDeletePathIter(iter); + + /* two markers */ + GdipAddPathLine(path, 0.0, 0.0, 10.0, 30.0); + GdipSetPathMarker(path); + GdipCreatePathIter(&iter, path); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(TRUE, (start == 0) && (end == 3) && (result == 4)); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(TRUE, (start == 4) && (end == 5) && (result == 2)); + stat = GdipPathIterNextMarker(iter, &result, &start, &end); + expect(Ok, stat); + expect(0, result); + GdipDeletePathIter(iter); + + GdipDeletePath(path); +} + START_TEST(pathiterator) { struct GdiplusStartupInput gdiplusStartupInput; @@ -104,6 +160,7 @@ START_TEST(pathiterator) test_constructor_destructor(); test_hascurve(); + test_nextmarker(); GdiplusShutdown(gdiplusToken); } diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h index 9ef7ad7..c33645a 100644 --- a/include/gdiplusflat.h +++ b/include/gdiplusflat.h @@ -281,6 +281,7 @@ GpStatus WINGDIPAPI GdipCreatePathIter(GpPathIterator**,GpPath*); GpStatus WINGDIPAPI GdipDeletePathIter(GpPathIterator*); GpStatus WINGDIPAPI GdipPathIterCopyData(GpPathIterator*,INT*,GpPointF*,BYTE*, INT,INT); +GpStatus WINGDIPAPI GdipPathIterNextMarker(GpPathIterator*,INT*,INT*,INT*); GpStatus WINGDIPAPI GdipPathIterNextSubpath(GpPathIterator*,INT*,INT*,INT*,BOOL*); GpStatus WINGDIPAPI GdipPathIterRewind(GpPathIterator*); GpStatus WINGDIPAPI GdipPathIterGetCount(GpPathIterator*,INT*);
1
0
0
0
Dylan Smith : richedit: Fixed Valgrind error related to undoing.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: ebded1636b850c3e1f1ef253ebaba6b9f11652da URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ebded1636b850c3e1f1ef253e…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Sun Jul 6 15:27:40 2008 -0400 richedit: Fixed Valgrind error related to undoing. The error was a memory access of a freed object. In ME_AddUndoItem I checked the top of the undo stack to end a coalescing undo transaction, assuming that this should be either a valid undo item, or NULL, instead it was already freed. --- dlls/riched20/undo.c | 37 +++++++++++++++++++------------------ 1 files changed, 19 insertions(+), 18 deletions(-) diff --git a/dlls/riched20/undo.c b/dlls/riched20/undo.c index a0fd646..bf992ab 100644 --- a/dlls/riched20/undo.c +++ b/dlls/riched20/undo.c @@ -55,13 +55,7 @@ ME_UndoItem *ME_AddUndoItem(ME_TextEditor *editor, ME_DIType type, const ME_Disp return NULL; else { - ME_DisplayItem *pItem; - if (editor->pUndoStack - && editor->pUndoStack->type == diUndoPotentialEndTransaction) - { - editor->pUndoStack->type = diUndoEndTransaction; - } - pItem = (ME_DisplayItem *)ALLOC_OBJ(ME_UndoItem); + ME_DisplayItem *pItem = (ME_DisplayItem *)ALLOC_OBJ(ME_UndoItem); ((ME_UndoItem *)pItem)->nCR = ((ME_UndoItem *)pItem)->nLF = -1; switch(type) { @@ -109,6 +103,11 @@ ME_UndoItem *ME_AddUndoItem(ME_TextEditor *editor, ME_DIType type, const ME_Disp pItem->prev = NULL; if (editor->nUndoMode == umAddToUndo || editor->nUndoMode == umAddBackToUndo) { + if (editor->pUndoStack + && editor->pUndoStack->type == diUndoPotentialEndTransaction) + { + editor->pUndoStack->type = diUndoEndTransaction; + } if (editor->nUndoMode == umAddToUndo) TRACE("Pushing id=%s to undo stack, deleting redo stack\n", ME_GetDITypeName(type)); else @@ -355,17 +354,18 @@ BOOL ME_Undo(ME_TextEditor *editor) { editor->nUndoMode = umAddToRedo; p = editor->pUndoStack->next; ME_DestroyDisplayItem(editor->pUndoStack); + editor->pUndoStack = p; do { - ME_DisplayItem *pp = p; + p->prev = NULL; ME_PlayUndoItem(editor, p); - p = p->next; - ME_DestroyDisplayItem(pp); + editor->pUndoStack = p->next; + ME_DestroyDisplayItem(p); + p = editor->pUndoStack; } while(p && p->type != diUndoEndTransaction); - ME_AddUndoItem(editor, diUndoEndTransaction, NULL); - editor->pUndoStack = p; - editor->nUndoStackSize--; if (p) p->prev = NULL; + ME_AddUndoItem(editor, diUndoEndTransaction, NULL); + editor->nUndoStackSize--; editor->nUndoMode = nMode; ME_UpdateRepaint(editor); return TRUE; @@ -389,16 +389,17 @@ BOOL ME_Redo(ME_TextEditor *editor) { editor->nUndoMode = umAddBackToUndo; p = editor->pRedoStack->next; ME_DestroyDisplayItem(editor->pRedoStack); + editor->pRedoStack = p; do { - ME_DisplayItem *pp = p; + p->prev = NULL; ME_PlayUndoItem(editor, p); - p = p->next; - ME_DestroyDisplayItem(pp); + editor->pRedoStack = p->next; + ME_DestroyDisplayItem(p); + p = editor->pRedoStack; } while(p && p->type != diUndoEndTransaction); - ME_AddUndoItem(editor, diUndoEndTransaction, NULL); - editor->pRedoStack = p; if (p) p->prev = NULL; + ME_AddUndoItem(editor, diUndoEndTransaction, NULL); editor->nUndoMode = nMode; ME_UpdateRepaint(editor); return TRUE;
1
0
0
0
Dylan Smith : richedit: Fixed double click issues by sharing code with single click.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 5b2bdc06d00ef2a3e3bfd30dc142da5f902ede5b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5b2bdc06d00ef2a3e3bfd30dc…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Sat Jul 5 04:23:53 2008 -0400 richedit: Fixed double click issues by sharing code with single click. --- dlls/riched20/caret.c | 26 ++++++++++---------------- dlls/riched20/editor.c | 14 ++++++-------- dlls/riched20/editor.h | 2 +- 3 files changed, 17 insertions(+), 25 deletions(-) diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c index 4a79e48..c23d92c 100644 --- a/dlls/riched20/caret.c +++ b/dlls/riched20/caret.c @@ -749,8 +749,6 @@ ME_SelectWord(ME_TextEditor *editor) ME_MoveCursorWords(editor, &editor->pCursors[1], +1); editor->pCursors[0] = editor->pCursors[1]; ME_MoveCursorWords(editor, &editor->pCursors[0], -1); - ME_InvalidateSelection(editor); - ME_SendSelChange(editor); } @@ -871,7 +869,7 @@ ME_CharFromPos(ME_TextEditor *editor, int x, int y) } -void ME_LButtonDown(ME_TextEditor *editor, int x, int y) +void ME_LButtonDown(ME_TextEditor *editor, int x, int y, int clickNum) { ME_Cursor tmp_cursor; int is_selection = 0; @@ -888,19 +886,15 @@ void ME_LButtonDown(ME_TextEditor *editor, int x, int y) ME_FindPixelPos(editor, x, y, &editor->pCursors[0], &editor->bCaretAtEnd); if (GetKeyState(VK_SHIFT)>=0) { + /* Shift key is not down */ editor->pCursors[1] = editor->pCursors[0]; + if (clickNum > 1) + ME_SelectWord(editor); } else if (!is_selection) { editor->pCursors[1] = tmp_cursor; is_selection = 1; } - - ME_InvalidateSelection(editor); - HideCaret(editor->hWnd); - ME_MoveCaret(editor); - ShowCaret(editor->hWnd); - ME_ClearTempStyle(editor); - ME_SendSelChange(editor); } else { @@ -934,13 +928,13 @@ void ME_LButtonDown(ME_TextEditor *editor, int x, int y) } editor->pCursors[2] = editor->pCursors[0]; editor->pCursors[3] = editor->pCursors[1]; - ME_InvalidateSelection(editor); - HideCaret(editor->hWnd); - ME_MoveCaret(editor); - ShowCaret(editor->hWnd); - ME_ClearTempStyle(editor); - ME_SendSelChange(editor); } + ME_InvalidateSelection(editor); + HideCaret(editor->hWnd); + ME_MoveCaret(editor); + ShowCaret(editor->hWnd); + ME_ClearTempStyle(editor); + ME_SendSelChange(editor); } void ME_MouseMove(ME_TextEditor *editor, int x, int y) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 6ff1385..2d00061 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -2966,17 +2966,22 @@ static LRESULT RichEditWndProc_common(HWND hWnd, UINT msg, WPARAM wParam, ME_DestroyEditor(editor); SetWindowLongPtrW(hWnd, 0, 0); return 0; + case WM_LBUTTONDBLCLK: case WM_LBUTTONDOWN: + { + int clickNum = (msg == WM_LBUTTONDBLCLK) ? 2 : 1; ME_CommitUndo(editor); /* End coalesced undos for typed characters */ if ((editor->nEventMask & ENM_MOUSEEVENTS) && !ME_FilterEvent(editor, msg, &wParam, &lParam)) return 0; SetFocus(hWnd); - ME_LButtonDown(editor, (short)LOWORD(lParam), (short)HIWORD(lParam)); + ME_LButtonDown(editor, (short)LOWORD(lParam), (short)HIWORD(lParam), + clickNum); SetCapture(hWnd); ME_LinkNotify(editor,msg,wParam,lParam); if (!ME_SetCursor(editor, LOWORD(lParam))) goto do_default; break; + } case WM_MOUSEMOVE: if ((editor->nEventMask & ENM_MOUSEEVENTS) && !ME_FilterEvent(editor, msg, &wParam, &lParam)) @@ -3001,13 +3006,6 @@ static LRESULT RichEditWndProc_common(HWND hWnd, UINT msg, WPARAM wParam, if (!ret) goto do_default; } break; - case WM_LBUTTONDBLCLK: - if ((editor->nEventMask & ENM_MOUSEEVENTS) && - !ME_FilterEvent(editor, msg, &wParam, &lParam)) - return 0; - ME_LinkNotify(editor,msg,wParam,lParam); - ME_SelectWord(editor); - break; case WM_RBUTTONUP: case WM_RBUTTONDOWN: ME_CommitUndo(editor); /* End coalesced undos for typed characters */ diff --git a/dlls/riched20/editor.h b/dlls/riched20/editor.h index 0fc615a..a23fb8b 100644 --- a/dlls/riched20/editor.h +++ b/dlls/riched20/editor.h @@ -181,7 +181,7 @@ void ME_HideCaret(ME_TextEditor *ed); void ME_ShowCaret(ME_TextEditor *ed); void ME_MoveCaret(ME_TextEditor *ed); int ME_CharFromPos(ME_TextEditor *editor, int x, int y); -void ME_LButtonDown(ME_TextEditor *editor, int x, int y); +void ME_LButtonDown(ME_TextEditor *editor, int x, int y, int clickNum); void ME_MouseMove(ME_TextEditor *editor, int x, int y); void ME_DeleteTextAtCursor(ME_TextEditor *editor, int nCursor, int nChars); void ME_InsertTextFromCursor(ME_TextEditor *editor, int nCursor,
1
0
0
0
Dylan Smith : richedit: Made sure word selection selects only one word.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 379835b63409bbb1f2cea5717e3cb7841bd9f703 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=379835b63409bbb1f2cea5717…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Sat Jul 5 04:23:47 2008 -0400 richedit: Made sure word selection selects only one word. --- dlls/riched20/caret.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c index 4a1a8a4..4a79e48 100644 --- a/dlls/riched20/caret.c +++ b/dlls/riched20/caret.c @@ -746,9 +746,9 @@ ME_MoveCursorWords(ME_TextEditor *editor, ME_Cursor *cursor, int nRelOfs) void ME_SelectWord(ME_TextEditor *editor) { - if (!(editor->pCursors[0].pRun->member.run.nFlags & MERF_ENDPARA)) - ME_MoveCursorWords(editor, &editor->pCursors[0], -1); ME_MoveCursorWords(editor, &editor->pCursors[1], +1); + editor->pCursors[0] = editor->pCursors[1]; + ME_MoveCursorWords(editor, &editor->pCursors[0], -1); ME_InvalidateSelection(editor); ME_SendSelChange(editor); }
1
0
0
0
Stefan Dösinger : wined3d: Correct an off-by-one error in constant dirtification.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 9be8f36c2ec1dd3a1bb1d9b116ea11313da38e64 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9be8f36c2ec1dd3a1bb1d9b11…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Jul 6 11:51:26 2008 -0500 wined3d: Correct an off-by-one error in constant dirtification. Constant numbers start at 0, and the loading loop has a for(i; i < dirtyconsts; i++). This means that the highest dirty constant isn't loaded correctly. Rather than replacing the < with <=, which would make it impossible to have no dirty constant, add 1 to the dirty constant counter. --- dlls/wined3d/arb_program_shader.c | 2 +- dlls/wined3d/device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 84ec4fc..42b107a 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -134,7 +134,7 @@ static unsigned int shader_arb_load_constantsF(IWineD3DBaseShaderImpl* This, Win ret = 0; LIST_FOR_EACH_ENTRY(lconst, &This->baseShader.constantsF, local_constant, entry) { dirty_consts[lconst->idx] = 1; /* Dirtify so the non-immediate constant overwrites it next time */ - ret = max(ret, lconst->idx); + ret = max(ret, lconst->idx + 1); GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, lconst->idx, (GLfloat*)lconst->value)); } checkGLcall("glProgramEnvParameter4fvARB()"); diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 7a0cce2..26c1c9c 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -3602,7 +3602,7 @@ UINT count) { */ memset(This->activeContext->vshader_const_dirty + start, 1, sizeof(*This->activeContext->vshader_const_dirty) * count); - This->highest_dirty_vs_const = max(This->highest_dirty_vs_const, start+count); + This->highest_dirty_vs_const = max(This->highest_dirty_vs_const, start+count+1); IWineD3DDeviceImpl_MarkStateDirty(This, STATE_VERTEXSHADERCONSTANT); @@ -4030,7 +4030,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_SetPixelShaderConstantF_DirtyConst( */ memset(This->activeContext->pshader_const_dirty + start, 1, sizeof(*This->activeContext->pshader_const_dirty) * count); - This->highest_dirty_ps_const = max(This->highest_dirty_ps_const, start+count); + This->highest_dirty_ps_const = max(This->highest_dirty_ps_const, start+count+1); IWineD3DDeviceImpl_MarkStateDirty(This, STATE_PIXELSHADERCONSTANT);
1
0
0
0
Alexander Nicolaysen Sørnes : winecfg: Update Norwegian Bokmål translation.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 5bd57c5992f719a457a6121f497f52c5277162a9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5bd57c5992f719a457a6121f4…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jul 6 17:54:31 2008 +0200 winecfg: Update Norwegian Bokmål translation. --- programs/winecfg/No.rc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/winecfg/No.rc b/programs/winecfg/No.rc index f31d05d..b48a4ed 100644 --- a/programs/winecfg/No.rc +++ b/programs/winecfg/No.rc @@ -39,7 +39,7 @@ BEGIN LTEXT "
http://www.winehq.org/
",IDC_STATIC,119,31,106,8 LTEXT "Dette biblioteket er fri programvarer; det kan redistribueres i henhold til vilk�rene i GNU Lesser General Public License utgitt av �the Free Software Foundation�, enten versjon 2.1 av denne Lisensen, eller (hvis du �nsker det) en nyere versjon.", IDC_STATIC,119,44,124,72 - GROUPBOX " Windows P�melding Informasjon ", IDC_STATIC, 15, 110, 230, 55 + GROUPBOX " Brukerinformasjon ", IDC_STATIC, 15, 110, 230, 55 LTEXT "Eier:", IDC_STATIC, 22, 126, 40, 20 LTEXT "Organisasjon:", IDC_STATIC, 22, 140, 50, 20 EDITTEXT IDC_ABT_OWNER, 75, 126, 160, 13, ES_AUTOHSCROLL | WS_TABSTOP @@ -85,7 +85,7 @@ BEGIN CONTROL "", IDC_RES_TRACKBAR, "msctls_trackbar32",WS_TABSTOP,12,161,187,15 EDITTEXT IDC_RES_DPIEDIT,204,161,23,13,ES_NUMBER|WS_TABSTOP LTEXT "dpi",IDC_STATIC,235,163,10,8 - LTEXT "This is a sample text using 10 point Tahoma",IDC_RES_FONT_PREVIEW,15,181,230,55 + LTEXT "Forh�ndsvisning av tekst med 10 punkters Tahoma",IDC_RES_FONT_PREVIEW,15,181,230,55 END IDD_DLLCFG DIALOG DISCARDABLE 0, 0, 260, 250
1
0
0
0
Alexander Nicolaysen Sørnes : shell32: Update Norwegian Bokmål translation.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: ade9a3d6ea69cfd8e85ae9735d41e144c0406155 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ade9a3d6ea69cfd8e85ae9735…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jul 6 17:38:32 2008 +0200 shell32: Update Norwegian Bokmål translation. --- dlls/shell32/shell32_No.rc | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shell32_No.rc b/dlls/shell32/shell32_No.rc index b6ad967..adaefc1 100644 --- a/dlls/shell32/shell32_No.rc +++ b/dlls/shell32/shell32_No.rc @@ -1,5 +1,5 @@ /* - * Copyright 2005-2007 Alexander N. S�rnes <alex(a)thehandofagony.com> + * Copyright 2005-2008 Alexander N. S�rnes <alex(a)thehandofagony.com> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -220,6 +220,12 @@ STRINGTABLE IDS_SHUTDOWN_TITLE "Avslutt" IDS_SHUTDOWN_PROMPT "Vil du avslutte Wine-�kten?" + /* Run File dialog */ + IDS_RUNDLG_ERROR "Klarte ikke vise Kj�r-vinduet (intern feil)" + IDS_RUNDLG_BROWSE_ERROR "Klarte ikke vise Bla-vinduet (intern feil)" + IDS_RUNDLG_BROWSE_CAPTION "Bla" + IDS_RUNDLG_BROWSE_FILTER "Programfiler\0*.exe\0Alle filer\0*.*\0\0" + /* shell folder path default values */ IDS_PROGRAMS "Start-meny\\Programmer" IDS_PERSONAL "Mine dokumenter"
1
0
0
0
Andrew Talbot : winedos: Remove unneeded address-of operator from function name.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 7e917a0f9dbc69dc19b000a10e85dd1c0936fb49 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7e917a0f9dbc69dc19b000a10…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sun Jul 6 13:00:58 2008 +0100 winedos: Remove unneeded address-of operator from function name. --- dlls/winedos/dosaspi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winedos/dosaspi.c b/dlls/winedos/dosaspi.c index 28089a3..988e776 100644 --- a/dlls/winedos/dosaspi.c +++ b/dlls/winedos/dosaspi.c @@ -153,7 +153,7 @@ DWORD ASPI_SendASPIDOSCommand(DWORD ptrSRB) memcpy(&lpPRB->CDBByte[0],&lpSRB16->cmd.CDBByte[0],lpSRB16->cmd.SRB_CDBLen); /* Set post proc to our post proc */ - lpPRB->SRB_PostProc = &DOSASPI_PostProc; + lpPRB->SRB_PostProc = DOSASPI_PostProc; /* Stick the DWORD after all the sense info */ memcpy(lpPRB->SenseArea + lpPRB->SRB_SenseLen,&ptrSRB,sizeof(DWORD));
1
0
0
0
Andrew Talbot : wined3d: Remove unneeded address-of operators from function names.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 6ced8a3f55aec5b85668b158f5106a9dcca9e160 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6ced8a3f55aec5b85668b158f…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sun Jul 6 13:00:52 2008 +0100 wined3d: Remove unneeded address-of operators from function names. --- dlls/wined3d/arb_program_shader.c | 30 +++++++++++++++--------------- dlls/wined3d/baseshader.c | 30 +++++++++++++++--------------- dlls/wined3d/glsl_shader.c | 32 ++++++++++++++++---------------- 3 files changed, 46 insertions(+), 46 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index bd633f6..84ec4fc 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -2098,20 +2098,20 @@ static void shader_arb_fragment_enable(IWineD3DDevice *iface, BOOL enable) { } const shader_backend_t arb_program_shader_backend = { - &shader_arb_select, - &shader_arb_select_depth_blt, - &shader_arb_destroy_depth_blt, - &shader_arb_load_constants, - &shader_arb_cleanup, - &shader_arb_color_correction, - &shader_arb_destroy, - &shader_arb_alloc, - &shader_arb_free, - &shader_arb_dirty_const, - &shader_arb_generate_pshader, - &shader_arb_generate_vshader, - &shader_arb_get_caps, - &shader_arb_load_init, - &shader_arb_fragment_enable, + shader_arb_select, + shader_arb_select_depth_blt, + shader_arb_destroy_depth_blt, + shader_arb_load_constants, + shader_arb_cleanup, + shader_arb_color_correction, + shader_arb_destroy, + shader_arb_alloc, + shader_arb_free, + shader_arb_dirty_const, + shader_arb_generate_pshader, + shader_arb_generate_vshader, + shader_arb_get_caps, + shader_arb_load_init, + shader_arb_fragment_enable, FFPStateTable }; diff --git a/dlls/wined3d/baseshader.c b/dlls/wined3d/baseshader.c index 174f2ea..06dd69d 100644 --- a/dlls/wined3d/baseshader.c +++ b/dlls/wined3d/baseshader.c @@ -1201,21 +1201,21 @@ static void shader_none_fragment_enable(IWineD3DDevice *iface, BOOL enable) { #undef GLINFO_LOCATION const shader_backend_t none_shader_backend = { - &shader_none_select, - &shader_none_select_depth_blt, - &shader_none_destroy_depth_blt, - &shader_none_load_constants, - &shader_none_cleanup, - &shader_none_color_correction, - &shader_none_destroy, - &shader_none_alloc, - &shader_none_free, - &shader_none_dirty_const, - &shader_none_generate_pshader, - &shader_none_generate_vshader, - &shader_none_get_caps, - &shader_none_load_init, - &shader_none_fragment_enable, + shader_none_select, + shader_none_select_depth_blt, + shader_none_destroy_depth_blt, + shader_none_load_constants, + shader_none_cleanup, + shader_none_color_correction, + shader_none_destroy, + shader_none_alloc, + shader_none_free, + shader_none_dirty_const, + shader_none_generate_pshader, + shader_none_generate_vshader, + shader_none_get_caps, + shader_none_load_init, + shader_none_fragment_enable, FFPStateTable }; diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index a9ab92c..4823126 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -3473,7 +3473,7 @@ static BOOL glsl_program_key_compare(void *keya, void *keyb) { static HRESULT shader_glsl_alloc(IWineD3DDevice *iface) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; This->shader_priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct shader_glsl_priv)); - This->glsl_program_lookup = hash_table_create(&glsl_program_key_hash, &glsl_program_key_compare); + This->glsl_program_lookup = hash_table_create(glsl_program_key_hash, glsl_program_key_compare); return WINED3D_OK; } @@ -3693,20 +3693,20 @@ static void shader_glsl_fragment_enable(IWineD3DDevice *iface, BOOL enable) { } const shader_backend_t glsl_shader_backend = { - &shader_glsl_select, - &shader_glsl_select_depth_blt, - &shader_glsl_destroy_depth_blt, - &shader_glsl_load_constants, - &shader_glsl_cleanup, - &shader_glsl_color_correction, - &shader_glsl_destroy, - &shader_glsl_alloc, - &shader_glsl_free, - &shader_glsl_dirty_const, - &shader_glsl_generate_pshader, - &shader_glsl_generate_vshader, - &shader_glsl_get_caps, - &shader_glsl_load_init, - &shader_glsl_fragment_enable, + shader_glsl_select, + shader_glsl_select_depth_blt, + shader_glsl_destroy_depth_blt, + shader_glsl_load_constants, + shader_glsl_cleanup, + shader_glsl_color_correction, + shader_glsl_destroy, + shader_glsl_alloc, + shader_glsl_free, + shader_glsl_dirty_const, + shader_glsl_generate_pshader, + shader_glsl_generate_vshader, + shader_glsl_get_caps, + shader_glsl_load_init, + shader_glsl_fragment_enable, FFPStateTable };
1
0
0
0
Andrew Talbot : user32: Remove unneeded address-of operators from function names.
by Alexandre Julliard
07 Jul '08
07 Jul '08
Module: wine Branch: master Commit: 5806e4b5045f8702b0ddd9b5ab0cc40ba5115876 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5806e4b5045f8702b0ddd9b5a…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sun Jul 6 13:00:47 2008 +0100 user32: Remove unneeded address-of operators from function names. --- dlls/user32/nonclient.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/user32/nonclient.c b/dlls/user32/nonclient.c index 729a901..b11f474 100644 --- a/dlls/user32/nonclient.c +++ b/dlls/user32/nonclient.c @@ -1254,7 +1254,7 @@ static void NC_TrackMinMaxBox( HWND hwnd, WORD wParam ) /* Check if the sysmenu item for minimize is there */ state = GetMenuState(hSysMenu, SC_MINIMIZE, MF_BYCOMMAND); - paintButton = &NC_DrawMinButton; + paintButton = NC_DrawMinButton; } else { @@ -1265,7 +1265,7 @@ static void NC_TrackMinMaxBox( HWND hwnd, WORD wParam ) /* Check if the sysmenu item for maximize is there */ state = GetMenuState(hSysMenu, SC_MAXIMIZE, MF_BYCOMMAND); - paintButton = &NC_DrawMaxButton; + paintButton = NC_DrawMaxButton; } SetCapture( hwnd );
1
0
0
0
← Newer
1
...
88
89
90
91
92
93
94
...
112
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
Results per page:
10
25
50
100
200