winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2008
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
839 discussions
Start a n
N
ew thread
Huw Davies : crypt32: Remove some unnecessary code.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: 08c2b101f28a3a5852634aba20784cb4a8a8b728 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=08c2b101f28a3a5852634aba2…
Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Aug 21 17:56:17 2008 +0100 crypt32: Remove some unnecessary code. --- dlls/crypt32/str.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/dlls/crypt32/str.c b/dlls/crypt32/str.c index b0b0990..d574790 100644 --- a/dlls/crypt32/str.c +++ b/dlls/crypt32/str.c @@ -169,10 +169,8 @@ static DWORD CRYPT_AddPrefixA(LPCSTR prefix, LPSTR psz, DWORD csz) { chars = min(lstrlenA(prefix), csz); memcpy(psz, prefix, chars); - csz -= chars; *(psz + chars) = '='; chars++; - csz--; } else chars = lstrlenA(prefix) + 1; @@ -303,10 +301,8 @@ static DWORD CRYPT_AddPrefixAToW(LPCSTR prefix, LPWSTR psz, DWORD csz) chars = min(lstrlenA(prefix), csz); for (i = 0; i < chars; i++) *(psz + i) = prefix[i]; - csz -= chars; *(psz + chars) = '='; chars++; - csz--; } else chars = lstrlenA(prefix) + 1; @@ -328,10 +324,8 @@ static DWORD CRYPT_AddPrefixW(LPCWSTR prefix, LPWSTR psz, DWORD csz) { chars = min(lstrlenW(prefix), csz); memcpy(psz, prefix, chars * sizeof(WCHAR)); - csz -= chars; *(psz + chars) = '='; chars++; - csz--; } else chars = lstrlenW(prefix) + 1;
1
0
0
0
Huw Davies : crypt32: Don't decrease the size of the buffer, since we' re already counting the characters that we're adding to it.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: e71406451503086c1b6bd65f007cc4a457d60ed1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e71406451503086c1b6bd65f0…
Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Aug 21 18:03:11 2008 +0100 crypt32: Don't decrease the size of the buffer, since we're already counting the characters that we're adding to it. --- dlls/crypt32/str.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/dlls/crypt32/str.c b/dlls/crypt32/str.c index 699779f..b0b0990 100644 --- a/dlls/crypt32/str.c +++ b/dlls/crypt32/str.c @@ -249,7 +249,6 @@ DWORD WINAPI CertNameToStrA(DWORD dwCertEncodingType, PCERT_NAME_BLOB pName, chars = CRYPT_AddPrefixA(prefix, psz ? psz + ret : NULL, psz ? csz - ret - 1 : 0); ret += chars; - csz -= chars; } /* FIXME: handle quoting */ chars = CertRDNValueToStrA( @@ -277,7 +276,6 @@ DWORD WINAPI CertNameToStrA(DWORD dwCertEncodingType, PCERT_NAME_BLOB pName, if (psz && csz) { *(psz + ret) = '\0'; - csz--; ret++; } else @@ -406,7 +404,6 @@ DWORD WINAPI CertNameToStrW(DWORD dwCertEncodingType, PCERT_NAME_BLOB pName, chars = CRYPT_AddPrefixW(prefixW, psz ? psz + ret : NULL, psz ? csz - ret - 1 : 0); ret += chars; - csz -= chars; } else if (prefixA) { @@ -414,7 +411,6 @@ DWORD WINAPI CertNameToStrW(DWORD dwCertEncodingType, PCERT_NAME_BLOB pName, chars = CRYPT_AddPrefixAToW(prefixA, psz ? psz + ret : NULL, psz ? csz - ret - 1 : 0); ret += chars; - csz -= chars; } /* FIXME: handle quoting */ chars = CertRDNValueToStrW( @@ -442,7 +438,6 @@ DWORD WINAPI CertNameToStrW(DWORD dwCertEncodingType, PCERT_NAME_BLOB pName, if (psz && csz) { *(psz + ret) = '\0'; - csz--; ret++; } else
1
0
0
0
Roderick Colenbrander : wined3d: Fix window rewrite regression.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: fd0e60180a1979e3dd8730bd4922556a73353ea6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fd0e60180a1979e3dd8730bd4…
Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Thu Aug 21 20:51:18 2008 +0000 wined3d: Fix window rewrite regression. --- dlls/wined3d/device.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 0efe88f..d247d65 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1319,8 +1319,7 @@ static void WINAPI IWineD3DDeviceImpl_SetupFullscreenWindow(IWineD3DDevice *ifac /* Inform the window about the update. */ SetWindowPos(window, HWND_TOP, 0, 0, - w, h, SWP_FRAMECHANGED); - ShowWindow(window, SW_NORMAL); + w, h, SWP_FRAMECHANGED | SWP_SHOWWINDOW); } /*****************************************************************************
1
0
0
0
H. Verbeet : wined3d: Remove useless hash_table_entry_t typedef.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: b917bdaa5221391f3ccb5fdaa1cd0d1caf241e3f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b917bdaa5221391f3ccb5fdaa…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Thu Aug 21 18:35:34 2008 +0200 wined3d: Remove useless hash_table_entry_t typedef. It doesn't add much. --- dlls/wined3d/utils.c | 26 +++++++++++++------------- dlls/wined3d/wined3d_private.h | 6 +++--- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index df291ea..8b3be3f 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -5,7 +5,7 @@ * Copyright 2003-2004 Raphael Junqueira * Copyright 2004 Christian Costa * Copyright 2005 Oliver Stieber - * Copyright 2006-2007 Henri Verbeet + * Copyright 2006-2008 Henri Verbeet * Copyright 2007-2008 Stefan D�singer for CodeWeavers * * This library is free software; you can redistribute it and/or @@ -1581,7 +1581,7 @@ hash_table_t *hash_table_create(hash_function_t *hash_function, compare_function } table->bucket_count = initial_size; - table->entries = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, table->grow_size * sizeof(hash_table_entry_t)); + table->entries = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, table->grow_size * sizeof(struct hash_table_entry_t)); if (!table->entries) { ERR("Failed to allocate table entries, returning NULL.\n"); @@ -1614,12 +1614,12 @@ void hash_table_destroy(hash_table_t *table, void (*free_value)(void *value, voi HeapFree(GetProcessHeap(), 0, table); } -static inline hash_table_entry_t *hash_table_get_by_idx(hash_table_t *table, void *key, unsigned int idx) +static inline struct hash_table_entry_t *hash_table_get_by_idx(hash_table_t *table, void *key, unsigned int idx) { - hash_table_entry_t *entry; + struct hash_table_entry_t *entry; if (table->buckets[idx].next) - LIST_FOR_EACH_ENTRY(entry, &(table->buckets[idx]), hash_table_entry_t, entry) + LIST_FOR_EACH_ENTRY(entry, &(table->buckets[idx]), struct hash_table_entry_t, entry) if (table->compare_function(entry->key, key)) return entry; return NULL; @@ -1628,7 +1628,7 @@ static inline hash_table_entry_t *hash_table_get_by_idx(hash_table_t *table, voi static BOOL hash_table_resize(hash_table_t *table, unsigned int new_bucket_count) { unsigned int new_entry_count = 0; - hash_table_entry_t *new_entries; + struct hash_table_entry_t *new_entries; struct list *new_buckets; unsigned int grow_size = new_bucket_count - (new_bucket_count >> 2); unsigned int i; @@ -1640,7 +1640,7 @@ static BOOL hash_table_resize(hash_table_t *table, unsigned int new_bucket_count return FALSE; } - new_entries = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, grow_size * sizeof(hash_table_entry_t)); + new_entries = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, grow_size * sizeof(struct hash_table_entry_t)); if (!new_entries) { ERR("Failed to allocate new entries, returning FALSE.\n"); @@ -1652,12 +1652,12 @@ static BOOL hash_table_resize(hash_table_t *table, unsigned int new_bucket_count { if (table->buckets[i].next) { - hash_table_entry_t *entry, *entry2; + struct hash_table_entry_t *entry, *entry2; - LIST_FOR_EACH_ENTRY_SAFE(entry, entry2, &table->buckets[i], hash_table_entry_t, entry) + LIST_FOR_EACH_ENTRY_SAFE(entry, entry2, &table->buckets[i], struct hash_table_entry_t, entry) { int j; - hash_table_entry_t *new_entry = new_entries + (new_entry_count++); + struct hash_table_entry_t *new_entry = new_entries + (new_entry_count++); *new_entry = *entry; j = new_entry->hash & (new_bucket_count - 1); @@ -1688,7 +1688,7 @@ void hash_table_put(hash_table_t *table, void *key, void *value) { unsigned int idx; unsigned int hash; - hash_table_entry_t *entry; + struct hash_table_entry_t *entry; hash = table->hash_function(key); idx = hash & (table->bucket_count - 1); @@ -1742,7 +1742,7 @@ void hash_table_put(hash_table_t *table, void *key, void *value) struct list *elem = list_head(&table->free_entries); list_remove(elem); - entry = LIST_ENTRY(elem, hash_table_entry_t, entry); + entry = LIST_ENTRY(elem, struct hash_table_entry_t, entry); } else { entry = table->entries + (table->entry_count++); } @@ -1765,7 +1765,7 @@ void hash_table_remove(hash_table_t *table, void *key) void *hash_table_get(hash_table_t *table, void *key) { unsigned int idx; - hash_table_entry_t *entry; + struct hash_table_entry_t *entry; idx = table->hash_function(key) & (table->bucket_count - 1); entry = hash_table_get_by_idx(table, key, idx); diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index db9b10b..e67ec38 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -47,19 +47,19 @@ typedef unsigned int (hash_function_t)(void *key); typedef BOOL (compare_function_t)(void *keya, void *keyb); -typedef struct { +struct hash_table_entry_t { void *key; void *value; unsigned int hash; struct list entry; -} hash_table_entry_t; +}; typedef struct { hash_function_t *hash_function; compare_function_t *compare_function; struct list *buckets; unsigned int bucket_count; - hash_table_entry_t *entries; + struct hash_table_entry_t *entries; unsigned int entry_count; struct list free_entries; unsigned int count;
1
0
0
0
H. Verbeet : wined3d: Track FBOs per-context.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: 05931f4a5a2838ba6c867b29c7172a8d33b0a8b4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=05931f4a5a2838ba6c867b29c…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Thu Aug 21 18:34:55 2008 +0200 wined3d: Track FBOs per-context. Although sharing FBOs across contexts is allowed by EXT_framebuffer_object (issue 76), it causes issues with nVidia drivers. Considering the GL 3 spec explicitly disallows sharing of FBOs accross contexts (Appendix D), this patch is probably the right thing to do. --- dlls/wined3d/context.c | 28 ++++++++++- dlls/wined3d/device.c | 102 ++++++++++++---------------------------- dlls/wined3d/surface.c | 6 +- dlls/wined3d/wined3d_private.h | 13 +++-- 4 files changed, 67 insertions(+), 82 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=05931f4a5a2838ba6c867…
1
0
0
0
H. Verbeet : wined3d: Move depth stencil location handling code up a couple of lines.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: 2f99bcdde2e3f8dd9e763bff650c3cc28055f401 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2f99bcdde2e3f8dd9e763bff6…
Author: H. Verbeet <hverbeet(a)gmail.com> Date: Thu Aug 21 18:23:32 2008 +0200 wined3d: Move depth stencil location handling code up a couple of lines. This is just for clarity, so that render targets and the depth stencil are handled in the same place. --- dlls/wined3d/drawprim.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index 59e1f64..b0f6a53 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -5,7 +5,7 @@ * Copyright 2002-2004 Raphael Junqueira * Copyright 2004 Christian Costa * Copyright 2005 Oliver Stieber - * Copyright 2006 Henri Verbeet + * Copyright 2006, 2008 Henri Verbeet * Copyright 2007-2008 Stefan D�singer for CodeWeavers * * This library is free software; you can redistribute it and/or @@ -936,6 +936,12 @@ void drawPrimitive(IWineD3DDevice *iface, } } + if (This->stencilBufferTarget) { + DWORD location = This->render_offscreen ? SFLAG_DS_OFFSCREEN : SFLAG_DS_ONSCREEN; + surface_load_ds_location(This->stencilBufferTarget, location); + surface_modify_ds_location(This->stencilBufferTarget, location); + } + /* Signals other modules that a drawing is in progress and the stateblock finalized */ This->isInDraw = TRUE; @@ -944,12 +950,6 @@ void drawPrimitive(IWineD3DDevice *iface, ActivateContext(This, This->render_targets[0], CTXUSAGE_DRAWPRIM); ENTER_GL(); - if (This->stencilBufferTarget) { - DWORD location = This->render_offscreen ? SFLAG_DS_OFFSCREEN : SFLAG_DS_ONSCREEN; - surface_load_ds_location(This->stencilBufferTarget, location); - surface_modify_ds_location(This->stencilBufferTarget, location); - } - { GLenum glPrimType; BOOL emulation = FALSE;
1
0
0
0
Damjan Jovanovic : oleaut32: Add a failing VarFormat test.
by Alexandre Julliard
22 Aug '08
22 Aug '08
Module: wine Branch: master Commit: 1cbd1c2bf322ae4d78a7051ac69b0462278c8f42 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1cbd1c2bf322ae4d78a7051ac…
Author: Damjan Jovanovic <damjan.jov(a)gmail.com> Date: Thu Aug 21 16:30:56 2008 +0200 oleaut32: Add a failing VarFormat test. --- dlls/oleaut32/tests/varformat.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/oleaut32/tests/varformat.c b/dlls/oleaut32/tests/varformat.c index 228ad1c..2895408 100644 --- a/dlls/oleaut32/tests/varformat.c +++ b/dlls/oleaut32/tests/varformat.c @@ -368,6 +368,10 @@ static void test_VarFormat(void) VARFMT(VT_R8,V_R8,1.0001e-27,"##00.0000e-0",S_OK,"1000.1000e-30"); VARFMT(VT_R8,V_R8,47.11,".0000E+0",S_OK,".4711E+2"); VARFMT(VT_R8,V_R8,3.0401e-13,"#####.####e-0%",S_OK,"30401.e-15%"); + VARFMT(VT_R8,V_R8,1.57,"0.00",S_OK,"1.57"); + todo_wine { + VARFMT(VT_R8,V_R8,-1.57,"0.00",S_OK,"-1.57"); + } /* 'out' is not cleared */
1
0
0
0
Alexandre Julliard : Avoid some size_t printf format warnings.
by Alexandre Julliard
21 Aug '08
21 Aug '08
Module: wine Branch: master Commit: 5d900bb0f625f7870170c1a5ae570872664aba5c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5d900bb0f625f7870170c1a5a…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Aug 21 16:05:15 2008 +0200 Avoid some size_t printf format warnings. --- dlls/dplayx/tests/dplayx.c | 2 +- dlls/quartz/avisplit.c | 2 +- dlls/winhttp/tests/winhttp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/dplayx/tests/dplayx.c b/dlls/dplayx/tests/dplayx.c index 4fdc494..19c42b4 100644 --- a/dlls/dplayx/tests/dplayx.c +++ b/dlls/dplayx/tests/dplayx.c @@ -27,7 +27,7 @@ #define check(expected, result) \ ok( (expected) == (result), \ "expected=%d got=%d\n", \ - expected, result ); + (int)(expected), (int)(result) ); #define checkLP(expected, result) \ ok( (expected) == (result), \ "expected=%p got=%p\n", \ diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c index 3f1625c..e93d1d1 100644 --- a/dlls/quartz/avisplit.c +++ b/dlls/quartz/avisplit.c @@ -549,7 +549,7 @@ static HRESULT AVISplitter_ProcessIndex(AVISplitterImpl *This, AVISTDINDEX **ind { FIXME("Invalid index chunk encountered: %u/%u, %u/%u, %u/%u, %u/%u\n", pIndex->bIndexType, AVI_INDEX_OF_CHUNKS, pIndex->wLongsPerEntry, 2, - rest, (pIndex->nEntriesInUse * sizeof(DWORD) * pIndex->wLongsPerEntry), + rest, (DWORD)(pIndex->nEntriesInUse * sizeof(DWORD) * pIndex->wLongsPerEntry), pIndex->bIndexSubType, AVI_INDEX_SUB_DEFAULT); *index = NULL; return E_INVALIDARG; diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 527794d..d77dcc0 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -129,7 +129,7 @@ static void test_SendRequest (void) todo_wine ok(ret == TRUE, "WinHttpReadData failed: %u.\n", GetLastError()); todo_wine ok(bytes_rw == strlen(test_post), "Read %u bytes instead of %d.\n", - bytes_rw, strlen(test_post)); + bytes_rw, lstrlen(test_post)); todo_wine ok(strncmp(buffer, test_post, bytes_rw) == 0, "Data read did not match, got '%s'.\n", buffer);
1
0
0
0
Alexandre Julliard : kernel32: Fix a compiler warning on Mac OS.
by Alexandre Julliard
21 Aug '08
21 Aug '08
Module: wine Branch: master Commit: 49421014b79bdf21027c640a143d8b28b6eaab47 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=49421014b79bdf21027c640a1…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Aug 21 16:04:58 2008 +0200 kernel32: Fix a compiler warning on Mac OS. --- dlls/kernel32/locale.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c index 0366894..8aedacb 100644 --- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c @@ -2875,7 +2875,7 @@ void LOCALE_Init(void) CFStringGetCString( user_locale_string_ref, user_locale, sizeof(user_locale), kCFStringEncodingUTF8 ); CFRelease( user_locale_ref ); /* Strip modifiers because setlocale() can't parse them. */ - if (p = strchr( user_locale, '@' )) *p = 0; + if ((p = strchr( user_locale, '@' ))) *p = 0; if (!strchr( user_locale, '.' )) strcat( user_locale, ".UTF-8" ); unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a valid locale */ setenv( "LANG", user_locale, 0 );
1
0
0
0
Vladimir Pankratov : taskmgr: Converted some functions and variables to Unicode.
by Alexandre Julliard
21 Aug '08
21 Aug '08
Module: wine Branch: master Commit: 91227d913850bd6a2554b77a4b36a05664dfe26b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=91227d913850bd6a2554b77a4…
Author: Vladimir Pankratov <scriptkid(a)mail.ru> Date: Wed Aug 20 08:35:51 2008 +0000 taskmgr: Converted some functions and variables to Unicode. --- programs/taskmgr/perfpage.c | 61 +++++++++++++++++++++++------------------- 1 files changed, 33 insertions(+), 28 deletions(-) diff --git a/programs/taskmgr/perfpage.c b/programs/taskmgr/perfpage.c index 11220e6..4bf69c6 100644 --- a/programs/taskmgr/perfpage.c +++ b/programs/taskmgr/perfpage.c @@ -4,6 +4,7 @@ * perfpage.c * * Copyright (C) 1999 - 2001 Brian Palmer <brianp(a)reactos.org> + * Copyright (C) 2008 Vladimir Pankratov * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -26,10 +27,10 @@ #include <stdlib.h> #include <malloc.h> #include <memory.h> -#include <tchar.h> #include <stdio.h> #include <winnt.h> +#include "wine/unicode.h" #include "taskmgr.h" #include "perfdata.h" #include "graphctl.h" @@ -138,7 +139,11 @@ static DWORD WINAPI PerformancePageRefreshThread(void *lpParameter) ULONG TotalThreads; ULONG TotalProcesses; - TCHAR Text[260]; + WCHAR Text[256]; + + static const WCHAR wszFormatDigit[] = {'%','d',0}; + static const WCHAR wszMemUsage[] = {'M','e','m',' ','U','s','a','g','e',':',' ', + '%','d','K',' ','/',' ','%','d','K',0}; /* Create the event */ hPerformancePageEvent = CreateEvent(NULL, TRUE, TRUE, NULL); @@ -175,14 +180,14 @@ static DWORD WINAPI PerformancePageRefreshThread(void *lpParameter) CommitChargeTotal = PerfDataGetCommitChargeTotalK(); CommitChargeLimit = PerfDataGetCommitChargeLimitK(); CommitChargePeak = PerfDataGetCommitChargePeakK(); - _ultoa(CommitChargeTotal, Text, 10); - SetWindowText(hPerformancePageCommitChargeTotalEdit, Text); - _ultoa(CommitChargeLimit, Text, 10); - SetWindowText(hPerformancePageCommitChargeLimitEdit, Text); - _ultoa(CommitChargePeak, Text, 10); - SetWindowText(hPerformancePageCommitChargePeakEdit, Text); - wsprintf(Text, _T("Mem Usage: %dK / %dK"), CommitChargeTotal, CommitChargeLimit); - SendMessage(hStatusWnd, SB_SETTEXT, 2, (LPARAM)Text); + wsprintfW(Text, wszFormatDigit, CommitChargeTotal); + SetWindowTextW(hPerformancePageCommitChargeTotalEdit, Text); + wsprintfW(Text, wszFormatDigit, CommitChargeLimit); + SetWindowTextW(hPerformancePageCommitChargeLimitEdit, Text); + wsprintfW(Text, wszFormatDigit, CommitChargePeak); + SetWindowTextW(hPerformancePageCommitChargePeakEdit, Text); + wsprintfW(Text, wszMemUsage, CommitChargeTotal, CommitChargeLimit); + SendMessageW(hStatusWnd, SB_SETTEXTW, 2, (LPARAM)Text); /* * Update the kernel memory info @@ -190,12 +195,12 @@ static DWORD WINAPI PerformancePageRefreshThread(void *lpParameter) KernelMemoryTotal = PerfDataGetKernelMemoryTotalK(); KernelMemoryPaged = PerfDataGetKernelMemoryPagedK(); KernelMemoryNonPaged = PerfDataGetKernelMemoryNonPagedK(); - _ultoa(KernelMemoryTotal, Text, 10); - SetWindowText(hPerformancePageKernelMemoryTotalEdit, Text); - _ultoa(KernelMemoryPaged, Text, 10); - SetWindowText(hPerformancePageKernelMemoryPagedEdit, Text); - _ultoa(KernelMemoryNonPaged, Text, 10); - SetWindowText(hPerformancePageKernelMemoryNonPagedEdit, Text); + wsprintfW(Text, wszFormatDigit, KernelMemoryTotal); + SetWindowTextW(hPerformancePageKernelMemoryTotalEdit, Text); + wsprintfW(Text, wszFormatDigit, KernelMemoryPaged); + SetWindowTextW(hPerformancePageKernelMemoryPagedEdit, Text); + wsprintfW(Text, wszFormatDigit, KernelMemoryNonPaged); + SetWindowTextW(hPerformancePageKernelMemoryNonPagedEdit, Text); /* * Update the physical memory info @@ -203,12 +208,12 @@ static DWORD WINAPI PerformancePageRefreshThread(void *lpParameter) PhysicalMemoryTotal = PerfDataGetPhysicalMemoryTotalK(); PhysicalMemoryAvailable = PerfDataGetPhysicalMemoryAvailableK(); PhysicalMemorySystemCache = PerfDataGetPhysicalMemorySystemCacheK(); - _ultoa(PhysicalMemoryTotal, Text, 10); - SetWindowText(hPerformancePagePhysicalMemoryTotalEdit, Text); - _ultoa(PhysicalMemoryAvailable, Text, 10); - SetWindowText(hPerformancePagePhysicalMemoryAvailableEdit, Text); - _ultoa(PhysicalMemorySystemCache, Text, 10); - SetWindowText(hPerformancePagePhysicalMemorySystemCacheEdit, Text); + wsprintfW(Text, wszFormatDigit, PhysicalMemoryTotal); + SetWindowTextW(hPerformancePagePhysicalMemoryTotalEdit, Text); + wsprintfW(Text, wszFormatDigit, PhysicalMemoryAvailable); + SetWindowTextW(hPerformancePagePhysicalMemoryAvailableEdit, Text); + wsprintfW(Text, wszFormatDigit, PhysicalMemorySystemCache); + SetWindowTextW(hPerformancePagePhysicalMemorySystemCacheEdit, Text); /* * Update the totals info @@ -216,12 +221,12 @@ static DWORD WINAPI PerformancePageRefreshThread(void *lpParameter) TotalHandles = PerfDataGetSystemHandleCount(); TotalThreads = PerfDataGetTotalThreadCount(); TotalProcesses = PerfDataGetProcessCount(); - _ultoa(TotalHandles, Text, 10); - SetWindowText(hPerformancePageTotalsHandleCountEdit, Text); - _ultoa(TotalThreads, Text, 10); - SetWindowText(hPerformancePageTotalsThreadCountEdit, Text); - _ultoa(TotalProcesses, Text, 10); - SetWindowText(hPerformancePageTotalsProcessCountEdit, Text); + wsprintfW(Text, wszFormatDigit, TotalHandles); + SetWindowTextW(hPerformancePageTotalsHandleCountEdit, Text); + wsprintfW(Text, wszFormatDigit, TotalThreads); + SetWindowTextW(hPerformancePageTotalsThreadCountEdit, Text); + wsprintfW(Text, wszFormatDigit, TotalProcesses); + SetWindowTextW(hPerformancePageTotalsProcessCountEdit, Text); /* * Redraw the graphs
1
0
0
0
← Newer
1
...
32
33
34
35
36
37
38
...
84
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Results per page:
10
25
50
100
200