wine-commits August 2008

wine-commits@winehq.org

2 participants
839 discussions

Stefan Dösinger : wined3d: Add a swapchain method to set the dest override.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 3d49e8cd5e3872c06c5b86f8d2bb0cc41d5ddfa9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3d49e8cd5e3872c06c5b86f8d… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Jul 28 22:34:32 2008 -0500 wined3d: Add a swapchain method to set the dest override. DDraw can draw to the front buffer only, thus there's never a Present call which could pass this window. Due to that a drawing-independent method is needed. --- dlls/wined3d/swapchain.c | 73 +++++++++++++++++++++---------------- dlls/wined3d/swapchain_gdi.c | 8 ++++ include/wine/wined3d_interface.h | 2 + 3 files changed, 51 insertions(+), 32 deletions(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 9ec296c..1a82ab8 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -144,38 +144,7 @@ static HRESULT WINAPI IWineD3DSwapChainImpl_Present(IWineD3DSwapChain *iface, CO /* Don't call checkGLcall, as glGetError is not applicable here */ if (hDestWindowOverride && This->win_handle != hDestWindowOverride) { - WINED3DLOCKED_RECT r; - BYTE *mem; - - TRACE("Performing dest override of swapchain %p from window %p to %p\n", This, This->win_handle, hDestWindowOverride); - if(This->context[0] == This->wineD3DDevice->contexts[0]) { - /* The primary context 'owns' all the opengl resources. Destroying and recreating that context requires downloading - * all opengl resources, deleting the gl resources, destroying all other contexts, then recreating all other contexts - * and reload the resources - */ - delete_opengl_contexts((IWineD3DDevice *) This->wineD3DDevice, iface); - This->win_handle = hDestWindowOverride; - create_primary_opengl_context((IWineD3DDevice *) This->wineD3DDevice, iface); - } else { - This->win_handle = hDestWindowOverride; - - /* The old back buffer has to be copied over to the new back buffer. A lockrect - switchcontext - unlockrect - * would suffice in theory, but it is rather nasty and may cause troubles with future changes of the locking code - * So lock read only, copy the surface out, then lock with the discard flag and write back - */ - IWineD3DSurface_LockRect(This->backBuffer[0], &r, NULL, WINED3DLOCK_READONLY); - mem = HeapAlloc(GetProcessHeap(), 0, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); - memcpy(mem, r.pBits, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); - IWineD3DSurface_UnlockRect(This->backBuffer[0]); - - DestroyContext(This->wineD3DDevice, This->context[0]); - This->context[0] = CreateContext(This->wineD3DDevice, (IWineD3DSurfaceImpl *) This->frontBuffer, This->win_handle, FALSE /* pbuffer */, &This->presentParms); - - IWineD3DSurface_LockRect(This->backBuffer[0], &r, NULL, WINED3DLOCK_DISCARD); - memcpy(r.pBits, mem, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); - HeapFree(GetProcessHeap(), 0, mem); - IWineD3DSurface_UnlockRect(This->backBuffer[0]); - } + IWineD3DSwapChain_SetDestWindowOverride(iface, hDestWindowOverride); } SwapBuffers(This->context[0]->hdc); /* TODO: cycle through the swapchain buffers */ @@ -335,6 +304,45 @@ static HRESULT WINAPI IWineD3DSwapChainImpl_Present(IWineD3DSwapChain *iface, CO return WINED3D_OK; } +static HRESULT WINAPI IWineD3DSwapChainImpl_SetDestWindowOverride(IWineD3DSwapChain *iface, HWND window) { + IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *)iface; + WINED3DLOCKED_RECT r; + BYTE *mem; + + if(window == This->win_handle) return WINED3D_OK; + + TRACE("Performing dest override of swapchain %p from window %p to %p\n", This, This->win_handle, window); + if(This->context[0] == This->wineD3DDevice->contexts[0]) { + /* The primary context 'owns' all the opengl resources. Destroying and recreating that context requires downloading + * all opengl resources, deleting the gl resources, destroying all other contexts, then recreating all other contexts + * and reload the resources + */ + delete_opengl_contexts((IWineD3DDevice *) This->wineD3DDevice, iface); + This->win_handle = window; + create_primary_opengl_context((IWineD3DDevice *) This->wineD3DDevice, iface); + } else { + This->win_handle = window; + + /* The old back buffer has to be copied over to the new back buffer. A lockrect - switchcontext - unlockrect + * would suffice in theory, but it is rather nasty and may cause troubles with future changes of the locking code + * So lock read only, copy the surface out, then lock with the discard flag and write back + */ + IWineD3DSurface_LockRect(This->backBuffer[0], &r, NULL, WINED3DLOCK_READONLY); + mem = HeapAlloc(GetProcessHeap(), 0, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); + memcpy(mem, r.pBits, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); + IWineD3DSurface_UnlockRect(This->backBuffer[0]); + + DestroyContext(This->wineD3DDevice, This->context[0]); + This->context[0] = CreateContext(This->wineD3DDevice, (IWineD3DSurfaceImpl *) This->frontBuffer, This->win_handle, FALSE /* pbuffer */, &This->presentParms); + + IWineD3DSurface_LockRect(This->backBuffer[0], &r, NULL, WINED3DLOCK_DISCARD); + memcpy(r.pBits, mem, r.Pitch * ((IWineD3DSurfaceImpl *) This->backBuffer[0])->currentDesc.Height); + HeapFree(GetProcessHeap(), 0, mem); + IWineD3DSurface_UnlockRect(This->backBuffer[0]); + } + return WINED3D_OK; +} + const IWineD3DSwapChainVtbl IWineD3DSwapChain_Vtbl = { /* IUnknown */ @@ -346,6 +354,7 @@ const IWineD3DSwapChainVtbl IWineD3DSwapChain_Vtbl = IWineD3DSwapChainImpl_Destroy, IWineD3DBaseSwapChainImpl_GetDevice, IWineD3DSwapChainImpl_Present, + IWineD3DSwapChainImpl_SetDestWindowOverride, IWineD3DBaseSwapChainImpl_GetFrontBufferData, IWineD3DBaseSwapChainImpl_GetBackBuffer, IWineD3DBaseSwapChainImpl_GetRasterStatus, diff --git a/dlls/wined3d/swapchain_gdi.c b/dlls/wined3d/swapchain_gdi.c index 7aa81c2..d76b9b5 100644 --- a/dlls/wined3d/swapchain_gdi.c +++ b/dlls/wined3d/swapchain_gdi.c @@ -156,6 +156,13 @@ void x11_copy_to_screen(IWineD3DSwapChainImpl *This, LPRECT rc) { } } +static HRESULT WINAPI IWineGDISwapChainImpl_SetDestWindowOverride(IWineD3DSwapChain *iface, HWND window) { + IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *)iface; + + This->win_handle = window; + return WINED3D_OK; +} + static HRESULT WINAPI IWineGDISwapChainImpl_Present(IWineD3DSwapChain *iface, CONST RECT *pSourceRect, CONST RECT *pDestRect, HWND hDestWindowOverride, CONST RGNDATA *pDirtyRegion, DWORD dwFlags) { IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *) iface; IWineD3DSurfaceImpl *front, *back; @@ -254,6 +261,7 @@ const IWineD3DSwapChainVtbl IWineGDISwapChain_Vtbl = IWineGDISwapChainImpl_Destroy, IWineD3DBaseSwapChainImpl_GetDevice, IWineGDISwapChainImpl_Present, + IWineGDISwapChainImpl_SetDestWindowOverride, IWineD3DBaseSwapChainImpl_GetFrontBufferData, IWineD3DBaseSwapChainImpl_GetBackBuffer, IWineD3DBaseSwapChainImpl_GetRasterStatus, diff --git a/include/wine/wined3d_interface.h b/include/wine/wined3d_interface.h index 0768b0a..d2c8a2c 100644 --- a/include/wine/wined3d_interface.h +++ b/include/wine/wined3d_interface.h @@ -1421,6 +1421,7 @@ DECLARE_INTERFACE_(IWineD3DSwapChain,IWineD3DBase) STDMETHOD_(void, Destroy)(THIS_ D3DCB_DESTROYSURFACEFN pFn) PURE; STDMETHOD(GetDevice)(THIS_ IWineD3DDevice **ppDevice) PURE; STDMETHOD(Present)(THIS_ CONST RECT *pSourceRect, CONST RECT *pDestRect, HWND hDestWindowOverride, CONST RGNDATA *pDirtyRegion, DWORD dwFlags) PURE; + STDMETHOD(SetDestWindowOverride)(THIS_ HWND window); STDMETHOD(GetFrontBufferData)(THIS_ IWineD3DSurface *pDestSurface) PURE; STDMETHOD(GetBackBuffer)(THIS_ UINT iBackBuffer, WINED3DBACKBUFFER_TYPE Type, IWineD3DSurface **ppBackBuffer) PURE; STDMETHOD(GetRasterStatus)(THIS_ WINED3DRASTER_STATUS *pRasterStatus) PURE; @@ -1442,6 +1443,7 @@ DECLARE_INTERFACE_(IWineD3DSwapChain,IWineD3DBase) #define IWineD3DSwapChain_Destroy(p,a) (p)->lpVtbl->Destroy(p,a) #define IWineD3DSwapChain_GetDevice(p,a) (p)->lpVtbl->GetDevice(p,a) #define IWineD3DSwapChain_Present(p,a,b,c,d,e) (p)->lpVtbl->Present(p,a,b,c,d,e) +#define IWineD3DSwapChain_SetDestWindowOverride(p,a) (p)->lpVtbl->SetDestWindowOverride(p,a) #define IWineD3DSwapChain_GetFrontBufferData(p,a) (p)->lpVtbl->GetFrontBufferData(p,a) #define IWineD3DSwapChain_GetBackBuffer(p,a,b,c) (p)->lpVtbl->GetBackBuffer(p,a,b,c) #define IWineD3DSwapChain_GetRasterStatus(p,a) (p)->lpVtbl->GetRasterStatus(p,a)

1 0

Stefan Dösinger : wined3d: Remove the ddraw_window device member.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 25c07dc86ccba1dd95e2b2dd95ad7ae344dfc37d URL: http://source.winehq.org/git/wine.git/?a=commit;h=25c07dc86ccba1dd95e2b2dd9… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Aug 4 14:16:49 2008 -0500 wined3d: Remove the ddraw_window device member. --- dlls/wined3d/device.c | 35 ++++++++++++++++------------------- dlls/wined3d/surface.c | 4 ++-- dlls/wined3d/swapchain_gdi.c | 2 +- dlls/wined3d/wined3d_private.h | 1 - 4 files changed, 19 insertions(+), 23 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 91da15a..43837b2 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1432,13 +1432,10 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateAdditionalSwapChain(IWineD3DDevic if (!object->win_handle) { object->win_handle = This->createParms.hFocusWindow; } - if(!This->ddraw_window) { - if(!pPresentationParameters->Windowed && object->win_handle) { - IWineD3DDeviceImpl_SetupFullscreenWindow(iface, object->win_handle, - pPresentationParameters->BackBufferWidth, - pPresentationParameters->BackBufferHeight); - } - This->ddraw_window = object->win_handle; + if(!pPresentationParameters->Windowed && object->win_handle) { + IWineD3DDeviceImpl_SetupFullscreenWindow(iface, object->win_handle, + pPresentationParameters->BackBufferWidth, + pPresentationParameters->BackBufferHeight); } hDc = GetDC(object->win_handle); @@ -6652,8 +6649,8 @@ void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, WINED if(buffer == GL_FRONT) { RECT windowsize; UINT h; - ClientToScreen(This->ddraw_window, &offset); - GetClientRect(This->ddraw_window, &windowsize); + ClientToScreen(((IWineD3DSwapChainImpl *)src_swapchain)->win_handle, &offset); + GetClientRect(((IWineD3DSwapChainImpl *)src_swapchain)->win_handle, &windowsize); h = windowsize.bottom - windowsize.top; src_rect->x1 -= offset.x; src_rect->x2 -=offset.x; src_rect->y1 = offset.y + h - src_rect->y1; @@ -6693,8 +6690,8 @@ void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, WINED if(buffer == GL_FRONT) { RECT windowsize; UINT h; - ClientToScreen(This->ddraw_window, &offset); - GetClientRect(This->ddraw_window, &windowsize); + ClientToScreen(((IWineD3DSwapChainImpl *)dst_swapchain)->win_handle, &offset); + GetClientRect(((IWineD3DSwapChainImpl *)dst_swapchain)->win_handle, &windowsize); h = windowsize.bottom - windowsize.top; dst_rect->x1 -= offset.x; dst_rect->x2 -=offset.x; dst_rect->y1 = offset.y + h - dst_rect->y1; @@ -7397,21 +7394,21 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE IWineD3DDevice_SetDisplayMode(iface, 0, &mode); - if(This->ddraw_window && !pPresentationParameters->Windowed) { + if(swapchain->win_handle && !pPresentationParameters->Windowed) { if(swapchain->presentParms.Windowed) { /* switch from windowed to fs */ - IWineD3DDeviceImpl_SetupFullscreenWindow(iface, This->ddraw_window, + IWineD3DDeviceImpl_SetupFullscreenWindow(iface, swapchain->win_handle, pPresentationParameters->BackBufferWidth, pPresentationParameters->BackBufferHeight); } else { /* Fullscreen -> fullscreen mode change */ - MoveWindow(This->ddraw_window, 0, 0, - pPresentationParameters->BackBufferWidth, pPresentationParameters->BackBufferHeight, - TRUE); + MoveWindow(swapchain->win_handle, 0, 0, + pPresentationParameters->BackBufferWidth, pPresentationParameters->BackBufferHeight, + TRUE); } - } else if(This->ddraw_window && !swapchain->presentParms.Windowed) { + } else if(swapchain->win_handle && !swapchain->presentParms.Windowed) { /* Fullscreen -> windowed switch */ - IWineD3DDeviceImpl_RestoreWindow(iface, This->ddraw_window); + IWineD3DDeviceImpl_RestoreWindow(iface, swapchain->win_handle); } swapchain->presentParms.Windowed = pPresentationParameters->Windowed; } else if(!pPresentationParameters->Windowed) { @@ -7422,7 +7419,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE */ This->style = 0; This->exStyle = 0; - IWineD3DDeviceImpl_SetupFullscreenWindow(iface, This->ddraw_window, + IWineD3DDeviceImpl_SetupFullscreenWindow(iface, swapchain->win_handle, pPresentationParameters->BackBufferWidth, pPresentationParameters->BackBufferHeight); This->style = style; diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index dff833e..3c56d4c 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -3451,8 +3451,8 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, RECT * RECT windowsize; POINT offset = {0,0}; UINT h; - ClientToScreen(myDevice->ddraw_window, &offset); - GetClientRect(myDevice->ddraw_window, &windowsize); + ClientToScreen(dstSwapchain->win_handle, &offset); + GetClientRect(dstSwapchain->win_handle, &windowsize); h = windowsize.bottom - windowsize.top; rect.x1 -= offset.x; rect.x2 -=offset.x; rect.y1 -= offset.y; rect.y2 -=offset.y; diff --git a/dlls/wined3d/swapchain_gdi.c b/dlls/wined3d/swapchain_gdi.c index 41a5475..7aa81c2 100644 --- a/dlls/wined3d/swapchain_gdi.c +++ b/dlls/wined3d/swapchain_gdi.c @@ -93,7 +93,7 @@ void x11_copy_to_screen(IWineD3DSwapChainImpl *This, LPRECT rc) { hSurfaceDC = front->hDC; - hDisplayWnd = front->resource.wineD3DDevice->ddraw_window; + hDisplayWnd = This->win_handle; hDisplayDC = GetDCEx(hDisplayWnd, 0, DCX_CLIPSIBLINGS|DCX_CACHE); if(rc) { TRACE(" copying rect (%d,%d)->(%d,%d), offset (%d,%d)\n", diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index ee1e1e8..6f14790 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -920,7 +920,6 @@ struct IWineD3DDeviceImpl BOOL softwareVertexProcessing; /* DirectDraw stuff */ - HWND ddraw_window; DWORD ddraw_width, ddraw_height; WINED3DFORMAT ddraw_format;

1 0

Stefan Dösinger : wined3d: Remove the device-global fullscreen flag.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 376944ebe452cebfeca655b1d25cda6c5da0bf34 URL: http://source.winehq.org/git/wine.git/?a=commit;h=376944ebe452cebfeca655b1d… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Aug 4 14:11:22 2008 -0500 wined3d: Remove the device-global fullscreen flag. --- dlls/ddraw/ddraw.c | 5 --- dlls/wined3d/device.c | 60 +++++++++++++++++--------------------- dlls/wined3d/swapchain_gdi.c | 6 ++-- dlls/wined3d/wined3d_private.h | 1 - include/wine/wined3d_interface.h | 2 - 5 files changed, 30 insertions(+), 44 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=376944ebe452cebfeca65…

1 0

Stefan Dösinger : d3d: Remove IWineD3DDevice::SetHwnd.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 34b37fe2411d83f1a6f3e11a7a1e4d28bd9b36ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=34b37fe2411d83f1a6f3e11a7… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 5 14:24:10 2008 -0500 d3d: Remove IWineD3DDevice::SetHwnd. --- dlls/ddraw/ddraw.c | 34 +++++++--------------------------- dlls/ddraw/ddraw_private.h | 1 + dlls/wined3d/device.c | 36 ++++++------------------------------ include/wine/wined3d_interface.h | 4 ---- 4 files changed, 14 insertions(+), 61 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index d037769..6ae0269 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -357,7 +357,6 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, { ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw7, iface); HWND window; - HRESULT hr; TRACE("(%p)->(%p,%08x)\n",This,hwnd,cooplevel); DDRAW_dump_cooperativelevel(cooplevel); @@ -365,13 +364,7 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, EnterCriticalSection(&ddraw_cs); /* Get the old window */ - hr = IWineD3DDevice_GetHWND(This->wineD3DDevice, &window); - if(hr != D3D_OK) - { - ERR("IWineD3DDevice::GetHWND failed, hr = %08x\n", hr); - LeaveCriticalSection(&ddraw_cs); - return hr; - } + window = This->dest_window; /* Tests suggest that we need one of them: */ if(!(cooplevel & (DDSCL_SETFOCUSWINDOW | @@ -413,7 +406,7 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, hwnd = NULL; /* Use the focus window for drawing too */ - IWineD3DDevice_SetHWND(This->wineD3DDevice, This->focuswindow); + This->dest_window = This->focuswindow; /* Destroy the device window, if we have one */ if(This->devicewindow) @@ -450,7 +443,7 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, !(This->devicewindow) && (hwnd != window) ) { - IWineD3DDevice_SetHWND(This->wineD3DDevice, hwnd); + This->dest_window = hwnd; } IWineD3DDevice_SetFullscreen(This->wineD3DDevice, @@ -483,7 +476,7 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, !(This->devicewindow) && (hwnd != window) ) { - IWineD3DDevice_SetHWND(This->wineD3DDevice, hwnd); + This->dest_window = hwnd; } } else if(cooplevel & DDSCL_EXCLUSIVE) @@ -507,8 +500,8 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, ShowWindow(devicewindow, SW_SHOW); /* Just to be sure */ TRACE("(%p) Created a DDraw device window. HWND=%p\n", This, devicewindow); - IWineD3DDevice_SetHWND(This->wineD3DDevice, devicewindow); This->devicewindow = devicewindow; + This->dest_window = devicewindow; } } @@ -3195,11 +3188,7 @@ static HRESULT WINAPI IDirectDrawImpl_CreateGDISwapChain(IDirectDrawImpl *This, WINED3DPRESENT_PARAMETERS presentation_parameters; HWND window; - hr = IWineD3DDevice_GetHWND(This->wineD3DDevice, - &window); - if(FAILED(hr)) { - return hr; - } + window = This->dest_window; memset(&presentation_parameters, 0, sizeof(presentation_parameters)); @@ -3253,21 +3242,12 @@ IDirectDrawImpl_AttachD3DDevice(IDirectDrawImpl *This, IDirectDrawSurfaceImpl *primary) { HRESULT hr; - HWND window; + HWND window = This->dest_window; WINED3DPRESENT_PARAMETERS localParameters; TRACE("(%p)->(%p)\n", This, primary); - /* Get the window */ - hr = IWineD3DDevice_GetHWND(This->wineD3DDevice, - &window); - if(hr != D3D_OK) - { - ERR("IWineD3DDevice::GetHWND failed\n"); - return hr; - } - /* If there's no window, create a hidden window. WineD3D needs it */ if(window == 0) { diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index b7816d7..a92f7f4 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -137,6 +137,7 @@ struct IDirectDrawImpl /* Various HWNDs */ HWND focuswindow; HWND devicewindow; + HWND dest_window; /* The surface type to request */ WINED3DSURFTYPE ImplType; diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index abcd90f..b89db16 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1432,7 +1432,12 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateAdditionalSwapChain(IWineD3DDevic if (!object->win_handle) { object->win_handle = This->createParms.hFocusWindow; } - if(!This->ddraw_window) IWineD3DDevice_SetHWND(iface, object->win_handle); + if(!This->ddraw_window) { + if(This->ddraw_fullscreen && object->win_handle) { + IWineD3DDeviceImpl_SetupFullscreenWindow(iface, object->win_handle); + } + This->ddraw_window = object->win_handle; + } hDc = GetDC(object->win_handle); TRACE("Using hDc %p\n", hDc); @@ -4827,31 +4832,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl_GetDisplayMode(IWineD3DDevice *iface, U return hr; } -static HRESULT WINAPI IWineD3DDeviceImpl_SetHWND(IWineD3DDevice *iface, HWND hWnd) { - IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; - TRACE("(%p)->(%p)\n", This, hWnd); - - if(This->ddraw_fullscreen) { - if(This->ddraw_window && This->ddraw_window != hWnd) { - IWineD3DDeviceImpl_RestoreWindow(iface, This->ddraw_window); - } - if(hWnd && This->ddraw_window != hWnd) { - IWineD3DDeviceImpl_SetupFullscreenWindow(iface, hWnd); - } - } - - This->ddraw_window = hWnd; - return WINED3D_OK; -} - -static HRESULT WINAPI IWineD3DDeviceImpl_GetHWND(IWineD3DDevice *iface, HWND *hWnd) { - IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; - TRACE("(%p)->(%p)\n", This, hWnd); - - *hWnd = This->ddraw_window; - return WINED3D_OK; -} - /***** * Stateblock related functions *****/ @@ -7734,8 +7714,6 @@ const IWineD3DDeviceVtbl IWineD3DDevice_Vtbl = IWineD3DDeviceImpl_GetDirect3D, IWineD3DDeviceImpl_GetDisplayMode, IWineD3DDeviceImpl_SetDisplayMode, - IWineD3DDeviceImpl_GetHWND, - IWineD3DDeviceImpl_SetHWND, IWineD3DDeviceImpl_GetNumberOfSwapChains, IWineD3DDeviceImpl_GetRasterStatus, IWineD3DDeviceImpl_GetSwapChain, @@ -7882,8 +7860,6 @@ const IWineD3DDeviceVtbl IWineD3DDevice_DirtyConst_Vtbl = IWineD3DDeviceImpl_GetDirect3D, IWineD3DDeviceImpl_GetDisplayMode, IWineD3DDeviceImpl_SetDisplayMode, - IWineD3DDeviceImpl_GetHWND, - IWineD3DDeviceImpl_SetHWND, IWineD3DDeviceImpl_GetNumberOfSwapChains, IWineD3DDeviceImpl_GetRasterStatus, IWineD3DDeviceImpl_GetSwapChain, diff --git a/include/wine/wined3d_interface.h b/include/wine/wined3d_interface.h index e8b4d94..72ee7fd 100644 --- a/include/wine/wined3d_interface.h +++ b/include/wine/wined3d_interface.h @@ -387,8 +387,6 @@ DECLARE_INTERFACE_(IWineD3DDevice,IWineD3DBase) STDMETHOD(GetDirect3D)(THIS_ IWineD3D** ppD3D) PURE; STDMETHOD(GetDisplayMode)(THIS_ UINT iSwapChain, WINED3DDISPLAYMODE* pMode) PURE; STDMETHOD(SetDisplayMode)(THIS_ UINT iSwapChain, WINED3DDISPLAYMODE* pMode) PURE; - STDMETHOD(GetHWND)(THIS_ HWND *hwnd) PURE; - STDMETHOD(SetHWND)(THIS_ HWND hwnd) PURE; STDMETHOD_(UINT, GetNumberOfSwapChains)(THIS) PURE; STDMETHOD(GetRasterStatus)(THIS_ UINT iSwapChain, WINED3DRASTER_STATUS* pRasterStatus) PURE; STDMETHOD(GetSwapChain)(THIS_ UINT iSwapChain, struct IWineD3DSwapChain **pSwapChain) PURE; @@ -530,8 +528,6 @@ DECLARE_INTERFACE_(IWineD3DDevice,IWineD3DBase) #define IWineD3DDevice_GetDirect3D(p,a) (p)->lpVtbl->GetDirect3D(p,a) #define IWineD3DDevice_GetDisplayMode(p,a,b) (p)->lpVtbl->GetDisplayMode(p,a,b) #define IWineD3DDevice_SetDisplayMode(p,a,b) (p)->lpVtbl->SetDisplayMode(p,a,b) -#define IWineD3DDevice_GetHWND(p, a) (p)->lpVtbl->GetHWND(p, a) -#define IWineD3DDevice_SetHWND(p, a) (p)->lpVtbl->SetHWND(p, a) #define IWineD3DDevice_GetNumberOfSwapChains(p) (p)->lpVtbl->GetNumberOfSwapChains(p) #define IWineD3DDevice_Reset(p,a) (p)->lpVtbl->Reset(p,a) #define IWineD3DDevice_SetDialogBoxMode(p,a) (p)->lpVtbl->SetDialogBoxMode(p,a)

1 0

Stefan Dösinger : wined3d: Support redirecting the primary context.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 7f2b8f9bba906b8620eb6c643a86c65b69d022fb URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f2b8f9bba906b8620eb6c643… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Jul 29 12:09:34 2008 -0500 wined3d: Support redirecting the primary context. --- dlls/wined3d/device.c | 153 ++++++++++++++++++++++------------------ dlls/wined3d/swapchain.c | 6 +- dlls/wined3d/wined3d_private.h | 3 + 3 files changed, 92 insertions(+), 70 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 836b318..abcd90f 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -7239,15 +7239,92 @@ static BOOL is_display_mode_supported(IWineD3DDeviceImpl *This, WINED3DPRESENT_P return FALSE; } +void delete_opengl_contexts(IWineD3DDevice *iface, IWineD3DSwapChain *swapchain_iface) { + IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; + IWineD3DSwapChainImpl *swapchain = (IWineD3DSwapChainImpl *) swapchain_iface; + UINT i; + IWineD3DBaseShaderImpl *shader; + + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) { + reset_fbo_state((IWineD3DDevice *) This); + } + + IWineD3DDevice_EnumResources(iface, reset_unload_resources, NULL); + LIST_FOR_EACH_ENTRY(shader, &This->shaders, IWineD3DBaseShaderImpl, baseShader.shader_list_entry) { + This->shader_backend->shader_destroy((IWineD3DBaseShader *) shader); + } + + ENTER_GL(); + if(This->depth_blt_texture) { + glDeleteTextures(1, &This->depth_blt_texture); + This->depth_blt_texture = 0; + } + if (This->depth_blt_rb) { + GL_EXTCALL(glDeleteRenderbuffersEXT(1, &This->depth_blt_rb)); + This->depth_blt_rb = 0; + This->depth_blt_rb_w = 0; + This->depth_blt_rb_h = 0; + } + This->frag_pipe->free_private(iface); + This->shader_backend->shader_free_private(iface); + + for (i = 0; i < GL_LIMITS(textures); i++) { + /* Textures are recreated below */ + glDeleteTextures(1, &This->dummyTextureName[i]); + checkGLcall("glDeleteTextures(1, &This->dummyTextureName[i])"); + This->dummyTextureName[i] = 0; + } + LEAVE_GL(); + + while(This->numContexts) { + DestroyContext(This, This->contexts[0]); + } + This->activeContext = NULL; + HeapFree(GetProcessHeap(), 0, swapchain->context); + swapchain->context = NULL; + swapchain->num_contexts = 0; +} + +HRESULT create_primary_opengl_context(IWineD3DDevice *iface, IWineD3DSwapChain *swapchain_iface) { + IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; + IWineD3DSwapChainImpl *swapchain = (IWineD3DSwapChainImpl *) swapchain_iface; + HRESULT hr; + IWineD3DSurfaceImpl *target; + + /* Recreate the primary swapchain's context */ + swapchain->context = HeapAlloc(GetProcessHeap(), 0, sizeof(*swapchain->context)); + if(swapchain->backBuffer) { + target = (IWineD3DSurfaceImpl *) swapchain->backBuffer[0]; + } else { + target = (IWineD3DSurfaceImpl *) swapchain->frontBuffer; + } + swapchain->context[0] = CreateContext(This, target, swapchain->win_handle, FALSE, + &swapchain->presentParms); + swapchain->num_contexts = 1; + This->activeContext = swapchain->context[0]; + + create_dummy_textures(This); + + hr = This->shader_backend->shader_alloc_private(iface); + if(FAILED(hr)) { + ERR("Failed to recreate shader private data\n"); + return hr; + } + hr = This->frag_pipe->alloc_private(iface); + if(FAILED(hr)) { + TRACE("Fragment pipeline private data couldn't be allocated\n"); + return hr; + } + + return WINED3D_OK; +} + static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRESENT_PARAMETERS* pPresentationParameters) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; IWineD3DSwapChainImpl *swapchain; HRESULT hr; BOOL DisplayModeChanged = FALSE; WINED3DDISPLAYMODE mode; - IWineD3DBaseShaderImpl *shader; - IWineD3DSurfaceImpl *target; - UINT i; TRACE("(%p)\n", This); hr = IWineD3DDevice_GetSwapChain(iface, 0, (IWineD3DSwapChain **) &swapchain); @@ -7308,46 +7385,9 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE ERR("What do do about a changed auto depth stencil parameter?\n"); } - if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) { - reset_fbo_state((IWineD3DDevice *) This); - } - - IWineD3DDevice_EnumResources(iface, reset_unload_resources, NULL); - LIST_FOR_EACH_ENTRY(shader, &This->shaders, IWineD3DBaseShaderImpl, baseShader.shader_list_entry) { - This->shader_backend->shader_destroy((IWineD3DBaseShader *) shader); - } - - ENTER_GL(); - if(This->depth_blt_texture) { - glDeleteTextures(1, &This->depth_blt_texture); - This->depth_blt_texture = 0; - } - if (This->depth_blt_rb) { - GL_EXTCALL(glDeleteRenderbuffersEXT(1, &This->depth_blt_rb)); - This->depth_blt_rb = 0; - This->depth_blt_rb_w = 0; - This->depth_blt_rb_h = 0; - } - This->frag_pipe->free_private(iface); - This->shader_backend->shader_free_private(iface); - - for (i = 0; i < GL_LIMITS(textures); i++) { - /* Textures are recreated below */ - glDeleteTextures(1, &This->dummyTextureName[i]); - checkGLcall("glDeleteTextures(1, &This->dummyTextureName[i])"); - This->dummyTextureName[i] = 0; - } - LEAVE_GL(); - - while(This->numContexts) { - DestroyContext(This, This->contexts[0]); - } - This->activeContext = NULL; - HeapFree(GetProcessHeap(), 0, swapchain->context); - swapchain->context = NULL; - swapchain->num_contexts = 0; + delete_opengl_contexts(iface, (IWineD3DSwapChain *) swapchain); - if(pPresentationParameters->Windowed) { + if(pPresentationParameters->Windowed) { mode.Width = swapchain->orig_width; mode.Height = swapchain->orig_height; mode.RefreshRate = 0; @@ -7413,41 +7453,18 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE This->exStyle = exStyle; } - /* Recreate the primary swapchain's context */ - swapchain->context = HeapAlloc(GetProcessHeap(), 0, sizeof(*swapchain->context)); - if(swapchain->backBuffer) { - target = (IWineD3DSurfaceImpl *) swapchain->backBuffer[0]; - } else { - target = (IWineD3DSurfaceImpl *) swapchain->frontBuffer; - } - swapchain->context[0] = CreateContext(This, target, swapchain->win_handle, FALSE, - &swapchain->presentParms); - swapchain->num_contexts = 1; - This->activeContext = swapchain->context[0]; - IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); - hr = IWineD3DStateBlock_InitStartupStateBlock((IWineD3DStateBlock *) This->stateBlock); if(FAILED(hr)) { ERR("Resetting the stateblock failed with error 0x%08x\n", hr); } - create_dummy_textures(This); - - hr = This->shader_backend->shader_alloc_private(iface); - if(FAILED(hr)) { - ERR("Failed to recreate shader private data\n"); - return hr; - } - hr = This->frag_pipe->alloc_private(iface); - if(FAILED(hr)) { - TRACE("Fragment pipeline private data couldn't be allocated\n"); - return hr; - } + hr = create_primary_opengl_context(iface, (IWineD3DSwapChain *) swapchain); + IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); /* All done. There is no need to reload resources or shaders, this will happen automatically on the * first use */ - return WINED3D_OK; + return hr; } static HRESULT WINAPI IWineD3DDeviceImpl_SetDialogBoxMode(IWineD3DDevice *iface, BOOL bEnableDialogs) { diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 72b1c7c..9ec296c 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -149,11 +149,13 @@ static HRESULT WINAPI IWineD3DSwapChainImpl_Present(IWineD3DSwapChain *iface, CO TRACE("Performing dest override of swapchain %p from window %p to %p\n", This, This->win_handle, hDestWindowOverride); if(This->context[0] == This->wineD3DDevice->contexts[0]) { - /* The primary context 'owns' all the opengl resources. Destroying and recreating that context would require downloading + /* The primary context 'owns' all the opengl resources. Destroying and recreating that context requires downloading * all opengl resources, deleting the gl resources, destroying all other contexts, then recreating all other contexts * and reload the resources */ - ERR("Cannot change the destination window of the owner of the primary context\n"); + delete_opengl_contexts((IWineD3DDevice *) This->wineD3DDevice, iface); + This->win_handle = hDestWindowOverride; + create_primary_opengl_context((IWineD3DDevice *) This->wineD3DDevice, iface); } else { This->win_handle = hDestWindowOverride; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 0c163f4..3cdfd1a 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -629,6 +629,9 @@ WineD3DContext *CreateContext(IWineD3DDeviceImpl *This, IWineD3DSurfaceImpl *tar void DestroyContext(IWineD3DDeviceImpl *This, WineD3DContext *context); void apply_fbo_state(IWineD3DDevice *iface); +void delete_opengl_contexts(IWineD3DDevice *iface, IWineD3DSwapChain *swapchain); +HRESULT create_primary_opengl_context(IWineD3DDevice *iface, IWineD3DSwapChain *swapchain); + /* Macros for doing basic GPU detection based on opengl capabilities */ #define WINE_D3D6_CAPABLE(gl_info) (gl_info->supported[ARB_MULTITEXTURE]) #define WINE_D3D7_CAPABLE(gl_info) (gl_info->supported[ARB_TEXTURE_COMPRESSION] && gl_info->supported[ARB_TEXTURE_CUBE_MAP] && gl_info->supported[ARB_TEXTURE_ENV_DOT3])

1 0

Stefan Dösinger : wined3d: Use a swapchain for GDI surfaces.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: e178ddd9e1e16d1a3f52492799692e289eefcf8c URL: http://source.winehq.org/git/wine.git/?a=commit;h=e178ddd9e1e16d1a3f5249279… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 5 14:23:00 2008 -0500 wined3d: Use a swapchain for GDI surfaces. This is a long-needed cleanup aimed at removing the ddraw_primary, ddraw_window, ddraw_width and ddraw_height members from IWineD3DDeviceImpl, which just do not belong there. Destination window and screen handling is supposed to be done by swapchains. --- dlls/d3d8/device.c | 2 +- dlls/d3d9/swapchain.c | 2 +- dlls/ddraw/ddraw.c | 94 +++++++++++++- dlls/ddraw/ddraw_private.h | 1 + dlls/ddraw/surface.c | 64 +++++---- dlls/wined3d/Makefile.in | 1 + dlls/wined3d/device.c | 110 +++++++++++++---- dlls/wined3d/surface.c | 7 +- dlls/wined3d/surface_gdi.c | 222 ++++---------------------------- dlls/wined3d/swapchain_gdi.c | 264 ++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h | 3 +- include/wine/wined3d_interface.h | 8 +- 12 files changed, 517 insertions(+), 261 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e178ddd9e1e16d1a3f524…

1 0

Stefan Dösinger : wined3d: Remove unused enum entry.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 66738fbb87e9e870288d755d795736adb6692f5b URL: http://source.winehq.org/git/wine.git/?a=commit;h=66738fbb87e9e870288d755d7… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Jul 27 22:29:05 2008 -0500 wined3d: Remove unused enum entry. --- include/wine/wined3d_types.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/wine/wined3d_types.h b/include/wine/wined3d_types.h index bbfbcff..bf35b9f 100644 --- a/include/wine/wined3d_types.h +++ b/include/wine/wined3d_types.h @@ -1373,7 +1373,6 @@ typedef enum _WINED3DSURFTYPE { SURFACE_UNKNOWN = 0, /* Default / Unknown surface type */ SURFACE_OPENGL, /* OpenGL surface: Renders using libGL, needed for 3D */ SURFACE_GDI, /* User surface. No 3D, DirectDraw rendering with GDI */ - SURFACE_XRENDER /* Future dreams: Use XRENDER / EXA / whatever stuff */ } WINED3DSURFTYPE; #define WINED3DCAPS2_NO2DDURING3DSCENE 0x00000002L

1 0

Stefan Dösinger : wined3d: Move some swapchain code into a base class.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: e5de2fc82c8dc292878f72375a83f1fc4f3df787 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e5de2fc82c8dc292878f72375… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Jul 27 18:04:16 2008 -0500 wined3d: Move some swapchain code into a base class. --- dlls/wined3d/Makefile.in | 1 + dlls/wined3d/swapchain.c | 183 +++------------------------------------- dlls/wined3d/swapchain_base.c | 182 +++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h | 13 +++ 4 files changed, 209 insertions(+), 170 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e5de2fc82c8dc292878f7…

1 0

Juan Lang : crypt32: Free memory using the correct function on failure.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 1799ceb8c1a0764d9ae8077207f661ec55c01c07 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1799ceb8c1a0764d9ae807720… Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Aug 15 16:39:09 2008 -0700 crypt32: Free memory using the correct function on failure. --- dlls/crypt32/encode.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/dlls/crypt32/encode.c b/dlls/crypt32/encode.c index ee42a3d..0d62b02 100644 --- a/dlls/crypt32/encode.c +++ b/dlls/crypt32/encode.c @@ -1561,6 +1561,14 @@ static BOOL CRYPT_AsnEncodeUnicodeStringCoerce(const CERT_NAME_VALUE *value, return ret; } +static void CRYPT_FreeSpace(PCRYPT_ENCODE_PARA pEncodePara, LPVOID pv) +{ + if (pEncodePara && pEncodePara->pfnFree) + pEncodePara->pfnFree(pv); + else + LocalFree(pv); +} + static BOOL CRYPT_AsnEncodeNumericString(const CERT_NAME_VALUE *value, DWORD dwFlags, PCRYPT_ENCODE_PARA pEncodePara, BYTE *pbEncoded, DWORD *pcbEncoded) @@ -1602,7 +1610,7 @@ static BOOL CRYPT_AsnEncodeNumericString(const CERT_NAME_VALUE *value, } } if (!ret && (dwFlags & CRYPT_ENCODE_ALLOC_FLAG)) - CryptMemFree(*(BYTE **)pbEncoded); + CRYPT_FreeSpace(pEncodePara, *(BYTE **)pbEncoded); } } return ret; @@ -1656,7 +1664,7 @@ static BOOL CRYPT_AsnEncodePrintableString(const CERT_NAME_VALUE *value, } } if (!ret && (dwFlags & CRYPT_ENCODE_ALLOC_FLAG)) - CryptMemFree(*(BYTE **)pbEncoded); + CRYPT_FreeSpace(pEncodePara, *(BYTE **)pbEncoded); } } return ret; @@ -1703,7 +1711,7 @@ static BOOL CRYPT_AsnEncodeIA5String(const CERT_NAME_VALUE *value, } } if (!ret && (dwFlags & CRYPT_ENCODE_ALLOC_FLAG)) - CryptMemFree(*(BYTE **)pbEncoded); + CRYPT_FreeSpace(pEncodePara, *(BYTE **)pbEncoded); } } return ret;

1 0

Juan Lang : crypt32: Fix length calculation for decoding CRL_DIST_POINT_NAME.
by Alexandre Julliard 19 Aug '08

19 Aug '08

Module: wine Branch: master Commit: 9423f836ac76b8242a5870dbabe73b8f947252a0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9423f836ac76b8242a5870dba… Author: Juan Lang <juan.lang(a)gmail.com> Date: Fri Aug 15 16:19:11 2008 -0700 crypt32: Fix length calculation for decoding CRL_DIST_POINT_NAME. --- dlls/crypt32/decode.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c index a5df225..89c62ee 100644 --- a/dlls/crypt32/decode.c +++ b/dlls/crypt32/decode.c @@ -3919,15 +3919,19 @@ static BOOL CRYPT_AsnDecodeDistPointName(const BYTE *pbEncoded, sizeof(CERT_ALT_NAME_ENTRY), TRUE, offsetof(CERT_ALT_NAME_ENTRY, u.pwszURL) }; BYTE lenBytes = GET_LEN_BYTES(pbEncoded[1]); + DWORD nameLen; if (dataLen) { - DWORD nameLen; - ret = CRYPT_AsnDecodeArray(&arrayDesc, pbEncoded + 1 + lenBytes, cbEncoded - 1 - lenBytes, 0, NULL, NULL, &nameLen, NULL, NULL); - bytesNeeded = sizeof(CRL_DIST_POINT_NAME) + nameLen; + /* The CERT_ALT_NAME_INFO's size is included by CRYPT_AsnDecodeArray + * as the sizeof(struct GenericArray), so don't include it in the + * total bytes needed. + */ + bytesNeeded = sizeof(CRL_DIST_POINT_NAME) + nameLen - + sizeof(CERT_ALT_NAME_INFO); } else bytesNeeded = sizeof(CRL_DIST_POINT_NAME); @@ -3951,7 +3955,7 @@ static BOOL CRYPT_AsnDecodeDistPointName(const BYTE *pbEncoded, name->dwDistPointNameChoice = CRL_DIST_POINT_FULL_NAME; ret = CRYPT_AsnDecodeArray(&arrayDesc, pbEncoded + 1 + lenBytes, cbEncoded - 1 - lenBytes, - 0, NULL, &name->u.FullName, pcbStructInfo, NULL, + 0, NULL, &name->u.FullName, &nameLen, NULL, name->u.FullName.rgAltEntry); } else

1 0

← Newer
1
...
53
54
55
56
57
58
59
...
84
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2008