winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2008
----- 2025 -----
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1215 discussions
Start a n
N
ew thread
Jacek Caban : jscript: Added Math.ceil implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 90dd23cc4c7416288ff8d5cb45523f073011f21e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=90dd23cc4c7416288ff8d5cb4…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:46:45 2008 +0200 jscript: Added Math.ceil implementation. --- dlls/jscript/math.c | 21 ++++++++++++++++++--- dlls/jscript/tests/api.js | 15 +++++++++++++++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/dlls/jscript/math.c b/dlls/
…
[View More]
jscript/math.c index 8803f7c..e0e88e4 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -160,11 +160,27 @@ static HRESULT Math_atan2(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS return E_NOTIMPL; } +/* ECMA-262 3rd Edition 15.8.2.6 */ static HRESULT Math_ceil(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + VARIANT v; + HRESULT hres; + + TRACE("\n"); + + if(!arg_cnt(dp)) { + FIXME("arg_cnt = 0\n"); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &v); + if(FAILED(hres)) + return hres; + + if(retv) + num_set_val(retv, ceil(num_val(&v))); + return S_OK; } static HRESULT Math_cos(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, @@ -233,7 +249,6 @@ static HRESULT Math_max(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *d return S_OK; } - /* ECMA-262 3rd Edition 15.8.2.12 */ static HRESULT Math_min(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 7796623..d590308 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -279,6 +279,21 @@ ok(tmp === 1, "Math.round(true) = " + tmp); tmp = Math.round(1.1, 3, 4); ok(tmp === 1, "Math.round(1.1, 3, 4) = " + tmp); +tmp = Math.ceil(0.5); +ok(tmp === 1, "Math.ceil(0.5) = " + tmp); + +tmp = Math.ceil(-0.5); +ok(tmp === 0, "Math.ceil(-0.5) = " + tmp); + +tmp = Math.ceil(1.1); +ok(tmp === 2, "Math.round(1.1) = " + tmp); + +tmp = Math.ceil(true); +ok(tmp === 1, "Math.ceil(true) = " + tmp); + +tmp = Math.ceil(1.1, 3, 4); +ok(tmp === 2, "Math.ceil(1.1, 3, 4) = " + tmp); + tmp = Math.abs(3); ok(tmp === 3, "Math.abs(3) = " + tmp);
[View Less]
1
0
0
0
Jacek Caban : jscript: Added Math.pow implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: c4fe1b2efdb10c04a2a0fa984b42d7aa3e979880 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c4fe1b2efdb10c04a2a0fa984…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:46:22 2008 +0200 jscript: Added Math.pow implementation. --- dlls/jscript/math.c | 24 ++++++++++++++++++++++-- dlls/jscript/tests/api.js | 9 +++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/math.c b/dlls/
…
[View More]
jscript/math.c index dc6f365..8803f7c 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -272,11 +272,31 @@ static HRESULT Math_min(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *d return S_OK; } +/* ECMA-262 3rd Edition 15.8.2.13 */ static HRESULT Math_pow(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + VARIANT x, y; + HRESULT hres; + + TRACE("\n"); + + if(arg_cnt(dp) < 2) { + FIXME("unimplemented arg_cnt %d\n", arg_cnt(dp)); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &x); + if(FAILED(hres)) + return hres; + + hres = to_number(dispex->ctx, get_arg(dp, 1), ei, &y); + if(FAILED(hres)) + return hres; + + if(retv) + num_set_val(retv, pow(num_val(&x), num_val(&y))); + return S_OK; } static HRESULT Math_random(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 85bca45..7796623 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -291,4 +291,13 @@ ok(tmp === 1, "Math.abs(true) = " + tmp); tmp = Math.abs(-3, 2); ok(tmp === 3, "Math.abs(-3, 2) = " + tmp); +tmp = Math.pow(2, 2); +ok(tmp === 4, "Math.pow(2, 2) = " + tmp); + +tmp = Math.pow(4, 0.5); +ok(tmp === 2, "Math.pow(2, 2) = " + tmp); + +tmp = Math.pow(2, 2, 3); +ok(tmp === 4, "Math.pow(2, 2, 3) = " + tmp); + reportSuccess();
[View Less]
1
0
0
0
Jacek Caban : jscript: Added Math.max implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 37b69e9a9eac535bc14ed8ee8afbc80954b00d12 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=37b69e9a9eac535bc14ed8ee8…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:46:04 2008 +0200 jscript: Added Math.max implementation. --- dlls/jscript/math.c | 36 ++++++++++++++++++++++++++++++++++-- dlls/jscript/tests/api.js | 9 +++++++++ 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/math.
…
[View More]
c b/dlls/jscript/math.c index 74c01d1..dc6f365 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -195,13 +195,45 @@ static HRESULT Math_log(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *d return E_NOTIMPL; } +/* ECMA-262 3rd Edition 15.8.2.11 */ static HRESULT Math_max(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + DOUBLE max, d; + VARIANT v; + DWORD i; + HRESULT hres; + + TRACE("\n"); + + /* FIXME: Handle NaN */ + + if(!arg_cnt(dp)) { + FIXME("arg_cnt = 0\n"); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &v); + if(FAILED(hres)) + return hres; + + max = num_val(&v); + for(i=1; i < arg_cnt(dp); i++) { + hres = to_number(dispex->ctx, get_arg(dp, i), ei, &v); + if(FAILED(hres)) + return hres; + + d = num_val(&v); + if(d > max) + max = d; + } + + if(retv) + num_set_val(retv, max); + return S_OK; } + /* ECMA-262 3rd Edition 15.8.2.12 */ static HRESULT Math_min(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 65c4992..85bca45 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -255,6 +255,15 @@ ok(tmp === 0, "Math.min(1, false) = " + tmp); tmp = Math.min(1, false, true, null, -3); ok(tmp === -3, "Math.min(1, false, true, null, -3) = " + tmp); +tmp = Math.max(1); +ok(tmp === 1, "Math.max(1) = " + tmp); + +tmp = Math.max(true, 0); +ok(tmp === 1, "Math.max(true, 0) = " + tmp); + +tmp = Math.max(-2, false, true, null, 1); +ok(tmp === 1, "Math.max(-2, false, true, null, 1) = " + tmp); + tmp = Math.round(0.5); ok(tmp === 1, "Math.round(0.5) = " + tmp);
[View Less]
1
0
0
0
Jacek Caban : jscript: Added Math.abs implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 2149494c9dfbfe7cf0d90090a6c2929cf8d79ef6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2149494c9dfbfe7cf0d90090a…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:45:49 2008 +0200 jscript: Added Math.abs implementation. --- dlls/jscript/math.c | 22 ++++++++++++++++++++-- dlls/jscript/tests/api.js | 12 ++++++++++++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/math.c b/dlls/
…
[View More]
jscript/math.c index 2bcf5ad..74c01d1 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -107,11 +107,29 @@ static HRESULT Math_SQRT1_2(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAM return E_NOTIMPL; } +/* ECMA-262 3rd Edition 15.8.2.12 */ static HRESULT Math_abs(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + VARIANT v; + DOUBLE d; + HRESULT hres; + + TRACE("\n"); + + if(!arg_cnt(dp)) { + FIXME("arg_cnt = 0\n"); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &v); + if(FAILED(hres)) + return hres; + + d = num_val(&v); + if(retv) + num_set_val(retv, d < 0.0 ? -d : d); + return S_OK; } static HRESULT Math_acos(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 34a6456..65c4992 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -270,4 +270,16 @@ ok(tmp === 1, "Math.round(true) = " + tmp); tmp = Math.round(1.1, 3, 4); ok(tmp === 1, "Math.round(1.1, 3, 4) = " + tmp); +tmp = Math.abs(3); +ok(tmp === 3, "Math.abs(3) = " + tmp); + +tmp = Math.abs(-3); +ok(tmp === 3, "Math.abs(-3) = " + tmp); + +tmp = Math.abs(true); +ok(tmp === 1, "Math.abs(true) = " + tmp); + +tmp = Math.abs(-3, 2); +ok(tmp === 3, "Math.abs(-3, 2) = " + tmp); + reportSuccess();
[View Less]
1
0
0
0
Jacek Caban : jscript: Added Math.round implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: c395981b2fef13008a4aa807869b7d657f38abd3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c395981b2fef13008a4aa8078…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:45:25 2008 +0200 jscript: Added Math.round implementation. --- dlls/jscript/math.c | 20 ++++++++++++++++++-- dlls/jscript/tests/api.js | 15 +++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/math.c b/dlls/
…
[View More]
jscript/math.c index a2aa6a9..2bcf5ad 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -236,11 +236,27 @@ static HRESULT Math_random(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS return E_NOTIMPL; } +/* ECMA-262 3rd Edition 15.8.2.15 */ static HRESULT Math_round(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + VARIANT v; + HRESULT hres; + + TRACE("\n"); + + if(!arg_cnt(dp)) { + FIXME("arg_cnt = 0\n"); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &v); + if(FAILED(hres)) + return hres; + + if(retv) + num_set_val(retv, floor(num_val(&v)+0.5)); + return S_OK; } static HRESULT Math_sin(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 93f131d..34a6456 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -255,4 +255,19 @@ ok(tmp === 0, "Math.min(1, false) = " + tmp); tmp = Math.min(1, false, true, null, -3); ok(tmp === -3, "Math.min(1, false, true, null, -3) = " + tmp); +tmp = Math.round(0.5); +ok(tmp === 1, "Math.round(0.5) = " + tmp); + +tmp = Math.round(-0.5); +ok(tmp === 0, "Math.round(-0.5) = " + tmp); + +tmp = Math.round(1.1); +ok(tmp === 1, "Math.round(1.1) = " + tmp); + +tmp = Math.round(true); +ok(tmp === 1, "Math.round(true) = " + tmp); + +tmp = Math.round(1.1, 3, 4); +ok(tmp === 1, "Math.round(1.1, 3, 4) = " + tmp); + reportSuccess();
[View Less]
1
0
0
0
Jacek Caban : jscript: Added Math.min implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 50a24a4a1378e9bca1b6ff65055ab6d186048ee9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=50a24a4a1378e9bca1b6ff650…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:45:00 2008 +0200 jscript: Added Math.min implementation. --- dlls/jscript/math.c | 37 +++++++++++++++++++++++++++++++++++-- dlls/jscript/tests/api.js | 9 +++++++++ 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/math.
…
[View More]
c b/dlls/jscript/math.c index 8454cfa..a2aa6a9 100644 --- a/dlls/jscript/math.c +++ b/dlls/jscript/math.c @@ -16,6 +16,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <math.h> + #include "jscript.h" #include "wine/debug.h" @@ -182,11 +184,42 @@ static HRESULT Math_max(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *d return E_NOTIMPL; } +/* ECMA-262 3rd Edition 15.8.2.12 */ static HRESULT Math_min(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + DOUBLE min, d; + VARIANT v; + DWORD i; + HRESULT hres; + + TRACE("\n"); + + /* FIXME: Handle NaN */ + + if(!arg_cnt(dp)) { + FIXME("arg_cnt = 0\n"); + return E_NOTIMPL; + } + + hres = to_number(dispex->ctx, get_arg(dp, 0), ei, &v); + if(FAILED(hres)) + return hres; + + min = num_val(&v); + for(i=1; i < arg_cnt(dp); i++) { + hres = to_number(dispex->ctx, get_arg(dp, i), ei, &v); + if(FAILED(hres)) + return hres; + + d = num_val(&v); + if(d < min) + min = d; + } + + if(retv) + num_set_val(retv, min); + return S_OK; } static HRESULT Math_pow(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 04515e3..93f131d 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -246,4 +246,13 @@ ok(Number() === 0, "Number() = " + Number()); ok(Number(false) === 0, "Number(false) = " + Number(false)); ok(Number("43") === 43, "Number('43') = " + Number("43")); +tmp = Math.min(1); +ok(tmp === 1, "Math.min(1) = " + tmp); + +tmp = Math.min(1, false); +ok(tmp === 0, "Math.min(1, false) = " + tmp); + +tmp = Math.min(1, false, true, null, -3); +ok(tmp === -3, "Math.min(1, false, true, null, -3) = " + tmp); + reportSuccess();
[View Less]
1
0
0
0
Jacek Caban : jscript: Added String function implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 17ceb90b30f14fba20c8205870f2a2f89f7a1e6b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=17ceb90b30f14fba20c820587…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:44:29 2008 +0200 jscript: Added String function implementation. --- dlls/jscript/string.c | 19 +++++++++++++++++++ dlls/jscript/tests/api.js | 11 +++++++++++ 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/string.c b/
…
[View More]
dlls/jscript/string.c index 9da1bfb..d4f58cd 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -772,7 +772,26 @@ static HRESULT StringConstr_value(DispatchEx *dispex, LCID lcid, WORD flags, DIS { HRESULT hres; + TRACE("\n"); + switch(flags) { + case INVOKE_FUNC: { + BSTR str; + + if(arg_cnt(dp)) { + hres = to_string(dispex->ctx, get_arg(dp, 0), ei, &str); + if(FAILED(hres)) + return hres; + }else { + str = SysAllocStringLen(NULL, 0); + if(!str) + return E_OUTOFMEMORY; + } + + V_VT(retv) = VT_BSTR; + V_BSTR(retv) = str; + break; + } case DISPATCH_CONSTRUCT: { DispatchEx *ret; diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index cea936d..04515e3 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -69,6 +69,17 @@ ok(str.toString() === "test", "str.toString() = " + str.toString()); tmp = "value " + str; ok(tmp === "value test", "'value ' + str = " + tmp); +tmp = String(); +ok(tmp === "", "String() = " + tmp); +tmp = String(false); +ok(tmp === "false", "String(false) = " + tmp); +tmp = String(null); +ok(tmp === "null", "String(null) = " + tmp); +tmp = String("test"); +ok(tmp === "test", "String('test') = " + tmp); +tmp = String("test", "abc"); +ok(tmp === "test", "String('test','abc') = " + tmp); + tmp = "abc".charAt(0); ok(tmp === "a", "'abc',charAt(0) = " + tmp); tmp = "abc".charAt(1);
[View Less]
1
0
0
0
Jacek Caban : jscript: Added String.concat implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 6751644835cc374baf5e04b80d878cee9f69c956 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6751644835cc374baf5e04b80…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:44:13 2008 +0200 jscript: Added String.concat implementation. --- dlls/jscript/string.c | 55 +++++++++++++++++++++++++++++++++++++++++++- dlls/jscript/tests/api.js | 7 +++++ 2 files changed, 60 insertions(+), 2 deletions(-) diff --git a/dlls/
…
[View More]
jscript/string.c b/dlls/jscript/string.c index b56fd9e..9da1bfb 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -241,11 +241,62 @@ static HRESULT String_charCodeAt(DispatchEx *dispex, LCID lcid, WORD flags, DISP return S_OK; } +/* ECMA-262 3rd Edition 15.5.4.6 */ static HRESULT String_concat(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + BSTR *strs = NULL, ret = NULL; + DWORD len = 0, i, l, str_cnt; + VARIANT var; + WCHAR *ptr; + HRESULT hres; + + TRACE("\n"); + + str_cnt = arg_cnt(dp)+1; + strs = heap_alloc_zero(str_cnt * sizeof(BSTR)); + if(!strs) + return E_OUTOFMEMORY; + + V_VT(&var) = VT_DISPATCH; + V_DISPATCH(&var) = (IDispatch*)_IDispatchEx_(dispex); + + hres = to_string(dispex->ctx, &var, ei, strs); + if(SUCCEEDED(hres)) { + for(i=0; i < arg_cnt(dp); i++) { + hres = to_string(dispex->ctx, get_arg(dp, i), ei, strs+i+1); + if(FAILED(hres)) + break; + } + } + + if(SUCCEEDED(hres)) { + for(i=0; i < str_cnt; i++) + len += SysStringLen(strs[i]); + + ptr = ret = SysAllocStringLen(NULL, len); + + for(i=0; i < str_cnt; i++) { + l = SysStringLen(strs[i]); + memcpy(ptr, strs[i], l*sizeof(WCHAR)); + ptr += l; + } + } + + for(i=0; i < str_cnt; i++) + SysFreeString(strs[i]); + heap_free(strs); + + if(FAILED(hres)) + return hres; + + if(retv) { + V_VT(retv) = VT_BSTR; + V_BSTR(retv) = ret; + }else { + SysFreeString(ret); + } + return S_OK; } static HRESULT String_fixed(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 707eacf..cea936d 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -133,6 +133,13 @@ ok(tmp === "abcd", "'abcd'.slice() = " + tmp); tmp = "abcd".slice(1); ok(tmp === "bcd", "'abcd'.slice(1) = " + tmp); +tmp = "abc".concat(["d",1],2,false); +ok(tmp === "abcd,12false", "concat returned " + tmp); +var arr = new Array(2,"a"); +arr.concat = String.prototype.concat; +tmp = arr.concat("d"); +ok(tmp === "2,ad", "arr.concat = " + tmp); + var arr = new Array(); ok(typeof(arr) === "object", "arr () is not object"); ok((arr.length === 0), "arr.length is not 0");
[View Less]
1
0
0
0
Jacek Caban : jscript: Added String default value implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 1f134b41b32dc92738fcbb1730e68c72845d7f06 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1f134b41b32dc92738fcbb173…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:43:50 2008 +0200 jscript: Added String default value implementation. --- dlls/jscript/string.c | 22 ++++++++++++++++++++-- dlls/jscript/tests/api.js | 3 +++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/string.c b/
…
[View More]
dlls/jscript/string.c index 656b9ec..b56fd9e 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -638,8 +638,26 @@ static HRESULT String_isPrototypeOf(DispatchEx *dispex, LCID lcid, WORD flags, D static HRESULT String_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + StringInstance *This = (StringInstance*)dispex; + + TRACE("\n"); + + switch(flags) { + case DISPATCH_PROPERTYGET: { + BSTR str = SysAllocString(This->str); + if(!str) + return E_OUTOFMEMORY; + + V_VT(retv) = VT_BSTR; + V_BSTR(retv) = str; + break; + } + default: + FIXME("flags %x\n", flags); + return E_NOTIMPL; + } + + return S_OK; } static void String_destructor(DispatchEx *dispex) diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index f86ea1a..707eacf 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -66,6 +66,9 @@ ok(str.toString() === "", "str.toString() = " + str.toString()); var str = new String("test", "abc"); ok(str.toString() === "test", "str.toString() = " + str.toString()); +tmp = "value " + str; +ok(tmp === "value test", "'value ' + str = " + tmp); + tmp = "abc".charAt(0); ok(tmp === "a", "'abc',charAt(0) = " + tmp); tmp = "abc".charAt(1);
[View Less]
1
0
0
0
Jacek Caban : jscript: Added String constructor implementation.
by Alexandre Julliard
22 Sep '08
22 Sep '08
Module: wine Branch: master Commit: 3925f13023161e9beda334a61b026ba78c58df4b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3925f13023161e9beda334a61…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Sep 21 15:43:32 2008 +0200 jscript: Added String constructor implementation. --- dlls/jscript/string.c | 35 +++++++++++++++++++++++++++++++++-- dlls/jscript/tests/api.js | 7 +++++++ 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/dlls/
…
[View More]
jscript/string.c b/dlls/jscript/string.c index d6a7a71..656b9ec 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -701,8 +701,39 @@ static const builtin_info_t String_info = { static HRESULT StringConstr_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + HRESULT hres; + + switch(flags) { + case DISPATCH_CONSTRUCT: { + DispatchEx *ret; + + if(arg_cnt(dp)) { + BSTR str; + + hres = to_string(dispex->ctx, get_arg(dp, 0), ei, &str); + if(FAILED(hres)) + return hres; + + hres = create_string(dispex->ctx, str, SysStringLen(str), &ret); + SysFreeString(str); + }else { + hres = create_string(dispex->ctx, NULL, 0, &ret); + } + + if(FAILED(hres)) + return hres; + + V_VT(retv) = VT_DISPATCH; + V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(ret); + break; + } + + default: + FIXME("unimplemented flags: %x\n", flags); + return E_NOTIMPL; + } + + return S_OK; } static HRESULT string_alloc(script_ctx_t *ctx, BOOL use_constr, StringInstance **ret) diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 8237ddb..f86ea1a 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -59,6 +59,13 @@ ok(tmp === "test", "''.valueOf() = " + tmp); tmp = "test".valueOf(3); ok(tmp === "test", "''.valueOf(3) = " + tmp); +var str = new String("test"); +ok(str.toString() === "test", "str.toString() = " + str.toString()); +var str = new String(); +ok(str.toString() === "", "str.toString() = " + str.toString()); +var str = new String("test", "abc"); +ok(str.toString() === "test", "str.toString() = " + str.toString()); + tmp = "abc".charAt(0); ok(tmp === "a", "'abc',charAt(0) = " + tmp); tmp = "abc".charAt(1);
[View Less]
1
0
0
0
← Newer
1
...
24
25
26
27
28
29
30
...
122
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
Results per page:
10
25
50
100
200