winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2008
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1215 discussions
Start a n
N
ew thread
Dmitry Timoshkov : user32: Implement SystemParametersInfo(SPI_GETWORKAREA) properly.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: c707e7d9a6a5c804b3ae286c9bd8bab279327dc6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c707e7d9a6a5c804b3ae286c9…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Sep 11 13:20:15 2008 +0900 user32: Implement SystemParametersInfo(SPI_GETWORKAREA) properly. --- dlls/user32/sysparams.c | 16 +++++++++++++++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/dlls/user32/sysparams.c b/dlls/user32/sysparams.c
…
[View More]
index 6e260ea..fc5785a 100644 --- a/dlls/user32/sysparams.c +++ b/dlls/user32/sysparams.c @@ -1139,6 +1139,19 @@ static void load_nonclient_metrics(void) spi_loaded[SPI_NONCLIENTMETRICS_IDX] = TRUE; } +static BOOL CALLBACK enum_monitors( HMONITOR monitor, HDC hdc, LPRECT rect, LPARAM lp ) +{ + MONITORINFO mi; + + mi.cbSize = sizeof(mi); + if (GetMonitorInfoW( monitor, &mi ) && (mi.dwFlags & MONITORINFOF_PRIMARY)) + { + LPRECT work = (LPRECT)lp; + *work = mi.rcWork; + return FALSE; + } + return TRUE; +} /*********************************************************************** * SystemParametersInfoW (USER32.@) @@ -1725,10 +1738,11 @@ BOOL WINAPI SystemParametersInfoW( UINT uiAction, UINT uiParam, SetRect( &work_area, 0, 0, GetSystemMetrics( SM_CXSCREEN ), GetSystemMetrics( SM_CYSCREEN ) ); + EnumDisplayMonitors( 0, NULL, enum_monitors, (LPARAM)&work_area ); spi_loaded[spi_idx] = TRUE; } CopyRect( (RECT *)pvParam, &work_area ); - + TRACE("work area %s\n", wine_dbgstr_rect( &work_area )); break; }
[View Less]
1
0
0
0
Dmitry Timoshkov : user32: Make GetMonitorInfoW print the monitor properties.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: 5587387c9f07e0632d81090a1364b749156c90fd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5587387c9f07e0632d81090a1…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Sep 11 13:13:14 2008 +0900 user32: Make GetMonitorInfoW print the monitor properties. --- dlls/user32/misc.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c index f91be62..9de9b91 100644 ---
…
[View More]
a/dlls/user32/misc.c +++ b/dlls/user32/misc.c @@ -477,7 +477,12 @@ BOOL WINAPI GetMonitorInfoA(HMONITOR hMonitor, LPMONITORINFO lpMonitorInfo) */ BOOL WINAPI GetMonitorInfoW(HMONITOR hMonitor, LPMONITORINFO lpMonitorInfo) { - return USER_Driver->pGetMonitorInfo( hMonitor, lpMonitorInfo ); + BOOL ret = USER_Driver->pGetMonitorInfo( hMonitor, lpMonitorInfo ); + if (ret) + TRACE("flags %04x, monitor %s, work %s\n", lpMonitorInfo->dwFlags, + wine_dbgstr_rect(&lpMonitorInfo->rcMonitor), + wine_dbgstr_rect(&lpMonitorInfo->rcWork)); + return ret; } /***********************************************************************
[View Less]
1
0
0
0
Dmitry Timoshkov : winedevice: Wine PE loader is able to resolve forwards to not yet loaded modules.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: a2a3c59a45c1f849ced2ed8901e04cdbfa4b7df9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a2a3c59a45c1f849ced2ed890…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Sep 11 13:00:40 2008 +0900 winedevice: Wine PE loader is able to resolve forwards to not yet loaded modules. --- programs/winedevice/device.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/programs/winedevice/device.c b/programs/
…
[View More]
winedevice/device.c index d48017a..5a1ba99 100644 --- a/programs/winedevice/device.c +++ b/programs/winedevice/device.c @@ -186,9 +186,6 @@ static BOOL load_driver(void) HeapFree( GetProcessHeap(), 0, str ); if (!path) return FALSE; - /* make sure msvcrt is loaded to resolve the ntoskrnl.exe forwards */ - LoadLibraryA( "msvcrt.dll" ); - /* GameGuard uses an NT-style path name */ str = path; if (!strncmpW( path, ntprefixW, 4 )) str += 4;
[View Less]
1
0
0
0
Dmitry Timoshkov : kernel32: Use a kernel error code.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: 4d672ba090bc6d6d6f66cffce09ec0e1ad2167bb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4d672ba090bc6d6d6f66cffce…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Sep 11 12:55:09 2008 +0900 kernel32: Use a kernel error code. --- dlls/kernel32/tests/profile.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index 9cccac2..8a3e83b 100644
…
[View More]
--- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -183,13 +183,14 @@ static void test_profile_sections(void) ok( GetLastError() == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); /* And a real one */ + SetLastError(0xdeadbeef); ret=GetPrivateProfileSectionA("section1", buf, sizeof(buf), testfile4); for( p = buf + strlen(buf) + 1; *p;p += strlen(p)+1) p[-1] = ','; ok( ret == 35 && !strcmp( buf, "name1=val1,name2=,name3,name4=val4"), "wrong section returned(%d): %s\n", ret, buf); ok( buf[ret-1] == 0 && buf[ret] == 0, "returned buffer not terminated with double-null\n" ); - ok( GetLastError() == S_OK, "expected S_OK, got %d\n", GetLastError()); + ok( GetLastError() == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", GetLastError()); DeleteFileA( testfile4 ); }
[View Less]
1
0
0
0
Dmitry Timoshkov : winex11.drv: Fix the scan codes keypad keys section to match the vkeys one.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: 73569a95c19cdb5d6231730ac0df703c72d6111f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=73569a95c19cdb5d6231730ac…
Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Sep 11 11:59:32 2008 +0900 winex11.drv: Fix the scan codes keypad keys section to match the vkeys one. --- dlls/winex11.drv/keyboard.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/
…
[View More]
keyboard.c index bf399c9..fe0e840 100644 --- a/dlls/winex11.drv/keyboard.c +++ b/dlls/winex11.drv/keyboard.c @@ -1063,7 +1063,7 @@ static const WORD nonchar_key_scan[256] = /*?*/ 0, /*?*/ 0, 0x38, 0x146, 0x00, 0x00, 0x00, 0x00, /* FF68 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* FF70 */ /* keypad keys */ - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x138, 0x145, /* FF78 */ + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x145, /* FF78 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* FF80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x11C, 0x00, 0x00, /* FF88 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x47, 0x4B, 0x48, /* FF90 */
[View Less]
1
0
0
0
Roy Shea : shell32: Use default system icons if PrivateExtractIconsW in SHGetFileInfoW fails.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: 5b6806922aedc00e445f009389b2832c5da690ac URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5b6806922aedc00e445f00938…
Author: Roy Shea <royshea(a)gmail.com> Date: Wed Sep 10 14:33:02 2008 -0700 shell32: Use default system icons if PrivateExtractIconsW in SHGetFileInfoW fails. --- dlls/shell32/shell32_main.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/
…
[View More]
shell32_main.c index 9c400e4..a0d3fe7 100644 --- a/dlls/shell32/shell32_main.c +++ b/dlls/shell32/shell32_main.c @@ -596,18 +596,22 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, } else { - IconNotYetLoaded=FALSE; + UINT ret; if (flags & SHGFI_SMALLICON) - PrivateExtractIconsW( sTemp,icon_idx, + ret = PrivateExtractIconsW( sTemp,icon_idx, GetSystemMetrics( SM_CXSMICON ), GetSystemMetrics( SM_CYSMICON ), &psfi->hIcon, 0, 1, 0); else - PrivateExtractIconsW( sTemp, icon_idx, + ret = PrivateExtractIconsW( sTemp, icon_idx, GetSystemMetrics( SM_CXICON), GetSystemMetrics( SM_CYICON), &psfi->hIcon, 0, 1, 0); - psfi->iIcon = icon_idx; + if (ret != 0 && ret != 0xFFFFFFFF) + { + IconNotYetLoaded=FALSE; + psfi->iIcon = icon_idx; + } } } }
[View Less]
1
0
0
0
Rob Shearman : widl: Remove redundant code.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: e0dd72162ac1c7ba0eb8856e1c8fd5ce2a1410be URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e0dd72162ac1c7ba0eb8856e1…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Wed Sep 10 22:31:39 2008 +0100 widl: Remove redundant code. dispinterfaces now have a type of RPC_FC_IP instead of 0, so this code will never be reached. --- tools/widl/write_msft.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/tools/
…
[View More]
widl/write_msft.c b/tools/widl/write_msft.c index 28a74f2..30ed251 100644 --- a/tools/widl/write_msft.c +++ b/tools/widl/write_msft.c @@ -1005,10 +1005,7 @@ static int encode_type( add_coclass_typeinfo(typelib, type); break; case 0: - if (type->kind == TKIND_DISPATCH) - add_dispinterface_typeinfo(typelib, type); - else - error("encode_type: VT_USERDEFINED - can't yet add typedef's on the fly\n"); + error("encode_type: VT_USERDEFINED - can't yet add typedef's on the fly\n"); break; default: error("encode_type: VT_USERDEFINED - unhandled type %d\n", type->type);
[View Less]
1
0
0
0
Juan Lang : riched20: Use helper function rather than goto to return found position.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: fb30d61c97641c82b2a5dc2e130bd951709f5f7c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fb30d61c97641c82b2a5dc2e1…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Sep 10 11:08:46 2008 -0700 riched20: Use helper function rather than goto to return found position. --- dlls/riched20/caret.c | 36 ++++++++++++++++++++---------------- 1 files changed, 20 insertions(+), 16 deletions(-) diff --git a/dlls/riched20/caret.c b/dlls/
…
[View More]
riched20/caret.c index 376318e..1780bc0 100644 --- a/dlls/riched20/caret.c +++ b/dlls/riched20/caret.c @@ -889,6 +889,23 @@ static ME_DisplayItem* ME_FindPixelPosInTableRow(int x, int y, return para; } +static BOOL ME_ReturnFoundPos(ME_TextEditor *editor, ME_DisplayItem *found, + ME_Cursor *result, int rx, BOOL isExact) +{ + assert(found); + assert(found->type == diRun); + if ((found->member.run.nFlags & MERF_ENDPARA) || rx < 0) + rx = 0; + result->pRun = found; + result->nOffset = ME_CharFromPointCursor(editor, rx, &found->member.run); + if (editor->pCursors[0].nOffset == found->member.run.strText->nLen && rx) + { + result->pRun = ME_FindItemFwd(editor->pCursors[0].pRun, diRun); + result->nOffset = 0; + } + return isExact; +} + /* Finds the run and offset from the pixel position. * * x & y are pixel positions in virtual coordinates into the rich edit control, @@ -963,34 +980,21 @@ static BOOL ME_FindPixelPos(ME_TextEditor *editor, int x, int y, case diRun: rx = x - p->member.run.pt.x; if (rx < p->member.run.nWidth) - { - found_here: - assert(p->type == diRun); - if ((p->member.run.nFlags & MERF_ENDPARA) || rx < 0) - rx = 0; - result->pRun = p; - result->nOffset = ME_CharFromPointCursor(editor, rx, &p->member.run); - if (editor->pCursors[0].nOffset == p->member.run.strText->nLen && rx) - { - result->pRun = ME_FindItemFwd(editor->pCursors[0].pRun, diRun); - result->nOffset = 0; - } - return isExact; - } + return ME_ReturnFoundPos(editor, p, result, rx, isExact); break; case diStartRow: isExact = FALSE; p = ME_FindItemFwd(p, diRun); if (is_eol) *is_eol = 1; rx = 0; /* FIXME not sure */ - goto found_here; + return ME_ReturnFoundPos(editor, p, result, rx, isExact); case diCell: case diParagraph: case diTextEnd: isExact = FALSE; rx = 0; /* FIXME not sure */ p = last; - goto found_here; + return ME_ReturnFoundPos(editor, p, result, rx, isExact); default: assert(0); } last = p;
[View Less]
1
0
0
0
Juan Lang : user32: Return error if memory allocation fails. Fixes Coverity id 115.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: 1a5374065fe31e4a1363d5bd25c6e998d387e2a3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1a5374065fe31e4a1363d5bd2…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Sep 10 10:14:13 2008 -0700 user32: Return error if memory allocation fails. Fixes Coverity id 115. --- dlls/user32/listbox.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/user32/listbox.c b/dlls/user32/listbox.c index ee326c6..0c24e71
…
[View More]
100644 --- a/dlls/user32/listbox.c +++ b/dlls/user32/listbox.c @@ -2658,6 +2658,8 @@ static LRESULT WINAPI ListBoxWndProc_common( HWND hwnd, UINT msg, INT countW = MultiByteToWideChar(CP_ACP, 0, textA, -1, NULL, 0); if((textW = HeapAlloc(GetProcessHeap(), 0, countW * sizeof(WCHAR)))) MultiByteToWideChar(CP_ACP, 0, textA, -1, textW, countW); + else + return LB_ERRSPACE; } wParam = LISTBOX_FindStringPos( descr, textW, FALSE ); ret = LISTBOX_InsertString( descr, wParam, textW ); @@ -2682,6 +2684,8 @@ static LRESULT WINAPI ListBoxWndProc_common( HWND hwnd, UINT msg, INT countW = MultiByteToWideChar(CP_ACP, 0, textA, -1, NULL, 0); if((textW = HeapAlloc(GetProcessHeap(), 0, countW * sizeof(WCHAR)))) MultiByteToWideChar(CP_ACP, 0, textA, -1, textW, countW); + else + return LB_ERRSPACE; } ret = LISTBOX_InsertString( descr, wParam, textW ); if(!unicode && HAS_STRINGS(descr)) @@ -2704,6 +2708,8 @@ static LRESULT WINAPI ListBoxWndProc_common( HWND hwnd, UINT msg, INT countW = MultiByteToWideChar(CP_ACP, 0, textA, -1, NULL, 0); if((textW = HeapAlloc(GetProcessHeap(), 0, countW * sizeof(WCHAR)))) MultiByteToWideChar(CP_ACP, 0, textA, -1, textW, countW); + else + return LB_ERRSPACE; } wParam = LISTBOX_FindFileStrPos( descr, textW ); ret = LISTBOX_InsertString( descr, wParam, textW );
[View Less]
1
0
0
0
Juan Lang : crypt32: Don't set salt's cbData unless allocation succeeds. Fixes Coverity id 133.
by Alexandre Julliard
11 Sep '08
11 Sep '08
Module: wine Branch: master Commit: c958a71df9b5dfe0292de8608219baffb6e0e196 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c958a71df9b5dfe0292de8608…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Sep 10 09:39:23 2008 -0700 crypt32: Don't set salt's cbData unless allocation succeeds. Fixes Coverity id 133. --- dlls/crypt32/protectdata.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/crypt32/protectdata.c b/dlls/crypt32/protectdata.
…
[View More]
c index d3e0034..d86dd8e 100644 --- a/dlls/crypt32/protectdata.c +++ b/dlls/crypt32/protectdata.c @@ -607,8 +607,7 @@ BOOL fill_protect_data(struct protect_data_t * pInfo, LPCWSTR szDataDescr, pInfo->hash_len=CRYPT32_PROTECTDATA_HASH_LEN; /* allocate memory to hold a salt */ - pInfo->salt.cbData=CRYPT32_PROTECTDATA_SALT_LEN; - if ((pInfo->salt.pbData=CryptMemAlloc(pInfo->salt.cbData))) + if ((pInfo->salt.pbData=CryptMemAlloc(CRYPT32_PROTECTDATA_SALT_LEN))) { /* generate random salt */ if (!CryptGenRandom(hProv, pInfo->salt.cbData, pInfo->salt.pbData)) @@ -617,6 +616,7 @@ BOOL fill_protect_data(struct protect_data_t * pInfo, LPCWSTR szDataDescr, free_protect_data(pInfo); return FALSE; } + pInfo->salt.cbData=CRYPT32_PROTECTDATA_SALT_LEN; } /* debug: show our salt */
[View Less]
1
0
0
0
← Newer
1
...
66
67
68
69
70
71
72
...
122
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
Results per page:
10
25
50
100
200