winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2008
----- 2025 -----
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1215 discussions
Start a n
N
ew thread
Rob Shearman : include: Use placeholder structures with at least one field in vmr9.idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: b49835229e333e0075215afef9ed151107d23da7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b49835229e333e0075215afef…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:51 2008 +0100 include: Use placeholder structures with at least one field in vmr9.idl. MIDL won't parse structures with no fields. --- include/vmr9.idl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/vmr9.idl b/include/vmr9.idl index b7f916c..bb3681c 100644 --- a/include/vmr9.idl +++ b/include/vmr9.idl @@ -25,8 +25,8 @@ typedef LONGLONG REFERENCE_TIME; typedef DWORD D3DFORMAT; typedef DWORD D3DPOOL; typedef HANDLE HMONITOR; -typedef struct { } AM_MEDIA_TYPE; -typedef struct { } D3DCOLOR; +typedef struct { char dummy; } AM_MEDIA_TYPE; +typedef struct { char dummy; } D3DCOLOR; cpp_quote("#endif") interface IVMRSurface9;
1
0
0
0
Rob Shearman : include: Add XMLDOMDocumentEvents dispinterface to xmldom. idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: fa441c9dd07f091d16e6a904fa5e632e74b85721 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fa441c9dd07f091d16e6a904f…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:47 2008 +0100 include: Add XMLDOMDocumentEvents dispinterface to xmldom.idl. --- include/xmldom.idl | 14 ++++++++++++++ include/xmldomdid.h | 4 ++++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/xmldom.idl b/include/xmldom.idl index bf85acf..31c5e66 100644 --- a/include/xmldom.idl +++ b/include/xmldom.idl @@ -720,6 +720,20 @@ interface IXMLDOMParseError : IDispatch HRESULT filepos([retval, out] long * filePos); } +[ + hidden, + uuid(3efaa427-272f-11d2-836f-0000f87a7782) +] +dispinterface XMLDOMDocumentEvents +{ + properties: + methods: + [id(DISPID_XMLDOMEVENT_ONDATAAVAILABLE)] + HRESULT ondataavailable(); + + [id(DISPID_XMLDOMEVENT_ONREADYSTATECHANGE)] + HRESULT onreadystatechange(); +} [ uuid(2933bf90-7b36-11d2-b20e-00c04f983e60) diff --git a/include/xmldomdid.h b/include/xmldomdid.h index a299157..d241a9c 100644 --- a/include/xmldomdid.h +++ b/include/xmldomdid.h @@ -197,5 +197,9 @@ #define DISPID_DOM_ERROR_FILEPOS 0x000000b7 #define DISPID_DOM_ERROR__TOP 0x000000b8 +#define DISPID_XMLDOMEVENT 197 +#define DISPID_XMLDOMEVENT_ONREADYSTATECHANGE DISPID_READYSTATECHANGE +#define DISPID_XMLDOMEVENT_ONDATAAVAILABLE 198 +#define DISPID_XMLDOMEVENT__TOP 199 #endif /* __XMLDOMDID_H__ */
1
0
0
0
Rob Shearman : include: The INewShortcutHookA, INewShortcutHookW and IRunnableTask interface in shobjidl. idl should be local.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: d65920df77590097905d13bbaf8b997ab40392be URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d65920df77590097905d13bba…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:42 2008 +0100 include: The INewShortcutHookA, INewShortcutHookW and IRunnableTask interface in shobjidl.idl should be local. They are declared such that they cannot be used over the network and cause errors in MIDL when they are not declared local. --- include/shobjidl.idl | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 23a1fde..7a4bd88 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -1248,7 +1248,8 @@ cpp_quote("#define INewShortcutHook WINELIB_NAME_AW(INewShortcutHook)") [ object, uuid(000214e1-0000-0000-c000-000000000046), - pointer_default(unique) + pointer_default(unique), + local ] interface INewShortcutHookA : IUnknown { @@ -1278,7 +1279,8 @@ interface INewShortcutHookA : IUnknown [ object, uuid(000214f7-0000-0000-c000-000000000046), - pointer_default(unique) + pointer_default(unique), + local ] interface INewShortcutHookW : IUnknown { @@ -1307,7 +1309,8 @@ interface INewShortcutHookW : IUnknown [ object, uuid(85788d00-6807-11d0-b810-00c04fd706ec), - pointer_default(unique) + pointer_default(unique), + local ] interface IRunnableTask : IUnknown {
1
0
0
0
Rob Shearman : include: Fix signature of NearestPoint function of IInkDisp interface in msinkaut. idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: c36682685a5c713fd93145ee28b27d9f0645f467 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c36682685a5c713fd93145ee2…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:33 2008 +0100 include: Fix signature of NearestPoint function of IInkDisp interface in msinkaut.idl. Since the PointOnStroke and DistanceFromPacket parameters are [in, out] parameters the must be pointers. --- include/msinkaut.idl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/msinkaut.idl b/include/msinkaut.idl index 607229d..12dc107 100644 --- a/include/msinkaut.idl +++ b/include/msinkaut.idl @@ -637,8 +637,8 @@ cpp_quote("#endif /* _WINGDI_ */") HRESULT NearestPoint( [in] long X, [in] long Y, - [in, out] float PointOnStroke, - [in, out] float DistanceFromPacket, + [in, out] float *PointOnStroke, + [in, out] float *DistanceFromPacket, [out, retval] IInkStrokeDisp **Stroke); HRESULT CreateStrokes( [in] VARIANT StrokeIds,
1
0
0
0
Rob Shearman : include: Fix level of indirection of parameters in GetNotifyCmdLine function of IBackgroundCopyJob2 interface in bits1_5 .idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: 244b14ba36e4ff89338138b64fb4cd0b29c81454 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=244b14ba36e4ff89338138b64…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:22 2008 +0100 include: Fix level of indirection of parameters in GetNotifyCmdLine function of IBackgroundCopyJob2 interface in bits1_5.idl. The parameters should be double pointers to strings, not pointers to strings. --- dlls/qmgr/job.c | 4 ++-- include/bits1_5.idl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c index 32dadd8..e344027 100644 --- a/dlls/qmgr/job.c +++ b/dlls/qmgr/job.c @@ -456,8 +456,8 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_SetNotifyCmdLine( static HRESULT WINAPI BITS_IBackgroundCopyJob_GetNotifyCmdLine( IBackgroundCopyJob2 *iface, - LPWSTR prog, - LPWSTR params) + LPWSTR *prog, + LPWSTR *params) { FIXME("Not implemented\n"); return E_NOTIMPL; diff --git a/include/bits1_5.idl b/include/bits1_5.idl index 0bb27ca..274a7de 100644 --- a/include/bits1_5.idl +++ b/include/bits1_5.idl @@ -30,7 +30,7 @@ import "bits.idl"; interface IBackgroundCopyJob2 : IBackgroundCopyJob { HRESULT SetNotifyCmdLine([unique] LPCWSTR prog, [unique] LPCWSTR params); - HRESULT GetNotifyCmdLine([out] LPWSTR prog, [out] LPWSTR params); + HRESULT GetNotifyCmdLine([out] LPWSTR *prog, [out] LPWSTR *params); typedef struct _BG_JOB_REPLY_PROGRESS {
1
0
0
0
Rob Shearman : include: Uncomment declaration of IDirectShowStream in amstream.idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: 10208999c53dd647a08890a6a61a6b90a7389f50 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=10208999c53dd647a08890a6a…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:14 2008 +0100 include: Uncomment declaration of IDirectShowStream in amstream.idl. Also remove incorrect [optional] attributes from parameters. --- include/amstream.idl | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/amstream.idl b/include/amstream.idl index 1433f7a..d1cdd4c 100644 --- a/include/amstream.idl +++ b/include/amstream.idl @@ -64,7 +64,6 @@ typedef [v1_enum] enum { RenderData = 2 } OUTPUT_STATE; -/* [ object, uuid(7DB01C96-C0C3-11d0-8FF1-00C04FD9189D), @@ -81,7 +80,6 @@ interface IDirectShowStream : IDispatch [propget, id(3), helpstring("property Audio")] HRESULT Audio([out, retval] OUTPUT_STATE *pVal); [propput, id(3), helpstring("propetry Audio")] HRESULT Audio([in] OUTPUT_STATE newVal); }; -*/ [ object, @@ -93,7 +91,7 @@ interface IAMMultiMediaStream : IMultiMediaStream HRESULT Initialize( [in] STREAM_TYPE StreamType, [in] DWORD dwFlags, - [in, optional] IGraphBuilder *pFilterGraph); + [in] IGraphBuilder *pFilterGraph); HRESULT GetFilterGraph( [out] IGraphBuilder **ppGraphBuilder); @@ -102,10 +100,10 @@ interface IAMMultiMediaStream : IMultiMediaStream [out] IMediaStreamFilter **ppFilter); HRESULT AddMediaStream( - [in, optional] IUnknown *pStreamObject, - [in, optional] const MSPID *PurposeId, + [in] IUnknown *pStreamObject, + [in] const MSPID *PurposeId, [in] DWORD dwFlags, - [out, optional] IMediaStream **ppNewStream); + [out] IMediaStream **ppNewStream); HRESULT OpenFile( [in] LPCWSTR pszFileName, @@ -129,7 +127,7 @@ pointer_default(unique) interface IAMMediaStream : IMediaStream { HRESULT Initialize( - [in, optional] IUnknown *pSourceObject, + [in] IUnknown *pSourceObject, [in] DWORD dwFlags, [in] REFMSPID PurposeId, [in] const STREAM_TYPE StreamType); @@ -233,9 +231,9 @@ interface IAMMediaTypeStream : IMediaStream HRESULT CreateSample( [in] long lSampleSize, - [in, optional] BYTE * pbBuffer, + [in] BYTE * pbBuffer, [in] DWORD dwFlags, - [in, optional] IUnknown *pUnkOuter, + [in] IUnknown *pUnkOuter, [out] IAMMediaTypeSample ** ppAMMediaTypeSample); HRESULT GetStreamAllocatorRequirements(
1
0
0
0
Rob Shearman : include: Remove incorrect [optional] attributes from parameters in ddstream.idl.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: f399e6ecf2fa6e7fa5ed0aac12bd207478583194 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f399e6ecf2fa6e7fa5ed0aac1…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:20:06 2008 +0100 include: Remove incorrect [optional] attributes from parameters in ddstream.idl. --- include/ddstream.idl | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/ddstream.idl b/include/ddstream.idl index 6444015..947e2bc 100644 --- a/include/ddstream.idl +++ b/include/ddstream.idl @@ -44,14 +44,14 @@ pointer_default(unique) interface IDirectDrawMediaStream : IMediaStream { HRESULT GetFormat( - [out, optional] DDSURFACEDESC *pDDSDCurrent, - [out, optional] IDirectDrawPalette **ppDirectDrawPalette, - [out, optional] DDSURFACEDESC *pDDSDDesired, - [out, optional] DWORD *pdwFlags); + [out] DDSURFACEDESC *pDDSDCurrent, + [out] IDirectDrawPalette **ppDirectDrawPalette, + [out] DDSURFACEDESC *pDDSDDesired, + [out] DWORD *pdwFlags); HRESULT SetFormat( [in] const DDSURFACEDESC *pDDSurfaceDesc, - [in, optional] IDirectDrawPalette *pDirectDrawPalette); + [in] IDirectDrawPalette *pDirectDrawPalette); HRESULT GetDirectDraw( [out] IDirectDraw **ppDirectDraw); @@ -60,8 +60,8 @@ interface IDirectDrawMediaStream : IMediaStream [in] IDirectDraw *pDirectDraw); HRESULT CreateSample( - [in, optional] IDirectDrawSurface *pSurface, - [in, optional] const RECT *pRect, + [in] IDirectDrawSurface *pSurface, + [in] const RECT *pRect, [in] DWORD dwFlags, [out] IDirectDrawStreamSample **ppSample); @@ -79,8 +79,8 @@ pointer_default(unique) interface IDirectDrawStreamSample : IStreamSample { HRESULT GetSurface( - [out, optional] IDirectDrawSurface ** ppDirectDrawSurface, - [out, optional] RECT * pRect); + [out] IDirectDrawSurface ** ppDirectDrawSurface, + [out] RECT * pRect); HRESULT SetRect( [in] const RECT * pRect);
1
0
0
0
Rob Shearman : include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn' t defined.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: dc2bee5f4259a878aef9d5e29028a40de3326997 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dc2bee5f4259a878aef9d5e29…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Mon Sep 8 23:19:41 2008 +0100 include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined. --- include/wine/pthread.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/wine/pthread.h b/include/wine/pthread.h index 1971ebb..a8d5ba3 100644 --- a/include/wine/pthread.h +++ b/include/wine/pthread.h @@ -25,6 +25,11 @@ struct wine_pthread_callbacks; #include <signal.h> +#ifndef HAVE_SIGSET_T +struct sigset_t; +typedef struct sigset_t sigset_t; +#endif + #ifdef HAVE_PTHREAD_H #define _GNU_SOURCE
1
0
0
0
Hans Leidekker : winhttp: Make sure not to read more data than expected on a redirect.
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: 7f28c5f87e23fe4a079d1f1fb184228212a39709 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7f28c5f87e23fe4a079d1f1fb…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Sep 8 22:02:21 2008 +0200 winhttp: Make sure not to read more data than expected on a redirect. Fixes a bug in automatic redirects with content. --- dlls/winhttp/request.c | 213 ++++++++++++++++++++++++------------------------ 1 files changed, 106 insertions(+), 107 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 46c6d6d..b11c426 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -1132,16 +1132,120 @@ static BOOL receive_data( request_t *request, void *buffer, DWORD size, DWORD *r return TRUE; } +static DWORD get_chunk_size( const char *buffer ) +{ + const char *p; + DWORD size = 0; + + for (p = buffer; *p; p++) + { + if (*p >= '0' && *p <= '9') size = size * 16 + *p - '0'; + else if (*p >= 'a' && *p <= 'f') size = size * 16 + *p - 'a' + 10; + else if (*p >= 'A' && *p <= 'F') size = size * 16 + *p - 'A' + 10; + else if (*p == ';') break; + } + return size; +} + +static BOOL receive_data_chunked( request_t *request, void *buffer, DWORD size, DWORD *read, BOOL async ) +{ + char reply[MAX_REPLY_LEN], *p = buffer; + DWORD buflen, to_read, to_write = size; + int bytes_read; + + *read = 0; + for (;;) + { + if (*read == size) break; + + if (request->content_length == ~0UL) /* new chunk */ + { + buflen = sizeof(reply); + if (!netconn_get_next_line( &request->netconn, reply, &buflen )) break; + + if (!(request->content_length = get_chunk_size( reply ))) + { + /* zero sized chunk marks end of transfer; read any trailing headers and return */ + read_reply( request, FALSE ); + break; + } + } + to_read = min( to_write, request->content_length - request->content_read ); + + if (!netconn_recv( &request->netconn, p, to_read, async ? 0 : MSG_WAITALL, &bytes_read )) + { + if (bytes_read != to_read) + { + ERR("Not all data received %d/%d\n", bytes_read, to_read); + } + /* always return success, even if the network layer returns an error */ + *read = 0; + break; + } + if (!bytes_read) break; + + request->content_read += bytes_read; + to_write -= bytes_read; + *read += bytes_read; + p += bytes_read; + + if (request->content_read == request->content_length) /* chunk complete */ + { + request->content_read = 0; + request->content_length = ~0UL; + + buflen = sizeof(reply); + if (!netconn_get_next_line( &request->netconn, reply, &buflen )) + { + ERR("Malformed chunk\n"); + *read = 0; + break; + } + } + } + return TRUE; +} + +static BOOL read_data( request_t *request, void *buffer, DWORD to_read, DWORD *read, BOOL async ) +{ + static const WCHAR chunked[] = {'c','h','u','n','k','e','d',0}; + + BOOL ret; + WCHAR encoding[20]; + DWORD num_bytes, buflen = sizeof(encoding); + + if (query_headers( request, WINHTTP_QUERY_TRANSFER_ENCODING, NULL, encoding, &buflen, NULL ) && + !strcmpiW( encoding, chunked )) + { + ret = receive_data_chunked( request, buffer, to_read, &num_bytes, async ); + } + else + ret = receive_data( request, buffer, to_read, &num_bytes, async ); + + if (async) + { + if (ret) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, buffer, num_bytes ); + else + { + WINHTTP_ASYNC_RESULT result; + result.dwResult = API_READ_DATA; + result.dwError = get_last_error(); + send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, &result, sizeof(result) ); + } + } + if (ret && read) *read = num_bytes; + return ret; +} + /* read any content returned by the server so that the connection can be reused */ static void drain_content( request_t *request ) { DWORD bytes_read; char buffer[2048]; - if (request->content_length == ~0UL) return; for (;;) { - if (!receive_data( request, buffer, sizeof(buffer), &bytes_read, FALSE ) || !bytes_read) return; + if (!read_data( request, buffer, sizeof(buffer), &bytes_read, FALSE ) || !bytes_read) return; } } @@ -1321,111 +1425,6 @@ BOOL WINAPI WinHttpQueryDataAvailable( HINTERNET hrequest, LPDWORD available ) return ret; } -static DWORD get_chunk_size( const char *buffer ) -{ - const char *p; - DWORD size = 0; - - for (p = buffer; *p; p++) - { - if (*p >= '0' && *p <= '9') size = size * 16 + *p - '0'; - else if (*p >= 'a' && *p <= 'f') size = size * 16 + *p - 'a' + 10; - else if (*p >= 'A' && *p <= 'F') size = size * 16 + *p - 'A' + 10; - else if (*p == ';') break; - } - return size; -} - -static BOOL receive_data_chunked( request_t *request, void *buffer, DWORD size, DWORD *read, BOOL async ) -{ - char reply[MAX_REPLY_LEN], *p = buffer; - DWORD buflen, to_read, to_write = size; - int bytes_read; - - *read = 0; - for (;;) - { - if (*read == size) break; - - if (request->content_length == ~0UL) /* new chunk */ - { - buflen = sizeof(reply); - if (!netconn_get_next_line( &request->netconn, reply, &buflen )) break; - - if (!(request->content_length = get_chunk_size( reply ))) - { - /* zero sized chunk marks end of transfer; read any trailing headers and return */ - read_reply( request, FALSE ); - break; - } - } - to_read = min( to_write, request->content_length - request->content_read ); - - if (!netconn_recv( &request->netconn, p, to_read, async ? 0 : MSG_WAITALL, &bytes_read )) - { - if (bytes_read != to_read) - { - ERR("Not all data received %d/%d\n", bytes_read, to_read); - } - /* always return success, even if the network layer returns an error */ - *read = 0; - break; - } - if (!bytes_read) break; - - request->content_read += bytes_read; - to_write -= bytes_read; - *read += bytes_read; - p += bytes_read; - - if (request->content_read == request->content_length) /* chunk complete */ - { - request->content_read = 0; - request->content_length = ~0UL; - - buflen = sizeof(reply); - if (!netconn_get_next_line( &request->netconn, reply, &buflen )) - { - ERR("Malformed chunk\n"); - *read = 0; - break; - } - } - } - return TRUE; -} - -static BOOL read_data( request_t *request, void *buffer, DWORD to_read, DWORD *read, BOOL async ) -{ - static const WCHAR chunked[] = {'c','h','u','n','k','e','d',0}; - - BOOL ret; - WCHAR encoding[20]; - DWORD num_bytes, buflen = sizeof(encoding); - - if (query_headers( request, WINHTTP_QUERY_TRANSFER_ENCODING, NULL, encoding, &buflen, NULL ) && - !strcmpiW( encoding, chunked )) - { - ret = receive_data_chunked( request, buffer, to_read, &num_bytes, async ); - } - else - ret = receive_data( request, buffer, to_read, &num_bytes, async ); - - if (async) - { - if (ret) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, buffer, num_bytes ); - else - { - WINHTTP_ASYNC_RESULT result; - result.dwResult = API_READ_DATA; - result.dwError = get_last_error(); - send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, &result, sizeof(result) ); - } - } - if (ret && read) *read = num_bytes; - return ret; -} - static void task_read_data( task_header_t *task ) { read_data_t *r = (read_data_t *)task;
1
0
0
0
Hans Leidekker : winhttp: WinHttpQueryDataAvailable should do a blocking read if more data is expected .
by Alexandre Julliard
09 Sep '08
09 Sep '08
Module: wine Branch: master Commit: 01e7d128483cf4bec401dee3fc8a479109d7a072 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=01e7d128483cf4bec401dee3f…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Sep 8 22:02:01 2008 +0200 winhttp: WinHttpQueryDataAvailable should do a blocking read if more data is expected. Spotted by Henri Verbeet. --- dlls/winhttp/net.c | 6 +----- dlls/winhttp/request.c | 21 ++++++++++++++++++++- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c index 1abfbdd..450366b 100644 --- a/dlls/winhttp/net.c +++ b/dlls/winhttp/net.c @@ -464,11 +464,7 @@ BOOL netconn_query_data_available( netconn_t *conn, DWORD *available ) return TRUE; } #ifdef FIONREAD - if (!(ret = ioctl( conn->socket, FIONREAD, &unread ))) - { - TRACE("%d bytes of queued, but unread data\n", unread); - *available += unread; - } + if (!(ret = ioctl( conn->socket, FIONREAD, &unread ))) *available = unread; #endif return TRUE; } diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index d1fc005..46c6d6d 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -1238,7 +1238,26 @@ static BOOL query_data( request_t *request, LPDWORD available, BOOL async ) BOOL ret; DWORD num_bytes; - ret = netconn_query_data_available( &request->netconn, &num_bytes ); + if ((ret = netconn_query_data_available( &request->netconn, &num_bytes ))) + { + if (request->content_read < request->content_length) + { + if (!num_bytes) + { + char buffer[4096]; + size_t to_read = min( sizeof(buffer), request->content_length - request->content_read ); + + ret = netconn_recv( &request->netconn, buffer, to_read, MSG_PEEK, (int *)&num_bytes ); + if (ret && !num_bytes) WARN("expected more data to be available\n"); + } + } + else if (num_bytes) + { + WARN("extra data available %u\n", num_bytes); + ret = FALSE; + } + } + TRACE("%u bytes available\n", num_bytes); if (async) {
1
0
0
0
← Newer
1
...
79
80
81
82
83
84
85
...
122
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
Results per page:
10
25
50
100
200