winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
January 2009
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1348 discussions
Start a n
N
ew thread
Juan Lang : crypt32: Fix typo.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 4de59850d55fa0587990d62d03b57f3f6c57b4cc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4de59850d55fa0587990d62d0…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 17:48:21 2009 -0800 crypt32: Fix typo. --- dlls/crypt32/collectionstore.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/collectionstore.c b/dlls/crypt32/collectionstore.c index be8eddf..12eb7c3 100644 --- a/dlls/crypt32/collectionstore.c +++ b/dlls/crypt32/collectionstore.c @@ -95,7 +95,7 @@ static BOOL CRYPT_CollectionAddContext(PWINE_COLLECTIONSTORE store, contextFuncs = (PCONTEXT_FUNCS)((LPBYTE)storeEntry->store + contextFuncsOffset); ret = contextFuncs->addContext(storeEntry->store, context, - existingLinked, childContext); + existingLinked, (const void **)&childContext); } else {
1
0
0
0
Juan Lang : cryptui: Export all selected certificates when requested from the certificate manager , not just the first one.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 157709d7a294e30182d0dfe2758df18e490a7457 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=157709d7a294e30182d0dfe27…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 16:41:04 2009 -0800 cryptui: Export all selected certificates when requested from the certificate manager, not just the first one. --- dlls/cryptui/main.c | 84 +++++++++++++++++++++++++++++++++++++------------- 1 files changed, 62 insertions(+), 22 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 5c07014..498c158 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -1001,6 +1001,67 @@ static void cert_mgr_do_remove(HWND hwnd) } } +static void cert_mgr_do_export(HWND hwnd) +{ + HWND lv = GetDlgItem(hwnd, IDC_MGR_CERTS); + int selectionCount = SendMessageW(lv, LVM_GETSELECTEDCOUNT, 0, 0); + + if (selectionCount == 1) + { + int selection = SendMessageW(lv, LVM_GETNEXTITEM, -1, + LVNI_SELECTED); + + if (selection >= 0) + { + PCCERT_CONTEXT cert = cert_mgr_index_to_cert(hwnd, selection); + + if (cert) + { + CRYPTUI_WIZ_EXPORT_INFO info; + + info.dwSize = sizeof(info); + info.pwszExportFileName = NULL; + info.dwSubjectChoice = CRYPTUI_WIZ_EXPORT_CERT_CONTEXT; + info.u.pCertContext = cert; + info.cStores = 0; + CryptUIWizExport(0, hwnd, NULL, &info, NULL); + } + } + } + else if (selectionCount > 1) + { + HCERTSTORE store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0, + CERT_STORE_CREATE_NEW_FLAG, NULL); + + if (store) + { + CRYPTUI_WIZ_EXPORT_INFO info; + int selection = -1; + + info.dwSize = sizeof(info); + info.pwszExportFileName = NULL; + info.dwSubjectChoice = + CRYPTUI_WIZ_EXPORT_CERT_STORE_CERTIFICATES_ONLY; + info.u.hCertStore = store; + info.cStores = 0; + do { + selection = SendMessageW(lv, LVM_GETNEXTITEM, selection, + LVNI_SELECTED); + if (selection >= 0) + { + PCCERT_CONTEXT cert = cert_mgr_index_to_cert(hwnd, + selection); + + CertAddCertificateContextToStore(store, cert, + CERT_STORE_ADD_ALWAYS, NULL); + } + } while (selection >= 0); + CryptUIWizExport(0, hwnd, NULL, &info, NULL); + CertCloseStore(store, 0); + } + } +} + static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) { @@ -1135,29 +1196,8 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, break; } case IDC_MGR_EXPORT: - { - HWND lv = GetDlgItem(hwnd, IDC_MGR_CERTS); - int selection = SendMessageW(lv, LVM_GETNEXTITEM, -1, - LVNI_SELECTED); - - if (selection >= 0) - { - PCCERT_CONTEXT cert = cert_mgr_index_to_cert(hwnd, selection); - - if (cert) - { - CRYPTUI_WIZ_EXPORT_INFO info; - - info.dwSize = sizeof(info); - info.pwszExportFileName = NULL; - info.dwSubjectChoice = CRYPTUI_WIZ_EXPORT_CERT_CONTEXT; - info.u.pCertContext = cert; - info.cStores = 0; - CryptUIWizExport(0, hwnd, NULL, &info, NULL); - } - } + cert_mgr_do_export(hwnd); break; - } case IDC_MGR_REMOVE: cert_mgr_do_remove(hwnd); break;
1
0
0
0
Juan Lang : cryptui: Set default export file name based on input in CryptUIWizExport.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 56b38801b1e385c47078c6e781320b359b2d1e86 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=56b38801b1e385c47078c6e78…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 14:16:19 2009 -0800 cryptui: Set default export file name based on input in CryptUIWizExport. --- dlls/cryptui/main.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 50b5cb5..5c07014 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -5886,6 +5886,9 @@ static LRESULT CALLBACK export_file_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, data = (struct ExportWizData *)page->lParam; SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); + if (data->pExportInfo->pwszExportFileName) + SendMessageW(GetDlgItem(hwnd, IDC_EXPORT_FILENAME), WM_SETTEXT, 0, + (LPARAM)data->pExportInfo->pwszExportFileName); break; } case WM_NOTIFY:
1
0
0
0
Juan Lang : cryptui: Move code for enabling the PFX export format to the correct dialog proc.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: b2fefc0ffd4c8b6c9f64c4aee8a07e2403e1a455 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b2fefc0ffd4c8b6c9f64c4aee…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 14:13:44 2009 -0800 cryptui: Move code for enabling the PFX export format to the correct dialog proc. --- dlls/cryptui/main.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index d2c438e..50b5cb5 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -5557,9 +5557,13 @@ static LRESULT CALLBACK export_format_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, { PROPSHEETPAGEW *page = (PROPSHEETPAGEW *)lp; int defaultFormatID; + BOOL hasPrivateKey; data = (struct ExportWizData *)page->lParam; SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); + hasPrivateKey = export_info_has_private_key(data->pExportInfo); + if (hasPrivateKey) + EnableWindow(GetDlgItem(hwnd, IDC_EXPORT_FORMAT_PFX), TRUE); switch (data->contextInfo.dwExportFormat) { case CRYPTUI_WIZ_EXPORT_FORMAT_BASE64: @@ -5569,7 +5573,7 @@ static LRESULT CALLBACK export_format_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, defaultFormatID = IDC_EXPORT_FORMAT_CMS; break; case CRYPTUI_WIZ_EXPORT_FORMAT_PFX: - if (export_info_has_private_key(data->pExportInfo)) + if (hasPrivateKey) defaultFormatID = IDC_EXPORT_FORMAT_PFX; else defaultFormatID = IDC_EXPORT_FORMAT_DER; @@ -5882,8 +5886,6 @@ static LRESULT CALLBACK export_file_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, data = (struct ExportWizData *)page->lParam; SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); - if (export_info_has_private_key(data->pExportInfo)) - EnableWindow(GetDlgItem(hwnd, IDC_EXPORT_FORMAT_PFX), TRUE); break; } case WM_NOTIFY:
1
0
0
0
Juan Lang : cryptui: Select export format based on input in CryptUIWizExport.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 214045988fc21368303f72293039452565f913d7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=214045988fc21368303f72293…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 14:11:24 2009 -0800 cryptui: Select export format based on input in CryptUIWizExport. --- dlls/cryptui/main.c | 53 +++++++++++++++++++++++++++++++++++++------------- 1 files changed, 39 insertions(+), 14 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 18d809f..d2c438e 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -5527,6 +5527,24 @@ static LRESULT CALLBACK export_welcome_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, return ret; } +static BOOL export_info_has_private_key(PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo) +{ + BOOL ret = FALSE; + + if (pExportInfo->dwSubjectChoice == CRYPTUI_WIZ_EXPORT_CERT_CONTEXT) + { + DWORD size; + + /* If there's a CRYPT_KEY_PROV_INFO set for this cert, assume the + * cert has a private key. + */ + if (CertGetCertificateContextProperty(pExportInfo->u.pCertContext, + CERT_KEY_PROV_INFO_PROP_ID, NULL, &size)) + ret = TRUE; + } + return ret; +} + static LRESULT CALLBACK export_format_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) { @@ -5538,10 +5556,28 @@ static LRESULT CALLBACK export_format_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, case WM_INITDIALOG: { PROPSHEETPAGEW *page = (PROPSHEETPAGEW *)lp; + int defaultFormatID; data = (struct ExportWizData *)page->lParam; SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); - SendMessageW(GetDlgItem(hwnd, IDC_EXPORT_FORMAT_DER), BM_CLICK, 0, 0); + switch (data->contextInfo.dwExportFormat) + { + case CRYPTUI_WIZ_EXPORT_FORMAT_BASE64: + defaultFormatID = IDC_EXPORT_FORMAT_BASE64; + break; + case CRYPTUI_WIZ_EXPORT_FORMAT_PKCS7: + defaultFormatID = IDC_EXPORT_FORMAT_CMS; + break; + case CRYPTUI_WIZ_EXPORT_FORMAT_PFX: + if (export_info_has_private_key(data->pExportInfo)) + defaultFormatID = IDC_EXPORT_FORMAT_PFX; + else + defaultFormatID = IDC_EXPORT_FORMAT_DER; + break; + default: + defaultFormatID = IDC_EXPORT_FORMAT_DER; + } + SendMessageW(GetDlgItem(hwnd, defaultFormatID), BM_CLICK, 0, 0); break; } case WM_NOTIFY: @@ -5846,19 +5882,8 @@ static LRESULT CALLBACK export_file_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, data = (struct ExportWizData *)page->lParam; SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); - if (data->pExportInfo->dwSubjectChoice == - CRYPTUI_WIZ_EXPORT_CERT_CONTEXT) - { - DWORD size; - - /* If there's a CRYPT_KEY_PROV_INFO set for this cert, assume the - * cert has a private key. - */ - if (CertGetCertificateContextProperty( - data->pExportInfo->u.pCertContext, CERT_KEY_PROV_INFO_PROP_ID, - NULL, &size)) - EnableWindow(GetDlgItem(hwnd, IDC_EXPORT_FORMAT_PFX), TRUE); - } + if (export_info_has_private_key(data->pExportInfo)) + EnableWindow(GetDlgItem(hwnd, IDC_EXPORT_FORMAT_PFX), TRUE); break; } case WM_NOTIFY:
1
0
0
0
Juan Lang : cryptui: Implement CryptUIWizExport for CRYPTUI_WIZ_EXPORT_CERT_STORE_CERTIFICATES_ONLY .
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 15a8ea6a51ceb9bce131f1af9c1535cb4aa92b3d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=15a8ea6a51ceb9bce131f1af9…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 13:58:46 2009 -0800 cryptui: Implement CryptUIWizExport for CRYPTUI_WIZ_EXPORT_CERT_STORE_CERTIFICATES_ONLY. --- dlls/cryptui/main.c | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 3108c6a..18d809f 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -5978,6 +5978,7 @@ static void show_export_details(HWND lv, struct ExportWizData *data) case CRYPTUI_WIZ_EXPORT_CRL_CONTEXT: case CRYPTUI_WIZ_EXPORT_CTL_CONTEXT: case CRYPTUI_WIZ_EXPORT_CERT_STORE: + case CRYPTUI_WIZ_EXPORT_CERT_STORE_CERTIFICATES_ONLY: /* do nothing */ break; default: @@ -6076,7 +6077,13 @@ static BOOL save_base64(HANDLE file, const BYTE *pb, DWORD cb) return ret; } -static BOOL save_cms(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, +static inline BOOL save_store_as_cms(HANDLE file, HCERTSTORE store) +{ + return CertSaveStore(store, PKCS_7_ASN_ENCODING | X509_ASN_ENCODING, + CERT_STORE_SAVE_AS_PKCS7, CERT_STORE_SAVE_TO_FILE, file, 0); +} + +static BOOL save_cert_as_cms(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, BOOL includeChain) { BOOL ret; @@ -6136,8 +6143,7 @@ static BOOL save_cms(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, ret = CertAddCertificateContextToStore(store, pExportInfo->u.pCertContext, CERT_STORE_ADD_ALWAYS, NULL); if (ret) - ret = CertSaveStore(store, PKCS_7_ASN_ENCODING | X509_ASN_ENCODING, - CERT_STORE_SAVE_AS_PKCS7, CERT_STORE_SAVE_TO_FILE, file, 0); + ret = save_store_as_cms(file, store); CertCloseStore(store, 0); } else @@ -6176,6 +6182,9 @@ static BOOL do_export(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, case CRYPTUI_WIZ_EXPORT_CERT_STORE: ret = save_serialized_store(file, pExportInfo->u.hCertStore); break; + case CRYPTUI_WIZ_EXPORT_CERT_STORE_CERTIFICATES_ONLY: + ret = save_store_as_cms(file, pExportInfo->u.hCertStore); + break; default: switch (pContextInfo->dwExportFormat) { @@ -6189,7 +6198,8 @@ static BOOL do_export(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, pExportInfo->u.pCertContext->cbCertEncoded); break; case CRYPTUI_WIZ_EXPORT_FORMAT_PKCS7: - ret = save_cms(file, pExportInfo, pContextInfo->fExportChain); + ret = save_cert_as_cms(file, pExportInfo, + pContextInfo->fExportChain); break; case CRYPTUI_WIZ_EXPORT_FORMAT_PFX: FIXME("unimplemented for PFX\n");
1
0
0
0
Juan Lang : crypt32: Close file when appropriate in CertSaveStore.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: befce84f4c9d417253010ff6d270314ec4fff48d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=befce84f4c9d417253010ff6d…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 13:08:21 2009 -0800 crypt32: Close file when appropriate in CertSaveStore. --- dlls/crypt32/serialize.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/serialize.c b/dlls/crypt32/serialize.c index af36441..4548ce6 100644 --- a/dlls/crypt32/serialize.c +++ b/dlls/crypt32/serialize.c @@ -833,7 +833,7 @@ BOOL WINAPI CertSaveStore(HCERTSTORE hCertStore, DWORD dwMsgAndCertEncodingType, { BOOL (*saveFunc)(HCERTSTORE, DWORD, void *); void *handle; - BOOL ret; + BOOL ret, closeFile = TRUE; TRACE("(%p, %08x, %d, %d, %p, %08x)\n", hCertStore, dwMsgAndCertEncodingType, dwSaveAs, dwSaveTo, pvSaveToPara, dwFlags); @@ -861,6 +861,7 @@ BOOL WINAPI CertSaveStore(HCERTSTORE hCertStore, DWORD dwMsgAndCertEncodingType, { case CERT_STORE_SAVE_TO_FILE: handle = pvSaveToPara; + closeFile = FALSE; break; case CERT_STORE_SAVE_TO_FILENAME_A: handle = CreateFileA((LPCSTR)pvSaveToPara, GENERIC_WRITE, 0, NULL, @@ -879,6 +880,8 @@ BOOL WINAPI CertSaveStore(HCERTSTORE hCertStore, DWORD dwMsgAndCertEncodingType, return FALSE; } ret = saveFunc(hCertStore, dwMsgAndCertEncodingType, handle); + if (closeFile) + CloseHandle(handle); TRACE("returning %d\n", ret); return ret; }
1
0
0
0
Juan Lang : crypt32: Set save function in switch statement rather than with trinary conditional operator .
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 6917fdd3a85b10c6d6e2eaa5fa12699656a70d54 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6917fdd3a85b10c6d6e2eaa5f…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 13:07:02 2009 -0800 crypt32: Set save function in switch statement rather than with trinary conditional operator. --- dlls/crypt32/serialize.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/dlls/crypt32/serialize.c b/dlls/crypt32/serialize.c index 32a9ca0..af36441 100644 --- a/dlls/crypt32/serialize.c +++ b/dlls/crypt32/serialize.c @@ -841,7 +841,16 @@ BOOL WINAPI CertSaveStore(HCERTSTORE hCertStore, DWORD dwMsgAndCertEncodingType, switch (dwSaveAs) { case CERT_STORE_SAVE_AS_STORE: + if (dwSaveTo == CERT_STORE_SAVE_TO_MEMORY) + saveFunc = CRYPT_SaveSerializedToMem; + else + saveFunc = CRYPT_SaveSerializedToFile; + break; case CERT_STORE_SAVE_AS_PKCS7: + if (dwSaveTo == CERT_STORE_SAVE_TO_MEMORY) + saveFunc = CRYPT_SavePKCSToMem; + else + saveFunc = CRYPT_SavePKCSToFile; break; default: WARN("unimplemented for %d\n", dwSaveAs); @@ -852,25 +861,17 @@ BOOL WINAPI CertSaveStore(HCERTSTORE hCertStore, DWORD dwMsgAndCertEncodingType, { case CERT_STORE_SAVE_TO_FILE: handle = pvSaveToPara; - saveFunc = dwSaveAs == CERT_STORE_SAVE_AS_STORE ? - CRYPT_SaveSerializedToFile : CRYPT_SavePKCSToFile; break; case CERT_STORE_SAVE_TO_FILENAME_A: handle = CreateFileA((LPCSTR)pvSaveToPara, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); - saveFunc = dwSaveAs == CERT_STORE_SAVE_AS_STORE ? - CRYPT_SaveSerializedToFile : CRYPT_SavePKCSToFile; break; case CERT_STORE_SAVE_TO_FILENAME_W: handle = CreateFileW((LPCWSTR)pvSaveToPara, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); - saveFunc = dwSaveAs == CERT_STORE_SAVE_AS_STORE ? - CRYPT_SaveSerializedToFile : CRYPT_SavePKCSToFile; break; case CERT_STORE_SAVE_TO_MEMORY: handle = pvSaveToPara; - saveFunc = dwSaveAs == CERT_STORE_SAVE_AS_STORE ? - CRYPT_SaveSerializedToMem : CRYPT_SavePKCSToMem; break; default: WARN("unimplemented for %d\n", dwSaveTo);
1
0
0
0
Juan Lang : cryptui: Add support for exporting a serialized store from CryptUIWizExport.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: a7096f9636e2b586db7e8ea5b7cccb8ce414312c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a7096f9636e2b586db7e8ea5b…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 12:54:53 2009 -0800 cryptui: Add support for exporting a serialized store from CryptUIWizExport. --- dlls/cryptui/cryptui_En.rc | 1 + dlls/cryptui/cryptuires.h | 15 ++++++++------- dlls/cryptui/main.c | 22 ++++++++++++++++++++++ 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/dlls/cryptui/cryptui_En.rc b/dlls/cryptui/cryptui_En.rc index d40d9c1..1e311a1 100644 --- a/dlls/cryptui/cryptui_En.rc +++ b/dlls/cryptui/cryptui_En.rc @@ -153,6 +153,7 @@ STRINGTABLE DISCARDABLE IDS_EXPORT_FILTER_CTL "Certificate Trust List (*.stl)" IDS_EXPORT_FILTER_CMS "CMS/PKCS #7 Messages (*.p7b)" IDS_EXPORT_FILTER_PFX "Personal Information Exchange (*.pfx)" + IDS_EXPORT_FILTER_SERIALIZED_CERT_STORE "Serialized Certificate Store (*.sst)" IDS_EXPORT_FORMAT "File Format" IDS_EXPORT_INCLUDE_CHAIN "Include all certificates in certificate path" IDS_EXPORT_KEYS "Export keys" diff --git a/dlls/cryptui/cryptuires.h b/dlls/cryptui/cryptuires.h index 7b8b4f2..486bae0 100644 --- a/dlls/cryptui/cryptuires.h +++ b/dlls/cryptui/cryptuires.h @@ -152,13 +152,14 @@ #define IDS_EXPORT_FILTER_CTL 1209 #define IDS_EXPORT_FILTER_CMS 1210 #define IDS_EXPORT_FILTER_PFX 1211 -#define IDS_EXPORT_FORMAT 1212 -#define IDS_EXPORT_INCLUDE_CHAIN 1213 -#define IDS_EXPORT_KEYS 1214 -#define IDS_YES 1215 -#define IDS_NO 1216 -#define IDS_EXPORT_SUCCEEDED 1217 -#define IDS_EXPORT_FAILED 1218 +#define IDS_EXPORT_FILTER_SERIALIZED_CERT_STORE 1212 +#define IDS_EXPORT_FORMAT 1213 +#define IDS_EXPORT_INCLUDE_CHAIN 1214 +#define IDS_EXPORT_KEYS 1215 +#define IDS_YES 1216 +#define IDS_NO 1217 +#define IDS_EXPORT_SUCCEEDED 1218 +#define IDS_EXPORT_FAILED 1219 #define IDD_GENERAL 100 #define IDD_DETAIL 101 diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 9ea7b93..3108c6a 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -5633,6 +5633,7 @@ static LPWSTR export_append_extension(struct ExportWizData *data, static const WCHAR ctl[] = { '.','c','t','l',0 }; static const WCHAR p7b[] = { '.','p','7','b',0 }; static const WCHAR pfx[] = { '.','p','f','x',0 }; + static const WCHAR sst[] = { '.','s','s','t',0 }; LPCWSTR extension; LPWSTR dot; BOOL appendExtension; @@ -5654,6 +5655,9 @@ static LPWSTR export_append_extension(struct ExportWizData *data, case CRYPTUI_WIZ_EXPORT_CTL_CONTEXT: extension = ctl; break; + case CRYPTUI_WIZ_EXPORT_CERT_STORE: + extension = sst; + break; default: extension = cer; } @@ -5760,6 +5764,7 @@ static const WCHAR export_filter_crl[] = { '*','.','c','r','l',0 }; static const WCHAR export_filter_ctl[] = { '*','.','s','t','l',0 }; static const WCHAR export_filter_cms[] = { '*','.','p','7','b',0 }; static const WCHAR export_filter_pfx[] = { '*','.','p','f','x',0 }; +static const WCHAR export_filter_sst[] = { '*','.','s','s','t',0 }; static WCHAR *make_export_file_filter(DWORD exportFormat, DWORD subjectChoice) { @@ -5792,6 +5797,10 @@ static WCHAR *make_export_file_filter(DWORD exportFormat, DWORD subjectChoice) baseID = IDS_EXPORT_FILTER_CTL; filterStr = export_filter_ctl; break; + case CRYPTUI_WIZ_EXPORT_CERT_STORE: + baseID = IDS_EXPORT_FILTER_SERIALIZED_CERT_STORE; + filterStr = export_filter_sst; + break; default: baseID = IDS_EXPORT_FILTER_CERT; filterStr = export_filter_cert; @@ -5968,6 +5977,7 @@ static void show_export_details(HWND lv, struct ExportWizData *data) { case CRYPTUI_WIZ_EXPORT_CRL_CONTEXT: case CRYPTUI_WIZ_EXPORT_CTL_CONTEXT: + case CRYPTUI_WIZ_EXPORT_CERT_STORE: /* do nothing */ break; default: @@ -6011,6 +6021,9 @@ static void show_export_details(HWND lv, struct ExportWizData *data) case CRYPTUI_WIZ_EXPORT_CTL_CONTEXT: contentID = IDS_EXPORT_FILTER_CTL; break; + case CRYPTUI_WIZ_EXPORT_CERT_STORE: + contentID = IDS_EXPORT_FILTER_SERIALIZED_CERT_STORE; + break; default: switch (data->contextInfo.dwExportFormat) { @@ -6132,6 +6145,12 @@ static BOOL save_cms(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, return ret; } +static BOOL save_serialized_store(HANDLE file, HCERTSTORE store) +{ + return CertSaveStore(store, PKCS_7_ASN_ENCODING | X509_ASN_ENCODING, + CERT_STORE_SAVE_AS_STORE, CERT_STORE_SAVE_TO_FILE, file, 0); +} + static BOOL do_export(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, PCCRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO pContextInfo) { @@ -6154,6 +6173,9 @@ static BOOL do_export(HANDLE file, PCCRYPTUI_WIZ_EXPORT_INFO pExportInfo, pExportInfo->u.pCTLContext->pbCtlEncoded, pExportInfo->u.pCTLContext->cbCtlEncoded); break; + case CRYPTUI_WIZ_EXPORT_CERT_STORE: + ret = save_serialized_store(file, pExportInfo->u.hCertStore); + break; default: switch (pContextInfo->dwExportFormat) {
1
0
0
0
Juan Lang : include: Add missing type to union.
by Alexandre Julliard
27 Jan '09
27 Jan '09
Module: wine Branch: master Commit: 072b606588cd60f87ffeb74e71767b237fb9bf6e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=072b606588cd60f87ffeb74e7…
Author: Juan Lang <juan.lang(a)gmail.com> Date: Sat Jan 24 12:52:34 2009 -0800 include: Add missing type to union. --- include/cryptuiapi.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/cryptuiapi.h b/include/cryptuiapi.h index 510c7d1..4ba04a3 100644 --- a/include/cryptuiapi.h +++ b/include/cryptuiapi.h @@ -271,6 +271,7 @@ typedef struct _CRYPTUI_WIZ_EXPORT_INFO PCCERT_CONTEXT pCertContext; PCCTL_CONTEXT pCTLContext; PCCRL_CONTEXT pCRLContext; + HCERTSTORE hCertStore; } DUMMYUNIONNAME; DWORD cStores; HCERTSTORE *rghStores;
1
0
0
0
← Newer
1
...
22
23
24
25
26
27
28
...
135
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
Results per page:
10
25
50
100
200