winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
January 2009
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1348 discussions
Start a n
N
ew thread
Andrew Talbot : msi: Declare some functions static.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: 668197a898d4c34d44d97096fec36c3805a53188 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=668197a898d4c34d44d97096f…
Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Jan 10 14:20:03 2009 +0000 msi: Declare some functions static. --- dlls/msi/database.c | 4 +- dlls/msi/dialog.c | 64 +++++++++++++++++++++++++------------------------- dlls/msi/media.c | 4 +- dlls/msi/msipriv.h | 17 ------------- dlls/msi/preview.c | 4 +- dlls/msi/record.c | 6 ++-- dlls/msi/registry.c | 2 +- dlls/msi/string.c | 58 +++++++++++++++++++++++----------------------- dlls/msi/table.c | 4 +- 9 files changed, 73 insertions(+), 90 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=668197a898d4c34d44d97…
1
0
0
0
David Adam : d3dx9_36/test: Remove an unconsistent test.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: e1fefd57e784fcf14bdfc0f97a279ec775b50fe3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e1fefd57e784fcf14bdfc0f97…
Author: David Adam <david.adam.cnrs(a)gmail.com> Date: Sun Jan 11 12:48:03 2009 +0100 d3dx9_36/test: Remove an unconsistent test. --- dlls/d3dx9_36/math.c | 5 ----- dlls/d3dx9_36/tests/math.c | 5 ----- 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dlls/d3dx9_36/math.c b/dlls/d3dx9_36/math.c index a00ffc5..542e408 100644 --- a/dlls/d3dx9_36/math.c +++ b/dlls/d3dx9_36/math.c @@ -84,11 +84,6 @@ HRESULT WINAPI D3DXMatrixDecompose(D3DXVECTOR3 *poutscale, D3DXQUATERNION *poutr D3DXMATRIX normalized; D3DXVECTOR3 vec; - if (!pm) - { - return D3DERR_INVALIDCALL; - } - /*Compute the scaling part.*/ vec.x=pm->u.m[0][0]; vec.y=pm->u.m[0][1]; diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c index f3bb482..2240fb0 100644 --- a/dlls/d3dx9_36/tests/math.c +++ b/dlls/d3dx9_36/tests/math.c @@ -578,11 +578,6 @@ static void test_Matrix_Decompose(void) hr = D3DXMatrixDecompose(&got_scale, &got_rotation, &got_translation, &pm); ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %x\n", hr); - -/*___________*/ - - hr = D3DXMatrixDecompose(&got_scale, &got_rotation, &got_translation, NULL); - ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %x\n", hr); } static void test_Matrix_Transformation2D(void)
1
0
0
0
Rob Shearman : rpcrt4: Unmarshalling functions should always set fMustAlloc when allocating memory .
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: 59158fb25ce0b8d8f75fd44137085908a53bbafa URL:
http://source.winehq.org/git/wine.git/?a=commit;h=59158fb25ce0b8d8f75fd4413…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Jan 10 22:17:15 2009 +0000 rpcrt4: Unmarshalling functions should always set fMustAlloc when allocating memory. The memory is uninitialised and so further unmarshalling shouldn't try to reuse any memory. fMustAlloc is always set to TRUE when allocating memory so that it is clear that the unmarshalling is safe and to avoid future problems with change or the code being copied. --- dlls/rpcrt4/ndr_marshall.c | 43 +++++++++++++++++++++++++++++++++---------- 1 files changed, 33 insertions(+), 10 deletions(-) diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c index f0a13de..37d286d 100644 --- a/dlls/rpcrt4/ndr_marshall.c +++ b/dlls/rpcrt4/ndr_marshall.c @@ -2440,7 +2440,9 @@ unsigned char * WINAPI NdrNonConformantStringUnmarshall(PMIDL_STUB_MESSAGE pStu validate_string_data(pStubMsg, bufsize, esize); - if (fMustAlloc || !*ppMemory) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, memsize); safe_copy_from_buffer(pStubMsg, *ppMemory, bufsize); @@ -3380,7 +3382,9 @@ unsigned char * WINAPI NdrComplexStructUnmarshall(PMIDL_STUB_MESSAGE pStubMsg, offset = pStubMsg->Offset; } - if (fMustAlloc || !*ppMemory) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, size); pMemory = ComplexUnmarshall(pStubMsg, *ppMemory, pFormat, pointer_desc, fMustAlloc); @@ -3921,7 +3925,9 @@ unsigned char * WINAPI NdrComplexArrayUnmarshall(PMIDL_STUB_MESSAGE pStubMsg, pFormat = ReadConformance(pStubMsg, pFormat); pFormat = ReadVariance(pStubMsg, pFormat, pStubMsg->MaxCount); - if (fMustAlloc || !*ppMemory) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, size); ALIGN_POINTER(pStubMsg->Buffer, alignment); @@ -4193,8 +4199,13 @@ unsigned char * WINAPI NdrUserMarshalUnmarshall(PMIDL_STUB_MESSAGE pStubMsg, else ALIGN_POINTER(pStubMsg->Buffer, (flags & 0xf) + 1); - if (fMustAlloc || !*ppMemory) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) + { *ppMemory = NdrAllocate(pStubMsg, memsize); + memset(*ppMemory, 0, memsize); + } pStubMsg->Buffer = pStubMsg->StubDesc->aUserMarshalQuadruple[index].pfnUnmarshall( @@ -4662,7 +4673,9 @@ unsigned char * WINAPI NdrConformantVaryingStructUnmarshall(PMIDL_STUB_MESSAGE TRACE("memory_size = %d\n", pCVStructFormat->memory_size); /* work out how much memory to allocate if we need to do so */ - if (!*ppMemory || fMustAlloc) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) { SIZE_T size = pCVStructFormat->memory_size + memsize; *ppMemory = NdrAllocate(pStubMsg, size); @@ -5149,7 +5162,9 @@ unsigned char * WINAPI NdrVaryingArrayUnmarshall(PMIDL_STUB_MESSAGE pStubMsg, bufsize = safe_multiply(esize, pStubMsg->ActualCount); offset = pStubMsg->Offset; - if (!*ppMemory || fMustAlloc) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, size); saved_buffer = pStubMsg->BufferMark = pStubMsg->Buffer; safe_buffer_increment(pStubMsg, bufsize); @@ -5707,7 +5722,9 @@ unsigned char * WINAPI NdrEncapsulatedUnionUnmarshall(PMIDL_STUB_MESSAGE pStubM TRACE("got switch value 0x%x\n", switch_value); size = *(const unsigned short*)pFormat + increment; - if(!*ppMemory || fMustAlloc) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, size); NdrBaseTypeUnmarshall(pStubMsg, ppMemory, &switch_type, FALSE); @@ -5887,7 +5904,9 @@ unsigned char * WINAPI NdrNonEncapsulatedUnionUnmarshall(PMIDL_STUB_MESSAGE pSt size = *(const unsigned short*)pFormat; - if(!*ppMemory || fMustAlloc) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, size); return union_arm_unmarshall(pStubMsg, ppMemory, discriminant, pFormat, fMustAlloc); @@ -6109,7 +6128,9 @@ unsigned char *WINAPI NdrRangeUnmarshall( do \ { \ ALIGN_POINTER(pStubMsg->Buffer, sizeof(type)); \ - if (fMustAlloc || !*ppMemory) \ + if (!fMustAlloc && !*ppMemory) \ + fMustAlloc = TRUE; \ + if (fMustAlloc) \ *ppMemory = NdrAllocate(pStubMsg, sizeof(type)); \ if (pStubMsg->Buffer + sizeof(type) > pStubMsg->BufferEnd) \ { \ @@ -6363,7 +6384,9 @@ static unsigned char *WINAPI NdrBaseTypeUnmarshall( break; case RPC_FC_ENUM16: ALIGN_POINTER(pStubMsg->Buffer, sizeof(USHORT)); - if (fMustAlloc || !*ppMemory) + if (!fMustAlloc && !*ppMemory) + fMustAlloc = TRUE; + if (fMustAlloc) *ppMemory = NdrAllocate(pStubMsg, sizeof(UINT)); if (pStubMsg->Buffer + sizeof(USHORT) > pStubMsg->BufferEnd) RpcRaiseException(RPC_X_BAD_STUB_DATA);
1
0
0
0
Rob Shearman : oleaut32: Test the return value of the remote IWidget_StructArgs call.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: 17a30ff2e8ab5fbd29e8fe86a3cf98d2221c8658 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=17a30ff2e8ab5fbd29e8fe86a…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Jan 10 20:56:52 2009 +0000 oleaut32: Test the return value of the remote IWidget_StructArgs call. --- dlls/oleaut32/tests/tmarshal.c | 15 +++++++++++---- dlls/oleaut32/tests/tmarshal.idl | 6 +++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c index 6193d80..713c366 100644 --- a/dlls/oleaut32/tests/tmarshal.c +++ b/dlls/oleaut32/tests/tmarshal.c @@ -546,7 +546,7 @@ static HRESULT WINAPI Widget_VariantArrayPtr( return S_OK; } -static void WINAPI Widget_Variant( +static HRESULT WINAPI Widget_Variant( IWidget __RPC_FAR * iface, VARIANT var) { @@ -554,9 +554,10 @@ static void WINAPI Widget_Variant( ok(V_VT(&var) == VT_CY, "V_VT(&var) was %d\n", V_VT(&var)); ok(S(V_CY(&var)).Hi == 0xdababe, "V_CY(&var).Hi was 0x%x\n", S(V_CY(&var)).Hi); ok(S(V_CY(&var)).Lo == 0xdeadbeef, "V_CY(&var).Lo was 0x%x\n", S(V_CY(&var)).Lo); + return S_OK; } -static void WINAPI Widget_VarArg( +static HRESULT WINAPI Widget_VarArg( IWidget * iface, int numexpect, SAFEARRAY * values) @@ -586,9 +587,11 @@ static void WINAPI Widget_VarArg( hr = SafeArrayUnaccessData(values); ok(hr == S_OK, "SafeArrayUnaccessData failed with %x\n", hr); + + return S_OK; } -static void WINAPI Widget_StructArgs( +static HRESULT WINAPI Widget_StructArgs( IWidget * iface, MYSTRUCT byval, MYSTRUCT *byptr, @@ -597,6 +600,7 @@ static void WINAPI Widget_StructArgs( ok(memcmp(&byval, &MYSTRUCT_BYVAL, sizeof(MYSTRUCT))==0, "Struct parameter passed by value corrupted\n"); ok(memcmp(byptr, &MYSTRUCT_BYPTR, sizeof(MYSTRUCT))==0, "Struct parameter passed by pointer corrupted\n"); ok(memcmp(arr, MYSTRUCT_ARRAY, sizeof(MYSTRUCT_ARRAY))==0, "Array of structs corrupted\n"); + return S_OK; } @@ -1102,7 +1106,10 @@ static void test_typelibmarshal(void) /* call StructArgs (direct) */ mystruct = MYSTRUCT_BYPTR; memcpy(mystructArray, MYSTRUCT_ARRAY, sizeof(mystructArray)); - IWidget_StructArgs(pWidget, MYSTRUCT_BYVAL, &mystruct, mystructArray); + hr = IWidget_StructArgs(pWidget, MYSTRUCT_BYVAL, &mystruct, mystructArray); + todo_wine { + ok_ole_success(hr, IWidget_StructArgs); + } /* call Clone */ dispparams.cNamedArgs = 0; diff --git a/dlls/oleaut32/tests/tmarshal.idl b/dlls/oleaut32/tests/tmarshal.idl index ea10797..2b57ddd 100644 --- a/dlls/oleaut32/tests/tmarshal.idl +++ b/dlls/oleaut32/tests/tmarshal.idl @@ -112,13 +112,13 @@ library TestTypelib HRESULT VariantArrayPtr([in] SAFEARRAY(VARIANT) *values); [id(DISPID_TM_VARIANT)] - void Variant([in] VARIANT var); + HRESULT Variant([in] VARIANT var); [vararg, id(DISPID_TM_VARARG)] - void VarArg([in] int numexpect, [in] SAFEARRAY(VARIANT) values); + HRESULT VarArg([in] int numexpect, [in] SAFEARRAY(VARIANT) values); [id(DISPID_TM_STRUCTARGS)] - void StructArgs([in] MYSTRUCT byval, [in] MYSTRUCT *byptr, [in] MYSTRUCT arr[5]); + HRESULT StructArgs([in] MYSTRUCT byval, [in] MYSTRUCT *byptr, [in] MYSTRUCT arr[5]); [id(DISPID_TM_ERROR)] HRESULT Error();
1
0
0
0
Rob Shearman : user32: Free allocated memory in USER_unload_driver.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: ea00dc4b49de4e339c154defdd4e1258ada0290a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea00dc4b49de4e339c154defd…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Jan 10 20:56:21 2009 +0000 user32: Free allocated memory in USER_unload_driver. --- dlls/user32/driver.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/user32/driver.c b/dlls/user32/driver.c index 86d1543..6454f65 100644 --- a/dlls/user32/driver.c +++ b/dlls/user32/driver.c @@ -141,8 +141,11 @@ static const USER_DRIVER *load_driver(void) /* unload the graphics driver on process exit */ void USER_unload_driver(void) { + USER_DRIVER *prev; /* make sure we don't try to call the driver after it has been detached */ - USER_Driver = &null_driver; + prev = InterlockedExchangePointer( (void **)&USER_Driver, &null_driver ); + if (prev != &lazy_load_driver && prev != &null_driver) + HeapFree( GetProcessHeap(), 0, prev ); }
1
0
0
0
Rob Shearman : ntoskrnl: Free allocated buffers on exit from wine_ntoskrnl_main_loop.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: 07090c248576f07b2e0afcf992ba908e54c4b7fe URL:
http://source.winehq.org/git/wine.git/?a=commit;h=07090c248576f07b2e0afcf99…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Jan 10 20:56:10 2009 +0000 ntoskrnl: Free allocated buffers on exit from wine_ntoskrnl_main_loop. Avoids a warning of a memory leak in Valgrind. --- dlls/ntoskrnl.exe/ntoskrnl.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 81c4f33..7d7236d 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -257,7 +257,11 @@ NTSTATUS CDECL wine_ntoskrnl_main_loop( HANDLE stop_event ) break; case STATUS_PENDING: if (WaitForMultipleObjects( 2, handles, FALSE, INFINITE ) == WAIT_OBJECT_0) + { + HeapFree( GetProcessHeap(), 0, in_buff ); + HeapFree( GetProcessHeap(), 0, out_buff ); return STATUS_SUCCESS; + } break; } }
1
0
0
0
Rob Shearman : oleaut32: Dump MSFT format typeinfos upon loading.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: b3c8124a15e8c6ec078c06d3bb3fffe974e2a9b2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b3c8124a15e8c6ec078c06d3b…
Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Jan 10 20:55:55 2009 +0000 oleaut32: Dump MSFT format typeinfos upon loading. --- dlls/oleaut32/typelib.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c index 9bc601e..0f35fc1 100644 --- a/dlls/oleaut32/typelib.c +++ b/dlls/oleaut32/typelib.c @@ -2214,6 +2214,8 @@ static ITypeInfoImpl * MSFT_DoTypeInfo( debugstr_w(ptiRet->Name), debugstr_guid(&ptiRet->TypeAttr.guid), typekind_desc[ptiRet->TypeAttr.typekind]); + if (TRACE_ON(typelib)) + dump_TypeInfo(ptiRet); return ptiRet; }
1
0
0
0
Michael Stefaniuc : include: Replace unsigned long with unsigned int in winerror.h.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: de97ce150ce24699f94e38f8b6624e1d71f6d13b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=de97ce150ce24699f94e38f8b…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Sun Jan 11 00:16:47 2009 +0100 include: Replace unsigned long with unsigned int in winerror.h. --- include/winerror.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/winerror.h b/include/winerror.h index 5d32374..c7427d7 100644 --- a/include/winerror.h +++ b/include/winerror.h @@ -65,12 +65,12 @@ #define MAKE_HRESULT(sev,fac,code) \ - ((HRESULT) (((unsigned long)(sev)<<31) | ((unsigned long)(fac)<<16) | ((unsigned long)(code))) ) + ((HRESULT) (((unsigned int)(sev)<<31) | ((unsigned int)(fac)<<16) | ((unsigned int)(code))) ) #define MAKE_SCODE(sev,fac,code) \ - ((SCODE) (((unsigned long)(sev)<<31) | ((unsigned long)(fac)<<16) | ((unsigned long)(code))) ) + ((SCODE) (((unsigned int)(sev)<<31) | ((unsigned int)(fac)<<16) | ((unsigned int)(code))) ) #define SUCCEEDED(stat) ((HRESULT)(stat)>=0) #define FAILED(stat) ((HRESULT)(stat)<0) -#define IS_ERROR(stat) (((unsigned long)(stat)>>31) == SEVERITY_ERROR) +#define IS_ERROR(stat) (((unsigned int)(stat)>>31) == SEVERITY_ERROR) #define HRESULT_CODE(hr) ((hr) & 0xFFFF) #define SCODE_CODE(sc) ((sc) & 0xFFFF) @@ -90,7 +90,7 @@ typedef long HRESULT; typedef int HRESULT; # endif #endif -static inline HRESULT HRESULT_FROM_WIN32(unsigned long x) +static inline HRESULT HRESULT_FROM_WIN32(unsigned int x) { return (HRESULT)x > 0 ? ((HRESULT) ((x & 0x0000FFFF) | (FACILITY_WIN32 << 16) | 0x80000000)) : (HRESULT)x; }
1
0
0
0
Michael Stefaniuc : dxgi: Remove superfluous pointer casts.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: f93b29b04d07ba4a9a76e7e54c82c752421a3e70 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f93b29b04d07ba4a9a76e7e54…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Sun Jan 11 00:15:40 2009 +0100 dxgi: Remove superfluous pointer casts. --- dlls/dxgi/dxgi_main.c | 2 +- dlls/dxgi/factory.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dxgi/dxgi_main.c b/dlls/dxgi/dxgi_main.c index b72c04a..06086f7 100644 --- a/dlls/dxgi/dxgi_main.c +++ b/dlls/dxgi/dxgi_main.c @@ -315,7 +315,7 @@ HRESULT WINAPI DXGID3D10CreateDevice(HMODULE d3d10core, IDXGIFactory *factory, I goto fail; } - *device = (IUnknown *)dxgi_device; + *device = dxgi_device; return hr; diff --git a/dlls/dxgi/factory.c b/dlls/dxgi/factory.c index 03db096..19bc4cf 100644 --- a/dlls/dxgi/factory.c +++ b/dlls/dxgi/factory.c @@ -131,7 +131,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_factory_EnumAdapters(IWineDXGIFactory *ifa return DXGI_ERROR_NOT_FOUND; } - *adapter = (IDXGIAdapter *)This->adapters[adapter_idx]; + *adapter = This->adapters[adapter_idx]; IDXGIAdapter_AddRef(*adapter); TRACE("Returning adapter %p\n", *adapter);
1
0
0
0
Michael Stefaniuc : include: Use LONG in vfw.h for Win64 compatibility.
by Alexandre Julliard
12 Jan '09
12 Jan '09
Module: wine Branch: master Commit: 79f49804a4a2c241a3087d03b17dc7e81a7a0a1b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=79f49804a4a2c241a3087d03b…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Sun Jan 11 00:17:14 2009 +0100 include: Use LONG in vfw.h for Win64 compatibility. --- include/vfw.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/vfw.h b/include/vfw.h index b3b6679..2751ef5 100644 --- a/include/vfw.h +++ b/include/vfw.h @@ -1419,7 +1419,7 @@ HWND VFWAPIV MCIWndCreateW(HWND, HINSTANCE, DWORD, LPCWSTR); #define MCIWndGetLength(hWnd) (LONG)MCIWndSM(hWnd,MCIWNDM_GETLENGTH,0,0) #define MCIWndGetEnd(hWnd) (LONG)MCIWndSM(hWnd,MCIWNDM_GETEND,0,0) -#define MCIWndStep(hWnd,n) (LONG)MCIWndSM(hWnd,MCI_STEP,0,(LPARAM)(long)(n)) +#define MCIWndStep(hWnd,n) (LONG)MCIWndSM(hWnd,MCI_STEP,0,(LPARAM)(LONG)(n)) #define MCIWndDestroy(hWnd) (VOID)MCIWndSM(hWnd,WM_CLOSE,0,0) #define MCIWndSetZoom(hWnd,iZoom) (VOID)MCIWndSM(hWnd,MCIWNDM_SETZOOM,0,(LPARAM)(UINT)(iZoom))
1
0
0
0
← Newer
1
...
81
82
83
84
85
86
87
...
135
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
Results per page:
10
25
50
100
200