winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
January 2009
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
1348 discussions
Start a n
N
ew thread
Austin English : traffic: Add stub dll.
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 2de77982a94f8946b6bc26402c3d33551e9f458b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2de77982a94f8946b6bc26402…
Author: Austin English <austinenglish(a)gmail.com> Date: Wed Jan 28 10:51:51 2009 -0600 traffic: Add stub dll. --- configure | 9 ++++++++ configure.ac | 1 + dlls/traffic/Makefile.in | 13 ++++++++++++ dlls/traffic/traffic.spec | 21 ++++++++++++++++++++ dlls/traffic/traffic_main.c | 44 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 88 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 162775d..9add58a 100755 --- a/configure +++ b/configure @@ -26550,6 +26550,14 @@ dlls/tapi32/Makefile: dlls/tapi32/Makefile.in dlls/Makedll.rules" ac_config_files="$ac_config_files dlls/tapi32/Makefile" ALL_MAKEFILES="$ALL_MAKEFILES \\ + dlls/traffic/Makefile" +test "x$enable_traffic" != xno && ALL_DLL_DIRS="$ALL_DLL_DIRS \\ + traffic" +ALL_MAKEFILE_DEPENDS="$ALL_MAKEFILE_DEPENDS +dlls/traffic/Makefile: dlls/traffic/Makefile.in dlls/Makedll.rules" +ac_config_files="$ac_config_files dlls/traffic/Makefile" + +ALL_MAKEFILES="$ALL_MAKEFILES \\ dlls/twain_32/Makefile" test "x$enable_twain_32" != xno && ALL_DLL_DIRS="$ALL_DLL_DIRS \\ twain_32" @@ -28603,6 +28611,7 @@ do "dlls/svrapi/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/svrapi/Makefile" ;; "dlls/sxs/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/sxs/Makefile" ;; "dlls/tapi32/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/tapi32/Makefile" ;; + "dlls/traffic/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/traffic/Makefile" ;; "dlls/twain_32/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/twain_32/Makefile" ;; "dlls/twain_32/tests/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/twain_32/tests/Makefile" ;; "dlls/unicows/Makefile") CONFIG_FILES="$CONFIG_FILES dlls/unicows/Makefile" ;; diff --git a/configure.ac b/configure.ac index 06e3678..682d1da 100644 --- a/configure.ac +++ b/configure.ac @@ -2111,6 +2111,7 @@ WINE_CONFIG_MAKEFILE([dlls/strmiids/Makefile],[dlls/Makeimplib.rules],[dlls],[AL WINE_CONFIG_MAKEFILE([dlls/svrapi/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) WINE_CONFIG_MAKEFILE([dlls/sxs/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) WINE_CONFIG_MAKEFILE([dlls/tapi32/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) +WINE_CONFIG_MAKEFILE([dlls/traffic/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) WINE_CONFIG_MAKEFILE([dlls/twain_32/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) WINE_CONFIG_MAKEFILE([dlls/twain_32/tests/Makefile],[dlls/Maketest.rules],[dlls],[ALL_TEST_DIRS],[enable_tests]) WINE_CONFIG_MAKEFILE([dlls/unicows/Makefile],[dlls/Makedll.rules],[dlls],[ALL_DLL_DIRS]) diff --git a/dlls/traffic/Makefile.in b/dlls/traffic/Makefile.in new file mode 100644 index 0000000..9af37e2 --- /dev/null +++ b/dlls/traffic/Makefile.in @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = traffic.dll +IMPORTS = kernel32 + +C_SRCS = \ + traffic_main.c + +@MAKE_DLL_RULES@ + +@DEPENDENCIES@ # everything below this line is overwritten by make depend diff --git a/dlls/traffic/traffic.spec b/dlls/traffic/traffic.spec new file mode 100644 index 0000000..eed26e8 --- /dev/null +++ b/dlls/traffic/traffic.spec @@ -0,0 +1,21 @@ +@ stub TcAddClassMap +@ stub TcAddFilter +@ stub TcAddFlow +@ stub TcCloseInterface +@ stub TcDeleteFilter +@ stub TcDeleteFlow +@ stub TcDeregisterClient +@ stub TcEnumerateFlows +@ stub TcEnumerateInterfaces +@ stub TcGetFlowNameA +@ stub TcGetFlowNameW +@ stub TcModifyFlow +@ stub TcOpenInterfaceA +@ stub TcOpenInterfaceW +@ stub TcQueryFlowA +@ stub TcQueryFlowW +@ stub TcQueryInterface +@ stub TcRegisterClient +@ stub TcSetFlowA +@ stub TcSetFlowW +@ stub TcSetInterface diff --git a/dlls/traffic/traffic_main.c b/dlls/traffic/traffic_main.c new file mode 100644 index 0000000..421be6c --- /dev/null +++ b/dlls/traffic/traffic_main.c @@ -0,0 +1,44 @@ +/* + * QoS traffic control implementation + * + * Copyright 2009 Austin English + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(traffic); + +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) +{ + TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); + + switch (fdwReason) + { + case DLL_WINE_PREATTACH: + return FALSE; /* prefer native version */ + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls(hinstDLL); + break; + default: + break; + } + + return TRUE; +}
1
0
0
0
Marcus Meissner : xcopy: Handle return from vsnprintfW (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 1db4c5dc67e6754bad0bee3a442d639ecd80c97f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1db4c5dc67e6754bad0bee3a4…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 28 23:40:56 2009 +0100 xcopy: Handle return from vsnprintfW (Coverity). --- programs/xcopy/xcopy.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/programs/xcopy/xcopy.c b/programs/xcopy/xcopy.c index e89c404..eaff10c 100644 --- a/programs/xcopy/xcopy.c +++ b/programs/xcopy/xcopy.c @@ -984,7 +984,8 @@ int XCOPY_wprintf(const WCHAR *format, ...) { #define MAX_WRITECONSOLE_SIZE 65535 va_list parms; - DWORD len, nOut; + DWORD nOut; + int len; DWORD res = 0; /* @@ -1003,6 +1004,10 @@ int XCOPY_wprintf(const WCHAR *format, ...) { va_start(parms, format); len = vsnprintfW(output_bufW, MAX_WRITECONSOLE_SIZE/sizeof(WCHAR), format, parms); va_end(parms); + if (len < 0) { + WINE_FIXME("String too long.\n"); + return 0; + } /* Try to write as unicode all the time we think its a console */ if (toConsole) {
1
0
0
0
Marcus Meissner : msxml3: Handle get_element returning NULL (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 525a5510d15952cb388cd124ca8d226aeaa081d6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=525a5510d15952cb388cd124c…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 28 23:25:16 2009 +0100 msxml3: Handle get_element returning NULL (Coverity). --- dlls/msxml3/element.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c index f479395..4f0bce9 100644 --- a/dlls/msxml3/element.c +++ b/dlls/msxml3/element.c @@ -644,6 +644,7 @@ static HRESULT WINAPI domelem_getElementsByTagName( { domelem *This = impl_from_IXMLDOMElement( iface ); LPWSTR szPattern; + xmlNodePtr element; HRESULT hr; TRACE("(%p)->(%s,%p)\n", This, debugstr_w(bstrName), resultList); @@ -654,7 +655,11 @@ static HRESULT WINAPI domelem_getElementsByTagName( lstrcpyW(szPattern+3, bstrName); TRACE("%s\n", debugstr_w(szPattern)); - hr = queryresult_create(get_element(This), szPattern, resultList); + element = get_element(This); + if (!element) + hr = E_FAIL; + else + hr = queryresult_create(element, szPattern, resultList); HeapFree(GetProcessHeap(), 0, szPattern); return hr;
1
0
0
0
Marcus Meissner : server: Handle NULL thread in send_hardware_message ( Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 3b86f463b5cb6217fa835c67c9325f8a592fd1a4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3b86f463b5cb6217fa835c67c…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 28 23:58:38 2009 +0100 server: Handle NULL thread in send_hardware_message (Coverity). --- server/queue.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/queue.c b/server/queue.c index ab524a7..bc0aea7 100644 --- a/server/queue.c +++ b/server/queue.c @@ -1720,7 +1720,7 @@ DECL_HANDLER(send_hardware_message) if (!(data = mem_alloc( sizeof(*data) ))) { - release_object( thread ); + if (thread) release_object( thread ); return; } memset( data, 0, sizeof(*data) );
1
0
0
0
Marcus Meissner : riched20: Handle more missing allocs gracefully (Coverity ).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: a09621b00fe4d57db48cec93a059bf5e2baa4030 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a09621b00fe4d57db48cec93a…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 09:51:05 2009 +0100 riched20: Handle more missing allocs gracefully (Coverity). --- dlls/riched20/reader.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/reader.c b/dlls/riched20/reader.c index c5a3a35..17f530d 100644 --- a/dlls/riched20/reader.c +++ b/dlls/riched20/reader.c @@ -219,8 +219,10 @@ void RTFInit(RTF_Info *info) { info->rtfTextBuf = heap_alloc (rtfBufSiz); info->pushedTextBuf = heap_alloc (rtfBufSiz); - if (info->rtfTextBuf == NULL || info->pushedTextBuf == NULL) + if (info->rtfTextBuf == NULL || info->pushedTextBuf == NULL) { ERR ("Cannot allocate text buffers.\n"); + return; + } info->rtfTextBuf[0] = info->pushedTextBuf[0] = '\0'; }
1
0
0
0
Marcus Meissner : riched20: Handle NULL fp more gracefully (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 605a40e477386264efc57a097f1df6e9cfb06ca4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=605a40e477386264efc57a097…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 09:46:21 2009 +0100 riched20: Handle NULL fp more gracefully (Coverity). --- dlls/riched20/reader.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/reader.c b/dlls/riched20/reader.c index f99ac58..c5a3a35 100644 --- a/dlls/riched20/reader.c +++ b/dlls/riched20/reader.c @@ -871,8 +871,10 @@ static void ReadFontTbl(RTF_Info *info) break; } fp = New (RTFFont); - if (fp == NULL) + if (fp == NULL) { ERR ( "%s: cannot allocate font entry\n", fn); + break; + } fp->rtfNextFont = info->fontList; info->fontList = fp; @@ -992,7 +994,7 @@ static void ReadFontTbl(RTF_Info *info) TRACE("default font codepage %d\n", info->codePage); } } - if (fp->rtfFNum == -1) + if (!fp || (fp->rtfFNum == -1)) ERR( "%s: missing font number\n", fn); /* * Could check other pieces of structure here, too, I suppose.
1
0
0
0
Marcus Meissner : riched20: Handle cp NULL more gracefully (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 9eb4c73ae3e915994bbe3de156a7acf0d3d177a3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9eb4c73ae3e915994bbe3de15…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 09:49:05 2009 +0100 riched20: Handle cp NULL more gracefully (Coverity). --- dlls/riched20/reader.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/reader.c b/dlls/riched20/reader.c index 295d6d8..f99ac58 100644 --- a/dlls/riched20/reader.c +++ b/dlls/riched20/reader.c @@ -1044,8 +1044,10 @@ static void ReadColorTbl(RTF_Info *info) } cp = New (RTFColor); - if (cp == NULL) + if (cp == NULL) { ERR ( "%s: cannot allocate color entry\n", fn); + break; + } cp->rtfCNum = cnum++; cp->rtfCRed = cp->rtfCGreen = cp->rtfCBlue = -1; cp->rtfNextColor = info->colorList;
1
0
0
0
Marcus Meissner : riched20: Exit the loop instead of crashing (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 3d8fd826e13e310dc118f20cd0591e9edc92a45d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3d8fd826e13e310dc118f20cd…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 09:42:33 2009 +0100 riched20: Exit the loop instead of crashing (Coverity). --- dlls/riched20/reader.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/reader.c b/dlls/riched20/reader.c index 7fc952b..295d6d8 100644 --- a/dlls/riched20/reader.c +++ b/dlls/riched20/reader.c @@ -1090,8 +1090,10 @@ static void ReadStyleSheet(RTF_Info *info) if (RTFCheckCM (info, rtfGroup, rtfEndGroup)) break; sp = New (RTFStyle); - if (sp == NULL) + if (sp == NULL) { ERR ( "%s: cannot allocate stylesheet entry\n", fn); + break; + } sp->rtfSName = NULL; sp->rtfSNum = -1; sp->rtfSType = rtfParStyle;
1
0
0
0
Marcus Meissner : riched20: Removed unneeded NULL check (Coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 4662271afdbcf67e87fafb847f7c0431dc8e0e77 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4662271afdbcf67e87fafb847…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 09:26:40 2009 +0100 riched20: Removed unneeded NULL check (Coverity). --- dlls/riched20/editor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 4495fb4..574118a 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -4059,7 +4059,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, origNPos = editor->vert_si.nPos; lineHeight = 24; - if (editor && editor->pBuffer && editor->pBuffer->pDefaultStyle) + if (editor->pBuffer && editor->pBuffer->pDefaultStyle) lineHeight = editor->pBuffer->pDefaultStyle->tm.tmHeight; if (lineHeight <= 0) lineHeight = 24;
1
0
0
0
Marcus Meissner : regedit: Check HeapAlloc results (coverity).
by Alexandre Julliard
29 Jan '09
29 Jan '09
Module: wine Branch: master Commit: 1082779ddc55cec4f1a6e076140e109baf707502 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1082779ddc55cec4f1a6e0761…
Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jan 29 08:47:42 2009 +0100 regedit: Check HeapAlloc results (coverity). --- programs/regedit/listview.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c index fb7688f..333b2a4 100644 --- a/programs/regedit/listview.c +++ b/programs/regedit/listview.c @@ -533,7 +533,12 @@ BOOL RefreshListView(HWND hwndLV, HKEY hKeyRoot, LPCWSTR keyPath, LPCWSTR highli max_val_size++; valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * sizeof(WCHAR)); + if (!valName) + goto done; valBuf = HeapAlloc(GetProcessHeap(), 0, max_val_size); + if (!valBuf) + goto done; + if (RegQueryValueExW(hKey, NULL, NULL, &valType, valBuf, &valSize) == ERROR_FILE_NOT_FOUND) { AddEntryToList(hwndLV, NULL, REG_SZ, NULL, 0, !highlightValue); } @@ -545,7 +550,7 @@ BOOL RefreshListView(HWND hwndLV, HKEY hKeyRoot, LPCWSTR keyPath, LPCWSTR highli errCode = RegEnumValueW(hKey, index, valName, &valNameLen, NULL, &valType, valBuf, &valSize); if (errCode != ERROR_SUCCESS) goto done; valBuf[valSize] = 0; - if (valName && highlightValue && !lstrcmpW(valName, highlightValue)) + if (highlightValue && !lstrcmpW(valName, highlightValue)) bSelected = TRUE; AddEntryToList(hwndLV, valName[0] ? valName : NULL, valType, valBuf, valSize, bSelected); }
1
0
0
0
← Newer
1
...
6
7
8
9
10
11
12
...
135
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
Results per page:
10
25
50
100
200