wine-commits November 2009

wine-commits@winehq.org

3 participants
910 discussions

Jacek Caban : mshtml: Fixed ref count leak and code clean up.
by Alexandre Julliard 30 Nov '09

30 Nov '09

Module: wine Branch: master Commit: 5dd4248ff36bd88d75359dc45e79add7ffb47d14 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5dd4248ff36bd88d75359dc45… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 24 21:12:40 2009 +0100 mshtml: Fixed ref count leak and code clean up. --- dlls/mshtml/tests/dom.c | 25 ++++--------------------- 1 files changed, 4 insertions(+), 21 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index bd55c9f..1387b13 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5606,8 +5606,6 @@ static void test_frame(IDispatch *disp, const char *exp_id) IHTMLDocument2 *parent_doc, *top_doc; IHTMLWindow4 *frame; IHTMLFrameBase *frame_elem; - IHTMLElement *html_elem; - BSTR bstr; HRESULT hres; hres = IDispatch_QueryInterface(disp, &IID_IHTMLWindow4, (void**)&frame); @@ -5621,17 +5619,8 @@ static void test_frame(IDispatch *disp, const char *exp_id) if(FAILED(hres)) return; - hres = IHTMLFrameBase_QueryInterface(frame_elem, &IID_IHTMLElement, (void**)&html_elem); - ok(hres == S_OK, "Could not get IHTMLElement interface: 0x%08x\n", hres); - IHTMLFrameBase_Release(frame_elem); - if(FAILED(hres)) - return; - - hres = IHTMLElement_get_id(html_elem, &bstr); - ok(hres == S_OK, "IHTMLElement_get_id failed: 0x%08x\n", hres); - ok(!strcmp_wa(bstr, exp_id), "Expected ID: \"%s\", found ID: %s\n", exp_id, wine_dbgstr_w(bstr)); - IHTMLElement_Release(html_elem); - SysFreeString(bstr); + test_elem_id((IUnknown*)frame_elem, exp_id); + IHTMLElement_Release(frame_elem); hres = IDispatch_QueryInterface(disp, &IID_IHTMLWindow2, (void**)&frame2); ok(hres == S_OK, "Could not get IHTMLWindow2 interface: 0x%08x\n", hres); @@ -5653,11 +5642,8 @@ static void test_frame(IDispatch *disp, const char *exp_id) return; } - hres = IHTMLDocument2_get_title(parent_doc, &bstr); - ok(hres == S_OK, "IHTMLDocument2_get_title failed: 0x%08x\n", hres); - ok(!strcmp_wa(bstr, "frameset test"), "Did not get the right parent. Expected \"frameset test\", found %s\n", wine_dbgstr_w(bstr)); + test_doc_title(parent_doc, "frameset test"); IHTMLDocument2_Release(parent_doc); - SysFreeString(bstr); /* test get_top */ hres = IHTMLWindow2_get_top(frame2, &top); @@ -5672,11 +5658,8 @@ static void test_frame(IDispatch *disp, const char *exp_id) if(FAILED(hres)) return; - hres = IHTMLDocument2_get_title(top_doc, &bstr); - ok(hres == S_OK, "IHTMLDocument2_get_title failed: 0x%08x\n", hres); - ok(!strcmp_wa(bstr, "frameset test"), "Did not get the right parent. Expected \"frameset test\", found %s\n", wine_dbgstr_w(bstr)); + test_doc_title(top_doc, "frameset test"); IHTMLDocument2_Release(top_doc); - SysFreeString(bstr); } static void test_frameset(IHTMLDocument2 *doc)

1 0

Paul Vriens : shell32/tests: Fix test failures on several platforms.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: ac85305c95e6e26954f3b3aea4909371ba36d674 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ac85305c95e6e26954f3b3aea… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Tue Nov 24 17:06:45 2009 +0100 shell32/tests: Fix test failures on several platforms. --- dlls/shell32/tests/progman_dde.c | 68 ++++++++++++++++++++++++++++++-------- 1 files changed, 54 insertions(+), 14 deletions(-) diff --git a/dlls/shell32/tests/progman_dde.c b/dlls/shell32/tests/progman_dde.c index c2ff934..09eb791 100644 --- a/dlls/shell32/tests/progman_dde.c +++ b/dlls/shell32/tests/progman_dde.c @@ -76,6 +76,45 @@ static void init_function_pointers(void) pSHGetSpecialFolderPathA = (void*)GetProcAddress(hmod, "SHGetSpecialFolderPathA"); } +static char Group1Title[MAX_PATH] = "Group1"; +static char Group2Title[MAX_PATH] = "Group2"; +static char Group3Title[MAX_PATH] = "Group3"; +static char Startup[MAX_PATH] = "Startup"; +static char StartupTitle[MAX_PATH] = "Startup"; + +static void init_strings(void) +{ + HKEY key; + DWORD fullpath = 0; + DWORD size = sizeof(DWORD); + + if (!pSHGetSpecialFolderPathA) + return; + + RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\CabinetState", &key); + RegQueryValueExA(key, "FullPath", NULL, NULL, (LPBYTE)&fullpath, &size); + RegCloseKey(key); + if (fullpath == 1) + { + BOOL ret; + char commonprog[MAX_PATH], startup[MAX_PATH]; + + ret = SHGetSpecialFolderPathA(NULL, commonprog, CSIDL_COMMON_PROGRAMS, FALSE); + if (!ret) /* Win9x */ + SHGetSpecialFolderPathA(NULL, commonprog, CSIDL_PROGRAMS, FALSE); + lstrcpyA(Group1Title, commonprog); + lstrcatA(Group1Title, "\\Group1"); + lstrcpyA(Group2Title, commonprog); + lstrcatA(Group2Title, "\\Group2"); + lstrcpyA(Group3Title, commonprog); + lstrcatA(Group3Title, "\\Group3"); + + SHGetSpecialFolderPathA(NULL, startup, CSIDL_STARTUP, FALSE); + lstrcpyA(StartupTitle, startup); + lstrcpyA(Startup, (strrchr(StartupTitle, '\\') + 1)); + } +} + static HDDEDATA CALLBACK DdeCallback(UINT type, UINT format, HCONV hConv, HSZ hsz1, HSZ hsz2, HDDEDATA hDDEData, ULONG_PTR data1, ULONG_PTR data2) { @@ -316,7 +355,7 @@ static void CheckFileExistsInProgramGroups(const char *nameToCheck, int shouldEx * 2. window is open */ static void CreateGroupTest(DWORD instance, HCONV hConv, const char *command, UINT expected_result, - const char *groupName, int testParams) + const char *groupName, const char *windowTitle, int testParams) { HDDEDATA hData; UINT error; @@ -337,7 +376,7 @@ static void CreateGroupTest(DWORD instance, HCONV hConv, const char *command, UI /* Check if Group Now Exists */ CheckFileExistsInProgramGroups(groupName, TRUE, TRUE, NULL, testParams); /* Check if Window is Open (polling) */ - CheckWindowCreated(groupName, TRUE, testParams); + CheckWindowCreated(windowTitle, TRUE, testParams); } } @@ -347,7 +386,7 @@ static void CreateGroupTest(DWORD instance, HCONV hConv, const char *command, UI * 1. window is open */ static void ShowGroupTest(DWORD instance, HCONV hConv, const char *command, UINT expected_result, - const char *groupName, int closeAfterShowing, int testParams) + const char *groupName, const char *windowTitle, int closeAfterShowing, int testParams) { HDDEDATA hData; UINT error; @@ -372,7 +411,7 @@ static void ShowGroupTest(DWORD instance, HCONV hConv, const char *command, UINT if (error == DMLERR_NO_ERROR) { /* Check if Window is Open (polling) */ - CheckWindowCreated(groupName, closeAfterShowing, testParams); + CheckWindowCreated(windowTitle, closeAfterShowing, testParams); } } @@ -461,7 +500,7 @@ static void DeleteItemTest(DWORD instance, HCONV hConv, const char *command, UIN * AddItems) so this covers minimum expected functionality. */ static void CompoundCommandTest(DWORD instance, HCONV hConv, const char *command, UINT expected_result, - const char *groupName, const char *fileName1, + const char *groupName, const char *windowTitle, const char *fileName1, const char *fileName2, int testParams) { HDDEDATA hData; @@ -479,7 +518,7 @@ static void CompoundCommandTest(DWORD instance, HCONV hConv, const char *command { /* Check that File exists */ CheckFileExistsInProgramGroups(groupName, TRUE, TRUE, NULL, testParams); - CheckWindowCreated(groupName, FALSE, testParams); + CheckWindowCreated(windowTitle, FALSE, testParams); CheckFileExistsInProgramGroups(fileName1, TRUE, FALSE, groupName, testParams); CheckFileExistsInProgramGroups(fileName2, TRUE, FALSE, groupName, testParams); } @@ -499,26 +538,26 @@ static int DdeTestProgman(DWORD instance, HCONV hConv) GetStringFromError(DMLERR_NOTPROCESSED), GetStringFromError(error)); /* CreateGroup Tests (including AddItem, DeleteItem) */ - CreateGroupTest(instance, hConv, "[CreateGroup(Group1)]", DMLERR_NO_ERROR, "Group1", DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); + CreateGroupTest(instance, hConv, "[CreateGroup(Group1)]", DMLERR_NO_ERROR, "Group1", Group1Title, DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); AddItemTest(instance, hConv, "[AddItem(c:\\f1g1,f1g1Name)]", DMLERR_NO_ERROR, "f1g1Name.lnk", "Group1", DDE_TEST_COMMON|DDE_TEST_ADDITEM|testnum++); AddItemTest(instance, hConv, "[AddItem(c:\\f2g1,f2g1Name)]", DMLERR_NO_ERROR, "f2g1Name.lnk", "Group1", DDE_TEST_COMMON|DDE_TEST_ADDITEM|testnum++); DeleteItemTest(instance, hConv, "[DeleteItem(f2g1Name)]", DMLERR_NO_ERROR, "f2g1Name.lnk", "Group1", DDE_TEST_COMMON|DDE_TEST_DELETEITEM|testnum++); AddItemTest(instance, hConv, "[AddItem(c:\\f3g1,f3g1Name)]", DMLERR_NO_ERROR, "f3g1Name.lnk", "Group1", DDE_TEST_COMMON|DDE_TEST_ADDITEM|testnum++); - CreateGroupTest(instance, hConv, "[CreateGroup(Group2)]", DMLERR_NO_ERROR, "Group2", DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); + CreateGroupTest(instance, hConv, "[CreateGroup(Group2)]", DMLERR_NO_ERROR, "Group2", Group2Title, DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); /* Create Group that already exists - same instance */ - CreateGroupTest(instance, hConv, "[CreateGroup(Group1)]", DMLERR_NO_ERROR, "Group1", DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); + CreateGroupTest(instance, hConv, "[CreateGroup(Group1)]", DMLERR_NO_ERROR, "Group1", Group1Title, DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); /* ShowGroup Tests */ - ShowGroupTest(instance, hConv, "[ShowGroup(Group1)]", DMLERR_NOTPROCESSED, "Startup", TRUE, DDE_TEST_SHOWGROUP|testnum++); + ShowGroupTest(instance, hConv, "[ShowGroup(Group1)]", DMLERR_NOTPROCESSED, Startup, StartupTitle, TRUE, DDE_TEST_SHOWGROUP|testnum++); DeleteItemTest(instance, hConv, "[DeleteItem(f3g1Name)]", DMLERR_NO_ERROR, "f3g1Name.lnk", "Group1", DDE_TEST_COMMON|DDE_TEST_DELETEITEM|testnum++); - ShowGroupTest(instance, hConv, "[ShowGroup(Startup,0)]", DMLERR_NO_ERROR, "Startup", TRUE, DDE_TEST_SHOWGROUP|testnum++); - ShowGroupTest(instance, hConv, "[ShowGroup(Group1,0)]", DMLERR_NO_ERROR, "Group1", FALSE, DDE_TEST_SHOWGROUP|testnum++); + ShowGroupTest(instance, hConv, "[ShowGroup(Startup,0)]", DMLERR_NO_ERROR, Startup, StartupTitle, TRUE, DDE_TEST_SHOWGROUP|testnum++); + ShowGroupTest(instance, hConv, "[ShowGroup(Group1,0)]", DMLERR_NO_ERROR, "Group1", Group1Title, FALSE, DDE_TEST_SHOWGROUP|testnum++); /* DeleteGroup Test - Note that Window is Open for this test */ DeleteGroupTest(instance, hConv, "[DeleteGroup(Group1)]", DMLERR_NO_ERROR, "Group1", DDE_TEST_DELETEGROUP|testnum++); /* Compound Execute String Command */ - CompoundCommandTest(instance, hConv, "[CreateGroup(Group3)][AddItem(c:\\f1g3,f1g3Name)][AddItem(c:\\f2g3,f2g3Name)]", DMLERR_NO_ERROR, "Group3", "f1g3Name.lnk", "f2g3Name.lnk", DDE_TEST_COMMON|DDE_TEST_COMPOUND|testnum++); + CompoundCommandTest(instance, hConv, "[CreateGroup(Group3)][AddItem(c:\\f1g3,f1g3Name)][AddItem(c:\\f2g3,f2g3Name)]", DMLERR_NO_ERROR, "Group3", Group3Title, "f1g3Name.lnk", "f2g3Name.lnk", DDE_TEST_COMMON|DDE_TEST_COMPOUND|testnum++); DeleteGroupTest(instance, hConv, "[DeleteGroup(Group3)]", DMLERR_NO_ERROR, "Group3", DDE_TEST_DELETEGROUP|testnum++); /* Full Parameters of Add Item */ @@ -531,7 +570,7 @@ static int DdeTestProgman(DWORD instance, HCONV hConv) static void DdeTestProgman2(DWORD instance, HCONV hConv, int testnum) { /* Create Group that already exists on a separate connection */ - CreateGroupTest(instance, hConv, "[CreateGroup(Group2)]", DMLERR_NO_ERROR, "Group2", DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); + CreateGroupTest(instance, hConv, "[CreateGroup(Group2)]", DMLERR_NO_ERROR, "Group2", Group2Title, DDE_TEST_COMMON|DDE_TEST_CREATEGROUP|testnum++); DeleteGroupTest(instance, hConv, "[DeleteGroup(Group2)]", DMLERR_NO_ERROR, "Group2", DDE_TEST_COMMON|DDE_TEST_DELETEGROUP|testnum++); } @@ -544,6 +583,7 @@ START_TEST(progman_dde) int testnum; init_function_pointers(); + init_strings(); /* Only report this once */ if (!pSHGetSpecialFolderPathA)

1 0

Rob Shearman : ole32: Fix circular reference count in default handler objects.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 6592c25bc749373cad0e7584ef13e010b4a2431d URL: http://source.winehq.org/git/wine.git/?a=commit;h=6592c25bc749373cad0e7584e… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Tue Nov 24 14:06:57 2009 +0000 ole32: Fix circular reference count in default handler objects. This is caused by caching a pointer and reference to the data cache's IPersistStorage interface without managing reference counts appropriately. --- dlls/ole32/defaulthandler.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/dlls/ole32/defaulthandler.c b/dlls/ole32/defaulthandler.c index a3da0dd..5130513 100644 --- a/dlls/ole32/defaulthandler.c +++ b/dlls/ole32/defaulthandler.c @@ -1960,9 +1960,21 @@ static DefaultHandler* DefaultHandler_Construct( &IID_IUnknown, (void**)&This->dataCache); if(SUCCEEDED(hr)) + { hr = IUnknown_QueryInterface(This->dataCache, &IID_IPersistStorage, (void**)&This->dataCache_PersistStg); + /* keeping a reference to This->dataCache_PersistStg causes us to keep a + * reference on the outer object */ + if (SUCCEEDED(hr)) + IUnknown_Release(This->outerUnknown); + else + IUnknown_Release(This->dataCache); + } if(FAILED(hr)) + { ERR("Unexpected error creating data cache\n"); + HeapFree(GetProcessHeap(), 0, This); + return NULL; + } This->clsid = *clsid; This->clientSite = NULL; @@ -2009,6 +2021,13 @@ static DefaultHandler* DefaultHandler_Construct( static void DefaultHandler_Destroy( DefaultHandler* This) { + TRACE("(%p)\n", This); + + /* AddRef/Release may be called on this object during destruction. + * Prevent the object being destroyed recursively by artificially raising + * the reference count. */ + This->ref = 10000; + /* release delegates */ DefaultHandler_Stop(This); release_delegates(This); @@ -2020,6 +2039,9 @@ static void DefaultHandler_Destroy( if (This->dataCache) { + /* to balance out the release of dataCache_PersistStg which will result + * in a reference being released from the outer unknown */ + IUnknown_AddRef(This->outerUnknown); IPersistStorage_Release(This->dataCache_PersistStg); IUnknown_Release(This->dataCache); This->dataCache_PersistStg = NULL;

1 0

Rob Shearman : ole32: Fix a typo in PropertyStorage_WritePropertyToStream that caused the wrong data to be written to the stream .
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 4b1d527b15dc2781feade1378bdce59377b54d11 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b1d527b15dc2781feade1378… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Tue Nov 24 14:05:06 2009 +0000 ole32: Fix a typo in PropertyStorage_WritePropertyToStream that caused the wrong data to be written to the stream. The field pClipData is a pointer to the data to be written, not the start of it. --- dlls/ole32/stg_prop.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/stg_prop.c b/dlls/ole32/stg_prop.c index 1c77c9e..bc45cea 100644 --- a/dlls/ole32/stg_prop.c +++ b/dlls/ole32/stg_prop.c @@ -1735,7 +1735,7 @@ static HRESULT PropertyStorage_WritePropertyToStream(PropertyStorage_impl *This, hr = IStream_Write(This->stm, cf_hdr, sizeof(cf_hdr), &count); if (FAILED(hr)) goto end; - hr = IStream_Write(This->stm, &var->u.pclipdata->pClipData, len, &count); + hr = IStream_Write(This->stm, var->u.pclipdata->pClipData, len, &count); if (FAILED(hr)) goto end; bytesWritten = count + sizeof cf_hdr;

1 0

Jeremy White : winspool: Add a test showing Windows behavior wrt size and GetPrinterDriverA.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 2feb43f57301ebbee7929a82ebf69a3c7df5e49e URL: http://source.winehq.org/git/wine.git/?a=commit;h=2feb43f57301ebbee7929a82e… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Tue Nov 24 07:31:21 2009 -0600 winspool: Add a test showing Windows behavior wrt size and GetPrinterDriverA. This behavior was discovered by Huw Davies. --- dlls/winspool.drv/tests/info.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c index c6c0066..2fb09f3 100644 --- a/dlls/winspool.drv/tests/info.c +++ b/dlls/winspool.drv/tests/info.c @@ -70,6 +70,7 @@ static BOOL (WINAPI * pGetDefaultPrinterA)(LPSTR, LPDWORD); static BOOL (WINAPI * pSetDefaultPrinterA)(LPCSTR); static DWORD (WINAPI * pXcvDataW)(HANDLE, LPCWSTR, PBYTE, DWORD, PBYTE, DWORD, PDWORD, PDWORD); static BOOL (WINAPI * pAddPortExA)(LPSTR, DWORD, LPBYTE, LPSTR); +static BOOL (WINAPI * pGetPrinterDriverW)(HANDLE, LPWSTR, DWORD, LPBYTE, DWORD, LPDWORD); /* ################################ */ @@ -2260,6 +2261,15 @@ static void test_GetPrinterDriver(void) continue; } + /* GetPrinterDriverA returns the same number of bytes as GetPrinterDriverW */ + if (! ret && pGetPrinterDriverW) + { + DWORD double_needed; + ret = pGetPrinterDriverW(hprn, NULL, level, NULL, 0, &double_needed); + todo_wine + ok(double_needed == needed, "GetPrinterDriverA returned different size %d than GetPrinterDriverW (%d)\n", needed, double_needed); + } + buf = HeapAlloc(GetProcessHeap(), 0, needed); SetLastError(0xdeadbeef); @@ -2536,6 +2546,7 @@ START_TEST(info) hwinspool = GetModuleHandleA("winspool.drv"); pGetDefaultPrinterA = (void *) GetProcAddress(hwinspool, "GetDefaultPrinterA"); pSetDefaultPrinterA = (void *) GetProcAddress(hwinspool, "SetDefaultPrinterA"); + pGetPrinterDriverW = (void *) GetProcAddress(hwinspool, "GetPrinterDriverW"); pXcvDataW = (void *) GetProcAddress(hwinspool, "XcvDataW"); pAddPortExA = (void *) GetProcAddress(hwinspool, "AddPortExA");

1 0

Nathan Gallaher : msi: Support _Streams, _Storages tablename prefixes in SELECT.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: abb23d8bd5004dd031e0ab978208845ac2fe363d URL: http://source.winehq.org/git/wine.git/?a=commit;h=abb23d8bd5004dd031e0ab978… Author: Nathan Gallaher <ngallaher(a)deepthought.org> Date: Thu Nov 12 22:59:03 2009 -0500 msi: Support _Streams, _Storages tablename prefixes in SELECT. --- dlls/msi/storages.c | 11 +++++++++++ dlls/msi/streams.c | 11 +++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/dlls/msi/storages.c b/dlls/msi/storages.c index 005bcdb..844db8d 100644 --- a/dlls/msi/storages.c +++ b/dlls/msi/storages.c @@ -296,6 +296,7 @@ static UINT STORAGES_get_column_info(struct tagMSIVIEW *view, UINT n, static const WCHAR Name[] = {'N','a','m','e',0}; static const WCHAR Data[] = {'D','a','t','a',0}; + static const WCHAR _Storages[] = {'_','S','t','o','r','a','g','e','s',0}; TRACE("(%p, %d, %p, %p, %p, %p)\n", view, n, name, type, temporary, table_name); @@ -322,6 +323,16 @@ static UINT STORAGES_get_column_info(struct tagMSIVIEW *view, UINT n, if (!*name) return ERROR_FUNCTION_FAILED; } + if (table_name) + { + *table_name = strdupW(_Storages); + if (!*table_name) + { + msi_free(name); + return ERROR_FUNCTION_FAILED; + } + } + if (temporary) *temporary = FALSE; diff --git a/dlls/msi/streams.c b/dlls/msi/streams.c index 23ae971..faa27c8 100644 --- a/dlls/msi/streams.c +++ b/dlls/msi/streams.c @@ -262,6 +262,7 @@ static UINT STREAMS_get_column_info(struct tagMSIVIEW *view, UINT n, static const WCHAR Name[] = {'N','a','m','e',0}; static const WCHAR Data[] = {'D','a','t','a',0}; + static const WCHAR _Streams[] = {'_','S','t','r','e','a','m','s',0}; TRACE("(%p, %d, %p, %p, %p, %p)\n", view, n, name, type, temporary, table_name); @@ -288,6 +289,16 @@ static UINT STREAMS_get_column_info(struct tagMSIVIEW *view, UINT n, if (!*name) return ERROR_FUNCTION_FAILED; } + if (table_name) + { + *table_name = strdupW(_Streams); + if (!*table_name) + { + msi_free(name); + return ERROR_FUNCTION_FAILED; + } + } + if (temporary) *temporary = FALSE;

1 0

Nathan Gallaher : msi/tests: Test for SELECT table.column FROM table.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: f7ba4b2ec00c19d3c97b46d6395ba606100f7f89 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f7ba4b2ec00c19d3c97b46d63… Author: Nathan Gallaher <ngallaher(a)deepthought.org> Date: Sun Nov 15 22:33:29 2009 -0500 msi/tests: Test for SELECT table.column FROM table. Make sure that mixing table columns returns the expected data. eg: SELECT t1.action, t2.action FROM t1, t2 should return distinct data. --- dlls/msi/tests/db.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 75 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index 19cd74c..041e860 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -7901,6 +7901,80 @@ static void test_dbmerge(void) DeleteFileA("binary.dat"); } +static void test_select_with_tablenames(void) +{ + MSIHANDLE hdb, view, rec; + LPCSTR query; + UINT r; + int i; + + int vals[4][2] = { + {1,12}, + {4,12}, + {1,15}, + {4,15}}; + + hdb = create_db(); + ok(hdb, "failed to create db\n"); + + /* Build a pair of tables with the same column names, but unique data */ + query = "CREATE TABLE `T1` ( `A` SHORT, `B` SHORT PRIMARY KEY `A`)"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "INSERT INTO `T1` ( `A`, `B` ) VALUES ( 1, 2 )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "INSERT INTO `T1` ( `A`, `B` ) VALUES ( 4, 5 )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "CREATE TABLE `T2` ( `A` SHORT, `B` SHORT PRIMARY KEY `A`)"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "INSERT INTO `T2` ( `A`, `B` ) VALUES ( 11, 12 )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "INSERT INTO `T2` ( `A`, `B` ) VALUES ( 14, 15 )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + + /* Test that selection based on prefixing the column with the table + * actually selects the right data */ + + query = "SELECT T1.A, T2.B FROM T1,T2"; + r = MsiDatabaseOpenView(hdb, query, &view); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + r = MsiViewExecute(view, 0); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + for (i = 0; i < 4; i++) + { + r = MsiViewFetch(view, &rec); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + r = MsiRecordGetInteger(rec, 1); + ok(r == vals[i][0], "Expected %d, got %d\n", vals[i][0], r); + + r = MsiRecordGetInteger(rec, 2); + ok(r == vals[i][1], "Expected %d, got %d\n", vals[i][1], r); + + MsiCloseHandle(rec); + } + + r = MsiViewFetch(view, &rec); + ok(r == ERROR_NO_MORE_ITEMS, "Expected ERROR_NO_MORE_ITEMS, got %d\n", r); + + MsiViewClose(view); + MsiCloseHandle(view); + MsiCloseHandle(hdb); + DeleteFileA(msifile); +} + UINT ordervals[6][3] = { { MSI_NULL_INTEGER, 12, 13 }, @@ -8579,6 +8653,7 @@ START_TEST(db) test_dbtopackage(); test_droptable(); test_dbmerge(); + test_select_with_tablenames(); test_insertorder(); test_columnorder(); test_suminfo_import();

1 0

Nathan Gallaher : msi: Add support for table names in select statements.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 5c56e1f440049e0676b81f74c182d4ce25661dec URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c56e1f440049e0676b81f74c… Author: Nathan Gallaher <ngallaher(a)deepthought.org> Date: Mon Nov 9 20:41:43 2009 -0500 msi: Add support for table names in select statements. Propagate tablename from 'SELECT tablename.column from tablename' queries into VIEW_find_column(). Previously, the tablename had been dropped. --- dlls/msi/select.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/msi/select.c b/dlls/msi/select.c index c4b9e80..f6b5dae 100644 --- a/dlls/msi/select.c +++ b/dlls/msi/select.c @@ -368,12 +368,14 @@ static const MSIVIEWOPS select_ops = NULL, }; -static UINT SELECT_AddColumn( MSISELECTVIEW *sv, LPCWSTR name ) +static UINT SELECT_AddColumn( MSISELECTVIEW *sv, LPCWSTR name, + LPCWSTR table_name ) { UINT r, n=0; MSIVIEW *table; - TRACE("%p adding %s\n", sv, debugstr_w( name ) ); + TRACE("%p adding %s.%s\n", sv, debugstr_w( table_name ), + debugstr_w( name )); if( sv->view.ops != &select_ops ) return ERROR_FUNCTION_FAILED; @@ -389,7 +391,7 @@ static UINT SELECT_AddColumn( MSISELECTVIEW *sv, LPCWSTR name ) if( sv->num_cols >= sv->max_cols ) return ERROR_FUNCTION_FAILED; - r = VIEW_find_column( table, name, NULL, &n ); + r = VIEW_find_column( table, name, table_name, &n ); if( r != ERROR_SUCCESS ) return r; @@ -433,7 +435,7 @@ UINT SELECT_CreateView( MSIDATABASE *db, MSIVIEW **view, MSIVIEW *table, while( columns ) { - r = SELECT_AddColumn( sv, columns->column ); + r = SELECT_AddColumn( sv, columns->column, columns->table ); if( r ) break; columns = columns->next;

1 0

Paul Chitescu : wineserver: Do not uselessly set the KEY_DIRTY flag on registry keys when loading from file .
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 51000c171b256b1367550cfab6f77d34d8c63f68 URL: http://source.winehq.org/git/wine.git/?a=commit;h=51000c171b256b1367550cfab… Author: Paul Chitescu <paulc(a)voip.null.ro> Date: Tue Nov 24 15:12:56 2009 +0200 wineserver: Do not uselessly set the KEY_DIRTY flag on registry keys when loading from file. --- server/registry.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/server/registry.c b/server/registry.c index 1fa2c67..afdffed 100644 --- a/server/registry.c +++ b/server/registry.c @@ -1257,7 +1257,6 @@ static int load_value( struct key *key, const char *buffer, struct file_load_inf value->data = newptr; value->len = len; value->type = type; - make_dirty( key ); return 1; error: @@ -1266,7 +1265,6 @@ static int load_value( struct key *key, const char *buffer, struct file_load_inf value->data = NULL; value->len = 0; value->type = REG_NONE; - make_dirty( key ); return 0; } @@ -1304,7 +1302,6 @@ static void load_keys( struct key *key, const char *filename, FILE *f, int prefi struct key *subkey = NULL; struct file_load_info info; char *p; - int flags = (key->flags & KEY_VOLATILE) ? KEY_VOLATILE : KEY_DIRTY; info.filename = filename; info.file = f; @@ -1334,7 +1331,7 @@ static void load_keys( struct key *key, const char *filename, FILE *f, int prefi case '[': /* new key */ if (subkey) release_object( subkey ); if (prefix_len == -1) prefix_len = get_prefix_len( key, p + 1, &info ); - if (!(subkey = load_key( key, p + 1, flags, prefix_len, &info ))) + if (!(subkey = load_key( key, p + 1, key->flags, prefix_len, &info ))) file_read_error( "Error creating key", &info ); break; case '@': /* default value */

1 0

Paul Vriens : snmpapi/tests: Fix a crash on some 64bit systems.
by Alexandre Julliard 24 Nov '09

24 Nov '09

Module: wine Branch: master Commit: 2cde60421177dc82f3efb1d9ac3bf251b6a54abe URL: http://source.winehq.org/git/wine.git/?a=commit;h=2cde60421177dc82f3efb1d9a… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Tue Nov 24 13:33:28 2009 +0100 snmpapi/tests: Fix a crash on some 64bit systems. --- dlls/snmpapi/tests/util.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/snmpapi/tests/util.c b/dlls/snmpapi/tests/util.c index 64c7501..908d5e2 100644 --- a/dlls/snmpapi/tests/util.c +++ b/dlls/snmpapi/tests/util.c @@ -424,7 +424,7 @@ static void test_SnmpUtilOidAppend(void) static AsnObjectIdentifier oid1; static AsnObjectIdentifier oid2 = { 3, ids2 }; - ids1 = HeapAlloc(GetProcessHeap(), 0, 3 * sizeof(UINT)); + ids1 = SnmpUtilMemAlloc(3 * sizeof(UINT)); ids1[0] = 1; ids1[1] = 2; ids1[2] = 3; @@ -451,7 +451,7 @@ static void test_SnmpUtilOidAppend(void) ok(!memcmp(&oid1.ids[3], ids2, 3 * sizeof(UINT)), "SnmpUtilOidAppend failed\n"); - HeapFree(GetProcessHeap(), 0, ids1); + SnmpUtilOidFree(&oid1); } static void test_SnmpUtilVarBindCpyFree(void)

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
91
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits November 2009