wine-commits February 2009

wine-commits@winehq.org

2 participants
965 discussions

Juan Lang : shell32: Use list of allowed PIDL types rather than assuming there are no more than two .
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: 0bb1c5648b3a266a54dc9a9ab601d58070141010 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0bb1c5648b3a266a54dc9a9ab… Author: Juan Lang <juan.lang(a)gmail.com> Date: Tue Feb 3 09:45:00 2009 -0800 shell32: Use list of allowed PIDL types rather than assuming there are no more than two. --- dlls/shell32/tests/shellpath.c | 169 +++++++++++++++++++-------------------- 1 files changed, 82 insertions(+), 87 deletions(-) diff --git a/dlls/shell32/tests/shellpath.c b/dlls/shell32/tests/shellpath.c index 0c7bafd..bf125b0 100644 --- a/dlls/shell32/tests/shellpath.c +++ b/dlls/shell32/tests/shellpath.c @@ -74,9 +74,9 @@ static GUID CLSID_CommonDocuments = { 0x0000000c, 0x0000, 0x0000, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x74, 0x1a } }; struct shellExpectedValues { - int folder; - BYTE pidlType; - BYTE altPidlType; + int folder; + int numTypes; + const BYTE *types; }; static HRESULT (WINAPI *pDllGetVersion)(DLLVERSIONINFO *); @@ -90,75 +90,83 @@ static int (WINAPI *pSHFileOperationA)(LPSHFILEOPSTRUCTA); static HRESULT (WINAPI *pSHGetMalloc)(LPMALLOC *); static DLLVERSIONINFO shellVersion = { 0 }; static LPMALLOC pMalloc; +static const BYTE guidType[] = { PT_GUID }; +static const BYTE controlPanelType[] = { PT_SHELLEXT, PT_GUID }; +static const BYTE folderType[] = { PT_FOLDER }; +static const BYTE favoritesType[] = { PT_FOLDER, 0 }; +static const BYTE folderOrSpecialType[] = { PT_FOLDER, PT_IESPECIAL2 }; +/* FIXME: don't know the type of 0x71 returned by Vista/2008 for printers */ +static const BYTE printersType[] = { PT_YAGUID, PT_SHELLEXT, 0x71 }; +static const BYTE ieSpecialType[] = { PT_IESPECIAL2 }; +static const BYTE shellExtType[] = { PT_SHELLEXT }; +static const BYTE workgroupType[] = { PT_WORKGRP }; +#define DECLARE_TYPE(x, y) { x, sizeof(y) / sizeof(y[0]), y } static const struct shellExpectedValues requiredShellValues[] = { - { CSIDL_BITBUCKET, PT_GUID, 0 }, - { CSIDL_CONTROLS, PT_SHELLEXT, PT_GUID }, - { CSIDL_COOKIES, PT_FOLDER, 0 }, - { CSIDL_DESKTOPDIRECTORY, PT_FOLDER, 0 }, - { CSIDL_DRIVES, PT_GUID, 0 }, -/* Note that 0 is an expected type for CSIDL_FAVORITES. Inverting the order - * will cause the test to fail, as it'll only check for PT_FOLDER. - */ - { CSIDL_FAVORITES, 0, PT_FOLDER }, - { CSIDL_FONTS, PT_FOLDER, PT_IESPECIAL2 }, + DECLARE_TYPE(CSIDL_BITBUCKET, guidType), + DECLARE_TYPE(CSIDL_CONTROLS, controlPanelType), + DECLARE_TYPE(CSIDL_COOKIES, folderType), + DECLARE_TYPE(CSIDL_DESKTOPDIRECTORY, folderType), + DECLARE_TYPE(CSIDL_DRIVES, guidType), + DECLARE_TYPE(CSIDL_FAVORITES, favoritesType), + DECLARE_TYPE(CSIDL_FONTS, folderOrSpecialType), /* FIXME: the following fails in Wine, returns type PT_FOLDER - { CSIDL_HISTORY, PT_IESPECIAL2, 0 }, + DECLARE_TYPE(CSIDL_HISTORY, ieSpecialType), */ - { CSIDL_INTERNET, PT_GUID, 0 }, - { CSIDL_NETHOOD, PT_FOLDER, 0 }, - { CSIDL_NETWORK, PT_GUID, 0 }, -/* FIXME: don't know the type of 0x71 returned by Vista/2008 for printers */ - { CSIDL_PRINTERS, PT_YAGUID, 0x71 }, - { CSIDL_PRINTHOOD, PT_FOLDER, 0 }, - { CSIDL_PROGRAMS, PT_FOLDER, 0 }, - { CSIDL_RECENT, PT_FOLDER, PT_IESPECIAL2 }, - { CSIDL_SENDTO, PT_FOLDER, 0 }, - { CSIDL_STARTMENU, PT_FOLDER, 0 }, - { CSIDL_STARTUP, PT_FOLDER, 0 }, - { CSIDL_TEMPLATES, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_INTERNET, guidType), + DECLARE_TYPE(CSIDL_NETHOOD, folderType), + DECLARE_TYPE(CSIDL_NETWORK, guidType), + DECLARE_TYPE(CSIDL_PRINTERS, printersType), + DECLARE_TYPE(CSIDL_PRINTHOOD, folderType), + DECLARE_TYPE(CSIDL_PROGRAMS, folderType), + DECLARE_TYPE(CSIDL_RECENT, folderOrSpecialType), + DECLARE_TYPE(CSIDL_SENDTO, folderType), + DECLARE_TYPE(CSIDL_STARTMENU, folderType), + DECLARE_TYPE(CSIDL_STARTUP, folderType), + DECLARE_TYPE(CSIDL_TEMPLATES, folderType), }; static const struct shellExpectedValues optionalShellValues[] = { /* FIXME: the following only semi-succeed; they return NULL PIDLs on XP.. hmm. - { CSIDL_ALTSTARTUP, PT_FOLDER, 0 }, - { CSIDL_COMMON_ALTSTARTUP, PT_FOLDER, 0 }, - { CSIDL_COMMON_OEM_LINKS, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_ALTSTARTUP, folderType), + DECLARE_TYPE(CSIDL_COMMON_ALTSTARTUP, folderType), + DECLARE_TYPE(CSIDL_COMMON_OEM_LINKS, folderType), */ /* Windows NT-only: */ - { CSIDL_COMMON_DESKTOPDIRECTORY, PT_FOLDER, 0 }, - { CSIDL_COMMON_DOCUMENTS, PT_SHELLEXT, 0 }, - { CSIDL_COMMON_FAVORITES, PT_FOLDER, 0 }, - { CSIDL_COMMON_PROGRAMS, PT_FOLDER, 0 }, - { CSIDL_COMMON_STARTMENU, PT_FOLDER, 0 }, - { CSIDL_COMMON_STARTUP, PT_FOLDER, 0 }, - { CSIDL_COMMON_TEMPLATES, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_COMMON_DESKTOPDIRECTORY, folderType), + DECLARE_TYPE(CSIDL_COMMON_DOCUMENTS, shellExtType), + DECLARE_TYPE(CSIDL_COMMON_FAVORITES, folderType), + DECLARE_TYPE(CSIDL_COMMON_PROGRAMS, folderType), + DECLARE_TYPE(CSIDL_COMMON_STARTMENU, folderType), + DECLARE_TYPE(CSIDL_COMMON_STARTUP, folderType), + DECLARE_TYPE(CSIDL_COMMON_TEMPLATES, folderType), /* first appearing in shell32 version 4.71: */ - { CSIDL_APPDATA, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_APPDATA, folderType), /* first appearing in shell32 version 4.72: */ - { CSIDL_INTERNET_CACHE, PT_IESPECIAL2, 0 }, + DECLARE_TYPE(CSIDL_INTERNET_CACHE, ieSpecialType), /* first appearing in shell32 version 5.0: */ - { CSIDL_ADMINTOOLS, PT_FOLDER, 0 }, - { CSIDL_COMMON_APPDATA, PT_FOLDER, 0 }, - { CSIDL_LOCAL_APPDATA, PT_FOLDER, 0 }, - { OLD_CSIDL_MYDOCUMENTS, PT_FOLDER, 0 }, - { CSIDL_MYMUSIC, PT_FOLDER, 0 }, - { CSIDL_MYPICTURES, PT_FOLDER, 0 }, - { CSIDL_MYVIDEO, PT_FOLDER, 0 }, - { CSIDL_PROFILE, PT_FOLDER, 0 }, - { CSIDL_PROGRAM_FILES, PT_FOLDER, 0 }, - { CSIDL_PROGRAM_FILESX86, PT_FOLDER, 0 }, - { CSIDL_PROGRAM_FILES_COMMON, PT_FOLDER, 0 }, - { CSIDL_PROGRAM_FILES_COMMONX86, PT_FOLDER, 0 }, - { CSIDL_SYSTEM, PT_FOLDER, 0 }, - { CSIDL_WINDOWS, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_ADMINTOOLS, folderType), + DECLARE_TYPE(CSIDL_COMMON_APPDATA, folderType), + DECLARE_TYPE(CSIDL_LOCAL_APPDATA, folderType), + DECLARE_TYPE(OLD_CSIDL_MYDOCUMENTS, folderType), + DECLARE_TYPE(CSIDL_MYMUSIC, folderType), + DECLARE_TYPE(CSIDL_MYPICTURES, folderType), + DECLARE_TYPE(CSIDL_MYVIDEO, folderType), + DECLARE_TYPE(CSIDL_PROFILE, folderType), + DECLARE_TYPE(CSIDL_PROGRAM_FILES, folderType), + DECLARE_TYPE(CSIDL_PROGRAM_FILESX86, folderType), + DECLARE_TYPE(CSIDL_PROGRAM_FILES_COMMON, folderType), + DECLARE_TYPE(CSIDL_PROGRAM_FILES_COMMONX86, folderType), + DECLARE_TYPE(CSIDL_SYSTEM, folderType), + DECLARE_TYPE(CSIDL_WINDOWS, folderType), /* first appearing in shell32 6.0: */ - { CSIDL_CDBURN_AREA, PT_FOLDER, 0 }, - { CSIDL_COMMON_MUSIC, PT_FOLDER, 0 }, - { CSIDL_COMMON_PICTURES, PT_FOLDER, 0 }, - { CSIDL_COMMON_VIDEO, PT_FOLDER, 0 }, - { CSIDL_COMPUTERSNEARME, PT_WORKGRP, 0 }, - { CSIDL_RESOURCES, PT_FOLDER, 0 }, - { CSIDL_RESOURCES_LOCALIZED, PT_FOLDER, 0 }, + DECLARE_TYPE(CSIDL_CDBURN_AREA, folderType), + DECLARE_TYPE(CSIDL_COMMON_MUSIC, folderType), + DECLARE_TYPE(CSIDL_COMMON_PICTURES, folderType), + DECLARE_TYPE(CSIDL_COMMON_VIDEO, folderType), + DECLARE_TYPE(CSIDL_COMPUTERSNEARME, workgroupType), + DECLARE_TYPE(CSIDL_RESOURCES, folderType), + DECLARE_TYPE(CSIDL_RESOURCES_LOCALIZED, folderType), }; +#undef DECLARE_TYPE static void loadShell32(void) { @@ -476,40 +484,27 @@ static void testShellValues(const struct shellExpectedValues testEntries[], for (i = 0; i < numEntries; i++) { BYTE type; + int j; + BOOL foundTypeMatch = FALSE; if (pSHGetFolderLocation) { type = testSHGetFolderLocation(optional, testEntries[i].folder); - if (!testEntries[i].altPidlType) - ok(type == testEntries[i].pidlType || optional || - broken(type == 0xff) /* Win9x */, - "%s has type %d (0x%02x), expected %d (0x%02x)\n", - getFolderName(testEntries[i].folder), type, type, - testEntries[i].pidlType, testEntries[i].pidlType); - else - ok(type == testEntries[i].pidlType || - type == testEntries[i].altPidlType || - optional || broken(type == 0xff) /* Win9x */, - "%s has type %d (0x%02x), expected %d (0x%02x) or %d (0x%02x)\n", - getFolderName(testEntries[i].folder), type, type, - testEntries[i].pidlType, testEntries[i].pidlType, - testEntries[i].altPidlType, testEntries[i].altPidlType); + for (j = 0; !foundTypeMatch && j < testEntries[i].numTypes; j++) + if (testEntries[i].types[j] == type) + foundTypeMatch = TRUE; + ok(foundTypeMatch || optional || broken(type == 0xff) /* Win9x */, + "%s has unexpected type %d (0x%02x)\n", + getFolderName(testEntries[i].folder), type, type); } type = testSHGetSpecialFolderLocation(optional, testEntries[i].folder); - if (!testEntries[i].altPidlType) - ok(type == testEntries[i].pidlType || optional || - broken(type == 0xff) /* Win9x */, - "%s has type %d (0x%02x), expected %d (0x%02x)\n", - getFolderName(testEntries[i].folder), type, type, - testEntries[i].pidlType, testEntries[i].pidlType); - else - ok(type == testEntries[i].pidlType || - type == testEntries[i].altPidlType || - optional || broken(type == 0xff) /* Win9x */, - "%s has type %d (0x%02x), expected %d (0x%02x) or %d (0x%02x)\n", - getFolderName(testEntries[i].folder), type, type, - testEntries[i].pidlType, testEntries[i].pidlType, - testEntries[i].altPidlType, testEntries[i].altPidlType); + for (j = 0, foundTypeMatch = FALSE; !foundTypeMatch && + j < testEntries[i].numTypes; j++) + if (testEntries[i].types[j] == type) + foundTypeMatch = TRUE; + ok(foundTypeMatch || optional || broken(type == 0xff) /* Win9x */, + "%s has unexpected type %d (0x%02x)\n", + getFolderName(testEntries[i].folder), type, type); switch (type) { case PT_FOLDER:

1 0

Juan Lang : shell32: Fix a couple test failures on NT4.
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: dfdf2be7c6108ca89faee3cdb2a789698c8cf170 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dfdf2be7c6108ca89faee3cdb… Author: Juan Lang <juan.lang(a)gmail.com> Date: Tue Feb 3 09:01:59 2009 -0800 shell32: Fix a couple test failures on NT4. --- dlls/shell32/tests/shellpath.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/tests/shellpath.c b/dlls/shell32/tests/shellpath.c index 7c7cc52..0c7bafd 100644 --- a/dlls/shell32/tests/shellpath.c +++ b/dlls/shell32/tests/shellpath.c @@ -419,7 +419,9 @@ static BYTE testSHGetSpecialFolderLocation(BOOL optional, int folder) pidl = NULL; hr = pSHGetSpecialFolderLocation(NULL, folder, &pidl); - ok(SUCCEEDED(hr) || optional, + ok(SUCCEEDED(hr) || optional || + broken((folder == CSIDL_COOKIES || folder == CSIDL_INTERNET) && + hr == E_INVALIDARG) /* NT4 */, "SHGetSpecialFolderLocation(NULL, %s, &pidl) failed: 0x%08x\n", getFolderName(folder), hr); if (SUCCEEDED(hr)) {

1 0

Juan Lang : rsaenh: Fix failing tests on Windows ME.
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: 8b0f2e3e4bd2a3e6c8e893b18b8b88657054e2fc URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b0f2e3e4bd2a3e6c8e893b18… Author: Juan Lang <juan.lang(a)gmail.com> Date: Tue Feb 3 08:11:33 2009 -0800 rsaenh: Fix failing tests on Windows ME. --- dlls/rsaenh/tests/rsaenh.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c index ad53c72..8e12b2a 100644 --- a/dlls/rsaenh/tests/rsaenh.c +++ b/dlls/rsaenh/tests/rsaenh.c @@ -2033,8 +2033,12 @@ static void test_null_provider(void) uniquecontainer(container); todo_wine { - ok(dataLen == strlen(container)+1, "Expected a param length of 70, got %d\n", dataLen); - ok(!strcmp(container, szName), "Wrong container name : %s\n", szName); + ok(dataLen == strlen(container)+1 || + broken(dataLen == strlen(szContainer)+1) /* WinME */, + "Expected a param length of 70, got %d\n", dataLen); + ok(!strcmp(container, szName) || + broken(!strcmp(szName, szContainer)) /* WinME */, + "Wrong container name : %s\n", szName); } } result = CryptGetUserKey(prov, AT_KEYEXCHANGE, &key);

1 0

Juan Lang : wintrust: Use GetSystemDirectory rather than GetWindowsDirectory to find the CatRoot directories .
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: 2d0e58642510129569a966c94dd781c0868a1b26 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d0e58642510129569a966c94… Author: Juan Lang <juan.lang(a)gmail.com> Date: Tue Feb 3 08:04:15 2009 -0800 wintrust: Use GetSystemDirectory rather than GetWindowsDirectory to find the CatRoot directories. --- dlls/wintrust/tests/crypt.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/wintrust/tests/crypt.c b/dlls/wintrust/tests/crypt.c index 64211f1..1d7f30e 100644 --- a/dlls/wintrust/tests/crypt.c +++ b/dlls/wintrust/tests/crypt.c @@ -1079,7 +1079,7 @@ START_TEST(crypt) { int myARGC; char** myARGV; - char windir[MAX_PATH]; + char sysdir[MAX_PATH]; InitFunctionPtrs(); @@ -1089,11 +1089,11 @@ START_TEST(crypt) return; } - GetWindowsDirectoryA(windir, MAX_PATH); - lstrcpyA(catroot, windir); - lstrcatA(catroot, "\\system32\\CatRoot"); - lstrcpyA(catroot2, windir); - lstrcatA(catroot2, "\\system32\\CatRoot2"); + GetSystemDirectoryA(sysdir, MAX_PATH); + lstrcpyA(catroot, sysdir); + lstrcatA(catroot, "\\CatRoot"); + lstrcpyA(catroot2, sysdir); + lstrcatA(catroot2, "\\CatRoot2"); myARGC = winetest_get_mainargs(&myARGV); strcpy(selfname, myARGV[0]);

1 0

Juan Lang : secur32: Fix a handful of test failures on Win9x.
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: b9ae777d966bdc950c97619d0efd3e1262851ed9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b9ae777d966bdc950c97619d0… Author: Juan Lang <juan.lang(a)gmail.com> Date: Tue Feb 3 07:48:59 2009 -0800 secur32: Fix a handful of test failures on Win9x. --- dlls/secur32/tests/secur32.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/secur32/tests/secur32.c b/dlls/secur32/tests/secur32.c index 39edeea..27e07fb 100644 --- a/dlls/secur32/tests/secur32.c +++ b/dlls/secur32/tests/secur32.c @@ -102,9 +102,15 @@ static void test_InitSecurityInterface(void) sftA = pInitSecurityInterfaceA(); ok(sftA != NULL, "pInitSecurityInterfaceA failed\n"); ok(sftA->dwVersion == SECURITY_SUPPORT_PROVIDER_INTERFACE_VERSION, "wrong dwVersion %d in security function table\n", sftA->dwVersion); - ok(!sftA->Reserved2, "Reserved2 should be NULL instead of %p in security function table\n", sftA->Reserved2); - ok(sftA->Reserved3 == sftA->EncryptMessage, "Reserved3 should be equal to EncryptMessage in the security function table\n"); - ok(sftA->Reserved4 == sftA->DecryptMessage, "Reserved4 should be equal to DecryptMessage in the security function table\n"); + ok(!sftA->Reserved2 || broken(sftA->Reserved2 != NULL) /* WinME */, + "Reserved2 should be NULL instead of %p in security function table\n", + sftA->Reserved2); + ok(sftA->Reserved3 == sftA->EncryptMessage || + broken(sftA->Reserved3 != sftA->EncryptMessage) /* Win9x */, + "Reserved3 should be equal to EncryptMessage in the security function table\n"); + ok(sftA->Reserved4 == sftA->DecryptMessage || + broken(sftA->Reserved4 != sftA->DecryptMessage) /* Win9x */, + "Reserved4 should be equal to DecryptMessage in the security function table\n"); if (!pInitSecurityInterfaceW) {

1 0

Alexandre Julliard : setupapi/tests: Don' t compare the drive letter of expanded file paths.
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: 486e66ed6edf3805a07e55e6875d349499e20bb2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=486e66ed6edf3805a07e55e68… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 3 22:23:35 2009 +0100 setupapi/tests: Don't compare the drive letter of expanded file paths. --- dlls/setupapi/tests/parser.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/setupapi/tests/parser.c b/dlls/setupapi/tests/parser.c index ddfd0f2..0aa78c1 100644 --- a/dlls/setupapi/tests/parser.c +++ b/dlls/setupapi/tests/parser.c @@ -439,6 +439,11 @@ static void test_key_names(void) !strcmp( field, A1200), /* Vista, W2K8 */ "line %u: bad field %s/%s\n", i, field, key_names[i].fields[index] ); + else /* don't compare drive letter of paths */ + if (field[0] && field[1] == ':' && field[2] == '\\') + ok( !strcmp( field + 1, key_names[i].fields[index] + 1 ), + "line %u: bad field %s/%s\n", + i, field, key_names[i].fields[index] ); else ok( !strcmp( field, key_names[i].fields[index] ), "line %u: bad field %s/%s\n", i, field, key_names[i].fields[index] ); @@ -584,18 +589,18 @@ static void test_SetupGetIntField(void) retb = SetupGetIntField( &context, keys[i].index, &intfield ); if ( keys[i].err == ERROR_SUCCESS ) { - ok( retb, "Expected success\n" ); + ok( retb, "%u: Expected success\n", i ); ok( GetLastError() == ERROR_SUCCESS || GetLastError() == 0xdeadbeef /* win9x, NT4 */, - "Expected ERROR_SUCCESS or 0xdeadbeef, got %u\n", GetLastError() ); + "%u: Expected ERROR_SUCCESS or 0xdeadbeef, got %u\n", i, GetLastError() ); } else { - ok( !retb, "Expected failure\n" ); + ok( !retb, "%u: Expected failure\n", i ); ok( GetLastError() == keys[i].err, - "Expected %d, got %u\n", keys[i].err, GetLastError() ); + "%u: Expected %d, got %u\n", i, keys[i].err, GetLastError() ); } - ok( intfield == keys[i].value, "Expected %d, got %d\n", keys[i].value, intfield ); + ok( intfield == keys[i].value, "%u: Expected %d, got %d\n", i, keys[i].value, intfield ); SetupCloseInfFile( hinf ); }

1 0

Alexandre Julliard : kernel32/tests: Add another error code in the CreateDirectory test.
by Alexandre Julliard 04 Feb '09

04 Feb '09

Module: wine Branch: master Commit: 5d0f3aa33b000be1b6c2d91506a8b5f9d3a7f68e URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d0f3aa33b000be1b6c2d9150… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 3 22:23:19 2009 +0100 kernel32/tests: Add another error code in the CreateDirectory test. --- dlls/kernel32/tests/directory.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/tests/directory.c b/dlls/kernel32/tests/directory.c index 2c943d1..a0ccd9f 100644 --- a/dlls/kernel32/tests/directory.c +++ b/dlls/kernel32/tests/directory.c @@ -363,7 +363,7 @@ static void test_CreateDirectoryW(void) GetTempPathW(MAX_PATH, tmpdir); tmpdir[3] = 0; /* truncate the path */ ret = CreateDirectoryW(tmpdir, NULL); - ok(ret == FALSE && GetLastError() == ERROR_ACCESS_DENIED, + ok(ret == FALSE && (GetLastError() == ERROR_ACCESS_DENIED || GetLastError() == ERROR_ALREADY_EXISTS), "should deny access to the drive root ret %u err %u\n", ret, GetLastError()); GetTempPathW(MAX_PATH, tmpdir);

1 0

Paul Vriens : riched32/tests: Skip some tests on Win9x, WinME and NT4.
by Alexandre Julliard 03 Feb '09

03 Feb '09

Module: wine Branch: master Commit: e1b80a04a031336adc28ac78f951bfead79c345f URL: http://source.winehq.org/git/wine.git/?a=commit;h=e1b80a04a031336adc28ac78f… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Tue Feb 3 13:55:53 2009 +0100 riched32/tests: Skip some tests on Win9x, WinME and NT4. --- dlls/riched32/tests/editor.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/riched32/tests/editor.c b/dlls/riched32/tests/editor.c index 006da7d..6216001 100644 --- a/dlls/riched32/tests/editor.c +++ b/dlls/riched32/tests/editor.c @@ -450,6 +450,10 @@ static void test_EM_LINELENGTH(void) SendMessage(hwndRichEdit, WM_SETTEXT, 0, (LPARAM) text); result = SendMessage(hwndRichEdit, EM_GETLINECOUNT, 0, 0); + if (result == 4) { + win_skip("Win9x, WinME and NT4 don't handle '\\r only' correctly\n"); + return; + } ok(result == 9, "Incorrect line count of %ld\n", result); for (i = 0; i < sizeof(offset_test)/sizeof(offset_test[0]); i++) {

1 0

Alexandre Julliard : kernel32/tests: Don' t hardcode C drive for CreateDirectory tests.
by Alexandre Julliard 03 Feb '09

03 Feb '09

Module: wine Branch: master Commit: 3cd415005924aacde715720d36b8c8e7e96bf3d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3cd415005924aacde715720d3… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 3 15:21:47 2009 +0100 kernel32/tests: Don't hardcode C drive for CreateDirectory tests. --- dlls/kernel32/tests/path.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c index a272b56..397d4f4 100644 --- a/dlls/kernel32/tests/path.c +++ b/dlls/kernel32/tests/path.c @@ -384,14 +384,16 @@ static void test_InitPathA(CHAR *newdir, CHAR *curDrive, CHAR *otherDrive) ok(CreateDirectoryA(tmpstr,NULL),"CreateDirectoryA failed\n"); sprintf(tmpstr,"%s\\%s",newdir,LONGDIR); ok(CreateDirectoryA(tmpstr,NULL),"CreateDirectoryA failed\n"); - bRes = CreateDirectoryA("c:",NULL); - ok(!bRes && (GetLastError() == ERROR_ACCESS_DENIED || + sprintf(tmpstr,"%c:", *curDrive); + bRes = CreateDirectoryA(tmpstr,NULL); + ok(!bRes && (GetLastError() == ERROR_ACCESS_DENIED || GetLastError() == ERROR_ALREADY_EXISTS), - "CreateDirectoryA(\"c:\" should have failed (%d)\n", GetLastError()); - bRes = CreateDirectoryA("c:\\",NULL); + "CreateDirectoryA(\"%s\" should have failed (%d)\n", tmpstr, GetLastError()); + sprintf(tmpstr,"%c:\\", *curDrive); + bRes = CreateDirectoryA(tmpstr,NULL); ok(!bRes && (GetLastError() == ERROR_ACCESS_DENIED || GetLastError() == ERROR_ALREADY_EXISTS), - "CreateDirectoryA(\"c:\\\" should have failed (%d)\n", GetLastError()); + "CreateDirectoryA(\"%s\" should have failed (%d)\n", tmpstr, GetLastError()); sprintf(tmpstr,"%s\\%s\\%s",newdir,SHORTDIR,SHORTFILE); hndl=CreateFileA(tmpstr,GENERIC_WRITE,0,NULL, CREATE_NEW,FILE_ATTRIBUTE_NORMAL,NULL);

1 0

Alexandre Julliard : kernel32/tests: Use a better invalid filename than " foo".
by Alexandre Julliard 03 Feb '09

03 Feb '09

Module: wine Branch: master Commit: 1a28fb6c165c8c3ed6120de2f49ac62a6aa52bc5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1a28fb6c165c8c3ed6120de2f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 3 15:15:49 2009 +0100 kernel32/tests: Use a better invalid filename than "foo". --- dlls/kernel32/tests/file.c | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 1196d7a..a96ea92 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -1323,6 +1323,7 @@ static void test_FindFirstFileA(void) int err; char buffer[5] = "C:\\"; char buffer2[100]; + char nonexistent[MAX_PATH]; /* try FindFirstFileA on "C:\" */ buffer[0] = get_windows_drive(); @@ -1360,8 +1361,10 @@ static void test_FindFirstFileA(void) /* try FindFirstFileA on "C:\foo\" */ SetLastError( 0xdeadbeaf ); - strcpy(buffer2, buffer); - strcat(buffer2, "foo\\"); + GetTempFileNameA( buffer, "foo", 0, nonexistent ); + DeleteFileA( nonexistent ); + strcpy(buffer2, nonexistent); + strcat(buffer2, "\\"); handle = FindFirstFileA(buffer2, &data); err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); @@ -1371,8 +1374,8 @@ static void test_FindFirstFileA(void) /* try FindFirstFileA on "C:\foo\bar.txt" */ SetLastError( 0xdeadbeaf ); - strcpy(buffer2, buffer); - strcat(buffer2, "foo\\bar.txt"); + strcpy(buffer2, nonexistent); + strcat(buffer2, "\\bar.txt"); handle = FindFirstFileA(buffer2, &data); err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); @@ -1380,8 +1383,8 @@ static void test_FindFirstFileA(void) /* try FindFirstFileA on "C:\foo\*.*" */ SetLastError( 0xdeadbeaf ); - strcpy(buffer2, buffer); - strcat(buffer2, "foo\\*.*"); + strcpy(buffer2, nonexistent); + strcat(buffer2, "\\*.*"); handle = FindFirstFileA(buffer2, &data); err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); @@ -1389,7 +1392,8 @@ static void test_FindFirstFileA(void) /* try FindFirstFileA on "foo\bar.txt" */ SetLastError( 0xdeadbeaf ); - strcpy(buffer2, "foo\\bar.txt"); + strcpy(buffer2, nonexistent + 3); + strcat(buffer2, "\\bar.txt"); handle = FindFirstFileA(buffer2, &data); err = GetLastError(); ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 );

1 0

← Newer
1
...
83
84
85
86
87
88
89
...
97
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2009