winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2009
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
834 discussions
Start a n
N
ew thread
Alexandre Julliard : winedos: Release the 16-bit lock before calling ExitThread.
by Alexandre Julliard
31 Mar '09
31 Mar '09
Module: wine Branch: master Commit: c5bdfdfb2da8c2cb414a3263939467d920b987cc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c5bdfdfb2da8c2cb414a32639…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 31 12:39:10 2009 +0200 winedos: Release the 16-bit lock before calling ExitThread. This avoids deadlocks with the loader lock. --- dlls/winedos/dosexe.h | 1 + dlls/winedos/int21.c | 4 ++-- dlls/winedos/int31.c | 4 ++-- dlls/winedos/interrupts.c | 2 +- dlls/winedos/module.c | 16 ++++++++++++++-- 5 files changed, 20 insertions(+), 7 deletions(-) diff --git a/dlls/winedos/dosexe.h b/dlls/winedos/dosexe.h index 023d691..77eed9e 100644 --- a/dlls/winedos/dosexe.h +++ b/dlls/winedos/dosexe.h @@ -352,6 +352,7 @@ extern BOOL WINAPI MZ_Current( void ); extern void WINAPI MZ_AllocDPMITask( void ); extern void WINAPI MZ_RunInThread( PAPCFUNC proc, ULONG_PTR arg ); extern BOOL DOSVM_IsWin16(void); +extern void DOSVM_Exit( WORD retval ); /* dosvm.c */ extern void DOSVM_SendQueuedEvents( CONTEXT86 * ); diff --git a/dlls/winedos/int21.c b/dlls/winedos/int21.c index cbce913..79aa8ea 100644 --- a/dlls/winedos/int21.c +++ b/dlls/winedos/int21.c @@ -4176,7 +4176,7 @@ void WINAPI DOSVM_Int21Handler( CONTEXT86 *context ) case 0x00: /* TERMINATE PROGRAM */ TRACE("TERMINATE PROGRAM\n"); if (DOSVM_IsWin16()) - ExitThread( 0 ); + DOSVM_Exit( 0 ); else if(ISV86(context)) MZ_Exit( context, FALSE, 0 ); else @@ -5050,7 +5050,7 @@ void WINAPI DOSVM_Int21Handler( CONTEXT86 *context ) case 0x4c: /* "EXIT" - TERMINATE WITH RETURN CODE */ TRACE( "EXIT with return code %d\n", AL_reg(context) ); if (DOSVM_IsWin16()) - ExitThread( AL_reg(context) ); + DOSVM_Exit( AL_reg(context) ); else if(ISV86(context)) MZ_Exit( context, FALSE, AL_reg(context) ); else diff --git a/dlls/winedos/int31.c b/dlls/winedos/int31.c index e555e97..9cc9e90 100644 --- a/dlls/winedos/int31.c +++ b/dlls/winedos/int31.c @@ -626,11 +626,11 @@ static void StartPM( CONTEXT86 *context ) TRACE( "Protected mode DOS program is terminating\n" ); /* - * FIXME: Instead of calling ExitThread, we should release all + * FIXME: Instead of calling DOSVM_Exit, we should release all * allocated protected mode resources and call MZ_Exit * using real mode context. See DPMI specification. */ - ExitThread( DPMI_retval ); + DOSVM_Exit( DPMI_retval ); #if 0 wine_ldt_free_entries( psp->environment, 1 ); diff --git a/dlls/winedos/interrupts.c b/dlls/winedos/interrupts.c index db0f17e..81cb2bb 100644 --- a/dlls/winedos/interrupts.c +++ b/dlls/winedos/interrupts.c @@ -951,7 +951,7 @@ static void WINAPI DOSVM_Int1aHandler( CONTEXT86 *context ) static void WINAPI DOSVM_Int20Handler( CONTEXT86 *context ) { if (DOSVM_IsWin16()) - ExitThread( 0 ); + DOSVM_Exit( 0 ); else if(ISV86(context)) MZ_Exit( context, TRUE, 0 ); else diff --git a/dlls/winedos/module.c b/dlls/winedos/module.c index a88aa0c..3b2abe7 100644 --- a/dlls/winedos/module.c +++ b/dlls/winedos/module.c @@ -64,6 +64,18 @@ BOOL DOSVM_IsWin16(void) return DOSVM_isdosexe ? FALSE : TRUE; } +/********************************************************************** + * DOSVM_Exit + */ +void DOSVM_Exit( WORD retval ) +{ + DWORD count; + + ReleaseThunkLock( &count ); + ExitThread( retval ); +} + + #ifdef MZ_SUPPORTED #ifdef HAVE_SYS_MMAN_H @@ -731,7 +743,7 @@ void WINAPI MZ_Exit( CONTEXT86 *context, BOOL cs_psp, WORD retval ) } else TRACE("killing DOS task\n"); } - ExitThread( retval ); + DOSVM_Exit( retval ); } @@ -785,7 +797,7 @@ void WINAPI MZ_RunInThread( PAPCFUNC proc, ULONG_PTR arg ) */ void WINAPI MZ_Exit( CONTEXT86 *context, BOOL cs_psp, WORD retval ) { - ExitThread( retval ); + DOSVM_Exit( retval ); } /***********************************************************************
1
0
0
0
Alexandre Julliard : include: Try to avoid socklen_t redefinition in winsock.h.
by Alexandre Julliard
31 Mar '09
31 Mar '09
Module: wine Branch: master Commit: a6aa7771d3b7db21819ce8f07518f85149404039 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a6aa7771d3b7db21819ce8f07…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 31 12:19:03 2009 +0200 include: Try to avoid socklen_t redefinition in winsock.h. --- include/winsock.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/winsock.h b/include/winsock.h index 537e16a..6870197 100644 --- a/include/winsock.h +++ b/include/winsock.h @@ -79,12 +79,14 @@ # define fd_set unix_fd_set # define timeval unix_timeval # define select unix_select +# define socklen_t unix_socklen_t # include <sys/types.h> # include <time.h> # include <stdlib.h> # undef fd_set # undef timeval # undef select +# undef socklen_t # undef FD_SETSIZE # undef FD_CLR # undef FD_SET
1
0
0
0
Alexandre Julliard : ws2_32/tests: Don't use socklen_t.
by Alexandre Julliard
31 Mar '09
31 Mar '09
Module: wine Branch: master Commit: 65e71259df49574bb3c63ca9ba5f9d417b077fff URL:
http://source.winehq.org/git/wine.git/?a=commit;h=65e71259df49574bb3c63ca9b…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 31 12:13:15 2009 +0200 ws2_32/tests: Don't use socklen_t. --- dlls/ws2_32/tests/sock.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 22455ef..ffc7ba9 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -270,7 +270,7 @@ static int do_synchronous_recv ( SOCKET s, char *buf, int buflen, int recvlen ) return p - buf; } -static int do_synchronous_recvfrom ( SOCKET s, char *buf, int buflen,int flags,struct sockaddr *from, socklen_t *fromlen, int recvlen ) +static int do_synchronous_recvfrom ( SOCKET s, char *buf, int buflen,int flags,struct sockaddr *from, int *fromlen, int recvlen ) { char* last = buf + buflen, *p; int n = 1; @@ -642,7 +642,7 @@ static VOID WINAPI simple_mixed_client ( client_params *par ) test_params *gen = par->general; client_memory *mem; int pos, n_sent, n_recvd, n_expected = gen->n_chunks * gen->chunk_size, id; - socklen_t fromLen = sizeof(mem->addr); + int fromLen = sizeof(mem->addr); struct sockaddr test; id = GetCurrentThreadId();
1
0
0
0
Alexandre Julliard : inetcomm: Include ws2tcpip.h before anything else.
by Alexandre Julliard
31 Mar '09
31 Mar '09
Module: wine Branch: master Commit: 2e8d68d68301d3f6a4a4874a38d29dd5203161fb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2e8d68d68301d3f6a4a4874a3…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 31 12:12:13 2009 +0200 inetcomm: Include ws2tcpip.h before anything else. --- dlls/inetcomm/internettransport.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/inetcomm/internettransport.c b/dlls/inetcomm/internettransport.c index f0499bc..af4772c 100644 --- a/dlls/inetcomm/internettransport.c +++ b/dlls/inetcomm/internettransport.c @@ -20,19 +20,15 @@ #define COBJMACROS -#include <stdarg.h> -#include <stdio.h> - +#include "ws2tcpip.h" #include "windef.h" -#include "winbase.h" #include "winnt.h" -#include "winuser.h" -#include "winsock2.h" -#include "ws2tcpip.h" #include "objbase.h" #include "ole2.h" #include "mimeole.h" +#include <stdio.h> + #include "wine/debug.h" #include "inetcomm_private.h"
1
0
0
0
Maik Schulz : corrective patch for german 1.1.18 release news item
by Jeremy Newman
31 Mar '09
31 Mar '09
Module: website Branch: master Commit: 24d82638c565acdac059cd8e891da4244f6d6faf URL:
http://source.winehq.org/git/website.git/?a=commit;h=24d82638c565acdac059cd…
Author: Maik Schulz <maik.schulz(a)gmail.com> Date: Tue Mar 31 00:14:03 2009 +0200 corrective patch for german 1.1.18 release news item Hi, my first translation patch missed the date and title tags, here is the correction. Cheers, -Maik >From 5cfacf2f43df711dba21fa8d393d9693c22c1392 Mon Sep 17 00:00:00 2001 From: Maik Schulz <maik.schulz(a)gmail.com> Date: Tue, 31 Mar 2009 00:11:47 +0200 Subject: correction of german 1.1.18 news item --- news/de/2009032701.xml | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/news/de/2009032701.xml b/news/de/2009032701.xml index ec1e6dd..545f435 100644 --- a/news/de/2009032701.xml +++ b/news/de/2009032701.xml @@ -1,6 +1,6 @@ <news> -<date>March 27, 2009</date> -<title>Wine 1.1.18 Released</title> +<date>27. März 2009</date> +<title>Wine 1.1.18 Freigegeben</title> <body> <p> Die Entwicklungsversion 1.1.18 von Wine ist jetzt verfügbar.</p> <p> <a href="{$root}/announce/1.1.18">Neuerungen (en)</a> in dieser Version:
1
0
0
0
Christoph Korn : wine-website: German template sync
by Jeremy Newman
30 Mar '09
30 Mar '09
Module: website Branch: master Commit: 1b5891d10510bfd5b873212b9d56c2dc79a8596c URL:
http://source.winehq.org/git/website.git/?a=commit;h=1b5891d10510bfd5b87321…
Author: Christoph Korn <c_korn(a)gmx.de> Date: Mon Mar 30 22:50:17 2009 +0200 wine-website: German template sync Just a template sync for the jaunty download. Christoph >From 15caea52d7a63272d62b769c81af501dd4908190 Mon Sep 17 00:00:00 2001 From: Christoph Korn <c_korn(a)gmx.de> Date: Mon, 30 Mar 2009 22:45:10 +0200 Subject: German template sync. Sync commit "Update-download-and-download-deb-page-for-Ubuntu-9.04" Commit: 7ed6536bc070fa779ec67e82669184872ea13d9a --- templates/de/download.template | 2 +- templates/de/download/deb.template | 4 ++++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/templates/de/download.template b/templates/de/download.template index e46cc97..70fd6e6 100644 --- a/templates/de/download.template +++ b/templates/de/download.template @@ -62,7 +62,7 @@ erbeten hat, dass sie die Wine-Website hosten.</p> <img src="{$root}/images/distro/ubuntu.png" width="50" height="50" alt="Ubuntu linux" border="0"></a> </td> <td> <b><a href="{$root}/download/deb">Ubuntu</a></b> - binär und Quellcode .debs für Ubuntu Hardy (8.04) und Intrepid (8.10) + binär und Quellcode .debs für Ubuntu Hardy (8.04), Intrepid (8.10) und Jaunty (9.04) <td><a href="mailto:scott@open-vote.org">Scott Ritchie</a></td> </tr> diff --git a/templates/de/download/deb.template b/templates/de/download/deb.template index 7ed2f4a..bc5315e 100644 --- a/templates/de/download/deb.template +++ b/templates/de/download/deb.template @@ -32,6 +32,8 @@ von Drittanbietern</b>-Reiter und klicke auf <b>Hinzufügen</b>.</p> <p>Dann, <b>copy-paste eine der unteren Zeilen</b> in Abhängigkeit welche Version du benutzt.</p> +<p><b>Für Ubuntu Jaunty (9.04):</b><br> +<i>deb
http://wine.budgetdedicated.com/apt
jaunty main #WineHQ - Ubuntu 9.04 "Jaunty Jackalope"</i></p> <p><b>Für Ubuntu Intrepid (8.10):</b><br> <i>deb
http://wine.budgetdedicated.com/apt
intrepid main #WineHQ - Ubuntu 8.10 "Intrepid Ibex"</i></p> <p><b>Für Ubuntu Hardy (8.04):</b><br> @@ -88,6 +90,8 @@ in das Terminal copy-pastest.:</p> <p>Danach, füge das Repository zu den APT-Quellen Deines Systems hinzu:</p> +<p><b>Für Ubuntu Jaunty (9.04):</b><br> +<i>sudo wget
http://wine.budgetdedicated.com/apt/sources.list.d/jaunty.list
-O /etc/apt/sources.list.d/winehq.list</i></p> <p><b>Für Ubuntu Intrepid (8.10):</b><br> <i>sudo wget
http://wine.budgetdedicated.com/apt/sources.list.d/intrepid.list
-O /etc/apt/sources.list.d/winehq.list</i></p> <p><b>Für Ubuntu Hardy (8.04):</b><br>
1
0
0
0
Rico Schüller : Implement d3dx9_41 and forward the functions to d3dx9_36.
by Alexandre Julliard
30 Mar '09
30 Mar '09
Module: wine Branch: master Commit: 3400c03346b8afe45db00bbdc2ddc3270ccd9106 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3400c03346b8afe45db00bbdc…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Mar 29 15:41:21 2009 +0200 Implement d3dx9_41 and forward the functions to d3dx9_36. --- configure | 9 + configure.ac | 1 + dlls/d3dx9_41/Makefile.in | 15 ++ dlls/d3dx9_41/d3dx9_41.spec | 336 +++++++++++++++++++++++++++++++++++++++++ dlls/d3dx9_41/d3dx9_41_main.c | 63 ++++++++ dlls/d3dx9_41/version.rc | 27 ++++ 6 files changed, 451 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=3400c03346b8afe45db00…
1
0
0
0
Detlef Riekenberg : msi/tests: Fix a copy & paste typo in a test message.
by Alexandre Julliard
30 Mar '09
30 Mar '09
Module: wine Branch: master Commit: 03ff6ba6414a8bfe5d18213f063f6856538a158b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=03ff6ba6414a8bfe5d18213f0…
Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Mon Mar 30 17:33:09 2009 +0200 msi/tests: Fix a copy & paste typo in a test message. --- dlls/msi/tests/install.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 6dbcf31..768ece1 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -1779,7 +1779,7 @@ static void test_MsiInstallProduct(void) type = REG_SZ; res = RegQueryValueExA(hkey, "OrderTestName", NULL, &type, (LPBYTE)path, &size); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); - ok(!lstrcmpA(path, "OrderTestValue"), "Expected imaname, got %s\n", path); + ok(!lstrcmpA(path, "OrderTestValue"), "Expected OrderTestValue, got %s\n", path); check_service_is_installed();
1
0
0
0
Aric Stewart : advapi32: Alias some sids in LookupAccountName and make comparison case insensitive.
by Alexandre Julliard
30 Mar '09
30 Mar '09
Module: wine Branch: master Commit: 4ea704d15a2bb3c5f628f1edd48be1dcee16d3c7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4ea704d15a2bb3c5f628f1edd…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Fri Mar 27 09:47:43 2009 -0500 advapi32: Alias some sids in LookupAccountName and make comparison case insensitive. --- dlls/advapi32/security.c | 10 +++++-- dlls/advapi32/tests/security.c | 56 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index a220ddb..a26e81a 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -167,6 +167,7 @@ typedef struct _AccountSid { LPCWSTR account; LPCWSTR domain; SID_NAME_USE name_use; + LPCWSTR alias; } AccountSid; static const WCHAR Account_Operators[] = { 'A','c','c','o','u','n','t',' ','O','p','e','r','a','t','o','r','s',0 }; @@ -200,9 +201,11 @@ static const WCHAR Guests[] = { 'G','u','e','s','t','s',0 }; static const WCHAR INTERACTIVE[] = { 'I','N','T','E','R','A','C','T','I','V','E',0 }; static const WCHAR LOCAL[] = { 'L','O','C','A','L',0 }; static const WCHAR LOCAL_SERVICE[] = { 'L','O','C','A','L',' ','S','E','R','V','I','C','E',0 }; +static const WCHAR LOCAL_SERVICE2[] = { 'L','O','C','A','L','S','E','R','V','I','C','E',0 }; static const WCHAR NETWORK[] = { 'N','E','T','W','O','R','K',0 }; static const WCHAR Network_Configuration_Operators[] = { 'N','e','t','w','o','r','k',' ','C','o','n','f','i','g','u','r','a','t','i','o','n',' ','O','p','e','r','a','t','o','r','s',0 }; static const WCHAR NETWORK_SERVICE[] = { 'N','E','T','W','O','R','K',' ','S','E','R','V','I','C','E',0 }; +static const WCHAR NETWORK_SERVICE2[] = { 'N','E','T','W','O','R','K','S','E','R','V','I','C','E',0 }; static const WCHAR NT_AUTHORITY[] = { 'N','T',' ','A','U','T','H','O','R','I','T','Y',0 }; static const WCHAR NT_Pseudo_Domain[] = { 'N','T',' ','P','s','e','u','d','o',' ','D','o','m','a','i','n',0 }; static const WCHAR NTML_Authentication[] = { 'N','T','M','L',' ','A','u','t','h','e','n','t','i','c','a','t','i','o','n',0 }; @@ -252,8 +255,8 @@ static const AccountSid ACCOUNT_SIDS[] = { { WinTerminalServerSid, TERMINAL_SERVER_USER, NT_AUTHORITY, SidTypeWellKnownGroup }, { WinRemoteLogonIdSid, REMOTE_INTERACTIVE_LOGON, NT_AUTHORITY, SidTypeWellKnownGroup }, { WinLocalSystemSid, SYSTEM, NT_AUTHORITY, SidTypeWellKnownGroup }, - { WinLocalServiceSid, LOCAL_SERVICE, NT_AUTHORITY, SidTypeWellKnownGroup }, - { WinNetworkServiceSid, NETWORK_SERVICE, NT_AUTHORITY, SidTypeWellKnownGroup }, + { WinLocalServiceSid, LOCAL_SERVICE, NT_AUTHORITY, SidTypeWellKnownGroup, LOCAL_SERVICE2 }, + { WinNetworkServiceSid, NETWORK_SERVICE, NT_AUTHORITY, SidTypeWellKnownGroup , NETWORK_SERVICE2}, { WinBuiltinDomainSid, BUILTIN, BUILTIN, SidTypeDomain }, { WinBuiltinAdministratorsSid, Administrators, BUILTIN, SidTypeAlias }, { WinBuiltinUsersSid, Users, BUILTIN, SidTypeAlias }, @@ -2667,7 +2670,8 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, LPCWSTR lpAccountName, PSI for (i = 0; i < (sizeof(ACCOUNT_SIDS) / sizeof(ACCOUNT_SIDS[0])); i++) { - if (!strcmpW(lpAccountName, ACCOUNT_SIDS[i].account)) + if (!strcmpiW(lpAccountName, ACCOUNT_SIDS[i].account) || + (ACCOUNT_SIDS[i].alias && !strcmpiW(lpAccountName, ACCOUNT_SIDS[i].alias))) { DWORD sidLen = SECURITY_MAX_SID_SIZE; diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index e82167a..dd6879d 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1700,6 +1700,40 @@ static void get_sid_info(PSID psid, LPSTR *user, LPSTR *dom) LookupAccountSidA(NULL, psid, account, &size, domain, &dom_size, &use); } +static void check_wellknown_name(const char* name, const char* exp_account, int exp_size, SID_NAME_USE exp_use, BOOL exp_succ) +{ + DWORD sid_size, domain_size; + SID_NAME_USE sid_use; + LPSTR domain, account, sid_dom; + PSID psid; + BOOL ret; + + sid_size = 0; + domain_size = 0; + ret = LookupAccountNameA(NULL, name, NULL, &sid_size, NULL, &domain_size, &sid_use); + psid = HeapAlloc(GetProcessHeap(),0,sid_size); + domain = HeapAlloc(GetProcessHeap(),0,domain_size); + ret = LookupAccountNameA(NULL, name, psid, &sid_size, domain, &domain_size, &sid_use); + + get_sid_info(psid, &account, &sid_dom); + + if (!exp_succ) + { + ok(!ret, " %s Should have failed to lookup account name\n",name); + return; + } + ok(ret, "Failed to lookup account name %s\n",name); + ok(sid_size != 0, "sid_size was zero\n"); + ok(!lstrcmp(account, exp_account), "Expected %s , got %s\n", exp_account, account); + ok(!lstrcmp(domain, sid_dom), "Expected %s, got %s\n", sid_dom, domain); + ok(domain_size == exp_size, "Expected %i, got %d\n", exp_size, domain_size); + ok(lstrlen(domain) == domain_size, "Expected %d, got %d\n", lstrlen(domain), domain_size); + ok(sid_use == exp_use, "Expected (%d), got %d\n", exp_use, sid_use); + + HeapFree(GetProcessHeap(),0,psid); + HeapFree(GetProcessHeap(),0,domain); +} + static void test_LookupAccountName(void) { DWORD sid_size, domain_size, user_size; @@ -1898,6 +1932,28 @@ static void test_LookupAccountName(void) HeapFree(GetProcessHeap(), 0, domain); HeapFree(GetProcessHeap(), 0, psid); } + + /* Well Known names */ + check_wellknown_name("LocalService", "LOCAL SERVICE", 12, SidTypeWellKnownGroup, TRUE); + check_wellknown_name("Local Service", "LOCAL SERVICE", 12, SidTypeWellKnownGroup, TRUE); + /* 2 spaces */ + check_wellknown_name("Local Service", "", 0, 0, FALSE); + check_wellknown_name("NetworkService", "NETWORK SERVICE", 12, SidTypeWellKnownGroup, TRUE); + check_wellknown_name("Network Service", "NETWORK SERVICE", 12, SidTypeWellKnownGroup, TRUE); + + /* example of some names where the spaces are not optional */ + check_wellknown_name("Terminal Server User", "TERMINAL SERVER USER", 12, SidTypeWellKnownGroup, TRUE); + check_wellknown_name("TerminalServer User", "", 0, 0, FALSE); + check_wellknown_name("TerminalServerUser", "", 0, 0, FALSE); + check_wellknown_name("Terminal ServerUser", "", 0, 0, FALSE); + + check_wellknown_name("enterprise domain controllers", "ENTERPRISE DOMAIN CONTROLLERS", 12, SidTypeWellKnownGroup, TRUE); + check_wellknown_name("enterprisedomain controllers", "", 0, 0, FALSE); + check_wellknown_name("enterprise domaincontrollers", "", 0, 0, FALSE); + check_wellknown_name("enterprisedomaincontrollers", "", 0, 0, FALSE); + + /* case insensitivity */ + check_wellknown_name("lOCAlServICE", "LOCAL SERVICE", 12, SidTypeWellKnownGroup, TRUE); } static void test_security_descriptor(void)
1
0
0
0
Joerg-Cyril.Hoehle@t-systems.com : amstream: Log GUID instead of pointer.
by Alexandre Julliard
30 Mar '09
30 Mar '09
Module: wine Branch: master Commit: 110c287f2f14108e04761cb76bd8124ef06dfc46 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=110c287f2f14108e04761cb76…
Author: Joerg-Cyril.Hoehle(a)t-systems.com <Joerg-Cyril.Hoehle(a)t-systems.com> Date: Mon Mar 30 13:21:45 2009 +0200 amstream: Log GUID instead of pointer. --- dlls/amstream/amstream.c | 4 ++-- dlls/amstream/mediastream.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/amstream/amstream.c b/dlls/amstream/amstream.c index 6c544f6..a709c7b 100644 --- a/dlls/amstream/amstream.c +++ b/dlls/amstream/amstream.c @@ -129,7 +129,7 @@ static HRESULT WINAPI IAMMultiMediaStreamImpl_GetMediaStream(IAMMultiMediaStream MSPID PurposeId; unsigned int i; - TRACE("(%p/%p)->(%p,%p)\n", This, iface, idPurpose, ppMediaStream); + TRACE("(%p/%p)->(%s,%p)\n", This, iface, debugstr_guid(idPurpose), ppMediaStream); for (i = 0; i < This->nbStreams; i++) { @@ -268,7 +268,7 @@ static HRESULT WINAPI IAMMultiMediaStreamImpl_AddMediaStream(IAMMultiMediaStream IMediaStream* pStream; IMediaStream** pNewStreams; - FIXME("(%p/%p)->(%p,%p,%x,%p) partial stub!\n", This, iface, pStreamObject, PurposeId, dwFlags, ppNewStream); + FIXME("(%p/%p)->(%p,%s,%x,%p) partial stub!\n", This, iface, pStreamObject, debugstr_guid(PurposeId), dwFlags, ppNewStream); if (IsEqualGUID(PurposeId, &MSPID_PrimaryVideo)) hr = DirectDrawMediaStream_create((IMultiMediaStream*)iface, PurposeId, This->StreamType, &pStream); diff --git a/dlls/amstream/mediastream.c b/dlls/amstream/mediastream.c index 39e9a28..697b03b 100644 --- a/dlls/amstream/mediastream.c +++ b/dlls/amstream/mediastream.c @@ -58,7 +58,7 @@ HRESULT MediaStream_create(IMultiMediaStream* Parent, const MSPID* pPurposeId, S { IMediaStreamImpl* object; - TRACE("(%p,%p,%p)\n", Parent, pPurposeId, ppMediaStream); + TRACE("(%p,%s,%p)\n", Parent, debugstr_guid(pPurposeId), ppMediaStream); object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IMediaStreamImpl)); if (!object) @@ -198,7 +198,7 @@ HRESULT DirectDrawMediaStream_create(IMultiMediaStream* Parent, const MSPID* pPu { IDirectDrawMediaStreamImpl* object; - TRACE("(%p,%p,%p)\n", Parent, pPurposeId, ppMediaStream); + TRACE("(%p,%s,%p)\n", Parent, debugstr_guid(pPurposeId), ppMediaStream); object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IMediaStreamImpl)); if (!object)
1
0
0
0
← Newer
1
2
3
4
5
6
7
...
84
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Results per page:
10
25
50
100
200