wine-commits April 2009

wine-commits@winehq.org

2 participants
664 discussions

Stefan Dösinger : ddraw: Store the fvf in the ddraw buffer.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: fd9b574e4e4a42683e2a2e276c5e2d6311cbeb10 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd9b574e4e4a42683e2a2e276… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Apr 6 14:09:54 2009 +0200 ddraw: Store the fvf in the ddraw buffer. WineD3D buffer FVFs will go away soon. --- dlls/ddraw/ddraw_private.h | 1 + dlls/ddraw/device.c | 34 ++++++---------------------------- dlls/ddraw/direct3d.c | 1 + dlls/ddraw/vertexbuffer.c | 8 +++----- 4 files changed, 11 insertions(+), 33 deletions(-) diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index f9bffd8..72dfff5 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -687,6 +687,7 @@ struct IDirect3DVertexBufferImpl /*** Storage for D3D7 specific things ***/ DWORD Caps; + DWORD fvf; }; /* The Vtables */ diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index a6b42a2..37bb1ff 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -4104,7 +4104,6 @@ IDirect3DDeviceImpl_7_DrawPrimitiveVB(IDirect3DDevice7 *iface, IDirect3DVertexBufferImpl *vb = (IDirect3DVertexBufferImpl *)D3DVertexBuf; HRESULT hr; DWORD stride; - WINED3DBUFFER_DESC Desc; TRACE("(%p)->(%08x,%p,%08x,%08x,%08x)\n", This, PrimitiveType, D3DVertexBuf, StartVertex, NumVertices, Flags); @@ -4114,18 +4113,9 @@ IDirect3DDeviceImpl_7_DrawPrimitiveVB(IDirect3DDevice7 *iface, ERR("(%p) No Vertex buffer specified\n", This); return DDERR_INVALIDPARAMS; } + stride = get_flexible_vertex_size(vb->fvf); - /* Get the FVF of the vertex buffer, and its stride */ EnterCriticalSection(&ddraw_cs); - hr = IWineD3DBuffer_GetDesc(vb->wineD3DVertexBuffer, &Desc); - if(hr != D3D_OK) - { - ERR("(%p) IWineD3DVertexBuffer::GetDesc failed with hr = %08x\n", This, hr); - LeaveCriticalSection(&ddraw_cs); - return hr; - } - stride = get_flexible_vertex_size(Desc.FVF); - hr = IWineD3DDevice_SetVertexDeclaration(This->wineD3DDevice, vb->wineD3DVertexDeclaration); if(FAILED(hr)) @@ -4229,32 +4219,20 @@ IDirect3DDeviceImpl_7_DrawIndexedPrimitiveVB(IDirect3DDevice7 *iface, { IDirect3DDeviceImpl *This = (IDirect3DDeviceImpl *)iface; IDirect3DVertexBufferImpl *vb = (IDirect3DVertexBufferImpl *)D3DVertexBuf; - DWORD stride; + DWORD stride = get_flexible_vertex_size(vb->fvf); WORD *LockedIndices; HRESULT hr; - WINED3DBUFFER_DESC Desc; TRACE("(%p)->(%08x,%p,%d,%d,%p,%d,%08x)\n", This, PrimitiveType, vb, StartVertex, NumVertices, Indices, IndexCount, Flags); /* Steps: - * 1) Calculate some things: stride, ... - * 2) Upload the Indices to the index buffer - * 3) Set the index source - * 4) Set the Vertex Buffer as the Stream source - * 5) Call IWineD3DDevice::DrawIndexedPrimitive + * 1) Upload the Indices to the index buffer + * 2) Set the index source + * 3) Set the Vertex Buffer as the Stream source + * 4) Call IWineD3DDevice::DrawIndexedPrimitive */ EnterCriticalSection(&ddraw_cs); - /* Get the FVF of the vertex buffer, and its stride */ - hr = IWineD3DBuffer_GetDesc(vb->wineD3DVertexBuffer, &Desc); - if(hr != D3D_OK) - { - ERR("(%p) IWineD3DVertexBuffer::GetDesc failed with hr = %08x\n", This, hr); - LeaveCriticalSection(&ddraw_cs); - return hr; - } - stride = get_flexible_vertex_size(Desc.FVF); - TRACE("Vertex buffer FVF = %08x, stride=%d\n", Desc.FVF, stride); hr = IWineD3DDevice_SetVertexDeclaration(This->wineD3DDevice, vb->wineD3DVertexDeclaration); diff --git a/dlls/ddraw/direct3d.c b/dlls/ddraw/direct3d.c index abeb882..438b6ad 100644 --- a/dlls/ddraw/direct3d.c +++ b/dlls/ddraw/direct3d.c @@ -1017,6 +1017,7 @@ IDirect3DImpl_7_CreateVertexBuffer(IDirect3D7 *iface, object->Caps = Desc->dwCaps; object->ddraw = This; + object->fvf = Desc->dwFVF; EnterCriticalSection(&ddraw_cs); hr = IWineD3DDevice_CreateVertexBuffer(This->wineD3DDevice, diff --git a/dlls/ddraw/vertexbuffer.c b/dlls/ddraw/vertexbuffer.c index 8157334..de94791 100644 --- a/dlls/ddraw/vertexbuffer.c +++ b/dlls/ddraw/vertexbuffer.c @@ -340,7 +340,6 @@ IDirect3DVertexBufferImpl_ProcessVertices(IDirect3DVertexBuffer7 *iface, IDirect3DDeviceImpl *D3D = (IDirect3DDeviceImpl *)D3DDevice; BOOL oldClip, doClip; HRESULT hr; - WINED3DBUFFER_DESC Desc; TRACE("(%p)->(%08x,%d,%d,%p,%d,%p,%08x)\n", This, VertexOp, DestIndex, Count, Src, SrcIndex, D3D, Flags); @@ -372,12 +371,11 @@ IDirect3DVertexBufferImpl_ProcessVertices(IDirect3DVertexBuffer7 *iface, doClip); } - IWineD3DBuffer_GetDesc(Src->wineD3DVertexBuffer, &Desc); IWineD3DDevice_SetStreamSource(D3D->wineD3DDevice, 0, /* Stream No */ Src->wineD3DVertexBuffer, 0, /* Offset */ - get_flexible_vertex_size(Desc.FVF)); + get_flexible_vertex_size(Src->fvf)); IWineD3DDevice_SetVertexDeclaration(D3D->wineD3DDevice, Src->wineD3DVertexDeclaration); hr = IWineD3DDevice_ProcessVertices(D3D->wineD3DDevice, @@ -452,8 +450,8 @@ IDirect3DVertexBufferImpl_GetVertexBufferDesc(IDirect3DVertexBuffer7 *iface, /* Now fill the Desc structure */ Desc->dwCaps = This->Caps; - Desc->dwFVF = WDesc.FVF; - Desc->dwNumVertices = WDesc.Size / get_flexible_vertex_size(WDesc.FVF); + Desc->dwFVF = This->fvf; + Desc->dwNumVertices = WDesc.Size / get_flexible_vertex_size(This->fvf); LeaveCriticalSection(&ddraw_cs); return D3D_OK;

1 0

Paul Vriens : secur32/tests: Document some crashes on Windows.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: 825354afe603cf73d28009619d750724ad277a0c URL: http://source.winehq.org/git/wine.git/?a=commit;h=825354afe603cf73d28009619… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Thu Apr 9 14:44:23 2009 +0200 secur32/tests: Document some crashes on Windows. --- dlls/secur32/tests/secur32.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/dlls/secur32/tests/secur32.c b/dlls/secur32/tests/secur32.c index 6a4ae05..7e969bd 100644 --- a/dlls/secur32/tests/secur32.c +++ b/dlls/secur32/tests/secur32.c @@ -118,10 +118,20 @@ static void testGetUserNameExA(void) formats[i], GetLastError()); } + if (0) /* Crashes on Windows */ + rc = pGetUserNameExA(NameSamCompatible, NULL, NULL); + size = 0; rc = pGetUserNameExA(NameSamCompatible, NULL, &size); ok(! rc && GetLastError() == ERROR_MORE_DATA, "Expected fail with ERROR_MORE_DATA, got %d with %u\n", rc, GetLastError()); ok(size != 0, "Expected size to be set to required size\n"); + + if (0) /* Crashes on Windows with big enough size */ + { + /* Returned size is already big enough */ + rc = pGetUserNameExA(NameSamCompatible, NULL, &size); + } + size = 0; rc = pGetUserNameExA(NameSamCompatible, name, &size); ok(! rc && GetLastError() == ERROR_MORE_DATA, "Expected fail with ERROR_MORE_DATA, got %d with %u\n", rc, GetLastError()); @@ -156,10 +166,20 @@ static void testGetUserNameExW(void) formats[i], GetLastError()); } + if (0) /* Crashes on Windows */ + rc = pGetUserNameExW(NameSamCompatible, NULL, NULL); + size = 0; rc = pGetUserNameExW(NameSamCompatible, NULL, &size); ok(! rc && GetLastError() == ERROR_MORE_DATA, "Expected fail with ERROR_MORE_DATA, got %d with %u\n", rc, GetLastError()); ok(size != 0, "Expected size to be set to required size\n"); + + if (0) /* Crashes on Windows with big enough size */ + { + /* Returned size is already big enough */ + rc = pGetUserNameExW(NameSamCompatible, NULL, &size); + } + size = 0; rc = pGetUserNameExW(NameSamCompatible, nameW, &size); ok(! rc && GetLastError() == ERROR_MORE_DATA, "Expected fail with ERROR_MORE_DATA, got %d with %u\n", rc, GetLastError());

1 0

Alexandre Julliard : ntdll: Remove pthread_data from the ntdll_thread_data structure. Document the offsets for 64-bit.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: 2a2fe959afd1e6bc0d28b088dc6791afc10626cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=2a2fe959afd1e6bc0d28b088d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Apr 9 14:41:12 2009 +0200 ntdll: Remove pthread_data from the ntdll_thread_data structure. Document the offsets for 64-bit. --- dlls/ntdll/ntdll_misc.h | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h index 61622b1..b626df8 100644 --- a/dlls/ntdll/ntdll_misc.h +++ b/dlls/ntdll/ntdll_misc.h @@ -188,15 +188,14 @@ struct debug_info /* thread private data, stored in NtCurrentTeb()->SystemReserved2 */ struct ntdll_thread_data { - DWORD fs; /* 1d4 TEB selector */ - DWORD gs; /* 1d8 libc selector; update winebuild if you move this! */ - struct debug_info *debug_info; /* 1dc info for debugstr functions */ - int request_fd; /* 1e0 fd for sending server requests */ - int reply_fd; /* 1e4 fd for receiving server replies */ - int wait_fd[2]; /* 1e8 fd for sleeping server requests */ - void *vm86_ptr; /* 1f0 data for vm86 mode */ - void *pthread_data; /* 1f4 private data for pthread emulation */ - pthread_t pthread_id; /* 1f8 pthread thread id */ + DWORD fs; /* 1d4/300 TEB selector */ + DWORD gs; /* 1d8/304 libc selector; update winebuild if you move this! */ + struct debug_info *debug_info; /* 1dc/308 info for debugstr functions */ + int request_fd; /* 1e0/310 fd for sending server requests */ + int reply_fd; /* 1e4/314 fd for receiving server replies */ + int wait_fd[2]; /* 1e8/318 fd for sleeping server requests */ + void *vm86_ptr; /* 1f0/320 data for vm86 mode */ + pthread_t pthread_id; /* 1f4/328 pthread thread id */ }; static inline struct ntdll_thread_data *ntdll_get_thread_data(void)

1 0

Alexandre Julliard : include: Update and document the TEB/ PEB offsets on 64-bit.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: b9b515749b1cc55197d2f0c88bdf64ad0971318d URL: http://source.winehq.org/git/wine.git/?a=commit;h=b9b515749b1cc55197d2f0c88… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Apr 9 14:29:30 2009 +0200 include: Update and document the TEB/PEB offsets on 64-bit. --- include/winternl.h | 274 ++++++++++++++++++++++++++-------------------------- 1 files changed, 138 insertions(+), 136 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=b9b515749b1cc55197d2f…

1 0

Nicolas Le Cam : shell32/tests: Fix ITEMIDLIST format test on Win2k and below.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: fa010ad211b43be723866a36b8e2bddeb7ec9912 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa010ad211b43be723866a36b… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Thu Apr 9 01:30:31 2009 +0200 shell32/tests: Fix ITEMIDLIST format test on Win2k and below. On Win2k SHITEMID only contains FileStructA. This structure isn't padded like it is on WinXP and contains a supplementary CHAR* member at its end which contains the 8.3 filename if needed. --- dlls/shell32/tests/shlfolder.c | 46 ++++++++++++++++++++++----------------- 1 files changed, 26 insertions(+), 20 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index 5c30a7b..1d63778 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -1376,11 +1376,11 @@ static void test_ITEMIDLIST_format(void) { HANDLE hFile; HRESULT hr; BOOL bResult; - WCHAR wszFile[3][17] = { { 'e','v','e','n','_',0 }, { 'o','d','d','_',0 }, + WCHAR wszFile[3][17] = { { 'e','v','e','n','_',0 }, { 'o','d','d','_',0 }, { 'l','o','n','g','e','r','_','t','h','a','n','.','8','_','3',0 } }; int i; - - if(!pSHGetSpecialFolderPathW) return; + + if (!pSHGetSpecialFolderPathW) return; bResult = pSHGetSpecialFolderPathW(NULL, wszPersonal, CSIDL_PERSONAL, FALSE); ok(bResult, "SHGetSpecialFolderPathW failed! Last error: %u\n", GetLastError()); @@ -1417,9 +1417,9 @@ static void test_ITEMIDLIST_format(void) { CHAR szFile[MAX_PATH]; struct FileStructA *pFileStructA; WORD cbOffset; - + WideCharToMultiByte(CP_ACP, 0, wszFile[i], -1, szFile, MAX_PATH, NULL, NULL); - + hFile = CreateFileW(wszFile[i], GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_FLAG_WRITE_THROUGH, NULL); ok(hFile != INVALID_HANDLE_VALUE, "CreateFile failed! (%u)\n", GetLastError()); if (hFile == INVALID_HANDLE_VALUE) { @@ -1439,51 +1439,57 @@ static void test_ITEMIDLIST_format(void) { pFileStructA = (struct FileStructA *)pidlFile->mkid.abID; ok(pFileStructA->type == 0x32, "PIDLTYPE should be 0x32!\n"); ok(pFileStructA->dummy == 0x00, "Dummy Byte should be 0x00!\n"); - ok(pFileStructA->dwFileSize == 0, "Filesize should be zero!\n"); + ok(pFileStructA->dwFileSize == 0, "Filesize should be zero!\n"); - if (i < 2) /* First two file names are already in valid 8.3 format */ + if (i < 2) /* First two file names are already in valid 8.3 format */ ok(!strcmp(szFile, (CHAR*)&pidlFile->mkid.abID[12]), "Wrong file name!\n"); - else + else /* WinXP stores a derived 8.3 dos name (LONGER~1.8_3) here. We probably * can't implement this correctly, since unix filesystems don't support * this nasty short/long filename stuff. So we'll probably stay with our * current habbit of storing the long filename here, which seems to work * just fine. */ - todo_wine { ok(pidlFile->mkid.abID[18] == '~', "Should be derived 8.3 name!\n"); } + todo_wine + ok(pidlFile->mkid.abID[18] == '~' || + broken(pidlFile->mkid.abID[34] == '~'), /* Win2k */ + "Should be derived 8.3 name!\n"); if (i == 0) /* First file name has an even number of chars. No need for alignment. */ - ok(pidlFile->mkid.abID[12 + strlen(szFile) + 1] != '\0', - "Alignment byte, where there shouldn't be!\n"); - + ok(pidlFile->mkid.abID[12 + strlen(szFile) + 1] != '\0' || + broken(pidlFile->mkid.cb == 2 + 12 + strlen(szFile) + 1 + 1), /* Win2k */ + "Alignment byte, where there shouldn't be!\n"); + if (i == 1) /* Second file name has an uneven number of chars => alignment byte */ - ok(pidlFile->mkid.abID[12 + strlen(szFile) + 1] == '\0', + ok(pidlFile->mkid.abID[12 + strlen(szFile) + 1] == '\0', "There should be an alignment byte, but isn't!\n"); /* The offset of the FileStructW member is stored as a WORD at the end of the pidl. */ cbOffset = *(WORD*)(((LPBYTE)pidlFile)+pidlFile->mkid.cb-sizeof(WORD)); - ok (cbOffset >= sizeof(struct FileStructA) && - cbOffset <= pidlFile->mkid.cb - sizeof(struct FileStructW), + ok ((cbOffset >= sizeof(struct FileStructA) && + cbOffset <= pidlFile->mkid.cb - sizeof(struct FileStructW)) || + broken(pidlFile->mkid.cb == 2 + 12 + strlen(szFile) + 1 + 1) || /* Win2k on short names */ + broken(pidlFile->mkid.cb == 2 + 12 + strlen(szFile) + 1 + 12 + 1), /* Win2k on long names */ "Wrong offset value (%d) stored at the end of the PIDL\n", cbOffset); if (cbOffset >= sizeof(struct FileStructA) && - cbOffset <= pidlFile->mkid.cb - sizeof(struct FileStructW)) + cbOffset <= pidlFile->mkid.cb - sizeof(struct FileStructW)) { struct FileStructW *pFileStructW = (struct FileStructW *)(((LPBYTE)pidlFile)+cbOffset); - ok(pidlFile->mkid.cb == cbOffset + pFileStructW->cbLen, + ok(pidlFile->mkid.cb == cbOffset + pFileStructW->cbLen, "FileStructW's offset and length should add up to the PIDL's length!\n"); if (pidlFile->mkid.cb == cbOffset + pFileStructW->cbLen) { /* Since we just created the file, time of creation, - * time of last access and time of last write access just be the same. - * These tests seem to fail sometimes (on WinXP), if the test is run again shortly + * time of last access and time of last write access just be the same. + * These tests seem to fail sometimes (on WinXP), if the test is run again shortly * after the first run. I do remember something with NTFS keeping the creation time * if a file is deleted and then created again within a couple of seconds or so. * Might be the reason. */ ok (pFileStructA->uFileDate == pFileStructW->uDate && pFileStructA->uFileTime == pFileStructW->uTime, "Last write time should match creation time!\n"); - + ok (pFileStructA->uFileDate == pFileStructW->uDate2 && pFileStructA->uFileTime == pFileStructW->uTime2, "Last write time should match last access time!\n");

1 0

Nicolas Le Cam : shell32/tests: Skip FolderShortcut test on Win2k.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: fbcec1ca56e7acff180b23e81b6f1d38060ad4b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fbcec1ca56e7acff180b23e81… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Thu Apr 9 00:01:12 2009 +0200 shell32/tests: Skip FolderShortcut test on Win2k. Skip this test as it doesn't work on Win2k. CoCreateInstance is successful but IPersistPropertyBag_Load call fails. --- dlls/shell32/tests/shlfolder.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index a45a386..5c30a7b 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -1196,7 +1196,13 @@ static void test_FolderShortcut(void) { win_skip("SHGetSpecialFolderPathW and/or StrRetToBufW are not available\n"); return; } - + + if (!pSHGetFolderPathAndSubDirA) + { + win_skip("FolderShortcut test doesn't work on Win2k\n"); + return; + } + /* These tests basically show, that CLSID_FolderShortcuts are initialized * via their IPersistPropertyBag interface. And that the target folder * is taken from the IPropertyBag's 'Target' property. @@ -1216,7 +1222,7 @@ static void test_FolderShortcut(void) { IPersistPropertyBag_Release(pPersistPropertyBag); return; } - + hr = IPersistPropertyBag_QueryInterface(pPersistPropertyBag, &IID_IShellFolder, (LPVOID*)&pShellFolder); IPersistPropertyBag_Release(pPersistPropertyBag);

1 0

Nicolas Le Cam : shell32/tests: Fix PropertyBag test on Win2k.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: 1d3edf6377cf346eed758bdfe1c6a81f5dadde5e URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d3edf6377cf346eed758bdfe… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Tue Apr 7 19:16:46 2009 +0200 shell32/tests: Fix PropertyBag test on Win2k. --- dlls/shell32/tests/shlfolder.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index cbbad01..a45a386 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -1106,7 +1106,9 @@ static HRESULT WINAPI InitPropertyBag_IPropertyBag_Read(IPropertyBag *iface, LPC 'R','e','s','o','l','v','e','L','i','n','k','F','l','a','g','s',0 }; if (!lstrcmpW(pszPropName, wszTargetSpecialFolder)) { - ok(V_VT(pVar) == VT_I4, "Wrong variant type for 'TargetSpecialFolder' property!\n"); + ok(V_VT(pVar) == VT_I4 || + broken(V_VT(pVar) == VT_BSTR), /* Win2k */ + "Wrong variant type for 'TargetSpecialFolder' property!\n"); return E_INVALIDARG; } @@ -1120,7 +1122,9 @@ static HRESULT WINAPI InitPropertyBag_IPropertyBag_Read(IPropertyBag *iface, LPC WCHAR wszPath[MAX_PATH]; BOOL result; - ok(V_VT(pVar) == VT_BSTR, "Wrong variant type for 'Target' property!\n"); + ok(V_VT(pVar) == VT_BSTR || + broken(V_VT(pVar) == VT_EMPTY), /* Win2k */ + "Wrong variant type for 'Target' property!\n"); if (V_VT(pVar) != VT_BSTR) return E_INVALIDARG; result = pSHGetSpecialFolderPathW(NULL, wszPath, CSIDL_DESKTOPDIRECTORY, FALSE);

1 0

Nicolas Le Cam : shell32/tests: Skip interactive part of SetNameOf test on Win2k.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: eb57396fc62b1c4fc56c187273c534ca82abc1f3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=eb57396fc62b1c4fc56c18727… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Tue Apr 7 19:15:35 2009 +0200 shell32/tests: Skip interactive part of SetNameOf test on Win2k. Passing an absolute path to SetNameOf on Win2k display an error message box about invalid characters in filename, forcing interaction during test. --- dlls/shell32/tests/shlfolder.c | 63 +++++++++++++++++++++------------------ 1 files changed, 34 insertions(+), 29 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index 08ea9cc..cbbad01 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -473,7 +473,7 @@ static void test_GetDisplayName(void) IShellFolder_Release(psfFile); } - if(!pSHBindToParent) + if (!pSHBindToParent) { win_skip("SHBindToParent is missing\n"); DeleteFileA(szTestFile); @@ -482,37 +482,42 @@ static void test_GetDisplayName(void) } /* Some tests for IShellFolder::SetNameOf */ - hr = pSHBindToParent(pidlTestFile, &IID_IShellFolder, (VOID**)&psfPersonal, &pidlLast); - ok(SUCCEEDED(hr), "SHBindToParent failed! hr = %08x\n", hr); - if (SUCCEEDED(hr)) { - /* It's ok to use this fixed path. Call will fail anyway. */ - WCHAR wszAbsoluteFilename[] = { 'C',':','\\','w','i','n','e','t','e','s','t', 0 }; - LPITEMIDLIST pidlNew; - - /* The pidl returned through the last parameter of SetNameOf is a simple one. */ - hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlLast, wszDirName, SHGDN_NORMAL, &pidlNew); - ok (SUCCEEDED(hr), "SetNameOf failed! hr = %08x\n", hr); - if(hr == S_OK) - { - ok (((LPITEMIDLIST)((LPBYTE)pidlNew+pidlNew->mkid.cb))->mkid.cb == 0, - "pidl returned from SetNameOf should be simple!\n"); - - /* Passing an absolute path to SetNameOf fails. The HRESULT code indicates that SetNameOf - * is implemented on top of SHFileOperation in WinXP. */ - hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlNew, wszAbsoluteFilename, - SHGDN_FORPARSING, NULL); - ok (hr == HRESULT_FROM_WIN32(ERROR_CANCELLED), "SetNameOf succeeded! hr = %08x\n", hr); - - /* Rename the file back to its original name. SetNameOf ignores the fact, that the - * SHGDN flags specify an absolute path. */ - hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlNew, wszFileName, SHGDN_FORPARSING, NULL); + if (pSHGetFolderPathAndSubDirA) + { + hr = pSHBindToParent(pidlTestFile, &IID_IShellFolder, (VOID**)&psfPersonal, &pidlLast); + ok(SUCCEEDED(hr), "SHBindToParent failed! hr = %08x\n", hr); + if (SUCCEEDED(hr)) { + /* It's ok to use this fixed path. Call will fail anyway. */ + WCHAR wszAbsoluteFilename[] = { 'C',':','\\','w','i','n','e','t','e','s','t', 0 }; + LPITEMIDLIST pidlNew; + + /* The pidl returned through the last parameter of SetNameOf is a simple one. */ + hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlLast, wszDirName, SHGDN_NORMAL, &pidlNew); ok (SUCCEEDED(hr), "SetNameOf failed! hr = %08x\n", hr); + if (hr == S_OK) + { + ok (((LPITEMIDLIST)((LPBYTE)pidlNew+pidlNew->mkid.cb))->mkid.cb == 0, + "pidl returned from SetNameOf should be simple!\n"); + + /* Passing an absolute path to SetNameOf fails. The HRESULT code indicates that SetNameOf + * is implemented on top of SHFileOperation in WinXP. */ + hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlNew, wszAbsoluteFilename, + SHGDN_FORPARSING, NULL); + ok (hr == HRESULT_FROM_WIN32(ERROR_CANCELLED), "SetNameOf succeeded! hr = %08x\n", hr); + + /* Rename the file back to its original name. SetNameOf ignores the fact, that the + * SHGDN flags specify an absolute path. */ + hr = IShellFolder_SetNameOf(psfPersonal, NULL, pidlNew, wszFileName, SHGDN_FORPARSING, NULL); + ok (SUCCEEDED(hr), "SetNameOf failed! hr = %08x\n", hr); + + pILFree(pidlNew); + } - pILFree(pidlNew); + IShellFolder_Release(psfPersonal); } - - IShellFolder_Release(psfPersonal); } + else + win_skip("Avoid needs of interaction on Win2k\n"); /* Deleting the file and the directory */ DeleteFileA(szTestFile);

1 0

Nicolas Le Cam : shell32/tests: Completly fix GetAttributesOf test when launched from drive root dir.
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: 1f52f12f3c125f7c07f531c6064760516cc24e5d URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f52f12f3c125f7c07f531c60… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Tue Apr 7 19:14:07 2009 +0200 shell32/tests: Completly fix GetAttributesOf test when launched from drive root dir. --- dlls/shell32/tests/shlfolder.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index 5492b84..08ea9cc 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -848,6 +848,8 @@ static void test_GetAttributesOf(void) IMalloc_Free(ppM, newPIDL); /* append testdirectory name to path */ + if (cCurrDirA[len-1] == '\\') + cCurrDirA[len-1] = 0; lstrcatA(cCurrDirA, "\\testdir"); MultiByteToWideChar(CP_ACP, 0, cCurrDirA, -1, cCurrDirW, MAX_PATH);

1 0

Henri Verbeet : wined3d: Get rid of a redundant strcat in shader_glsl_get_register_name().
by Alexandre Julliard 09 Apr '09

09 Apr '09

Module: wine Branch: master Commit: 3a0eb81cea5301103da362e2594ca828fc8bc6a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a0eb81cea5301103da362e25… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 9 09:58:29 2009 +0200 wined3d: Get rid of a redundant strcat in shader_glsl_get_register_name(). --- dlls/wined3d/glsl_shader.c | 85 +++++++++++++++++++++----------------------- 1 files changed, 41 insertions(+), 44 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3a0eb81cea5301103da36…

1 0

← Newer
1
...
46
47
48
49
50
51
52
...
67
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2009