wine-commits April 2009

wine-commits@winehq.org

2 participants
664 discussions

Vincent Povirk : gdiplus: Create a static InstalledFontCollection object, currently empty.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 73eea0d05ffbe810092840f70c7fbce55f2bc8b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=73eea0d05ffbe810092840f70… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Mon Apr 27 16:24:47 2009 -0500 gdiplus: Create a static InstalledFontCollection object, currently empty. --- dlls/gdiplus/font.c | 6 +++++- dlls/gdiplus/tests/font.c | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c index 6454765..68540e4 100644 --- a/dlls/gdiplus/font.c +++ b/dlls/gdiplus/font.c @@ -36,6 +36,8 @@ WINE_DEFAULT_DEBUG_CHANNEL (gdiplus); static const REAL mm_per_inch = 25.4; static const REAL inch_per_point = 1.0/72.0; +static GpFontCollection installedFontCollection = {0}; + static inline REAL get_dpi (void) { REAL dpi; @@ -936,5 +938,7 @@ GpStatus WINGDIPAPI GdipNewInstalledFontCollection( if (!fontCollection) return InvalidParameter; - return NotImplemented; + *fontCollection = &installedFontCollection; + + return Ok; } diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 6fbb8e2..0da5b2f 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -349,8 +349,8 @@ static void test_installedfonts (void) expect (InvalidParameter, stat); stat = GdipNewInstalledFontCollection(&collection); - todo_wine expect (Ok, stat); - todo_wine ok (collection != NULL, "got NULL font collection\n"); + expect (Ok, stat); + ok (collection != NULL, "got NULL font collection\n"); } START_TEST(font)

1 0

Vincent Povirk : gdiplus: Add test for GdipNewInstalledFontCollection.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 31f2b8e1eab801d27815a68808e5124d9c06a344 URL: http://source.winehq.org/git/wine.git/?a=commit;h=31f2b8e1eab801d27815a6880… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Jan 28 16:08:43 2009 -0600 gdiplus: Add test for GdipNewInstalledFontCollection. --- dlls/gdiplus/tests/font.c | 14 ++++++++++++++ include/gdiplusflat.h | 1 + 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 7d6582f..6fbb8e2 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -340,6 +340,19 @@ monospace: expect (Ok, stat); } +static void test_installedfonts (void) +{ + GpStatus stat; + GpFontCollection* collection=NULL; + + stat = GdipNewInstalledFontCollection(NULL); + expect (InvalidParameter, stat); + + stat = GdipNewInstalledFontCollection(&collection); + todo_wine expect (Ok, stat); + todo_wine ok (collection != NULL, "got NULL font collection\n"); +} + START_TEST(font) { struct GdiplusStartupInput gdiplusStartupInput; @@ -357,6 +370,7 @@ START_TEST(font) test_fontfamily(); test_fontfamily_properties(); test_getgenerics(); + test_installedfonts(); GdiplusShutdown(gdiplusToken); } diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h index 158eb5e..f8ebc73 100644 --- a/include/gdiplusflat.h +++ b/include/gdiplusflat.h @@ -93,6 +93,7 @@ GpStatus WINGDIPAPI GdipGetFontHeight(GDIPCONST GpFont*, GDIPCONST GpGraphics*, GpStatus WINGDIPAPI GdipGetFontHeightGivenDPI(GDIPCONST GpFont*, REAL, REAL*); /* FontCollection */ +GpStatus WINGDIPAPI GdipNewInstalledFontCollection(GpFontCollection**); GpStatus WINGDIPAPI GdipNewPrivateFontCollection(GpFontCollection**); GpStatus WINGDIPAPI GdipDeletePrivateFontCollection(GpFontCollection**); GpStatus WINGDIPAPI GdipPrivateAddFontFile(GpFontCollection*, GDIPCONST WCHAR*);

1 0

Massimo Del Fedele : gdiplus: Add stub for GdipBitmapSetPixel.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: a3221e7f2371b5671ba315bea90ebed84f6c2806 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a3221e7f2371b5671ba315bea… Author: Massimo Del Fedele <max(a)veneto.com> Date: Mon Apr 27 23:20:27 2009 +0200 gdiplus: Add stub for GdipBitmapSetPixel. --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/image.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index ba98518..2d5bc78 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -42,7 +42,7 @@ @ stub GdipBitmapGetHistogramSize @ stdcall GdipBitmapGetPixel(ptr long long ptr) @ stdcall GdipBitmapLockBits(ptr ptr long long ptr) -@ stub GdipBitmapSetPixel +@ stdcall GdipBitmapSetPixel(ptr long long long) @ stdcall GdipBitmapSetResolution(ptr long long) @ stdcall GdipBitmapUnlockBits(ptr ptr) @ stdcall GdipClearPathMarkers(ptr) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 5552225..fde6ab3 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -87,6 +87,21 @@ GpStatus WINGDIPAPI GdipBitmapGetPixel(GpBitmap* bitmap, INT x, INT y, return NotImplemented; } +GpStatus WINGDIPAPI GdipBitmapSetPixel(GpBitmap* bitmap, INT x, INT y, + ARGB color) +{ + static int calls; + TRACE("bitmap:%p, x:%d, y:%d, color:%08x\n", bitmap, x, y, color); + + if(!bitmap) + return InvalidParameter; + + if(!(calls++)) + FIXME("not implemented\n"); + + return NotImplemented; +} + /* This function returns a pointer to an array of pixels that represents the * bitmap. The *entire* bitmap is locked according to the lock mode specified by * flags. It is correct behavior that a user who calls this function with write

1 0

Eric Pouech : kernel32: In editline's keys table, use constants instead of numeric constants.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 88bdc0c1107323046415865e5f72206bef9cac30 URL: http://source.winehq.org/git/wine.git/?a=commit;h=88bdc0c1107323046415865e5… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Mon Apr 27 21:09:06 2009 +0200 kernel32: In editline's keys table, use constants instead of numeric constants. --- dlls/kernel32/editline.c | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/kernel32/editline.c b/dlls/kernel32/editline.c index 6fab049..bcbf927 100644 --- a/dlls/kernel32/editline.c +++ b/dlls/kernel32/editline.c @@ -727,13 +727,13 @@ static const KeyEntry EmacsKeyMapExtended[] = static const KeyMap EmacsKeyMap[] = { - {0x00000000, 1, StdKeyMap}, - {0x00000001, 1, EmacsKeyMapAlt}, /* left alt */ - {0x00000002, 1, EmacsKeyMapAlt}, /* right alt */ - {0x00000004, 1, EmacsKeyMapCtrl}, /* left ctrl */ - {0x00000008, 1, EmacsKeyMapCtrl}, /* right ctrl */ - {0x00000100, 0, EmacsKeyMapExtended}, - {0, 0, 0} + {0, 1, StdKeyMap}, + {RIGHT_ALT_PRESSED, 1, EmacsKeyMapAlt}, /* right alt */ + {LEFT_ALT_PRESSED, 1, EmacsKeyMapAlt}, /* left alt */ + {RIGHT_CTRL_PRESSED, 1, EmacsKeyMapCtrl}, /* right ctrl */ + {LEFT_CTRL_PRESSED, 1, EmacsKeyMapCtrl}, /* left ctrl */ + {ENHANCED_KEY, 0, EmacsKeyMapExtended}, + {0, 0, NULL} }; static const KeyEntry Win32KeyMapExtended[] = @@ -758,12 +758,12 @@ static const KeyEntry Win32KeyMapCtrlExtended[] = static const KeyMap Win32KeyMap[] = { - {0x00000000, 1, StdKeyMap}, - {0x00000000, 0, Win32ExtraStdKeyMap}, - {0x00000100, 0, Win32KeyMapExtended}, - {0x00000104, 0, Win32KeyMapCtrlExtended}, - {0x00000108, 0, Win32KeyMapCtrlExtended}, - {0, 0, 0} + {0, 1, StdKeyMap}, + {0, 0, Win32ExtraStdKeyMap}, + {ENHANCED_KEY, 0, Win32KeyMapExtended}, + {ENHANCED_KEY | RIGHT_CTRL_PRESSED, 0, Win32KeyMapCtrlExtended}, + {ENHANCED_KEY | LEFT_CTRL_PRESSED, 0, Win32KeyMapCtrlExtended}, + {0, 0, NULL} }; #undef CTRL

1 0

André Hentschel : cmdlgtst: Spelling fix.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 078d465fa9c01d96b6b700ca9178f0d68055e4fe URL: http://source.winehq.org/git/wine.git/?a=commit;h=078d465fa9c01d96b6b700ca9… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Apr 27 20:34:16 2009 +0200 cmdlgtst: Spelling fix. --- programs/cmdlgtst/De.rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/cmdlgtst/De.rc b/programs/cmdlgtst/De.rc index 323b6f8..f8e7d0e 100644 --- a/programs/cmdlgtst/De.rc +++ b/programs/cmdlgtst/De.rc @@ -145,7 +145,7 @@ FONT 8, "MS Shell Dlg" CONTROL "", -1, "static", SS_BLACKRECT | WS_CHILD | WS_VISIBLE, 12, 168, 11, 13 CONTROL "", -1, "static", SS_BLACKRECT | WS_CHILD | WS_VISIBLE, 12, 180, 11, 13 CONTROL "", -1, "static", SS_BLACKRECT | WS_CHILD | WS_VISIBLE, 24, 228, 11, 13 - CONTROL "Markierte Flags sind durch das System gesetzt wurden und m�ssen von dem Benutzer entfernt werden", -1, "static", SS_LEFT | WS_CHILD | WS_VISIBLE, 48, 228, 98, 36 + CONTROL "Markierte Flags sind durch das System gesetzt worden und m�ssen von dem Benutzer entfernt werden", -1, "static", SS_LEFT | WS_CHILD | WS_VISIBLE, 48, 228, 98, 36 } Print_Flags_Dialog DIALOG 4, 17, 239, 287

1 0

Paul Vriens : urlmon/tests: Fix a test failure on Win9x, WinME and NT4.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 6ba4b314f36705d6ea73f59ff4d80ad254be53ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=6ba4b314f36705d6ea73f59ff… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Mon Apr 27 20:33:12 2009 +0200 urlmon/tests: Fix a test failure on Win9x, WinME and NT4. --- dlls/urlmon/tests/protocol.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/urlmon/tests/protocol.c b/dlls/urlmon/tests/protocol.c index ea19c77..e136d4b 100644 --- a/dlls/urlmon/tests/protocol.c +++ b/dlls/urlmon/tests/protocol.c @@ -671,7 +671,9 @@ static HRESULT WINAPI ProtocolSink_ReportResult(IInternetProtocolSink *iface, HR if(SUCCEEDED(hrResult) || tested_protocol == FTP_TEST) ok(dwError == ERROR_SUCCESS, "dwError = %d, expected ERROR_SUCCESS\n", dwError); else - ok(dwError != ERROR_SUCCESS, "dwError == ERROR_SUCCESS\n"); + ok(dwError != ERROR_SUCCESS || + broken(tested_protocol == MK_TEST), /* Win9x, WinME and NT4 */ + "dwError == ERROR_SUCCESS\n"); ok(!szResult, "szResult != NULL\n"); return S_OK;

1 0

Paul Vriens : gdi32/tests: Fix a test failure on NT4.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: f043f3db27089f2da5f676abe016fbdeeebdd20a URL: http://source.winehq.org/git/wine.git/?a=commit;h=f043f3db27089f2da5f676abe… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Mon Apr 27 19:48:17 2009 +0200 gdi32/tests: Fix a test failure on NT4. --- dlls/gdi32/tests/font.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index c10d6e8..88e1797 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -1785,7 +1785,9 @@ static void test_EnumFontFamilies(const char *font_name, INT font_charset) ok(efdw.total > 0, "fonts enumerated: NULL\n"); ok(ansi_charset > 0, "NULL family should enumerate ANSI_CHARSET\n"); ok(symbol_charset > 0, "NULL family should enumerate SYMBOL_CHARSET\n"); - ok(russian_charset > 0, "NULL family should enumerate RUSSIAN_CHARSET\n"); + ok(russian_charset > 0 || + broken(russian_charset == 0), /* NT4 */ + "NULL family should enumerate RUSSIAN_CHARSET\n"); } efdw.total = 0;

1 0

Paul Vriens : ws2_32/tests: Run tests again on several platforms due to missing functions.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: ffd855d21422325cea240a66d6e35da4d98558a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ffd855d21422325cea240a66d… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Mon Apr 27 16:47:49 2009 +0200 ws2_32/tests: Run tests again on several platforms due to missing functions. --- dlls/ws2_32/tests/sock.c | 31 ++++++++++++++++++++----------- 1 files changed, 20 insertions(+), 11 deletions(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 8316982..e7c9868 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -56,7 +56,8 @@ } while (0); /* Function pointers */ -static HMODULE hws2_32 = 0; +static void (WINAPI *pFreeAddrInfoW)(PADDRINFOW) = 0; +static int (WINAPI *pGetAddrInfoW)(LPCWSTR,LPCWSTR,const ADDRINFOW *,PADDRINFOW *) = 0; static PCSTR (WINAPI *pInetNtop)(INT,LPVOID,LPSTR,ULONG) = 0; /**************** Structs and typedefs ***************/ @@ -841,6 +842,11 @@ static void Init (void) { WORD ver = MAKEWORD (2, 2); WSADATA data; + HMODULE hws2_32 = GetModuleHandle("ws2_32.dll"); + + pFreeAddrInfoW = (void *)GetProcAddress(hws2_32, "FreeAddrInfoW"); + pGetAddrInfoW = (void *)GetProcAddress(hws2_32, "GetAddrInfoW"); + pInetNtop = (void *)GetProcAddress(hws2_32, "inet_ntop"); ok ( WSAStartup ( ver, &data ) == 0, "WSAStartup failed\n" ); tls = TlsAlloc(); @@ -2016,9 +2022,6 @@ static void test_addr_to_print(void) u_char addr3_Num[16] = {0x20,0x30,0xa4,0xb1}; PCSTR addr3_Str = "2030:a4b1::"; - hws2_32 = GetModuleHandle("ws2_32.dll"); - pInetNtop = (void *)GetProcAddress(hws2_32, "inet_ntop"); - in.s_addr = addr0_Num; pdst = inet_ntoa(*((struct in_addr*)&in.s_addr)); @@ -2382,22 +2385,28 @@ static void test_GetAddrInfoW(void) int ret; ADDRINFOW *result, hint; + if (!pGetAddrInfoW || !pFreeAddrInfoW) + { + win_skip("GetAddrInfoW and/or FreeAddrInfoW not present\n"); + return; + } + memset(&hint, 0, sizeof(ADDRINFOW)); - ret = GetAddrInfoW(NULL, NULL, NULL, &result); + ret = pGetAddrInfoW(NULL, NULL, NULL, &result); ok(ret == WSAHOST_NOT_FOUND, "got %d expected WSAHOST_NOT_FOUND\n", ret); - ret = GetAddrInfoW(localhost, NULL, NULL, &result); + ret = pGetAddrInfoW(localhost, NULL, NULL, &result); ok(!ret, "GetAddrInfoW failed with %d\n", WSAGetLastError()); - FreeAddrInfoW(result); + pFreeAddrInfoW(result); - ret = GetAddrInfoW(localhost, port, NULL, &result); + ret = pGetAddrInfoW(localhost, port, NULL, &result); ok(!ret, "GetAddrInfoW failed with %d\n", WSAGetLastError()); - FreeAddrInfoW(result); + pFreeAddrInfoW(result); - ret = GetAddrInfoW(localhost, port, &hint, &result); + ret = pGetAddrInfoW(localhost, port, &hint, &result); ok(!ret, "GetAddrInfoW failed with %d\n", WSAGetLastError()); - FreeAddrInfoW(result); + pFreeAddrInfoW(result); } /**************** Main program ***************/

1 0

Paul Vriens : gdi32/tests: Fix some test failures on Win9x/WinME.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 75f6b1d6363207dc7848121f235b797a38caaea8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=75f6b1d6363207dc7848121f2… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Mon Apr 27 14:35:51 2009 +0200 gdi32/tests: Fix some test failures on Win9x/WinME. --- dlls/gdi32/tests/bitmap.c | 35 +++++++++++++++++++++++++++-------- 1 files changed, 27 insertions(+), 8 deletions(-) diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c index 75f3310..bfbeee0 100644 --- a/dlls/gdi32/tests/bitmap.c +++ b/dlls/gdi32/tests/bitmap.c @@ -1441,6 +1441,13 @@ static void test_GetDIBits(void) 0,0,0,0, 0xff,0xff,0,0, 0,0,0,0, 0xff,0xff,0,0, 0,0,0,0, 0xff,0xff,0,0, 0,0,0,0, 0xff,0xff,0,0 }; + static const BYTE dib_bits_1_9x[16 * 4] = + { + 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, + 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, + 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, + 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa, 0,0,0xaa,0xaa, 0xff,0xff,0xaa,0xaa + }; /* 2-bytes aligned 24-bit bitmap data: 16x16 */ static const BYTE bmp_bits_24[16 * 16*3] = { @@ -1592,15 +1599,21 @@ static void test_GetDIBits(void) } /* returned bits are DWORD aligned and upside down */ - ok(!memcmp(buf, dib_bits_1, sizeof(dib_bits_1)), "DIB bits don't match\n"); + ok(!memcmp(buf, dib_bits_1, sizeof(dib_bits_1)) || + broken(!memcmp(buf, dib_bits_1_9x, sizeof(dib_bits_1_9x))), /* Win9x, WinME */ + "DIB bits don't match\n"); /* Test the palette indices */ memset(bi->bmiColors, 0xAA, sizeof(RGBQUAD) * 256); SetLastError(0xdeadbeef); lines = GetDIBits(hdc, hbmp, 0, 0, NULL, bi, DIB_PAL_COLORS); - - ok(((WORD*)bi->bmiColors)[0] == 0, "Color 0 is %d\n", ((WORD*)bi->bmiColors)[0]); - ok(((WORD*)bi->bmiColors)[1] == 1, "Color 1 is %d\n", ((WORD*)bi->bmiColors)[1]); + if (lines == 0 && GetLastError() == ERROR_INVALID_PARAMETER) + win_skip("Win9x/WinMe doesn't handle 0 for the number of scan lines\n"); + else + { + ok(((WORD*)bi->bmiColors)[0] == 0, "Color 0 is %d\n", ((WORD*)bi->bmiColors)[0]); + ok(((WORD*)bi->bmiColors)[1] == 1, "Color 1 is %d\n", ((WORD*)bi->bmiColors)[1]); + } for (i = 2; i < 256; i++) ok(((WORD*)bi->bmiColors)[i] == 0xAAAA, "Color %d is %d\n", i, ((WORD*)bi->bmiColors)[1]); @@ -1708,15 +1721,21 @@ static void test_GetDIBits(void) /* returned bits are DWORD aligned and upside down */ todo_wine - ok(!memcmp(buf, dib_bits_1, sizeof(dib_bits_1)), "DIB bits don't match\n"); + ok(!memcmp(buf, dib_bits_1, sizeof(dib_bits_1)) || + broken(!memcmp(buf, dib_bits_1_9x, sizeof(dib_bits_1_9x))), /* Win9x, WinME */ + "DIB bits don't match\n"); /* Test the palette indices */ memset(bi->bmiColors, 0xAA, sizeof(RGBQUAD) * 256); SetLastError(0xdeadbeef); lines = GetDIBits(hdc, hbmp, 0, 0, NULL, bi, DIB_PAL_COLORS); - - ok(((WORD*)bi->bmiColors)[0] == 0, "Color 0 is %d\n", ((WORD*)bi->bmiColors)[0]); - ok(((WORD*)bi->bmiColors)[1] == 1, "Color 1 is %d\n", ((WORD*)bi->bmiColors)[1]); + if (lines == 0 && GetLastError() == ERROR_INVALID_PARAMETER) + win_skip("Win9x/WinMe doesn't handle 0 for the number of scan lines\n"); + else + { + ok(((WORD*)bi->bmiColors)[0] == 0, "Color 0 is %d\n", ((WORD*)bi->bmiColors)[0]); + ok(((WORD*)bi->bmiColors)[1] == 1, "Color 1 is %d\n", ((WORD*)bi->bmiColors)[1]); + } for (i = 2; i < 256; i++) ok(((WORD*)bi->bmiColors)[i] == 0xAAAA, "Color %d is %d\n", i, ((WORD*)bi->bmiColors)[i]);

1 0

Alexandre Julliard : wininet: Fix a memory leak in the URL cache.
by Alexandre Julliard 28 Apr '09

28 Apr '09

Module: wine Branch: master Commit: 7e11ecdd8d2db70526f284c43bf7a7f1ebd14a9e URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e11ecdd8d2db70526f284c43… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 27 20:04:45 2009 +0200 wininet: Fix a memory leak in the URL cache. --- dlls/wininet/urlcache.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index b4feba3..5e1541d 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -692,6 +692,7 @@ static LPURLCACHE_HEADER URLCacheContainer_LockIndex(URLCACHECONTAINER * pContai * of the memory mapped file */ if (pHeader->dwFileSize != pContainer->file_size) { + UnmapViewOfFile( pHeader ); URLCacheContainer_CloseIndex(pContainer); error = URLCacheContainer_OpenIndex(pContainer); if (error != ERROR_SUCCESS)

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
67
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2009