wine-commits June 2009

wine-commits@winehq.org

5 participants
1115 discussions

Joris Huizer : winemenubuilder: reg_get_val[AW]: Fix memory leak.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 12c237056ed7705c4df356051adfaa20f30d1e78 URL: http://source.winehq.org/git/wine.git/?a=commit;h=12c237056ed7705c4df356051… Author: Joris Huizer <joris_huizer(a)yahoo.com> Date: Sat Jun 6 21:24:20 2009 +0200 winemenubuilder: reg_get_val[AW]: Fix memory leak. --- programs/winemenubuilder/winemenubuilder.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index eeded0e..145817e 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -1525,6 +1525,7 @@ static CHAR* reg_get_valA(HKEY key, LPCSTR subkey, LPCSTR name) if (RegGetValueA(key, subkey, name, RRF_RT_REG_SZ, NULL, ret, &size) == ERROR_SUCCESS) return ret; } + HeapFree(GetProcessHeap(), 0, ret); } return NULL; } @@ -1540,6 +1541,7 @@ static WCHAR* reg_get_valW(HKEY key, LPCWSTR subkey, LPCWSTR name) if (RegGetValueW(key, subkey, name, RRF_RT_REG_SZ, NULL, ret, &size) == ERROR_SUCCESS) return ret; } + HeapFree(GetProcessHeap(), 0, ret); } return NULL; }

1 0

Andrew Eikum : gdiplus: Test cases and parameter checks for GdipDrawCurve.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 119e9af74a47a7e0a7565f1d379c6fb1fb7649bf URL: http://source.winehq.org/git/wine.git/?a=commit;h=119e9af74a47a7e0a7565f1d3… Author: Andrew Eikum <andrew(a)brightnightgames.com> Date: Sat Jun 6 12:02:29 2009 -0500 gdiplus: Test cases and parameter checks for GdipDrawCurve. --- dlls/gdiplus/graphics.c | 6 ++++ dlls/gdiplus/tests/graphics.c | 62 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 2698159..c7fa0be 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -1459,7 +1459,13 @@ GpStatus WINGDIPAPI GdipDrawCurve2(GpGraphics *graphics, GpPen *pen, if(graphics->busy) return ObjectBusy; + if(count < 2) + return InvalidParameter; + pt = GdipAlloc(len_pt * sizeof(GpPointF)); + if(!pt) + return OutOfMemory; + tension = tension * TENSION_CONST; calc_curve_bezier_endp(points[0].X, points[0].Y, points[1].X, points[1].Y, diff --git a/dlls/gdiplus/tests/graphics.c b/dlls/gdiplus/tests/graphics.c index 61143c6..668d261 100644 --- a/dlls/gdiplus/tests/graphics.c +++ b/dlls/gdiplus/tests/graphics.c @@ -367,6 +367,67 @@ static void test_GdipDrawBezierI(void) ReleaseDC(0, hdc); } +static void test_GdipDrawCurve(void) +{ + GpStatus status; + GpGraphics *graphics = NULL; + GpPen *pen = NULL; + HDC hdc = GetDC(0); + GpPointF points[3]; + + points[0].X = 0; + points[0].Y = 0; + + points[1].X = 40; + points[1].Y = 20; + + points[2].X = 10; + points[2].Y = 40; + + /* make a graphics object and pen object */ + ok(hdc != NULL, "Expected HDC to be initialized\n"); + + status = GdipCreateFromHDC(hdc, &graphics); + expect(Ok, status); + ok(graphics != NULL, "Expected graphics to be initialized\n"); + + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, &pen); + expect(Ok, status); + ok(pen != NULL, "Expected pen to be initialized\n"); + + /* InvalidParameter cases: null graphics, null pen */ + status = GdipDrawCurve(NULL, NULL, points, 3); + expect(InvalidParameter, status); + + status = GdipDrawCurve(graphics, NULL, points, 3); + expect(InvalidParameter, status); + + status = GdipDrawCurve(NULL, pen, points, 3); + expect(InvalidParameter, status); + + /* InvalidParameter cases: invalid count */ + status = GdipDrawCurve(graphics, pen, points, -1); + expect(InvalidParameter, status); + + status = GdipDrawCurve(graphics, pen, points, 0); + expect(InvalidParameter, status); + + status = GdipDrawCurve(graphics, pen, points, 1); + expect(InvalidParameter, status); + + /* Valid test cases */ + status = GdipDrawCurve(graphics, pen, points, 2); + expect(Ok, status); + + status = GdipDrawCurve(graphics, pen, points, 3); + expect(Ok, status); + + GdipDeletePen(pen); + GdipDeleteGraphics(graphics); + + ReleaseDC(0, hdc); +} + static void test_GdipDrawLineI(void) { GpStatus status; @@ -1095,6 +1156,7 @@ START_TEST(graphics) test_GdipDrawBezierI(); test_GdipDrawArc(); test_GdipDrawArcI(); + test_GdipDrawCurve(); test_GdipDrawLineI(); test_GdipDrawLinesI(); test_GdipDrawString();

1 0

Andrew Talbot : comctl32: Constify some variables.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: f5d8fa66134ee71cb598bd40adc9df3d9044978f URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5d8fa66134ee71cb598bd40a… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Jun 6 17:20:48 2009 +0100 comctl32: Constify some variables. --- dlls/comctl32/listview.c | 2 +- dlls/comctl32/rebar.c | 2 +- dlls/comctl32/status.c | 2 +- dlls/comctl32/tab.c | 4 ++-- dlls/comctl32/toolbar.c | 8 ++++---- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index dafb914..8d4f6f3 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -9942,7 +9942,7 @@ static LRESULT LISTVIEW_ShowWindow(LISTVIEW_INFO *infoPtr, BOOL bShown, INT iSta * RETURN: * Current version */ -static inline LRESULT LISTVIEW_GetVersion(LISTVIEW_INFO *infoPtr) +static inline LRESULT LISTVIEW_GetVersion(const LISTVIEW_INFO *infoPtr) { return infoPtr->iVersion; } diff --git a/dlls/comctl32/rebar.c b/dlls/comctl32/rebar.c index 982c844..8e18e22 100644 --- a/dlls/comctl32/rebar.c +++ b/dlls/comctl32/rebar.c @@ -452,7 +452,7 @@ static int get_rect_cy(const REBAR_INFO *infoPtr, const RECT *lpRect) return lpRect->bottom - lpRect->top; } -static int round_child_height(REBAR_BAND *lpBand, int cyHeight) +static int round_child_height(const REBAR_BAND *lpBand, int cyHeight) { int cy = 0; if (lpBand->cyIntegral == 0) diff --git a/dlls/comctl32/status.c b/dlls/comctl32/status.c index f7d203b..11a977d 100644 --- a/dlls/comctl32/status.c +++ b/dlls/comctl32/status.c @@ -333,7 +333,7 @@ STATUSBAR_Refresh (STATUS_INFO *infoPtr, HDC hdc) static int -STATUSBAR_InternalHitTest(const STATUS_INFO *infoPtr, const LPPOINT pt) +STATUSBAR_InternalHitTest(const STATUS_INFO *infoPtr, const POINT *pt) { int i; if (infoPtr->simple) diff --git a/dlls/comctl32/tab.c b/dlls/comctl32/tab.c index b884697..4b439b2 100644 --- a/dlls/comctl32/tab.c +++ b/dlls/comctl32/tab.c @@ -1445,7 +1445,7 @@ static void TAB_SetItemBounds (TAB_INFO *infoPtr) static void -TAB_EraseTabInterior(const TAB_INFO *infoPtr, HDC hdc, INT iItem, RECT *drawRect) +TAB_EraseTabInterior(const TAB_INFO *infoPtr, HDC hdc, INT iItem, const RECT *drawRect) { LONG lStyle = GetWindowLongW(infoPtr->hwnd, GWL_STYLE); HBRUSH hbr = CreateSolidBrush (comctl32_color.clrBtnFace); @@ -3223,7 +3223,7 @@ TAB_SetExtendedStyle (TAB_INFO *infoPtr, DWORD exMask, DWORD exStyle) } static inline LRESULT -TAB_GetExtendedStyle (TAB_INFO *infoPtr) +TAB_GetExtendedStyle (const TAB_INFO *infoPtr) { return infoPtr->exStyle; } diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index 5a0344f..9bbac21 100644 --- a/dlls/comctl32/toolbar.c +++ b/dlls/comctl32/toolbar.c @@ -240,7 +240,7 @@ typedef enum static const WCHAR themeClass[] = { 'T','o','o','l','b','a','r',0 }; static BOOL TOOLBAR_GetButtonInfo(const TOOLBAR_INFO *infoPtr, NMTOOLBARW *nmtb); -static BOOL TOOLBAR_IsButtonRemovable(const TOOLBAR_INFO *infoPtr, int iItem, PCUSTOMBUTTON btnInfo); +static BOOL TOOLBAR_IsButtonRemovable(const TOOLBAR_INFO *infoPtr, int iItem, const CUSTOMBUTTON *btnInfo); static HIMAGELIST TOOLBAR_GetImageList(const PIMLENTRY *pies, INT cies, INT id); static PIMLENTRY TOOLBAR_GetImageListEntry(const PIMLENTRY *pies, INT cies, INT id); static VOID TOOLBAR_DeleteImageList(PIMLENTRY **pies, INT *cies); @@ -1770,7 +1770,7 @@ TOOLBAR_LayoutToolbar(TOOLBAR_INFO *infoPtr) static INT -TOOLBAR_InternalHitTest (TOOLBAR_INFO *infoPtr, const POINT *lpPt) +TOOLBAR_InternalHitTest (const TOOLBAR_INFO *infoPtr, const POINT *lpPt) { TBUTTON_INFO *btnPtr; INT i; @@ -3676,7 +3676,7 @@ TOOLBAR_HideButton (TOOLBAR_INFO *infoPtr, WPARAM wParam, LPARAM lParam) static inline LRESULT -TOOLBAR_HitTest (TOOLBAR_INFO *infoPtr, LPARAM lParam) +TOOLBAR_HitTest (const TOOLBAR_INFO *infoPtr, LPARAM lParam) { return TOOLBAR_InternalHitTest (infoPtr, (LPPOINT)lParam); } @@ -7039,7 +7039,7 @@ static BOOL TOOLBAR_GetButtonInfo(const TOOLBAR_INFO *infoPtr, NMTOOLBARW *nmtb) } -static BOOL TOOLBAR_IsButtonRemovable(const TOOLBAR_INFO *infoPtr, int iItem, PCUSTOMBUTTON btnInfo) +static BOOL TOOLBAR_IsButtonRemovable(const TOOLBAR_INFO *infoPtr, int iItem, const CUSTOMBUTTON *btnInfo) { NMTOOLBARW nmtb;

1 0

Paul Vriens : mshtml/tests: Use strcmp_wa instead of lstrcmpW to test correctly on Win98.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: a3160779f9ad66f44bd9b39bb2d99808210344bc URL: http://source.winehq.org/git/wine.git/?a=commit;h=a3160779f9ad66f44bd9b39bb… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sat Jun 6 13:42:38 2009 +0200 mshtml/tests: Use strcmp_wa instead of lstrcmpW to test correctly on Win98. --- dlls/mshtml/tests/dom.c | 18 +++++------------- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index fa861ad..7e43693 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -58,14 +58,10 @@ static const char cond_comment_str[] = "" "</body></html>"; -static const WCHAR noneW[] = {'N','o','n','e',0}; - static WCHAR characterW[] = {'c','h','a','r','a','c','t','e','r',0}; static WCHAR texteditW[] = {'t','e','x','t','e','d','i','t',0}; static WCHAR wordW[] = {'w','o','r','d',0}; -static const WCHAR text_javascriptW[] = {'t','e','x','t','/','j','a','v','a','s','c','r','i','p','t',0}; - typedef enum { ET_NONE, ET_HTML, @@ -3638,7 +3634,7 @@ static void test_default_selection(IHTMLDocument2 *doc) hres = IHTMLSelectionObject_get_type(selection, &str); ok(hres == S_OK, "get_type failed: %08x\n", hres); - ok(!lstrcmpW(str, noneW), "type = %s\n", dbgstr_w(str)); + ok(!strcmp_wa(str, "None"), "type = %s\n", dbgstr_w(str)); SysFreeString(str); hres = IHTMLSelectionObject_createRange(selection, &disp); @@ -3661,7 +3657,6 @@ static void test_default_body(IHTMLBodyElement *body) VARIANT v; WCHAR sBodyText[] = {'#','F','F','0','0','0','0',0}; WCHAR sTextInvalid[] = {'I','n','v','a','l','i','d',0}; - WCHAR sResInvalid[] = {'#','0','0','a','0','d','0',0}; bstr = (void*)0xdeadbeef; hres = IHTMLBodyElement_get_background(body, &bstr); @@ -3694,7 +3689,7 @@ static void test_default_body(IHTMLBodyElement *body) hres = IHTMLBodyElement_get_text(body, &v); ok(hres == S_OK, "expect S_OK got 0x%08d\n", hres); ok(V_VT(&v) == VT_BSTR, "Expected VT_BSTR got %d\n", V_VT(&v)); - ok(!lstrcmpW(sResInvalid, V_BSTR(&v)), "v != sResInvalid\n"); + ok(!strcmp_wa(V_BSTR(&v), "#00a0d0"), "v != '#00a0d0'\n"); VariantClear(&v); /* get_text - Valid Text */ @@ -3715,7 +3710,6 @@ static void test_default_body(IHTMLBodyElement *body) static void test_body_funs(IHTMLBodyElement *body) { static WCHAR sRed[] = {'r','e','d',0}; - static WCHAR sRedbg[] = {'#','f','f','0','0','0','0',0}; VARIANT vbg; VARIANT vDefaultbg; HRESULT hres; @@ -3733,7 +3727,7 @@ static void test_body_funs(IHTMLBodyElement *body) hres = IHTMLBodyElement_get_bgColor(body, &vbg); ok(hres == S_OK, "get_bgColor failed: %08x\n", hres); ok(V_VT(&vDefaultbg) == VT_BSTR, "V_VT(&vDefaultbg) != VT_BSTR\n"); - ok(!lstrcmpW(V_BSTR(&vbg), sRedbg), "Unexpected type %s\n", dbgstr_w(V_BSTR(&vbg))); + ok(!strcmp_wa(V_BSTR(&vbg), "#ff0000"), "Unexpected bgcolor %s\n", dbgstr_w(V_BSTR(&vbg))); VariantClear(&vbg); /* Restore Originial */ @@ -4319,7 +4313,7 @@ static void test_elems(IHTMLDocument2 *doc) hres = IHTMLScriptElement_get_type(script, &type); ok(hres == S_OK, "get_type failed: %08x\n", hres); - ok(!lstrcmpW(type, text_javascriptW), "Unexpected type %s\n", dbgstr_w(type)); + ok(!strcmp_wa(type, "text/javascript"), "Unexpected type %s\n", dbgstr_w(type)); SysFreeString(type); /* test defer */ @@ -4733,12 +4727,10 @@ static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, D BSTR state; HRESULT hres; - static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; - hres = IHTMLDocument2_get_readyState(notif_doc, &state); ok(hres == S_OK, "get_readyState failed: %08x\n", hres); - if(!lstrcmpW(state, completeW)) + if(!strcmp_wa(state, "complete")) doc_complete = TRUE; SysFreeString(state);

1 0

Paul Vriens : mshtml/tests: Correct another test.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 44ef1c9bed298c0ecf4d616a7de0a14ac1a77eaa URL: http://source.winehq.org/git/wine.git/?a=commit;h=44ef1c9bed298c0ecf4d616a7… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sat Jun 6 13:28:58 2009 +0200 mshtml/tests: Correct another test. --- dlls/mshtml/tests/dom.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 99e5d2a..fa861ad 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -3688,12 +3688,13 @@ static void test_default_body(IHTMLBodyElement *body) V_BSTR(&v) = SysAllocString(sTextInvalid); hres = IHTMLBodyElement_put_text(body, v); ok(hres == S_OK, "expect S_OK got 0x%08d\n", hres); + VariantClear(&v); V_VT(&v) = VT_NULL; hres = IHTMLBodyElement_get_text(body, &v); ok(hres == S_OK, "expect S_OK got 0x%08d\n", hres); ok(V_VT(&v) == VT_BSTR, "Expected VT_BSTR got %d\n", V_VT(&v)); - ok(!lstrcmpW(sResInvalid, V_BSTR(&v)), "bstr != sResInvalid\n"); + ok(!lstrcmpW(sResInvalid, V_BSTR(&v)), "v != sResInvalid\n"); VariantClear(&v); /* get_text - Valid Text */ @@ -3701,12 +3702,13 @@ static void test_default_body(IHTMLBodyElement *body) V_BSTR(&v) = SysAllocString(sBodyText); hres = IHTMLBodyElement_put_text(body, v); ok(hres == S_OK, "expect S_OK got 0x%08d\n", hres); + VariantClear(&v); V_VT(&v) = VT_NULL; hres = IHTMLBodyElement_get_text(body, &v); ok(hres == S_OK, "expect S_OK got 0x%08d\n", hres); ok(V_VT(&v) == VT_BSTR, "Expected VT_BSTR got %d\n", V_VT(&v)); - ok(lstrcmpW(bstr, V_BSTR(&v)), "bstr != V_BSTR(&v)\n"); + ok(!strcmp_wa(V_BSTR(&v), "#ff0000"), "v != '#ff0000'\n"); VariantClear(&v); }

1 0

Paul Vriens : mshtml/tests: Use lstrcmpA in a helper function to make it work correctly on Win98.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 8a784a5ebab33018c362895511ebd6bfe488be56 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a784a5ebab33018c36289551… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sat Jun 6 12:11:45 2009 +0200 mshtml/tests: Use lstrcmpA in a helper function to make it work correctly on Win98. --- dlls/mshtml/tests/dom.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 8951bf2..99e5d2a 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -374,9 +374,9 @@ static const char *dbgstr_guid(REFIID riid) static int strcmp_wa(LPCWSTR strw, const char *stra) { - WCHAR buf[512]; - MultiByteToWideChar(CP_ACP, 0, stra, -1, buf, sizeof(buf)/sizeof(WCHAR)); - return lstrcmpW(strw, buf); + CHAR buf[512]; + WideCharToMultiByte(CP_ACP, 0, strw, -1, buf, sizeof(buf), NULL, NULL); + return lstrcmpA(stra, buf); } static BSTR a2bstr(const char *str)

1 0

Paul Vriens : mshtml/tests: Correct a test and show a Wine bug.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 3aef9ef08eeddcc43fbd82a243753fe211d243b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3aef9ef08eeddcc43fbd82a24… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sat Jun 6 11:57:41 2009 +0200 mshtml/tests: Correct a test and show a Wine bug. --- dlls/mshtml/tests/dom.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 497fc0a..8951bf2 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2957,7 +2957,8 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_get_margin(style, &str); ok(hres == S_OK, "get_margin failed: %08x\n", hres); - ok(strcmp_wa(str, "1"), "margin = %s\n", dbgstr_w(str)); + todo_wine + ok(!strcmp_wa(str, "1px"), "margin = %s\n", dbgstr_w(str)); hres = IHTMLStyle_put_margin(style, NULL); ok(hres == S_OK, "put_margin failed: %08x\n", hres);

1 0

André Hentschel : shell32/tests: Fix error messages.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: c867eca1e0bfc13fac282690a94cea4dc323882f URL: http://source.winehq.org/git/wine.git/?a=commit;h=c867eca1e0bfc13fac282690a… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 6 12:44:53 2009 +0200 shell32/tests: Fix error messages. --- dlls/shell32/tests/appbar.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/tests/appbar.c b/dlls/shell32/tests/appbar.c index 51bea2b..e23d728 100644 --- a/dlls/shell32/tests/appbar.c +++ b/dlls/shell32/tests/appbar.c @@ -71,15 +71,15 @@ static void testwindow_setpos(HWND hwnd) abd.rc.top = abd.rc.bottom - (info->desired_rect.bottom - info->desired_rect.top); break; case ABE_LEFT: - ok(info->desired_rect.right == abd.rc.right, "ABM_QUERYPOS changed right of rect from %i to %i\n", info->desired_rect.top, abd.rc.top); + ok(info->desired_rect.right == abd.rc.right, "ABM_QUERYPOS changed right of rect from %i to %i\n", info->desired_rect.right, abd.rc.right); abd.rc.right = abd.rc.left + (info->desired_rect.right - info->desired_rect.left); break; case ABE_RIGHT: - ok(info->desired_rect.left == abd.rc.left, "ABM_QUERYPOS changed left of rect from %i to %i\n", info->desired_rect.top, abd.rc.top); + ok(info->desired_rect.left == abd.rc.left, "ABM_QUERYPOS changed left of rect from %i to %i\n", info->desired_rect.left, abd.rc.left); abd.rc.left = abd.rc.right - (info->desired_rect.right - info->desired_rect.left); break; case ABE_TOP: - ok(info->desired_rect.bottom == abd.rc.bottom, "ABM_QUERYPOS changed bottom of rect from %i to %i\n", info->desired_rect.top, abd.rc.top); + ok(info->desired_rect.bottom == abd.rc.bottom, "ABM_QUERYPOS changed bottom of rect from %i to %i\n", info->desired_rect.bottom, abd.rc.bottom); abd.rc.bottom = abd.rc.top + (info->desired_rect.bottom - info->desired_rect.top); break; }

1 0

Alexandre Julliard : wininet: Always use a full URL for redirects, even with an absolute path.
by Alexandre Julliard 08 Jun '09

08 Jun '09

Module: wine Branch: master Commit: 4b2a15de9fef0f396783ab2f1979538abc63f457 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b2a15de9fef0f396783ab2f1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 5 16:42:44 2009 +0200 wininet: Always use a full URL for redirects, even with an absolute path. --- dlls/wininet/http.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 1bba8d9..0f59810 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -3255,8 +3255,6 @@ static LPWSTR HTTP_GetRedirectURL(LPWININETHTTPREQW lpwhr, LPCWSTR lpszUrl) LPWSTR orig_url; LPWSTR combined_url; - if (lpszUrl[0]=='/') return WININET_strdupW( lpszUrl ); - urlComponents.dwStructSize = sizeof(URL_COMPONENTSW); urlComponents.lpszScheme = (lpwhr->hdr.dwFlags & INTERNET_FLAG_SECURE) ? szHttps : szHttp; urlComponents.dwSchemeLength = 0;

1 0

Ken Sharp : Try2: Website: Remove GIMP Fun Project
by Jeremy Newman 08 Jun '09

08 Jun '09

Module: website Branch: master Commit: d3b2b22abd9b0d87da83e134ad9e1c8d1ab58c3f URL: http://source.winehq.org/git/website.git/?a=commit;h=d3b2b22abd9b0d87da83e1… Author: Ken Sharp <kennybobs(a)o2.co.uk> Date: Sat Jun 6 00:12:36 2009 +0100 Try2: Website: Remove GIMP Fun Project Disregard first patch.. this one makes a little more sense. Ken Sharp wrote: > See Bug 7976. Apparently this has already been done. > > > ------------------------------------------------------------------------ > > >From 81e05905abf3330c07e13fbf58dc6e8b4ac767d1 Mon Sep 17 00:00:00 2001 From: Ken Sharp <kennybobs(a)o2.co.uk> Date: Fri, 5 Jun 2009 23:55:39 +0100 Subject: [PATCH] Remove GIMP Fun Project --- templates/en/fun_projects.template | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/templates/en/fun_projects.template b/templates/en/fun_projects.template index 1b078af..d94a999 100644 --- a/templates/en/fun_projects.template +++ b/templates/en/fun_projects.template @@ -426,11 +426,6 @@ subsystem level. The complementary project (use ghostscript to print from Wine) has been implemented, and working just fine. - <a name="gimp"></a><h4 class=todo>A Wine based GIMP plugin for using Photoshop plugins</h4> - Suggested by <a href="mailto:meissner@suse.de">Marcus Meissner</a>: - Investigate if we could make a WINE based GIMP plugin which can handle - Photoshop plugins. - <a name="wgl"></a><h3 class=inprogress>wined3d use wgl</h3> Make wined3d (or d3d8) use wgl (windows opengl) instead of glx. (just search for glx commands and replace then with the wgl equivalents) Doing so would enable wine's d3d to run on windows in place of

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2009