wine-commits June 2009

wine-commits@winehq.org

5 participants
1115 discussions

Tony Wasserka : d3dx9: Implement D3DXLoadSurfaceFromFile.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 2a9c43fb355c30a3f8a57e318eab45e45794f023 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2a9c43fb355c30a3f8a57e318… Author: Tony Wasserka <tony.wasserka(a)freenet.de> Date: Mon Jun 22 17:33:48 2009 +0200 d3dx9: Implement D3DXLoadSurfaceFromFile. --- dlls/d3dx9_36/d3dx9_36.spec | 4 +- dlls/d3dx9_36/surface.c | 54 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/d3dx9_36.spec b/dlls/d3dx9_36/d3dx9_36.spec index dd9f74a..663483a 100644 --- a/dlls/d3dx9_36/d3dx9_36.spec +++ b/dlls/d3dx9_36/d3dx9_36.spec @@ -182,9 +182,9 @@ @ stub D3DXLoadPRTCompBufferFromFileA @ stub D3DXLoadPRTCompBufferFromFileW @ stub D3DXLoadSkinMeshFromXof -@ stub D3DXLoadSurfaceFromFileA +@ stdcall D3DXLoadSurfaceFromFileA(ptr ptr ptr str ptr long long ptr) @ stdcall D3DXLoadSurfaceFromFileInMemory(ptr ptr ptr ptr long ptr long long ptr) -@ stub D3DXLoadSurfaceFromFileW +@ stdcall D3DXLoadSurfaceFromFileW(ptr ptr ptr wstr ptr long long ptr) @ stub D3DXLoadSurfaceFromMemory @ stub D3DXLoadSurfaceFromResourceA @ stub D3DXLoadSurfaceFromResourceW diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index a4a8910..ac619c6 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -197,3 +197,57 @@ HRESULT WINAPI D3DXLoadSurfaceFromFileInMemory(LPDIRECT3DSURFACE9 pDestSurface, if( !pDestSurface || !pSrcData | !SrcDataSize ) return D3DERR_INVALIDCALL; return E_NOTIMPL; } + +/************************************************************ + * D3DXLoadSurfaceFromFile + */ +HRESULT WINAPI D3DXLoadSurfaceFromFileA(LPDIRECT3DSURFACE9 pDestSurface, + CONST PALETTEENTRY *pDestPalette, + CONST RECT *pDestRect, + LPCSTR pSrcFile, + CONST RECT *pSrcRect, + DWORD dwFilter, + D3DCOLOR Colorkey, + D3DXIMAGE_INFO *pSrcInfo) +{ + LPWSTR pWidename; + HRESULT hr; + int strlength; + TRACE("(void): relay\n"); + + if( !pSrcFile || !pDestSurface ) return D3DERR_INVALIDCALL; + + strlength = MultiByteToWideChar(CP_ACP, 0, pSrcFile, -1, NULL, 0); + pWidename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, strlength * sizeof(WCHAR)); + MultiByteToWideChar(CP_ACP, 0, pSrcFile, -1, pWidename, strlength); + + hr = D3DXLoadSurfaceFromFileW(pDestSurface, pDestPalette, pDestRect, pWidename, pSrcRect, dwFilter, Colorkey, pSrcInfo); + HeapFree(GetProcessHeap(), 0, pWidename); + + return hr; +} + +HRESULT WINAPI D3DXLoadSurfaceFromFileW(LPDIRECT3DSURFACE9 pDestSurface, + CONST PALETTEENTRY *pDestPalette, + CONST RECT *pDestRect, + LPCWSTR pSrcFile, + CONST RECT *pSrcRect, + DWORD Filter, + D3DCOLOR Colorkey, + D3DXIMAGE_INFO *pSrcInfo) +{ + HRESULT hr; + DWORD dwSize; + LPVOID pBuffer; + TRACE("(void): relay\n"); + + if( !pSrcFile || !pDestSurface ) return D3DERR_INVALIDCALL; + + hr = map_view_of_file(pSrcFile, &pBuffer, &dwSize); + if(FAILED(hr)) return D3DXERR_INVALIDDATA; + + hr = D3DXLoadSurfaceFromFileInMemory(pDestSurface, pDestPalette, pDestRect, pBuffer, dwSize, pSrcRect, Filter, Colorkey, pSrcInfo); + UnmapViewOfFile(pBuffer); + + return hr; +}

1 0

Tony Wasserka : d3dx9: Add a stub for D3DXLoadSurfaceFromFileInMemory.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 818223e75e3dd6582dcf37ca760eeaffe3f19548 URL: http://source.winehq.org/git/wine.git/?a=commit;h=818223e75e3dd6582dcf37ca7… Author: Tony Wasserka <tony.wasserka(a)freenet.de> Date: Mon Jun 22 17:21:30 2009 +0200 d3dx9: Add a stub for D3DXLoadSurfaceFromFileInMemory. --- dlls/d3dx9_36/d3dx9_36.spec | 2 +- dlls/d3dx9_36/surface.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/d3dx9_36.spec b/dlls/d3dx9_36/d3dx9_36.spec index 9721fc4..dd9f74a 100644 --- a/dlls/d3dx9_36/d3dx9_36.spec +++ b/dlls/d3dx9_36/d3dx9_36.spec @@ -183,7 +183,7 @@ @ stub D3DXLoadPRTCompBufferFromFileW @ stub D3DXLoadSkinMeshFromXof @ stub D3DXLoadSurfaceFromFileA -@ stub D3DXLoadSurfaceFromFileInMemory +@ stdcall D3DXLoadSurfaceFromFileInMemory(ptr ptr ptr ptr long ptr long long ptr) @ stub D3DXLoadSurfaceFromFileW @ stub D3DXLoadSurfaceFromMemory @ stub D3DXLoadSurfaceFromResourceA diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index 1614e44..a4a8910 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -159,3 +159,41 @@ HRESULT WINAPI D3DXGetImageInfoFromResourceW(HMODULE module, LPCWSTR resource, D } return D3DXERR_INVALIDDATA; } + +/************************************************************ + * D3DXLoadSurfaceFromFileInMemory + * + * Loads data from a given buffer into a surface and fills a given + * D3DXIMAGE_INFO structure with info about the source data. + * + * PARAMS + * pDestSurface [I] pointer to the surface + * pDestPalette [I] palette to use + * pDestRect [I] to be filled area of the surface + * pSrcData [I] pointer to the source data + * SrcDataSize [I] size of the source data in bytes + * pSrcRect [I] area of the source data to load + * dwFilter [I] filter to apply on stretching + * Colorkey [I] colorkey + * pSrcInfo [O] pointer to a D3DXIMAGE_INFO structure + * + * RETURNS + * Success: D3D_OK + * Failure: D3DERR_INVALIDCALL, if pDestSurface or pSrcData or SrcDataSize are NULL + * D3DXERR_INVALIDDATA, if pSrcData is no valid image file + * + */ +HRESULT WINAPI D3DXLoadSurfaceFromFileInMemory(LPDIRECT3DSURFACE9 pDestSurface, + CONST PALETTEENTRY *pDestPalette, + CONST RECT *pDestRect, + LPCVOID pSrcData, + UINT SrcDataSize, + CONST RECT *pSrcRect, + DWORD dwFilter, + D3DCOLOR Colorkey, + D3DXIMAGE_INFO *pSrcInfo) +{ + FIXME("stub\n"); + if( !pDestSurface || !pSrcData | !SrcDataSize ) return D3DERR_INVALIDCALL; + return E_NOTIMPL; +}

1 0

Andrew Eikum : gdiplus/tests: Fix resource leaks in several tests.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: ff95a69f5a97db5f4c0908c7dda77ba7d6563ecc URL: http://source.winehq.org/git/wine.git/?a=commit;h=ff95a69f5a97db5f4c0908c7d… Author: Andrew Eikum <andrew(a)brightnightgames.com> Date: Thu Jun 25 08:40:28 2009 -0500 gdiplus/tests: Fix resource leaks in several tests. A few tests initialized two GpGraphics objects, and only released one. These have been fixed by removing the redundant initialization. --- dlls/gdiplus/tests/graphics.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dlls/gdiplus/tests/graphics.c b/dlls/gdiplus/tests/graphics.c index 668d261..68c0e29 100644 --- a/dlls/gdiplus/tests/graphics.c +++ b/dlls/gdiplus/tests/graphics.c @@ -243,8 +243,6 @@ static void test_GdipDrawArc(void) HDC hdc = GetDC(0); /* make a graphics object and pen object */ - status = GdipCreateFromHDC(hdc, &graphics); - expect(Ok, status); ok(hdc != NULL, "Expected HDC to be initialized\n"); status = GdipCreateFromHDC(hdc, &graphics); @@ -289,8 +287,6 @@ static void test_GdipDrawArcI(void) HDC hdc = GetDC(0); /* make a graphics object and pen object */ - status = GdipCreateFromHDC(hdc, &graphics); - expect(Ok, status); ok(hdc != NULL, "Expected HDC to be initialized\n"); status = GdipCreateFromHDC(hdc, &graphics); @@ -335,8 +331,6 @@ static void test_GdipDrawBezierI(void) HDC hdc = GetDC(0); /* make a graphics object and pen object */ - status = GdipCreateFromHDC(hdc, &graphics); - expect(Ok, status); ok(hdc != NULL, "Expected HDC to be initialized\n"); status = GdipCreateFromHDC(hdc, &graphics); @@ -436,8 +430,6 @@ static void test_GdipDrawLineI(void) HDC hdc = GetDC(0); /* make a graphics object and pen object */ - status = GdipCreateFromHDC(hdc, &graphics); - expect(Ok, status); ok(hdc != NULL, "Expected HDC to be initialized\n"); status = GdipCreateFromHDC(hdc, &graphics); @@ -477,8 +469,6 @@ static void test_GdipDrawLinesI(void) HDC hdc = GetDC(0); /* make a graphics object and pen object */ - status = GdipCreateFromHDC(hdc, &graphics); - expect(Ok, status); ok(hdc != NULL, "Expected HDC to be initialized\n"); status = GdipCreateFromHDC(hdc, &graphics);

1 0

Austin English : winex11: Make sure GetKeyNameText gets the correct length to return.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 349337d7ef3ba9178f92c85d61d93bde7528e4b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=349337d7ef3ba9178f92c85d6… Author: Austin English <austinenglish(a)gmail.com> Date: Fri Jun 26 03:55:12 2009 -0500 winex11: Make sure GetKeyNameText gets the correct length to return. --- dlls/winex11.drv/keyboard.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c index 8a6dd37..3ffa13c 100644 --- a/dlls/winex11.drv/keyboard.c +++ b/dlls/winex11.drv/keyboard.c @@ -2349,11 +2349,7 @@ INT CDECL X11DRV_GetKeyNameText(LONG lParam, LPWSTR lpBuffer, INT nSize) TRACE("found scan=%04x keyc=%04x keysym=%04x string=%s\n", scanCode, keyc, (int)keys, name); if (lpBuffer && nSize && name) - { - MultiByteToWideChar(CP_UNIXCP, 0, name, -1, lpBuffer, nSize); - lpBuffer[nSize - 1] = 0; - return nSize; - } + return MultiByteToWideChar(CP_UNIXCP, 0, name, -1, lpBuffer, nSize); } /* Finally issue WARN for unknown keys */

1 0

Henri Verbeet : wined3d: Document GL context dependencies.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 7363b6e2e31639d81317b8817a2f885160370ac6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7363b6e2e31639d81317b8817… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jun 26 10:07:12 2009 +0200 wined3d: Document GL context dependencies. --- dlls/wined3d/arb_program_shader.c | 9 +++++++++ dlls/wined3d/ati_fragment_shader.c | 3 +++ dlls/wined3d/basetexture.c | 1 + dlls/wined3d/buffer.c | 4 ++++ dlls/wined3d/context.c | 2 ++ dlls/wined3d/cubetexture.c | 1 + dlls/wined3d/device.c | 5 ++++- dlls/wined3d/directx.c | 3 +++ dlls/wined3d/glsl_shader.c | 1 + dlls/wined3d/nvidia_texture_shader.c | 3 +++ dlls/wined3d/state.c | 1 + dlls/wined3d/surface.c | 23 +++++++++++++++++------ dlls/wined3d/texture.c | 1 + dlls/wined3d/utils.c | 3 +++ dlls/wined3d/volume.c | 2 ++ dlls/wined3d/volumetexture.c | 1 + 16 files changed, 56 insertions(+), 7 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7363b6e2e31639d81317b…

1 0

Henri Verbeet : wined3d: Make sure we have an active GL context before calling d3dfmt_p8_upload_palette ().
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 626baad817415f62cec4bb5f75d806a793ed67f1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=626baad817415f62cec4bb5f7… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jun 26 10:07:11 2009 +0200 wined3d: Make sure we have an active GL context before calling d3dfmt_p8_upload_palette(). --- dlls/wined3d/surface.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index e3070d2..bac2fe5 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -4094,6 +4094,8 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_RealizePalette(IWineD3DSurface *iface) if((This->resource.usage & WINED3DUSAGE_RENDERTARGET) && (convert == NO_CONVERSION)) { + IWineD3DDeviceImpl *device = This->resource.wineD3DDevice; + /* Make sure the texture is up to date. This call doesn't do anything if the texture is already up to date. */ IWineD3DSurface_LoadLocation(iface, SFLAG_INTEXTURE, NULL); @@ -4101,6 +4103,7 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_RealizePalette(IWineD3DSurface *iface) IWineD3DSurface_ModifyLocation(iface, SFLAG_INDRAWABLE, FALSE); /* Re-upload the palette */ + ActivateContext(device, device->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); d3dfmt_p8_upload_palette(iface, convert); } else { if(!(This->Flags & SFLAG_INSYSMEM)) {

1 0

Henri Verbeet : wined3d: Make sure we have an active GL context before calling surface_remove_pbo() .
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 1b306c25e22c5de24342294b453f795fbeb64a4e URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b306c25e22c5de24342294b4… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jun 26 10:07:10 2009 +0200 wined3d: Make sure we have an active GL context before calling surface_remove_pbo(). --- dlls/wined3d/surface.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 37cd88a..e3070d2 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -4826,6 +4826,7 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_LoadLocation(IWineD3DSurface *iface, D * but it isn't set (yet) in all cases it is getting called. */ if((convert != NO_CONVERSION) && (This->Flags & SFLAG_PBO)) { TRACE("Removing the pbo attached to surface %p\n", This); + if (!device->isInDraw) ActivateContext(device, device->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); surface_remove_pbo(This); }

1 0

Henri Verbeet : wined3d: Make sure we have an active GL context in IWineD3DSurfaceImpl_UnLoad().
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: db5b126da6c5099b4dab9c575a49afde93381b0a URL: http://source.winehq.org/git/wine.git/?a=commit;h=db5b126da6c5099b4dab9c575… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jun 26 10:07:09 2009 +0200 wined3d: Make sure we have an active GL context in IWineD3DSurfaceImpl_UnLoad(). --- dlls/wined3d/surface.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 424d2e3..37cd88a 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -836,6 +836,7 @@ static void surface_remove_pbo(IWineD3DSurfaceImpl *This) { static void WINAPI IWineD3DSurfaceImpl_UnLoad(IWineD3DSurface *iface) { IWineD3DBaseTexture *texture = NULL; IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *) iface; + IWineD3DDeviceImpl *device = This->resource.wineD3DDevice; renderbuffer_entry_t *entry, *entry2; TRACE("(%p)\n", iface); @@ -866,6 +867,8 @@ static void WINAPI IWineD3DSurfaceImpl_UnLoad(IWineD3DSurface *iface) { IWineD3DSurface_ModifyLocation(iface, SFLAG_INSRGBTEX, FALSE); This->Flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); + ActivateContext(device, device->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + /* Destroy PBOs, but load them into real sysmem before */ if(This->Flags & SFLAG_PBO) { surface_remove_pbo(This);

1 0

Henri Verbeet : wined3d: Make sure queries have an active GL context.
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: 181442a6a2127cbad550af23fdd33ee6a85e7180 URL: http://source.winehq.org/git/wine.git/?a=commit;h=181442a6a2127cbad550af23f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jun 26 10:07:08 2009 +0200 wined3d: Make sure queries have an active GL context. --- dlls/wined3d/query.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/query.c b/dlls/wined3d/query.c index 481177f..a24f513 100644 --- a/dlls/wined3d/query.c +++ b/dlls/wined3d/query.c @@ -62,6 +62,8 @@ static ULONG WINAPI IWineD3DQueryImpl_Release(IWineD3DQuery *iface) { TRACE("(%p) : Releasing from %d\n", This, This->ref); ref = InterlockedDecrement(&This->ref); if (ref == 0) { + ActivateContext(This->wineD3DDevice, This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + ENTER_GL(); /* Queries are specific to the GL context that created them. Not * deleting the query will obviously leak it, but that's still better @@ -316,6 +318,8 @@ static HRESULT WINAPI IWineD3DOcclusionQueryImpl_GetData(IWineD3DQuery* iface, return S_OK; } + ActivateContext(This->wineD3DDevice, This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + if (((WineQueryOcclusionData *)This->extendedData)->ctx != This->wineD3DDevice->activeContext || This->wineD3DDevice->activeContext->tid != GetCurrentThreadId()) { @@ -357,6 +361,8 @@ static HRESULT WINAPI IWineD3DEventQueryImpl_GetData(IWineD3DQuery* iface, void WineD3DContext *ctx; TRACE("(%p) : type D3DQUERY_EVENT, pData %p, dwSize %#x, dwGetDataFlags %#x\n", This, pData, dwSize, dwGetDataFlags); + ActivateContext(This->wineD3DDevice, This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + ctx = ((WineQueryEventData *)This->extendedData)->ctx; if(pData == NULL || dwSize == 0) { return S_OK; @@ -457,6 +463,9 @@ static HRESULT WINAPI IWineD3DEventQueryImpl_Issue(IWineD3DQuery* iface, DWORD TRACE("(%p) : dwIssueFlags %#x, type D3DQUERY_EVENT\n", This, dwIssueFlags); if (dwIssueFlags & WINED3DISSUE_END) { WineD3DContext *ctx = ((WineQueryEventData *)This->extendedData)->ctx; + + ActivateContext(This->wineD3DDevice, This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + if(ctx != This->wineD3DDevice->activeContext || ctx->tid != GetCurrentThreadId()) { /* GL fences can be used only from the context that created them, * so if a different context is active, don't bother setting the query. The penalty @@ -497,6 +506,8 @@ static HRESULT WINAPI IWineD3DOcclusionQueryImpl_Issue(IWineD3DQuery* iface, D if (GL_SUPPORT(ARB_OCCLUSION_QUERY)) { WineD3DContext *ctx = ((WineQueryOcclusionData *)This->extendedData)->ctx; + ActivateContext(This->wineD3DDevice, This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + if(ctx != This->wineD3DDevice->activeContext || ctx->tid != GetCurrentThreadId()) { FIXME("Not the owning context, can't start query\n"); } else {

1 0

Aric Stewart : shell32: Implement SHCreateShellFolderView (ordinal 256).
by Alexandre Julliard 26 Jun '09

26 Jun '09

Module: wine Branch: master Commit: a6c81e07548aec5777a2a53fbd4c7dca4cec4ba5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6c81e07548aec5777a2a53fb… Author: Aric Stewart <aric(a)codeweavers.com> Date: Fri Jun 26 17:01:29 2009 +0900 shell32: Implement SHCreateShellFolderView (ordinal 256). Used by IE7's Add On management dialog. --- dlls/shell32/shell32.spec | 2 +- dlls/shell32/shellord.c | 60 ++++++++++++++++++++++++-------------------- include/shlobj.h | 35 ++++++++++++++++++++++++++ 3 files changed, 69 insertions(+), 28 deletions(-) diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec index b50890b..433ed3a 100644 --- a/dlls/shell32/shell32.spec +++ b/dlls/shell32/shell32.spec @@ -210,7 +210,7 @@ 249 stdcall -noname PathParseIconLocation(ptr) PathParseIconLocationAW 250 stdcall -noname PathRemoveExtension(ptr) PathRemoveExtensionAW 251 stdcall -noname PathRemoveArgs(ptr) PathRemoveArgsAW - 256 stdcall @(ptr ptr) SHELL32_256 + 256 stdcall SHCreateShellFolderView(ptr ptr) 258 stdcall -noname LinkWindow_RegisterClass() 259 stdcall -noname LinkWindow_UnregisterClass() #299 stub Shl1632_ThunkData32 diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c index 2fef940..44c9c7e 100644 --- a/dlls/shell32/shellord.c +++ b/dlls/shell32/shellord.c @@ -1893,33 +1893,6 @@ HRESULT WINAPI SHCreateStdEnumFmtEtc( return hRes; } - -/************************************************************************* - * SHELL32_256 (SHELL32.256) - */ -HRESULT WINAPI SHELL32_256(LPDWORD lpdw0, LPDWORD lpdw1) -{ - HRESULT ret = S_OK; - - FIXME("stub %p 0x%08x %p\n", lpdw0, lpdw0 ? *lpdw0 : 0, lpdw1); - - if (!lpdw0 || *lpdw0 != 0x10) - ret = E_INVALIDARG; - else - { - LPVOID lpdata = 0;/*LocalAlloc(LMEM_ZEROINIT, 0x4E4);*/ - - if (!lpdata) - ret = E_OUTOFMEMORY; - else - { - /* Initialize and return unknown lpdata structure */ - } - } - - return ret; -} - /************************************************************************* * SHFindFiles (SHELL32.90) */ @@ -2140,3 +2113,36 @@ HRESULT WINAPI SHGetImageList(int iImageList, REFIID riid, void **ppv) FIXME("STUB: %i %s\n",iImageList,debugstr_guid(riid)); return E_NOINTERFACE; } + +/************************************************************************* + * SHCreateShellFolderView [SHELL32.256] + * + * Create a new instance of the default Shell folder view object. + * + * RETURNS + * Success: S_OK + * Failure: error value + * + * NOTES + * see IShellFolder::CreateViewObject + */ +HRESULT WINAPI SHCreateShellFolderView(const SFV_CREATE *pcsfv, + IShellView **ppsv) +{ + IShellView * psf; + HRESULT hRes; + + TRACE("sf=%p outer=%p callback=%p\n", + pcsfv->pshf, pcsfv->psvOuter, pcsfv->psfvcb); + + psf = IShellView_Constructor(pcsfv->pshf); + + if (!psf) + return E_OUTOFMEMORY; + + IShellView_AddRef(psf); + hRes = IShellView_QueryInterface(psf, &IID_IShellView, (LPVOID *)ppsv); + IShellView_Release(psf); + + return hRes; +} diff --git a/include/shlobj.h b/include/shlobj.h index 01f8368..c24c29c 100644 --- a/include/shlobj.h +++ b/include/shlobj.h @@ -514,6 +514,31 @@ DECLARE_INTERFACE_(IACList2,IACList) #define IACList2_SetOptions(p,a) (p)->lpVtbl->SetOptions(p,a) #endif +/**************************************************************************** + * IShellFolderViewCB interface + */ + +#define INTERFACE IShellFolderViewCB +DECLARE_INTERFACE_(IShellFolderViewCB,IUnknown) +{ + /*** IUnknown methods ***/ + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID riid, void** ppvObject) PURE; + STDMETHOD_(ULONG,AddRef)(THIS) PURE; + STDMETHOD_(ULONG,Release)(THIS) PURE; + /*** IShellFolderViewCB methods ***/ + STDMETHOD(MessageSFVCB)(THIS_ UINT uMsg, WPARAM wParam, LPARAM lParam) PURE; +}; +#undef INTERFACE + +#if !defined(__cplusplus) || defined(CINTERFACE) +/*** IUnknown methods ***/ +#define IShellFolderViewCB_QueryInterface(p,a,b) (p)->lpVtbl->QueryInterface(p,a,b) +#define IShellFolderViewCB_AddRef(p) (p)->lpVtbl->AddRef(p) +#define IShellFolderViewCB_Release(p) (p)->lpVtbl->Release(p) +/*** IShellFolderViewCB methods ***/ +#define IShellFolderViewCB_MessageSFVCB(p,a,b,c) (p)->lpVtbl->MessageSFVCB(p,a,b,c) +#endif + /* IProgressDialog interface */ #define PROGDLG_NORMAL 0x00000000 #define PROGDLG_MODAL 0x00000001 @@ -737,6 +762,16 @@ HRESULT WINAPI SHCreateShellFolderViewEx(LPCSFV pshfvi, IShellView **ppshv); #define SFVM_GET_WEBVIEW_THEME 86 /* undocumented */ #define SFVM_GETDEFERREDVIEWSETTINGS 92 /* undocumented */ +typedef struct _SFV_CREATE +{ + UINT cbSize; + IShellFolder *pshf; + IShellView *psvOuter; + IShellFolderViewCB *psfvcb; +} SFV_CREATE; + +HRESULT WINAPI SHCreateShellFolderView(const SFV_CREATE *pscfv, IShellView **ppsv); + /* Types and definitions for the SFM_* parameters */ #include <pshpack8.h>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2009