winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
January 2010
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
615 discussions
Start a n
N
ew thread
Paul Vriens : xmllite/tests: Remove some tests that make Vista SP0 crash.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 307b9fb68750951c42da2425e9b5d75e0d406724 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=307b9fb68750951c42da2425e…
Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 22 10:03:28 2010 +0100 xmllite/tests: Remove some tests that make Vista SP0 crash. --- dlls/xmllite/tests/reader.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 27dae53..cb55181 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -176,7 +176,6 @@ static void test_reader_create(void) { HRESULT hr; IXmlReader *reader; - IMalloc *imalloc; IUnknown *input; /* crashes native */ @@ -189,12 +188,6 @@ static void test_reader_create(void) hr = pCreateXmlReader(&IID_IXmlReader, (LPVOID*)&reader, NULL); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); - hr = CoGetMalloc(1, &imalloc); - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); - - hr = IMalloc_DidAlloc(imalloc, reader); - ok(hr != 1, "Expected 0 or -1, got %08x\n", hr); - /* Null input pointer, releases previous input */ hr = IXmlReader_SetInput(reader, NULL); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
1
0
0
0
Nikolay Sivov : xmllite: Basic input object creation on IXmlReader:: SetInput().
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 89092c928ac7d8c38aef8a8db5cab5d6109dc628 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=89092c928ac7d8c38aef8a8db…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Jan 21 21:05:25 2010 +0300 xmllite: Basic input object creation on IXmlReader::SetInput(). --- dlls/xmllite/reader.c | 39 +++++++++++++++++++++++++++++++++++++-- dlls/xmllite/tests/reader.c | 8 ++++++-- include/xmllite.idl | 5 ++++- 3 files changed, 47 insertions(+), 5 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 2c7d3f1..97476d9 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -38,6 +38,7 @@ typedef struct _xmlreader { const IXmlReaderVtbl *lpVtbl; LONG ref; + IXmlReaderInput *input; } xmlreader; typedef struct _xmlreaderinput @@ -95,6 +96,7 @@ static ULONG WINAPI xmlreader_Release(IXmlReader *iface) ref = InterlockedDecrement(&This->ref); if (ref == 0) { + if (This->input) IUnknown_Release(This->input); HeapFree(GetProcessHeap(), 0, This); } @@ -103,8 +105,40 @@ static ULONG WINAPI xmlreader_Release(IXmlReader *iface) static HRESULT WINAPI xmlreader_SetInput(IXmlReader* iface, IUnknown *input) { - FIXME("(%p %p): stub\n", iface, input); - return E_NOTIMPL; + xmlreader *This = impl_from_IXmlReader(iface); + HRESULT hr; + + TRACE("(%p %p)\n", This, input); + + if (This->input) + { + IUnknown_Release(This->input); + This->input = NULL; + } + + /* just reset current input */ + if (!input) return S_OK; + + /* now try IXmlReaderInput, ISequentialStream, IStream */ + hr = IUnknown_QueryInterface(input, &IID_IXmlReaderInput, (void**)&This->input); + if (hr != S_OK) + { + IUnknown *stream_input = NULL; + + hr = IUnknown_QueryInterface(input, &IID_ISequentialStream, (void**)&stream_input); + if (hr != S_OK) + { + hr = IUnknown_QueryInterface(input, &IID_IStream, (void**)&stream_input); + if (hr != S_OK) return hr; + } + + /* create IXmlReaderInput basing on supplied interface */ + IUnknown_Release(stream_input); + return CreateXmlReaderInputWithEncodingName(stream_input, + NULL, NULL, FALSE, NULL, &This->input); + } + + return S_OK; } static HRESULT WINAPI xmlreader_GetProperty(IXmlReader* iface, UINT property, LONG_PTR *value) @@ -357,6 +391,7 @@ HRESULT WINAPI CreateXmlReader(REFIID riid, void **pObject, IMalloc *pMalloc) reader->lpVtbl = &xmlreader_vtbl; reader->ref = 1; + reader->input = NULL; *pObject = &reader->lpVtbl; diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 5585853..27dae53 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -195,14 +195,18 @@ static void test_reader_create(void) hr = IMalloc_DidAlloc(imalloc, reader); ok(hr != 1, "Expected 0 or -1, got %08x\n", hr); + /* Null input pointer, releases previous input */ + hr = IXmlReader_SetInput(reader, NULL); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + /* test input interface selection sequence */ hr = testinput_createinstance((void**)&input); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); input_iids.count = 0; hr = IXmlReader_SetInput(reader, input); - todo_wine ok(hr == E_NOINTERFACE, "Expected E_NOINTERFACE, got %08x\n", hr); - ok_iids(&input_iids, setinput_full, sizeof(setinput_full)/sizeof(REFIID), TRUE); + ok(hr == E_NOINTERFACE, "Expected E_NOINTERFACE, got %08x\n", hr); + ok_iids(&input_iids, setinput_full, sizeof(setinput_full)/sizeof(REFIID), FALSE); IUnknown_Release(input); diff --git a/include/xmllite.idl b/include/xmllite.idl index e00d8c8..dbbb0d9 100644 --- a/include/xmllite.idl +++ b/include/xmllite.idl @@ -81,4 +81,7 @@ interface IXmlReader : IUnknown /* IXmlReader construction */ cpp_quote("STDAPI CreateXmlReader(REFIID riid, void **ppvObject, IMalloc *pMalloc);") -typedef IUnknown IXmlReaderInput; +cpp_quote("typedef IUnknown IXmlReaderInput;") +cpp_quote("STDAPI CreateXmlReaderInputWithEncodingName(IUnknown *stream, IMalloc *pMalloc,") +cpp_quote(" LPCWSTR encoding, BOOL hint,") +cpp_quote(" LPCWSTR base_uri, IXmlReaderInput **ppInput);")
1
0
0
0
Nikolay Sivov : xmllite: Add IXmlReaderInput stub implementation.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 4e3283fdd25d019e78da89590ad19854bdf43d4f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4e3283fdd25d019e78da89590…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Jan 21 18:19:20 2010 +0300 xmllite: Add IXmlReaderInput stub implementation. --- dlls/xmllite/reader.c | 88 +++++++++++++++++++++++++++++++++++++++++- dlls/xmllite/tests/reader.c | 17 +++----- 2 files changed, 92 insertions(+), 13 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 5877474..2c7d3f1 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -31,17 +31,31 @@ WINE_DEFAULT_DEBUG_CHANNEL(xmllite); +/* not defined in public headers */ +DEFINE_GUID(IID_IXmlReaderInput, 0x0b3ccc9b, 0x9214, 0x428b, 0xa2, 0xae, 0xef, 0x3a, 0xa8, 0x71, 0xaf, 0xda); + typedef struct _xmlreader { const IXmlReaderVtbl *lpVtbl; LONG ref; } xmlreader; +typedef struct _xmlreaderinput +{ + const IUnknownVtbl *lpVtbl; + LONG ref; +} xmlreaderinput; + static inline xmlreader *impl_from_IXmlReader(IXmlReader *iface) { return (xmlreader *)((char*)iface - FIELD_OFFSET(xmlreader, lpVtbl)); } +static inline xmlreaderinput *impl_from_IXmlReaderInput(IXmlReaderInput *iface) +{ + return (xmlreaderinput *)((char*)iface - FIELD_OFFSET(xmlreaderinput, lpVtbl)); +} + static HRESULT WINAPI xmlreader_QueryInterface(IXmlReader *iface, REFIID riid, void** ppvObject) { xmlreader *This = impl_from_IXmlReader(iface); @@ -271,6 +285,59 @@ static const struct IXmlReaderVtbl xmlreader_vtbl = xmlreader_IsEOF }; +/* IXmlReaderInput */ +static HRESULT WINAPI xmlreaderinput_QueryInterface(IXmlReaderInput *iface, REFIID riid, void** ppvObject) +{ + xmlreaderinput *This = impl_from_IXmlReaderInput(iface); + + TRACE("%p %s %p\n", This, debugstr_guid(riid), ppvObject); + + if (IsEqualGUID(riid, &IID_IXmlReaderInput) || + IsEqualGUID(riid, &IID_IUnknown)) + { + *ppvObject = iface; + } + else + { + FIXME("interface %s not implemented\n", debugstr_guid(riid)); + return E_NOINTERFACE; + } + + IUnknown_AddRef(iface); + + return S_OK; +} + +static ULONG WINAPI xmlreaderinput_AddRef(IXmlReaderInput *iface) +{ + xmlreaderinput *This = impl_from_IXmlReaderInput(iface); + TRACE("%p\n", This); + return InterlockedIncrement(&This->ref); +} + +static ULONG WINAPI xmlreaderinput_Release(IXmlReaderInput *iface) +{ + xmlreaderinput *This = impl_from_IXmlReaderInput(iface); + LONG ref; + + TRACE("%p\n", This); + + ref = InterlockedDecrement(&This->ref); + if (ref == 0) + { + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static const struct IUnknownVtbl xmlreaderinput_vtbl = +{ + xmlreaderinput_QueryInterface, + xmlreaderinput_AddRef, + xmlreaderinput_Release +}; + HRESULT WINAPI CreateXmlReader(REFIID riid, void **pObject, IMalloc *pMalloc) { xmlreader *reader; @@ -305,7 +372,22 @@ HRESULT WINAPI CreateXmlReaderInputWithEncodingName(IUnknown *stream, LPCWSTR base_uri, IXmlReaderInput **ppInput) { - FIXME("%p %p %s %d %s %p\n", stream, pMalloc, wine_dbgstr_w(encoding), - hint, wine_dbgstr_w(base_uri), ppInput); - return E_NOTIMPL; + xmlreaderinput *readerinput; + + FIXME("%p %p %s %d %s %p: stub\n", stream, pMalloc, wine_dbgstr_w(encoding), + hint, wine_dbgstr_w(base_uri), ppInput); + + if (!stream || !ppInput) return E_INVALIDARG; + + readerinput = HeapAlloc(GetProcessHeap(), 0, sizeof (*readerinput)); + if(!readerinput) return E_OUTOFMEMORY; + + readerinput->lpVtbl = &xmlreaderinput_vtbl; + readerinput->ref = 1; + + *ppInput = (IXmlReaderInput*)&readerinput->lpVtbl; + + TRACE("returning iface %p\n", *ppInput); + + return S_OK; } diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 8faf469..5585853 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -218,9 +218,9 @@ static void test_readerinput(void) LONG ref; hr = pCreateXmlReaderInputWithEncodingName(NULL, NULL, NULL, FALSE, NULL, NULL); - todo_wine ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); + ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); hr = pCreateXmlReaderInputWithEncodingName(NULL, NULL, NULL, FALSE, NULL, &reader_input); - todo_wine ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); + ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); @@ -229,17 +229,11 @@ static void test_readerinput(void) ok(ref == 2, "Expected 2, got %d\n", ref); IStream_Release(stream); hr = pCreateXmlReaderInputWithEncodingName((IUnknown*)stream, NULL, NULL, FALSE, NULL, &reader_input); - todo_wine ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); - if(hr != S_OK) - { - skip("CreateXmlReaderInputWithEncodingName not implemented\n"); - IStream_Release(stream); - return; - } + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); /* IXmlReader grabs a stream reference */ ref = IStream_AddRef(stream); - ok(ref == 3, "Expected 3, got %d\n", ref); + todo_wine ok(ref == 3, "Expected 3, got %d\n", ref); IStream_Release(stream); /* IID_IXmlReaderInput */ @@ -249,6 +243,9 @@ static void test_readerinput(void) obj = (IUnknown*)0xdeadbeef; hr = IUnknown_QueryInterface(reader_input, &IID_IXmlReaderInput, (void**)&obj); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ref = IUnknown_AddRef(reader_input); + ok(ref == 3, "Expected 3, got %d\n", ref); + IUnknown_Release(reader_input); IUnknown_Release(reader_input); IStream_Release(stream);
1
0
0
0
Nikolay Sivov : xmllite/tests: Test query for supported interface sequence while creating IXmlReaderInput instance .
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 5c1f0dbae088589a791a35df3ccffd7d8ed2fdad URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5c1f0dbae088589a791a35df3…
Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Jan 21 17:47:03 2010 +0300 xmllite/tests: Test query for supported interface sequence while creating IXmlReaderInput instance. --- dlls/xmllite/reader.c | 12 +++ dlls/xmllite/tests/reader.c | 189 +++++++++++++++++++++++++++++++++++++++++- dlls/xmllite/xmllite.spec | 2 +- include/xmllite.idl | 2 + 4 files changed, 199 insertions(+), 6 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index cd30f48..5877474 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -297,3 +297,15 @@ HRESULT WINAPI CreateXmlReader(REFIID riid, void **pObject, IMalloc *pMalloc) return S_OK; } + +HRESULT WINAPI CreateXmlReaderInputWithEncodingName(IUnknown *stream, + IMalloc *pMalloc, + LPCWSTR encoding, + BOOL hint, + LPCWSTR base_uri, + IXmlReaderInput **ppInput) +{ + FIXME("%p %p %s %d %s %p\n", stream, pMalloc, wine_dbgstr_w(encoding), + hint, wine_dbgstr_w(base_uri), ppInput); + return E_NOTIMPL; +} diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 18eed5c..8faf469 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -21,18 +21,137 @@ #define COBJMACROS #include <stdarg.h> +#include <stdio.h> #include "windef.h" #include "winbase.h" +#include "initguid.h" #include "ole2.h" #include "xmllite.h" -#include "initguid.h" #include "wine/test.h" -DEFINE_GUID(IID_IXmlReader, 0x7279fc81, 0x709d, 0x4095, 0xb6, 0x3d, 0x69, - 0xfe, 0x4b, 0x0d, 0x90, 0x30); +DEFINE_GUID(IID_IXmlReaderInput, 0x0b3ccc9b, 0x9214, 0x428b, 0xa2, 0xae, 0xef, 0x3a, 0xa8, 0x71, 0xaf, 0xda); HRESULT WINAPI (*pCreateXmlReader)(REFIID riid, void **ppvObject, IMalloc *pMalloc); +HRESULT WINAPI (*pCreateXmlReaderInputWithEncodingName)(IUnknown *stream, + IMalloc *pMalloc, + LPCWSTR encoding, + BOOL hint, + LPCWSTR base_uri, + IXmlReaderInput **ppInput); +static const char *debugstr_guid(REFIID riid) +{ + static char buf[50]; + + sprintf(buf, "{%08X-%04X-%04X-%02X%02X-%02X%02X%02X%02X%02X%02X}", + riid->Data1, riid->Data2, riid->Data3, riid->Data4[0], + riid->Data4[1], riid->Data4[2], riid->Data4[3], riid->Data4[4], + riid->Data4[5], riid->Data4[6], riid->Data4[7]); + + return buf; +} + +typedef struct input_iids_t { + IID iids[10]; + int count; +} input_iids_t; + +static const IID *setinput_full[] = { + &IID_IXmlReaderInput, + &IID_ISequentialStream, + &IID_IStream +}; + +static input_iids_t input_iids; + +static void ok_iids_(const input_iids_t *iids, const IID **expected, int size, int todo, int line) +{ + int i; + + if (todo) { + todo_wine + ok_(__FILE__, line)(iids->count == size, "Sequence size mismatch (%d), got (%d)\n", size, iids->count); + } + else + ok_(__FILE__, line)(iids->count == size, "Sequence size mismatch (%d), got (%d)\n", size, iids->count); + + if (iids->count != size) return; + + for (i = 0; i < size; i++) { + ok_(__FILE__, line)(IsEqualGUID(&iids->iids[i], expected[i]), + "Wrong IID(%d), got (%s)\n", i, debugstr_guid(&iids->iids[i])); + } +} +#define ok_iids(got, exp, size, todo) ok_iids_(got, exp, size, todo, __LINE__) + +typedef struct _testinput +{ + const IUnknownVtbl *lpVtbl; + LONG ref; +} testinput; + +static inline testinput *impl_from_IUnknown(IUnknown *iface) +{ + return (testinput *)((char*)iface - FIELD_OFFSET(testinput, lpVtbl)); +} + +static HRESULT WINAPI testinput_QueryInterface(IUnknown *iface, REFIID riid, void** ppvObj) +{ + if (IsEqualGUID( riid, &IID_IUnknown )) + { + *ppvObj = iface; + IUnknown_AddRef(iface); + return S_OK; + } + + input_iids.iids[input_iids.count++] = *riid; + + *ppvObj = NULL; + + return E_NOINTERFACE; +} + +static ULONG WINAPI testinput_AddRef(IUnknown *iface) +{ + testinput *This = impl_from_IUnknown(iface); + return InterlockedIncrement(&This->ref); +} + +static ULONG WINAPI testinput_Release(IUnknown *iface) +{ + testinput *This = impl_from_IUnknown(iface); + LONG ref; + + ref = InterlockedDecrement(&This->ref); + if (ref == 0) + { + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static const struct IUnknownVtbl testinput_vtbl = +{ + testinput_QueryInterface, + testinput_AddRef, + testinput_Release +}; + +static HRESULT testinput_createinstance(void **ppObj) +{ + testinput *input; + + input = HeapAlloc(GetProcessHeap(), 0, sizeof (*input)); + if(!input) return E_OUTOFMEMORY; + + input->lpVtbl = &testinput_vtbl; + input->ref = 1; + + *ppObj = &input->lpVtbl; + + return S_OK; +} static BOOL init_pointers(void) { @@ -45,8 +164,10 @@ static BOOL init_pointers(void) return FALSE; } - pCreateXmlReader = (void*)GetProcAddress(mod, "CreateXmlReader"); - if (!pCreateXmlReader) return FALSE; +#define MAKEFUNC(f) if (!(p##f = (void*)GetProcAddress(mod, #f))) return FALSE; + MAKEFUNC(CreateXmlReader); + MAKEFUNC(CreateXmlReaderInputWithEncodingName); +#undef MAKEFUNC return TRUE; } @@ -56,6 +177,7 @@ static void test_reader_create(void) HRESULT hr; IXmlReader *reader; IMalloc *imalloc; + IUnknown *input; /* crashes native */ if (0) @@ -73,9 +195,65 @@ static void test_reader_create(void) hr = IMalloc_DidAlloc(imalloc, reader); ok(hr != 1, "Expected 0 or -1, got %08x\n", hr); + /* test input interface selection sequence */ + hr = testinput_createinstance((void**)&input); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + input_iids.count = 0; + hr = IXmlReader_SetInput(reader, input); + todo_wine ok(hr == E_NOINTERFACE, "Expected E_NOINTERFACE, got %08x\n", hr); + ok_iids(&input_iids, setinput_full, sizeof(setinput_full)/sizeof(REFIID), TRUE); + + IUnknown_Release(input); + IXmlReader_Release(reader); } +static void test_readerinput(void) +{ + IXmlReaderInput *reader_input; + IUnknown *obj; + IStream *stream; + HRESULT hr; + LONG ref; + + hr = pCreateXmlReaderInputWithEncodingName(NULL, NULL, NULL, FALSE, NULL, NULL); + todo_wine ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); + hr = pCreateXmlReaderInputWithEncodingName(NULL, NULL, NULL, FALSE, NULL, &reader_input); + todo_wine ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); + + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + ref = IStream_AddRef(stream); + ok(ref == 2, "Expected 2, got %d\n", ref); + IStream_Release(stream); + hr = pCreateXmlReaderInputWithEncodingName((IUnknown*)stream, NULL, NULL, FALSE, NULL, &reader_input); + todo_wine ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + if(hr != S_OK) + { + skip("CreateXmlReaderInputWithEncodingName not implemented\n"); + IStream_Release(stream); + return; + } + + /* IXmlReader grabs a stream reference */ + ref = IStream_AddRef(stream); + ok(ref == 3, "Expected 3, got %d\n", ref); + IStream_Release(stream); + + /* IID_IXmlReaderInput */ + /* it returns a kind of private undocumented vtable incompatible with IUnknown, + so it's not a COM interface actually. + Such query will be used only to check if input is really IXmlReaderInput */ + obj = (IUnknown*)0xdeadbeef; + hr = IUnknown_QueryInterface(reader_input, &IID_IXmlReaderInput, (void**)&obj); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + IUnknown_Release(reader_input); + IStream_Release(stream); +} + START_TEST(reader) { HRESULT r; @@ -90,6 +268,7 @@ START_TEST(reader) } test_reader_create(); + test_readerinput(); CoUninitialize(); } diff --git a/dlls/xmllite/xmllite.spec b/dlls/xmllite/xmllite.spec index 9b5a84a..d2d0ff7 100644 --- a/dlls/xmllite/xmllite.spec +++ b/dlls/xmllite/xmllite.spec @@ -1,6 +1,6 @@ @ stdcall CreateXmlReader(ptr ptr ptr) @ stub CreateXmlReaderInputWithEncodingCodePage -@ stub CreateXmlReaderInputWithEncodingName +@ stdcall CreateXmlReaderInputWithEncodingName(ptr ptr ptr long ptr ptr) @ stub CreateXmlWriter @ stub CreateXmlWriterOutputWithEncodingCodePage @ stub CreateXmlWriterOutputWithEncodingName diff --git a/include/xmllite.idl b/include/xmllite.idl index 9ba429f..e00d8c8 100644 --- a/include/xmllite.idl +++ b/include/xmllite.idl @@ -80,3 +80,5 @@ interface IXmlReader : IUnknown /* IXmlReader construction */ cpp_quote("STDAPI CreateXmlReader(REFIID riid, void **ppvObject, IMalloc *pMalloc);") + +typedef IUnknown IXmlReaderInput;
1
0
0
0
Alexandre Julliard : winex11: Use the thread connection to clear the systray icon window.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: baa7eed11c4f67b2daef61979c35232b09cdb471 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=baa7eed11c4f67b2daef61979…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 22 12:44:59 2010 +0100 winex11: Use the thread connection to clear the systray icon window. --- dlls/winex11.drv/systray.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/systray.c b/dlls/winex11.drv/systray.c index bbe6b67..8ed1550 100644 --- a/dlls/winex11.drv/systray.c +++ b/dlls/winex11.drv/systray.c @@ -344,7 +344,7 @@ static BOOL modify_icon( struct tray_icon *icon, NOTIFYICONDATAW *nid ) if (icon->window) { struct x11drv_win_data *data = X11DRV_get_win_data( icon->window ); - if (data) XClearArea( gdi_display, data->client_window, 0, 0, 0, 0, True ); + if (data) XClearArea( thread_display(), data->client_window, 0, 0, 0, 0, True ); } }
1
0
0
0
Alexandre Julliard : kernel32/tests: Add tests for the global flag and its influence on the heap flags.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: dabda7e3ee6e7710ddb7dca1db94ce7d5fd3fcf1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dabda7e3ee6e7710ddb7dca1d…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 22 12:33:24 2010 +0100 kernel32/tests: Add tests for the global flag and its influence on the heap flags. --- dlls/kernel32/tests/heap.c | 151 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 151 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/heap.c b/dlls/kernel32/tests/heap.c index 56f9744..b213339 100644 --- a/dlls/kernel32/tests/heap.c +++ b/dlls/kernel32/tests/heap.c @@ -21,14 +21,25 @@ #include <stdarg.h> #include <stdlib.h> +#include <stdio.h> #include "windef.h" #include "winbase.h" +#include "winreg.h" +#include "winternl.h" #include "wine/test.h" #define MAGIC_DEAD 0xdeadbeef static BOOL (WINAPI *pHeapQueryInformation)(HANDLE, HEAP_INFORMATION_CLASS, PVOID, SIZE_T, PSIZE_T); +static ULONG (WINAPI *pRtlGetNtGlobalFlags)(void); + +struct heap_layout +{ + DWORD unknown[3]; + DWORD flags; + DWORD force_flags; +}; static SIZE_T resize_9x(SIZE_T size) { @@ -467,8 +478,132 @@ static void test_HeapQueryInformation(void) ok(info == 0 || info == 1 || info == 2, "expected 0, 1 or 2, got %u\n", info); } +static void test_debug_heap( const char *argv0, DWORD flags ) +{ + char keyname[MAX_PATH]; + char buffer[MAX_PATH]; + PROCESS_INFORMATION info; + STARTUPINFOA startup; + BOOL ret; + DWORD err; + HKEY hkey; + const char *basename; + + if ((basename = strrchr( argv0, '\\' ))) basename++; + else basename = argv0; + + sprintf( keyname, "SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\Image File Execution Options\\%s", + basename ); + if (!strcmp( keyname + strlen(keyname) - 3, ".so" )) keyname[strlen(keyname) - 3] = 0; + + err = RegCreateKeyA( HKEY_LOCAL_MACHINE, keyname, &hkey ); + ok( !err, "failed to create '%s' error %u\n", keyname, err ); + if (err) return; + + if (flags == 0xdeadbeef) /* magic value for unsetting it */ + RegDeleteValueA( hkey, "GlobalFlag" ); + else + RegSetValueExA( hkey, "GlobalFlag", 0, REG_DWORD, (BYTE *)&flags, sizeof(flags) ); + + memset( &startup, 0, sizeof(startup) ); + startup.cb = sizeof(startup); + + sprintf( buffer, "%s heap.c 0x%x", argv0, flags ); + ret = CreateProcessA( NULL, buffer, NULL, NULL, FALSE, 0, NULL, NULL, &startup, &info ); + ok( ret, "failed to create child process error %u\n", GetLastError() ); + if (ret) + { + winetest_wait_child_process( info.hProcess ); + CloseHandle( info.hThread ); + CloseHandle( info.hProcess ); + } + RegDeleteValueA( hkey, "GlobalFlag" ); + RegCloseKey( hkey ); + RegDeleteKeyA( HKEY_LOCAL_MACHINE, keyname ); +} + +static DWORD heap_flags_from_global_flag( DWORD flag ) +{ + DWORD ret = 0; + + if (flag & FLG_HEAP_ENABLE_TAIL_CHECK) + ret |= HEAP_TAIL_CHECKING_ENABLED; + if (flag & FLG_HEAP_ENABLE_FREE_CHECK) + ret |= HEAP_FREE_CHECKING_ENABLED; + if (flag & FLG_HEAP_VALIDATE_PARAMETERS) + ret |= 0x50000000 | HEAP_TAIL_CHECKING_ENABLED | HEAP_FREE_CHECKING_ENABLED; + if (flag & FLG_HEAP_VALIDATE_ALL) + ret |= 0x30000000 | HEAP_TAIL_CHECKING_ENABLED | HEAP_FREE_CHECKING_ENABLED; + if (flag & FLG_HEAP_DISABLE_COALESCING) + ret |= HEAP_DISABLE_COALESCE_ON_FREE; + if (flag & FLG_HEAP_PAGE_ALLOCS) + ret |= 0x01000000 | HEAP_GROWABLE; + return ret; +} + +static void test_child_heap( const char *arg ) +{ + struct heap_layout *heap = GetProcessHeap(); + DWORD expected = strtoul( arg, 0, 16 ); + + if (expected == 0xdeadbeef) /* expected value comes from Session Manager global flags */ + { + HKEY hkey; + expected = 0; + if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "SYSTEM\\CurrentControlSet\\Control\\Session Manager", &hkey )) + { + char buffer[32]; + DWORD type, size = sizeof(buffer); + + if (!RegQueryValueExA( hkey, "GlobalFlag", 0, &type, (BYTE *)buffer, &size )) + { + if (type == REG_DWORD) expected = *(DWORD *)buffer; + else if (type == REG_SZ) expected = strtoul( buffer, 0, 16 ); + } + RegCloseKey( hkey ); + } + } + if (expected && !pRtlGetNtGlobalFlags()) /* not working on NT4 */ + { + win_skip( "global flags not set\n" ); + return; + } + + ok( pRtlGetNtGlobalFlags() == expected, + "%s: got global flags %08x expected %08x\n", arg, pRtlGetNtGlobalFlags(), expected ); + + if (!(heap->flags & HEAP_GROWABLE) || heap->flags == 0xeeeeeeee) /* vista layout */ + { + if (expected & FLG_HEAP_PAGE_ALLOCS) + ok( heap->flags == 0xeeeeeeee, "%s: got heap flags %08x expected 0xeeeeeeee\n", + arg, heap->flags ); + else + ok( heap->flags == 0, "%s: got heap flags %08x expected 0\n", arg, heap->flags ); + } + else + { + expected = heap_flags_from_global_flag( expected ); + ok( heap->flags == (expected | HEAP_GROWABLE), + "%s: got heap flags %08x expected %08x\n", arg, heap->flags, expected ); + ok( heap->force_flags == (expected & ~0x18000080), + "%s: got heap force flags %08x expected %08x\n", arg, heap->force_flags, expected ); + } +} + START_TEST(heap) { + int argc; + char **argv; + + pRtlGetNtGlobalFlags = (void *)GetProcAddress( GetModuleHandleA("ntdll.dll"), "RtlGetNtGlobalFlags" ); + + argc = winetest_get_mainargs( &argv ); + if (argc >= 3) + { + test_child_heap( argv[2] ); + return; + } + test_heap(); test_obsolete_flags(); @@ -480,4 +615,20 @@ START_TEST(heap) test_sized_HeapReAlloc((1 << 20), (2 << 20)); test_sized_HeapReAlloc((1 << 20), 1); test_HeapQueryInformation(); + + if (pRtlGetNtGlobalFlags) + { + test_debug_heap( argv[0], 0 ); + test_debug_heap( argv[0], FLG_HEAP_ENABLE_TAIL_CHECK ); + test_debug_heap( argv[0], FLG_HEAP_ENABLE_FREE_CHECK ); + test_debug_heap( argv[0], FLG_HEAP_VALIDATE_PARAMETERS ); + test_debug_heap( argv[0], FLG_HEAP_VALIDATE_ALL ); + test_debug_heap( argv[0], FLG_POOL_ENABLE_TAGGING ); + test_debug_heap( argv[0], FLG_HEAP_ENABLE_TAGGING ); + test_debug_heap( argv[0], FLG_HEAP_ENABLE_TAG_BY_DLL ); + test_debug_heap( argv[0], FLG_HEAP_DISABLE_COALESCING ); + test_debug_heap( argv[0], FLG_HEAP_PAGE_ALLOCS ); + test_debug_heap( argv[0], 0xdeadbeef ); + } + else win_skip( "RtlGetNtGlobalFlags not found, skipping heap debug tests\n" ); }
1
0
0
0
Alexandre Julliard : ntdll: Set the heap debug flags based on the GlobalFlag value.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 9055e9e3dd41504431af5e6fcb6be49ef1a7cbc8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9055e9e3dd41504431af5e6fc…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 22 12:33:03 2010 +0100 ntdll: Set the heap debug flags based on the GlobalFlag value. --- dlls/ntdll/heap.c | 33 +++++++++++++++++++++++++++++++++ dlls/ntdll/loader.c | 1 + dlls/ntdll/ntdll_misc.h | 1 + 3 files changed, 35 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/heap.c b/dlls/ntdll/heap.c index adaf693..a1fc764 100644 --- a/dlls/ntdll/heap.c +++ b/dlls/ntdll/heap.c @@ -155,6 +155,12 @@ typedef struct tagHEAP #define HEAP_DEF_SIZE 0x110000 /* Default heap size = 1Mb + 64Kb */ #define COMMIT_MASK 0xffff /* bitmask for commit/decommit granularity */ +/* some undocumented flags (names are made up) */ +#define HEAP_PAGE_ALLOCS 0x01000000 +#define HEAP_VALIDATE 0x10000000 +#define HEAP_VALIDATE_ALL 0x20000000 +#define HEAP_VALIDATE_PARAMS 0x40000000 + static HEAP *processHeap; /* main process heap */ static BOOL HEAP_IsRealArena( HEAP *heapPtr, DWORD flags, LPCVOID block, BOOL quiet ); @@ -1233,6 +1239,32 @@ static BOOL HEAP_IsRealArena( HEAP *heapPtr, /* [in] ptr to the heap */ /*********************************************************************** + * heap_set_debug_flags + */ +void heap_set_debug_flags( HANDLE handle ) +{ + HEAP *heap = HEAP_GetPtr( handle ); + ULONG global_flags = RtlGetNtGlobalFlags(); + ULONG flags = 0; + + if (global_flags & FLG_HEAP_ENABLE_TAIL_CHECK) flags |= HEAP_TAIL_CHECKING_ENABLED; + if (global_flags & FLG_HEAP_ENABLE_FREE_CHECK) flags |= HEAP_FREE_CHECKING_ENABLED; + if (global_flags & FLG_HEAP_DISABLE_COALESCING) flags |= HEAP_DISABLE_COALESCE_ON_FREE; + if (global_flags & FLG_HEAP_PAGE_ALLOCS) flags |= HEAP_PAGE_ALLOCS | HEAP_GROWABLE; + + if (global_flags & FLG_HEAP_VALIDATE_PARAMETERS) + flags |= HEAP_VALIDATE | HEAP_VALIDATE_PARAMS | + HEAP_TAIL_CHECKING_ENABLED | HEAP_FREE_CHECKING_ENABLED; + if (global_flags & FLG_HEAP_VALIDATE_ALL) + flags |= HEAP_VALIDATE | HEAP_VALIDATE_ALL | + HEAP_TAIL_CHECKING_ENABLED | HEAP_FREE_CHECKING_ENABLED; + + heap->flags |= flags; + heap->force_flags |= flags & ~(HEAP_VALIDATE | HEAP_DISABLE_COALESCE_ON_FREE); +} + + +/*********************************************************************** * RtlCreateHeap (NTDLL.@) * * Create a new Heap. @@ -1278,6 +1310,7 @@ HANDLE WINAPI RtlCreateHeap( ULONG flags, PVOID addr, SIZE_T totalSize, SIZE_T c list_init( &processHeap->entry ); } + heap_set_debug_flags( subheap->heap ); return subheap->heap; } diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 1172a86..7bbcf95 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2656,6 +2656,7 @@ void WINAPI LdrInitializeThunk( void *kernel_start, ULONG_PTR unknown2, if ((status = fixup_imports( wm, load_path )) != STATUS_SUCCESS) goto error; if ((status = alloc_process_tls()) != STATUS_SUCCESS) goto error; if ((status = alloc_thread_tls()) != STATUS_SUCCESS) goto error; + heap_set_debug_flags( GetProcessHeap() ); status = wine_call_on_stack( attach_process_dlls, wm, NtCurrentTeb()->Tib.StackBase ); if (status != STATUS_SUCCESS) goto error; diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h index 586250d..c7b721a 100644 --- a/dlls/ntdll/ntdll_misc.h +++ b/dlls/ntdll/ntdll_misc.h @@ -70,6 +70,7 @@ extern void actctx_init(void); extern void virtual_init(void); extern void virtual_init_threading(void); extern void fill_cpu_info(void); +extern void heap_set_debug_flags( HANDLE handle ); /* server support */ extern timeout_t server_start_time;
1
0
0
0
Alexandre Julliard : ntdll: Make it possible to use RtlGetNtGlobalFlags before the TEB is initialized.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: e7810c8bc6ba41851e38e69baf133226188faa3b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e7810c8bc6ba41851e38e69ba…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 22 12:32:40 2010 +0100 ntdll: Make it possible to use RtlGetNtGlobalFlags before the TEB is initialized. --- dlls/ntdll/process.c | 9 --------- dlls/ntdll/thread.c | 12 +++++++++++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/dlls/ntdll/process.c b/dlls/ntdll/process.c index aaf8315..ba51df5 100644 --- a/dlls/ntdll/process.c +++ b/dlls/ntdll/process.c @@ -73,15 +73,6 @@ PEB * WINAPI RtlGetCurrentPeb(void) return NtCurrentTeb()->Peb; } -/****************************************************************************** - * RtlGetNtGlobalFlags [NTDLL.@] - * - */ -ULONG WINAPI RtlGetNtGlobalFlags(void) -{ - return NtCurrentTeb()->Peb->NtGlobalFlag; -} - /*********************************************************************** * __wine_make_process_system (NTDLL.@) * diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c index ef9183a..65fc737 100644 --- a/dlls/ntdll/thread.c +++ b/dlls/ntdll/thread.c @@ -57,6 +57,7 @@ struct startup_info void *entry_arg; }; +static PEB *peb; static PEB_LDR_DATA ldr; static RTL_USER_PROCESS_PARAMETERS params; /* default parameters if no parent */ static WCHAR current_dir[MAX_NT_PATH_LENGTH]; @@ -191,7 +192,6 @@ done: */ HANDLE thread_init(void) { - PEB *peb; TEB *teb; void *addr; SIZE_T size, info_size; @@ -522,6 +522,16 @@ error: } +/****************************************************************************** + * RtlGetNtGlobalFlags (NTDLL.@) + */ +ULONG WINAPI RtlGetNtGlobalFlags(void) +{ + if (!peb) return 0; /* init not done yet */ + return peb->NtGlobalFlag; +} + + /*********************************************************************** * NtOpenThread (NTDLL.@) * ZwOpenThread (NTDLL.@)
1
0
0
0
Jacek Caban : jscript: Skip tests on too old jscript.dll.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 2a81ef06f89894531197103be44ac5e646b2848f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2a81ef06f89894531197103be…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jan 22 01:25:30 2010 +0100 jscript: Skip tests on too old jscript.dll. --- dlls/jscript/tests/activex.c | 32 +++++++++++++++++++++++++++++--- 1 files changed, 29 insertions(+), 3 deletions(-) diff --git a/dlls/jscript/tests/activex.c b/dlls/jscript/tests/activex.c index 4826910..ba3f8bd 100644 --- a/dlls/jscript/tests/activex.c +++ b/dlls/jscript/tests/activex.c @@ -720,6 +720,8 @@ static IActiveScriptParse *create_script(void) hres = CoCreateInstance(&CLSID_JScript, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, &IID_IActiveScript, (void**)&script); ok(hres == S_OK, "CoCreateInstance failed: %08x\n", hres); + if(FAILED(hres)) + return NULL; set_safety_options((IUnknown*)script); @@ -1058,13 +1060,37 @@ static BOOL register_activex(void) return TRUE; } +static BOOL check_jscript(void) +{ + IActiveScriptParse *parser; + BSTR str; + HRESULT hres; + + parser = create_script(); + if(!parser) + return FALSE; + + str = a2bstr("if(!('localeCompare' in String.prototype)) throw 1;"); + hres = IActiveScriptParse64_ParseScriptText(parser, str, NULL, NULL, NULL, 0, 0, 0, NULL, NULL); + SysFreeString(str); + IUnknown_Release(parser); + + return hres == S_OK; +} + START_TEST(activex) { CoInitialize(NULL); - register_activex(); - test_ActiveXObject(); + if(check_jscript()) { + register_activex(); + + test_ActiveXObject(); + + init_registry(FALSE); + }else { + win_skip("Broken engine, probably too old\n"); + } - init_registry(FALSE); CoUninitialize(); }
1
0
0
0
Jacek Caban : mshtml: Added IDispatchEx support for frame element.
by Alexandre Julliard
22 Jan '10
22 Jan '10
Module: wine Branch: master Commit: 65d9ab16507a53eb6577be4f278a1adb67353c87 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=65d9ab16507a53eb6577be4f2…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jan 21 14:48:43 2010 +0100 mshtml: Added IDispatchEx support for frame element. --- dlls/mshtml/dispex.c | 2 ++ dlls/mshtml/htmlframe.c | 21 ++++++++++++++++++++- dlls/mshtml/mshtml_private.h | 2 ++ dlls/mshtml/tests/dom.c | 2 +- 4 files changed, 25 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index be44748..4019a3c 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -92,6 +92,7 @@ static REFIID tid_ids[] = { &DIID_DispHTMLElementCollection, &DIID_DispHTMLFormElement, &DIID_DispHTMLGenericElement, + &DIID_DispHTMLFrameElement, &DIID_DispHTMLIFrame, &DIID_DispHTMLImg, &DIID_DispHTMLInputElement, @@ -133,6 +134,7 @@ static REFIID tid_ids[] = { &IID_IHTMLFrameBase, &IID_IHTMLFrameBase2, &IID_IHTMLGenericElement, + &IID_IHTMLFrameElement3, &IID_IHTMLIFrameElement, &IID_IHTMLImageElementFactory, &IID_IHTMLImgElement, diff --git a/dlls/mshtml/htmlframe.c b/dlls/mshtml/htmlframe.c index 0bf5c4d..99b3f0b 100644 --- a/dlls/mshtml/htmlframe.c +++ b/dlls/mshtml/htmlframe.c @@ -269,6 +269,25 @@ static const NodeImplVtbl HTMLFrameElementImplVtbl = { HTMLFrameElement_bind_to_tree }; +static const tid_t HTMLFrameElement_iface_tids[] = { + IHTMLDOMNode_tid, + IHTMLDOMNode2_tid, + IHTMLElement_tid, + IHTMLElement2_tid, + IHTMLElement3_tid, + IHTMLFrameBase_tid, + IHTMLFrameBase2_tid, + IHTMLFrameElement3_tid, + 0 +}; + +static dispex_static_data_t HTMLFrameElement_dispex = { + NULL, + DispHTMLFrameElement_tid, + NULL, + HTMLFrameElement_iface_tids +}; + HTMLElement *HTMLFrameElement_Create(HTMLDocumentNode *doc, nsIDOMHTMLElement *nselem) { HTMLFrameElement *ret; @@ -278,7 +297,7 @@ HTMLElement *HTMLFrameElement_Create(HTMLDocumentNode *doc, nsIDOMHTMLElement *n ret->framebase.element.node.vtbl = &HTMLFrameElementImplVtbl; ret->lpIHTMLFrameElement3Vtbl = &HTMLFrameElement3Vtbl; - HTMLFrameBase_Init(&ret->framebase, doc, nselem, NULL); + HTMLFrameBase_Init(&ret->framebase, doc, nselem, &HTMLFrameElement_dispex); return &ret->framebase.element; } diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 4529231..0f7930e 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -68,6 +68,7 @@ typedef enum { DispHTMLElementCollection_tid, DispHTMLFormElement_tid, DispHTMLGenericElement_tid, + DispHTMLFrameElement_tid, DispHTMLIFrame_tid, DispHTMLImg_tid, DispHTMLInputElement_tid, @@ -108,6 +109,7 @@ typedef enum { IHTMLFormElement_tid, IHTMLFrameBase_tid, IHTMLFrameBase2_tid, + IHTMLFrameElement3_tid, IHTMLGenericElement_tid, IHTMLIFrameElement_tid, IHTMLImageElementFactory_tid, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 6fa0e29..c818a1d 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -421,7 +421,7 @@ static const elem_type_info_t elem_type_infos[] = { {"TD", td_iids, NULL}, {"IFRAME", iframe_iids, &DIID_DispHTMLIFrame}, {"FORM", form_iids, &DIID_DispHTMLFormElement}, - {"FRAME", frame_iids, NULL} + {"FRAME", frame_iids, &DIID_DispHTMLFrameElement} }; static const char *dbgstr_guid(REFIID riid)
1
0
0
0
← Newer
1
...
22
23
24
25
26
27
28
...
62
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
Results per page:
10
25
50
100
200