wine-commits January 2010

wine-commits@winehq.org

3 participants
615 discussions

Paul Vriens : ntdll: Fix length parameter for NtQueryValueKey (Coccinelle).
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: 2e03013fc0873524a7f8c0c78d455b7f3bac8966 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2e03013fc0873524a7f8c0c78… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 8 09:27:21 2010 +0100 ntdll: Fix length parameter for NtQueryValueKey (Coccinelle). --- dlls/ntdll/relay.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/relay.c b/dlls/ntdll/relay.c index 1981e51..7fd3c35 100644 --- a/dlls/ntdll/relay.c +++ b/dlls/ntdll/relay.c @@ -147,7 +147,7 @@ static const WCHAR **load_list( HKEY hkey, const WCHAR *value ) const WCHAR **list = NULL; RtlInitUnicodeString( &name, value ); - status = NtQueryValueKey( hkey, &name, KeyValuePartialInformation, buffer, sizeof(buffer), &count ); + status = NtQueryValueKey( hkey, &name, KeyValuePartialInformation, buffer, sizeof(initial_buffer), &count ); if (status == STATUS_BUFFER_OVERFLOW) { buffer = RtlAllocateHeap( GetProcessHeap(), 0, count );

1 0

Paul Vriens : d3d9/tests: Fix size parameter for memcmp (Coccinelle).
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: e38e54e3f458260e20142a0b74dddcbab8070f50 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e38e54e3f458260e20142a0b7… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 8 09:31:46 2010 +0100 d3d9/tests: Fix size parameter for memcmp (Coccinelle). --- dlls/d3d9/tests/vertexdeclaration.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3d9/tests/vertexdeclaration.c b/dlls/d3d9/tests/vertexdeclaration.c index 82538ab..72b8f9f 100644 --- a/dlls/d3d9/tests/vertexdeclaration.c +++ b/dlls/d3d9/tests/vertexdeclaration.c @@ -214,7 +214,7 @@ static void test_get_declaration(IDirect3DVertexDeclaration9 *decl_ptr, D3DVERTE ok(hret == D3D_OK && num_elements == expected_num_elements, "GetDeclaration returned: hret 0x%x, num_elements %d. " "Expected hret 0x%x, num_elements %d.\n", hret, num_elements, D3D_OK, expected_num_elements); - i = memcmp(decl, vertex_decl, sizeof(vertex_decl)); + i = memcmp(decl, vertex_decl, sizeof(*vertex_decl)); ok (!i, "Original and returned vertexdeclarations are not the same\n"); ZeroMemory(decl, sizeof(D3DVERTEXELEMENT9) * expected_num_elements); @@ -223,7 +223,7 @@ static void test_get_declaration(IDirect3DVertexDeclaration9 *decl_ptr, D3DVERTE ok(hret == D3D_OK && num_elements == expected_num_elements, "GetDeclaration returned: hret 0x%x, num_elements %d. " "Expected hret 0x%x, num_elements %d.\n", hret, num_elements, D3D_OK, expected_num_elements); - i = memcmp(decl, vertex_decl, sizeof(vertex_decl)); + i = memcmp(decl, vertex_decl, sizeof(*vertex_decl)); ok (!i, "Original and returned vertexdeclarations are not the same\n"); HeapFree(GetProcessHeap(), 0, decl);

1 0

Paul Vriens : shell32: Fix length parameter for ZeroMemory (Coccinelle).
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: cb5e6f378a2465b439aa0acfa1e25e5319f72688 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb5e6f378a2465b439aa0acfa… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 8 09:23:40 2010 +0100 shell32: Fix length parameter for ZeroMemory (Coccinelle). --- dlls/shell32/shfldr_fs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shfldr_fs.c b/dlls/shell32/shfldr_fs.c index 77a98f3..091c1e0 100644 --- a/dlls/shell32/shfldr_fs.c +++ b/dlls/shell32/shfldr_fs.c @@ -1504,7 +1504,7 @@ IFSFldr_PersistFolder3_GetFolderTargetInfo (IPersistFolder3 * iface, { IGenericSFImpl *This = impl_from_IPersistFolder3(iface); FIXME ("(%p)->(%p)\n", This, ppfti); - ZeroMemory (ppfti, sizeof (ppfti)); + ZeroMemory (ppfti, sizeof (*ppfti)); return E_NOTIMPL; }

1 0

Paul Vriens : wined3d: Fix use of memset (Coccinelle).
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: c8681f885d18e77ae227768e69a05e7369d45b89 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c8681f885d18e77ae227768e6… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 8 09:18:23 2010 +0100 wined3d: Fix use of memset (Coccinelle). --- dlls/wined3d/drawprim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index dbeb799..e8521bc 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -1100,7 +1100,7 @@ HRESULT tesselate_rectpatch(IWineD3DDeviceImpl *This, if(patch->has_texcoords) { vtxStride += 4 * sizeof(float); } - memset(&patch->strided, 0, sizeof(&patch->strided)); + memset(&patch->strided, 0, sizeof(patch->strided)); patch->strided.position.format = WINED3DFMT_R32G32B32_FLOAT; patch->strided.position.lpData = (BYTE *) patch->mem; patch->strided.position.dwStride = vtxStride;

1 0

Marcus Meissner : setupapi: Avoid NULL dereference in error path (Coverity) .
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: 1b27af164c3682419b636f5eb08647f3f6bb7e55 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b27af164c3682419b636f5eb… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Jan 8 09:20:34 2010 +0100 setupapi: Avoid NULL dereference in error path (Coverity). --- dlls/setupapi/parser.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/setupapi/parser.c b/dlls/setupapi/parser.c index 7f581bd..744ee4c 100644 --- a/dlls/setupapi/parser.c +++ b/dlls/setupapi/parser.c @@ -1024,7 +1024,7 @@ static struct inf_file *parse_file( HANDLE handle, const WCHAR *class, DWORD sty UnmapViewOfFile( buffer ); if (err) { - free_inf_file( file ); + if (file) free_inf_file( file ); SetLastError( err ); file = NULL; }

1 0

Marcus Meissner : winex11: Remove more superflous NULL checks (Coverity).
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: 6fb5e61afbae235dcabd4552e32ffbcbc29ad8d7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6fb5e61afbae235dcabd4552e… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Jan 8 09:24:18 2010 +0100 winex11: Remove more superflous NULL checks (Coverity). --- dlls/winex11.drv/palette.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/palette.c b/dlls/winex11.drv/palette.c index a02501f..cbdf2d1 100644 --- a/dlls/winex11.drv/palette.c +++ b/dlls/winex11.drv/palette.c @@ -925,7 +925,7 @@ int X11DRV_PALETTE_ToPhysical( X11DRV_PDEVICE *physDev, COLORREF color ) /* fall through to RGB */ case 0: /* RGB */ - if (physDev && (physDev->depth == 1) ) + if (physDev->depth == 1) { int white = 1; RGBQUAD table[2]; @@ -981,7 +981,7 @@ int X11DRV_PALETTE_ToPhysical( X11DRV_PDEVICE *physDev, COLORREF color ) /* fall through to RGB */ case 0: /* RGB */ - if (physDev && (physDev->depth == 1) ) + if (physDev->depth == 1) { int white = 1; RGBQUAD table[2];

1 0

Christian Costa : d3drm: Implement stubbed IDirect3DRM interface.
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: a59922ab55b08028a4dd1ea83510756199e2c99c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a59922ab55b08028a4dd1ea83… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Thu Jan 7 22:43:25 2010 +0100 d3drm: Implement stubbed IDirect3DRM interface. --- dlls/d3drm/Makefile.in | 3 +- dlls/d3drm/d3drm.c | 431 ++++++++++++++++++++++++++++++++++++++++++++ dlls/d3drm/d3drm_main.c | 6 +- dlls/d3drm/d3drm_private.h | 31 ++++ 4 files changed, 468 insertions(+), 3 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a59922ab55b08028a4dd1…

1 0

Alexandre Julliard : server: Don't dump more than 1024 bytes in a trace.
by Alexandre Julliard 08 Jan '10

08 Jan '10

Module: wine Branch: master Commit: b824fe05f4348ed6a2af45c4320d6eaf85eb3975 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b824fe05f4348ed6a2af45c43… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 7 20:27:17 2010 +0100 server: Don't dump more than 1024 bytes in a trace. --- server/trace.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/server/trace.c b/server/trace.c index 6cb4cc9..df47e8f 100644 --- a/server/trace.c +++ b/server/trace.c @@ -373,7 +373,7 @@ static void dump_varargs_user_handles( const char *prefix, data_size_t size ) static void dump_varargs_bytes( const char *prefix, data_size_t size ) { const unsigned char *data = cur_data; - data_size_t len = size; + data_size_t len = min( 1024, size ); fprintf( stderr,"%s{", prefix ); while (len > 0) @@ -381,6 +381,7 @@ static void dump_varargs_bytes( const char *prefix, data_size_t size ) fprintf( stderr, "%02x", *data++ ); if (--len) fputc( ',', stderr ); } + if (size > 1024) fprintf( stderr, "...(total %u)", size ); fputc( '}', stderr ); remove_data( size ); }

1 0

Marcus Meissner : winex11.drv: physDev cannot be NULL (Coverity).
by Alexandre Julliard 07 Jan '10

07 Jan '10

Module: wine Branch: master Commit: 065fa22adc39f2cd594ee5c8d9234d3a054af0de URL: http://source.winehq.org/git/wine.git/?a=commit;h=065fa22adc39f2cd594ee5c8d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Jan 6 18:58:55 2010 +0100 winex11.drv: physDev cannot be NULL (Coverity). --- dlls/winex11.drv/palette.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/palette.c b/dlls/winex11.drv/palette.c index 81bb73b..a02501f 100644 --- a/dlls/winex11.drv/palette.c +++ b/dlls/winex11.drv/palette.c @@ -881,7 +881,7 @@ static inline BOOL colour_is_brighter(RGBQUAD c1, RGBQUAD c2) int X11DRV_PALETTE_ToPhysical( X11DRV_PDEVICE *physDev, COLORREF color ) { WORD index = 0; - HPALETTE hPal = physDev ? GetCurrentObject(physDev->hdc, OBJ_PAL ) : GetStockObject(DEFAULT_PALETTE); + HPALETTE hPal = GetCurrentObject(physDev->hdc, OBJ_PAL ); unsigned char spec_type = color >> 24; int *mapping = palette_get_mapping( hPal ); PALETTEENTRY entry;

1 0

Nikolay Sivov : shell32/shelllink: Fix some string buffers leaks.
by Alexandre Julliard 07 Jan '10

07 Jan '10

Module: wine Branch: master Commit: 9a53cb52637f9856041eb70f17c1369004a5d8e1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9a53cb52637f9856041eb70f1… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Jan 7 16:00:50 2010 +0300 shell32/shelllink: Fix some string buffers leaks. --- dlls/shell32/shelllink.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c index 6dd62a7..e304058 100644 --- a/dlls/shell32/shelllink.c +++ b/dlls/shell32/shelllink.c @@ -303,7 +303,10 @@ static ULONG ShellLink_Release( IShellLinkImpl *This ) HeapFree(GetProcessHeap(), 0, This->sArgs); HeapFree(GetProcessHeap(), 0, This->sWorkDir); HeapFree(GetProcessHeap(), 0, This->sDescription); - HeapFree(GetProcessHeap(),0,This->sPath); + HeapFree(GetProcessHeap(), 0, This->sPath); + HeapFree(GetProcessHeap(), 0, This->sPathRel); + HeapFree(GetProcessHeap(), 0, This->sProduct); + HeapFree(GetProcessHeap(), 0, This->sComponent); if (This->site) IUnknown_Release( This->site );

1 0

← Newer
1
...
46
47
48
49
50
51
52
...
62
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2010