wine-commits December 2010

wine-commits@winehq.org

2 participants
1099 discussions

Andrew Nguyen : wineboot: Set a placeholder ProcessorNameString value in the volatile CPU registry keys .
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 1bffb577e33155bb153ee35886349029e35173d3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1bffb577e33155bb153ee3588… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Dec 27 06:54:24 2010 -0600 wineboot: Set a placeholder ProcessorNameString value in the volatile CPU registry keys. --- programs/wineboot/wineboot.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 1793a68..47a9bf1 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -175,6 +175,7 @@ static void create_hardware_registry_keys(void) static const WCHAR cpuW[] = {'C','e','n','t','r','a','l','P','r','o','c','e','s','s','o','r',0}; static const WCHAR FeatureSetW[] = {'F','e','a','t','u','r','e','S','e','t',0}; static const WCHAR IdentifierW[] = {'I','d','e','n','t','i','f','i','e','r',0}; + static const WCHAR ProcessorNameStringW[] = {'P','r','o','c','e','s','s','o','r','N','a','m','e','S','t','r','i','n','g',0}; static const WCHAR SysidW[] = {'A','T',' ','c','o','m','p','a','t','i','b','l','e',0}; static const WCHAR mhzKeyW[] = {'~','M','H','z',0}; static const WCHAR VendorIdentifierW[] = {'V','e','n','d','o','r','I','d','e','n','t','i','f','i','e','r',0}; @@ -183,6 +184,8 @@ static void create_hardware_registry_keys(void) static const WCHAR PercentDW[] = {'%','d',0}; static const WCHAR IntelCpuDescrW[] = {'x','8','6',' ','F','a','m','i','l','y',' ','%','d',' ','M','o','d','e','l',' ','%','d', ' ','S','t','e','p','p','i','n','g',' ','%','d',0}; + static const WCHAR IntelCpuStringW[] = {'I','n','t','e','l','(','R',')',' ','P','e','n','t','i','u','m','(','R',')',' ','4',' ', + 'C','P','U',' ','2','.','4','0','G','H','z',0}; unsigned int i; HKEY hkey, system_key, cpu_key, fpu_key; SYSTEM_CPU_INFORMATION sci; @@ -220,6 +223,7 @@ static void create_hardware_registry_keys(void) RegSetValueExW( hkey, FeatureSetW, 0, REG_DWORD, (BYTE *)&sci.FeatureSet, sizeof(DWORD) ); set_reg_value( hkey, IdentifierW, idW ); /*TODO; report amd's properly*/ + set_reg_value( hkey, ProcessorNameStringW, IntelCpuStringW ); set_reg_value( hkey, VendorIdentifierW, VenidIntelW ); RegSetValueExW( hkey, mhzKeyW, 0, REG_DWORD, (BYTE *)&power_info.MaxMhz, sizeof(DWORD) ); RegCloseKey( hkey );

1 0

Andrew Nguyen : wineboot: Set the FeatureSet value in the volatile CPU registry keys.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 0c8820563c8df325c6ab8c54fbbbdcb49491bf7b URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c8820563c8df325c6ab8c54f… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Dec 27 06:54:14 2010 -0600 wineboot: Set the FeatureSet value in the volatile CPU registry keys. --- programs/wineboot/wineboot.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 28292ad..1793a68 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -173,6 +173,7 @@ static void create_hardware_registry_keys(void) 'S','y','s','t','e','m',0}; static const WCHAR fpuW[] = {'F','l','o','a','t','i','n','g','P','o','i','n','t','P','r','o','c','e','s','s','o','r',0}; static const WCHAR cpuW[] = {'C','e','n','t','r','a','l','P','r','o','c','e','s','s','o','r',0}; + static const WCHAR FeatureSetW[] = {'F','e','a','t','u','r','e','S','e','t',0}; static const WCHAR IdentifierW[] = {'I','d','e','n','t','i','f','i','e','r',0}; static const WCHAR SysidW[] = {'A','T',' ','c','o','m','p','a','t','i','b','l','e',0}; static const WCHAR mhzKeyW[] = {'~','M','H','z',0}; @@ -216,6 +217,7 @@ static void create_hardware_registry_keys(void) if (!RegCreateKeyExW( cpu_key, numW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &hkey, NULL )) { + RegSetValueExW( hkey, FeatureSetW, 0, REG_DWORD, (BYTE *)&sci.FeatureSet, sizeof(DWORD) ); set_reg_value( hkey, IdentifierW, idW ); /*TODO; report amd's properly*/ set_reg_value( hkey, VendorIdentifierW, VenidIntelW );

1 0

Jacek Caban : jscript: Added ScriptEngine*Version functions implementation.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: f8afae75b5727462081e15b662f9bdf809229f8d URL: http://source.winehq.org/git/wine.git/?a=commit;h=f8afae75b5727462081e15b66… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 27 13:38:08 2010 +0100 jscript: Added ScriptEngine*Version functions implementation. --- dlls/jscript/global.c | 27 +++++++++++++++++++++------ dlls/jscript/resource.h | 4 ++++ dlls/jscript/tests/api.js | 3 +++ 3 files changed, 28 insertions(+), 6 deletions(-) diff --git a/dlls/jscript/global.c b/dlls/jscript/global.c index 0d922c8..f959577 100644 --- a/dlls/jscript/global.c +++ b/dlls/jscript/global.c @@ -727,22 +727,37 @@ static HRESULT JSGlobal_ScriptEngine(script_ctx_t *ctx, vdisp_t *jsthis, WORD fl static HRESULT JSGlobal_ScriptEngineMajorVersion(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + TRACE("\n"); + + if(retv) { + V_VT(retv) = VT_I4; + V_I4(retv) = JSCRIPT_MAJOR_VERSION; + } + return S_OK; } static HRESULT JSGlobal_ScriptEngineMinorVersion(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + TRACE("\n"); + + if(retv) { + V_VT(retv) = VT_I4; + V_I4(retv) = JSCRIPT_MINOR_VERSION; + } + return S_OK; } static HRESULT JSGlobal_ScriptEngineBuildVersion(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + TRACE("\n"); + + if(retv) { + V_VT(retv) = VT_I4; + V_I4(retv) = JSCRIPT_BUILD_VERSION; + } + return S_OK; } static HRESULT JSGlobal_CollectGarbage(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/resource.h b/dlls/jscript/resource.h index be569e0..c4153a4 100644 --- a/dlls/jscript/resource.h +++ b/dlls/jscript/resource.h @@ -18,6 +18,10 @@ #include <windef.h> +#define JSCRIPT_MAJOR_VERSION 5 +#define JSCRIPT_MINOR_VERSION 8 +#define JSCRIPT_BUILD_VERSION 16475 + #define IDS_TO_PRIMITIVE 0x0001 #define IDS_INVALID_CALL_ARG 0x0005 #define IDS_SUBSCRIPT_OUT_OF_RANGE 0x0009 diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index aed6c84..e4dc7c4 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -20,6 +20,9 @@ var tmp, i; ok(ScriptEngine() === "JScript", "ScriptEngine() = " + ScriptEngine()); ok(ScriptEngine(3) === "JScript", "ScriptEngine(3) = " + ScriptEngine(3)); +ok(ScriptEngineMajorVersion() === ScriptEngineMajorVersion(2), "ScriptEngineMajorVersion() !== ScriptEngineMajorVersion(2)"); +ok(ScriptEngineMinorVersion() === ScriptEngineMinorVersion(2), "ScriptEngineMinorVersion() !== ScriptEngineMinorVersion(2)"); +ok(ScriptEngineBuildVersion() === ScriptEngineBuildVersion(2), "ScriptEngineBuildVersion() !== ScriptEngineBuildVersion(2)"); i = parseInt("0"); ok(i === 0, "parseInt('0') = " + i);

1 0

Jacek Caban : jscript: Added ScriptEngine() implementation.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 36fe9472c26f21cd1c4b2ce4a343a64746e3aae3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=36fe9472c26f21cd1c4b2ce4a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 27 13:37:54 2010 +0100 jscript: Added ScriptEngine() implementation. --- dlls/jscript/global.c | 18 ++++++++++++++++-- dlls/jscript/tests/api.js | 3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/global.c b/dlls/jscript/global.c index 81aee50..0d922c8 100644 --- a/dlls/jscript/global.c +++ b/dlls/jscript/global.c @@ -706,8 +706,22 @@ static HRESULT JSGlobal_GetObject(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags static HRESULT JSGlobal_ScriptEngine(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + static const WCHAR JScriptW[] = {'J','S','c','r','i','p','t',0}; + + TRACE("\n"); + + if(retv) { + BSTR ret; + + ret = SysAllocString(JScriptW); + if(!ret) + return E_OUTOFMEMORY; + + V_VT(retv) = VT_BSTR; + V_BSTR(retv) = ret; + } + + return S_OK; } static HRESULT JSGlobal_ScriptEngineMajorVersion(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index ba5235d..aed6c84 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -18,6 +18,9 @@ var tmp, i; +ok(ScriptEngine() === "JScript", "ScriptEngine() = " + ScriptEngine()); +ok(ScriptEngine(3) === "JScript", "ScriptEngine(3) = " + ScriptEngine(3)); + i = parseInt("0"); ok(i === 0, "parseInt('0') = " + i); i = parseInt("123");

1 0

Timo Teräs : iphlpapi: Fix GetAdaptersAddresses return values.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: bfc8832ccb633ea1e8dbdcd31c24d7fbae3c5315 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bfc8832ccb633ea1e8dbdcd31… Author: Timo Teräs <timo.teras(a)iki.fi> Date: Mon Dec 27 09:56:21 2010 +0200 iphlpapi: Fix GetAdaptersAddresses return values. --- dlls/iphlpapi/iphlpapi_main.c | 5 ++++- dlls/iphlpapi/tests/iphlpapi.c | 21 ++++++++++++++------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index d734c39..3995a17 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -1115,10 +1115,13 @@ ULONG WINAPI GetAdaptersAddresses(ULONG family, ULONG flags, PVOID reserved, { if (aa->IfType != IF_TYPE_SOFTWARE_LOOPBACK && aa->OperStatus == IfOperStatusUp) aa->DnsSuffix = dnsSuffix; + else + aa->DnsSuffix = (WCHAR *)((BYTE*)dnsSuffix + dns_suffix_size - 2); } ret = ERROR_SUCCESS; } - if (*buflen < total_size) ret = ERROR_BUFFER_OVERFLOW; + else + ret = ERROR_BUFFER_OVERFLOW; *buflen = total_size; TRACE("num adapters %u\n", table->numIndexes); diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c index 823e596..a747423 100644 --- a/dlls/iphlpapi/tests/iphlpapi.c +++ b/dlls/iphlpapi/tests/iphlpapi.c @@ -819,7 +819,7 @@ static void testWin2KFunctions(void) static void test_GetAdaptersAddresses(void) { ULONG ret, size; - IP_ADAPTER_ADDRESSES *aa; + IP_ADAPTER_ADDRESSES *aa, *ptr; IP_ADAPTER_UNICAST_ADDRESS *ua; if (!gGetAdaptersAddresses) @@ -831,17 +831,25 @@ static void test_GetAdaptersAddresses(void) ret = gGetAdaptersAddresses(AF_UNSPEC, 0, NULL, NULL, NULL); ok(ret == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER got %u\n", ret); - size = 0; + /* size should be ignored and overwritten if buffer is NULL */ + size = 0x7fffffff; ret = gGetAdaptersAddresses(AF_UNSPEC, 0, NULL, NULL, &size); ok(ret == ERROR_BUFFER_OVERFLOW, "expected ERROR_BUFFER_OVERFLOW, got %u\n", ret); if (ret != ERROR_BUFFER_OVERFLOW) return; - aa = HeapAlloc(GetProcessHeap(), 0, size); - ret = gGetAdaptersAddresses(AF_UNSPEC, 0, NULL, aa, &size); + ptr = HeapAlloc(GetProcessHeap(), 0, size); + ret = gGetAdaptersAddresses(AF_UNSPEC, 0, NULL, ptr, &size); ok(!ret, "expected ERROR_SUCCESS got %u\n", ret); - while (!ret && winetest_debug > 1 && aa) + for (aa = ptr; !ret && aa; aa = aa->Next) { + ok(aa->DnsSuffix != NULL, "DnsSuffix is not a valid pointer\n"); + ok(aa->Description != NULL, "Description is not a valid pointer\n"); + ok(aa->FriendlyName != NULL, "FriendlyName is not a valid pointer\n"); + + if (winetest_debug <= 1) + continue; + trace("Length: %u\n", S(U(*aa)).Length); trace("IfIndex: %u\n", S(U(*aa)).IfIndex); trace("Next: %p\n", aa->Next); @@ -877,9 +885,8 @@ static void test_GetAdaptersAddresses(void) trace("IfType: %u\n", aa->IfType); trace("OperStatus: %u\n", aa->OperStatus); trace("\n"); - aa = aa->Next; } - HeapFree(GetProcessHeap(), 0, aa); + HeapFree(GetProcessHeap(), 0, ptr); } START_TEST(iphlpapi)

1 0

Hwang YunSong : msrle32: Update Korean resource.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 8dceb07620fa53cb6a70da1edf44244b6b27f3c7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8dceb07620fa53cb6a70da1ed… Author: Hwang YunSong <hys545(a)dreamwiz.com> Date: Mon Dec 27 11:24:11 2010 +0900 msrle32: Update Korean resource. --- dlls/msrle32/msrle_Ko.rc | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/msrle32/msrle_Ko.rc b/dlls/msrle32/msrle_Ko.rc index b804e32..8a170b3 100644 --- a/dlls/msrle32/msrle_Ko.rc +++ b/dlls/msrle32/msrle_Ko.rc @@ -1,7 +1,7 @@ /* * Korean resource file for MS-RLE * - * Copyright 2005 YunSong Hwang + * Copyright 2005,2010 YunSong Hwang * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -20,11 +20,13 @@ #include "msrle_private.h" +#pragma code_page(65001) + LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT STRINGTABLE { IDS_NAME "WINE-MS-RLE" - IDS_DESCRIPTION "Wine MS-RLE �� ڵ�" - IDS_ABOUT "Wine MS-RLE �� ڵ�\nCopyright 2002 by Michael Gunnewig" + IDS_DESCRIPTION "Wine MS-RLE 비디오 코덱" + IDS_ABOUT "Wine MS-RLE 비디오 코덱\nCopyright 2002 by Michael Gunnewig" }

1 0

Hwang YunSong : msi: Update Korean resource.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: a0639d004d79ae1feb75355b8811fc2b16ed55cd URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0639d004d79ae1feb75355b8… Author: Hwang YunSong <hys545(a)dreamwiz.com> Date: Mon Dec 27 11:21:27 2010 +0900 msi: Update Korean resource. --- dlls/msi/msi_Ko.rc | 40 +++++++++++++++++++++------------------- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/dlls/msi/msi_Ko.rc b/dlls/msi/msi_Ko.rc index 346e9be..7212892 100644 --- a/dlls/msi/msi_Ko.rc +++ b/dlls/msi/msi_Ko.rc @@ -22,43 +22,45 @@ #include "windef.h" +#pragma code_page(65001) + LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT STRINGTABLE { - 4 " �� ġ ��Ű�� ϴ�. �� θ� Ȯ��ϰ� �ٽ� �õ��Ͻʽÿ�." - 5 "%s ��θ� ã�� ϴ�" - 9 "��ũ %s ��" + 4 " 지정한 설치 패키지를 열 수 없습니다. 파일 경로를 확인하고 다시 시도하십시오." + 5 "%s 경로를 찾을수 없습니다" + 9 "디스크 %s 삽입" 10 "Windows Installer %s\n\n" \ - "��:\n" \ - "msiexec �� {�ʼ� �Ű��} [�� Ű��]\n\n" \ - "��ǰ ��ġ:\n" \ + "사용법:\n" \ + "msiexec 명령 {필수 매개변수} [선택적 매개변수]\n\n" \ + "제품 설치:\n" \ "\t/i {package|productcode} [property]\n" \ "\t/package {package|productcode} [property]\n" \ "\t/a package [property]\n" \ - "��ġ ��:\n" \ + "설치 복구:\n" \ "\t/f[p|o|e|d|c|a|u|m|s|v] {package|productcode}\n" \ - "��ǰ ��:\n" \ + "제품 제거:\n" \ "\t/uninstall {package|productcode} [property]\n" \ "\t/x {package|productcode} [property]\n" \ - "��ǰ �˸��:\n" \ + "제품 알리기:\n" \ "\t/j[u|m] package [/t transform] [/g languageid]\n" \ - "��ġ �߰�:\n" \ + "패치 추가:\n" \ "\t/p patchpackage [property]\n" \ "\t/p patchpackage /a package [property]\n" \ - "�� ɾ �� Log �� UI �� :\n" \ + "위의 명령어를 위한 Log 와 UI 한정자 :\n" \ "\t/l[*][i|w|e|a|r|u|c|m|o|p|v|][+|!] logfile\n" \ "\t/q{|n|b|r|f|n+|b+|b-}\n" \ - "MSI �� :\n" \ + "MSI 서비스 등록:\n" \ "\t/y\n" \ - "MSI �� :\n" \ + "MSI 서비스 등록 해제:\n" \ "\t/z\n" \ - "�� :\n" \ + "도움말 보기:\n" \ "\t/help\n" \ "\t/?\n" - 11 "%s�� ϴ� �� Է��ϼ��" - 12 "�� κ�(feature)�� ġ ��" - 13 "�� κ�(feature)�� Ʈ��ũ ��̺�" - 14 "�κ�(feature)��:" - 15 " %s�� ϴ� �� " + 11 "%s를 포함하는 폴더를 입력하세여" + 12 "빠진 부분(feature)을 위한 설치 원본" + 13 "빠진 부분(feature)을 위한 네트워크 드라이브" + 14 "부분(feature)에서:" + 15 " %s를 포함하는 폴더 선택" }

1 0

Greg Geldorp : spoolss/tests: Skip tests on Win7.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: c1dc5f887989544ae22eb4ce48b066f61c8d617e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1dc5f887989544ae22eb4ce4… Author: Greg Geldorp <ggeldorp(a)vmware.com> Date: Mon Dec 27 12:35:49 2010 +0100 spoolss/tests: Skip tests on Win7. --- dlls/spoolss/tests/spoolss.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/dlls/spoolss/tests/spoolss.c b/dlls/spoolss/tests/spoolss.c index 6a2711e..b7d71d6 100644 --- a/dlls/spoolss/tests/spoolss.c +++ b/dlls/spoolss/tests/spoolss.c @@ -62,6 +62,16 @@ static LPCSTR load_functions(void) if (!pSplInitializeWinSpoolDrv) return ptr; + /* Calling BuildOtherNamesFromMachineName or SplInitializeWinSpoolDrv on + * Win7 results in a breakpoint exception. If you continue after hitting + * the breakpoint, the functions fail with ERROR_NOT_SUPPORTED. So we + * just skip the tests on Win7, since they won't provide any useful info. + * To detect Win7, we check whether UnloadDriver exists (it doesn't on + * Win7, but does exist on earlier Windows versions) */ + ptr = "UnloadDriver"; + if (GetProcAddress(hspl, ptr) == NULL) return ptr; + + ptr = "winspool.drv"; hwinspool = LoadLibraryA(ptr); if (!hwinspool) return ptr;

1 0

André Hentschel : setupapi/tests: Don' t test function directly when reporting GetLastError().
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 57aa778e2d4105ac10774aa686a695a286f8565e URL: http://source.winehq.org/git/wine.git/?a=commit;h=57aa778e2d4105ac10774aa68… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Dec 25 00:07:01 2010 +0100 setupapi/tests: Don't test function directly when reporting GetLastError(). --- dlls/setupapi/tests/misc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/setupapi/tests/misc.c b/dlls/setupapi/tests/misc.c index 35b21d1..59a8d6b 100644 --- a/dlls/setupapi/tests/misc.c +++ b/dlls/setupapi/tests/misc.c @@ -328,7 +328,8 @@ static void test_SetupCopyOEMInf(void) { /* Win9x/WinMe */ SetLastError(0xdeadbeef); - ok(DeleteFileA(dest), "Failed to delete file '%s' : %d\n", dest, GetLastError()); + res = DeleteFileA(dest); + ok(res, "Failed to delete file '%s' : %d\n", dest, GetLastError()); /* On WinMe we also need to remove the .pnf file */ *(strrchr(dest, '.') + 1) = 'p';

1 0

André Hentschel : setupapi/tests: Better clean up if SetupUninstallOEMInf fails.
by Alexandre Julliard 27 Dec '10

27 Dec '10

Module: wine Branch: master Commit: 424fa9a7f333363946f83e2c7b5e13a6eaf78256 URL: http://source.winehq.org/git/wine.git/?a=commit;h=424fa9a7f333363946f83e2c7… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Dec 25 00:05:35 2010 +0100 setupapi/tests: Better clean up if SetupUninstallOEMInf fails. --- dlls/setupapi/tests/misc.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/setupapi/tests/misc.c b/dlls/setupapi/tests/misc.c index f2d885d..35b21d1 100644 --- a/dlls/setupapi/tests/misc.c +++ b/dlls/setupapi/tests/misc.c @@ -315,7 +315,14 @@ static void test_SetupCopyOEMInf(void) char *destfile = strrchr(dest, '\\') + 1; SetLastError(0xdeadbeef); - ok(pSetupUninstallOEMInfA(destfile, 0, NULL), "Failed to uninstall '%s' : %d\n", destfile, GetLastError()); + res = pSetupUninstallOEMInfA(destfile, 0, NULL); + ok(res, "Failed to uninstall '%s' : %d\n", destfile, GetLastError()); + if(!res) + { + SetLastError(0xdeadbeef); + res = DeleteFileA(dest); + ok(res, "Failed to delete file '%s' : %d\n", dest, GetLastError()); + } } else {

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits December 2010