winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2010
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1099 discussions
Start a n
N
ew thread
Henri Verbeet : wined3d: Pass an IWineD3DBaseShaderImpl pointer to shader_get_registers_used().
by Alexandre Julliard
15 Dec '10
15 Dec '10
Module: wine Branch: master Commit: 51f06dcf0c7d65bae6f88fefc6f8741a99d5b5e6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=51f06dcf0c7d65bae6f88fefc…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Dec 14 18:30:59 2010 +0100 wined3d: Pass an IWineD3DBaseShaderImpl pointer to shader_get_registers_used(). --- dlls/wined3d/shader.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 31ece02..0a0aae8 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -448,11 +448,10 @@ static unsigned int get_instr_extra_regcount(enum WINED3D_SHADER_INSTRUCTION_HAN } /* Note that this does not count the loop register as an address register. */ -static HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3d_shader_frontend *fe, +static HRESULT shader_get_registers_used(IWineD3DBaseShaderImpl *shader, const struct wined3d_shader_frontend *fe, struct wined3d_shader_reg_maps *reg_maps, struct wined3d_shader_signature_element *input_signature, struct wined3d_shader_signature_element *output_signature, const DWORD *byte_code, DWORD constf_size) { - IWineD3DBaseShaderImpl *shader = (IWineD3DBaseShaderImpl *)iface; unsigned int cur_loop_depth = 0, max_loop_depth = 0; void *fe_data = shader->baseShader.frontend_data; struct wined3d_shader_version shader_version; @@ -1607,7 +1606,7 @@ static HRESULT shader_set_function(IWineD3DBaseShaderImpl *shader, const DWORD * list_init(&shader->baseShader.constantsI); /* Second pass: figure out which registers are used, what the semantics are, etc. */ - hr = shader_get_registers_used((IWineD3DBaseShader *)shader, fe, + hr = shader_get_registers_used(shader, fe, reg_maps, shader->baseShader.input_signature, shader->baseShader.output_signature, byte_code, float_const_count); if (FAILED(hr)) return hr;
1
0
0
0
Henri Verbeet : wined3d: Pass implementation pointers to get_glsl_program_entry().
by Alexandre Julliard
15 Dec '10
15 Dec '10
Module: wine Branch: master Commit: c492ec196e4e8984ffc0068fb244315dec3756ea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c492ec196e4e8984ffc0068fb…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Dec 14 18:30:58 2010 +0100 wined3d: Pass implementation pointers to get_glsl_program_entry(). --- dlls/wined3d/glsl_shader.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index e6d1b86..6062231 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -3703,13 +3703,14 @@ static void add_glsl_program_entry(struct shader_glsl_priv *priv, struct glsl_sh } static struct glsl_shader_prog_link *get_glsl_program_entry(struct shader_glsl_priv *priv, - IWineD3DVertexShader *vshader, IWineD3DPixelShader *pshader, struct vs_compile_args *vs_args, - struct ps_compile_args *ps_args) { + IWineD3DVertexShaderImpl *vshader, IWineD3DPixelShaderImpl *pshader, + struct vs_compile_args *vs_args, struct ps_compile_args *ps_args) +{ struct wine_rb_entry *entry; glsl_program_key_t key; - key.vshader = (IWineD3DVertexShaderImpl *)vshader; - key.pshader = (IWineD3DPixelShaderImpl *)pshader; + key.vshader = vshader; + key.pshader = pshader; key.vs_args = *vs_args; key.ps_args = *ps_args; @@ -4302,8 +4303,7 @@ static void set_glsl_shader_program(const struct wined3d_context *context, if (vshader) find_vs_compile_args(state, vshader, &vs_compile_args); if (pshader) find_ps_compile_args(state, pshader, &ps_compile_args); - entry = get_glsl_program_entry(priv, (IWineD3DVertexShader *)vshader, (IWineD3DPixelShader *)pshader, - &vs_compile_args, &ps_compile_args); + entry = get_glsl_program_entry(priv, vshader, pshader, &vs_compile_args, &ps_compile_args); if (entry) { priv->glsl_program = entry;
1
0
0
0
Alexandre Julliard : wine.inf: Don' t set the ProgramFiles environment variables through the registry.
by Alexandre Julliard
15 Dec '10
15 Dec '10
Module: wine Branch: master Commit: bb80fdf744192af33cb542e075f7dcaba382f422 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bb80fdf744192af33cb542e07…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 14 22:49:01 2010 +0100 wine.inf: Don't set the ProgramFiles environment variables through the registry. --- tools/wine.inf.in | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/tools/wine.inf.in b/tools/wine.inf.in index 57ecddb..aa3b354 100644 --- a/tools/wine.inf.in +++ b/tools/wine.inf.in @@ -565,11 +565,9 @@ HKLM,%Control%\Session Manager,HeapDeCommitFreeBlockThreshold,0x00040002,0 HKLM,%Control%\Session Manager,HeapDeCommitTotalFreeThreshold,0x00040002,0 HKLM,%Control%\Session Manager,HeapSegmentCommit,0x00040002,0 HKLM,%Control%\Session Manager,HeapSegmentReserve,0x00040002,0 -HKLM,%Control%\Session Manager\Environment,"CommonProgramFiles",,"%16427%" HKLM,%Control%\Session Manager\Environment,"ComSpec",0x00020000,"%11%\cmd.exe" HKLM,%Control%\Session Manager\Environment,"PATH",0x00020002,"%11%;%10%;%11%\wbem" HKLM,%Control%\Session Manager\Environment,"PATHEXT",,".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH" -HKLM,%Control%\Session Manager\Environment,"ProgramFiles",,"%16422%" HKLM,%Control%\Session Manager\Environment,"SystemDrive",2,"c:" HKLM,%Control%\Session Manager\Environment,"SYSTEMROOT",,"%10%" HKLM,%Control%\Session Manager\Environment,"TEMP",0x00020002,"%10%\temp"
1
0
0
0
Alexandre Julliard : kernel32: Update the environment variables that vary across 32-bit/64-bit/Wow64.
by Alexandre Julliard
15 Dec '10
15 Dec '10
Module: wine Branch: master Commit: 01af5452c55c06ef827be23007482880649070d3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=01af5452c55c06ef827be2300…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 14 22:48:44 2010 +0100 kernel32: Update the environment variables that vary across 32-bit/64-bit/Wow64. --- dlls/kernel32/process.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 82 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 2b427b9..e29e1b2 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -542,6 +542,87 @@ static void set_additional_environment(void) } /*********************************************************************** + * set_wow64_environment + * + * Set the environment variables that change across 32/64/Wow64. + */ +static void set_wow64_environment(void) +{ + static const WCHAR archW[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0}; + static const WCHAR arch6432W[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','W','6','4','3','2',0}; + static const WCHAR x86W[] = {'x','8','6',0}; + static const WCHAR versionW[] = {'M','a','c','h','i','n','e','\\', + 'S','o','f','t','w','a','r','e','\\', + 'M','i','c','r','o','s','o','f','t','\\', + 'W','i','n','d','o','w','s','\\', + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n',0}; + static const WCHAR progdirW[] = {'P','r','o','g','r','a','m','F','i','l','e','s','D','i','r',0}; + static const WCHAR progdir86W[] = {'P','r','o','g','r','a','m','F','i','l','e','s','D','i','r',' ','(','x','8','6',')',0}; + static const WCHAR progfilesW[] = {'P','r','o','g','r','a','m','F','i','l','e','s',0}; + static const WCHAR progw6432W[] = {'P','r','o','g','r','a','m','W','6','4','3','2',0}; + static const WCHAR commondirW[] = {'C','o','m','m','o','n','F','i','l','e','s','D','i','r',0}; + static const WCHAR commondir86W[] = {'C','o','m','m','o','n','F','i','l','e','s','D','i','r',' ','(','x','8','6',')',0}; + static const WCHAR commonfilesW[] = {'C','o','m','m','o','n','P','r','o','g','r','a','m','F','i','l','e','s',0}; + static const WCHAR commonw6432W[] = {'C','o','m','m','o','n','P','r','o','g','r','a','m','W','6','4','3','2',0}; + + OBJECT_ATTRIBUTES attr; + UNICODE_STRING nameW; + WCHAR arch[64]; + WCHAR *value; + HANDLE hkey; + + /* set the PROCESSOR_ARCHITECTURE variable */ + + if (GetEnvironmentVariableW( arch6432W, arch, sizeof(arch) )) + { + if (is_win64) + { + SetEnvironmentVariableW( archW, arch ); + SetEnvironmentVariableW( arch6432W, NULL ); + } + } + else if (GetEnvironmentVariableW( archW, arch, sizeof(arch) )) + { + if (is_wow64) + { + SetEnvironmentVariableW( arch6432W, arch ); + SetEnvironmentVariableW( archW, x86W ); + } + } + + attr.Length = sizeof(attr); + attr.RootDirectory = 0; + attr.ObjectName = &nameW; + attr.Attributes = 0; + attr.SecurityDescriptor = NULL; + attr.SecurityQualityOfService = NULL; + RtlInitUnicodeString( &nameW, versionW ); + if (NtOpenKey( &hkey, KEY_READ | KEY_WOW64_64KEY, &attr )) return; + + /* set the ProgramFiles variables */ + + if ((value = get_reg_value( hkey, progdirW ))) + { + if (is_win64 || is_wow64) SetEnvironmentVariableW( progw6432W, value ); + if (is_win64 || !is_wow64) SetEnvironmentVariableW( progfilesW, value ); + } + if (is_wow64 && (value = get_reg_value( hkey, progdir86W ))) + SetEnvironmentVariableW( progfilesW, value ); + + /* set the CommonProgramFiles variables */ + + if ((value = get_reg_value( hkey, commondirW ))) + { + if (is_win64 || is_wow64) SetEnvironmentVariableW( commonw6432W, value ); + if (is_win64 || !is_wow64) SetEnvironmentVariableW( commonfilesW, value ); + } + if (is_wow64 && (value = get_reg_value( hkey, commondir86W ))) + SetEnvironmentVariableW( commonfilesW, value ); + + NtClose( hkey ); +} + +/*********************************************************************** * set_library_wargv * * Set the Wine library Unicode argv global variables. @@ -1125,6 +1206,7 @@ void CDECL __wine_kernel_init(void) set_registry_environment( got_environment ); set_additional_environment(); } + set_wow64_environment(); if (!(peb->ImageBaseAddress = LoadLibraryExW( main_exe_name, 0, DONT_RESOLVE_DLL_REFERENCES ))) {
1
0
0
0
Alexandre Julliard : wineboot: Set the correct architecture in the process identifier variable.
by Alexandre Julliard
15 Dec '10
15 Dec '10
Module: wine Branch: master Commit: 6838b4629ef980a70dedba606ae5149cce4ad866 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6838b4629ef980a70dedba606…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 14 22:48:11 2010 +0100 wineboot: Set the correct architecture in the process identifier variable. --- programs/wineboot/wineboot.c | 20 ++++++++------------ 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 4407e17..43cdf3b 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -268,12 +268,13 @@ static void create_environment_registry_keys( void ) static const WCHAR ProcRevW[] = {'P','R','O','C','E','S','S','O','R','_','R','E','V','I','S','I','O','N',0}; static const WCHAR PercentDW[] = {'%','d',0}; static const WCHAR Percent04XW[] = {'%','0','4','x',0}; - static const WCHAR IntelCpuDescrW[] = {'x','8','6',' ','F','a','m','i','l','y',' ','%','d',' ','M','o','d','e','l',' ','%','d', + static const WCHAR IntelCpuDescrW[] = {'%','s',' ','F','a','m','i','l','y',' ','%','d',' ','M','o','d','e','l',' ','%','d', ' ','S','t','e','p','p','i','n','g',' ','%','d',',',' ','G','e','n','u','i','n','e','I','n','t','e','l',0}; HKEY env_key; SYSTEM_CPU_INFORMATION sci; WCHAR buffer[60]; + const WCHAR *arch; NtQuerySystemInformation( SystemCpuInformation, &sci, sizeof(sci), NULL ); @@ -284,20 +285,15 @@ static void create_environment_registry_keys( void ) switch(sci.Architecture) { - case PROCESSOR_ARCHITECTURE_AMD64: - set_reg_value( env_key, ProcArchW, AMD64W ); - break; - case PROCESSOR_ARCHITECTURE_IA64: - set_reg_value( env_key, ProcArchW, IA64W ); - break; - case PROCESSOR_ARCHITECTURE_INTEL: - default: - set_reg_value( env_key, ProcArchW, x86W ); - break; + case PROCESSOR_ARCHITECTURE_AMD64: arch = AMD64W; break; + case PROCESSOR_ARCHITECTURE_IA64: arch = IA64W; break; + default: + case PROCESSOR_ARCHITECTURE_INTEL: arch = x86W; break; } + set_reg_value( env_key, ProcArchW, arch ); /* TODO: currently hardcoded Intel, add different processors */ - sprintfW( buffer, IntelCpuDescrW, sci.Level, HIBYTE(sci.Revision), LOBYTE(sci.Revision) ); + sprintfW( buffer, IntelCpuDescrW, arch, sci.Level, HIBYTE(sci.Revision), LOBYTE(sci.Revision) ); set_reg_value( env_key, ProcIdW, buffer ); sprintfW( buffer, PercentDW, sci.Level );
1
0
0
0
André Hentschel : shdocvw: Add Resizer control to the iexplore window.
by Alexandre Julliard
14 Dec '10
14 Dec '10
Module: wine Branch: master Commit: e8a766b4bf2e07ccb66d206908204d3710a88b35 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e8a766b4bf2e07ccb66d20690…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Dec 14 15:30:44 2010 +0100 shdocvw: Add Resizer control to the iexplore window. --- dlls/shdocvw/iexplore.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/shdocvw/iexplore.c b/dlls/shdocvw/iexplore.c index fb873f5..745cb17 100644 --- a/dlls/shdocvw/iexplore.c +++ b/dlls/shdocvw/iexplore.c @@ -488,7 +488,8 @@ static LRESULT iewnd_OnCreate(HWND hwnd, LPCREATESTRUCTW lpcs) This->menu = create_ie_menu(); - This->status_hwnd = CreateStatusWindowW(CCS_NODIVIDER|WS_CHILD|WS_VISIBLE, NULL, hwnd, IDC_BROWSE_STATUSBAR); + This->status_hwnd = CreateStatusWindowW(WS_VISIBLE|WS_CHILD|SBT_NOBORDERS|CCS_NODIVIDER, + NULL, hwnd, IDC_BROWSE_STATUSBAR); SendMessageW(This->status_hwnd, SB_SIMPLE, TRUE, 0); create_rebar(hwnd);
1
0
0
0
André Hentschel : shell32: Fix shelllink test to not crash on NT4.
by Alexandre Julliard
14 Dec '10
14 Dec '10
Module: wine Branch: master Commit: c0a86cc103923595308111f62c94c9c0aa126c9a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c0a86cc103923595308111f62…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Dec 14 14:05:25 2010 +0100 shell32: Fix shelllink test to not crash on NT4. With much help from Francois. --- dlls/shell32/tests/shelllink.c | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c index 2277e5e..f213221 100644 --- a/dlls/shell32/tests/shelllink.c +++ b/dlls/shell32/tests/shelllink.c @@ -168,15 +168,15 @@ static void test_get_set(void) CoCreateInstance(&CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, &IID_IShellLinkW, (LPVOID*)&slW); - if (!slW) - skip("SetPath with NULL parameter crashes on Win9x\n"); + if (!slW /* Win9x */ || !pGetLongPathNameA /* NT4 */) + skip("SetPath with NULL parameter crashes on Win9x and some NT4\n"); else { IShellLinkW_Release(slW); r = IShellLinkA_SetPath(sl, NULL); ok(r==E_INVALIDARG || broken(r==S_OK), /* Some Win95 and NT4 */ - "SetPath failed (0x%08x)\n", r); + "SetPath returned wrong error (0x%08x)\n", r); } r = IShellLinkA_SetPath(sl, ""); @@ -808,11 +808,16 @@ static void test_datalink(void) ok( r == E_FAIL, "CopyDataBlock failed\n"); ok( dar == NULL, "should be null\n"); - r = IShellLinkW_SetPath(sl, NULL); - ok(r == E_INVALIDARG, "set path failed\n"); + if (!pGetLongPathNameA /* NT4 */) + skip("SetPath with NULL parameter crashes on NT4\n"); + else + { + r = IShellLinkW_SetPath(sl, NULL); + ok(r == E_INVALIDARG, "SetPath returned wrong error (0x%08x)\n", r); + } r = IShellLinkW_SetPath(sl, lnk); - ok(r == S_OK, "set path failed\n"); + ok(r == S_OK, "SetPath failed\n"); if (0) {
1
0
0
0
Maarten Lankhorst : winegstreamer: Correct a state transition.
by Alexandre Julliard
14 Dec '10
14 Dec '10
Module: wine Branch: master Commit: 9ef5a863e395df8b37a6f562c03fd35ce10dd155 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9ef5a863e395df8b37a6f562c…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Fri Dec 10 16:06:59 2010 +0100 winegstreamer: Correct a state transition. --- dlls/winegstreamer/gstdemux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 41190ec..46cd9ec 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -1190,7 +1190,7 @@ static HRESULT WINAPI GST_Run(IBaseFilter *iface, REFERENCE_TIME tStart) { return S_OK; if (now == GST_STATE_PAUSED) { GstStateChangeReturn ret; - ret = gst_element_set_state(This->gstfilter, GST_STATE_PAUSED); + ret = gst_element_set_state(This->gstfilter, GST_STATE_PLAYING); if (ret == GST_STATE_CHANGE_ASYNC) return S_FALSE; return S_OK;
1
0
0
0
Maarten Lankhorst : winegstreamer: Silence a harmless fixme.
by Alexandre Julliard
14 Dec '10
14 Dec '10
Module: wine Branch: master Commit: ea397d25994bf7b9ead8a920ce6588d42b3e8e66 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea397d25994bf7b9ead8a920c…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Fri Dec 10 16:06:58 2010 +0100 winegstreamer: Silence a harmless fixme. --- dlls/winegstreamer/gstdemux.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 7b1c989..41190ec 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -360,7 +360,9 @@ static gboolean event_src(GstPad *pad, GstEvent *event) { LeaveCriticalSection(&This->filter.csFilter); break; default: - FIXME("%p stub\n", event); + FIXME("%p (%u) stub\n", event, event->type); + case GST_EVENT_TAG: + case GST_EVENT_QOS: return gst_pad_event_default(pad, event); } return 1;
1
0
0
0
Maarten Lankhorst : quartz: Handle EndOfStream more elegantly in dsound renderer.
by Alexandre Julliard
14 Dec '10
14 Dec '10
Module: wine Branch: master Commit: 220d610b3da682c75343f07bed0688a7affd5801 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=220d610b3da682c75343f07be…
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Fri Dec 10 16:06:57 2010 +0100 quartz: Handle EndOfStream more elegantly in dsound renderer. --- dlls/quartz/dsoundrender.c | 47 ++++++++++++++++++++++++++++++++++--------- 1 files changed, 37 insertions(+), 10 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index 975eee1..f48cc77 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -226,6 +226,42 @@ end: return S_OK; } +static HRESULT DSoundRender_HandleEndOfStream(DSoundRenderImpl *This) +{ + HRESULT hr; + IMediaEventSink *pEventSink; + + while (1) + { + DWORD pos1, pos2; + DSoundRender_UpdatePositions(This, &pos1, &pos2); + if (pos1 == pos2) + break; + + This->in_loop = 1; + LeaveCriticalSection(&This->filter.csFilter); + WaitForSingleObject(This->blocked, 10); + EnterCriticalSection(&This->filter.csFilter); + This->in_loop = 0; + if (This->pInputPin->flushing || + This->filter.state != State_Running) { + SetEvent(This->state_change); + return S_FALSE; + } + } + + if (!This->filter.filterInfo.pGraph) + return S_OK; + + hr = IFilterGraph_QueryInterface(This->filter.filterInfo.pGraph, &IID_IMediaEventSink, (LPVOID*)&pEventSink); + if (SUCCEEDED(hr)) + { + hr = IMediaEventSink_Notify(pEventSink, EC_COMPLETE, S_OK, (LONG_PTR)This); + IMediaEventSink_Release(pEventSink); + } + return hr; +} + static HRESULT DSoundRender_SendSampleData(DSoundRenderImpl* This, REFERENCE_TIME tStart, REFERENCE_TIME tStop, const BYTE *data, DWORD size) { HRESULT hr; @@ -875,7 +911,6 @@ static HRESULT WINAPI DSoundRender_InputPin_EndOfStream(IPin * iface) { BaseInputPin* This = (BaseInputPin*)iface; DSoundRenderImpl *me = (DSoundRenderImpl*)This->pin.pinInfo.pFilter; - IMediaEventSink* pEventSink; HRESULT hr; EnterCriticalSection(This->pin.pCritSec); @@ -889,15 +924,7 @@ static HRESULT WINAPI DSoundRender_InputPin_EndOfStream(IPin * iface) return hr; } - if (me->filter.filterInfo.pGraph) - { - hr = IFilterGraph_QueryInterface(me->filter.filterInfo.pGraph, &IID_IMediaEventSink, (LPVOID*)&pEventSink); - if (SUCCEEDED(hr)) - { - hr = IMediaEventSink_Notify(pEventSink, EC_COMPLETE, S_OK, (LONG_PTR)me); - IMediaEventSink_Release(pEventSink); - } - } + hr = DSoundRender_HandleEndOfStream(me); MediaSeekingPassThru_EOS(me->seekthru_unk); SetEvent(me->state_change); LeaveCriticalSection(This->pin.pCritSec);
1
0
0
0
← Newer
1
...
45
46
47
48
49
50
51
...
110
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
Results per page:
10
25
50
100
200