winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2010
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
898 discussions
Start a n
N
ew thread
Nikolay Sivov : ole32: Use -W versions of window/message calls.
by Alexandre Julliard
28 Apr '10
28 Apr '10
Module: wine Branch: master Commit: d819f13911deae2b1c14b34ab0d444f78e08de71 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d819f13911deae2b1c14b34ab…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Apr 27 23:41:04 2010 +0400 ole32: Use -W versions of window/message calls. --- dlls/ole32/ole2.c | 54 ++++++++++++++++++++++++++++++---------------------- 1 files changed, 31 insertions(+), 23 deletions(-) diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c index 6bf79fd..6c0f8c1 100644 --- a/dlls/ole32/ole2.c +++ b/dlls/ole32/ole2.c @@ -110,7 +110,14 @@ static LONG OLE_moduleLockCount = 0; /* * Name of our registered window class. */ -static const char OLEDD_DRAGTRACKERCLASS[] = "WineDragDropTracker32"; +static const WCHAR OLEDD_DRAGTRACKERCLASS[] = + {'W','i','n','e','D','r','a','g','D','r','o','p','T','r','a','c','k','e','r','3','2',0}; + +/* + * Name of menu descriptor property. + */ +static const WCHAR prop_olemenuW[] = + {'P','R','O','P','_','O','L','E','M','e','n','u','D','e','s','c','r','i','p','t','o','r',0}; /* * This is the head of the Drop target container. @@ -478,6 +485,7 @@ HRESULT WINAPI DoDragDrop ( DWORD dwOKEffect, /* [in] effects allowed by the source */ DWORD *pdwEffect) /* [out] ptr to effects of the source */ { + static const WCHAR trackerW[] = {'T','r','a','c','k','e','r','W','i','n','d','o','w',0}; TrackerWindowInfo trackerInfo; HWND hwndTrackWindow; MSG msg; @@ -500,12 +508,12 @@ HRESULT WINAPI DoDragDrop ( trackerInfo.curTargetHWND = 0; trackerInfo.curDragTarget = 0; - hwndTrackWindow = CreateWindowA(OLEDD_DRAGTRACKERCLASS, "TrackerWindow", + hwndTrackWindow = CreateWindowW(OLEDD_DRAGTRACKERCLASS, trackerW, WS_POPUP, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, 0, 0, 0, &trackerInfo); - if (hwndTrackWindow!=0) + if (hwndTrackWindow) { /* * Capture the mouse input @@ -517,7 +525,7 @@ HRESULT WINAPI DoDragDrop ( /* * Pump messages. All mouse input should go to the capture window. */ - while (!trackerInfo.trackingDone && GetMessageA(&msg, 0, 0, 0) ) + while (!trackerInfo.trackingDone && GetMessageW(&msg, 0, 0, 0) ) { trackerInfo.curMousePos.x = msg.pt.x; trackerInfo.curMousePos.y = msg.pt.y; @@ -548,7 +556,7 @@ HRESULT WINAPI DoDragDrop ( /* * Dispatch the messages only when it's not a keyboard message. */ - DispatchMessageA(&msg); + DispatchMessageW(&msg); } } @@ -1180,7 +1188,7 @@ static void OLEMenu_UnInitialize(void) */ static BOOL OLEMenu_InstallHooks( DWORD tid ) { - OleMenuHookItem *pHookItem = NULL; + OleMenuHookItem *pHookItem; /* Create an entry for the hook table */ if ( !(pHookItem = HeapAlloc(GetProcessHeap(), 0, @@ -1191,13 +1199,13 @@ static BOOL OLEMenu_InstallHooks( DWORD tid ) pHookItem->hHeap = GetProcessHeap(); /* Install a thread scope message hook for WH_GETMESSAGE */ - pHookItem->GetMsg_hHook = SetWindowsHookExA( WH_GETMESSAGE, OLEMenu_GetMsgProc, + pHookItem->GetMsg_hHook = SetWindowsHookExW( WH_GETMESSAGE, OLEMenu_GetMsgProc, 0, GetCurrentThreadId() ); if ( !pHookItem->GetMsg_hHook ) goto CLEANUP; /* Install a thread scope message hook for WH_CALLWNDPROC */ - pHookItem->CallWndProc_hHook = SetWindowsHookExA( WH_CALLWNDPROC, OLEMenu_CallWndProc, + pHookItem->CallWndProc_hHook = SetWindowsHookExW( WH_CALLWNDPROC, OLEMenu_CallWndProc, 0, GetCurrentThreadId() ); if ( !pHookItem->CallWndProc_hHook ) goto CLEANUP; @@ -1271,7 +1279,7 @@ CLEANUP: */ static OleMenuHookItem * OLEMenu_IsHookInstalled( DWORD tid ) { - OleMenuHookItem *pHookItem = NULL; + OleMenuHookItem *pHookItem; /* Do a simple linear search for an entry whose tid matches ours. * We really need a map but efficiency is not a concern here. */ @@ -1376,7 +1384,7 @@ static BOOL OLEMenu_SetIsServerMenu( HMENU hmenu, OleMenuDescriptor *pOleMenuDes */ static LRESULT CALLBACK OLEMenu_CallWndProc(INT code, WPARAM wParam, LPARAM lParam) { - LPCWPSTRUCT pMsg = NULL; + LPCWPSTRUCT pMsg; HOLEMENU hOleMenu = 0; OleMenuDescriptor *pOleMenuDescriptor = NULL; OleMenuHookItem *pHookItem = NULL; @@ -1395,7 +1403,7 @@ static LRESULT CALLBACK OLEMenu_CallWndProc(INT code, WPARAM wParam, LPARAM lPar * If the window has an OLEMenu property we may need to dispatch * the menu message to its active objects window instead. */ - hOleMenu = GetPropA( pMsg->hwnd, "PROP_OLEMenuDescriptor" ); + hOleMenu = GetPropW( pMsg->hwnd, prop_olemenuW ); if ( !hOleMenu ) goto NEXTHOOK; @@ -1413,7 +1421,7 @@ static LRESULT CALLBACK OLEMenu_CallWndProc(INT code, WPARAM wParam, LPARAM lPar pOleMenuDescriptor->bIsServerItem = FALSE; /* Send this message to the server as well */ - SendMessageA( pOleMenuDescriptor->hwndActiveObject, + SendMessageW( pOleMenuDescriptor->hwndActiveObject, pMsg->message, pMsg->wParam, pMsg->lParam ); goto NEXTHOOK; } @@ -1454,7 +1462,7 @@ static LRESULT CALLBACK OLEMenu_CallWndProc(INT code, WPARAM wParam, LPARAM lPar /* If the message was for the server dispatch it accordingly */ if ( pOleMenuDescriptor->bIsServerItem ) { - SendMessageA( pOleMenuDescriptor->hwndActiveObject, + SendMessageW( pOleMenuDescriptor->hwndActiveObject, pMsg->message, pMsg->wParam, pMsg->lParam ); } @@ -1481,7 +1489,7 @@ NEXTHOOK: */ static LRESULT CALLBACK OLEMenu_GetMsgProc(INT code, WPARAM wParam, LPARAM lParam) { - LPMSG pMsg = NULL; + LPMSG pMsg; HOLEMENU hOleMenu = 0; OleMenuDescriptor *pOleMenuDescriptor = NULL; OleMenuHookItem *pHookItem = NULL; @@ -1500,7 +1508,7 @@ static LRESULT CALLBACK OLEMenu_GetMsgProc(INT code, WPARAM wParam, LPARAM lPara * If the window has an OLEMenu property we may need to dispatch * the menu message to its active objects window instead. */ - hOleMenu = GetPropA( pMsg->hwnd, "PROP_OLEMenuDescriptor" ); + hOleMenu = GetPropW( pMsg->hwnd, prop_olemenuW ); if ( !hOleMenu ) goto NEXTHOOK; @@ -1671,7 +1679,7 @@ HRESULT WINAPI OleSetMenuDescriptor( pOleMenuDescriptor = NULL; /* Add a menu descriptor windows property to the frame window */ - SetPropA( hwndFrame, "PROP_OLEMenuDescriptor", hOleMenu ); + SetPropW( hwndFrame, prop_olemenuW, hOleMenu ); /* Install thread scope message hooks for WH_GETMESSAGE and WH_CALLWNDPROC */ if ( !OLEMenu_InstallHooks( GetCurrentThreadId() ) ) @@ -1684,7 +1692,7 @@ HRESULT WINAPI OleSetMenuDescriptor( return E_FAIL; /* Remove the menu descriptor property from the frame window */ - RemovePropA( hwndFrame, "PROP_OLEMenuDescriptor" ); + RemovePropW( hwndFrame, prop_olemenuW ); } return S_OK; @@ -1870,9 +1878,9 @@ void WINAPI ReleaseStgMedium( */ static void OLEDD_Initialize(void) { - WNDCLASSA wndClass; + WNDCLASSW wndClass; - ZeroMemory (&wndClass, sizeof(WNDCLASSA)); + ZeroMemory (&wndClass, sizeof(WNDCLASSW)); wndClass.style = CS_GLOBALCLASS; wndClass.lpfnWndProc = OLEDD_DragTrackerWindowProc; wndClass.cbClsExtra = 0; @@ -1881,7 +1889,7 @@ static void OLEDD_Initialize(void) wndClass.hbrBackground = 0; wndClass.lpszClassName = OLEDD_DRAGTRACKERCLASS; - RegisterClassA (&wndClass); + RegisterClassW (&wndClass); } /*** @@ -1958,7 +1966,7 @@ static LRESULT WINAPI OLEDD_DragTrackerWindowProc( { LPCREATESTRUCTA createStruct = (LPCREATESTRUCTA)lParam; - SetWindowLongPtrA(hwnd, 0, (LONG_PTR)createStruct->lpCreateParams); + SetWindowLongPtrW(hwnd, 0, (LONG_PTR)createStruct->lpCreateParams); SetTimer(hwnd, DRAG_TIMER_ID, 50, NULL); break; @@ -1989,7 +1997,7 @@ static LRESULT WINAPI OLEDD_DragTrackerWindowProc( /* * This is a window proc after all. Let's call the default. */ - return DefWindowProcA (hwnd, uMsg, wParam, lParam); + return DefWindowProcW (hwnd, uMsg, wParam, lParam); } /*** @@ -2257,8 +2265,8 @@ static void OLEUTL_ReadRegistryDWORDValue( DWORD* pdwValue) { char buffer[20]; + DWORD cbData = sizeof(buffer); DWORD dwKeyType; - DWORD cbData = 20; LONG lres; lres = RegQueryValueExA(regKey,
1
0
0
0
Ing. Simone. Giustetti : Slackware download description line updated to latest package binary format
by Jeremy Newman
28 Apr '10
28 Apr '10
Module: website Branch: master Commit: deed0159eb4b3576249b95bc0a9bf1bfd9f38114 URL:
http://source.winehq.org/git/website.git/?a=commit;h=deed0159eb4b3576249b95…
Author: Ing. Simone. Giustetti <studiosg(a)giustetti.net> Date: Wed Apr 28 16:51:41 2010 +0200 Slackware download description line updated to latest package binary format Try 2 Hope this one behaves better than first try. Cheers Simone > This patch does not apply against the current git tree. Please always > submit patches using "git format-patch". > > Also, it helps if you prefix the subject with [website] so I can tell > which patches are meant for the website without scanning the body. > > -Newman > > Ing. Simone. Giustetti wrote: > > Hi all, > > > > The download page description for Slackware was updated because someone > pointed > > to me it was not clear if the new txz package format was supported or not. > > The attached patch contains the updated line for the template in 3 > languages. > > > > Bye > > Simone > > > > > > > > ------------------------------------------------------------------------ > > > > > > -- Ing. Simone Giustetti Tel: 340-3425647 e-mail: studiosg(a)giustetti.net ------------------------------------------------- This mail sent through IMP:
http://horde.org/imp/
>From 79bf77cde5eecf7a4ef349272ac0157803f48833 Mon Sep 17 00:00:00 2001 From: twinstar <studiosg(a)giustetti.net> Date: Wed, 28 Apr 2010 16:23:59 +0200 Subject: Updated Slackware download description string with current package format MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1.6.5" This is a multi-part message in MIME format. --------------1.6.5 Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit --- templates/de/download.template | 2 +- templates/en/download.template | 2 +- templates/pl/download.template | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/templates/de/download.template b/templates/de/download.template index 6642219..c1e9e00 100644 --- a/templates/de/download.template +++ b/templates/de/download.template @@ -127,7 +127,7 @@ erbeten hat, dass sie die Wine-Website hosten.</p> <img src="{$root}/images/distro/slackware.png" width="50" height="50" alt="Slackware linux" border="0"></a> </td> <td> <b><a href="
http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=6…
">Slackware</a></b> - binär .tgz für Slackware 10.2</td> + binär txz (Slackware 13.0), und tgz (für ältere Versionen)</td> <td><a href="mailto:studiosg@giustetti.net">Simone Giustetti</a></td> </tr> diff --git a/templates/en/download.template b/templates/en/download.template index 5f2d51f..dd50dae 100644 --- a/templates/en/download.template +++ b/templates/en/download.template @@ -114,7 +114,7 @@ requested in exchange for hosting the Wine web site.</p> <img src="{$root}/images/distro/slackware.png" width="50" height="50" alt="Slackware linux" border="0"></a> </td> <td> <b><a href="
http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=6…
">Download Slackware packages</a></b> - - binary .tgz for Slackware 10.2</td> + - binary txz (Slackware 13.0), and tgz (for older versions)</td> <td><a href="mailto:studiosg@giustetti.net">Simone Giustetti</a></td> </tr> diff --git a/templates/pl/download.template b/templates/pl/download.template index a96e606..140759b 100644 --- a/templates/pl/download.template +++ b/templates/pl/download.template @@ -111,7 +111,7 @@ <img src="{$root}/images/distro/slackware.png" width="50" height="50" alt="Slackware linux" border="0"></a> </td> <td> <b><a href="
http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=6…
">Slackware</a></b> - binarne .tgz dla Slackware 10.2</td> + binarne: txz (dla Slackware 13.0), i tgz (dla starszych wersji)</td> <td><a href="mailto:studiosg@giustetti.net">Simone Giustetti</a></td> </tr>
1
0
0
0
Nikolay Sivov : t2embed: Add TTIsEmbeddingEnabled stub.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: b9391933a66dfdbf231fc9383e3d9dc6ee155e6e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b9391933a66dfdbf231fc9383…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Apr 27 22:37:57 2010 +0400 t2embed: Add TTIsEmbeddingEnabled stub. --- dlls/t2embed/main.c | 7 +++++++ dlls/t2embed/t2embed.spec | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/t2embed/main.c b/dlls/t2embed/main.c index a0abc57..6d12eff 100644 --- a/dlls/t2embed/main.c +++ b/dlls/t2embed/main.c @@ -66,3 +66,10 @@ LONG WINAPI TTGetEmbeddingType(HDC hDC, ULONG *status) if (status) *status = EMBED_NOEMBEDDING; return E_API_NOTIMPL; } + +LONG WINAPI TTIsEmbeddingEnabled(HDC hDC, BOOL *enabled) +{ + FIXME("(%p %p) stub\n", hDC, enabled); + if (enabled) *enabled = FALSE; + return E_API_NOTIMPL; +} diff --git a/dlls/t2embed/t2embed.spec b/dlls/t2embed/t2embed.spec index 828501c..12f8a6a 100644 --- a/dlls/t2embed/t2embed.spec +++ b/dlls/t2embed/t2embed.spec @@ -5,7 +5,7 @@ @ stub TTEnableEmbeddingForFacename @ stub TTGetEmbeddedFontInfo @ stdcall TTGetEmbeddingType(ptr ptr) -@ stub TTIsEmbeddingEnabled +@ stdcall TTIsEmbeddingEnabled(ptr ptr) @ stub TTIsEmbeddingEnabledForFacename @ stdcall TTLoadEmbeddedFont(ptr long ptr long ptr ptr ptr wstr str ptr) @ stub TTRunValidationTests
1
0
0
0
Vincent Povirk : windowscodecs: Partially implement IWICBitmapFlipRotator_CopyPixels.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: 4f4812b447c3d6f41a77db648992ac49cbb63666 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4f4812b447c3d6f41a77db648…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 13:15:33 2010 -0500 windowscodecs: Partially implement IWICBitmapFlipRotator_CopyPixels. --- dlls/windowscodecs/fliprotate.c | 42 +++++++++++++++++++++++++++++++++++++- 1 files changed, 40 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/fliprotate.c b/dlls/windowscodecs/fliprotate.c index 7bbaf99..7dac252 100644 --- a/dlls/windowscodecs/fliprotate.c +++ b/dlls/windowscodecs/fliprotate.c @@ -135,9 +135,47 @@ static HRESULT WINAPI FlipRotator_CopyPalette(IWICBitmapFlipRotator *iface, static HRESULT WINAPI FlipRotator_CopyPixels(IWICBitmapFlipRotator *iface, const WICRect *prc, UINT cbStride, UINT cbBufferSize, BYTE *pbBuffer) { - FIXME("(%p,%p,%u,%u,%p): stub\n", iface, prc, cbStride, cbBufferSize, pbBuffer); + FlipRotator *This = (FlipRotator*)iface; + HRESULT hr; + UINT y; + UINT srcy, srcwidth, srcheight; + WICRect rc; - return E_NOTIMPL; + TRACE("(%p,%p,%u,%u,%p)\n", iface, prc, cbStride, cbBufferSize, pbBuffer); + + if (!This->source) return WINCODEC_ERR_WRONGSTATE; + + if (This->swap_xy || This->flip_x) + { + /* This requires knowledge of the pixel format. */ + FIXME("flipping x and rotating are not implemented\n"); + return E_NOTIMPL; + } + + hr = IWICBitmapSource_GetSize(This->source, &srcwidth, &srcheight); + if (FAILED(hr)) return hr; + + for (y=prc->Y; y - prc->Y < prc->Height; y++) + { + if (This->flip_y) + srcy = srcheight - 1 - y; + else + srcy = y; + + rc.X = prc->X; + rc.Y = srcy; + rc.Width = prc->Width; + rc.Height = 1; + + hr = IWICBitmapSource_CopyPixels(This->source, &rc, cbStride, cbStride, + pbBuffer); + + if (FAILED(hr)) break; + + pbBuffer += cbStride; + } + + return hr; } static HRESULT WINAPI FlipRotator_Initialize(IWICBitmapFlipRotator *iface,
1
0
0
0
Vincent Povirk : windowscodecs: Implement IWICBitmapFlipRotator_GetSize.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: 0e992fccc5bb081e93e41781cf2a933bc9da4068 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0e992fccc5bb081e93e41781c…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 11:40:44 2010 -0500 windowscodecs: Implement IWICBitmapFlipRotator_GetSize. --- dlls/windowscodecs/fliprotate.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/fliprotate.c b/dlls/windowscodecs/fliprotate.c index 6db7fea..7bbaf99 100644 --- a/dlls/windowscodecs/fliprotate.c +++ b/dlls/windowscodecs/fliprotate.c @@ -98,9 +98,15 @@ static ULONG WINAPI FlipRotator_Release(IWICBitmapFlipRotator *iface) static HRESULT WINAPI FlipRotator_GetSize(IWICBitmapFlipRotator *iface, UINT *puiWidth, UINT *puiHeight) { - FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight); + FlipRotator *This = (FlipRotator*)iface; + TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight); - return E_NOTIMPL; + if (!This->source) + return WINCODEC_ERR_WRONGSTATE; + else if (This->swap_xy) + return IWICBitmapSource_GetSize(This->source, puiHeight, puiWidth); + else + return IWICBitmapSource_GetSize(This->source, puiWidth, puiHeight); } static HRESULT WINAPI FlipRotator_GetPixelFormat(IWICBitmapFlipRotator *iface,
1
0
0
0
Vincent Povirk : windowscodecs: Implement IWICBitmapFlipRotator_Initialize.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: dbdf1ef8b64fc9705665b5e141c42e627764d6aa URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dbdf1ef8b64fc9705665b5e14…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 11:40:25 2010 -0500 windowscodecs: Implement IWICBitmapFlipRotator_Initialize. --- dlls/windowscodecs/fliprotate.c | 48 +++++++++++++++++++++++++++++++++++++- 1 files changed, 46 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/fliprotate.c b/dlls/windowscodecs/fliprotate.c index 19a00de..6db7fea 100644 --- a/dlls/windowscodecs/fliprotate.c +++ b/dlls/windowscodecs/fliprotate.c @@ -36,6 +36,10 @@ WINE_DEFAULT_DEBUG_CHANNEL(wincodecs); typedef struct FlipRotator { const IWICBitmapFlipRotatorVtbl *lpVtbl; LONG ref; + IWICBitmapSource *source; + int flip_x; + int flip_y; + int swap_xy; CRITICAL_SECTION lock; /* must be held when initialized */ } FlipRotator; @@ -84,6 +88,7 @@ static ULONG WINAPI FlipRotator_Release(IWICBitmapFlipRotator *iface) { This->lock.DebugInfo->Spare[0] = 0; DeleteCriticalSection(&This->lock); + if (This->source) IWICBitmapSource_Release(This->source); HeapFree(GetProcessHeap(), 0, This); } @@ -132,9 +137,44 @@ static HRESULT WINAPI FlipRotator_CopyPixels(IWICBitmapFlipRotator *iface, static HRESULT WINAPI FlipRotator_Initialize(IWICBitmapFlipRotator *iface, IWICBitmapSource *pISource, WICBitmapTransformOptions options) { - FIXME("(%p,%p,%u): stub\n", iface, pISource, options); + FlipRotator *This = (FlipRotator*)iface; + HRESULT hr=S_OK; - return E_NOTIMPL; + TRACE("(%p,%p,%u)\n", iface, pISource, options); + + EnterCriticalSection(&This->lock); + + if (This->source) + { + hr = WINCODEC_ERR_WRONGSTATE; + goto end; + } + + if (options&WICBitmapTransformRotate90) + { + This->swap_xy = 1; + This->flip_x = !This->flip_x; + } + + if (options&WICBitmapTransformRotate180) + { + This->flip_x = !This->flip_x; + This->flip_y = !This->flip_y; + } + + if (options&WICBitmapTransformFlipHorizontal) + This->flip_x = !This->flip_x; + + if (options&WICBitmapTransformFlipVertical) + This->flip_y = !This->flip_y; + + IWICBitmapSource_AddRef(pISource); + This->source = pISource; + +end: + LeaveCriticalSection(&This->lock); + + return hr; } static const IWICBitmapFlipRotatorVtbl FlipRotator_Vtbl = { @@ -158,6 +198,10 @@ HRESULT FlipRotator_Create(IWICBitmapFlipRotator **fliprotator) This->lpVtbl = &FlipRotator_Vtbl; This->ref = 1; + This->source = NULL; + This->flip_x = 0; + This->flip_y = 0; + This->swap_xy = 0; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": FlipRotator.lock");
1
0
0
0
Vincent Povirk : windowscodecs: Add a stub implementation of IWICBitmapFlipRotator.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: 7a254fc4d807418fa6242f5bd2b9a4300e26807f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7a254fc4d807418fa6242f5bd…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 11:12:34 2010 -0500 windowscodecs: Add a stub implementation of IWICBitmapFlipRotator. --- dlls/windowscodecs/Makefile.in | 1 + dlls/windowscodecs/fliprotate.c | 167 ++++++++++++++++++++++++++++++++ dlls/windowscodecs/imgfactory.c | 4 +- dlls/windowscodecs/wincodecs_private.h | 1 + 4 files changed, 171 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/Makefile.in b/dlls/windowscodecs/Makefile.in index 0516161..44e17c9 100644 --- a/dlls/windowscodecs/Makefile.in +++ b/dlls/windowscodecs/Makefile.in @@ -12,6 +12,7 @@ C_SRCS = \ bmpencode.c \ clsfactory.c \ converter.c \ + fliprotate.c \ gifformat.c \ icoformat.c \ imgfactory.c \ diff --git a/dlls/windowscodecs/fliprotate.c b/dlls/windowscodecs/fliprotate.c new file mode 100644 index 0000000..19a00de --- /dev/null +++ b/dlls/windowscodecs/fliprotate.c @@ -0,0 +1,167 @@ +/* + * Copyright 2010 Vincent Povirk for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "config.h" + +#include <stdarg.h> + +#define COBJMACROS + +#include "windef.h" +#include "winbase.h" +#include "objbase.h" +#include "wincodec.h" + +#include "wincodecs_private.h" + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(wincodecs); + +typedef struct FlipRotator { + const IWICBitmapFlipRotatorVtbl *lpVtbl; + LONG ref; + CRITICAL_SECTION lock; /* must be held when initialized */ +} FlipRotator; + +static HRESULT WINAPI FlipRotator_QueryInterface(IWICBitmapFlipRotator *iface, REFIID iid, + void **ppv) +{ + FlipRotator *This = (FlipRotator*)iface; + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); + + if (!ppv) return E_INVALIDARG; + + if (IsEqualIID(&IID_IUnknown, iid) || + IsEqualIID(&IID_IWICBitmapSource, iid) || + IsEqualIID(&IID_IWICBitmapFlipRotator, iid)) + { + *ppv = This; + } + else + { + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI FlipRotator_AddRef(IWICBitmapFlipRotator *iface) +{ + FlipRotator *This = (FlipRotator*)iface; + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + return ref; +} + +static ULONG WINAPI FlipRotator_Release(IWICBitmapFlipRotator *iface) +{ + FlipRotator *This = (FlipRotator*)iface; + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + if (ref == 0) + { + This->lock.DebugInfo->Spare[0] = 0; + DeleteCriticalSection(&This->lock); + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static HRESULT WINAPI FlipRotator_GetSize(IWICBitmapFlipRotator *iface, + UINT *puiWidth, UINT *puiHeight) +{ + FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight); + + return E_NOTIMPL; +} + +static HRESULT WINAPI FlipRotator_GetPixelFormat(IWICBitmapFlipRotator *iface, + WICPixelFormatGUID *pPixelFormat) +{ + FIXME("(%p,%p): stub\n", iface, pPixelFormat); + + return E_NOTIMPL; +} + +static HRESULT WINAPI FlipRotator_GetResolution(IWICBitmapFlipRotator *iface, + double *pDpiX, double *pDpiY) +{ + FIXME("(%p,%p,%p): stub\n", iface, pDpiX, pDpiY); + + return E_NOTIMPL; +} + +static HRESULT WINAPI FlipRotator_CopyPalette(IWICBitmapFlipRotator *iface, + IWICPalette *pIPalette) +{ + FIXME("(%p,%p): stub\n", iface, pIPalette); + return E_NOTIMPL; +} + +static HRESULT WINAPI FlipRotator_CopyPixels(IWICBitmapFlipRotator *iface, + const WICRect *prc, UINT cbStride, UINT cbBufferSize, BYTE *pbBuffer) +{ + FIXME("(%p,%p,%u,%u,%p): stub\n", iface, prc, cbStride, cbBufferSize, pbBuffer); + + return E_NOTIMPL; +} + +static HRESULT WINAPI FlipRotator_Initialize(IWICBitmapFlipRotator *iface, + IWICBitmapSource *pISource, WICBitmapTransformOptions options) +{ + FIXME("(%p,%p,%u): stub\n", iface, pISource, options); + + return E_NOTIMPL; +} + +static const IWICBitmapFlipRotatorVtbl FlipRotator_Vtbl = { + FlipRotator_QueryInterface, + FlipRotator_AddRef, + FlipRotator_Release, + FlipRotator_GetSize, + FlipRotator_GetPixelFormat, + FlipRotator_GetResolution, + FlipRotator_CopyPalette, + FlipRotator_CopyPixels, + FlipRotator_Initialize +}; + +HRESULT FlipRotator_Create(IWICBitmapFlipRotator **fliprotator) +{ + FlipRotator *This; + + This = HeapAlloc(GetProcessHeap(), 0, sizeof(FlipRotator)); + if (!This) return E_OUTOFMEMORY; + + This->lpVtbl = &FlipRotator_Vtbl; + This->ref = 1; + InitializeCriticalSection(&This->lock); + This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": FlipRotator.lock"); + + *fliprotator = (IWICBitmapFlipRotator*)This; + + return S_OK; +} diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c index 3f51493..5c81b98 100644 --- a/dlls/windowscodecs/imgfactory.c +++ b/dlls/windowscodecs/imgfactory.c @@ -267,8 +267,8 @@ static HRESULT WINAPI ImagingFactory_CreateBitmapClipper(IWICImagingFactory *ifa static HRESULT WINAPI ImagingFactory_CreateBitmapFlipRotator(IWICImagingFactory *iface, IWICBitmapFlipRotator **ppIBitmapFlipRotator) { - FIXME("(%p,%p): stub\n", iface, ppIBitmapFlipRotator); - return E_NOTIMPL; + TRACE("(%p,%p)\n", iface, ppIBitmapFlipRotator); + return FlipRotator_Create(ppIBitmapFlipRotator); } static HRESULT WINAPI ImagingFactory_CreateStream(IWICImagingFactory *iface, diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h index 0e72793..059d8e7 100644 --- a/dlls/windowscodecs/wincodecs_private.h +++ b/dlls/windowscodecs/wincodecs_private.h @@ -30,6 +30,7 @@ extern HRESULT IcoDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** extern HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv); extern HRESULT TiffDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv); +extern HRESULT FlipRotator_Create(IWICBitmapFlipRotator **fliprotator); extern HRESULT PaletteImpl_Create(IWICPalette **palette); extern HRESULT StreamImpl_Create(IWICStream **stream);
1
0
0
0
Vincent Povirk : include: Add definitions for IWICBitmapFlipRotator.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: 6c480cb160aefe32dbe874ce658ab46470c07b63 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6c480cb160aefe32dbe874ce6…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 10:55:12 2010 -0500 include: Add definitions for IWICBitmapFlipRotator. --- include/wincodec.idl | 22 +++++++++++++++++++++- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/include/wincodec.idl b/include/wincodec.idl index b1fb41a..9d3fee1 100644 --- a/include/wincodec.idl +++ b/include/wincodec.idl @@ -98,6 +98,16 @@ typedef enum WICBitmapPaletteType { WICBITMAPPALETTETYPE_FORCE_DWORD = CODEC_FORCE_DWORD } WICBitmapPaletteType; +typedef enum WICBitmapTransformOptions { + WICBitmapTransformRotate0 = 0x00000000, + WICBitmapTransformRotate90 = 0x00000001, + WICBitmapTransformRotate180 = 0x00000002, + WICBitmapTransformRotate270 = 0x00000003, + WICBitmapTransformFlipHorizontal = 0x00000008, + WICBitmapTransformFlipVertical = 0x00000010, + WICBITMAPTRANSFORMOPTIONS_FORCE_DWORD = CODEC_FORCE_DWORD +} WICBitmapTransformOptions; + typedef enum WICComponentType { WICDecoder = 0x00000001, WICEncoder = 0x00000002, @@ -178,7 +188,6 @@ cpp_quote("#define WINCODEC_ERR_UNSUPPORTEDOPERATION 0x88982f81") cpp_quote("#define WINCODEC_ERR_INSUFFICIENTBUFFER 0x88982f8c") interface IWICPalette; -interface IWICBitmapFlipRotator; interface IWICColorContext; interface IWICColorTransform; interface IWICFastMetadataEncoder; @@ -235,6 +244,17 @@ interface IWICBitmapLock : IUnknown [ object, + uuid(5009834f-2d6a-41ce-9e1b-17c5aff7a782) +] +interface IWICBitmapFlipRotator : IWICBitmapSource +{ + HRESULT Initialize( + [in] IWICBitmapSource *pISource, + [in] WICBitmapTransformOptions options); +} + +[ + object, uuid(00000121-a8f2-4877-ba0a-fd2b6645fb94) ] interface IWICBitmap : IWICBitmapSource
1
0
0
0
Vincent Povirk : windowscodecs: Implement IWICImagingFactory_CreateFormatConverter.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: 83f32fc7d8f6ba709884bfb2214f862dae1420ab URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83f32fc7d8f6ba709884bfb22…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 10:46:53 2010 -0500 windowscodecs: Implement IWICImagingFactory_CreateFormatConverter. --- dlls/windowscodecs/imgfactory.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c index e3dcca0..3f51493 100644 --- a/dlls/windowscodecs/imgfactory.c +++ b/dlls/windowscodecs/imgfactory.c @@ -247,8 +247,7 @@ static HRESULT WINAPI ImagingFactory_CreatePalette(IWICImagingFactory *iface, static HRESULT WINAPI ImagingFactory_CreateFormatConverter(IWICImagingFactory *iface, IWICFormatConverter **ppIFormatConverter) { - FIXME("(%p,%p): stub\n", iface, ppIFormatConverter); - return E_NOTIMPL; + return FormatConverter_CreateInstance(NULL, &IID_IWICFormatConverter, (void**)ppIFormatConverter); } static HRESULT WINAPI ImagingFactory_CreateBitmapScaler(IWICImagingFactory *iface,
1
0
0
0
Vincent Povirk : windowscodecs: Implement IWICImagingFactory_CreateDecoderFromFilename.
by Alexandre Julliard
27 Apr '10
27 Apr '10
Module: wine Branch: master Commit: b468c29de10d29d9b3a7717bbc8b8dc631a4ca83 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b468c29de10d29d9b3a7717bb…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 27 10:40:40 2010 -0500 windowscodecs: Implement IWICImagingFactory_CreateDecoderFromFilename. --- dlls/windowscodecs/imgfactory.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c index a98aeb8..e3dcca0 100644 --- a/dlls/windowscodecs/imgfactory.c +++ b/dlls/windowscodecs/imgfactory.c @@ -26,6 +26,7 @@ #include "winbase.h" #include "winreg.h" #include "objbase.h" +#include "shellapi.h" #include "wincodec.h" #include "wincodecs_private.h" @@ -89,9 +90,27 @@ static HRESULT WINAPI ImagingFactory_CreateDecoderFromFilename( DWORD dwDesiredAccess, WICDecodeOptions metadataOptions, IWICBitmapDecoder **ppIDecoder) { - FIXME("(%p,%s,%s,%u,%u,%p): stub\n", iface, debugstr_w(wzFilename), + IWICStream *stream; + HRESULT hr; + + TRACE("(%p,%s,%s,%u,%u,%p)\n", iface, debugstr_w(wzFilename), debugstr_guid(pguidVendor), dwDesiredAccess, metadataOptions, ppIDecoder); - return E_NOTIMPL; + + hr = StreamImpl_Create(&stream); + if (SUCCEEDED(hr)) + { + hr = IWICStream_InitializeFromFilename(stream, wzFilename, dwDesiredAccess); + + if (SUCCEEDED(hr)) + { + hr = IWICImagingFactory_CreateDecoderFromStream(iface, (IStream*)stream, + pguidVendor, metadataOptions, ppIDecoder); + } + + IWICStream_Release(stream); + } + + return hr; } static HRESULT WINAPI ImagingFactory_CreateDecoderFromStream(
1
0
0
0
← Newer
1
...
4
5
6
7
8
9
10
...
90
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
Results per page:
10
25
50
100
200