winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2010
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
955 discussions
Start a n
N
ew thread
Gerald Pfeifer : gdi32: Remove variable x which is not really used from testJustification.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 08b88c42ee42d5ab081755272241e92d2bc29ca2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=08b88c42ee42d5ab081755272…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun May 2 20:53:58 2010 +0200 gdi32: Remove variable x which is not really used from testJustification. --- dlls/gdi32/tests/font.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index 87ca494..7982a73 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -1343,7 +1343,7 @@ static void test_GetOutlineTextMetrics(void) static void testJustification(HDC hdc, PSTR str, RECT *clientArea) { - INT x, y, + INT y, breakCount, justifiedWidth = 0, /* to test GetTextExtentExPointW() */ areaWidth = clientArea->right - clientArea->left, @@ -1399,8 +1399,6 @@ static void testJustification(HDC hdc, PSTR str, RECT *clientArea) } else lastExtent = TRUE; - x = clientArea->left; - /* catch errors and report them */ if (!lastExtent && (justifiedWidth != areaWidth)) {
1
0
0
0
Gerald Pfeifer : widl: Simplify write_struct_tfs and remove an unused variable.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 194fd8744ad9752ffa614f50b35ea153b610e9c6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=194fd8744ad9752ffa614f50b…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun May 2 20:48:39 2010 +0200 widl: Simplify write_struct_tfs and remove an unused variable. --- tools/widl/typegen.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 694e98d..8541c5a 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -2452,7 +2452,6 @@ static unsigned int write_struct_tfs(FILE *file, type_t *type, unsigned int total_size; const var_t *array; unsigned int start_offset; - unsigned int array_offset; unsigned int align; unsigned int corroff; var_t *f; @@ -2473,10 +2472,12 @@ static unsigned int write_struct_tfs(FILE *file, type_t *type, array = find_array_or_string_in_struct(type); if (array && !processed(array->type)) - array_offset - = is_string_type(array->attrs, array->type) - ? write_string_tfs(file, array->attrs, array->type, FALSE, array->name, tfsoff) - : write_array_tfs(file, array->attrs, array->type, array->name, tfsoff); + { + if(is_string_type(array->attrs, array->type)) + write_string_tfs(file, array->attrs, array->type, FALSE, array->name, tfsoff); + else + write_array_tfs(file, array->attrs, array->type, array->name, tfsoff); + } corroff = *tfsoff; write_descriptors(file, type, tfsoff);
1
0
0
0
Gerald Pfeifer : comctl32: Remove variable old_focused which is not really used from MONTHCAL_Mouse.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 44f1fbced49fad5901f6f01bce8541ea9a55f70e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=44f1fbced49fad5901f6f01bc…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun May 2 20:40:05 2010 +0200 comctl32: Remove variable old_focused which is not really used from MONTHCAL_Mouse. --- dlls/comctl32/monthcal.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c index 2c98331..a9795e0 100644 --- a/dlls/comctl32/monthcal.c +++ b/dlls/comctl32/monthcal.c @@ -2033,7 +2033,7 @@ static LRESULT MONTHCAL_MouseMove(MONTHCAL_INFO *infoPtr, LPARAM lParam) { MCHITTESTINFO ht; - SYSTEMTIME old_focused, st_ht; + SYSTEMTIME st_ht; INT hit; RECT r; @@ -2054,7 +2054,6 @@ MONTHCAL_MouseMove(MONTHCAL_INFO *infoPtr, LPARAM lParam) } st_ht = ht.st; - old_focused = infoPtr->focusedSel; /* if pointer is over focused day still there's nothing to do */ if(!MONTHCAL_SetDayFocus(infoPtr, &ht.st)) return 0;
1
0
0
0
Gerald Pfeifer : ole32: Fix return value for CoRevokeMallocSpy.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: c6f74e386b5f527843fd520f3a987bf8d36aff2c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c6f74e386b5f527843fd520f3…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 22:38:00 2010 +0200 ole32: Fix return value for CoRevokeMallocSpy. --- dlls/ole32/ifs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/ifs.c b/dlls/ole32/ifs.c index c6a6962..1a10c3e 100644 --- a/dlls/ole32/ifs.c +++ b/dlls/ole32/ifs.c @@ -501,7 +501,7 @@ HRESULT WINAPI CoRevokeMallocSpy(void) } LeaveCriticalSection(&IMalloc32_SpyCS); - return S_OK; + return hres; } /******************************************************************************
1
0
0
0
Gerald Pfeifer : ole32: Fix return value of DefaultHandler_SetClientSite.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 889900f020858de62dd7438c1b41fba61ac2a198 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=889900f020858de62dd7438c1…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 22:33:45 2010 +0200 ole32: Fix return value of DefaultHandler_SetClientSite. --- dlls/ole32/defaulthandler.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/defaulthandler.c b/dlls/ole32/defaulthandler.c index 5130513..d0a871f 100644 --- a/dlls/ole32/defaulthandler.c +++ b/dlls/ole32/defaulthandler.c @@ -365,7 +365,7 @@ static HRESULT WINAPI DefaultHandler_SetClientSite( if (This->clientSite) IOleClientSite_AddRef(This->clientSite); - return S_OK; + return hr; } /************************************************************************
1
0
0
0
Gerald Pfeifer : riched20: Remove variable changed which is not really used from ME_PrepareParagraphForWrapping .
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 14ef0fed9cd94ca0aaefa759d709ec1ccc351e4d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=14ef0fed9cd94ca0aaefa759d…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 22:35:31 2010 +0200 riched20: Remove variable changed which is not really used from ME_PrepareParagraphForWrapping. --- dlls/riched20/wrap.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/wrap.c b/dlls/riched20/wrap.c index 3b15490..790c280 100644 --- a/dlls/riched20/wrap.c +++ b/dlls/riched20/wrap.c @@ -578,14 +578,12 @@ static void ME_PrepareParagraphForWrapping(ME_Context *c, ME_DisplayItem *tp) { } /* join runs that can be joined, set up flags */ for (p = tp->next; p!=tp->member.para.next_para; p = p->next) { - int changed = 0; switch(p->type) { case diStartRow: assert(0); break; /* should have deleted it */ case diRun: while (p->next->type == diRun) { /* FIXME */ if (ME_CanJoinRuns(&p->member.run, &p->next->member.run)) { ME_JoinRuns(c->editor, p); - changed = 1; } else break;
1
0
0
0
Gerald Pfeifer : wintrust/tests: Remove variable myARGC which is not really used from test_cdf_parsing.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 7cdcdf781e2850d7aa9cfaedcf44dfdd39bd5ceb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7cdcdf781e2850d7aa9cfaedc…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 22:31:07 2010 +0200 wintrust/tests: Remove variable myARGC which is not really used from test_cdf_parsing. --- dlls/wintrust/tests/crypt.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/wintrust/tests/crypt.c b/dlls/wintrust/tests/crypt.c index a2e096a..64a91b7 100644 --- a/dlls/wintrust/tests/crypt.c +++ b/dlls/wintrust/tests/crypt.c @@ -1111,7 +1111,6 @@ static void test_cdf_parsing(void) START_TEST(crypt) { - int myARGC; char** myARGV; char sysdir[MAX_PATH]; @@ -1129,7 +1128,7 @@ START_TEST(crypt) lstrcpyA(catroot2, sysdir); lstrcatA(catroot2, "\\CatRoot2"); - myARGC = winetest_get_mainargs(&myARGV); + winetest_get_mainargs(&myARGV); strcpy(selfname, myARGV[0]); GetCurrentDirectoryA(MAX_PATH, CURR_DIR);
1
0
0
0
Gerald Pfeifer : winex11: Remove variable bits which is not really used from X11DRV_DIB_GetImageBits_32 .
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: 75c738e9e1b4d1b8696b0ac73151b08d533f0257 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=75c738e9e1b4d1b8696b0ac73…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 22:21:52 2010 +0200 winex11: Remove variable bits which is not really used from X11DRV_DIB_GetImageBits_32. --- dlls/winex11.drv/dib.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c index 7a1aad7..4b9c52b 100644 --- a/dlls/winex11.drv/dib.c +++ b/dlls/winex11.drv/dib.c @@ -3184,7 +3184,6 @@ static void X11DRV_DIB_GetImageBits_32( X11DRV_PDEVICE *physDev, int lines, BYTE { DWORD x; int h, width = min(srcwidth, dstwidth); - BYTE *bits; const dib_conversions *convs = (bmpImage->byte_order == LSBFirst) ? &dib_normal : &dib_src_byteswap; if (lines < 0 ) @@ -3194,8 +3193,6 @@ static void X11DRV_DIB_GetImageBits_32( X11DRV_PDEVICE *physDev, int lines, BYTE linebytes = -linebytes; } - bits = dstbits; - switch (bmpImage->depth) { case 24:
1
0
0
0
Gerald Pfeifer : mshtml: Remove variable doc which is not really used from process_timer.
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: d0f1b68416184aed40539a181ce75cadc8c495b3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d0f1b68416184aed40539a181…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 19:19:57 2010 +0200 mshtml: Remove variable doc which is not really used from process_timer. --- dlls/mshtml/task.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/task.c b/dlls/mshtml/task.c index eae51ca..c896179 100644 --- a/dlls/mshtml/task.c +++ b/dlls/mshtml/task.c @@ -222,7 +222,6 @@ static void call_timer_disp(IDispatch *disp) static LRESULT process_timer(void) { thread_data_t *thread_data = get_thread_data(TRUE); - HTMLDocument *doc; IDispatch *disp; DWORD tc; task_timer_t *timer; @@ -238,7 +237,6 @@ static LRESULT process_timer(void) return 0; } - doc = timer->doc; disp = timer->disp; IDispatch_AddRef(disp);
1
0
0
0
Gerald Pfeifer : msi: Remove variable product_code which is not really used from MSI_ApplyPatchW .
by Alexandre Julliard
03 May '10
03 May '10
Module: wine Branch: master Commit: be8d0bbb1e2e604f075e6facdb40ae7f9884fdc9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=be8d0bbb1e2e604f075e6facd…
Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 17:49:14 2010 +0200 msi: Remove variable product_code which is not really used from MSI_ApplyPatchW. --- dlls/msi/msi.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 983c0f5..8d63972 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -304,7 +304,7 @@ static UINT MSI_ApplyPatchW(LPCWSTR szPatchPackage, LPCWSTR szProductCode, LPCWS MSIHANDLE patch = 0, info = 0; UINT r = ERROR_SUCCESS, type; DWORD size = 0; - LPCWSTR cmd_ptr = szCommandLine, product_code = szProductCode; + LPCWSTR cmd_ptr = szCommandLine; LPWSTR beg, end, cmd = NULL, codes = NULL; BOOL succeeded = FALSE; @@ -341,8 +341,6 @@ static UINT MSI_ApplyPatchW(LPCWSTR szPatchPackage, LPCWSTR szProductCode, LPCWS r = MsiSummaryInfoGetPropertyW(info, PID_TEMPLATE, &type, NULL, NULL, codes, &size); if (r != ERROR_SUCCESS) goto done; - - product_code = codes; } if (!szCommandLine)
1
0
0
0
← Newer
1
...
88
89
90
91
92
93
94
95
96
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
Results per page:
10
25
50
100
200